forge-workflow 0.0.9 → 0.0.10

package/scripts/forge-team/tests/sync-github.test.sh

@@ -3,16 +3,17 @@ set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
 
-# ── Setup temp dir for test isolation ────────────────────────────────────
 TEST_TMP="$(mktemp -d)"
 trap 'rm -rf "$TEST_TMP" "$mock_dir"' EXIT
 
-# ── Create mock dir and log file ─────────────────────────────────────────
-mock_dir="$(mktemp -d /c/tmp/forge-sync-test.XXXXXX)"
+mock_dir="$(mktemp -d)"
+portable_bin="$(mktemp -d)"
 log_file="$mock_dir/calls.log"
 touch "$log_file"
+REAL_GREP="$(command -v grep)"
+ORIGINAL_PATH="$PATH"
+export REAL_GREP
 
-# ── Mock gh ──────────────────────────────────────────────────────────────
 cat > "$mock_dir/gh" << 'MOCK'
 #!/usr/bin/env bash
 echo "$*" >> "$LOG_FILE"
@@ -23,45 +24,69 @@ case "$1 $2" in
   "issue comment") echo ""; exit 0 ;;
   "api user") echo "testuser"; exit 0 ;;
 esac
-echo "unknown gh command: $*" >&2; exit 1
+echo "unknown gh command: $*" >&2
+exit 1
 MOCK
 chmod +x "$mock_dir/gh"
 
-# ── Mock bd ──────────────────────────────────────────────────────────────
 cat > "$mock_dir/bd" << 'MOCK'
 #!/usr/bin/env bash
 echo "$*" >> "$LOG_FILE"
 case "$1" in
   show)
-    echo "○ $2 · Test Issue [github_issue:42]"
-    echo "Title: Test Issue"
+    if [[ "${3:-}" == "--json" ]]; then
+      cat <<'JSON'
+{"id":"beads-001","github":{"number":42,"nodeId":"I_kwDOForge42","url":"https://github.com/test/repo/issues/42"},"shared":{"title":"Test Issue"}}
+JSON
+    else
+      echo "o $2 - Test Issue"
+      echo "Title: Test Issue"
+    fi
     ;;
   set-state) echo "State set" ;;
 esac
 MOCK
 chmod +x "$mock_dir/bd"
 
-# ── Mock bd that returns NO github_issue ─────────────────────────────────
 cat > "$mock_dir/bd-no-gh" << 'MOCK'
 #!/usr/bin/env bash
 echo "$*" >> "$LOG_FILE"
 case "$1" in
   show)
-    echo "○ $2 · Test Issue"
-    echo "Title: Test Issue"
+    if [[ "${3:-}" == "--json" ]]; then
+      cat <<'JSON'
+{"id":"beads-999","shared":{"title":"Test Issue"}}
+JSON
+    else
+      echo "o $2 - Test Issue"
+      echo "Title: Test Issue"
+    fi
     ;;
   set-state) echo "State set" ;;
 esac
 MOCK
 chmod +x "$mock_dir/bd-no-gh"
 
-# Export env for mocks
+cat > "$portable_bin/grep" << 'MOCK'
+#!/usr/bin/env bash
+for arg in "$@"; do
+  case "$arg" in
+    -P|--perl-regexp|-*P*)
+      echo "grep: PCRE support disabled for test" >&2
+      exit 2
+      ;;
+  esac
+done
+exec "$REAL_GREP" "$@"
+MOCK
+chmod +x "$portable_bin/grep"
+
 export LOG_FILE="$log_file"
 export GH_CMD="$mock_dir/gh"
 export BD_CMD="$mock_dir/bd"
 export TEAM_MAP_ROOT="$TEST_TMP"
+mapping_file="$TEAM_MAP_ROOT/.github/beads-mapping.json"
 
-# Source the library under test
 source "$SCRIPT_DIR/lib/sync-github.sh"
 
 PASS=0
@@ -70,119 +95,193 @@ FAIL=0
 assert_eq() {
   local label="$1" expected="$2" actual="$3"
   if [[ "$actual" == "$expected" ]]; then
-    PASS=$((PASS + 1)); echo "  PASS: $label"
+    PASS=$((PASS + 1))
+    echo "  PASS: $label"
   else
-    FAIL=$((FAIL + 1)); echo "  FAIL: $label (expected '$expected', got '$actual')"
+    FAIL=$((FAIL + 1))
+    echo "  FAIL: $label (expected '$expected', got '$actual')"
   fi
 }
 
 assert_contains() {
   local label="$1" expected="$2" actual="$3"
   if [[ "$actual" == *"$expected"* ]]; then
-    PASS=$((PASS + 1)); echo "  PASS: $label"
+    PASS=$((PASS + 1))
+    echo "  PASS: $label"
+  else
+    FAIL=$((FAIL + 1))
+    echo "  FAIL: $label (expected to contain '$expected', got '$actual')"
+  fi
+}
+
+assert_not_contains() {
+  local label="$1" unexpected="$2" actual="$3"
+  if [[ "$actual" == *"$unexpected"* ]]; then
+    FAIL=$((FAIL + 1))
+    echo "  FAIL: $label (did not expect '$unexpected', got '$actual')"
   else
-    FAIL=$((FAIL + 1)); echo "  FAIL: $label (expected to contain '$expected', got '$actual')"
+    PASS=$((PASS + 1))
+    echo "  PASS: $label"
   fi
 }
 
 assert_exit() {
   local label="$1" expected="$2" actual="$3"
   if [[ "$actual" -eq "$expected" ]]; then
-    PASS=$((PASS + 1)); echo "  PASS: $label"
+    PASS=$((PASS + 1))
+    echo "  PASS: $label"
   else
-    FAIL=$((FAIL + 1)); echo "  FAIL: $label (expected exit $expected, got $actual)"
+    FAIL=$((FAIL + 1))
+    echo "  FAIL: $label (expected exit $expected, got $actual)"
   fi
 }
 
-# ── Test 1: sync_issue_create — creates GitHub issue, calls bd set-state ─
-echo "── Test 1: sync_issue_create ──"
-> "$log_file"  # clear log
+echo "== Test 1: sync_issue_create =="
+> "$log_file"
 rc=0
 sync_issue_create "beads-001" || rc=$?
 assert_exit "exit code 0" 0 "$rc"
-# Check gh was called with issue create
 log_contents="$(cat "$log_file")"
 assert_contains "gh issue create called" "issue create" "$log_contents"
 assert_contains "title includes Test Issue" "Test Issue" "$log_contents"
 assert_contains "body includes beads-001" "beads-001" "$log_contents"
-# Check bd set-state was called with github_issue=42
-assert_contains "bd set-state called" "set-state" "$log_contents"
-assert_contains "github_issue=42 set" "github_issue=42" "$log_contents"
+assert_contains "sync create writes legacy github_issue state" "github_issue=42" "$log_contents"
+assert_contains "sync create calls set-state for hook compatibility" "set-state" "$log_contents"
+assert_contains "sync create persists mapping entry" '"42": "beads-001"' "$(cat "$mapping_file")"
 
-# ── Test 2: sync_issue_claim — updates GitHub assignee ───────────────────
-echo ""
-echo "── Test 2: sync_issue_claim ──"
+echo
+echo "== Test 2: sync_issue_claim =="
 > "$log_file"
 unset _GITHUB_USER_CACHE
 rc=0
 sync_issue_claim "beads-001" || rc=$?
 assert_exit "exit code 0" 0 "$rc"
 log_contents="$(cat "$log_file")"
+assert_contains "canonical lookup uses --json" "--json" "$log_contents"
 assert_contains "gh issue edit called" "issue edit" "$log_contents"
 assert_contains "add-assignee used" "--add-assignee" "$log_contents"
 assert_contains "assignee is testuser" "testuser" "$log_contents"
 
-# ── Test 3: sync_issue_status — removes old labels, adds new one ─────────
-echo ""
-echo "── Test 3: sync_issue_status ──"
+echo
+echo "== Test 3: sync_issue_status =="
 > "$log_file"
 rc=0
 sync_issue_status "beads-001" "in_progress" || rc=$?
 assert_exit "exit code 0" 0 "$rc"
 log_contents="$(cat "$log_file")"
+assert_contains "canonical lookup uses --json" "--json" "$log_contents"
 assert_contains "gh issue edit called" "issue edit" "$log_contents"
 assert_contains "removes status/open" "--remove-label status/open" "$log_contents"
 assert_contains "adds status/in-progress" "--add-label status/in-progress" "$log_contents"
 
-# ── Test 4: sync_issue_close — closes GitHub issue ───────────────────────
-echo ""
-echo "── Test 4: sync_issue_close ──"
+echo
+echo "== Test 4: sync_issue_close =="
 > "$log_file"
 rc=0
 sync_issue_close "beads-001" || rc=$?
 assert_exit "exit code 0" 0 "$rc"
 log_contents="$(cat "$log_file")"
+assert_contains "canonical lookup uses --json" "--json" "$log_contents"
 assert_contains "gh issue close called" "issue close" "$log_contents"
 assert_contains "closes issue 42" " 42" "$log_contents"
 
-# ── Test 5: sync_issue_deps — adds comment on GitHub issue ───────────────
-echo ""
-echo "── Test 5: sync_issue_deps ──"
+echo
+echo "== Test 5: sync_issue_deps =="
 > "$log_file"
 rc=0
 sync_issue_deps "beads-001" "beads-002" || rc=$?
 assert_exit "exit code 0" 0 "$rc"
 log_contents="$(cat "$log_file")"
+assert_contains "canonical lookup uses --json" "--json" "$log_contents"
 assert_contains "gh issue comment called" "issue comment" "$log_contents"
 assert_contains "Blocked by referenced" "Blocked by #42" "$log_contents"
 
-# ── Test 6: _get_github_issue_number — extracts number from bd show ──────
-echo ""
-echo "── Test 6: _get_github_issue_number ──"
+echo
+echo "== Test 6: _get_github_issue_number =="
 result="$(_get_github_issue_number "beads-001")"
 assert_eq "extracts issue number 42" "42" "$result"
+log_contents="$(cat "$log_file")"
+assert_contains "_get_github_issue_number uses JSON" "--json" "$log_contents"
 
-# ── Test 7: Missing GitHub issue number → returns error ──────────────────
-echo ""
-echo "── Test 7: Missing GitHub issue number ──"
+echo
+echo "== Test 7: Mapping fallback when canonical GitHub number missing =="
+mkdir -p "$(dirname "$mapping_file")"
+cat > "$mapping_file" << 'JSON'
+{
+  "77": "beads-999"
+}
+JSON
+export BD_CMD="$mock_dir/bd-no-gh"
+result="$(_get_github_issue_number "beads-999")"
+assert_eq "mapping fallback returns issue number 77" "77" "$result"
+export BD_CMD="$mock_dir/bd"
+
+echo
+echo "== Test 8: Mapping fallback returns newest issue number =="
+cat > "$mapping_file" << 'JSON'
+{
+  "77": "beads-999",
+  "91": "beads-999",
+  "88": "beads-other"
+}
+JSON
+export BD_CMD="$mock_dir/bd-no-gh"
+result="$(_get_github_issue_number "beads-999")"
+assert_eq "mapping fallback returns newest matching issue number" "91" "$result"
+export BD_CMD="$mock_dir/bd"
+
+echo
+echo "== Test 9: Missing canonical GitHub number =="
+rm -f "$mapping_file"
 export BD_CMD="$mock_dir/bd-no-gh"
 rc=0
 result="$(_get_github_issue_number "beads-999" 2>/dev/null)" || rc=$?
-assert_exit "returns error when no github_issue" 1 "$rc"
-# Restore normal bd mock
+assert_exit "returns error when no canonical github number" 1 "$rc"
+export BD_CMD="$mock_dir/bd"
+
+echo
+echo "== Test 10: Legacy github_issue state fallback =="
+cat > "$mock_dir/bd-legacy" << 'MOCK'
+#!/usr/bin/env bash
+echo "$*" >> "$LOG_FILE"
+case "$1" in
+  show)
+    if [[ "${3:-}" == "--json" ]]; then
+      cat <<'JSON'
+{"id":"beads-legacy","github_issue":43,"shared":{"title":"Legacy Issue"}}
+JSON
+    else
+      echo "o $2 - Legacy Issue"
+      echo "github_issue:43"
+      echo "Title: Legacy Issue"
+    fi
+    ;;
+  set-state) echo "State set" ;;
+esac
+MOCK
+chmod +x "$mock_dir/bd-legacy"
+export BD_CMD="$mock_dir/bd-legacy"
+rc=0
+result="$(_get_github_issue_number "beads-legacy" 2>/dev/null)" || rc=$?
+assert_exit "legacy github_issue exits successfully" 0 "$rc"
+assert_eq "legacy github_issue returns number" "43" "$result"
 export BD_CMD="$mock_dir/bd"
 
-# ── Test 8: Injection in issue title → sanitized before gh call ──────────
-echo ""
-echo "── Test 8: Injection in title sanitized ──"
-# Create a bd mock that returns injection-laden title
+echo
+echo "== Test 11: Injection in title sanitized =="
 cat > "$mock_dir/bd-inject" << 'MOCK'
 #!/usr/bin/env bash
 echo "$*" >> "$LOG_FILE"
 case "$1" in
   show)
-    echo '○ beads-inject · Evil $(rm -rf /) Issue [github_issue:99]'
-    echo 'Title: Evil $(rm -rf /) Issue'
+    if [[ "${3:-}" == "--json" ]]; then
+      cat <<'JSON'
+{"id":"beads-inject","github":{"number":99,"url":"https://github.com/test/repo/issues/99"},"shared":{"title":"Evil $(rm -rf /) Issue"}}
+JSON
+    else
+      echo 'o beads-inject - Evil $(rm -rf /) Issue'
+      echo 'Title: Evil $(rm -rf /) Issue'
+    fi
     ;;
   set-state) echo "State set" ;;
 esac
@@ -194,16 +293,54 @@ rc=0
 sync_issue_create "beads-inject" || rc=$?
 assert_exit "exit code 0 with injection" 0 "$rc"
 log_contents="$(cat "$log_file")"
-# The $(...) pattern must NOT appear in the gh call
 if [[ "$log_contents" == *'$(rm'* ]]; then
-  FAIL=$((FAIL + 1)); echo "  FAIL: injection NOT sanitized — \$(rm found in gh call"
+  FAIL=$((FAIL + 1))
+  echo "  FAIL: injection NOT sanitized - \$\(rm found in gh call"
 else
-  PASS=$((PASS + 1)); echo "  PASS: injection sanitized — no \$(rm in gh call"
+  PASS=$((PASS + 1))
+  echo "  PASS: injection sanitized - no \$\(rm in gh call"
 fi
-# Restore normal bd mock
 export BD_CMD="$mock_dir/bd"
 
-# ── Results ──────────────────────────────────────────────────────────────
-echo ""
+echo
+echo "== Test 11: sync_issue_create without grep -P =="
+export PATH="$portable_bin:$ORIGINAL_PATH"
+> "$log_file"
+rc=0
+sync_issue_create "beads-001" || rc=$?
+assert_exit "sync_issue_create works when grep -P is unavailable" 0 "$rc"
+log_contents="$(cat "$log_file")"
+assert_contains "gh issue create called without PCRE grep" "issue create" "$log_contents"
+export PATH="$ORIGINAL_PATH"
+
+echo
+echo "== Test 12: sync_issue_create with summary-only bd show =="
+cat > "$mock_dir/bd-summary-only" << 'MOCK'
+#!/usr/bin/env bash
+echo "$*" >> "$LOG_FILE"
+case "$1" in
+  show)
+    if [[ "${3:-}" == "--json" ]]; then
+      cat <<'JSON'
+{"id":"beads-summary","github":{"number":77,"url":"https://github.com/test/repo/issues/77"},"shared":{"title":"Summary Only Title"}}
+JSON
+    else
+      echo "o $2 - Summary Only Title"
+    fi
+    ;;
+  set-state) echo "State set" ;;
+esac
+MOCK
+chmod +x "$mock_dir/bd-summary-only"
+export BD_CMD="$mock_dir/bd-summary-only"
+> "$log_file"
+rc=0
+sync_issue_create "beads-summary" || rc=$?
+assert_exit "sync_issue_create works with summary-only bd show" 0 "$rc"
+log_contents="$(cat "$log_file")"
+assert_contains "summary-only title is passed to gh issue create" "Summary Only Title" "$log_contents"
+export BD_CMD="$mock_dir/bd"
+
+echo
 echo "Results: $PASS passed, $FAIL failed"
 [[ $FAIL -eq 0 ]] && exit 0 || exit 1