forge-workflow 0.0.5 → 0.0.6

package/scripts/forge-team/tests/workload.test.sh

@@ -0,0 +1,209 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+
+# ── Setup temp dir for test isolation ────────────────────────────────────
+TEST_TMP="$(mktemp -d)"
+trap 'rm -rf "$TEST_TMP"' EXIT
+
+# Override TEAM_MAP_ROOT so tests don't touch real .beads/
+export TEAM_MAP_ROOT="$TEST_TMP"
+
+# Fix "now" so stale detection is deterministic
+# forge-bbb updated 2026-03-25T10:00:00Z → 50h ago at this fixed time
+export WORKLOAD_NOW="2026-03-27T12:00:00Z"
+
+# ── Create mock gh ───────────────────────────────────────────────────────
+mock_dir="$(mktemp -d)"
+
+cat > "$mock_dir/gh" << 'MOCK'
+#!/usr/bin/env bash
+case "$1 $2" in
+  "api user")
+    echo "devone"
+    ;;
+esac
+MOCK
+chmod +x "$mock_dir/gh"
+
+# ── Create mock bd ───────────────────────────────────────────────────────
+cat > "$mock_dir/bd" << 'MOCK'
+#!/usr/bin/env bash
+case "$1 $2" in
+  "list --status=open,in_progress")
+    echo "◐ forge-aaa · Feature A"
+    echo "○ forge-bbb · Feature B"
+    echo "◐ forge-ccc · Feature C"
+    ;;
+  "show forge-aaa")
+    echo "◐ forge-aaa · Feature A [● P2 · IN_PROGRESS]"
+    echo "Owner: devone"
+    echo "Updated: 2026-03-27T10:00:00Z"
+    ;;
+  "show forge-bbb")
+    echo "○ forge-bbb · Feature B [● P2 · OPEN]"
+    echo "Owner: devtwo"
+    echo "Updated: 2026-03-25T10:00:00Z"
+    ;;
+  "show forge-ccc")
+    echo "◐ forge-ccc · Feature C [● P1 · IN_PROGRESS]"
+    echo "Owner: devone"
+    echo "Updated: 2026-03-27T09:00:00Z"
+    echo ""
+    echo "DEPENDS ON"
+    echo "  → forge-aaa: Feature A"
+    ;;
+esac
+MOCK
+chmod +x "$mock_dir/bd"
+
+# ── Create mock bd with no issues ────────────────────────────────────────
+cat > "$mock_dir/bd-empty" << 'MOCK'
+#!/usr/bin/env bash
+case "$1 $2" in
+  "list --status=open,in_progress")
+    echo ""
+    ;;
+esac
+MOCK
+chmod +x "$mock_dir/bd-empty"
+
+export GH_CMD="$mock_dir/gh"
+export BD_CMD="$mock_dir/bd"
+
+# Source the library under test
+source "$SCRIPT_DIR/lib/workload.sh"
+
+PASS=0
+FAIL=0
+
+assert_eq() {
+  local label="$1" expected="$2" actual="$3"
+  if [[ "$actual" == "$expected" ]]; then
+    PASS=$((PASS + 1)); echo "  PASS: $label"
+  else
+    FAIL=$((FAIL + 1)); echo "  FAIL: $label (expected '$expected', got '$actual')"
+  fi
+}
+
+assert_contains() {
+  local label="$1" expected="$2" actual="$3"
+  if [[ "$actual" == *"$expected"* ]]; then
+    PASS=$((PASS + 1)); echo "  PASS: $label"
+  else
+    FAIL=$((FAIL + 1)); echo "  FAIL: $label (expected to contain '$expected', got '$actual')"
+  fi
+}
+
+assert_not_contains() {
+  local label="$1" unexpected="$2" actual="$3"
+  if [[ "$actual" != *"$unexpected"* ]]; then
+    PASS=$((PASS + 1)); echo "  PASS: $label"
+  else
+    FAIL=$((FAIL + 1)); echo "  FAIL: $label (expected NOT to contain '$unexpected', got '$actual')"
+  fi
+}
+
+assert_exit() {
+  local label="$1" expected="$2" actual="$3"
+  if [[ "$actual" -eq "$expected" ]]; then
+    PASS=$((PASS + 1)); echo "  PASS: $label"
+  else
+    FAIL=$((FAIL + 1)); echo "  FAIL: $label (expected exit $expected, got $actual)"
+  fi
+}
+
+# ── Test 1: All developers shown with grouped issues ─────────────────────
+echo "── Test 1: All developers shown with grouped issues ──"
+unset _GITHUB_USER_CACHE
+rc=0
+output="$(cmd_workload 2>/dev/null)" || rc=$?
+assert_exit "exits 0" 0 "$rc"
+assert_contains "shows devone header" "Developer: devone" "$output"
+assert_contains "shows devtwo header" "Developer: devtwo" "$output"
+assert_contains "shows forge-aaa" "forge-aaa" "$output"
+assert_contains "shows forge-bbb" "forge-bbb" "$output"
+assert_contains "shows forge-ccc" "forge-ccc" "$output"
+
+# ── Test 2: --developer=devone filters correctly ─────────────────────────
+echo ""
+echo "── Test 2: --developer=devone filters correctly ──"
+unset _GITHUB_USER_CACHE
+rc=0
+output="$(cmd_workload --developer=devone 2>/dev/null)" || rc=$?
+assert_exit "exits 0" 0 "$rc"
+assert_contains "shows devone" "Developer: devone" "$output"
+assert_not_contains "excludes devtwo" "Developer: devtwo" "$output"
+assert_contains "shows forge-aaa" "forge-aaa" "$output"
+assert_contains "shows forge-ccc" "forge-ccc" "$output"
+assert_not_contains "excludes forge-bbb" "forge-bbb" "$output"
+
+# ── Test 3: --me uses get_github_user() to filter ────────────────────────
+echo ""
+echo "── Test 3: --me uses get_github_user() to filter ──"
+unset _GITHUB_USER_CACHE
+rc=0
+output="$(cmd_workload --me 2>/dev/null)" || rc=$?
+assert_exit "exits 0" 0 "$rc"
+assert_contains "shows devone (current user)" "Developer: devone" "$output"
+assert_not_contains "excludes devtwo" "Developer: devtwo" "$output"
+
+# ── Test 4: No issues → "No active work" ─────────────────────────────────
+echo ""
+echo "── Test 4: No issues → No active work ──"
+unset _GITHUB_USER_CACHE
+export BD_CMD="$mock_dir/bd-empty"
+rc=0
+output="$(cmd_workload 2>/dev/null)" || rc=$?
+assert_exit "exits 0" 0 "$rc"
+assert_contains "shows no active work message" "No active work" "$output"
+export BD_CMD="$mock_dir/bd"
+
+# ── Test 5: Stale assignment flagged (>48h) ──────────────────────────────
+echo ""
+echo "── Test 5: Stale assignment flagged (>48h) ──"
+unset _GITHUB_USER_CACHE
+rc=0
+output="$(cmd_workload 2>/dev/null)" || rc=$?
+assert_exit "exits 0" 0 "$rc"
+# forge-bbb was updated 2026-03-25T10:00:00Z, which is >48h ago from "now"
+assert_contains "stale flag on forge-bbb" "stale:" "$output"
+
+# ── Test 6: --format=json returns valid JSON ─────────────────────────────
+echo ""
+echo "── Test 6: --format=json returns valid JSON ──"
+unset _GITHUB_USER_CACHE
+rc=0
+output="$(cmd_workload --format=json 2>/dev/null)" || rc=$?
+assert_exit "exits 0" 0 "$rc"
+# Validate it's parseable JSON
+if echo "$output" | jq . >/dev/null 2>&1; then
+  PASS=$((PASS + 1)); echo "  PASS: output is valid JSON"
+else
+  FAIL=$((FAIL + 1)); echo "  FAIL: output is not valid JSON: $output"
+fi
+# Check JSON has developer keys
+if echo "$output" | jq -e '.devone' >/dev/null 2>&1; then
+  PASS=$((PASS + 1)); echo "  PASS: JSON contains devone key"
+else
+  FAIL=$((FAIL + 1)); echo "  FAIL: JSON missing devone key"
+fi
+if echo "$output" | jq -e '.devtwo' >/dev/null 2>&1; then
+  PASS=$((PASS + 1)); echo "  PASS: JSON contains devtwo key"
+else
+  FAIL=$((FAIL + 1)); echo "  FAIL: JSON missing devtwo key"
+fi
+
+# ── Test 7: Blocked issue flagged ─────────────────────────────────────────
+echo ""
+echo "── Test 7: Blocked issue flagged ──"
+unset _GITHUB_USER_CACHE
+rc=0
+output="$(cmd_workload 2>/dev/null)" || rc=$?
+assert_contains "blocked flag on forge-ccc" "blocked by forge-aaa" "$output"
+
+# ── Results ──────────────────────────────────────────────────────────────
+echo ""
+echo "Results: $PASS passed, $FAIL failed"
+[[ $FAIL -eq 0 ]] && exit 0 || exit 1

package/scripts/lib/eval-runner.js

@@ -11,6 +11,42 @@
 const path = require('path');
 const { execSync } = require('node:child_process');
 
+// ── active worktree tracking (cleanup on crash) ─────────────────────
+// Tracks active eval worktrees so we can clean up on process exit/crash.
+// Prevents orphaned eval-* branches when interrupted.
+// Note: execSync is safe here — all paths are internally generated, never user input.
+const activeEvalWorktrees = new Map(); // path -> branch
+
+function cleanupActiveWorktrees() {
+  if (activeEvalWorktrees.size === 0) return;
+  let repoRoot;
+  try { repoRoot = getRepoRoot(); } catch (_err) { return; }
+  for (const [wtPath, branch] of activeEvalWorktrees) {
+    try {
+      execSync(`git worktree remove --force "${wtPath}"`, { cwd: repoRoot, stdio: 'pipe' });
+    } catch (_err) { /* already removed */ }
+    if (branch && branch.startsWith('eval-')) {
+      try {
+        execSync(`git branch -D "${branch}"`, { cwd: repoRoot, stdio: 'pipe' });
+      } catch (_err) { /* already deleted */ }
+    }
+  }
+  try { execSync('git worktree prune', { cwd: repoRoot, stdio: 'pipe' }); } catch (_err) { /* ignore */ }
+  activeEvalWorktrees.clear();
+}
+
+process.on('exit', cleanupActiveWorktrees);
+process.on('SIGINT', () => {
+  const hadWork = activeEvalWorktrees.size > 0;
+  cleanupActiveWorktrees();
+  if (hadWork) process.exit(130);
+});
+process.on('SIGTERM', () => {
+  const hadWork = activeEvalWorktrees.size > 0;
+  cleanupActiveWorktrees();
+  if (hadWork) process.exit(143);
+});
+
 // ── helpers ──────────────────────────────────────────────────────────
 
 /**
@@ -56,6 +92,7 @@ async function createEvalWorktree() {
     stdio: ['pipe', 'pipe', 'pipe'],
   });
 
+  activeEvalWorktrees.set(wtPath, branch);
   return { path: wtPath, branch };
 }
 
@@ -98,6 +135,8 @@ async function destroyEvalWorktree(worktreePath) {
     stdio: ['pipe', 'pipe', 'pipe'],
   });
 
+  activeEvalWorktrees.delete(worktreePath);
+
   // Delete the temporary branch (force in case it's not fully merged)
   if (branch && branch.startsWith('eval-')) {
     try {

package/scripts/lib/jsonl-lock.sh

@@ -0,0 +1,48 @@
+#!/usr/bin/env bash
+# scripts/lib/jsonl-lock.sh — Atomic JSONL append with file locking
+#
+# Provides atomic_jsonl_append() for concurrent-safe JSONL file writes.
+# Cross-platform: uses flock on Linux/WSL/Git Bash, mkdir-based fallback on macOS.
+#
+# Usage (source this file):
+#   source scripts/lib/jsonl-lock.sh
+#   atomic_jsonl_append "/path/to/file.jsonl" '{"key":"value"}'
+#
+# Exit codes: 0=success, 1=lock timeout or write failure
+# Lock timeout: 5 seconds
+
+# atomic_jsonl_append <jsonl_file> <json_line>
+# Appends a JSON line to a JSONL file with file locking.
+# Lock file: <jsonl_file>.lock (flock) or <jsonl_file>.lock.d (mkdir)
+# Timeout: 5 seconds
+# Exit codes: 0=success, 1=lock timeout or write failure
+atomic_jsonl_append() {
+  local jsonl_file="$1"
+  local json_line="$2"
+
+  mkdir -p "$(dirname "$jsonl_file")"
+
+  if command -v flock &>/dev/null; then
+    # flock-based locking (Linux, WSL, Git Bash)
+    local lock_file="${jsonl_file}.lock"
+    (
+      flock -w 5 200 || { echo "Error: JSONL lock timeout after 5s" >&2; return 1; }
+      printf '%s\n' "$json_line" >> "$jsonl_file"
+    ) 200>"$lock_file"
+  else
+    # mkdir-based fallback (macOS, systems without flock)
+    local lock_file="${jsonl_file}.lock.d"
+    local attempts=0
+    while ! mkdir "$lock_file" 2>/dev/null; do
+      attempts=$((attempts + 1))
+      if [[ $attempts -ge 50 ]]; then  # 50 * 0.1s = 5s timeout
+        echo "Error: JSONL lock timeout after 5s" >&2
+        return 1
+      fi
+      sleep 0.1
+    done
+    # RETURN trap handles cleanup on both success and failure
+    trap 'rmdir "$lock_file" 2>/dev/null; trap - RETURN' RETURN
+    printf '%s\n' "$json_line" >> "$jsonl_file"
+  fi
+}

package/scripts/lib/sanitize.sh

@@ -0,0 +1,116 @@
+#!/usr/bin/env bash
+# sanitize.sh — Shared input sanitization and validation library.
+#
+# Extracted from file-index.sh, dep-guard.sh, beads-context.sh, sync-utils.sh
+# to eliminate duplication. Source this file; do NOT run it directly.
+#
+# Functions:
+#   sanitize              <string>    Strip shell-injection patterns (OWASP A03)
+#   sanitize_config_value <string>    Strip injection + pipes, trim whitespace
+#   validate_branch_name  <string>    Validate git branch name format
+#   validate_pr_number    <string>    Validate GitHub PR number (digits only)
+#   validate_label_name   <string>    Validate GitHub label format
+#
+# This file does NOT set errexit/pipefail — callers manage their own shell options.
+# OWASP A03: All inputs validated and shell-injection patterns stripped.
+
+# Guard against double-sourcing
+if [[ -n "${_SANITIZE_LIB_LOADED:-}" ]]; then
+  return 0 2>/dev/null || true
+fi
+_SANITIZE_LIB_LOADED=1
+
+# ── sanitize ──────────────────────────────────────────────────────────────
+# Sanitize a string: strip shell-injection patterns (OWASP A03).
+# Removes: double quotes, $(...), backticks, semicolons, and newlines.
+# Usage: clean="$(sanitize "$raw")"
+sanitize() {
+  local val="$1"
+  # Remove double quotes
+  val="${val//\"/}"
+  # Remove $(...) command substitution patterns (loop handles nested)
+  val="$(printf '%s' "$val" | sed -e ':loop' -e 's/\$([^()]*)//g' -e 't loop')"
+  # Remove backtick command substitution
+  val="${val//\`/}"
+  # Remove semicolons (command chaining)
+  val="${val//;/}"
+  # Replace newlines with spaces
+  val="$(printf '%s' "$val" | tr '\n' ' ')"
+  printf '%s' "$val"
+}
+
+# ── sanitize_config_value ────────────────────────────────────────────────
+# Sanitize a config value: strip shell-injection patterns + pipes (OWASP A03).
+# Removes: backticks, $(...), semicolons, pipes, newlines. Trims whitespace.
+# Usage: clean="$(sanitize_config_value "$raw")"
+sanitize_config_value() {
+  local val="$1"
+  # Remove backtick command substitution
+  val="${val//\`/}"
+  # Remove $(...) command substitution patterns (loop handles nested)
+  val="$(printf '%s' "$val" | sed -e ':loop' -e 's/\$([^()]*)//g' -e 't loop')"
+  # Remove semicolons (command chaining)
+  val="${val//;/}"
+  # Remove pipes (command chaining)
+  val="${val//|/}"
+  # Collapse newlines to spaces
+  val="$(printf '%s' "$val" | tr '\n' ' ')"
+  # Trim leading/trailing whitespace
+  val="$(printf '%s' "$val" | sed -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//')"
+  printf '%s' "$val"
+}
+
+# ── validate_branch_name ─────────────────────────────────────────────────
+# Validate a git branch name.
+# Allowed: alphanumeric, dots, hyphens, underscores, forward slashes, @
+# Usage: validate_branch_name "feat/my-feature" || exit 1
+validate_branch_name() {
+  local name="${1:-}"
+  if [[ -z "$name" ]]; then
+    echo "Error: branch name cannot be empty" >&2
+    return 1
+  fi
+  if [[ ! "$name" =~ ^[a-zA-Z0-9._/@-]+$ ]]; then
+    echo "Error: invalid branch name format: $name" >&2
+    return 1
+  fi
+  # Git rejects: double dots (..), trailing .lock, leading/trailing slash, leading hyphen
+  if [[ "$name" == *..* ]] || [[ "$name" == *.lock ]] || [[ "$name" == /* ]] || [[ "$name" == */ ]] || [[ "$name" == -* ]]; then
+    echo "Error: invalid branch name (contains .., .lock suffix, leading/trailing /, or leading -): $name" >&2
+    return 1
+  fi
+  return 0
+}
+
+# ── validate_pr_number ───────────────────────────────────────────────────
+# Validate a GitHub PR number (digits only).
+# Usage: validate_pr_number "42" || exit 1
+validate_pr_number() {
+  local num="${1:-}"
+  if [[ -z "$num" ]]; then
+    echo "Error: PR number cannot be empty" >&2
+    return 1
+  fi
+  if [[ ! "$num" =~ ^[0-9]+$ ]]; then
+    echo "Error: invalid PR number format: $num" >&2
+    return 1
+  fi
+  return 0
+}
+
+# ── validate_label_name ──────────────────────────────────────────────────
+# Validate a GitHub label name.
+# Allowed: alphanumeric, dots, hyphens, underscores, forward slashes
+# Usage: validate_label_name "forge/has-deps" || exit 1
+validate_label_name() {
+  local name="${1:-}"
+  if [[ -z "$name" ]]; then
+    echo "Error: label name cannot be empty" >&2
+    return 1
+  fi
+  if [[ ! "$name" =~ ^[a-zA-Z0-9._/-]+$ ]]; then
+    echo "Error: invalid label name format: $name" >&2
+    return 1
+  fi
+  return 0
+}