forge-orkes 0.71.0 → 0.72.2

package/template/.forge/checks/tests/forge-reserve.test.sh

@@ -0,0 +1,235 @@
+#!/usr/bin/env sh
+# Fixture-repo test suite for .claude/hooks/forge-reserve.sh (m-41, plan 81-01).
+#
+# Contract under test (ADR-021/023/029 + FR-236/237/238, NFR-045):
+#   phase  — computed P-0NN; in-tree scan = live roadmap `- id: N` ints ∪ archived
+#            phase dirs .forge/archive/milestone-*/phases/<N>-* (burned ids never
+#            reallocated); ledger + main:reservations.yml floors as for all kinds.
+#   wave   — computed W-0NN; in-tree scan = live waves-map KEYS only (never the
+#            phase ids inside the brackets).
+#   version — RECORD-ONLY (--value): clean claim dual-writes ledger +
+#            reservations.yml and echoes the value; the SAME value claimed by a
+#            DIFFERENT milestone → exit 1, stderr names the holder, nothing
+#            written; re-claim by the SAME milestone → exit 0, idempotent, no
+#            duplicate line; missing --value → usage exit 2, nothing written.
+#   regression (NFR-045) — the pre-existing kinds' ids and file shapes are
+#            unchanged; the lock releases so back-to-back calls never time out.
+#
+# Every case builds its own mktemp fixture repo (real `git init`) — the suite
+# never touches the enclosing dev repo's state. Output: one line per case,
+# `case N <tag> PASS` or `case N <tag> FAIL: <why>`; non-zero exit if any FAIL.
+#
+# Usage: sh .forge/checks/tests/forge-reserve.test.sh
+set -u
+
+SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
+RESERVE="$SCRIPT_DIR/../../../.claude/hooks/forge-reserve.sh"
+[ -f "$RESERVE" ] || { printf 'FATAL: %s missing\n' "$RESERVE" >&2; exit 1; }
+
+GIT_CONFIG_GLOBAL=/dev/null GIT_CONFIG_SYSTEM=/dev/null
+export GIT_CONFIG_GLOBAL GIT_CONFIG_SYSTEM
+
+ROOT="$(mktemp -d)"
+trap 'rm -rf "$ROOT"' EXIT INT TERM
+
+fails=0
+n=0
+
+# new_fixture <name> → prints the fixture repo path
+new_fixture() {
+  fx="$ROOT/$1"
+  mkdir -p "$fx"
+  git -C "$fx" init -q
+  printf '%s' "$fx"
+}
+
+report() { # report <tag> <pass|fail> [why]
+  n=$((n + 1))
+  if [ "$2" = pass ]; then
+    printf 'case %d %s PASS\n' "$n" "$1"
+  else
+    printf 'case %d %s FAIL: %s\n' "$n" "$1" "${3:-unspecified}"
+    fails=$((fails + 1))
+  fi
+}
+
+# ── FR-236: phase kind ────────────────────────────────────────────────────────
+
+# case 1 phase-archive-aware — roadmap max 12, archived phase dir 14 → P-015
+fx=$(new_fixture c1)
+mkdir -p "$fx/.forge/archive/milestone-9/phases/14-old"
+printf 'roadmap:\n  phases:\n    - id: 11\n    - id: 12\n' > "$fx/.forge/roadmap.yml"
+out=$(cd "$fx" && "$RESERVE" phase --milestone m-t 2>/dev/null)
+if [ "$out" = "P-015" ]; then report phase-archive-aware pass
+else report phase-archive-aware fail "expected P-015 (archived 14 must stay burned), got: $out"; fi
+
+# case 2 phase-dual-write — case 1's claim landed in BOTH registries
+if grep -q "phase	P-015	m-t" "$fx/.git/forge/id-reservations" 2>/dev/null \
+   && grep -q "id: P-015" "$fx/.forge/reservations.yml" 2>/dev/null; then
+  report phase-dual-write pass
+else report phase-dual-write fail "P-015 missing from ledger or reservations.yml"; fi
+
+# case 3 phase-sibling-ledger — uncommitted sibling ledger claim is visible
+fx=$(new_fixture c3)
+mkdir -p "$fx/.forge" "$fx/.git/forge"
+printf 'roadmap:\n  phases:\n    - id: 12\n' > "$fx/.forge/roadmap.yml"
+printf 'phase\tP-015\tm-sib\t2026-07-23T00:00:00Z\n' >> "$fx/.git/forge/id-reservations"
+out=$(cd "$fx" && "$RESERVE" phase --milestone m-t 2>/dev/null)
+if [ "$out" = "P-016" ]; then report phase-sibling-ledger pass
+else report phase-sibling-ledger fail "sibling claim P-015 ignored — expected P-016, got: $out"; fi
+
+# case 4 phase-fresh — no roadmap, no archive → P-001
+fx=$(new_fixture c4)
+out=$(cd "$fx" && "$RESERVE" phase --milestone m-t 2>/dev/null)
+if [ "$out" = "P-001" ]; then report phase-fresh pass
+else report phase-fresh fail "fresh repo expected P-001, got: $out"; fi
+
+# case 5 phase-wave-keys-not-counted — waves KEYS and bracket ids must not leak
+# into the phase max: roadmap phase max 3, waves key 9 pointing at [3] → P-004.
+fx=$(new_fixture c5)
+mkdir -p "$fx/.forge"
+printf 'roadmap:\n  phases:\n    - id: 3\n  waves:\n    9: [3]\n' > "$fx/.forge/roadmap.yml"
+out=$(cd "$fx" && "$RESERVE" phase --milestone m-t 2>/dev/null)
+if [ "$out" = "P-004" ]; then report phase-wave-keys-not-counted pass
+else report phase-wave-keys-not-counted fail "expected P-004 (wave key 9 is not a phase id), got: $out"; fi
+
+# ── FR-237: wave kind ────────────────────────────────────────────────────────
+
+# case 6 wave-max-key — waves keys 1,7 (bracket ids larger) → W-008
+fx=$(new_fixture c6)
+mkdir -p "$fx/.forge"
+printf 'roadmap:\n  phases:\n    - id: 1\n  waves:\n    1: [40]\n    7: [41]\n' > "$fx/.forge/roadmap.yml"
+out=$(cd "$fx" && "$RESERVE" wave --milestone m-t 2>/dev/null)
+if [ "$out" = "W-008" ]; then report wave-max-key pass
+else report wave-max-key fail "expected W-008 (max KEY 7, ids in brackets ignored), got: $out"; fi
+
+# case 7 wave-fresh — no waves block anywhere → W-001
+fx=$(new_fixture c7)
+out=$(cd "$fx" && "$RESERVE" wave --milestone m-t 2>/dev/null)
+if [ "$out" = "W-001" ]; then report wave-fresh pass
+else report wave-fresh fail "expected W-001, got: $out"; fi
+
+# ── FR-238: version kind (record-only) ───────────────────────────────────────
+
+# case 8 version-clean-claim — records in BOTH registries, echoes the value
+fx=$(new_fixture c8)
+out=$(cd "$fx" && "$RESERVE" version --value 0.9.0 --milestone m-a 2>/dev/null)
+if [ "$out" = "0.9.0" ] \
+   && grep -q "version	0.9.0	m-a" "$fx/.git/forge/id-reservations" 2>/dev/null \
+   && grep -q 'id: 0.9.0' "$fx/.forge/reservations.yml" 2>/dev/null; then
+  report version-clean-claim pass
+else report version-clean-claim fail "claim not recorded in both registries (stdout: $out)"; fi
+
+# case 9 version-conflict-refused — different milestone, same value → exit 1,
+# stderr names the holder, NOTHING written
+err=$(cd "$fx" && "$RESERVE" version --value 0.9.0 --milestone m-b 2>&1 >/dev/null)
+rc=$?
+lines=$(grep -c '^version' "$fx/.git/forge/id-reservations" 2>/dev/null)
+case "$err" in
+  *m-a*) named=yes ;;
+  *) named=no ;;
+esac
+if [ "$rc" -ne 0 ] && [ "$named" = yes ] && [ "$lines" = "1" ]; then
+  report version-conflict-refused pass
+else report version-conflict-refused fail "rc=$rc named-holder=$named ledger-version-lines=$lines (want rc!=0, holder m-a named, 1 line)"; fi
+
+# case 10 version-idempotent-reclaim — same milestone re-claims → exit 0, no dup
+out=$(cd "$fx" && "$RESERVE" version --value 0.9.0 --milestone m-a 2>/dev/null)
+rc=$?
+lines=$(grep -c '^version' "$fx/.git/forge/id-reservations" 2>/dev/null)
+if [ "$rc" -eq 0 ] && [ "$out" = "0.9.0" ] && [ "$lines" = "1" ]; then
+  report version-idempotent-reclaim pass
+else report version-idempotent-reclaim fail "rc=$rc stdout=$out ledger-version-lines=$lines (want 0 / 0.9.0 / 1)"; fi
+
+# case 11 version-missing-value — usage exit 2, nothing written
+fx=$(new_fixture c11)
+err=$(cd "$fx" && "$RESERVE" version --milestone m-a 2>&1 >/dev/null)
+rc=$?
+if [ "$rc" -eq 2 ] && [ ! -f "$fx/.git/forge/id-reservations" ] && [ ! -f "$fx/.forge/reservations.yml" ]; then
+  report version-missing-value pass
+else report version-missing-value fail "rc=$rc (want 2) or files written on usage error"; fi
+
+# ── NFR-045: existing kinds regression + lock release ────────────────────────
+
+# case 12 regression-existing-kinds — fr x2 / milestone / refactor sequence and
+# reservations.yml shape identical to pre-m-41 behavior
+fx=$(new_fixture c12)
+a=$(cd "$fx" && "$RESERVE" fr --milestone m-t 2>/dev/null)
+b=$(cd "$fx" && "$RESERVE" fr --milestone m-t 2>/dev/null)
+m=$(cd "$fx" && "$RESERVE" milestone --milestone m-new 2>/dev/null)
+r=$(cd "$fx" && "$RESERVE" refactor --milestone m-t 2>/dev/null)
+if [ "$a $b $m $r" = "FR-001 FR-002 M-1 R001" ] \
+   && grep -q '^reservations:' "$fx/.forge/reservations.yml" 2>/dev/null \
+   && grep -q 'kind: refactor' "$fx/.forge/reservations.yml" 2>/dev/null; then
+  report regression-existing-kinds pass
+else report regression-existing-kinds fail "expected FR-001 FR-002 M-1 R001 + seeded header, got: $a $b $m $r"; fi
+
+# case 13 regression-lock-release — back-to-back calls in one fixture must not
+# time out (a leaked lock would make the second call exit 3)
+fx=$(new_fixture c13)
+(cd "$fx" && "$RESERVE" adr --milestone m-t >/dev/null 2>&1)
+out=$(cd "$fx" && FORGE_RESERVE_WAIT=2 "$RESERVE" adr --milestone m-t 2>/dev/null)
+rc=$?
+if [ "$rc" -eq 0 ] && [ "$out" = "ADR-002" ]; then
+  report regression-lock-release pass
+else report regression-lock-release fail "second call rc=$rc out=$out (leaked lock?)"; fi
+
+# ── input hardening (review, m-41): validation before the lock, nothing written ─
+
+# case 14 version-value-rejects-non-semver — --value must be X.Y.Z; a non-semver
+# (here a YAML-injection payload) → exit 2, NOTHING written
+fx=$(new_fixture c14)
+err=$(cd "$fx" && "$RESERVE" version --value '9.9.9
+injected: pwned' --milestone m-a 2>&1 >/dev/null)
+rc=$?
+if [ "$rc" -eq 2 ] && [ ! -f "$fx/.git/forge/id-reservations" ] && [ ! -f "$fx/.forge/reservations.yml" ]; then
+  report version-value-rejects-non-semver pass
+else report version-value-rejects-non-semver fail "rc=$rc (want 2) or files written on bad --value"; fi
+
+# case 15 version-value-accepts-prerelease — X.Y.Z-pre is valid semver → recorded
+fx=$(new_fixture c15)
+out=$(cd "$fx" && "$RESERVE" version --value 1.2.0-rc.1 --milestone m-a 2>/dev/null)
+if [ "$out" = "1.2.0-rc.1" ]; then report version-value-accepts-prerelease pass
+else report version-value-accepts-prerelease fail "expected 1.2.0-rc.1 recorded, got: $out"; fi
+
+# case 16 milestone-rejects-control-char — a newline in --milestone would split
+# the ledger row / inject a sibling YAML key → exit 2, NOTHING written
+fx=$(new_fixture c16)
+err=$(cd "$fx" && "$RESERVE" fr --milestone 'm-1
+    injected: pwned' 2>&1 >/dev/null)
+rc=$?
+if [ "$rc" -eq 2 ] && [ ! -f "$fx/.git/forge/id-reservations" ] && [ ! -f "$fx/.forge/reservations.yml" ]; then
+  report milestone-rejects-control-char pass
+else report milestone-rejects-control-char fail "rc=$rc (want 2) or files written on control-char milestone"; fi
+
+# case 17 symlink-target-refused — reservations.yml is a symlink → refuse to
+# write through it, exit 2, and the symlink target stays untouched
+fx=$(new_fixture c17)
+mkdir -p "$fx/.forge"
+: > "$ROOT/c17-victim.txt"
+ln -s "$ROOT/c17-victim.txt" "$fx/.forge/reservations.yml"
+err=$(cd "$fx" && "$RESERVE" fr --milestone m-t 2>&1 >/dev/null)
+rc=$?
+if [ "$rc" -eq 2 ] && [ ! -s "$ROOT/c17-victim.txt" ]; then
+  report symlink-target-refused pass
+else report symlink-target-refused fail "rc=$rc (want 2) or victim written through symlink"; fi
+
+# case 18 main-floor — cross-machine/cold-start floor: main:reservations.yml
+# carries a merged P-020, empty ledger + roadmap → next phase is P-021
+fx=$(new_fixture c18)
+mkdir -p "$fx/.forge"
+printf 'reservations:\n  - kind: phase\n    id: P-020\n    milestone: m-old\n' > "$fx/.forge/reservations.yml"
+git -C "$fx" add .forge/reservations.yml >/dev/null 2>&1
+git -C "$fx" -c user.email=t@t -c user.name=t commit -qm seed >/dev/null 2>&1
+git -C "$fx" branch -M main >/dev/null 2>&1
+out=$(cd "$fx" && "$RESERVE" phase --milestone m-t 2>/dev/null)
+if [ "$out" = "P-021" ]; then report main-floor pass
+else report main-floor fail "main floor P-020 ignored — expected P-021, got: $out"; fi
+
+# ── summary ──────────────────────────────────────────────────────────────────
+if [ "$fails" -eq 0 ]; then
+  printf 'forge-reserve.test.sh: all %d cases PASS\n' "$n"
+  exit 0
+fi
+printf 'forge-reserve.test.sh: %d of %d cases FAILED\n' "$fails" "$n" >&2
+exit 1