forge-cc 0.1.23 → 0.1.25

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "forge-cc",
-  "version": "0.1.23",
+  "version": "0.1.25",
   "description": "Pre-PR verification harness for Claude Code agents — gate runner + CLI + MCP server",
   "type": "module",
   "license": "MIT",

package/skills/forge-go.md

@@ -95,7 +95,9 @@ If `.forge.json` includes `visual` in gates or specifies a `devServerUrl`, captu
 3. Screenshots save to `.forge/screenshots/before/`
 4. Stop the dev server
 
-This establishes the visual baseline for regression detection. Skip if no visual gate is configured.
+This establishes the visual baseline for regression detection.
+
+**The visual gate MUST run if configured — do not skip based on your assessment of whether changes affect the UI.** Parser changes, data fixes, and test-only changes can surface unexpected visual regressions. The only valid reason to skip is: `.forge.json` does NOT include `visual` in gates AND does NOT specify a `devServerUrl`.
 
 ### Step 2.5 — Session Isolation (Automatic)
 
@@ -214,7 +216,18 @@ npx forge verify
 
 If verification **fails**: proceed to Step 4 (self-healing loop).
 
-If verification **passes**: proceed to reviewer.
+If verification **passes**: capture after screenshots (if visual gate configured), then proceed to reviewer.
+
+#### 3e-vis. Capture After Screenshots (If Visual Gate Configured)
+
+If `.forge.json` includes `visual` in gates or specifies a `devServerUrl`, capture after screenshots:
+
+1. Start the dev server (from `.forge.json` devServerUrl or `npm run dev`)
+2. Run `npx forge verify --gate visual --after-only` (or manually call the screenshot capture)
+3. Screenshots save to `.forge/screenshots/after/`
+4. Stop the dev server
+
+**This step is mandatory when the visual gate is configured — same rule as Step 2.** The reviewer needs both before and after screenshots to detect visual regressions.
 
 #### 3f. Reviewer Consensus Protocol
 
@@ -265,7 +278,7 @@ If no findings (or all findings resolved): print wave completion summary and pro
 - agent-1: OK (created file1.ts, file2.ts)
 - agent-2: OK (modified file3.ts)
 - Mechanical verification: PASSED
-- Visual gate: PASSED (3 viewports captured) | SKIPPED (not configured)
+- Visual gate: PASSED (3 viewports captured) | SKIPPED (not in .forge.json gates)
 - Reviewer: {N} findings, {M} resolved, 0 outstanding
 
 Proceeding to Wave {N+1}...
@@ -349,12 +362,12 @@ Check for the Linear project ID in this priority order:
 
 If a Linear project ID is found:
 
-1. Transition issues for the completed milestone to appropriate state:
-   - If this was the **last milestone**: move issues to "In Review"
+1. **Transition issues** for the completed milestone:
+   - If this was the **last milestone**: use `mcp__linear__update_issue` on each issue to set state to "In Review"
    - Otherwise: keep issues as-is (they were set to "In Progress" at start)
 
-2. If this is the **last milestone**, also:
-   - Transition the project to "In Review"
+2. If this is the **last milestone**, **also transition the project itself** (separate from issues):
+   - Use `mcp__linear__update_project` to set the project state to "In Review". **Do not skip this — the project is a separate entity from its issues.**
    - Create a PR (see Step 8)
 
 If no Linear project ID is found in either location, skip this step silently.
@@ -501,12 +514,12 @@ At the START of milestone execution (between Step 2 and Step 3), check for the L
 1. `linearProjectId` field in `.planning/status/<slug>.json`
 2. `linearProject` field in `.forge.json`
 
-If a Linear project ID is found:
+If a Linear project ID is found, **execute ALL four steps below — do not skip any**:
 
-1. Find issues associated with this milestone in Linear.
-2. Transition them to "In Progress".
-3. Transition the project to "In Progress" (if not already).
-4. Add a brief comment: "Starting execution via forge:go."
+1. **Find issues:** Use `mcp__linear__list_issues` with the project ID to find issues associated with this milestone.
+2. **Transition issues:** Use `mcp__linear__update_issue` on each issue to set state to "In Progress".
+3. **Transition the project:** Use `mcp__linear__update_project` to set the project state to "In Progress". **This is a separate step from transitioning issues — do not skip it.** The project and its issues are independent entities in Linear.
+4. **Add comment:** Use `mcp__linear__create_comment` on each milestone issue with the body: "Starting execution via forge:go."
 
 If no Linear project ID is found, skip silently.