forge-cc 0.1.23 → 0.1.24
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +1 -1
- package/skills/forge-go.md +16 -3
package/package.json
CHANGED
package/skills/forge-go.md
CHANGED
|
@@ -95,7 +95,9 @@ If `.forge.json` includes `visual` in gates or specifies a `devServerUrl`, captu
|
|
|
95
95
|
3. Screenshots save to `.forge/screenshots/before/`
|
|
96
96
|
4. Stop the dev server
|
|
97
97
|
|
|
98
|
-
This establishes the visual baseline for regression detection.
|
|
98
|
+
This establishes the visual baseline for regression detection.
|
|
99
|
+
|
|
100
|
+
**The visual gate MUST run if configured — do not skip based on your assessment of whether changes affect the UI.** Parser changes, data fixes, and test-only changes can surface unexpected visual regressions. The only valid reason to skip is: `.forge.json` does NOT include `visual` in gates AND does NOT specify a `devServerUrl`.
|
|
99
101
|
|
|
100
102
|
### Step 2.5 — Session Isolation (Automatic)
|
|
101
103
|
|
|
@@ -214,7 +216,18 @@ npx forge verify
|
|
|
214
216
|
|
|
215
217
|
If verification **fails**: proceed to Step 4 (self-healing loop).
|
|
216
218
|
|
|
217
|
-
If verification **passes**: proceed to reviewer.
|
|
219
|
+
If verification **passes**: capture after screenshots (if visual gate configured), then proceed to reviewer.
|
|
220
|
+
|
|
221
|
+
#### 3e-vis. Capture After Screenshots (If Visual Gate Configured)
|
|
222
|
+
|
|
223
|
+
If `.forge.json` includes `visual` in gates or specifies a `devServerUrl`, capture after screenshots:
|
|
224
|
+
|
|
225
|
+
1. Start the dev server (from `.forge.json` devServerUrl or `npm run dev`)
|
|
226
|
+
2. Run `npx forge verify --gate visual --after-only` (or manually call the screenshot capture)
|
|
227
|
+
3. Screenshots save to `.forge/screenshots/after/`
|
|
228
|
+
4. Stop the dev server
|
|
229
|
+
|
|
230
|
+
**This step is mandatory when the visual gate is configured — same rule as Step 2.** The reviewer needs both before and after screenshots to detect visual regressions.
|
|
218
231
|
|
|
219
232
|
#### 3f. Reviewer Consensus Protocol
|
|
220
233
|
|
|
@@ -265,7 +278,7 @@ If no findings (or all findings resolved): print wave completion summary and pro
|
|
|
265
278
|
- agent-1: OK (created file1.ts, file2.ts)
|
|
266
279
|
- agent-2: OK (modified file3.ts)
|
|
267
280
|
- Mechanical verification: PASSED
|
|
268
|
-
- Visual gate: PASSED (3 viewports captured) | SKIPPED (not
|
|
281
|
+
- Visual gate: PASSED (3 viewports captured) | SKIPPED (not in .forge.json gates)
|
|
269
282
|
- Reviewer: {N} findings, {M} resolved, 0 outstanding
|
|
270
283
|
|
|
271
284
|
Proceeding to Wave {N+1}...
|