fontastic 1.3.2 → 1.4.0

package/.github/workflows/claude-code-review.yml

@@ -22,7 +22,7 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
         with:
           fetch-depth: 1
 

package/.github/workflows/claude.yml

@@ -26,7 +26,7 @@ jobs:
       actions: read # Required for Claude to read CI results on PRs
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
         with:
           fetch-depth: 1
 

package/.github/workflows/macos.yml

@@ -24,10 +24,10 @@ jobs:
     runs-on: macos-latest
 
     steps:
-    - uses: actions/checkout@v6
+    - uses: actions/checkout@v7
 
     - name: Cache Node modules
-      uses: actions/cache@v5
+      uses: actions/cache@v6
       with:
         # npm cache files are stored in ~/.npm
         path: ~/.npm
@@ -36,7 +36,7 @@ jobs:
           ${{ runner.os }}-node-
 
     - name: Cache Electron binaries
-      uses: actions/cache@v5
+      uses: actions/cache@v6
       with:
         path: |
           ~/Library/Caches/electron
@@ -51,7 +51,7 @@ jobs:
         node-version: ${{ matrix.node-version }}
 
     - name: Install Dependencies
-      uses: nick-fields/retry@v3
+      uses: nick-fields/retry@v4
       with:
         timeout_minutes: 10
         max_attempts: 3
@@ -61,7 +61,7 @@ jobs:
       run: npm run lint
 
     - name: Install Playwright Browsers
-      run: npx playwright@1.58.2 install --with-deps
+      run: npx playwright install --with-deps
 
     - name: Run headless unit test
       run: npm run test -- --reporters=default

package/.github/workflows/release-please.yml

@@ -18,7 +18,7 @@ jobs:
   release-please:
     runs-on: ubuntu-latest
     steps:
-      - uses: googleapis/release-please-action@v4.4.0
+      - uses: googleapis/release-please-action@v5.0.0
         with:
           token: ${{ secrets.RELEASE_PLEASE_TOKEN }}
           config-file: release-please-config.json

package/.github/workflows/release.yml

@@ -21,7 +21,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - name: Checkout tag
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
         with:
           ref: ${{ github.event.release.tag_name }}
 
@@ -37,7 +37,7 @@ jobs:
           sudo apt-get install -y libgtk-3-dev webkit2gtk-4.0 libappindicator3-dev librsvg2-dev patchelf
 
       - name: Install dependencies
-        uses: nick-fields/retry@v3
+        uses: nick-fields/retry@v4
         with:
           timeout_minutes: 10
           max_attempts: 3

package/.github/workflows/ubuntu.yml

@@ -22,13 +22,13 @@ jobs:
         node-version: [24]
 
     # The type of runner that the job will run on
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
 
     steps:
-    - uses: actions/checkout@v6
+    - uses: actions/checkout@v7
 
     - name: Cache Node modules
-      uses: actions/cache@v5
+      uses: actions/cache@v6
       with:
         # npm cache files are stored in ~/.npm
         path: ~/.npm
@@ -37,7 +37,7 @@ jobs:
           ${{ runner.os }}-node-
 
     - name: Cache Electron binaries
-      uses: actions/cache@v5
+      uses: actions/cache@v6
       with:
         path: |
           ~/.cache/electron
@@ -54,10 +54,10 @@ jobs:
     - name: Install linux dependencies
       run: |
         sudo apt-get update
-        sudo apt-get install -y libgtk-3-dev webkit2gtk-4.0 libappindicator3-dev librsvg2-dev patchelf
+        sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf
 
     - name: Install Dependencies
-      uses: nick-fields/retry@v3
+      uses: nick-fields/retry@v4
       with:
         timeout_minutes: 10
         max_attempts: 3
@@ -67,7 +67,7 @@ jobs:
       run: npm run lint
 
     - name: Install Playwright Browsers
-      run: npx playwright@1.58.2 install --with-deps
+      run: npx playwright install --with-deps
 
     - name: Run headless unit test
       uses: GabrielBB/xvfb-action@v1

package/.github/workflows/windows.yml

@@ -28,10 +28,10 @@ jobs:
     runs-on: windows-latest
 
     steps:
-    - uses: actions/checkout@v6
+    - uses: actions/checkout@v7
 
     - name: Cache Node modules
-      uses: actions/cache@v5
+      uses: actions/cache@v6
       with:
         # npm cache files are stored in ~/.npm
         path: ~/.npm
@@ -40,7 +40,7 @@ jobs:
           ${{ runner.os }}-node-
 
     - name: Cache Electron binaries
-      uses: actions/cache@v5
+      uses: actions/cache@v6
       with:
         path: |
           ${{ env.LOCALAPPDATA }}\electron\Cache
@@ -55,7 +55,7 @@ jobs:
         node-version: ${{ matrix.node-version }}
 
     - name: Install Dependencies
-      uses: nick-fields/retry@v3
+      uses: nick-fields/retry@v4
       with:
         timeout_minutes: 10
         max_attempts: 3
@@ -65,7 +65,7 @@ jobs:
       run: npm run lint
 
     - name: Install Playwright Browsers
-      run: npx playwright@1.58.2 install --with-deps
+      run: npx playwright install --with-deps
 
     - name: Run headless unit test
       run: npm run test -- --reporters=default

package/README.md

@@ -1,7 +1,7 @@
 # Fontastic
 
-[![Angular](https://img.shields.io/badge/Angular-21-dd0031?style=plastic&logo=angular&logoColor=white)](https://angular.dev)
-[![Electron](https://img.shields.io/badge/Electron-40-47848f?style=plastic&logo=electron&logoColor=white)](https://electronjs.org)
+[![Angular](https://img.shields.io/badge/Angular-21.2.17-dd0031?style=plastic&logo=angular&logoColor=white)](https://angular.dev)
+[![Electron](https://img.shields.io/badge/Electron-43-47848f?style=plastic&logo=electron&logoColor=white)](https://electronjs.org)
 [![TypeScript](https://img.shields.io/badge/TypeScript-5.9-3178c6?style=plastic&logo=typescript&logoColor=white)](https://www.typescriptlang.org)
 [![License](https://img.shields.io/badge/License-MIT-f59e0b?style=plastic)](LICENSE.md)
 [![PRs Welcome](https://img.shields.io/badge/PRs-Welcome-22c55e?style=plastic)](http://makeapullrequest.com)
@@ -56,11 +56,11 @@ npm start
 | Category | Technology |
 |---|---|
 | Framework | [Angular](https://angular.dev) 21 |
-| Desktop | [Electron](https://electronjs.org) 40 |
+| Desktop | [Electron](https://electronjs.org) 43 |
 | Language | [TypeScript](https://www.typescriptlang.org) 5.9 |
 | Database | [TypeORM](https://typeorm.io) + SQLite |
 | Font Parsing | [Fontkit](https://github.com/foliojs/fontkit) |
-| Styling | [Tailwind CSS](https://tailwindcss.com) 4 + SCSS |
+| Styling | [Tailwind CSS](https://tailwindcss.com) 4 + CSS variables |
 | i18n | [@ngx-translate](https://github.com/ngx-translate/core) |
 | Testing | [Vitest](https://vitest.dev) + [Playwright](https://playwright.dev) |
 | Linting | [ESLint](https://eslint.org) + [Prettier](https://prettier.io) |

package/angular.json

@@ -28,7 +28,7 @@
               "base": "dist"
             },
             "index": "src/index.html",
-            "polyfills": ["zone.js"],
+            "polyfills": [],
             "tsConfig": "src/tsconfig.app.json",
             "inlineStyleLanguage": "css",
             "assets": ["src/favicon.ico", "src/assets"],
@@ -66,7 +66,7 @@
               ]
             },
             "testing": {
-              "polyfills": ["zone.js", "zone.js/testing"]
+              "polyfills": []
             }
           }
         },
@@ -100,7 +100,12 @@
             "coverage": true,
             "coverageReporters": ["html", "lcovonly"],
             "reporters": [
-              ["default", { "summary": true }],
+              [
+                "default",
+                {
+                  "summary": true
+                }
+              ],
               [
                 "html",
                 {

package/app/core/FontFinder.js

@@ -79,9 +79,21 @@ class FontFinder {
     processInBatches(fontFiles, options) {
         return __awaiter(this, void 0, void 0, function* () {
             const total = fontFiles.length;
+            const repository = this.connectionManager.getStoreRepository();
             for (let i = 0; i < fontFiles.length; i += SCAN_CONCURRENCY) {
                 const batch = fontFiles.slice(i, i + SCAN_CONCURRENCY);
-                yield Promise.all(batch.map(({ fp, fileType }) => this.processFont(fp, fileType, options)));
+                const parsed = yield Promise.all(batch.map(({ fp, fileType }) => this.parseFont(fp, fileType, options)));
+                const rows = parsed.filter((row) => row !== null);
+                if (rows.length) {
+                    try {
+                        // One multi-row INSERT per batch instead of one statement per font.
+                        yield repository.createMany(rows);
+                        this.counter += rows.length;
+                    }
+                    catch (err) {
+                        this.errors.push(...rows.map((row) => ({ file: row.file_path, message: err.message })));
+                    }
+                }
                 if (this.onProgress) {
                     const lastFile = batch[batch.length - 1];
                     this.onProgress({
@@ -94,12 +106,12 @@ class FontFinder {
             }
         });
     }
-    processFont(fp, fileType, options) {
+    parseFont(fp, fileType, options) {
         return __awaiter(this, void 0, void 0, function* () {
             const font = new FontObject_1.default(fp);
             if (font.hasError()) {
                 this.errors.push(font.getError());
-                return;
+                return null;
             }
             let stat;
             try {
@@ -107,16 +119,9 @@ class FontFinder {
             }
             catch (err) {
                 this.errors.push({ file: fp, message: err.message });
-                return;
-            }
-            const data = Object.assign(Object.assign({ file_path: fp, file_name: path.basename(fp), file_size: stat.size, file_size_pretty: prettyBytes(stat.size), file_type: fileType, installable: mimes_1.installable.includes(fileType) }, options), font.getNamesTable());
-            try {
-                yield this.connectionManager.getStoreRepository().create(data);
-                this.counter++;
-            }
-            catch (err) {
-                this.errors.push({ file: fp, message: err.message });
+                return null;
             }
+            return Object.assign(Object.assign({ file_path: fp, file_name: path.basename(fp), file_size: stat.size, file_size_pretty: prettyBytes(stat.size), file_type: fileType, installable: mimes_1.installable.includes(fileType) }, options), font.getNamesTable());
         });
     }
 }

package/app/core/FontFinder.ts

@@ -81,9 +81,22 @@ export default class FontFinder {
 
   private async processInBatches(fontFiles: { fp: string; fileType: string }[], options: any) {
     const total = fontFiles.length;
+    const repository = this.connectionManager.getStoreRepository();
+
     for (let i = 0; i < fontFiles.length; i += SCAN_CONCURRENCY) {
       const batch = fontFiles.slice(i, i + SCAN_CONCURRENCY);
-      await Promise.all(batch.map(({ fp, fileType }) => this.processFont(fp, fileType, options)));
+      const parsed = await Promise.all(batch.map(({ fp, fileType }) => this.parseFont(fp, fileType, options)));
+      const rows = parsed.filter((row) => row !== null);
+
+      if (rows.length) {
+        try {
+          // One multi-row INSERT per batch instead of one statement per font.
+          await repository.createMany(rows);
+          this.counter += rows.length;
+        } catch (err: any) {
+          this.errors.push(...rows.map((row) => ({ file: row.file_path, message: err.message })));
+        }
+      }
 
       if (this.onProgress) {
         const lastFile = batch[batch.length - 1];
@@ -97,12 +110,12 @@ export default class FontFinder {
     }
   }
 
-  private async processFont(fp: string, fileType: string, options: any) {
+  private async parseFont(fp: string, fileType: string, options: any): Promise<any | null> {
     const font = new FontObject(fp);
 
     if (font.hasError()) {
       this.errors.push(font.getError());
-      return;
+      return null;
     }
 
     let stat;
@@ -110,10 +123,10 @@ export default class FontFinder {
       stat = await fs.stat(fp);
     } catch (err: any) {
       this.errors.push({ file: fp, message: err.message });
-      return;
+      return null;
     }
 
-    const data = {
+    return {
       file_path: fp,
       file_name: path.basename(fp),
       file_size: stat.size,
@@ -123,12 +136,5 @@ export default class FontFinder {
       ...options,
       ...font.getNamesTable(),
     };
-
-    try {
-      await this.connectionManager.getStoreRepository().create(data);
-      this.counter++;
-    } catch (err: any) {
-      this.errors.push({ file: fp, message: err.message });
-    }
   }
 }

package/app/core/FontManager.js

@@ -12,10 +12,8 @@ Object.defineProperty(exports, "__esModule", { value: true });
 const electron_1 = require("electron");
 const FontCatalog_1 = require("./FontCatalog");
 const FontFinder_1 = require("./FontFinder");
-const command_1 = require("../helpers/command");
 const StorageType_1 = require("../enums/StorageType");
 const path = require("path");
-const fetch = require('node-fetch');
 class FontManager {
     constructor(systemManager, configManager, connectionManager) {
         this.catalog = new FontCatalog_1.default();
@@ -51,16 +49,6 @@ class FontManager {
             return this.configManager.get(StorageType_1.StorageType.User);
         });
     }
-    executeCommand(args) {
-        return __awaiter(this, void 0, void 0, function* () {
-            try {
-                return yield (0, command_1.execute)(args.cmd, args.options);
-            }
-            catch (err) {
-                return err;
-            }
-        });
-    }
     getDestinationFolder(collectionId) {
         return path.join(this.systemManager.getCatalogPath(), String(collectionId));
     }
@@ -91,7 +79,7 @@ class FontManager {
         });
     }
     showMessageBox(options) {
-        return electron_1.dialog.showMessageBox(null, options);
+        return electron_1.dialog.showMessageBox(options);
     }
     showOpenDialog(options) {
         return electron_1.dialog.showOpenDialog(options);
@@ -103,7 +91,18 @@ class FontManager {
         electron_1.shell.openPath(path);
     }
     openExternal(url) {
-        electron_1.shell.openExternal(url);
+        // Only allow web URLs — anything else (file:, smb:, custom schemes) is a
+        // request the renderer should never be able to make.
+        let protocol;
+        try {
+            protocol = new URL(url).protocol;
+        }
+        catch (_a) {
+            return;
+        }
+        if (protocol === 'https:' || protocol === 'http:') {
+            electron_1.shell.openExternal(url);
+        }
     }
     showItemInFolder(fullPath) {
         electron_1.shell.showItemInFolder(fullPath);

package/app/core/FontManager.ts

@@ -6,14 +6,11 @@ import ConnectionManager from './ConnectionManager';
 
 import FontCatalog from './FontCatalog';
 import FontFinder, { ProgressCallback } from './FontFinder';
-import { execute } from '../helpers/command';
 
 import { StorageType } from '../enums/StorageType';
 
 import * as path from 'path';
 
-const fetch = require('node-fetch');
-
 export default class FontManager {
   systemManager: SystemManager;
   configManager: ConfigManager;
@@ -56,14 +53,6 @@ export default class FontManager {
     return this.configManager.get(StorageType.User);
   }
 
-  async executeCommand(args: any) {
-    try {
-      return await execute(args.cmd, args.options);
-    } catch (err) {
-      return err;
-    }
-  }
-
   getDestinationFolder(collectionId: number) {
     return path.join(this.systemManager.getCatalogPath(), String(collectionId));
   }
@@ -91,7 +80,7 @@ export default class FontManager {
   }
 
   showMessageBox(options: any) {
-    return dialog.showMessageBox(null, options);
+    return dialog.showMessageBox(options);
   }
 
   showOpenDialog(options: any) {
@@ -107,7 +96,17 @@ export default class FontManager {
   }
 
   openExternal(url: string) {
-    shell.openExternal(url);
+    // Only allow web URLs — anything else (file:, smb:, custom schemes) is a
+    // request the renderer should never be able to make.
+    let protocol: string;
+    try {
+      protocol = new URL(url).protocol;
+    } catch {
+      return;
+    }
+    if (protocol === 'https:' || protocol === 'http:') {
+      shell.openExternal(url);
+    }
   }
 
   showItemInFolder(fullPath: string) {

package/app/core/MessageHandler.js

@@ -75,7 +75,6 @@ class MessageHandler {
         }));
         this.handle(ChannelType_1.ChannelType.IPC_DATABASE_DROP, (_event) => __awaiter(this, void 0, void 0, function* () { return this.connectionManager.getDataSource().dropDatabase(); }));
         // Font Manager
-        this.handle(ChannelType_1.ChannelType.IPC_EXEC_CMD, (_event, args) => __awaiter(this, void 0, void 0, function* () { return this.fontManager.executeCommand(args).catch((err) => this.sendMessage('error', err.message)); }));
         this.handle(ChannelType_1.ChannelType.IPC_AUTH_USER, (_event, args) => __awaiter(this, void 0, void 0, function* () { return this.fontManager.systemAuthenticate(args); }));
         this.handle(ChannelType_1.ChannelType.IPC_SCAN_FILES, (_event, args) => __awaiter(this, void 0, void 0, function* () {
             const { port1, port2 } = new electron_1.MessageChannelMain();

package/app/core/MessageHandler.ts

@@ -108,10 +108,6 @@ export default class MessageHandler {
 
     // Font Manager
 
-    this.handle(ChannelType.IPC_EXEC_CMD, async (_event: IpcMainEvent, args: any) =>
-      this.fontManager.executeCommand(args).catch((err: Error) => this.sendMessage('error', err.message)),
-    );
-
     this.handle(ChannelType.IPC_AUTH_USER, async (_event: IpcMainEvent, args: any) => this.fontManager.systemAuthenticate(args));
 
     this.handle(ChannelType.IPC_SCAN_FILES, async (_event: IpcMainEvent, args: any) => {

package/app/database/entity/Store.schema.js

@@ -21,6 +21,7 @@ __decorate([
 ], Store.prototype, "id", void 0);
 __decorate([
     (0, typeorm_1.Column)('int'),
+    (0, typeorm_1.Index)(),
     __metadata("design:type", Number)
 ], Store.prototype, "collection_id", void 0);
 __decorate([

package/app/database/entity/Store.schema.ts

@@ -9,6 +9,7 @@ export class Store {
   id: number;
 
   @Column('int')
+  @Index()
   collection_id: number;
 
   @Column({ type: 'varchar', length: 255, default: '', nullable: true })

package/app/database/repository/Collection.repository.js

@@ -17,17 +17,6 @@ exports.CollectionRepository = {
         return __awaiter(this, void 0, void 0, function* () {
             const db = this.createQueryBuilder('collection');
             db.where('collection.is_system = 0');
-            db.leftJoin('collection.stores', 'store');
-            db.loadRelationCountAndMap('store.storeCount', 'collection.stores'); // correct
-            db.loadRelationCountAndMap('store.installableCount', 'collection.stores', 'store', (qb) => qb.andWhere('store.installable = :placeholder', {
-                placeholder: true,
-            }));
-            db.loadRelationCountAndMap('store.temporaryCount', 'collection.stores', 'store', (qb) => qb.andWhere('store.temporary = :placeholder', {
-                placeholder: true,
-            }));
-            db.loadRelationCountAndMap('store.favoriteCount', 'collection.stores', 'store', (qb) => qb.andWhere('store.favorite = :placeholder', {
-                placeholder: true,
-            }));
             db.orderBy('collection.orderby', 'ASC');
             db.addOrderBy('LOWER(collection.title)', 'ASC');
             return yield db.getMany();

package/app/database/repository/Collection.repository.ts

@@ -7,28 +7,6 @@ export const CollectionRepository = {
 
     db.where('collection.is_system = 0');
 
-    db.leftJoin('collection.stores', 'store');
-
-    db.loadRelationCountAndMap('store.storeCount', 'collection.stores'); // correct
-
-    db.loadRelationCountAndMap('store.installableCount', 'collection.stores', 'store', (qb: any) =>
-      qb.andWhere('store.installable = :placeholder', {
-        placeholder: true,
-      }),
-    );
-
-    db.loadRelationCountAndMap('store.temporaryCount', 'collection.stores', 'store', (qb: any) =>
-      qb.andWhere('store.temporary = :placeholder', {
-        placeholder: true,
-      }),
-    );
-
-    db.loadRelationCountAndMap('store.favoriteCount', 'collection.stores', 'store', (qb: any) =>
-      qb.andWhere('store.favorite = :placeholder', {
-        placeholder: true,
-      }),
-    );
-
     db.orderBy('collection.orderby', 'ASC');
     db.addOrderBy('LOWER(collection.title)', 'ASC');