fomantic-ui 2.9.1-beta.23 → 2.9.1-beta.25

package/gulpfile.js

@@ -2,7 +2,7 @@
  *           Set-up
  *******************************/
 
-let
+const
     gulp   = require('gulp'),
 
     // read user config to know what task to load

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fomantic-ui",
-  "version": "2.9.1-beta.23+27384cb",
+  "version": "2.9.1-beta.25+bbe4e58",
   "description": "Fomantic empowers designers and developers by creating a shared vocabulary for UI.",
   "keywords": [
     "fomantic-ui",
@@ -73,6 +73,7 @@
     "yamljs": "^0.3.0"
   },
   "devDependencies": {
+    "@internal/eslint-plugin": "file:.eslint",
     "all-contributors-cli": "^6.7.0",
     "auto-changelog": "^2.4.0",
     "eslint": "^8.29.0",

package/scripts/nightly-version.js

@@ -44,7 +44,9 @@ const getPublishedVersion = async function () {
             .then((p) => {
                 let nightly = p['dist-tags'].nightly ?? '';
                 let versionInfo = p.versions[nightly] ?? {};
-                let buildCommit = nightly.indexOf('+') === -1 && versionInfo.gitHead ? '+' + (versionInfo.gitHead ?? '').slice(0, 7) : '';
+                let buildCommit = nightly.indexOf('+') === -1 && versionInfo.gitHead
+                    ? '+' + (versionInfo.gitHead ?? '').slice(0, 7)
+                    : '';
 
                 return nightly + buildCommit;
             })

package/src/definitions/behaviors/api.js

@@ -12,14 +12,14 @@
     'use strict';
 
     function isWindow(obj) {
-        return obj != null && obj === obj.window;
+        return obj !== null && obj === obj.window;
     }
 
     function isFunction(obj) {
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (window !== undefined && window.Math === Math)
+    window = window !== undefined && window.Math === Math
         ? window
         : globalThis;
 
@@ -34,7 +34,7 @@
             performance    = [],
 
             query          = arguments[0],
-            methodInvoked  = (typeof query === 'string'),
+            methodInvoked  = typeof query === 'string',
             queryArguments = [].slice.call(arguments, 1),
 
             returnedValue
@@ -42,7 +42,7 @@
 
         $allModules.each(function () {
             var
-                settings          = ($.isPlainObject(parameters))
+                settings          = $.isPlainObject(parameters)
                     ? $.extend(true, {}, $.fn.api.settings, parameters)
                     : $.extend({}, $.fn.api.settings),
 
@@ -62,7 +62,7 @@
                 $form           = $module.closest(selector.form),
 
                 // context used for state
-                $context        = (settings.stateContext)
+                $context        = settings.stateContext
                     ? ([window, document].indexOf(settings.stateContext) < 0 ? $(document).find(settings.stateContext) : $(settings.stateContext))
                     : $module,
 
@@ -117,7 +117,7 @@
                             $module
                                 .on(triggerEvent + eventNamespace, module.event.trigger)
                             ;
-                        } else if (settings.on == 'now') {
+                        } else if (settings.on === 'now') {
                             module.debug('Querying API endpoint immediately');
                             module.query();
                         }
@@ -274,13 +274,13 @@
 
                 should: {
                     removeError: function () {
-                        return (settings.hideError === true || (settings.hideError === 'auto' && !module.is.form()));
+                        return settings.hideError === true || (settings.hideError === 'auto' && !module.is.form());
                     },
                 },
 
                 is: {
                     disabled: function () {
-                        return ($module.filter(selector.disabled).length > 0);
+                        return $module.filter(selector.disabled).length > 0;
                     },
                     expectingJSON: function () {
                         return settings.dataType === 'json' || settings.dataType === 'jsonp';
@@ -289,14 +289,14 @@
                         return $module.is('form') || $context.is('form');
                     },
                     mocked: function () {
-                        return (settings.mockResponse || settings.mockResponseAsync || settings.response || settings.responseAsync);
+                        return settings.mockResponse || settings.mockResponseAsync || settings.response || settings.responseAsync;
                     },
                     input: function () {
                         return $module.is('input');
                     },
                     loading: function () {
-                        return (module.request)
-                            ? (module.request.state() == 'pending')
+                        return module.request
+                            ? module.request.state() === 'pending'
                             : false;
                     },
                     abortedRequest: function (xhr) {
@@ -311,7 +311,7 @@
                         return false;
                     },
                     validResponse: function (response) {
-                        if ((!module.is.expectingJSON()) || !isFunction(settings.successTest)) {
+                        if (!module.is.expectingJSON() || !isFunction(settings.successTest)) {
                             module.verbose('Response is not JSON, skipping validation', settings.successTest, response);
 
                             return true;
@@ -331,16 +331,16 @@
 
                 was: {
                     cancelled: function () {
-                        return (module.cancelled || false);
+                        return module.cancelled || false;
                     },
                     successful: function () {
-                        return (module.request && module.request.state() == 'resolved');
+                        return module.request && module.request.state() === 'resolved';
                     },
                     failure: function () {
-                        return (module.request && module.request.state() == 'rejected');
+                        return module.request && module.request.state() === 'rejected';
                     },
                     complete: function () {
-                        return (module.request && (module.request.state() == 'resolved' || module.request.state() == 'rejected'));
+                        return module.request && (module.request.state() === 'resolved' || module.request.state() === 'rejected');
                     },
                 },
 
@@ -359,16 +359,16 @@
                                 $.each(requiredVariables, function (index, templatedString) {
                                     var
                                         // allow legacy {$var} style
-                                        variable = (templatedString.indexOf('$') !== -1)
+                                        variable = templatedString.indexOf('$') !== -1
                                             ? templatedString.slice(2, -1)
                                             : templatedString.slice(1, -1),
-                                        value   = ($.isPlainObject(urlData) && urlData[variable] !== undefined)
+                                        value   = $.isPlainObject(urlData) && urlData[variable] !== undefined
                                             ? urlData[variable]
-                                            : ($module.data(variable) !== undefined)
+                                            : ($module.data(variable) !== undefined
                                                 ? $module.data(variable)
-                                                : ($context.data(variable) !== undefined)
+                                                : ($context.data(variable) !== undefined // eslint-disable-line unicorn/no-nested-ternary
                                                     ? $context.data(variable)
-                                                    : urlData[variable]
+                                                    : urlData[variable]))
                                     ;
                                     // remove value
                                     if (value === undefined) {
@@ -379,7 +379,7 @@
                                     }
 
                                     module.verbose('Found required variable', variable, value);
-                                    value = (settings.encodeParameters)
+                                    value = settings.encodeParameters
                                         ? module.get.urlEncodedValue(value)
                                         : value;
                                     url = url.replace(templatedString, value);
@@ -390,16 +390,16 @@
                                 $.each(optionalVariables, function (index, templatedString) {
                                     var
                                         // allow legacy {/$var} style
-                                        variable = (templatedString.indexOf('$') !== -1)
+                                        variable = templatedString.indexOf('$') !== -1
                                             ? templatedString.slice(3, -1)
                                             : templatedString.slice(2, -1),
-                                        value   = ($.isPlainObject(urlData) && urlData[variable] !== undefined)
+                                        value   = $.isPlainObject(urlData) && urlData[variable] !== undefined
                                             ? urlData[variable]
-                                            : ($module.data(variable) !== undefined)
+                                            : ($module.data(variable) !== undefined
                                                 ? $module.data(variable)
-                                                : ($context.data(variable) !== undefined)
+                                                : ($context.data(variable) !== undefined // eslint-disable-line unicorn/no-nested-ternary
                                                     ? $context.data(variable)
-                                                    : urlData[variable]
+                                                    : urlData[variable]))
                                     ;
                                     // optional replacement
                                     if (value !== undefined) {
@@ -478,7 +478,7 @@
                                 while (nameKeys.length > 0) {
                                     var k = nameKeys.pop();
 
-                                    if (k == '' && !Array.isArray(value)) { // foo[]
+                                    if (k === '' && !Array.isArray(value)) { // foo[]
                                         value = build([], pushes[pushKey]++, value);
                                     } else if (settings.regExp.fixed.test(k)) { // foo[n]
                                         value = build([], k, value);
@@ -525,7 +525,7 @@
                 event: {
                     trigger: function (event) {
                         module.query();
-                        if (event.type == 'submit' || event.type == 'click') {
+                        if (event.type === 'submit' || event.type === 'click') {
                             event.preventDefault();
                         }
                     },
@@ -536,15 +536,15 @@
                         done: function (response, textStatus, xhr) {
                             var
                                 context            = this,
-                                elapsedTime        = (Date.now() - requestStartTime),
-                                timeLeft           = (settings.loadingDuration - elapsedTime),
-                                translatedResponse = (isFunction(settings.onResponse))
-                                    ? module.is.expectingJSON() && !settings.rawResponse
+                                elapsedTime        = Date.now() - requestStartTime,
+                                timeLeft           = settings.loadingDuration - elapsedTime,
+                                translatedResponse = isFunction(settings.onResponse)
+                                    ? (module.is.expectingJSON() && !settings.rawResponse
                                         ? settings.onResponse.call(context, $.extend(true, {}, response))
-                                        : settings.onResponse.call(context, response)
+                                        : settings.onResponse.call(context, response))
                                     : false
                             ;
-                            timeLeft = (timeLeft > 0)
+                            timeLeft = timeLeft > 0
                                 ? timeLeft
                                 : 0;
                             if (translatedResponse) {
@@ -565,10 +565,10 @@
                         fail: function (xhr, status, httpMessage) {
                             var
                                 context     = this,
-                                elapsedTime = (Date.now() - requestStartTime),
-                                timeLeft    = (settings.loadingDuration - elapsedTime)
+                                elapsedTime = Date.now() - requestStartTime,
+                                timeLeft    = settings.loadingDuration - elapsedTime
                             ;
-                            timeLeft = (timeLeft > 0)
+                            timeLeft = timeLeft > 0
                                 ? timeLeft
                                 : 0;
                             if (timeLeft > 0) {
@@ -614,15 +614,15 @@
                                 response     = module.get.responseFromXHR(xhr),
                                 errorMessage = module.get.errorFromRequest(response, status, httpMessage)
                             ;
-                            if (status == 'aborted') {
+                            if (status === 'aborted') {
                                 module.debug('XHR Aborted (Most likely caused by page navigation or CORS Policy)', status, httpMessage);
                                 settings.onAbort.call(context, status, $module, xhr);
 
                                 return true;
                             }
-                            if (status == 'invalid') {
+                            if (status === 'invalid') {
                                 module.debug('JSON did not pass success test. A server-side error has most likely occurred', response);
-                            } else if (status == 'error') {
+                            } else if (status === 'error') {
                                 if (xhr !== undefined) {
                                     module.debug('XHR produced a server error', status, httpMessage);
                                     // make sure we have an error to display to console
@@ -748,17 +748,17 @@
                     },
                     responseFromXHR: function (xhr) {
                         return $.isPlainObject(xhr)
-                            ? (module.is.expectingJSON())
+                            ? (module.is.expectingJSON()
                                 ? module.decode.json(xhr.responseText)
-                                : xhr.responseText
+                                : xhr.responseText)
                             : false;
                     },
                     errorFromRequest: function (response, status, httpMessage) {
-                        return ($.isPlainObject(response) && response.error !== undefined)
+                        return $.isPlainObject(response) && response.error !== undefined
                             ? response.error // use json error message
-                            : (settings.error[status] !== undefined) // use server error message
+                            : (settings.error[status] !== undefined // use server error message
                                 ? settings.error[status]
-                                : httpMessage;
+                                : httpMessage);
                     },
                     request: function () {
                         return module.request || false;
@@ -795,7 +795,7 @@
                             return runSettings;
                         }
 
-                        return (runSettings !== undefined)
+                        return runSettings !== undefined
                             ? $.extend(true, {}, runSettings)
                             : $.extend(true, {}, settings);
                     },
@@ -803,7 +803,7 @@
                         var
                             decodedValue   = window.decodeURIComponent(value),
                             encodedValue   = window.encodeURIComponent(value),
-                            alreadyEncoded = (decodedValue !== value)
+                            alreadyEncoded = decodedValue !== value
                         ;
                         if (alreadyEncoded) {
                             module.debug('URL value is already encoded, avoiding double encoding', value);
@@ -829,18 +829,18 @@
                         return data;
                     },
                     event: function () {
-                        if (isWindow(element) || settings.on == 'now') {
+                        if (isWindow(element) || settings.on === 'now') {
                             module.debug('API called without element, no events attached');
 
                             return false;
                         }
-                        if (settings.on == 'auto') {
+                        if (settings.on === 'auto') {
                             if ($module.is('input')) {
-                                return (element.oninput !== undefined)
+                                return element.oninput !== undefined
                                     ? 'input'
-                                    : (element.onpropertychange !== undefined)
+                                    : (element.onpropertychange !== undefined
                                         ? 'propertychange'
-                                        : 'keyup';
+                                        : 'keyup');
                             }
                             if ($module.is('form')) {
                                 return 'submit';
@@ -1004,17 +1004,17 @@
                         query = query.split(/[ .]/);
                         maxDepth = query.length - 1;
                         $.each(query, function (depth, value) {
-                            var camelCaseValue = (depth != maxDepth)
+                            var camelCaseValue = depth !== maxDepth
                                 ? value + query[depth + 1].charAt(0).toUpperCase() + query[depth + 1].slice(1)
                                 : query
                             ;
-                            if ($.isPlainObject(object[camelCaseValue]) && (depth != maxDepth)) {
+                            if ($.isPlainObject(object[camelCaseValue]) && (depth !== maxDepth)) {
                                 object = object[camelCaseValue];
                             } else if (object[camelCaseValue] !== undefined) {
                                 found = object[camelCaseValue];
 
                                 return false;
-                            } else if ($.isPlainObject(object[value]) && (depth != maxDepth)) {
+                            } else if ($.isPlainObject(object[value]) && (depth !== maxDepth)) {
                                 object = object[value];
                             } else if (object[value] !== undefined) {
                                 found = object[value];
@@ -1057,7 +1057,7 @@
             }
         });
 
-        return (returnedValue !== undefined)
+        return returnedValue !== undefined
             ? returnedValue
             : this;
     };