fomantic-ui 2.9.1-beta.22 → 2.9.1-beta.24

package/examples/responsive.html

@@ -642,7 +642,7 @@
 <script type="text/javascript">
 $(document).ready(function() {
 
-  var
+  let
     $headers     = $('body > h3'),
     $header      = $headers.first(),
     ignoreScroll = false,

package/gulpfile.js

@@ -2,7 +2,7 @@
  *           Set-up
  *******************************/
 
-var
+const
     gulp   = require('gulp'),
 
     // read user config to know what task to load

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fomantic-ui",
-  "version": "2.9.1-beta.22+6a42d01",
+  "version": "2.9.1-beta.24+029436f",
   "description": "Fomantic empowers designers and developers by creating a shared vocabulary for UI.",
   "keywords": [
     "fomantic-ui",
@@ -73,6 +73,7 @@
     "yamljs": "^0.3.0"
   },
   "devDependencies": {
+    "@internal/eslint-plugin": "file:.eslint",
     "all-contributors-cli": "^6.7.0",
     "auto-changelog": "^2.4.0",
     "eslint": "^8.29.0",

package/scripts/nightly-version.js

@@ -4,8 +4,8 @@ const path = require('path');
 const childProcess = require('child_process');
 
 // npm
-const fetch = require('node-fetch');
-const semver = require('semver');
+const fetch = require('node-fetch'); // eslint-disable-line import/no-extraneous-dependencies
+const semver = require('semver'); // eslint-disable-line import/no-extraneous-dependencies
 const actions = require('@actions/core');
 
 // pkg
@@ -44,7 +44,9 @@ const getPublishedVersion = async function () {
             .then((p) => {
                 let nightly = p['dist-tags'].nightly ?? '';
                 let versionInfo = p.versions[nightly] ?? {};
-                let buildCommit = nightly.indexOf('+') === -1 && versionInfo.gitHead ? '+' + (versionInfo.gitHead ?? '').slice(0, 7) : '';
+                let buildCommit = nightly.indexOf('+') === -1 && versionInfo.gitHead
+                    ? '+' + (versionInfo.gitHead ?? '').slice(0, 7)
+                    : '';
 
                 return nightly + buildCommit;
             })
@@ -59,7 +61,7 @@ const getNightlyVersion = async function () {
         actions.setOutput('shouldPublish', false);
 
         console.log('No new commits since last publish. Exiting.');
-        process.exit(0);
+        process.exit(0); // eslint-disable-line unicorn/no-process-exit
 
         return;
     }

package/src/definitions/behaviors/api.js

@@ -19,22 +19,22 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = window !== undefined && window.Math === Math
         ? window
         : globalThis;
 
-    $.api = $.fn.api = function (parameters) {
+    $.fn.api = function (parameters) {
         var
             // use window context if none specified
             $allModules     = isFunction(this)
                 ? $(window)
                 : $(this),
             moduleSelector = $allModules.selector || '',
-            time           = new Date().getTime(),
+            time           = Date.now(),
             performance    = [],
 
             query          = arguments[0],
-            methodInvoked  = (typeof query == 'string'),
+            methodInvoked  = typeof query === 'string',
             queryArguments = [].slice.call(arguments, 1),
 
             returnedValue
@@ -42,7 +42,7 @@
 
         $allModules.each(function () {
             var
-                settings          = ($.isPlainObject(parameters))
+                settings          = $.isPlainObject(parameters)
                     ? $.extend(true, {}, $.fn.api.settings, parameters)
                     : $.extend({}, $.fn.api.settings),
 
@@ -62,7 +62,7 @@
                 $form           = $module.closest(selector.form),
 
                 // context used for state
-                $context        = (settings.stateContext)
+                $context        = settings.stateContext
                     ? ([window, document].indexOf(settings.stateContext) < 0 ? $(document).find(settings.stateContext) : $(settings.stateContext))
                     : $module,
 
@@ -126,7 +126,7 @@
 
                 decode: {
                     json: function (response) {
-                        if (response !== undefined && typeof response == 'string') {
+                        if (response !== undefined && typeof response === 'string') {
                             try {
                                 response = JSON.parse(response);
                             } catch (e) {
@@ -207,10 +207,10 @@
                         module.error(error.beforeSend);
 
                         return;
-                    } else {
-                        module.cancelled = false;
                     }
 
+                    module.cancelled = false;
+
                     // get url
                     url = module.get.templatedURL();
 
@@ -274,13 +274,13 @@
 
                 should: {
                     removeError: function () {
-                        return (settings.hideError === true || (settings.hideError === 'auto' && !module.is.form()));
+                        return settings.hideError === true || (settings.hideError === 'auto' && !module.is.form());
                     },
                 },
 
                 is: {
                     disabled: function () {
-                        return ($module.filter(selector.disabled).length > 0);
+                        return $module.filter(selector.disabled).length > 0;
                     },
                     expectingJSON: function () {
                         return settings.dataType === 'json' || settings.dataType === 'jsonp';
@@ -289,14 +289,14 @@
                         return $module.is('form') || $context.is('form');
                     },
                     mocked: function () {
-                        return (settings.mockResponse || settings.mockResponseAsync || settings.response || settings.responseAsync);
+                        return settings.mockResponse || settings.mockResponseAsync || settings.response || settings.responseAsync;
                     },
                     input: function () {
                         return $module.is('input');
                     },
                     loading: function () {
-                        return (module.request)
-                            ? (module.request.state() == 'pending')
+                        return module.request
+                            ? module.request.state() == 'pending'
                             : false;
                     },
                     abortedRequest: function (xhr) {
@@ -304,14 +304,14 @@
                             module.verbose('XHR request determined to be aborted');
 
                             return true;
-                        } else {
-                            module.verbose('XHR request was not aborted');
-
-                            return false;
                         }
+
+                        module.verbose('XHR request was not aborted');
+
+                        return false;
                     },
                     validResponse: function (response) {
-                        if ((!module.is.expectingJSON()) || !isFunction(settings.successTest)) {
+                        if (!module.is.expectingJSON() || !isFunction(settings.successTest)) {
                             module.verbose('Response is not JSON, skipping validation', settings.successTest, response);
 
                             return true;
@@ -321,26 +321,26 @@
                             module.debug('Response passed success test', response);
 
                             return true;
-                        } else {
-                            module.debug('Response failed success test', response);
-
-                            return false;
                         }
+
+                        module.debug('Response failed success test', response);
+
+                        return false;
                     },
                 },
 
                 was: {
                     cancelled: function () {
-                        return (module.cancelled || false);
+                        return module.cancelled || false;
                     },
                     successful: function () {
-                        return (module.request && module.request.state() == 'resolved');
+                        return module.request && module.request.state() == 'resolved';
                     },
                     failure: function () {
-                        return (module.request && module.request.state() == 'rejected');
+                        return module.request && module.request.state() == 'rejected';
                     },
                     complete: function () {
-                        return (module.request && (module.request.state() == 'resolved' || module.request.state() == 'rejected'));
+                        return module.request && (module.request.state() == 'resolved' || module.request.state() == 'rejected');
                     },
                 },
 
@@ -359,16 +359,16 @@
                                 $.each(requiredVariables, function (index, templatedString) {
                                     var
                                         // allow legacy {$var} style
-                                        variable = (templatedString.indexOf('$') !== -1)
+                                        variable = templatedString.indexOf('$') !== -1
                                             ? templatedString.slice(2, -1)
                                             : templatedString.slice(1, -1),
-                                        value   = ($.isPlainObject(urlData) && urlData[variable] !== undefined)
+                                        value   = $.isPlainObject(urlData) && urlData[variable] !== undefined
                                             ? urlData[variable]
-                                            : ($module.data(variable) !== undefined)
+                                            : ($module.data(variable) !== undefined
                                                 ? $module.data(variable)
-                                                : ($context.data(variable) !== undefined)
+                                                : ($context.data(variable) !== undefined // eslint-disable-line unicorn/no-nested-ternary
                                                     ? $context.data(variable)
-                                                    : urlData[variable]
+                                                    : urlData[variable]))
                                     ;
                                     // remove value
                                     if (value === undefined) {
@@ -376,13 +376,13 @@
                                         url = false;
 
                                         return false;
-                                    } else {
-                                        module.verbose('Found required variable', variable, value);
-                                        value = (settings.encodeParameters)
-                                            ? module.get.urlEncodedValue(value)
-                                            : value;
-                                        url = url.replace(templatedString, value);
                                     }
+
+                                    module.verbose('Found required variable', variable, value);
+                                    value = settings.encodeParameters
+                                        ? module.get.urlEncodedValue(value)
+                                        : value;
+                                    url = url.replace(templatedString, value);
                                 });
                             }
                             if (optionalVariables) {
@@ -390,16 +390,16 @@
                                 $.each(optionalVariables, function (index, templatedString) {
                                     var
                                         // allow legacy {/$var} style
-                                        variable = (templatedString.indexOf('$') !== -1)
+                                        variable = templatedString.indexOf('$') !== -1
                                             ? templatedString.slice(3, -1)
                                             : templatedString.slice(2, -1),
-                                        value   = ($.isPlainObject(urlData) && urlData[variable] !== undefined)
+                                        value   = $.isPlainObject(urlData) && urlData[variable] !== undefined
                                             ? urlData[variable]
-                                            : ($module.data(variable) !== undefined)
+                                            : ($module.data(variable) !== undefined
                                                 ? $module.data(variable)
-                                                : ($context.data(variable) !== undefined)
+                                                : ($context.data(variable) !== undefined // eslint-disable-line unicorn/no-nested-ternary
                                                     ? $context.data(variable)
-                                                    : urlData[variable]
+                                                    : urlData[variable]))
                                     ;
                                     // optional replacement
                                     if (value !== undefined) {
@@ -408,11 +408,9 @@
                                     } else {
                                         module.verbose('Optional variable not found', variable);
                                         // remove preceding slash if set
-                                        if (url.indexOf('/' + templatedString) !== -1) {
-                                            url = url.replace('/' + templatedString, '');
-                                        } else {
-                                            url = url.replace(templatedString, '');
-                                        }
+                                        url = url.indexOf('/' + templatedString) !== -1
+                                            ? url.replace('/' + templatedString, '')
+                                            : url.replace(templatedString, '');
                                     }
                                 });
                             }
@@ -431,8 +429,8 @@
 
                         if (useFormDataApi) {
                             formData = new FormData($form[0]);
-                            settings.processData = typeof settings.processData !== 'undefined' ? settings.processData : false;
-                            settings.contentType = typeof settings.contentType !== 'undefined' ? settings.contentType : false;
+                            settings.processData = settings.processData !== undefined ? settings.processData : false;
+                            settings.contentType = settings.contentType !== undefined ? settings.contentType : false;
                         } else {
                             var
                                 formArray = $form.serializeArray(),
@@ -463,8 +461,7 @@
                                             ? floatValue
                                             : (el.value === 'false' ? false : el.value)),
                                     nameKeys = el.name.match(settings.regExp.key) || [],
-                                    k,
-                                    pushKey = el.name.replace(/\[\]$/, '')
+                                    pushKey = el.name.replace(/\[]$/, '')
                                 ;
                                 if (!(pushKey in pushes)) {
                                     pushes[pushKey] = 0;
@@ -478,7 +475,9 @@
                                     value = pushValues[pushKey];
                                 }
 
-                                while ((k = nameKeys.pop()) !== undefined) {
+                                while (nameKeys.length > 0) {
+                                    var k = nameKeys.pop();
+
                                     if (k == '' && !Array.isArray(value)) { // foo[]
                                         value = build([], pushes[pushKey]++, value);
                                     } else if (settings.regExp.fixed.test(k)) { // foo[n]
@@ -537,15 +536,15 @@
                         done: function (response, textStatus, xhr) {
                             var
                                 context            = this,
-                                elapsedTime        = (new Date().getTime() - requestStartTime),
-                                timeLeft           = (settings.loadingDuration - elapsedTime),
-                                translatedResponse = (isFunction(settings.onResponse))
-                                    ? module.is.expectingJSON() && !settings.rawResponse
+                                elapsedTime        = Date.now() - requestStartTime,
+                                timeLeft           = settings.loadingDuration - elapsedTime,
+                                translatedResponse = isFunction(settings.onResponse)
+                                    ? (module.is.expectingJSON() && !settings.rawResponse
                                         ? settings.onResponse.call(context, $.extend(true, {}, response))
-                                        : settings.onResponse.call(context, response)
+                                        : settings.onResponse.call(context, response))
                                     : false
                             ;
-                            timeLeft = (timeLeft > 0)
+                            timeLeft = timeLeft > 0
                                 ? timeLeft
                                 : 0;
                             if (translatedResponse) {
@@ -566,10 +565,10 @@
                         fail: function (xhr, status, httpMessage) {
                             var
                                 context     = this,
-                                elapsedTime = (new Date().getTime() - requestStartTime),
-                                timeLeft    = (settings.loadingDuration - elapsedTime)
+                                elapsedTime = Date.now() - requestStartTime,
+                                timeLeft    = settings.loadingDuration - elapsedTime
                             ;
-                            timeLeft = (timeLeft > 0)
+                            timeLeft = timeLeft > 0
                                 ? timeLeft
                                 : 0;
                             if (timeLeft > 0) {
@@ -620,7 +619,8 @@
                                 settings.onAbort.call(context, status, $module, xhr);
 
                                 return true;
-                            } else if (status == 'invalid') {
+                            }
+                            if (status == 'invalid') {
                                 module.debug('JSON did not pass success test. A server-side error has most likely occurred', response);
                             } else if (status == 'error') {
                                 if (xhr !== undefined) {
@@ -727,7 +727,7 @@
                     loading: function () {
                         module.verbose('Adding loading state to element', $context);
                         $context.addClass(className.loading);
-                        requestStartTime = new Date().getTime();
+                        requestStartTime = Date.now();
                     },
                 },
 
@@ -748,17 +748,17 @@
                     },
                     responseFromXHR: function (xhr) {
                         return $.isPlainObject(xhr)
-                            ? (module.is.expectingJSON())
+                            ? (module.is.expectingJSON()
                                 ? module.decode.json(xhr.responseText)
-                                : xhr.responseText
+                                : xhr.responseText)
                             : false;
                     },
                     errorFromRequest: function (response, status, httpMessage) {
-                        return ($.isPlainObject(response) && response.error !== undefined)
+                        return $.isPlainObject(response) && response.error !== undefined
                             ? response.error // use json error message
-                            : (settings.error[status] !== undefined) // use server error message
+                            : (settings.error[status] !== undefined // use server error message
                                 ? settings.error[status]
-                                : httpMessage;
+                                : httpMessage);
                     },
                     request: function () {
                         return module.request || false;
@@ -795,7 +795,7 @@
                             return runSettings;
                         }
 
-                        return (runSettings !== undefined)
+                        return runSettings !== undefined
                             ? $.extend(true, {}, runSettings)
                             : $.extend(true, {}, settings);
                     },
@@ -803,7 +803,7 @@
                         var
                             decodedValue   = window.decodeURIComponent(value),
                             encodedValue   = window.encodeURIComponent(value),
-                            alreadyEncoded = (decodedValue !== value)
+                            alreadyEncoded = decodedValue !== value
                         ;
                         if (alreadyEncoded) {
                             module.debug('URL value is already encoded, avoiding double encoding', value);
@@ -821,9 +821,7 @@
                         if (!isWindow(element)) {
                             if (module.is.input()) {
                                 data.value = $module.val();
-                            } else if (module.is.form()) {
-
-                            } else {
+                            } else if (!module.is.form()) {
                                 data.text = $module.text();
                             }
                         }
@@ -835,21 +833,23 @@
                             module.debug('API called without element, no events attached');
 
                             return false;
-                        } else if (settings.on == 'auto') {
+                        }
+                        if (settings.on == 'auto') {
                             if ($module.is('input')) {
-                                return (element.oninput !== undefined)
+                                return element.oninput !== undefined
                                     ? 'input'
-                                    : (element.onpropertychange !== undefined)
+                                    : (element.onpropertychange !== undefined
                                         ? 'propertychange'
-                                        : 'keyup';
-                            } else if ($module.is('form')) {
+                                        : 'keyup');
+                            }
+                            if ($module.is('form')) {
                                 return 'submit';
-                            } else {
-                                return 'click';
                             }
-                        } else {
-                            return settings.on;
+
+                            return 'click';
                         }
+
+                        return settings.on;
                     },
                     templatedURL: function (action) {
                         action = action || $module.data(metadata.action) || settings.action || false;
@@ -949,7 +949,7 @@
                             previousTime
                         ;
                         if (settings.performance) {
-                            currentTime = new Date().getTime();
+                            currentTime = Date.now();
                             previousTime = time || currentTime;
                             executionTime = currentTime - previousTime;
                             time = currentTime;
@@ -1000,11 +1000,11 @@
                     ;
                     passedArguments = passedArguments || queryArguments;
                     context = context || element;
-                    if (typeof query == 'string' && object !== undefined) {
-                        query = query.split(/[\. ]/);
+                    if (typeof query === 'string' && object !== undefined) {
+                        query = query.split(/[ .]/);
                         maxDepth = query.length - 1;
                         $.each(query, function (depth, value) {
-                            var camelCaseValue = (depth != maxDepth)
+                            var camelCaseValue = depth != maxDepth
                                 ? value + query[depth + 1].charAt(0).toUpperCase() + query[depth + 1].slice(1)
                                 : query
                             ;
@@ -1057,10 +1057,11 @@
             }
         });
 
-        return (returnedValue !== undefined)
+        return returnedValue !== undefined
             ? returnedValue
             : this;
     };
+    $.api = $.fn.api;
 
     $.api.settings = {
 
@@ -1186,13 +1187,13 @@
         },
 
         regExp: {
-            required: /\{\$*[a-z0-9]+\}/gi,
-            optional: /\{\/\$*[a-z0-9]+\}/gi,
-            validate: /^[a-z_][a-z0-9_-]*(?:\[[a-z0-9_-]*\])*$/i,
-            key: /[a-z0-9_-]+|(?=\[\])/gi,
+            required: /{\$*[\da-z]+}/gi,
+            optional: /{\/\$*[\da-z]+}/gi,
+            validate: /^[_a-z][\w-]*(?:\[[\w-]*])*$/i,
+            key: /[\w-]+|(?=\[])/gi,
             push: /^$/,
             fixed: /^\d+$/,
-            named: /^[a-z0-9_-]+$/i,
+            named: /^[\w-]+$/i,
         },
 
         className: {