fomantic-ui 2.9.1-beta.22 → 2.9.1-beta.23

package/tasks/config/tasks.js

@@ -1,15 +1,15 @@
-var
+let
     browserslist = require('browserslist'),
     console = require('better-console'),
     config  = require('./user'),
     release = require('./project/release')
 ;
 
-var defaultBrowsers = browserslist(browserslist.defaults);
-var userBrowsers = browserslist();
-var hasBrowserslistConfig = JSON.stringify(defaultBrowsers) !== JSON.stringify(userBrowsers);
+let defaultBrowsers = browserslist(browserslist.defaults);
+let userBrowsers = browserslist();
+let hasBrowserslistConfig = JSON.stringify(defaultBrowsers) !== JSON.stringify(userBrowsers);
 
-var overrideBrowserslist = hasBrowserslistConfig ? undefined : [
+let overrideBrowserslist = hasBrowserslistConfig ? undefined : [
     'last 2 versions',
     '> 1%',
     'opera 12.1',
@@ -18,9 +18,7 @@ var overrideBrowserslist = hasBrowserslistConfig ? undefined : [
 ];
 
 // Node 12 does not support ??, so a little polyfill
-var nullish = (value, fallback) => {
-    return value !== undefined && value !== null ? value : fallback;
-};
+let nullish = (value, fallback) => (value !== undefined && value !== null ? value : fallback);
 
 module.exports = {
 
@@ -55,32 +53,32 @@ module.exports = {
 
             // remove all comments from config files (.variable)
             variables: {
-                in: /(\/\*[\s\S]+?\*\/+)[\s\S]+?\/\* End Config \*\//,
+                in: /(\/\*[\S\s]+?\*\/+)[\S\s]+?\/\* End Config \*\//,
                 out: '$1',
             },
 
             // add version to first comment
             license: {
-                in: /(^\/\*[\s\S]+)(# Fomantic-UI )([\s\S]+?\*\/)/,
+                in: /(^\/\*[\S\s]+)(# Fomantic-UI )([\S\s]+?\*\/)/,
                 out: '$1$2' + release.version + ' $3',
             },
 
             // adds uniform spacing around comments
             large: {
-                in: /(\/\*\*\*\*[\s\S]+?\*\/)/mg,
+                in: /(\/\*{4}[\S\s]+?\*\/)/gm,
                 out: '\n\n$1\n',
             },
             small: {
-                in: /(\/\*---[\s\S]+?\*\/)/mg,
+                in: /(\/\*---[\S\s]+?\*\/)/gm,
                 out: '\n$1\n',
             },
             tiny: {
-                in: /(\/\* [\s\S]+? \*\/)/mg,
+                in: /(\/\* [\S\s]+? \*\/)/gm,
                 out: '\n$1',
             },
         },
 
-        theme: /.*(\/|\\)themes(\/|\\).*?(?=(\/|\\))/mg,
+        theme: /.*(\/|\\)themes(\/|\\).*?(?=(\/|\\))/gm,
 
     },
 
@@ -107,20 +105,20 @@ module.exports = {
         plumber: {
             less: {
                 errorHandler: function (error) {
-                    var
+                    let
                         regExp = {
                             variable: /@(\S.*?)\s/,
-                            theme: /themes[\/\\]+(.*?)[\/\\].*/,
-                            element: /[\/\\]([^\/\\*]*)\.overrides/,
+                            theme: /themes[/\\]+(.*?)[/\\].*/,
+                            element: /[/\\]([^*/\\]*)\.overrides/,
                         },
                         theme,
                         element
                     ;
-                    if (error && error.filename && error.filename.match(/theme.less/)) {
+                    if (error && error.filename && /theme.less/.test(error.filename)) {
                         if (error.line == 9) {
                             element = regExp.variable.exec(error.message)[1];
                             if (element) {
-                                console.error('Missing theme.config value for ', element);
+                                console.error('Missing theme.config value for', element);
                             }
                             console.error('Most likely new UI was added in an update. You will need to add missing elements from theme.config.example');
                         } else if (error.line == 84) {

package/tasks/config/user.js

@@ -2,7 +2,7 @@
              Set-up
 *******************************/
 
-var
+let
     // npm dependencies
     extend          = require('extend'),
     fs              = require('fs'),

package/tasks/docs/build.js

@@ -2,7 +2,8 @@
  Build Docs
  *******************************/
 
-var
+let
+    extend      = require('extend'),
     gulp        = require('gulp'),
 
     // node dependencies
@@ -14,7 +15,7 @@ var
     print       = require('gulp-print').default,
 
     // user config
-    config      = require('../config/docs'),
+    configDocs      = require('../config/docs'),
 
     // install config
     tasks       = require('../config/tasks'),
@@ -35,7 +36,8 @@ var
 
 module.exports = function (callback) {
     // use a different config
-    config = configSetup.addDerivedValues(config);
+    const config = extend(true, {}, configDocs);
+    configSetup.addDerivedValues(config);
 
     // shorthand
     const globs  = config.globs;

package/tasks/docs/metadata.js

@@ -2,14 +2,14 @@
            Summarize Docs
 *******************************/
 
-var
+let
     // node dependencies
     console      = require('better-console'),
     fs           = require('fs'),
     YAML         = require('yamljs')
 ;
 
-var data = {};
+let data = {};
 
 /**
  * Test for prefix in string.
@@ -22,8 +22,8 @@ function startsWith(str, prefix) {
 }
 
 function inArray(needle, haystack) {
-    var length = haystack.length;
-    for (var i = 0; i < length; i++) {
+    let length = haystack.length;
+    for (let i = 0; i < length; i++) {
         if (haystack[i] == needle) {
             return true;
         }
@@ -49,7 +49,7 @@ function parser(file, callback) {
     }
 
     try {
-        var
+        let
             /** @type {string} */
             text     = String(file.contents.toString('utf8')),
             lines    = text.split('\n'),
@@ -68,7 +68,7 @@ function parser(file, callback) {
 
         filename = filename.slice(position + key.length + 1, filename.length);
 
-        var
+        let
             lineCount = lines.length,
             active    = false,
             yaml      = [],
@@ -109,7 +109,6 @@ function parser(file, callback) {
             meta.category = meta.type;
             meta.filename = filename;
             meta.url = '/' + filename;
-            meta.title = meta.title;
             // Primary key will by filepath
             data[meta.element] = meta;
         } else {
@@ -117,7 +116,7 @@ function parser(file, callback) {
             // console.log(meta);
         }
     } catch (error) {
-        console.log(error, filename);
+        console.log(error, file.path);
     }
 
     callback(null, file);

package/tasks/docs/serve.js

@@ -1,7 +1,8 @@
 /*******************************
  Serve Docs
  *******************************/
-var
+let
+    extend      = require('extend'),
     gulp        = require('gulp'),
 
     // node dependencies
@@ -11,7 +12,7 @@ var
     print       = require('gulp-print').default,
 
     // user config
-    config      = require('../config/docs'),
+    configDocs      = require('../config/docs'),
 
     // task config
     tasks       = require('../config/tasks'),
@@ -27,7 +28,8 @@ var
 
 module.exports = function () {
     // use a different config
-    config = configSetup.addDerivedValues(config);
+    const config = extend(true, {}, configDocs);
+    configSetup.addDerivedValues(config);
 
     console.clear();
     console.log('Watching source files for changes');

package/tasks/install.js

@@ -13,7 +13,7 @@
    * Standard installer runs asking for paths to site files etc
 */
 
-var
+let
     gulp           = require('gulp'),
 
     // node dependencies
@@ -54,7 +54,7 @@ var
 
 // Export install task
 module.exports = function (callback) {
-    var
+    let
         currentConfig = requireDotFile('semantic.json', process.cwd()),
         manager       = install.getPackageManager(),
         rootQuestions = questions.root,
@@ -84,7 +84,7 @@ module.exports = function (callback) {
 
     // run update scripts if semantic.json exists
     if (currentConfig && manager.name === 'NPM') {
-        var
+        let
             updateFolder = path.join(manager.root, currentConfig.base),
             updatePaths  = {
                 config: path.join(manager.root, files.config),
@@ -141,21 +141,21 @@ module.exports = function (callback) {
                     .pipe(gulp.dest(manager.root))
                 ;
 
-                console.info('Update complete! Run "\x1b[92mgulp build\x1b[0m" to rebuild dist/ files.');
+                console.info('Update complete! Run "\u001B[92mgulp build\u001B[0m" to rebuild dist/ files.');
 
                 callback();
 
-                return;
-            } else {
-                console.log('Current version of Fomantic UI already installed');
-                callback();
-
                 return;
             }
-        } else {
-            console.error('Cannot locate files to update at path: ', updatePaths.definition);
-            console.log('Running installer');
+
+            console.log('Current version of Fomantic UI already installed');
+            callback();
+
+            return;
         }
+
+        console.error('Cannot locate files to update at path:', updatePaths.definition);
+        console.log('Running installer');
     }
 
     /* --------------
@@ -226,7 +226,7 @@ module.exports = function (callback) {
              Paths
         --------------- */
 
-        var
+        let
             installPaths = {
                 config: files.config,
                 configFolder: folders.config,
@@ -267,8 +267,8 @@ module.exports = function (callback) {
             installFolder = path.join(manager.root, answers.semanticRoot);
 
             // add install folder to all output paths
-            for (var destination in installPaths) {
-                if (installPaths.hasOwnProperty(destination)) {
+            for (let destination in installPaths) {
+                if (Object.prototype.hasOwnProperty.call(installPaths, destination)) {
                     // config goes in project root, rest in install folder
                     installPaths[destination] = (destination == 'config' || destination == 'configFolder')
                         ? path.normalize(path.join(manager.root, installPaths[destination]))
@@ -286,7 +286,7 @@ module.exports = function (callback) {
                 console.error('NPM does not have permissions to create folders at your specified path. Adjust your folders permissions and run "npm install" again');
             }
 
-            console.log('Installing to \x1b[92m' + answers.semanticRoot + '\x1b[0m');
+            console.log('Installing to \u001B[92m' + answers.semanticRoot + '\u001B[0m');
 
             console.info('Copying UI definitions');
             wrench.copyDirSyncRecursive(source.definitions, installPaths.definition, settings.wrench.overwrite);
@@ -334,7 +334,7 @@ module.exports = function (callback) {
         --------------- */
 
         gulp.task('create theme.config', function () {
-            var
+            let
                 // determine path to site theme folder from theme config
                 // force CSS path variable to use forward slashes for paths
                 pathToSite   = path.relative(path.resolve(installPaths.themeConfigFolder), path.resolve(installPaths.site)).replace(/\\/g, '/'),
@@ -342,7 +342,7 @@ module.exports = function (callback) {
             ;
 
             // rewrite site variable in theme.less
-            console.info('Adjusting @siteFolder to: ', pathToSite + '/');
+            console.info('Adjusting @siteFolder to:', pathToSite + '/');
 
             if (fs.existsSync(installPaths.themeConfig)) {
                 console.info('Modifying src/theme.config (LESS config)', installPaths.themeConfig);
@@ -352,16 +352,16 @@ module.exports = function (callback) {
                     .pipe(replace(regExp.siteVariable, siteVariable))
                     .pipe(gulp.dest(installPaths.themeConfigFolder))
                 ;
-            } else {
-                console.info('Creating src/theme.config (LESS config)', installPaths.themeConfig);
-
-                return gulp.src(source.themeConfig)
-                    .pipe(plumber())
-                    .pipe(rename({ extname: '' }))
-                    .pipe(replace(regExp.siteVariable, siteVariable))
-                    .pipe(gulp.dest(installPaths.themeConfigFolder))
-                ;
             }
+
+            console.info('Creating src/theme.config (LESS config)', installPaths.themeConfig);
+
+            return gulp.src(source.themeConfig)
+                .pipe(plumber())
+                .pipe(rename({ extname: '' }))
+                .pipe(replace(regExp.siteVariable, siteVariable))
+                .pipe(gulp.dest(installPaths.themeConfigFolder))
+            ;
         });
 
         /* --------------
@@ -369,7 +369,7 @@ module.exports = function (callback) {
         --------------- */
 
         gulp.task('create semantic.json', function () {
-            var
+            let
                 jsonConfig = install.createJSON(answers)
             ;
 
@@ -383,16 +383,16 @@ module.exports = function (callback) {
                     .pipe(jsonEditor(jsonConfig))
                     .pipe(gulp.dest(installPaths.configFolder))
                 ;
-            } else {
-                console.info('Creating config file (semantic.json)', installPaths.config);
-
-                return gulp.src(source.config)
-                    .pipe(plumber())
-                    .pipe(rename({ extname: '' })) // remove .template from ext
-                    .pipe(jsonEditor(jsonConfig, { end_with_newline: true }))
-                    .pipe(gulp.dest(installPaths.configFolder))
-                ;
             }
+
+            console.info('Creating config file (semantic.json)', installPaths.config);
+
+            return gulp.src(source.config)
+                .pipe(plumber())
+                .pipe(rename({ extname: '' })) // remove .template from ext
+                .pipe(jsonEditor(jsonConfig, { end_with_newline: true }))
+                .pipe(gulp.dest(installPaths.configFolder))
+            ;
         });
 
         gulp.series('create theme.config', 'create semantic.json')(callback);
@@ -401,7 +401,7 @@ module.exports = function (callback) {
     gulp.task('clean up install', function (callback) {
         // Completion Message
         if (installFolder && !install.shouldAutoInstall()) {
-            console.log('\n Setup Complete! \n Installing Peer Dependencies. \x1b[0;31mPlease refrain from ctrl + c\x1b[0m... \n After completion navigate to \x1b[92m' + answers.semanticRoot + '\x1b[0m and run "\x1b[92mgulp build\x1b[0m" to build');
+            console.log('\n Setup Complete! \n Installing Peer Dependencies. \u001B[0;31mPlease refrain from ctrl + c\u001B[0m... \n After completion navigate to \u001B[92m' + answers.semanticRoot + '\u001B[0m and run "\u001B[92mgulp build\u001B[0m" to build');
             callback();
         } else {
             console.log('');

package/tasks/rtl/build.js

@@ -2,7 +2,7 @@
  *         Build Task
  *******************************/
 
-var
+let
     gulp = require('gulp')
 ;
 

package/tasks/rtl/watch.js

@@ -2,7 +2,7 @@
  *          Watch Task
  *******************************/
 
-var
+let
     gulp = require('gulp')
 ;
 

package/tasks/version.js

@@ -2,7 +2,7 @@
           Version Task
 *******************************/
 
-var
+let
     release = require('./config/project/release')
 ;
 

package/tasks/watch.js

@@ -2,7 +2,7 @@
  *          Watch Task
  *******************************/
 
-var
+let
     gulp       = require('gulp'),
 
     // node dependencies

package/test/.eslintrc.js

@@ -9,10 +9,6 @@ module.exports = {
     },
     rules: {
         'jest/no-disabled-tests': 'off',
-
-        // TODO rare errors
-        'jest/no-jasmine-globals': 'off',
-        'jest/no-test-prefixes': 'off',
     },
     globals: {
         jQuery: false,

package/test/meteor/assets.js

@@ -1,4 +1,4 @@
-var assets = [
+let assets = [
     'dist/themes/default/assets/images/flags.png',
 ];
 

package/test/modules/module.spec.js

@@ -1,12 +1,12 @@
 function moduleTests(ui) {
-    var
+    let
         module    = ui.module,
         element   = ui.element,
         singleton = ui.singleton,
         name      = $.fn[module].settings.name,
 
         testValue = 'Test',
-        fixtures  = jasmine.getFixtures(),
+        fixtures  = jasmine.getFixtures(), // eslint-disable-line jest/no-jasmine-globals
 
         originalSettings,
         $modules,
@@ -59,18 +59,18 @@ function moduleTests(ui) {
     -------------------- */
     describe('Module', function () {
         it('allows chaining when no settings returned', function () {
-            var $chain = $modules[module]();
+            let $chain = $modules[module]();
             expect($chain).toExist();
             expect($chain.size()).toBe($modules.size());
         });
 
         it('returns a string when one setting returned', function () {
-            var result = $oneModule[module]('setting', 'name');
+            let result = $oneModule[module]('setting', 'name');
             expect(typeof result).toBe('string');
         });
 
         it('returns an array when multiple settings returned', function () {
-            var result = $modules[module]('setting', 'name');
+            let result = $modules[module]('setting', 'name');
             expect($.isArray(result)).toBeTruthy();
         });
 
@@ -90,7 +90,7 @@ function moduleTests(ui) {
                 name: testValue,
             });
 
-            var retrievedValue = $oneModule[module]('setting', 'name');
+            let retrievedValue = $oneModule[module]('setting', 'name');
             expect(retrievedValue).toBe(testValue);
 
             // reinit
@@ -103,7 +103,7 @@ function moduleTests(ui) {
             $.fn[module].settings.name = testValue;
             $oneModule[module]();
 
-            var retrievedValue = $oneModule[module]('setting', 'name');
+            let retrievedValue = $oneModule[module]('setting', 'name');
             $.fn[module].settings.name = name;
 
             expect(retrievedValue).toBe(testValue);
@@ -114,7 +114,7 @@ function moduleTests(ui) {
                 name: testValue,
             });
 
-            var retrievedValue = $oneModule[module]('setting', 'name');
+            let retrievedValue = $oneModule[module]('setting', 'name');
 
             expect(retrievedValue).toBe(testValue);
         });
@@ -122,7 +122,7 @@ function moduleTests(ui) {
         it('allows settings to be changed during runtime', function () {
             $oneModule[module]();
 
-            var retrievedValue = $oneModule[module]('setting', 'name');
+            let retrievedValue = $oneModule[module]('setting', 'name');
 
             expect(retrievedValue).toBe(name);
         });
@@ -137,8 +137,8 @@ function moduleTests(ui) {
             it('creates settings for all instances', function () {
                 $modules[module]('setting', 'name', testValue);
 
-                var retrievedValue = $oneModule[module]('setting', 'name');
-                var clonedSetting  = $clone[module]('setting', 'name');
+                let retrievedValue = $oneModule[module]('setting', 'name');
+                let clonedSetting  = $clone[module]('setting', 'name');
 
                 expect(retrievedValue).toBe(testValue);
                 expect(clonedSetting).toBe(testValue);
@@ -155,8 +155,8 @@ function moduleTests(ui) {
                 $modules[module]();
                 $oneModule[module]('setting', 'name', testValue);
 
-                var retrievedValue = $oneModule[module]('setting', 'name');
-                var clonedSetting  = $clone[module]('setting', 'name');
+                let retrievedValue = $oneModule[module]('setting', 'name');
+                let clonedSetting  = $clone[module]('setting', 'name');
 
                 expect(retrievedValue).toBe(testValue);
                 expect(clonedSetting).toBe(name);
@@ -169,8 +169,8 @@ function moduleTests(ui) {
                     name: testValue,
                 });
 
-                var retrievedValue = $oneModule[module]('setting', 'name');
-                var clonedSetting  = $clone[module]('setting', 'name');
+                let retrievedValue = $oneModule[module]('setting', 'name');
+                let clonedSetting  = $clone[module]('setting', 'name');
 
                 expect(retrievedValue).toBe(testValue);
                 expect(clonedSetting).toBe(name);

package/test/modules/popup.spec.js

@@ -1,4 +1,4 @@
-xdescribe('UI Popup', function () {
+describe.skip('UI Popup', function () {
     moduleTests({
         module: 'popup',
         element: 'i.icon',

package/test/modules/search.spec.js

@@ -1,4 +1,4 @@
-xdescribe('UI Search', function () {
+describe.skip('UI Search', function () {
     moduleTests({
         module: 'search',
         element: '.ui.search',

package/test/modules/tab.spec.js

@@ -1,4 +1,4 @@
-xdescribe('UI Tab', function () {
+describe.skip('UI Tab', function () {
     moduleTests({
         module: 'tab',
         element: '.ui.menu .item',

package/test/modules/transition.spec.js

@@ -1,4 +1,4 @@
-xdescribe('UI Transition', function () {
+describe.skip('UI Transition', function () {
     moduleTests({
         module: 'transition',
         element: '.ui.image',