fomantic-ui 2.9.1-beta.21 → 2.9.1-beta.23

package/src/definitions/modules/dimmer.js

@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math === Math)
         ? window
         : globalThis;
 
@@ -23,11 +23,11 @@
         var
             $allModules     = $(this),
 
-            time            = new Date().getTime(),
+            time            = Date.now(),
             performance     = [],
 
             query           = arguments[0],
-            methodInvoked   = (typeof query == 'string'),
+            methodInvoked   = (typeof query === 'string'),
             queryArguments  = [].slice.call(arguments, 1),
 
             returnedValue
@@ -70,11 +70,9 @@
                     } else {
                         $dimmable = $module;
                         if (module.has.dimmer()) {
-                            if (settings.dimmerName) {
-                                $dimmer = $dimmable.find(selector.dimmer).filter('.' + settings.dimmerName);
-                            } else {
-                                $dimmer = $dimmable.find(selector.dimmer);
-                            }
+                            $dimmer = settings.dimmerName
+                                ? $dimmable.find(selector.dimmer).filter('.' + settings.dimmerName)
+                                : $dimmable.find(selector.dimmer);
                         } else {
                             $dimmer = module.create();
                         }
@@ -336,9 +334,9 @@
                     duration: function () {
                         if (module.is.active()) {
                             return settings.transition.hideDuration || settings.duration.hide || settings.duration;
-                        } else {
-                            return settings.transition.showDuration || settings.duration.show || settings.duration;
                         }
+
+                        return settings.transition.showDuration || settings.duration.show || settings.duration;
                     },
                 },
 
@@ -346,9 +344,9 @@
                     dimmer: function () {
                         if (settings.dimmerName) {
                             return ($module.find(selector.dimmer).filter('.' + settings.dimmerName).length > 0);
-                        } else {
-                            return ($module.find(selector.dimmer).length > 0);
                         }
+
+                        return ($module.find(selector.dimmer).length > 0);
                     },
                 },
 
@@ -519,7 +517,7 @@
                             previousTime
                         ;
                         if (settings.performance) {
-                            currentTime = new Date().getTime();
+                            currentTime = Date.now();
                             previousTime = time || currentTime;
                             executionTime = currentTime - previousTime;
                             time = currentTime;
@@ -548,7 +546,7 @@
                             title += ' \'' + moduleSelector + '\'';
                         }
                         if ($allModules.length > 1) {
-                            title += ' ' + '(' + $allModules.length + ')';
+                            title += ' (' + $allModules.length + ')';
                         }
                         if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
                             console.groupCollapsed(title);
@@ -573,8 +571,8 @@
                     ;
                     passedArguments = passedArguments || queryArguments;
                     context = context || element;
-                    if (typeof query == 'string' && object !== undefined) {
-                        query = query.split(/[\. ]/);
+                    if (typeof query === 'string' && object !== undefined) {
+                        query = query.split(/[ .]/);
                         maxDepth = query.length - 1;
                         $.each(query, function (depth, value) {
                             var camelCaseValue = (depth != maxDepth)
@@ -721,7 +719,7 @@
                         .addClass(settings.className.loader)
                         .addClass(settings.loaderVariation)
                     ;
-                    if (!!settings.loaderText) {
+                    if (settings.loaderText) {
                         l.text(settings.loaderText);
                         l.addClass('text');
                     }

package/src/definitions/modules/dimmer.less

@@ -302,7 +302,7 @@ body.dimmable > .dimmer {
     .ui[class*="center dimmer"] {
         top: 50%;
         transform: translateY(-50%);
-        -webkit-transform: translateY(calc(-50% - .5px));
+        -webkit-transform: translateY(calc(-50% - 0.5px));
     }
 
     .ui.segment > .ui.ui[class*="top dimmer"] {
@@ -336,48 +336,48 @@ body.dimmable > .dimmer {
         0% {
             opacity: 0;
             transform: translateY(-40%);
-            -webkit-transform: translateY(calc(-40% - .5px));
+            -webkit-transform: translateY(calc(-40% - 0.5px));
         }
         100% {
             opacity: 1;
             transform: translateY(-50%);
-            -webkit-transform: translateY(calc(-50% - .5px));
+            -webkit-transform: translateY(calc(-50% - 0.5px));
         }
     }
     @keyframes fadeInDownCenter {
         0% {
             opacity: 0;
             transform: translateY(-60%);
-            -webkit-transform: translateY(calc(-60% - .5px));
+            -webkit-transform: translateY(calc(-60% - 0.5px));
         }
         100% {
             opacity: 1;
             transform: translateY(-50%);
-            -webkit-transform: translateY(calc(-50% - .5px));
+            -webkit-transform: translateY(calc(-50% - 0.5px));
         }
     }
     @keyframes fadeOutUpCenter {
         0% {
             opacity: 1;
             transform: translateY(-50%);
-            -webkit-transform: translateY(calc(-50% - .5px));
+            -webkit-transform: translateY(calc(-50% - 0.5px));
         }
         100% {
             opacity: 0;
             transform: translateY(-45%);
-            -webkit-transform: translateY(calc(-45% - .5px));
+            -webkit-transform: translateY(calc(-45% - 0.5px));
         }
     }
     @keyframes fadeOutDownCenter {
         0% {
             opacity: 1;
             transform: translateY(-50%);
-            -webkit-transform: translateY(calc(-50% - .5px));
+            -webkit-transform: translateY(calc(-50% - 0.5px));
         }
         100% {
             opacity: 0;
             transform: translateY(-55%);
-            -webkit-transform: translateY(calc(-55% - .5px));
+            -webkit-transform: translateY(calc(-55% - 0.5px));
         }
     }
     @keyframes bounceCenter {
@@ -387,7 +387,7 @@ body.dimmable > .dimmer {
         80%,
         100% {
             transform: translateY(-50%);
-            -webkit-transform: translateY(calc(-50% - .5px));
+            -webkit-transform: translateY(calc(-50% - 0.5px));
         }
         40% {
             transform: translateY(calc(-50% - 30px));

package/src/definitions/modules/dropdown.js

@@ -15,7 +15,7 @@
         return typeof obj === 'function' && typeof obj.nodeType !== 'number';
     }
 
-    window = (typeof window != 'undefined' && window.Math == Math)
+    window = (window !== undefined && window.Math === Math)
         ? window
         : globalThis;
 
@@ -26,11 +26,11 @@
 
             moduleSelector = $allModules.selector || '',
 
-            time           = new Date().getTime(),
+            time           = Date.now(),
             performance    = [],
 
             query          = arguments[0],
-            methodInvoked  = (typeof query == 'string'),
+            methodInvoked  = (typeof query === 'string'),
             queryArguments = [].slice.call(arguments, 1),
             returnedValue
         ;
@@ -361,7 +361,7 @@
                                 .addClass(className.search)
                                 .prop('autocomplete', module.is.chrome() ? 'fomantic-search' : 'off')
                             ;
-                            if (labelNode.length) {
+                            if (labelNode.length > 0) {
                                 if (!labelNode.attr('id')) {
                                     labelNode.attr('id', '_' + module.get.id() + '_formLabel');
                                 }
@@ -727,7 +727,7 @@
                             if (module.is.multiple()) {
                                 module.filterActive();
                             }
-                            if (query || (!query && module.get.activeItem().length == 0)) {
+                            if (query || (!query && module.get.activeItem().length === 0)) {
                                 module.select.firstUnfiltered();
                             }
                             if (module.has.allResultsFiltered()) {
@@ -942,7 +942,7 @@
                                 // Dividers which are direct siblings are considered a group
                                 var $lastDivider = $(this).nextUntil(selector.item);
 
-                                return ($lastDivider.length ? $lastDivider : $(this))
+                                return ($lastDivider.length > 0 ? $lastDivider : $(this))
                                     // Count all non-filtered items until the next divider (or end of the dropdown)
                                     .nextUntil(selector.divider)
                                     .filter(selector.item + ':not(.' + className.filtered + ')')
@@ -967,17 +967,22 @@
                     if (queryLength === termLength) {
                         return (query === term);
                     }
-                    search: for (var characterIndex = 0, nextCharacterIndex = 0; characterIndex < queryLength; characterIndex++) {
+                    for (var characterIndex = 0, nextCharacterIndex = 0; characterIndex < queryLength; characterIndex++) {
                         var
+                            continueSearch = false,
                             queryCharacter = query.charCodeAt(characterIndex)
                         ;
                         while (nextCharacterIndex < termLength) {
                             if (term.charCodeAt(nextCharacterIndex++) === queryCharacter) {
-                                continue search;
+                                continueSearch = true;
+
+                                break;
                             }
                         }
 
-                        return false;
+                        if (!continueSearch) {
+                            return false;
+                        }
                     }
 
                     return true;
@@ -1604,19 +1609,20 @@
                                         event.preventDefault();
 
                                         return;
-                                    } else {
-                                        module.verbose('Up key pressed, changing active item');
-                                        $selectedItem
-                                            .removeClass(className.selected)
-                                        ;
-                                        $nextItem
-                                            .addClass(className.selected)
-                                        ;
-                                        module.set.scrollPosition($nextItem);
-                                        if (settings.selectOnKeydown && module.is.single() && !$nextItem.hasClass(className.actionable)) {
-                                            module.set.selectedItem($nextItem);
-                                        }
                                     }
+
+                                    module.verbose('Up key pressed, changing active item');
+                                    $selectedItem
+                                        .removeClass(className.selected)
+                                    ;
+                                    $nextItem
+                                        .addClass(className.selected)
+                                    ;
+                                    module.set.scrollPosition($nextItem);
+                                    if (settings.selectOnKeydown && module.is.single() && !$nextItem.hasClass(className.actionable)) {
+                                        module.set.selectedItem($nextItem);
+                                    }
+
                                     event.preventDefault();
                                 }
 
@@ -1630,19 +1636,20 @@
                                         event.preventDefault();
 
                                         return;
-                                    } else {
-                                        module.verbose('Down key pressed, changing active item');
-                                        $item
-                                            .removeClass(className.selected)
-                                        ;
-                                        $nextItem
-                                            .addClass(className.selected)
-                                        ;
-                                        module.set.scrollPosition($nextItem);
-                                        if (settings.selectOnKeydown && module.is.single() && !$nextItem.hasClass(className.actionable)) {
-                                            module.set.selectedItem($nextItem);
-                                        }
                                     }
+
+                                    module.verbose('Down key pressed, changing active item');
+                                    $item
+                                        .removeClass(className.selected)
+                                    ;
+                                    $nextItem
+                                        .addClass(className.selected)
+                                    ;
+                                    module.set.scrollPosition($nextItem);
+                                    if (settings.selectOnKeydown && module.is.single() && !$nextItem.hasClass(className.actionable)) {
+                                        module.set.selectedItem($nextItem);
+                                    }
+
                                     event.preventDefault();
                                 }
 
@@ -1725,11 +1732,11 @@
                             callback();
 
                             return true;
-                        } else {
-                            module.verbose('Event occurred in dropdown, canceling callback');
-
-                            return false;
                         }
+
+                        module.verbose('Event occurred in dropdown, canceling callback');
+
+                        return false;
                     },
                     eventOnElement: function (event, callback) {
                         var
@@ -1747,11 +1754,11 @@
                             callback();
 
                             return true;
-                        } else {
-                            module.verbose('Event occurred in dropdown menu, canceling callback');
-
-                            return false;
                         }
+
+                        module.verbose('Event occurred in dropdown menu, canceling callback');
+
+                        return false;
                     },
                 },
 
@@ -1809,7 +1816,7 @@
                         return $module.data(metadata.defaultValue);
                     },
                     placeholderText: function () {
-                        if (settings.placeholder != 'auto' && typeof settings.placeholder == 'string') {
+                        if (settings.placeholder != 'auto' && typeof settings.placeholder === 'string') {
                             return settings.placeholder;
                         }
 
@@ -1880,7 +1887,8 @@
                         ;
                         if (returnEndPos && 'selectionEnd' in input) {
                             return input.selectionEnd;
-                        } else if (!returnEndPos && 'selectionStart' in input) {
+                        }
+                        if (!returnEndPos && 'selectionStart' in input) {
                             return input.selectionStart;
                         }
                         if (document.selection) {
@@ -1917,7 +1925,7 @@
                         }
 
                         return (!module.has.selectInput() && module.is.multiple())
-                            ? (typeof value == 'string') // delimited string
+                            ? (typeof value === 'string') // delimited string
                                 ? (raw ? value : module.escape.htmlEntities(value)).split(settings.delimiter)
                                 : ''
                             : value;
@@ -1928,7 +1936,7 @@
                             remoteValues = false
                         ;
                         if (values) {
-                            if (typeof values == 'string') {
+                            if (typeof values === 'string') {
                                 values = [values];
                             }
                             $.each(values, function (index, value) {
@@ -2119,9 +2127,7 @@
                                         return;
                                     }
                                     if (isMultiple) {
-                                        if ($.inArray(module.escape.htmlEntities(String(optionValue)), value.map(function (v) {
-                                            return String(v);
-                                        })) !== -1) {
+                                        if ($.inArray(module.escape.htmlEntities(String(optionValue)), value.map(String)) !== -1) {
                                             $selectedItem = ($selectedItem)
                                                 ? $selectedItem.add($choice)
                                                 : $choice;
@@ -2170,16 +2176,16 @@
                                 }
 
                                 return true;
-                            } else {
-                                module.verbose('No longer at maximum selection count');
-                                module.remove.message();
-                                module.remove.filteredItem();
-                                if (module.is.searchSelection()) {
-                                    module.filterItems();
-                                }
+                            }
 
-                                return false;
+                            module.verbose('No longer at maximum selection count');
+                            module.remove.message();
+                            module.remove.filteredItem();
+                            if (module.is.searchSelection()) {
+                                module.filterItems();
                             }
+
+                            return false;
                         }
 
                         return true;
@@ -2878,7 +2884,7 @@
                         var
                             $addition         = $menu.children(selector.addition),
                             $existingItem     = module.get.item(value),
-                            alreadyHasValue   = $existingItem && $existingItem.not(selector.addition).length,
+                            alreadyHasValue   = $existingItem && $existingItem.not(selector.addition).length > 0,
                             hasUserSuggestion = $addition.length > 0,
                             html
                         ;
@@ -3203,7 +3209,7 @@
                         }
                     },
                     diacritics: function (text) {
-                        return settings.ignoreDiacritics ? text.normalize('NFD').replace(/[\u0300-\u036f]/g, '') : text;
+                        return settings.ignoreDiacritics ? text.normalize('NFD').replace(/[\u0300-\u036F]/g, '') : text;
                     },
                 },
 
@@ -3262,7 +3268,7 @@
                         return ($currentMenu || $menu).find(selector.menu).length > 0;
                     },
                     message: function () {
-                        return ($menu.children(selector.message).length !== 0);
+                        return ($menu.children(selector.message).length > 0);
                     },
                     label: function (value) {
                         var
@@ -3304,9 +3310,7 @@
                                 : (values == value)
                         ;
 
-                        return (hasValue)
-                            ? true
-                            : false;
+                        return !!(hasValue);
                     },
                     valueIgnoringCase: function (value) {
                         var
@@ -3723,8 +3727,8 @@
                     },
                     htmlEntities: function (string) {
                         var
-                            badChars     = /[<>"'`]/g,
-                            shouldEscape = /[&<>"'`]/,
+                            badChars     = /["'<>`]/g,
+                            shouldEscape = /["&'<>`]/,
                             escape       = {
                                 '<': '&lt;',
                                 '>': '&gt;',
@@ -3737,7 +3741,7 @@
                             }
                         ;
                         if (shouldEscape.test(string)) {
-                            string = string.replace(/&(?![a-z0-9#]{1,12};)/gi, '&amp;');
+                            string = string.replace(/&(?![\d#a-z]{1,12};)/gi, '&amp;');
 
                             return string.replace(badChars, escapedChar);
                         }
@@ -3803,7 +3807,7 @@
                             previousTime
                         ;
                         if (settings.performance) {
-                            currentTime = new Date().getTime();
+                            currentTime = Date.now();
                             previousTime = time || currentTime;
                             executionTime = currentTime - previousTime;
                             time = currentTime;
@@ -3854,8 +3858,8 @@
                     ;
                     passedArguments = passedArguments || queryArguments;
                     context = context || element;
-                    if (typeof query == 'string' && object !== undefined) {
-                        query = query.split(/[\. ]/);
+                    if (typeof query === 'string' && object !== undefined) {
+                        query = query.split(/[ .]/);
                         maxDepth = query.length - 1;
                         $.each(query, function (depth, value) {
                             var camelCaseValue = (depth != maxDepth)
@@ -4039,7 +4043,7 @@
         },
 
         regExp: {
-            escape: /[-[\]{}()*+?.,\\^$|#\s:=@]/g,
+            escape: /[\s#$()*+,.:=?@[\\\]^{|}-]/g,
             quote: /"/g,
         },
 
@@ -4155,8 +4159,8 @@
                 return string;
             }
             var
-                badChars     = /[<>"'`]/g,
-                shouldEscape = /[&<>"'`]/,
+                badChars     = /["'<>`]/g,
+                shouldEscape = /["&'<>`]/,
                 escape       = {
                     '<': '&lt;',
                     '>': '&gt;',
@@ -4169,7 +4173,7 @@
                 }
             ;
             if (shouldEscape.test(string)) {
-                string = string.replace(/&(?![a-z0-9#]{1,12};)/gi, '&amp;');
+                string = string.replace(/&(?![\d#a-z]{1,12};)/gi, '&amp;');
 
                 return string.replace(badChars, escapedChar);
             }
@@ -4185,11 +4189,9 @@
                 deQuote = $.fn.dropdown.settings.templates.deQuote
             ;
             html += '<i class="dropdown icon"></i>';
-            if (placeholder) {
-                html += '<div class="default text">' + escape(placeholder, preserveHTML) + '</div>';
-            } else {
-                html += '<div class="text"></div>';
-            }
+            html += placeholder
+                ? '<div class="default text">' + escape(placeholder, preserveHTML) + '</div>'
+                : '<div class="text"></div>';
             html += '<div class="' + deQuote(className.menu) + '">';
             html += $.fn.dropdown.settings.templates.menu(select, fields, preserveHTML, className);
             html += '</div>';
@@ -4207,9 +4209,7 @@
             ;
             $.each(values, function (index, option) {
                 var
-                    itemType = (option[fields.type])
-                        ? option[fields.type]
-                        : 'item',
+                    itemType = option[fields.type] || 'item',
                     isMenu = itemType.indexOf('menu') !== -1
                 ;
 
@@ -4229,15 +4229,15 @@
                             : '',
                         hasDescription = (escape(option[fields.description] || '', preserveHTML) != '')
                     ;
-                    html += '<div class="' + deQuote(maybeActionable + maybeDisabled + maybeDescriptionVertical + (option[fields.class] ? option[fields.class] : className.item)) + '" data-value="' + deQuote(option[fields.value], true) + '"' + maybeText + '>';
+                    html += '<div class="' + deQuote(maybeActionable + maybeDisabled + maybeDescriptionVertical + (option[fields.class] || className.item)) + '" data-value="' + deQuote(option[fields.value], true) + '"' + maybeText + '>';
                     if (isMenu) {
                         html += '<i class="' + (itemType.indexOf('left') !== -1 ? 'left' : '') + ' dropdown icon"></i>';
                     }
                     if (option[fields.image]) {
-                        html += '<img class="' + deQuote(option[fields.imageClass] ? option[fields.imageClass] : className.image) + '" src="' + deQuote(option[fields.image]) + '">';
+                        html += '<img class="' + deQuote(option[fields.imageClass] || className.image) + '" src="' + deQuote(option[fields.image]) + '">';
                     }
                     if (option[fields.icon]) {
-                        html += '<i class="' + deQuote(option[fields.icon] + ' ' + (option[fields.iconClass] ? option[fields.iconClass] : className.icon)) + '"></i>';
+                        html += '<i class="' + deQuote(option[fields.icon] + ' ' + (option[fields.iconClass] || className.icon)) + '"></i>';
                     }
                     if (hasDescription) {
                         html += '<span class="' + deQuote(className.description) + '">' + escape(option[fields.description] || '', preserveHTML) + '</span>';
@@ -4259,12 +4259,12 @@
                 } else if (itemType === 'header') {
                     var
                         groupName = escape(option[fields.name] || '', preserveHTML),
-                        groupIcon = deQuote(option[fields.icon] ? option[fields.icon] : className.groupIcon)
+                        groupIcon = deQuote(option[fields.icon] || className.groupIcon)
                     ;
                     if (groupName !== '' || groupIcon !== '') {
-                        html += '<div class="' + deQuote(option[fields.class] ? option[fields.class] : className.header) + '">';
+                        html += '<div class="' + deQuote(option[fields.class] || className.header) + '">';
                         if (groupIcon !== '') {
-                            html += '<i class="' + deQuote(groupIcon + ' ' + (option[fields.iconClass] ? option[fields.iconClass] : className.icon)) + '"></i>';
+                            html += '<i class="' + deQuote(groupIcon + ' ' + (option[fields.iconClass] || className.icon)) + '"></i>';
                         }
                         html += groupName;
                         html += '</div>';