fomantic-ui 2.10.0-beta.8 → 2.10.0-beta.81

package/src/definitions/modules/sidebar.js

@@ -19,23 +19,23 @@
         ? window
         : globalThis;
 
-    $.fn.sidebar = function (parameters) {
-        let $allModules = $(this);
-        let $window = $(window);
-        let $document = $(document);
-        let $body = $('body');
-        let $html = $('html');
-        let $head = $('head');
+    $.fn.sidebar = function (...args) {
+        const $allModules = $(this);
+        const $window = $(window);
+        const $document = $(document);
+        const $body = $('body');
+        const $html = $('html');
+        const $head = $('head');
 
         let time = Date.now();
         let performance = [];
 
-        let query = arguments[0];
-        let methodInvoked = typeof query === 'string';
-        let queryArguments = [].slice.call(arguments, 1);
-        let contextCheck = function (context, win) {
+        const parameters = args[0];
+        const methodInvoked = typeof parameters === 'string';
+        const queryArguments = args.slice(1);
+        const contextCheck = function (context, win) {
             let $context;
-            if ([window, document].indexOf(context) >= 0) {
+            if ([window, document].includes(context)) {
                 $context = $body;
             } else {
                 $context = $(win.document).find(context);
@@ -49,41 +49,40 @@
         let returnedValue;
 
         $allModules.each(function () {
-            let settings = $.isPlainObject(parameters)
+            const settings = $.isPlainObject(parameters)
                 ? $.extend(true, {}, $.fn.sidebar.settings, parameters)
                 : $.extend({}, $.fn.sidebar.settings);
 
-            let selector = settings.selector;
-            let className = settings.className;
-            let namespace = settings.namespace;
-            let regExp = settings.regExp;
-            let error = settings.error;
+            const selector = settings.selector;
+            const className = settings.className;
+            const namespace = settings.namespace;
+            const regExp = settings.regExp;
+            const error = settings.error;
 
-            let eventNamespace = '.' + namespace;
-            let moduleNamespace = 'module-' + namespace;
+            const eventNamespace = '.' + namespace;
+            const moduleNamespace = 'module-' + namespace;
 
-            let $module = $(this);
+            const $module = $(this);
             let $context = contextCheck(settings.context, window);
-            let isBody = $context[0] === $body[0];
+            const isBody = $context[0] === $body[0];
 
             let $sidebars = $module.children(selector.sidebar);
             let $fixed = $context.children(selector.fixed);
             let $pusher = $context.children(selector.pusher);
             let $style;
 
-            let element = this;
+            const element = this;
             let instance = $module.data(moduleNamespace);
 
             let elementNamespace;
             let id;
             let currentScroll;
             let initialBodyMargin = '';
-            let tempBodyMargin = '';
+            let initialBodyMarginInt = 0;
+            let tempBodyMargin = 0;
             let hadScrollbar = false;
 
-            let module;
-
-            module = {
+            const module = {
 
                 initialize: function () {
                     module.debug('Initializing sidebar', parameters);
@@ -133,8 +132,8 @@
                 event: {
                     clickaway: function (event) {
                         if (settings.closable) {
-                            let clickedInPusher = $pusher.find(event.target).length > 0 || $pusher.is(event.target);
-                            let clickedContext = $context.is(event.target);
+                            const clickedInPusher = $pusher.find(event.target).length > 0 || $pusher.is(event.target);
+                            const clickedContext = $context.is(event.target);
                             if (clickedInPusher) {
                                 module.verbose('User clicked on dimmed page');
                                 module.hide();
@@ -205,11 +204,11 @@
 
                 add: {
                     inlineCSS: function () {
-                        let width = module.cache.width || $module.outerWidth();
-                        let height = module.cache.height || $module.outerHeight();
-                        let isRTL = module.is.rtl();
-                        let direction = module.get.direction();
-                        let distance = {
+                        const width = module.cache.width || $module.outerWidth();
+                        const height = module.cache.height || $module.outerHeight();
+                        const isRTL = module.is.rtl();
+                        const direction = module.get.direction();
+                        const distance = {
                             left: width,
                             right: -width,
                             top: height,
@@ -264,7 +263,7 @@
                 repaint: function () {
                     module.verbose('Forcing repaint event');
                     element.style.display = 'none';
-                    let ignored = element.offsetHeight;
+                    const ignored = element.offsetHeight;
                     element.scrollTop = element.scrollTop; // eslint-disable-line no-self-assign
                     element.style.display = '';
                 },
@@ -301,7 +300,7 @@
                 },
 
                 attachEvents: function (selector, event) {
-                    let $toggle = $(selector);
+                    const $toggle = $(selector);
                     event = isFunction(module[event])
                         ? module[event]
                         : module.toggle;
@@ -325,9 +324,9 @@
                 save: {
                     bodyMargin: function () {
                         initialBodyMargin = $context.css((isBody ? 'margin-' : 'padding-') + (module.can.leftBodyScrollbar() ? 'left' : 'right'));
-                        let bodyMarginRightPixel = parseInt(initialBodyMargin.replace(/[^\d.]/g, ''), 10);
-                        let bodyScrollbarWidth = isBody ? window.innerWidth - document.documentElement.clientWidth : $context[0].offsetWidth - $context[0].clientWidth;
-                        tempBodyMargin = bodyMarginRightPixel + bodyScrollbarWidth;
+                        initialBodyMarginInt = Number.parseInt(initialBodyMargin.replace(/[^\d.]/g, ''), 10);
+                        const bodyScrollbarWidth = isBody ? window.innerWidth - document.documentElement.clientWidth : $context[0].offsetWidth - $context[0].clientWidth;
+                        tempBodyMargin = initialBodyMarginInt + bodyScrollbarWidth;
                     },
                 },
                 show: function (callback) {
@@ -396,15 +395,14 @@
                     return module.othersVisible() || module.othersAnimating();
                 },
 
-                hideOthers: function (callback) {
-                    let $otherSidebars = $sidebars.not($module).filter('.' + className.visible);
-                    let sidebarCount = $otherSidebars.length;
+                hideOthers: function (callback = function () {}) {
+                    const $otherSidebars = $sidebars.not($module).filter('.' + className.visible);
+                    const sidebarCount = $otherSidebars.length;
                     let callbackCount = 0;
-                    callback = callback || function () {};
                     $otherSidebars
                         .sidebar('hide', function () {
                             callbackCount++;
-                            if (callbackCount === sidebarCount) {
+                            if (callbackCount === sidebarCount && isFunction(callback)) {
                                 callback();
                             }
                         });
@@ -420,13 +418,10 @@
                 },
 
                 pushPage: function (callback) {
-                    let transition = module.get.transition();
-                    let $transition = transition === 'overlay' || module.othersActive()
+                    const transition = module.get.transition();
+                    const $transition = transition === 'overlay' || module.othersActive()
                         ? $module
                         : $pusher;
-                    let animate;
-                    let dim;
-                    let transitionEnd;
                     callback = isFunction(callback)
                         ? callback
                         : function () {};
@@ -439,16 +434,16 @@
                     module.bind.scrollLock();
                     module.set.transition(transition);
                     module.repaint();
-                    animate = function () {
+                    const animate = function () {
                         module.bind.clickaway();
                         module.add.inlineCSS();
                         module.set.animating();
                         module.set.visible();
                     };
-                    dim = function () {
+                    const dim = function () {
                         module.set.dimmed();
                     };
-                    transitionEnd = function (event) {
+                    const transitionEnd = function (event) {
                         if (event.target === $transition[0]) {
                             $transition.off('transitionend' + elementNamespace, transitionEnd);
                             module.remove.animating();
@@ -464,12 +459,10 @@
                 },
 
                 pullPage: function (callback) {
-                    let transition = module.get.transition();
-                    let $transition = transition === 'overlay' || module.othersActive()
+                    const transition = module.get.transition();
+                    const $transition = transition === 'overlay' || module.othersActive()
                         ? $module
                         : $pusher;
-                    let animate;
-                    let transitionEnd;
                     callback = isFunction(callback)
                         ? callback
                         : function () {};
@@ -478,7 +471,7 @@
                     module.unbind.clickaway();
                     module.unbind.scrollLock();
 
-                    animate = function () {
+                    const animate = function () {
                         module.set.transition(transition);
                         module.set.animating();
                         if (settings.dimPage && !module.othersVisible()) {
@@ -486,7 +479,7 @@
                         }
                         module.remove.visible();
                     };
-                    transitionEnd = function (event) {
+                    const transitionEnd = function (event) {
                         if (event.target === $transition[0]) {
                             $transition.off('transitionend' + elementNamespace, transitionEnd);
                             module.remove.animating();
@@ -527,11 +520,11 @@
 
                 set: {
                     bodyMargin: function () {
-                        let position = module.can.leftBodyScrollbar() ? 'left' : 'right';
+                        const position = module.can.leftBodyScrollbar() ? 'left' : 'right';
                         $context.css((isBody ? 'margin-' : 'padding-') + position, tempBodyMargin + 'px');
                         $context.find(selector.bodyFixed.replace('right', position)).each(function () {
-                            let el = $(this);
-                            let attribute = el.css('position') === 'fixed' ? 'padding-' + position : position;
+                            const el = $(this);
+                            const attribute = el.css('position') === 'fixed' ? 'padding-' + position : position;
                             el.css(attribute, 'calc(' + el.css(attribute) + ' + ' + tempBodyMargin + 'px)');
                         });
                     },
@@ -566,12 +559,10 @@
                     closing: function () {
                         $pusher.addClass(className.closing);
                     },
-                    transition: function (transition) {
-                        transition = transition || module.get.transition();
+                    transition: function (transition = module.get.transition()) {
                         $module.addClass(transition);
                     },
-                    direction: function (direction) {
-                        direction = direction || module.get.direction();
+                    direction: function (direction = module.get.direction()) {
                         $module.addClass(className[direction]);
                     },
                     visible: function () {
@@ -608,12 +599,10 @@
                     closing: function () {
                         $pusher.removeClass(className.closing);
                     },
-                    transition: function (transition) {
-                        transition = transition || module.get.transition();
+                    transition: function (transition = module.get.transition()) {
                         $module.removeClass(transition);
                     },
-                    direction: function (direction) {
-                        direction = direction || module.get.direction();
+                    direction: function (direction = module.get.direction()) {
                         $module.removeClass(className[direction]);
                     },
                     visible: function () {
@@ -625,11 +614,11 @@
                 },
                 restore: {
                     bodyMargin: function () {
-                        let position = module.can.leftBodyScrollbar() ? 'left' : 'right';
-                        $context.css((isBody ? 'margin-' : 'padding-') + position, initialBodyMargin);
+                        const position = module.can.leftBodyScrollbar() ? 'left' : 'right';
+                        $context.css((isBody ? 'margin-' : 'padding-') + position, initialBodyMarginInt === 0 ? '' : initialBodyMargin);
                         $context.find(selector.bodyFixed.replace('right', position)).each(function () {
-                            let el = $(this);
-                            let attribute = el.css('position') === 'fixed' ? 'padding-' + position : position;
+                            const el = $(this);
+                            const attribute = el.css('position') === 'fixed' ? 'padding-' + position : position;
                             el.css(attribute, '');
                         });
                     },
@@ -649,9 +638,8 @@
                         return className.left;
                     },
                     transition: function () {
-                        let direction = module.get.direction();
-                        let transition;
-                        transition = module.is.mobile()
+                        const direction = module.get.direction();
+                        const transition = module.is.mobile()
                             ? (settings.mobileTransition === 'auto'
                                 ? settings.defaultTransition.mobile[direction]
                                 : settings.mobileTransition)
@@ -684,11 +672,11 @@
                         return module.cache.isFirefox;
                     },
                     iframe: function () {
-                        return !(self === top);
+                        return !(window.self === window.top);
                     },
                     mobile: function () {
-                        let userAgent = navigator.userAgent;
-                        let isMobile = userAgent.match(regExp.mobile);
+                        const userAgent = navigator.userAgent;
+                        const isMobile = userAgent.match(regExp.mobile);
                         if (isMobile) {
                             module.verbose('Browser was found to be mobile', userAgent);
 
@@ -750,30 +738,30 @@
                         return module[name];
                     }
                 },
-                debug: function () {
+                debug: function (...args) {
                     if (!settings.silent && settings.debug) {
                         if (settings.performance) {
-                            module.performance.log(arguments);
+                            module.performance.log(args);
                         } else {
                             module.debug = Function.prototype.bind.call(console.info, console, settings.name + ':');
-                            module.debug.apply(console, arguments);
+                            module.debug.apply(console, args);
                         }
                     }
                 },
-                verbose: function () {
+                verbose: function (...args) {
                     if (!settings.silent && settings.verbose && settings.debug) {
                         if (settings.performance) {
-                            module.performance.log(arguments);
+                            module.performance.log(args);
                         } else {
                             module.verbose = Function.prototype.bind.call(console.info, console, settings.name + ':');
-                            module.verbose.apply(console, arguments);
+                            module.verbose.apply(console, args);
                         }
                     }
                 },
-                error: function () {
+                error: function (...args) {
                     if (!settings.silent) {
                         module.error = Function.prototype.bind.call(console.error, console, settings.name + ':');
-                        module.error.apply(console, arguments);
+                        module.error.apply(console, args);
                     }
                 },
                 performance: {
@@ -788,7 +776,7 @@
                             time = currentTime;
                             performance.push({
                                 Name: message[0],
-                                Arguments: [].slice.call(message, 1) || '',
+                                Arguments: message.slice(1),
                                 Element: element,
                                 'Execution Time': executionTime,
                             });
@@ -809,30 +797,22 @@
                         title += ' ' + totalTime + 'ms';
                         if (performance.length > 0) {
                             console.groupCollapsed(title);
-                            if (console.table) {
-                                console.table(performance);
-                            } else {
-                                $.each(performance, function (index, data) {
-                                    console.log(data.Name + ': ' + data['Execution Time'] + 'ms');
-                                });
-                            }
+                            console.table(performance);
                             console.groupEnd();
                         }
                         performance = [];
                     },
                 },
-                invoke: function (query, passedArguments, context) {
+                invoke: function (query, passedArguments = queryArguments, context = element) {
                     let object = instance;
                     let maxDepth;
                     let found;
                     let response;
-                    passedArguments = passedArguments || queryArguments;
-                    context = context || element;
                     if (typeof query === 'string' && object !== undefined) {
                         query = query.split(/[ .]/);
                         maxDepth = query.length - 1;
                         $.each(query, function (depth, value) {
-                            let camelCaseValue = depth !== maxDepth
+                            const camelCaseValue = depth !== maxDepth
                                 ? value + query[depth + 1].charAt(0).toUpperCase() + query[depth + 1].slice(1)
                                 : query;
                             if ($.isPlainObject(object[camelCaseValue]) && (depth !== maxDepth)) {
@@ -875,7 +855,7 @@
                 if (instance === undefined) {
                     module.initialize();
                 }
-                module.invoke(query);
+                module.invoke(parameters);
             } else {
                 if (instance !== undefined) {
                     module.invoke('destroy');

package/src/definitions/modules/sidebar.less

@@ -667,5 +667,4 @@ body.pushable > .pusher {
     }
 }
 
-// stylelint-disable no-invalid-position-at-import-rule
 @import (multiple, optional) "../../overrides.less";