flowviant 0.125.3 → 0.125.4

package/bin/lib/postureTools.mjs

@@ -45,6 +45,10 @@ const SUPPORTING_CAPABILITIES = `The kind defines the delivered product, not whi
 may be used. Use available tools needed for the person's request, including
 native image generation for requested textures or illustrations. A listed skill
 is not proof that its tool is installed, mounted or entitled on this account.
+Configuration and mount names do not prove a live MCP connection. Verify access
+with a non-mutating tool before claiming it works. If a call fails, relay its
+actual startup, approval or connection error and a concrete corrective step;
+an empty instance list means no connected instances, not missing tools.
 Do not re-file the kind or require a separate image card just to use a tool.
 If a needed tool is absent or fails, relay the measured limitation and ask for
 the missing configuration or a decision. A separately billed CLI/API fallback

package/bin/lib/projectTools.mjs

@@ -1,6 +1,6 @@
 /** Repo-owned tool configuration, read from the base ref for every agent turn. */
 import { accessSync, constants, mkdirSync, mkdtempSync, readFileSync, rmSync, statSync, writeFileSync } from 'node:fs';
-import { delimiter, dirname, isAbsolute, join, resolve } from 'node:path';
+import { delimiter, dirname, isAbsolute, join, relative, resolve } from 'node:path';
 import { tmpdir } from 'node:os';
 import { git, gitRaw, splitNul } from './git.mjs';
 import { withoutMachineCredentials } from './machineEnv.mjs';
@@ -36,6 +36,19 @@ function onPath(command, env) {
   });
 }
 
+const relativeCommand = (command) => !isAbsolute(command) && command.includes('/');
+
+/** Repo launchers are not PATH commands. Measure the reviewed tree's mode,
+ * never an uncommitted executable in the checkout used to read that tree. */
+function reviewedExecutable(root, commit, command) {
+  const path = relative(resolve(root), resolve(root, command));
+  if (!path || path === '..' || path.startsWith('../') || isAbsolute(path)) return false;
+  try {
+    return splitNul(gitRaw(['ls-tree', '-z', commit, '--', path], root, SHOW))
+      .some((entry) => entry.startsWith('100755 blob ') && entry.slice(entry.indexOf('\t') + 1) === path);
+  } catch { return false; }
+}
+
 function referenced(value) {
   return [...String(value).matchAll(/\$\{([A-Za-z_][A-Za-z0-9_]*)\}/g)].map((m) => m[1]);
 }
@@ -101,9 +114,14 @@ export function readBaseTools(root, ref, callerEnv = process.env) {
       for (const key of referenced(value)) vars.add(key);
     }
     const missing = [...vars].filter((key) => !env[key]).sort();
-    const commandMissing = typeof config.command === 'string' && !onPath(expand(config.command, env), env);
+    const command = typeof config.command === 'string' ? expand(config.command, env) : null;
+    const repoCommand = command != null && relativeCommand(command);
+    const commandMissing = command != null && !(repoCommand ? reviewedExecutable(root, commit, command) : onPath(command, env));
     const unsupported = typeof config.command !== 'string' && typeof config.url !== 'string';
-    const reason = missing.length ? `env ${missing.join(', ')} unset` : commandMissing ? `command ${config.command} not on PATH` : unsupported ? 'MCP configuration unsupported' : null;
+    const reason = missing.length ? `env ${missing.join(', ')} unset` : commandMissing
+      ? repoCommand ? `command ${config.command} is not an executable file in the base branch; commit the launcher with executable permission on base`
+        : `command ${config.command} not on PATH`
+      : unsupported ? 'MCP configuration unsupported' : null;
     return { name, config, state: reason ? 'missing' : 'ready', reason };
   });
   // Nested instructions are normally discovered when a CLI enters that path.
@@ -119,7 +137,7 @@ export function readBaseTools(root, ref, callerEnv = process.env) {
     if (instructionBytes > MAX_INSTRUCTION_BYTES) throw new Error('Base branch agent instructions exceed the turn limit');
     instructions.push({ path, body });
   }
-  return { tools, skills, skillFiles, instructions };
+  return { tools, skills, skillFiles, instructions, root: resolve(root) };
 }
 
 const expand = (value, env) => String(value).replace(/\$\{([A-Za-z_][A-Za-z0-9_]*)\}/g, (_, key) => env[key] ?? '');
@@ -144,6 +162,11 @@ export function prepareAgentTools(snapshot, runner, callerEnv = process.env, wor
   const env = expansionEnv(callerEnv);
   const dir = mkdtempSync(join(tmpdir(), 'flowviant-agent-tools-'));
   const usable = snapshot.tools.filter((t) => t.state === 'ready' && mcpRefusal(runner, t.config) == null);
+  // The CLI may read its config from a temporary directory, and Codex research
+  // changes cwd to an isolated copy. Keep repository launchers rooted at the
+  // agent worktree, not either of those directories or the daemon's checkout.
+  const launchRoot = worktree ?? snapshot.root;
+  const launchCommand = (command) => launchRoot && relativeCommand(command) ? resolve(launchRoot, command) : command;
   // What the base lists and this turn cannot mount, and why — the turn is told
   // (postureTools.mjs), so a missing server is a named fact, never a guess.
   const mcpUnmounted = snapshot.tools
@@ -152,7 +175,7 @@ export function prepareAgentTools(snapshot, runner, callerEnv = process.env, wor
   const mcpServers = {};
   for (const { name, config } of usable) {
     if (typeof config.command === 'string') {
-      const command = expand(config.command, env);
+      const command = launchCommand(expand(config.command, env));
       const args = Array.isArray(config.args) ? config.args.map((v) => expand(v, env)) : [];
       const vars = Object.fromEntries(Object.entries(config.env ?? {}).map(([k, v]) => [k, expand(v, env)]));
       mcpServers[name] = { command, args, env: vars };
@@ -191,7 +214,10 @@ export function prepareAgentTools(snapshot, runner, callerEnv = process.env, wor
     mcpUnmounted,
     /** The mount a fenced turn takes where the runner's file is ignored
      *  (`fencedMountFor`, projectToolRuntimes.mjs); null where it has none. */
-    fencedMount: fencedMountFor(runner, usable, (value) => expand(value, env), callerEnv),
+    fencedMount: fencedMountFor(runner, usable.map((entry) => ({ ...entry, config: {
+      ...entry.config,
+      ...(typeof entry.config.command === 'string' ? { command: launchCommand(entry.config.command) } : {}),
+    } })), (value) => expand(value, env), callerEnv),
     instructions,
     pluginDir,
     codexHome,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "flowviant",
-  "version": "0.125.3",
+  "version": "0.125.4",
   "description": "Run your own coding CLIs as build agents for Flowviant \u2014 Claude Code, Codex or Antigravity, on your own credentials. Holds your sessions, keeps a worktree per tab, and ships branches on your word.",
   "type": "module",
   "bin": {