flowent 0.0.4 → 0.0.5

package/backend/tests/unit/prompts/test_prompts.py

@@ -178,7 +178,7 @@ def test_compose_system_prompt_injects_set_permissions_guidance_when_tool_presen
     )
 
     assert SET_PERMISSIONS_TOOL_GUIDANCE in result
-    assert "bound Leader's `allow_network` and `write_dirs`" in result
+    assert "target workflow's own `allow_network` and `write_dirs`" in result
 
 
 def test_common_communication_guidance_requires_explicit_target_routing():
@@ -398,7 +398,7 @@ def test_get_system_prompt_reads_conductor_prompt_via_role_system(monkeypatch):
     )
     assert ASSISTANT_ONLY_PROMPT not in prompt
     assert CREATE_AGENT_TOOL_GUIDANCE in prompt
-    assert LIST_WORKFLOWS_TOOL_GUIDANCE in prompt
+    assert LIST_WORKFLOWS_TOOL_GUIDANCE not in prompt
     assert LIST_ROLES_TOOL_GUIDANCE in prompt
     assert LIST_TOOLS_TOOL_GUIDANCE in prompt
     assert "## Tools Available" not in CONDUCTOR_ROLE_SYSTEM_PROMPT
@@ -549,6 +549,7 @@ def test_steward_included_tools_contains_list_roles_and_list_tools():
     assert "list_tools" in STEWARD_ROLE_INCLUDED_TOOLS
     assert "connect" not in STEWARD_ROLE_INCLUDED_TOOLS
     assert "connect" in CONDUCTOR_ROLE_INCLUDED_TOOLS
+    assert "list_workflows" not in CONDUCTOR_ROLE_INCLUDED_TOOLS
     assert "set_permissions" not in CONDUCTOR_ROLE_INCLUDED_TOOLS
     assert "set_permissions" not in WORKER_ROLE_INCLUDED_TOOLS
 

package/backend/tests/unit/routes/test_providers_route.py

@@ -234,6 +234,7 @@ def test_list_provider_models_runs_gateway_in_threadpool(monkeypatch):
                 "context_window_tokens": None,
                 "input_image": False,
                 "output_image": False,
+                "structured_output": False,
             }
         ]
     }
@@ -327,6 +328,7 @@ def test_list_provider_models_from_draft_passes_raw_base_url_to_provider(
                 "context_window_tokens": None,
                 "input_image": False,
                 "output_image": False,
+                "structured_output": False,
             }
         ]
     }

package/backend/tests/unit/routes/test_roles_routes.py

@@ -15,8 +15,11 @@ from flowent.routes.roles import (
 from flowent.settings import (
     CONDUCTOR_ROLE_NAME,
     DESIGNER_ROLE_NAME,
+    STEWARD_ROLE_INCLUDED_TOOLS,
+    STEWARD_ROLE_NAME,
     AssistantSettings,
     ProviderConfig,
+    ProviderModelCatalogEntry,
     RoleConfig,
     RoleModelConfig,
     Settings,
@@ -156,6 +159,33 @@ def test_create_role_uses_name_as_identifier(monkeypatch):
     assert saved == [["Reviewer"]]
 
 
+def test_create_role_filters_assistant_only_tools(monkeypatch):
+    settings = Settings()
+    monkeypatch.setattr("flowent.routes.roles.get_settings", lambda: settings)
+    monkeypatch.setattr("flowent.routes.roles.save_settings", lambda current: None)
+
+    result = asyncio.run(
+        create_role(
+            CreateRoleRequest(
+                name="Reviewer",
+                description="Review code carefully",
+                system_prompt="Review code carefully",
+                included_tools=[
+                    "read",
+                    "create_workflow",
+                    "delete_workflow",
+                    "list_workflows",
+                    "mcp__flowent__list_workflows",
+                    "manage_settings",
+                ],
+            )
+        )
+    )
+
+    assert result["included_tools"] == ["read"]
+    assert settings.roles[0].included_tools == ["read"]
+
+
 def test_create_role_rejects_duplicate_name(monkeypatch):
     settings = Settings(
         roles=[RoleConfig(name="Reviewer", system_prompt="Review code carefully")]
@@ -231,6 +261,40 @@ def test_update_role_uses_name_path_parameter(monkeypatch):
     assert saved == [["Architect"]]
 
 
+def test_update_role_filters_assistant_only_tools(monkeypatch):
+    settings = Settings(
+        roles=[
+            RoleConfig(
+                name="Reviewer",
+                description="Review code carefully",
+                system_prompt="Review code carefully",
+                included_tools=["read"],
+            )
+        ]
+    )
+    monkeypatch.setattr("flowent.routes.roles.get_settings", lambda: settings)
+    monkeypatch.setattr("flowent.routes.roles.save_settings", lambda current: None)
+
+    result = asyncio.run(
+        update_role(
+            "Reviewer",
+            UpdateRoleRequest(
+                included_tools=[
+                    "read",
+                    "create_workflow",
+                    "delete_workflow",
+                    "list_workflows",
+                    "mcp__flowent__list_workflows",
+                    "manage_roles",
+                ],
+            ),
+        )
+    )
+
+    assert result["included_tools"] == ["read"]
+    assert settings.roles[0].included_tools == ["read"]
+
+
 def test_update_role_rejects_duplicate_name(monkeypatch):
     settings = Settings(
         roles=[
@@ -290,6 +354,51 @@ def test_update_role_rejects_builtin_prompt_change(monkeypatch):
     )
 
 
+def test_update_builtin_steward_role_model_preserves_management_tools(monkeypatch):
+    settings = Settings(
+        providers=[
+            ProviderConfig(
+                id="provider-1",
+                name="OpenAI",
+                type="openai",
+                base_url="https://api.openai.com/v1",
+                api_key="sk-test",
+                models=[
+                    ProviderModelCatalogEntry(
+                        model="gpt-4.1-mini",
+                    )
+                ],
+            )
+        ],
+        roles=[
+            RoleConfig(
+                name=STEWARD_ROLE_NAME,
+                description="Assistant role",
+                system_prompt="Help coordinate work.",
+                included_tools=list(STEWARD_ROLE_INCLUDED_TOOLS),
+            )
+        ],
+    )
+
+    monkeypatch.setattr("flowent.routes.roles.get_settings", lambda: settings)
+    monkeypatch.setattr("flowent.routes.roles.save_settings", lambda current: None)
+
+    result = asyncio.run(
+        update_role(
+            STEWARD_ROLE_NAME,
+            UpdateRoleRequest(
+                model=RoleModelRequest(
+                    provider_id="provider-1",
+                    model="gpt-4.1-mini",
+                )
+            ),
+        )
+    )
+
+    assert result["included_tools"] == list(STEWARD_ROLE_INCLUDED_TOOLS)
+    assert settings.roles[0].included_tools == list(STEWARD_ROLE_INCLUDED_TOOLS)
+
+
 def test_delete_role_uses_name_path_parameter(monkeypatch):
     settings = Settings(
         roles=[

package/backend/tests/unit/routes/test_settings_routes.py

@@ -96,6 +96,7 @@ def test_get_settings_bootstrap_returns_related_resources(monkeypatch):
                 "active_model": "",
                 "input_image": None,
                 "output_image": None,
+                "structured_output": None,
                 "capabilities": None,
                 "context_window_tokens": None,
                 "resolved_context_window_tokens": None,
@@ -616,6 +617,7 @@ def test_update_settings_accepts_model_metadata_overrides_and_token_limit(
                     "context_window_tokens": 64000,
                     "input_image": True,
                     "output_image": False,
+                    "structured_output": True,
                     "auto_compact_token_limit": 48000,
                 },
             )
@@ -625,12 +627,14 @@ def test_update_settings_accepts_model_metadata_overrides_and_token_limit(
     assert settings.model.context_window_tokens == 64000
     assert settings.model.input_image is True
     assert settings.model.output_image is False
+    assert settings.model.structured_output is True
     assert settings.model.auto_compact_token_limit == 48000
     assert result["settings"]["model"]["context_window_tokens"] == 64000
     assert result["settings"]["model"]["resolved_context_window_tokens"] == 64000
     assert result["settings"]["model"]["capabilities"] == {
         "input_image": True,
         "output_image": False,
+        "structured_output": True,
     }
     assert result["settings"]["model"]["auto_compact_token_limit"] == 48000
     assert saved == [settings]

package/backend/tests/unit/runtime/test_bootstrap_runtime.py

@@ -5,7 +5,7 @@ import pytest
 
 import flowent.settings as settings_module
 from flowent.agent import Agent
-from flowent.models import AgentState, AssistantText, ReceivedMessage, StateEntry
+from flowent.models import AgentState, AssistantText, ReceivedMessage
 from flowent.registry import registry
 from flowent.runtime import bootstrap_runtime, shutdown_runtime
 from flowent.settings import (
@@ -502,10 +502,7 @@ def test_bootstrap_runtime_backfills_state_history_for_restored_nodes(
         restored = registry.get("node-1")
         assert restored is not None
         assert restored.state == AgentState.IDLE
-        assert any(
-            isinstance(entry, StateEntry) and entry.state == "idle"
-            for entry in restored.history
-        )
+        assert restored.history == []
     finally:
         registry.reset()
 
@@ -584,11 +581,8 @@ def test_bootstrap_runtime_restores_active_nodes_as_idle(
         assert restored.state == AgentState.IDLE
         assert restored.uuid == "node-1"
         assert [todo.text for todo in restored.todos] == ["resume me"]
-        assert any(
-            isinstance(entry, StateEntry)
-            and entry.state == "idle"
-            and entry.reason == "restored"
-            for entry in restored.history
+        assert all(
+            entry.__class__.__name__ != "StateEntry" for entry in restored.history
         )
         persisted = workspace_store.get_node_record("node-1")
         assert persisted is not None
@@ -811,11 +805,8 @@ def test_bootstrap_runtime_preserves_error_state_for_restored_nodes(
         assert restored is not None
         assert restored.state == AgentState.ERROR
         assert restored.wait_until_idle(timeout=0.05) is False
-        assert not any(
-            isinstance(entry, StateEntry)
-            and entry.state == "idle"
-            and entry.reason == "initialized, awaiting first message"
-            for entry in restored.history
+        assert all(
+            entry.__class__.__name__ != "StateEntry" for entry in restored.history
         )
         persisted = workspace_store.get_node_record("node-1")
         assert persisted is not None
@@ -990,9 +981,8 @@ def test_shutdown_runtime_keeps_persistent_workspace_nodes_unterminated(
         persisted = workspace_store.get_node_record("node-1")
         assert persisted is not None
         assert persisted.state == AgentState.IDLE
-        assert not any(
-            isinstance(entry, StateEntry) and entry.state == "terminated"
-            for entry in persistent.history
+        assert all(
+            entry.__class__.__name__ != "StateEntry" for entry in persistent.history
         )
 
         bootstrap_runtime()

package/backend/tests/unit/security/test_security.py

@@ -30,7 +30,7 @@ def test_authorize_rejects_edit_when_write_dirs_empty(tmp_path):
 
     result = authorize("edit", agent, {"path": str(tmp_path / "blocked.txt")})
 
-    assert result == "Write access is disabled for this agent"
+    assert result == "Write access is disabled for this workflow"
 
 
 def test_authorize_rejects_edit_outside_write_dirs(tmp_path):
@@ -99,7 +99,7 @@ def test_authorize_rejects_fetch_when_network_disabled():
 
     result = authorize("fetch", agent, {"url": "https://example.com"})
 
-    assert result == "Network access is disabled for this agent"
+    assert result == "Network access is disabled for this workflow"
 
 
 def test_authorize_allows_other_tools_by_default():
@@ -108,3 +108,17 @@ def test_authorize_allows_other_tools_by_default():
     result = authorize("exec", agent, {"command": "pwd"})
 
     assert result is None
+
+
+def test_authorize_rejects_assistant_only_tools_for_workflow_nodes():
+    agent = Agent(
+        NodeConfig(
+            node_type=NodeType.AGENT,
+            role_name="Worker",
+            tools=["list_workflows"],
+        )
+    )
+
+    result = authorize("list_workflows", agent, {})
+
+    assert result == "Ask the Assistant to manage workflows or settings"

package/backend/tests/unit/settings/test_settings_roles.py

@@ -465,6 +465,46 @@ def test_load_settings_drops_removed_exit_tool_from_roles(monkeypatch, tmp_path)
     ]
 
 
+def test_load_settings_drops_assistant_only_tools_from_custom_roles(
+    monkeypatch,
+    tmp_path,
+):
+    settings_file = tmp_path / "settings.json"
+    settings_file.write_text(
+        json.dumps(
+            {
+                "event_log": {"timestamp_format": "absolute"},
+                "model": {"active_provider_id": "", "active_model": ""},
+                "providers": [],
+                "roles": [
+                    {
+                        "name": "Reviewer",
+                        "system_prompt": "Review work.",
+                        "included_tools": [
+                            "read",
+                            "create_workflow",
+                            "delete_workflow",
+                            "list_workflows",
+                            "mcp__flowent__list_workflows",
+                            "manage_settings",
+                        ],
+                    }
+                ],
+            }
+        ),
+        encoding="utf-8",
+    )
+
+    monkeypatch.setattr(settings_module, "_SETTINGS_FILE", settings_file)
+    monkeypatch.setattr(settings_module, "_cached_settings", None)
+
+    loaded = settings_module.load_settings()
+
+    assert loaded.roles[0].included_tools == ["read"]
+    persisted = json.loads(settings_file.read_text(encoding="utf-8"))
+    assert persisted["roles"][0]["included_tools"] == ["read"]
+
+
 def test_load_settings_migrates_legacy_post_prompt_to_custom_post_prompt(
     monkeypatch, tmp_path
 ):

package/backend/tests/unit/test_state_sqlite_storage.py

@@ -3,8 +3,11 @@ import sqlite3
 import time
 
 import flowent.settings as settings_module
+from flowent.agent import Agent
 from flowent.image_assets import create_image_asset
-from flowent.mcp_service import MCPDiscoverySnapshot, mcp_service
+from flowent.mcp_service import MCPDiscoverySnapshot, MCPToolDescriptor, mcp_service
+from flowent.models import NodeConfig, NodeType
+from flowent.settings import MCPServerConfig, Settings
 
 _ONE_PIXEL_PNG = base64.b64decode(
     "iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mP8/x8AAwMCAO+aF9sAAAAASUVORK5CYII="
@@ -91,3 +94,66 @@ def test_mcp_service_restores_persisted_snapshot_and_activity_after_runtime_clea
         assert restored_activities[0].summary == "Capabilities refreshed"
     finally:
         mcp_service.reset()
+
+
+def test_mcp_service_filters_workflow_management_tools_for_non_assistant(
+    monkeypatch,
+    tmp_path,
+):
+    settings_file = tmp_path / "settings.json"
+    settings_file.write_text("{}", encoding="utf-8")
+    monkeypatch.setattr(settings_module, "_SETTINGS_FILE", settings_file)
+    monkeypatch.setattr(settings_module, "_cached_settings", None)
+    monkeypatch.setattr(
+        "flowent.mcp_service.get_settings",
+        lambda: Settings(
+            mcp_servers=[
+                MCPServerConfig(
+                    name="flowent",
+                    transport="stdio",
+                )
+            ]
+        ),
+    )
+    mcp_service.reset()
+
+    try:
+        mcp_service._set_snapshot(
+            MCPDiscoverySnapshot(
+                server_name="flowent",
+                transport="stdio",
+                status="connected",
+                auth_status="unsupported",
+                tools=[
+                    MCPToolDescriptor(
+                        server_name="flowent",
+                        tool_name="list_workflows",
+                        fully_qualified_id="mcp__flowent__list_workflows",
+                    ),
+                    MCPToolDescriptor(
+                        server_name="flowent",
+                        tool_name="search_notes",
+                        fully_qualified_id="mcp__flowent__search_notes",
+                    ),
+                ],
+            )
+        )
+        worker = Agent(NodeConfig(node_type=NodeType.AGENT), uuid="worker")
+        assistant = Agent(NodeConfig(node_type=NodeType.ASSISTANT), uuid="assistant")
+
+        worker_tools = {
+            descriptor.fully_qualified_id
+            for descriptor in mcp_service.list_agent_dynamic_tools(worker)
+        }
+        assistant_tools = {
+            descriptor.fully_qualified_id
+            for descriptor in mcp_service.list_agent_dynamic_tools(assistant)
+        }
+
+        assert worker_tools == {"mcp__flowent__search_notes"}
+        assert assistant_tools == {
+            "mcp__flowent__list_workflows",
+            "mcp__flowent__search_notes",
+        }
+    finally:
+        mcp_service.reset()

package/backend/tests/unit/tools/test_connect_tool.py

@@ -122,7 +122,6 @@ def test_connect_tool_creates_directed_workflow_edge():
                 "to": right.uuid,
                 "from_port_key": "out",
                 "to_port_key": "in",
-                "kind": "control",
             },
         )
     )
@@ -132,7 +131,7 @@ def test_connect_tool_creates_directed_workflow_edge():
     assert result["from_port_key"] == "out"
     assert result["to_node_id"] == "worker-b"
     assert result["to_port_key"] == "in"
-    assert result["kind"] == "control"
+    assert "kind" not in result
     assert left.get_connections_snapshot() == []
     assert right.get_connections_snapshot() == []
     stored_edges = workspace_store.list_edges(tab.id)
@@ -191,7 +190,7 @@ def test_connect_tool_resolves_non_agent_workflow_nodes_by_name():
 
     assert result["from_node_id"] == "worker-a"
     assert result["to_node_id"] == "code-a"
-    assert result["kind"] == "control"
+    assert "kind" not in result
 
 
 def test_connect_tool_rejects_leader_endpoints():