flow-workflows 0.77.0 → 0.79.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/adapters/codex/CORE.md +122 -5
- package/adapters/codex/skills/flow-bug-review/SKILL.md +1 -0
- package/adapters/codex/skills/flow-bug-ship/SKILL.md +2 -0
- package/adapters/codex/skills/flow-doctor/SKILL.md +2 -2
- package/adapters/codex/skills/flow-feat-build/SKILL.md +2 -2
- package/adapters/codex/skills/flow-feat-design/SKILL.md +1 -1
- package/adapters/codex/skills/flow-feat-review/SKILL.md +2 -1
- package/adapters/codex/skills/flow-feat-ship/SKILL.md +48 -0
- package/adapters/codex/skills/flow-work-README/SKILL.md +15 -0
- package/adapters/codex/skills/flow-work-respond/SKILL.md +2 -1
- package/adapters/gemini/CORE.md +122 -5
- package/adapters/gemini/commands/flow/bug/review.toml +1 -0
- package/adapters/gemini/commands/flow/bug/ship.toml +2 -0
- package/adapters/gemini/commands/flow/doctor.toml +2 -2
- package/adapters/gemini/commands/flow/feat/build.toml +2 -2
- package/adapters/gemini/commands/flow/feat/design.toml +1 -1
- package/adapters/gemini/commands/flow/feat/review.toml +2 -1
- package/adapters/gemini/commands/flow/feat/ship.toml +48 -0
- package/adapters/gemini/commands/flow/work/README.toml +15 -0
- package/adapters/gemini/commands/flow/work/respond.toml +2 -1
- package/adapters/hermes/CORE.md +122 -5
- package/adapters/hermes/skills/flow-bug-review/SKILL.md +1 -0
- package/adapters/hermes/skills/flow-bug-ship/SKILL.md +2 -0
- package/adapters/hermes/skills/flow-doctor/SKILL.md +2 -2
- package/adapters/hermes/skills/flow-feat-build/SKILL.md +2 -2
- package/adapters/hermes/skills/flow-feat-design/SKILL.md +1 -1
- package/adapters/hermes/skills/flow-feat-review/SKILL.md +2 -1
- package/adapters/hermes/skills/flow-feat-ship/SKILL.md +48 -0
- package/adapters/hermes/skills/flow-work-README/SKILL.md +15 -0
- package/adapters/hermes/skills/flow-work-respond/SKILL.md +2 -1
- package/adapters/opencode/CORE.md +122 -5
- package/adapters/opencode/commands/flow-bug-review.md +1 -0
- package/adapters/opencode/commands/flow-bug-ship.md +2 -0
- package/adapters/opencode/commands/flow-doctor.md +2 -2
- package/adapters/opencode/commands/flow-feat-build.md +2 -2
- package/adapters/opencode/commands/flow-feat-design.md +1 -1
- package/adapters/opencode/commands/flow-feat-review.md +2 -1
- package/adapters/opencode/commands/flow-feat-ship.md +48 -0
- package/adapters/opencode/commands/flow-work-README.md +15 -0
- package/adapters/opencode/commands/flow-work-respond.md +2 -1
- package/package.json +1 -1
- package/plugins/flow/.claude-plugin/plugin.json +1 -1
- package/plugins/flow/CHANGELOG.md +41 -0
- package/plugins/flow/examples/FLOW.template.md +13 -2
package/adapters/codex/CORE.md
CHANGED
|
@@ -17,7 +17,7 @@ Every `$flow-*` command assumes these rules. They are stated once, here, so a co
|
|
|
17
17
|
carries what is specific to its phase. Read this once per session; a command that says "load
|
|
18
18
|
`flow-core`" means this file.
|
|
19
19
|
|
|
20
|
-
**This file belongs to flow `0.
|
|
20
|
+
**This file belongs to flow `0.79.0`.** Compare it once, at the start of the session, against
|
|
21
21
|
`version` in `~/.claude/flow/.claude-plugin/plugin.json`. The two differing means the session
|
|
22
22
|
is running a **mixture** — the commands from one copy of the plugin, these shared rules from another
|
|
23
23
|
— which is exactly what happens when a branch or a release candidate is loaded over an installed
|
|
@@ -98,8 +98,7 @@ a command relies on is simply absent in that session, and nothing else will repo
|
|
|
98
98
|
"general-purpose", "phase": "review" }`. Asking here would break the never-a-question contract
|
|
99
99
|
(§2); recording keeps the decision readable afterwards, and `$flow-doctor` aggregates it.
|
|
100
100
|
|
|
101
|
-
**The list, and it is short on purpose**: `
|
|
102
|
-
role on an M/L or sensitive diff · `quality.review_depth` after a review's cost line went over
|
|
101
|
+
**The list, and it is short on purpose**: `quality.review_depth` after a review's cost line went over
|
|
103
102
|
`agents.budget_max` · `data.volumes` or `data.explain_cmd` when the query duel came back
|
|
104
103
|
schema-only · `quality.functional_check` when `validate` found a runnable app and no way to drive
|
|
105
104
|
it · `tracker.start_cmd`/`done_cmd`/`abandon_cmd` the first time a ticket could have been
|
|
@@ -157,8 +156,8 @@ improvises, `models.workers` for the parallel fan-out rounds, and `models.superv
|
|
|
157
156
|
bounded waits of §6.5 — the last two falling back to `models.agents`. Empty, absent, or no section
|
|
158
157
|
→ everything runs on the model you were launched with, and you say nothing.
|
|
159
158
|
|
|
160
|
-
- Pass the resolved value to every subagent you launch, **except** an agent named in `agents.<role
|
|
161
|
-
which keeps the model its own definition sets.
|
|
159
|
+
- Pass the resolved value to every subagent you launch, **except** an agent named in `agents.<role>`
|
|
160
|
+
or picked from the installed ones (§6.6), which keeps the model its own definition sets.
|
|
162
161
|
- **You cannot switch your own model**, so no key names the phases the main agent performs itself.
|
|
163
162
|
A phase that wants another model says it in one line at the handoff (`this step reads better on
|
|
164
163
|
<value>, you are on <current>` → `/model <value>`), records it in the artifact, and continues.
|
|
@@ -556,6 +555,124 @@ moving.
|
|
|
556
555
|
than to run — the brief, the round trip and the report are the whole of the saving. And anything you
|
|
557
556
|
must *react to* mid-wait is not a wait at all: it is the work, and it stays here.
|
|
558
557
|
|
|
558
|
+
### 6.6 — Which agent a role resolves to
|
|
559
|
+
|
|
560
|
+
**The harness already tells you which agents are installed**, each with a line on what it is for,
|
|
561
|
+
and choosing the one that fits a piece of work is something you do well without being told. A rule
|
|
562
|
+
that answers every empty role with `general-purpose` throws that away: a repo with a frontend
|
|
563
|
+
specialist installed and no `agents.frontend` got a generalist told to act like one. So wherever a
|
|
564
|
+
command says *"`agents.<role>`, empty → `Agent general-purpose` with the role"*, it means this:
|
|
565
|
+
|
|
566
|
+
1. **`agents.<role>` names an agent** → that agent, as always.
|
|
567
|
+
2. **Empty** → the installed agent whose description fits the role **and this work's stack** best —
|
|
568
|
+
read the list your harness gives you, never a guess at a name. None fits clearly →
|
|
569
|
+
`general-purpose` with the role in the prompt, as before. An agent that fits the role but not the
|
|
570
|
+
stack (a PHP reviewer on a React diff) does not fit.
|
|
571
|
+
|
|
572
|
+
**`agents.selection`** decides how far your judgement reaches:
|
|
573
|
+
|
|
574
|
+
- **`configured`** (empty → this) — the two steps above. A role you named is never second-guessed.
|
|
575
|
+
- **`open`** — a named role is a default, not an order: for a piece clearly outside what it
|
|
576
|
+
covers, or where an installed agent fits this piece plainly better, take that one. And a piece
|
|
577
|
+
**no role covers** — a UI component in a work whose roles are all backend — may go to the
|
|
578
|
+
specialist that does cover it. Every substitution is **one line in the phase artifact**: role,
|
|
579
|
+
the agent configured, the agent used, and why. Unrecorded, a panel that ran with other agents
|
|
580
|
+
reads exactly like the one you configured.
|
|
581
|
+
|
|
582
|
+
**Nothing installed fits → create the specialist for this work.** An installed agent is, in the
|
|
583
|
+
end, a brief with a name; what made it good is the brief. So instead of *"act as frontend"*, write
|
|
584
|
+
the one an expert would carry — the stack and its versions as this repo uses them, what to check
|
|
585
|
+
in this piece, the mistakes typical of it, and the report contract of this section — and launch
|
|
586
|
+
`general-purpose` with it. Nothing is written to the harness's agent folders: the specialist lives
|
|
587
|
+
for the brief, and it works on every harness, because every one has a general-purpose agent.
|
|
588
|
+
Record it in `meta.json.specialists[]`:
|
|
589
|
+
|
|
590
|
+
`{ "name": "react-form-reviewer", "role": "frontend", "phase": "review", "brief": "<the full text
|
|
591
|
+
you sent>", "useful": null, "status": null }`
|
|
592
|
+
|
|
593
|
+
Once its result is in, set `useful`: `true` when something it returned was kept — a finding
|
|
594
|
+
accepted, a piece merged into the diff — `false` otherwise. Only a useful one is ever offered for
|
|
595
|
+
saving, and only **when the work ends** (`$flow-feat-ship` §5.1), never mid-phase: by then the
|
|
596
|
+
MR/PR is open and it is plain which of them earned a place among your agents.
|
|
597
|
+
|
|
598
|
+
Three things this never touches, in either mode:
|
|
599
|
+
|
|
600
|
+
- **The review roster** (`quality.review_skill` / `quality.reviewers`) runs as defined, with no
|
|
601
|
+
substitutions: its value is being the same panel every time, so a result can be compared.
|
|
602
|
+
- **The agents that are `general-purpose` by design** — challengers, skeptics, the completeness
|
|
603
|
+
critic, the blinded contract check. They are generalists *on purpose*: a specialist brings the
|
|
604
|
+
assumptions the blinding is there to strip. A step that writes `general-purpose` with no role
|
|
605
|
+
behind it means exactly that.
|
|
606
|
+
- **The budget.** A picked agent counts against `agents.budget_max` like any other. Like a named
|
|
607
|
+
agent it keeps its own model (§1), and `models.agents` reaches it only when it has none.
|
|
608
|
+
|
|
609
|
+
Record what you picked where a default would be recorded (§0): *"`agents.frontend` empty → used
|
|
610
|
+
`react-expert` (installed)"*. That line is also the evidence for writing the role down when the
|
|
611
|
+
next stop offers it.
|
|
612
|
+
|
|
613
|
+
### 6.7 — An agent that missed something learns it, once
|
|
614
|
+
|
|
615
|
+
A reviewer that let a defect through will let the same one through next time: nothing it is given
|
|
616
|
+
changes between works. The fix is to its definition, and the evidence that it needs one arrives
|
|
617
|
+
here, in the flow, where somebody else caught what it did not. So a phase that holds that evidence
|
|
618
|
+
records it, and the work's close offers to write it into the agent.
|
|
619
|
+
|
|
620
|
+
**Only evidence from outside the agent counts.** An agent judging its own performance almost
|
|
621
|
+
always finds it good, and a lesson learned from that is a transient failure written down as a
|
|
622
|
+
permanent rule. Three signals, and nothing else:
|
|
623
|
+
|
|
624
|
+
- **Missed** — a finding that survived (§6 verification, or the user's acceptance) falls squarely in
|
|
625
|
+
the category a panel member or a named `agents.<role>` owns, and **that agent did not report it**
|
|
626
|
+
while another source did: the built-in review, another pass, a reinforcement, a human.
|
|
627
|
+
- **Produced** — a surviving finding sits in code a delegated agent wrote (a `build` piece, the
|
|
628
|
+
testing agent's suite): the lesson goes to the agent that wrote it.
|
|
629
|
+
- **Human caught** — a reviewer's thread in `$flow-work-respond` that ended in a code change, in a
|
|
630
|
+
category a panel member owns: the whole panel missed it, and the owner is the one to learn.
|
|
631
|
+
|
|
632
|
+
**The same test as a convention (§8), aimed at the agent.** Would this lesson help that agent on an
|
|
633
|
+
unrelated work in its domain? No → it belongs to this ticket, record nothing. Yes, but it is a fact
|
|
634
|
+
about the **repo** rather than the agent's craft (*"the test command is `make test-unit`"*) → it is a
|
|
635
|
+
`conventions_candidates[]` row, not a lesson. Yes, and it is about the craft (*"check that every
|
|
636
|
+
state change inside a loop is flushed once, not per iteration"*) → a lesson.
|
|
637
|
+
|
|
638
|
+
Record it in `meta.json.agent_lessons[]`, asking nothing:
|
|
639
|
+
|
|
640
|
+
`{ "agent": "query-reviewer", "signal": "missed" | "produced" | "human", "phase":
|
|
641
|
+
"review", "evidence": "<finding or thread, one line, with file:line or URL>", "lesson": "<one
|
|
642
|
+
imperative line, general, no ticket id>", "status": null }`
|
|
643
|
+
|
|
644
|
+
**What is never edited**, and the lesson stays recorded in `meta.json` for you to read:
|
|
645
|
+
|
|
646
|
+
- an agent installed from a plugin or a marketplace — it is someone else's file, and the next
|
|
647
|
+
update would overwrite the edit anyway;
|
|
648
|
+
- a skill (`quality.review_skill`) — it orchestrates agents rather than being one;
|
|
649
|
+
- `general-purpose` and the improvised specialists of §6.6 that were not saved — no file to edit.
|
|
650
|
+
|
|
651
|
+
**Writing it — only at the work's close** (`$flow-feat-ship` §5.2, `$flow-work-respond` §8), with
|
|
652
|
+
`agents.learn` (empty → `offer`; `off` → nothing is recorded or offered):
|
|
653
|
+
|
|
654
|
+
- **Your agents** (written by hand, or shared through the repo) → shown as a diff and written only
|
|
655
|
+
on an explicit yes, **in every mode**: it is your configuration, and in the repo it is your team's.
|
|
656
|
+
- **Agents flow created** (§6.6 saved with `created_by: flow` in their frontmatter) → the same
|
|
657
|
+
question in `manual`; in `guided`/`auto` written directly and reported in one line.
|
|
658
|
+
|
|
659
|
+
**How it is kept small** — without this, the file grows one line per incident until the rules
|
|
660
|
+
nobody reads crowd out the ones that matter:
|
|
661
|
+
|
|
662
|
+
1. Lessons live in one section at the end of the file, `## Lessons from past work`, one line each.
|
|
663
|
+
The rest of the file is never rewritten.
|
|
664
|
+
2. **Already there, in any wording → the lesson is not added.** The agent had the rule and missed
|
|
665
|
+
anyway, which says the rule is weak, not absent: offer instead to move it out of the lessons
|
|
666
|
+
into the body of the brief, rewritten as a check the agent must perform.
|
|
667
|
+
3. **At `agents.lessons_max` lines (empty → 10), adding one means consolidating first**: merge
|
|
668
|
+
lines that say the same thing, generalise two narrow ones into the rule they share, drop one a
|
|
669
|
+
later lesson supersedes. Show the section before and after in the same question.
|
|
670
|
+
4. **Before any edit, copy the file** to `.claude/work/<work>/agent-backups/<name>.md` and record
|
|
671
|
+
the path in the lesson's entry. Undoing is copying it back. A file is never deleted.
|
|
672
|
+
|
|
673
|
+
Then `status`: `"written"` (with the path) · `"declined"` (never offered again) · `"later"` ·
|
|
674
|
+
`"not-editable"` (one of the three cases above, with which).
|
|
675
|
+
|
|
559
676
|
## 7. Deferred work — `followups[]`
|
|
560
677
|
|
|
561
678
|
Every chain in this plugin reaches moments where the right call is **not to do it here**: a build
|
|
@@ -234,6 +234,7 @@ Cost line: count every subagent this command launched — reviewers = §2.1 buil
|
|
|
234
234
|
- Without blockers: `phase = "review"`, add to `phases_done`. Suggest `$flow-bug-postmortem` (M/L) or `$flow-bug-ship` (XS/S).
|
|
235
235
|
- **Record *what* you reviewed, and separately what you changed after reading it** — `$flow-feat-review` §9, unchanged: `reviewed_sha` = the **candidate** of §1.5 (the revision the reviewers read, never `git rev-parse HEAD`, which by now holds this round's own fixes), and `fixed_sha` = `git rev-parse HEAD` after those fixes, empty when the round applied none. `phases_done` says a review happened; these two say on which tree and what moved afterwards, and `$flow-bug-ship §0` reads both against what is being pushed. Only when the phase advances: a review that ended in blockers reviewed nothing that stands.
|
|
236
236
|
- **Record which pass found what** — `$flow-feat-review §9`, unchanged: one `meta.json.review_findings[]` entry per finding **per source** (`{ round, origin, severity, file, discarded_by_skeptic }`, no finding text), written by `flow review --record` when the CLI ran the panel and by this Close when the agentic panel did. `flow cost` reads them back per origin, and the retirement rule is the same: a pass with no exclusive surviving finding across twenty reviews comes out of the command.
|
|
237
|
+
- **Record what the agents missed** — `$flow-feat-review §9`, unchanged: surviving findings in a category a panel member or named `agents.<role>` owns and did not report → `meta.json.agent_lessons[]` rows (flow-core §6.7), asking nothing. A fix is where this pays most: the defect already reached production once, and the reviewer that owns its category let it.
|
|
237
238
|
- **Stage what the review taught** (`knowledge.stage` set; silence by default). Review is where a project teaches the most and, until now, the one phase that never staged — a work with three review rounds and seventeen blockers produced zero knowledge cards because nothing asked for them while they were in context. Candidates are findings about the **domain or the codebase's real behaviour**, not about this diff: a library that does other than its name says, a test disguise that kept the suite green over a live defect, a module rule the reviewers had to cite from its own prose, a measurement. A blocker fixed here is not knowledge; *why it was written wrong* may be. Same evidence rule as `$flow-feat-design` §8 — one line of evidence per finding or it is not staged. One call per finding, one line to the user («Staged N finding(s) for `postmortem`/`ship`»). Never `knowledge.save` here.
|
|
238
239
|
- Overwrite `00-summary.md` whole (≤15 lines, flow-core §5).
|
|
239
240
|
- Stop body (after the flow-core §3 header): the findings that survived and what you did with each, plus the same Cost line as the Summary: "- Cost: <n>/<budget_max> subagents launched (<k> reviewers · <m> reinforcements · <s> skeptics), tier <light|proportional|full>".
|
|
@@ -186,6 +186,8 @@ nothing was measured. A slowness bug is the case where this comment *is* the pro
|
|
|
186
186
|
- **Cross-repo reminder**: for each `meta.json.related_repos` entry not `done`: *"you've shipped the `<this-repo>` part; `<repo>` still needs: `<scope>` → go there and run `$flow-bug-start <TICKET>` (or `$flow-feat-start`)"*. flow only reminds; this is not a hard gate.
|
|
187
187
|
- **Cross-repo contract handoff**: for each such entry with `contract_handoff: "pending"` — the fix changed a surface that sibling consumes — hand the new shape over as `$flow-feat-ship` §6.3 (publish the **literal** shape to the tracker ticket, mandatory preview in every autonomy mode, then record `published → <location>`; versioned-file fallback when there is no tracker). A bug flow has no §"External contracts": take the literal from the fix itself — the actual key, code, route or event the code now emits — read it off the code, never from memory.
|
|
188
188
|
- **Follow-up triage — `$flow-feat-ship` §6.4, in full and unchanged.** Read `meta.json.followups[]`; nothing `proposed` → skip silently. Otherwise §6.4 step 0 first — **3 or more candidates go to a skeptic** whose job is to refute that each deserves a ticket, and only the strongest `tracker.followup_ask_max` (empty → **2**) reach the user (flow-core §7) — then one batched `AskUserQuestion` (**Do it** / **Not worth it** / **Later**; `decision` entries asked as their question, `tooling` and everything `log`ged never asked), the accepted ones get their tracker issue created (outward-facing → **asks in every mode**), the logged ones nothing but `status: "logged"` in `meta.json`, then one offer to start the first. A bug flow is where the gate earns its keep: the prevention actions `$flow-bug-postmortem` wrote, the neighbouring bugs `$flow-bug-validate` found and the similar-risk patterns `$flow-bug-fix` flagged all land here — half a dozen of them, from one fix, and «similar risk elsewhere» that no skeptic ever read is exactly the entry that turns a closed bug into six open questions. Repeat for anything still `proposed` on the re-run that confirms the merge.
|
|
189
|
+
- **Specialists created — `$flow-feat-ship` §5.1, in full and unchanged.** Read `meta.json.specialists[]` (flow-core §6.6); nothing `useful` and pending → skip silently. Otherwise one batched offer to save each as an agent, after the MR/PR and after the knowledge `$flow-bug-postmortem` §4 already consolidated — asked in every mode, never overwriting an agent that exists.
|
|
190
|
+
- **What the agents missed — `$flow-feat-ship` §5.2, in full and unchanged.** Read `meta.json.agent_lessons[]` (flow-core §6.7); `agents.learn: off` or nothing pending → skip silently. Otherwise one question per agent with the resulting lessons section, backup first, your agents asked in every mode.
|
|
189
191
|
- **Conventions learned — `$flow-feat-ship` §6.4bis, in full and unchanged.** Read `meta.json.conventions_candidates[]` (flow-core §8); nothing pending → skip silently. Otherwise: drop what `FLOW.md` already says, then one batched `AskUserQuestion` (**Add to FLOW.md** / **Not a rule** / **Later**, or **Replace** when it contradicts a line that is there). Asked in every mode — it edits a file in the tree. A fix is where the corrections land hardest: *«never mock the repository in that layer»*, *«the regression test goes next to the unit test, not in the functional suite»* — said once inside `bug:fix`, and proposed again in the next incident unless they reach the file.
|
|
190
192
|
- **Close the follow-up that started this work.** `meta.json.origin` set and this ship moved `phase` to `done` → open the originating work's `meta.json` (live folder or `_archive/`) and set that `followups[]` entry to `status: "done"`. Best-effort: the originating folder is gone or unreadable → warn in one line and continue, never block. Without this the entry stays `in_progress` forever and `status`/`daily` keep reporting work that is finished.
|
|
191
193
|
- **Only once `phase` is `done`**: delete the candidate anchor `$flow-bug-review §1.5` left behind — `git update-ref -d refs/flow/candidate/<TICKET>`. No question: local, never pushed, and the gate that needed it has run.
|
|
@@ -196,8 +196,8 @@ refuse) · **degraded** (it runs, quietly worse than the config promises), plus
|
|
|
196
196
|
|
|
197
197
|
- Every **role** set in `agents.*` (not `fanout_max` / `fanout_tool` — not agents), plus
|
|
198
198
|
`quality.reviewers` and `quality.review_skill`: discoverable in `~/.claude/agents`, the repo's
|
|
199
|
-
`.agents/agents`, or a plugin. Report each missing name and that it falls back
|
|
200
|
-
(a skill: skipped) — a panel missing agents reviews less and still reports a clean pass.
|
|
199
|
+
`.agents/agents`, or a plugin. Report each missing name and that it falls back per flow-core §6.6 — the installed agent
|
|
200
|
+
that fits, else `general-purpose` (a skill: skipped) — a panel missing agents reviews less and still reports a clean pass.
|
|
201
201
|
- Harness cannot set a model per subagent → note that every `models.*` value degrades to inheritance.
|
|
202
202
|
- **Where the live panel will go this session** (flow-core §4): a tool whose name ends in `panel_set` / `panel_patch` — namespaced by the harness (`mcp__panel__panel_set` on Claude Code) and possibly **deferred**, which reads as absent until the list of deferred tools is checked → the terminal draws the panel and no `panel.json` is written; genuinely absent → the panel is that file, as before. Neither is a fault — one line naming the tools as they are actually called here, or saying the file is the transport.
|
|
203
203
|
|
|
@@ -139,8 +139,8 @@ Take the shape from the **Access paths** table in `03-design.md`; a query matchi
|
|
|
139
139
|
|
|
140
140
|
Execution mode:
|
|
141
141
|
|
|
142
|
-
- **Single-thread (XS/S/M)**: implement yourself, step by step
|
|
143
|
-
- **Partial delegation (M/L with clear pieces)**: `Agent` for isolated endpoints, plus `agents.testing` from `FLOW.md` in parallel to prepare the test suite (
|
|
142
|
+
- **Single-thread (XS/S/M)**: implement yourself, step by step. Delegate a piece when a specialist would do it clearly better than you — a UI component to a frontend agent in a mostly backend work, a migration to a persistence agent — not because it is tedious; consult one when blocked — `agents.architecture` from `FLOW.md` for layer questions, `agents.persistence` for query/mapping questions. Which agent each role resolves to, and whether you may pick past a named one, is flow-core §6.6. A delegated piece follows the brief rules of the next bullet and the one-writer rule of flow-core §6.
|
|
143
|
+
- **Partial delegation (M/L with clear pieces)**: `Agent` for isolated endpoints, plus `agents.testing` from `FLOW.md` in parallel to prepare the test suite (empty → flow-core §6.6). Pass the full `03-design.md` in the prompt so agents do not invent things.
|
|
144
144
|
|
|
145
145
|
A brief here states the **output** as explicitly as the input (flow-core §6):
|
|
146
146
|
- **Name the path the agent writes**, and require it to **save after each finished piece, not at the end**. Code, tests and generated content are the deliverable; the report is not. Then **verify the file** instead of believing the report — a piece half-written on disk is recoverable, what only exists in the agent's context is lost the moment it is stopped.
|
|
@@ -175,7 +175,7 @@ Save the result at the top of `03-design.md` under "## What already exists". Des
|
|
|
175
175
|
## 4. Work
|
|
176
176
|
|
|
177
177
|
1. Load the project's skills (`FLOW.md` section `conventions`).
|
|
178
|
-
2. Launch **in parallel** by feature/project type. Agent = `agents.<role>` from `FLOW.md`; empty → `Agent general-purpose` with the role in the prompt.
|
|
178
|
+
2. Launch **in parallel** by feature/project type. Agent = `agents.<role>` from `FLOW.md`; empty → the installed agent that fits, else `Agent general-purpose` with the role in the prompt (flow-core §6.6).
|
|
179
179
|
|
|
180
180
|
| When | Agent | Task |
|
|
181
181
|
|---|---|---|
|
|
@@ -386,6 +386,7 @@ Write `.claude/work/<TICKET>/06-review.md`. The `Cost:` line of `## Summary` is
|
|
|
386
386
|
**The retirement rule, written down before the data arrives** so it cannot be argued backwards later: a pass that contributes **no exclusive surviving finding across twenty reviews** is removed from this command. Zero is zero, and the decision is made against the number rather than against whoever is most attached to the pass.
|
|
387
387
|
- **Stage what the review taught** (`knowledge.stage` set; silence by default). Review is where a project teaches the most and, until now, the one phase that never staged — a work with three review rounds and seventeen blockers produced zero knowledge cards because nothing asked for them while they were in context. Candidates are findings about the **domain or the codebase's real behaviour**, not about this diff: a library that does other than its name says, a test disguise that kept the suite green over a live defect, a module rule the reviewers had to cite from its own prose, a measurement. A blocker fixed here is not knowledge; *why it was written wrong* may be. Same evidence rule as `$flow-feat-design` §8 — one line of evidence per finding or it is not staged. One call per finding, one line to the user («Staged N finding(s) for `ship`»). Never `knowledge.save` here.
|
|
388
388
|
- Overwrite `00-summary.md` whole (≤15 lines, flow-core §5).
|
|
389
|
-
- **
|
|
389
|
+
- **Record what the agents missed** (flow-core §6.7, `agents.learn` not `off`; asking nothing): for each finding that survived, the panel member or named `agents.<role>` whose category it falls in and who did not report it, and the delegated `build` agent whose code it sits in → one `meta.json.agent_lessons[]` row each, only when the lesson passes the §6.7 test. The origins §2.1 carried are what make this possible — a finding with no origin teaches nobody.
|
|
390
|
+
- **Configuration this phase earned the right to ask about** (flow-core §0, `manual` only, at most one key per work, as an extra option on this same stop — never a question of its own): a `Cost:` line that went over `agents.budget_max` → `quality.review_depth`. In `guided`/`auto` neither is asked: the default is taken and recorded in `meta.json.defaults_used[]`.
|
|
390
391
|
- Report findings and next step **following the stop header** (flow-core §3) **when this is a stop**; in `guided`/`auto` with a clean gate the next command runs in this same turn, so this goes to `06-review.md` and the turn opens with the call that chains — the `Cost:` line then travels to the stop the run does reach, added to that phase's own. Include it once. Body: the findings that **survived** verification and what you did with each — a blocker, an applied fix, a rejection with its reason. Corrections to the reviewers' own reports go to `06-review.md`, not here.
|
|
391
392
|
- **Autonomy handoff.** Only when there are **no blockers and no unresolved high-severity findings** — with any of those, stop in every mode (hard gate). Clean: in `manual`, propose `$flow-feat-validate` with a single `AskUserQuestion` and invoke it on confirmation; in `guided`/`auto`, **chain into `$flow-feat-validate` automatically** in this same turn. Never chain into `$flow-feat-ship` from here — ship is reached through `validate`.
|
|
@@ -234,6 +234,54 @@ Only if `knowledge.read_staging` or `knowledge.save` is set; neither → skip wi
|
|
|
234
234
|
3. **Combine staging + new findings** into a short list. Empty or only code-derivable → do not insist.
|
|
235
235
|
4. 1+ relevant findings → ask the user whether to consolidate. Yes → run the consolidation of flow-core §0 (`read_staging`, then one decision and one `knowledge.save` per finding). No → do not insist.
|
|
236
236
|
|
|
237
|
+
## 5.1 Specialists created (offer)
|
|
238
|
+
|
|
239
|
+
Read `meta.json.specialists[]` (flow-core §6.6). **No entry with `useful: true` and `status` unset
|
|
240
|
+
or `"later"` → skip this section and say nothing.** It comes after §5 on purpose: the MR/PR is open,
|
|
241
|
+
the knowledge is saved, and what is left is whether an agent this work improvised deserves a name.
|
|
242
|
+
|
|
243
|
+
1. **A harness with no file-defined agents** → the section does not exist; say so in one line if
|
|
244
|
+
there were useful specialists, so the brief is not mistaken for lost (it stays in `meta.json`).
|
|
245
|
+
2. **One `AskUserQuestion`**, at most 4 entries, most useful first: its `name`, the role, the phase,
|
|
246
|
+
and in one line what it caught. Options: **Save as agent** · **Save and use it for `<role>`** ·
|
|
247
|
+
**No** · **Later**. The second option exists only when `agents.<role>` is empty.
|
|
248
|
+
3. **Asked in every mode**, `auto` included: it writes to your agent configuration, outside the
|
|
249
|
+
tree, and that is never flow mechanics.
|
|
250
|
+
4. **Save** → write the agent where and in the format your harness reads agents from (on Claude
|
|
251
|
+
Code, `~/.claude/agents/<name>.md`: frontmatter `name`, a one-line `description` of when to
|
|
252
|
+
use it and `created_by: flow` (flow-core §6.7 reads it), then the brief as the body — drop what only made sense for this ticket, keep the stack,
|
|
253
|
+
the checks and the typical mistakes). A file with that name already there → never overwrite:
|
|
254
|
+
suffix the name and say so. **Save and use it** → also write `agents.<role>: <name>` to the
|
|
255
|
+
active overlay (a harness-owned agent name, flow-core §0). Then `status: "saved"`, with the path.
|
|
256
|
+
**No** → `"declined"`, never offered again. **Later** → `"later"`, offered by the re-run of this
|
|
257
|
+
close.
|
|
258
|
+
5. **One line on screen**: how many agents were saved and where.
|
|
259
|
+
|
|
260
|
+
## 5.2 What the agents missed (offer)
|
|
261
|
+
|
|
262
|
+
Read `meta.json.agent_lessons[]` (flow-core §6.7). `agents.learn: off`, or no entry with `status`
|
|
263
|
+
unset or `"later"` → skip this section and say nothing. Last of the three offers on purpose: the
|
|
264
|
+
MR/PR is open, the knowledge is saved, the specialists have their files — now the agents that
|
|
265
|
+
exist get what this work showed they lacked.
|
|
266
|
+
|
|
267
|
+
1. **Group by agent**, and resolve each agent's file (`~/.claude/agents`, the repo's agent folder,
|
|
268
|
+
the overlay's harness equivalent). Plugin- or marketplace-installed, a skill, or no file →
|
|
269
|
+
`status: "not-editable"` with which, and one line on screen; the lesson stays readable in
|
|
270
|
+
`meta.json`.
|
|
271
|
+
2. **Apply the size rules of §6.7 before asking** — drop what the file already says (and turn it
|
|
272
|
+
into the "promote to a check" option instead), consolidate when the section is at
|
|
273
|
+
`agents.lessons_max` — so the question shows the section as it would end up, not a line to append.
|
|
274
|
+
3. **One `AskUserQuestion`**, one entry per agent (at most 4, most lessons first): the agent, the
|
|
275
|
+
evidence in one line per lesson, and the resulting `## Lessons from past work` section. Options:
|
|
276
|
+
**Write it** · **No** · **Later**. Your agents are asked **in every mode**; agents with
|
|
277
|
+
`created_by: flow` are asked in `manual` and written directly in `guided`/`auto`.
|
|
278
|
+
4. **Write it** → back up the file (§6.7), replace only that section, record the path and the
|
|
279
|
+
backup in each entry, `status: "written"`. A file tracked by the repo is left modified in the
|
|
280
|
+
tree, uncommitted, and said so in one line: it is the team's file and the team's commit.
|
|
281
|
+
**No** → `"declined"`. **Later** → `"later"`, offered again by the re-run of this close or by
|
|
282
|
+
`$flow-work-respond`.
|
|
283
|
+
5. **One line on screen**: how many agents learned something, and where the backups are.
|
|
284
|
+
|
|
237
285
|
## 5.5 A worktree does not own the tree its tools wrote into
|
|
238
286
|
|
|
239
287
|
`meta.json.worktree` null → skip silently; there is nothing here that can go wrong.
|
|
@@ -136,6 +136,19 @@ This system **orchestrates** the project's existing sub-agents and skills (it do
|
|
|
136
136
|
"evidence": "the stop it came from",
|
|
137
137
|
"status": "proposed" | "added" | "declined", "note": "" }
|
|
138
138
|
],
|
|
139
|
+
"specialists": [
|
|
140
|
+
{ "name": "react-form-reviewer", "role": "frontend", "phase": "review",
|
|
141
|
+
"brief": "the full expert brief it was launched with",
|
|
142
|
+
"useful": true | false | null,
|
|
143
|
+
"status": null | "saved" | "declined" | "later", "path": null }
|
|
144
|
+
],
|
|
145
|
+
"agent_lessons": [
|
|
146
|
+
{ "agent": "query-reviewer", "signal": "missed" | "produced" | "human",
|
|
147
|
+
"phase": "review", "evidence": "finding or thread, one line, file:line or URL",
|
|
148
|
+
"lesson": "one imperative line, general, no ticket id",
|
|
149
|
+
"status": null | "written" | "declined" | "later" | "not-editable",
|
|
150
|
+
"path": null, "backup": null }
|
|
151
|
+
],
|
|
139
152
|
"origin": { "work": "{PREFIX}XXXXX", "followup": "F1" },
|
|
140
153
|
"started_at": "2026-05-11T10:00:00Z",
|
|
141
154
|
"updated_at": "2026-05-11T11:30:00Z",
|
|
@@ -152,6 +165,8 @@ This system **orchestrates** the project's existing sub-agents and skills (it do
|
|
|
152
165
|
- **`followups`**: work a phase deliberately did **not** do here — a neighbouring defect found while building, a piece put out of scope while planning, a risk recorded but not mitigated, an edge case left unchecked, a prevention action from a postmortem. Written by the phase that parks it (asks nothing) when it clears the bar of flow-core §7, triaged **once** at `ship`'s Close behind a skeptic and a ceiling on how many may become questions, published in the MR/PR description while still open, and surfaced by `status`/`daily`/`next` — including from `_archive/` — until `declined` or `done`. Shape and rules: flow-core §7. `[]` when the work deferred nothing.
|
|
153
166
|
- **`defaults_used`**: an empty `FLOW.md` key a phase resolved with its default instead of asking — written in `guided`/`auto`, where asking would breach the never-a-question contract (flow-core §0). Not an error and not deferred work: a record, aggregated by `$flow-doctor` across every work including `_archive/`, so a key that keeps defaulting can be pinned once instead of decided every time. `[]` when nothing defaulted.
|
|
154
167
|
- **`conventions_candidates`**: rules the user taught **this repo's flow** while correcting a phase — *«not a listener, a message handler»*, *«the test command is `make test-unit`»*. Written by the phase that heard one, asking nothing, only when it would apply to an unrelated ticket in this repo; read by `review`'s idiom audit in the same work; offered once at `ship`'s Close (**Add to FLOW.md** / **Not a rule** / **Later**, or **Replace**), in every mode, because it edits a file in the tree. Never domain knowledge — that filter is unchanged. Shape and rules: flow-core §8. `[]` when the work taught nothing.
|
|
168
|
+
- **`specialists`**: agents a phase **created for this work** because nothing installed fit a role, under `agents.selection: open` (flow-core §6.6) — the brief it wrote and ran on `general-purpose`, and whether anything it returned was kept. Nothing is written to the harness's agent folders while the work runs; `$flow-feat-ship` §5.1 offers the useful ones for saving as real agents once the MR/PR is open and the knowledge is saved, and records where each went.
|
|
169
|
+
- **`agent_lessons`**: what an agent was shown to lack **by evidence from outside it** — a surviving finding in its category that it did not report, a finding in code it wrote, a human review thread in its category that ended in a change (flow-core §6.7). Written by `review` and `respond` asking nothing; offered for the agent's file by `$flow-feat-ship` §5.2 and at `respond`'s close, with a backup under `agent-backups/`, never on plugin-installed agents or skills.
|
|
155
170
|
- **`origin`**: set when this work *is* a follow-up someone accepted — which work raised it and which entry. Lets `start` carry the recorded "why" into `01-context.md` instead of re-deriving it, and lets that entry move to `done` when this work does. Absent for a work that came straight from a ticket.
|
|
156
171
|
- Ticket format follows `tracker.prefix`; empty → free-form.
|
|
157
172
|
|
|
@@ -165,12 +165,13 @@ After the push (or immediately, for reply-only threads), post the agreed respons
|
|
|
165
165
|
## 8. Log, loop, and domain knowledge
|
|
166
166
|
|
|
167
167
|
- **Artifact.** Append this round to `.claude/work/<TICKET>/08-feedback.md` (create it the first round). Per round: the date, and per thread — location, category, decision (reply-only / code-change / defer / held / handled-by-user), the reply posted, and the commit/edit if any. **For a `G` thread, the measurement table goes in whole** — variants, plans, timings, keys served, how the data set was built — plus what stayed unresolved. A later round reads it to avoid re-litigating settled threads.
|
|
168
|
+
- **What the panel missed.** Each thread this round that ended in a code change and falls in a category a `quality.reviewers` member or a named `agents.<role>` owns → one `meta.json.agent_lessons[]` row, `signal: "human"` (flow-core §6.7), when the lesson passes that section's test. A human had to catch what the agent is there to catch; that is the strongest evidence this flow ever gets that an agent needs a line.
|
|
168
169
|
- **Knowledge.** `knowledge.stage` is set and the debate produced a non-obvious "why" worth keeping (a reviewer-surfaced constraint, an integration gotcha, a decision that reversed the design) → `knowledge.stage` for this branch (silence by default; only on a clear signal). Consolidated at `knowledge.save` time.
|
|
169
170
|
- **Count the round in the artifact, not in your head.** Increment `respond_rounds` for this MR/PR in `meta.json` (its `mrs[]` entry; work-level when there are no `mrs`) in the same write that appends the round to `08-feedback.md` — the §1 ceiling is worth exactly as much as this counter. Lightweight mode: nothing to write, no ceiling to enforce; say so once and carry on.
|
|
170
171
|
- **Re-post the performance comment when this round changed a measured path.** A push that touches a query or an entry point already benchmarked (`$flow-feat-ship` §4.3) makes the standing comment wrong — and a wrong number is worse than none. Re-run those rows against the same base and post a new comment; never edit the old one. Nothing measured changed → post nothing.
|
|
171
172
|
- Overwrite `00-summary.md` whole (≤15 lines, flow-core §5). Not in lightweight mode.
|
|
172
173
|
- **A repeated answer spends the budget and buys nothing.** A reply this round that says what an earlier round said — same position, same reasoning, no new evidence → stop **now**, before the ceiling, and escalate that thread by name: your position, the reviewer's counter, the fact that neither has moved.
|
|
173
|
-
- **Loop / close.** Threads open awaiting the reviewer → tell the user the ball is in their court; a later `$flow-work-respond` picks up the next round. All threads answered and code pushed → summarize: threads addressed, code changes made, threads **ready for the user to resolve**, follow-up tickets proposed. Once approved and merged, the normal `$flow-feat-ship §6` / `$flow-bug-ship` close applies (and `$flow-work-watch` for the post-deploy).
|
|
174
|
+
- **Loop / close.** Threads open awaiting the reviewer → tell the user the ball is in their court; a later `$flow-work-respond` picks up the next round. All threads answered and code pushed → **offer the agent lessons first** — `$flow-feat-ship §5.2`, in full and unchanged, over the rows still pending (this round's and any earlier ship left as `later`) — then summarize: threads addressed, code changes made, threads **ready for the user to resolve**, follow-up tickets proposed. Once approved and merged, the normal `$flow-feat-ship §6` / `$flow-bug-ship` close applies (and `$flow-work-watch` for the post-deploy).
|
|
174
175
|
|
|
175
176
|
## Notes
|
|
176
177
|
|
package/adapters/gemini/CORE.md
CHANGED
|
@@ -16,7 +16,7 @@ Every `/flow:*` command assumes these rules. They are stated once, here, so a co
|
|
|
16
16
|
carries what is specific to its phase. Read this once per session; a command that says "load
|
|
17
17
|
`flow-core`" means this file.
|
|
18
18
|
|
|
19
|
-
**This file belongs to flow `0.
|
|
19
|
+
**This file belongs to flow `0.79.0`.** Compare it once, at the start of the session, against
|
|
20
20
|
`version` in `~/.claude/flow/.claude-plugin/plugin.json`. The two differing means the session
|
|
21
21
|
is running a **mixture** — the commands from one copy of the plugin, these shared rules from another
|
|
22
22
|
— which is exactly what happens when a branch or a release candidate is loaded over an installed
|
|
@@ -97,8 +97,7 @@ a command relies on is simply absent in that session, and nothing else will repo
|
|
|
97
97
|
"general-purpose", "phase": "review" }`. Asking here would break the never-a-question contract
|
|
98
98
|
(§2); recording keeps the decision readable afterwards, and `/flow:doctor` aggregates it.
|
|
99
99
|
|
|
100
|
-
**The list, and it is short on purpose**: `
|
|
101
|
-
role on an M/L or sensitive diff · `quality.review_depth` after a review's cost line went over
|
|
100
|
+
**The list, and it is short on purpose**: `quality.review_depth` after a review's cost line went over
|
|
102
101
|
`agents.budget_max` · `data.volumes` or `data.explain_cmd` when the query duel came back
|
|
103
102
|
schema-only · `quality.functional_check` when `validate` found a runnable app and no way to drive
|
|
104
103
|
it · `tracker.start_cmd`/`done_cmd`/`abandon_cmd` the first time a ticket could have been
|
|
@@ -156,8 +155,8 @@ improvises, `models.workers` for the parallel fan-out rounds, and `models.superv
|
|
|
156
155
|
bounded waits of §6.5 — the last two falling back to `models.agents`. Empty, absent, or no section
|
|
157
156
|
→ everything runs on the model you were launched with, and you say nothing.
|
|
158
157
|
|
|
159
|
-
- Pass the resolved value to every subagent you launch, **except** an agent named in `agents.<role
|
|
160
|
-
which keeps the model its own definition sets.
|
|
158
|
+
- Pass the resolved value to every subagent you launch, **except** an agent named in `agents.<role>`
|
|
159
|
+
or picked from the installed ones (§6.6), which keeps the model its own definition sets.
|
|
161
160
|
- **You cannot switch your own model**, so no key names the phases the main agent performs itself.
|
|
162
161
|
A phase that wants another model says it in one line at the handoff (`this step reads better on
|
|
163
162
|
<value>, you are on <current>` → `/model <value>`), records it in the artifact, and continues.
|
|
@@ -555,6 +554,124 @@ moving.
|
|
|
555
554
|
than to run — the brief, the round trip and the report are the whole of the saving. And anything you
|
|
556
555
|
must *react to* mid-wait is not a wait at all: it is the work, and it stays here.
|
|
557
556
|
|
|
557
|
+
### 6.6 — Which agent a role resolves to
|
|
558
|
+
|
|
559
|
+
**The harness already tells you which agents are installed**, each with a line on what it is for,
|
|
560
|
+
and choosing the one that fits a piece of work is something you do well without being told. A rule
|
|
561
|
+
that answers every empty role with `general-purpose` throws that away: a repo with a frontend
|
|
562
|
+
specialist installed and no `agents.frontend` got a generalist told to act like one. So wherever a
|
|
563
|
+
command says *"`agents.<role>`, empty → `Agent general-purpose` with the role"*, it means this:
|
|
564
|
+
|
|
565
|
+
1. **`agents.<role>` names an agent** → that agent, as always.
|
|
566
|
+
2. **Empty** → the installed agent whose description fits the role **and this work's stack** best —
|
|
567
|
+
read the list your harness gives you, never a guess at a name. None fits clearly →
|
|
568
|
+
`general-purpose` with the role in the prompt, as before. An agent that fits the role but not the
|
|
569
|
+
stack (a PHP reviewer on a React diff) does not fit.
|
|
570
|
+
|
|
571
|
+
**`agents.selection`** decides how far your judgement reaches:
|
|
572
|
+
|
|
573
|
+
- **`configured`** (empty → this) — the two steps above. A role you named is never second-guessed.
|
|
574
|
+
- **`open`** — a named role is a default, not an order: for a piece clearly outside what it
|
|
575
|
+
covers, or where an installed agent fits this piece plainly better, take that one. And a piece
|
|
576
|
+
**no role covers** — a UI component in a work whose roles are all backend — may go to the
|
|
577
|
+
specialist that does cover it. Every substitution is **one line in the phase artifact**: role,
|
|
578
|
+
the agent configured, the agent used, and why. Unrecorded, a panel that ran with other agents
|
|
579
|
+
reads exactly like the one you configured.
|
|
580
|
+
|
|
581
|
+
**Nothing installed fits → create the specialist for this work.** An installed agent is, in the
|
|
582
|
+
end, a brief with a name; what made it good is the brief. So instead of *"act as frontend"*, write
|
|
583
|
+
the one an expert would carry — the stack and its versions as this repo uses them, what to check
|
|
584
|
+
in this piece, the mistakes typical of it, and the report contract of this section — and launch
|
|
585
|
+
`general-purpose` with it. Nothing is written to the harness's agent folders: the specialist lives
|
|
586
|
+
for the brief, and it works on every harness, because every one has a general-purpose agent.
|
|
587
|
+
Record it in `meta.json.specialists[]`:
|
|
588
|
+
|
|
589
|
+
`{ "name": "react-form-reviewer", "role": "frontend", "phase": "review", "brief": "<the full text
|
|
590
|
+
you sent>", "useful": null, "status": null }`
|
|
591
|
+
|
|
592
|
+
Once its result is in, set `useful`: `true` when something it returned was kept — a finding
|
|
593
|
+
accepted, a piece merged into the diff — `false` otherwise. Only a useful one is ever offered for
|
|
594
|
+
saving, and only **when the work ends** (`/flow:feat:ship` §5.1), never mid-phase: by then the
|
|
595
|
+
MR/PR is open and it is plain which of them earned a place among your agents.
|
|
596
|
+
|
|
597
|
+
Three things this never touches, in either mode:
|
|
598
|
+
|
|
599
|
+
- **The review roster** (`quality.review_skill` / `quality.reviewers`) runs as defined, with no
|
|
600
|
+
substitutions: its value is being the same panel every time, so a result can be compared.
|
|
601
|
+
- **The agents that are `general-purpose` by design** — challengers, skeptics, the completeness
|
|
602
|
+
critic, the blinded contract check. They are generalists *on purpose*: a specialist brings the
|
|
603
|
+
assumptions the blinding is there to strip. A step that writes `general-purpose` with no role
|
|
604
|
+
behind it means exactly that.
|
|
605
|
+
- **The budget.** A picked agent counts against `agents.budget_max` like any other. Like a named
|
|
606
|
+
agent it keeps its own model (§1), and `models.agents` reaches it only when it has none.
|
|
607
|
+
|
|
608
|
+
Record what you picked where a default would be recorded (§0): *"`agents.frontend` empty → used
|
|
609
|
+
`react-expert` (installed)"*. That line is also the evidence for writing the role down when the
|
|
610
|
+
next stop offers it.
|
|
611
|
+
|
|
612
|
+
### 6.7 — An agent that missed something learns it, once
|
|
613
|
+
|
|
614
|
+
A reviewer that let a defect through will let the same one through next time: nothing it is given
|
|
615
|
+
changes between works. The fix is to its definition, and the evidence that it needs one arrives
|
|
616
|
+
here, in the flow, where somebody else caught what it did not. So a phase that holds that evidence
|
|
617
|
+
records it, and the work's close offers to write it into the agent.
|
|
618
|
+
|
|
619
|
+
**Only evidence from outside the agent counts.** An agent judging its own performance almost
|
|
620
|
+
always finds it good, and a lesson learned from that is a transient failure written down as a
|
|
621
|
+
permanent rule. Three signals, and nothing else:
|
|
622
|
+
|
|
623
|
+
- **Missed** — a finding that survived (§6 verification, or the user's acceptance) falls squarely in
|
|
624
|
+
the category a panel member or a named `agents.<role>` owns, and **that agent did not report it**
|
|
625
|
+
while another source did: the built-in review, another pass, a reinforcement, a human.
|
|
626
|
+
- **Produced** — a surviving finding sits in code a delegated agent wrote (a `build` piece, the
|
|
627
|
+
testing agent's suite): the lesson goes to the agent that wrote it.
|
|
628
|
+
- **Human caught** — a reviewer's thread in `/flow:work:respond` that ended in a code change, in a
|
|
629
|
+
category a panel member owns: the whole panel missed it, and the owner is the one to learn.
|
|
630
|
+
|
|
631
|
+
**The same test as a convention (§8), aimed at the agent.** Would this lesson help that agent on an
|
|
632
|
+
unrelated work in its domain? No → it belongs to this ticket, record nothing. Yes, but it is a fact
|
|
633
|
+
about the **repo** rather than the agent's craft (*"the test command is `make test-unit`"*) → it is a
|
|
634
|
+
`conventions_candidates[]` row, not a lesson. Yes, and it is about the craft (*"check that every
|
|
635
|
+
state change inside a loop is flushed once, not per iteration"*) → a lesson.
|
|
636
|
+
|
|
637
|
+
Record it in `meta.json.agent_lessons[]`, asking nothing:
|
|
638
|
+
|
|
639
|
+
`{ "agent": "query-reviewer", "signal": "missed" | "produced" | "human", "phase":
|
|
640
|
+
"review", "evidence": "<finding or thread, one line, with file:line or URL>", "lesson": "<one
|
|
641
|
+
imperative line, general, no ticket id>", "status": null }`
|
|
642
|
+
|
|
643
|
+
**What is never edited**, and the lesson stays recorded in `meta.json` for you to read:
|
|
644
|
+
|
|
645
|
+
- an agent installed from a plugin or a marketplace — it is someone else's file, and the next
|
|
646
|
+
update would overwrite the edit anyway;
|
|
647
|
+
- a skill (`quality.review_skill`) — it orchestrates agents rather than being one;
|
|
648
|
+
- `general-purpose` and the improvised specialists of §6.6 that were not saved — no file to edit.
|
|
649
|
+
|
|
650
|
+
**Writing it — only at the work's close** (`/flow:feat:ship` §5.2, `/flow:work:respond` §8), with
|
|
651
|
+
`agents.learn` (empty → `offer`; `off` → nothing is recorded or offered):
|
|
652
|
+
|
|
653
|
+
- **Your agents** (written by hand, or shared through the repo) → shown as a diff and written only
|
|
654
|
+
on an explicit yes, **in every mode**: it is your configuration, and in the repo it is your team's.
|
|
655
|
+
- **Agents flow created** (§6.6 saved with `created_by: flow` in their frontmatter) → the same
|
|
656
|
+
question in `manual`; in `guided`/`auto` written directly and reported in one line.
|
|
657
|
+
|
|
658
|
+
**How it is kept small** — without this, the file grows one line per incident until the rules
|
|
659
|
+
nobody reads crowd out the ones that matter:
|
|
660
|
+
|
|
661
|
+
1. Lessons live in one section at the end of the file, `## Lessons from past work`, one line each.
|
|
662
|
+
The rest of the file is never rewritten.
|
|
663
|
+
2. **Already there, in any wording → the lesson is not added.** The agent had the rule and missed
|
|
664
|
+
anyway, which says the rule is weak, not absent: offer instead to move it out of the lessons
|
|
665
|
+
into the body of the brief, rewritten as a check the agent must perform.
|
|
666
|
+
3. **At `agents.lessons_max` lines (empty → 10), adding one means consolidating first**: merge
|
|
667
|
+
lines that say the same thing, generalise two narrow ones into the rule they share, drop one a
|
|
668
|
+
later lesson supersedes. Show the section before and after in the same question.
|
|
669
|
+
4. **Before any edit, copy the file** to `.claude/work/<work>/agent-backups/<name>.md` and record
|
|
670
|
+
the path in the lesson's entry. Undoing is copying it back. A file is never deleted.
|
|
671
|
+
|
|
672
|
+
Then `status`: `"written"` (with the path) · `"declined"` (never offered again) · `"later"` ·
|
|
673
|
+
`"not-editable"` (one of the three cases above, with which).
|
|
674
|
+
|
|
558
675
|
## 7. Deferred work — `followups[]`
|
|
559
676
|
|
|
560
677
|
Every chain in this plugin reaches moments where the right call is **not to do it here**: a build
|
|
@@ -230,6 +230,7 @@ Cost line: count every subagent this command launched — reviewers = §2.1 buil
|
|
|
230
230
|
- Without blockers: `phase = "review"`, add to `phases_done`. Suggest `/flow:bug:postmortem` (M/L) or `/flow:bug:ship` (XS/S).
|
|
231
231
|
- **Record *what* you reviewed, and separately what you changed after reading it** — `/flow:feat:review` §9, unchanged: `reviewed_sha` = the **candidate** of §1.5 (the revision the reviewers read, never `git rev-parse HEAD`, which by now holds this round's own fixes), and `fixed_sha` = `git rev-parse HEAD` after those fixes, empty when the round applied none. `phases_done` says a review happened; these two say on which tree and what moved afterwards, and `/flow:bug:ship §0` reads both against what is being pushed. Only when the phase advances: a review that ended in blockers reviewed nothing that stands.
|
|
232
232
|
- **Record which pass found what** — `/flow:feat:review §9`, unchanged: one `meta.json.review_findings[]` entry per finding **per source** (`{ round, origin, severity, file, discarded_by_skeptic }`, no finding text), written by `flow review --record` when the CLI ran the panel and by this Close when the agentic panel did. `flow cost` reads them back per origin, and the retirement rule is the same: a pass with no exclusive surviving finding across twenty reviews comes out of the command.
|
|
233
|
+
- **Record what the agents missed** — `/flow:feat:review §9`, unchanged: surviving findings in a category a panel member or named `agents.<role>` owns and did not report → `meta.json.agent_lessons[]` rows (flow-core §6.7), asking nothing. A fix is where this pays most: the defect already reached production once, and the reviewer that owns its category let it.
|
|
233
234
|
- **Stage what the review taught** (`knowledge.stage` set; silence by default). Review is where a project teaches the most and, until now, the one phase that never staged — a work with three review rounds and seventeen blockers produced zero knowledge cards because nothing asked for them while they were in context. Candidates are findings about the **domain or the codebase's real behaviour**, not about this diff: a library that does other than its name says, a test disguise that kept the suite green over a live defect, a module rule the reviewers had to cite from its own prose, a measurement. A blocker fixed here is not knowledge; *why it was written wrong* may be. Same evidence rule as `/flow:feat:design` §8 — one line of evidence per finding or it is not staged. One call per finding, one line to the user («Staged N finding(s) for `postmortem`/`ship`»). Never `knowledge.save` here.
|
|
234
235
|
- Overwrite `00-summary.md` whole (≤15 lines, flow-core §5).
|
|
235
236
|
- Stop body (after the flow-core §3 header): the findings that survived and what you did with each, plus the same Cost line as the Summary: "- Cost: <n>/<budget_max> subagents launched (<k> reviewers · <m> reinforcements · <s> skeptics), tier <light|proportional|full>".
|
|
@@ -182,6 +182,8 @@ nothing was measured. A slowness bug is the case where this comment *is* the pro
|
|
|
182
182
|
- **Cross-repo reminder**: for each `meta.json.related_repos` entry not `done`: *"you've shipped the `<this-repo>` part; `<repo>` still needs: `<scope>` → go there and run `/flow:bug:start <TICKET>` (or `/flow:feat:start`)"*. flow only reminds; this is not a hard gate.
|
|
183
183
|
- **Cross-repo contract handoff**: for each such entry with `contract_handoff: "pending"` — the fix changed a surface that sibling consumes — hand the new shape over as `/flow:feat:ship` §6.3 (publish the **literal** shape to the tracker ticket, mandatory preview in every autonomy mode, then record `published → <location>`; versioned-file fallback when there is no tracker). A bug flow has no §"External contracts": take the literal from the fix itself — the actual key, code, route or event the code now emits — read it off the code, never from memory.
|
|
184
184
|
- **Follow-up triage — `/flow:feat:ship` §6.4, in full and unchanged.** Read `meta.json.followups[]`; nothing `proposed` → skip silently. Otherwise §6.4 step 0 first — **3 or more candidates go to a skeptic** whose job is to refute that each deserves a ticket, and only the strongest `tracker.followup_ask_max` (empty → **2**) reach the user (flow-core §7) — then one batched `AskUserQuestion` (**Do it** / **Not worth it** / **Later**; `decision` entries asked as their question, `tooling` and everything `log`ged never asked), the accepted ones get their tracker issue created (outward-facing → **asks in every mode**), the logged ones nothing but `status: "logged"` in `meta.json`, then one offer to start the first. A bug flow is where the gate earns its keep: the prevention actions `/flow:bug:postmortem` wrote, the neighbouring bugs `/flow:bug:validate` found and the similar-risk patterns `/flow:bug:fix` flagged all land here — half a dozen of them, from one fix, and «similar risk elsewhere» that no skeptic ever read is exactly the entry that turns a closed bug into six open questions. Repeat for anything still `proposed` on the re-run that confirms the merge.
|
|
185
|
+
- **Specialists created — `/flow:feat:ship` §5.1, in full and unchanged.** Read `meta.json.specialists[]` (flow-core §6.6); nothing `useful` and pending → skip silently. Otherwise one batched offer to save each as an agent, after the MR/PR and after the knowledge `/flow:bug:postmortem` §4 already consolidated — asked in every mode, never overwriting an agent that exists.
|
|
186
|
+
- **What the agents missed — `/flow:feat:ship` §5.2, in full and unchanged.** Read `meta.json.agent_lessons[]` (flow-core §6.7); `agents.learn: off` or nothing pending → skip silently. Otherwise one question per agent with the resulting lessons section, backup first, your agents asked in every mode.
|
|
185
187
|
- **Conventions learned — `/flow:feat:ship` §6.4bis, in full and unchanged.** Read `meta.json.conventions_candidates[]` (flow-core §8); nothing pending → skip silently. Otherwise: drop what `FLOW.md` already says, then one batched `AskUserQuestion` (**Add to FLOW.md** / **Not a rule** / **Later**, or **Replace** when it contradicts a line that is there). Asked in every mode — it edits a file in the tree. A fix is where the corrections land hardest: *«never mock the repository in that layer»*, *«the regression test goes next to the unit test, not in the functional suite»* — said once inside `bug:fix`, and proposed again in the next incident unless they reach the file.
|
|
186
188
|
- **Close the follow-up that started this work.** `meta.json.origin` set and this ship moved `phase` to `done` → open the originating work's `meta.json` (live folder or `_archive/`) and set that `followups[]` entry to `status: "done"`. Best-effort: the originating folder is gone or unreadable → warn in one line and continue, never block. Without this the entry stays `in_progress` forever and `status`/`daily` keep reporting work that is finished.
|
|
187
189
|
- **Only once `phase` is `done`**: delete the candidate anchor `/flow:bug:review §1.5` left behind — `git update-ref -d refs/flow/candidate/<TICKET>`. No question: local, never pushed, and the gate that needed it has run.
|
|
@@ -192,8 +192,8 @@ refuse) · **degraded** (it runs, quietly worse than the config promises), plus
|
|
|
192
192
|
|
|
193
193
|
- Every **role** set in `agents.*` (not `fanout_max` / `fanout_tool` — not agents), plus
|
|
194
194
|
`quality.reviewers` and `quality.review_skill`: discoverable in `~/.claude/agents`, the repo's
|
|
195
|
-
`.agents/agents`, or a plugin. Report each missing name and that it falls back
|
|
196
|
-
(a skill: skipped) — a panel missing agents reviews less and still reports a clean pass.
|
|
195
|
+
`.agents/agents`, or a plugin. Report each missing name and that it falls back per flow-core §6.6 — the installed agent
|
|
196
|
+
that fits, else `general-purpose` (a skill: skipped) — a panel missing agents reviews less and still reports a clean pass.
|
|
197
197
|
- Harness cannot set a model per subagent → note that every `models.*` value degrades to inheritance.
|
|
198
198
|
- **Where the live panel will go this session** (flow-core §4): a tool whose name ends in `panel_set` / `panel_patch` — namespaced by the harness (`mcp__panel__panel_set` on Claude Code) and possibly **deferred**, which reads as absent until the list of deferred tools is checked → the terminal draws the panel and no `panel.json` is written; genuinely absent → the panel is that file, as before. Neither is a fault — one line naming the tools as they are actually called here, or saying the file is the transport.
|
|
199
199
|
|
|
@@ -135,8 +135,8 @@ Take the shape from the **Access paths** table in `03-design.md`; a query matchi
|
|
|
135
135
|
|
|
136
136
|
Execution mode:
|
|
137
137
|
|
|
138
|
-
- **Single-thread (XS/S/M)**: implement yourself, step by step
|
|
139
|
-
- **Partial delegation (M/L with clear pieces)**: `Agent` for isolated endpoints, plus `agents.testing` from `FLOW.md` in parallel to prepare the test suite (
|
|
138
|
+
- **Single-thread (XS/S/M)**: implement yourself, step by step. Delegate a piece when a specialist would do it clearly better than you — a UI component to a frontend agent in a mostly backend work, a migration to a persistence agent — not because it is tedious; consult one when blocked — `agents.architecture` from `FLOW.md` for layer questions, `agents.persistence` for query/mapping questions. Which agent each role resolves to, and whether you may pick past a named one, is flow-core §6.6. A delegated piece follows the brief rules of the next bullet and the one-writer rule of flow-core §6.
|
|
139
|
+
- **Partial delegation (M/L with clear pieces)**: `Agent` for isolated endpoints, plus `agents.testing` from `FLOW.md` in parallel to prepare the test suite (empty → flow-core §6.6). Pass the full `03-design.md` in the prompt so agents do not invent things.
|
|
140
140
|
|
|
141
141
|
A brief here states the **output** as explicitly as the input (flow-core §6):
|
|
142
142
|
- **Name the path the agent writes**, and require it to **save after each finished piece, not at the end**. Code, tests and generated content are the deliverable; the report is not. Then **verify the file** instead of believing the report — a piece half-written on disk is recoverable, what only exists in the agent's context is lost the moment it is stopped.
|
|
@@ -171,7 +171,7 @@ Save the result at the top of `03-design.md` under "## What already exists". Des
|
|
|
171
171
|
## 4. Work
|
|
172
172
|
|
|
173
173
|
1. Load the project's skills (`FLOW.md` section `conventions`).
|
|
174
|
-
2. Launch **in parallel** by feature/project type. Agent = `agents.<role>` from `FLOW.md`; empty → `Agent general-purpose` with the role in the prompt.
|
|
174
|
+
2. Launch **in parallel** by feature/project type. Agent = `agents.<role>` from `FLOW.md`; empty → the installed agent that fits, else `Agent general-purpose` with the role in the prompt (flow-core §6.6).
|
|
175
175
|
|
|
176
176
|
| When | Agent | Task |
|
|
177
177
|
|---|---|---|
|
|
@@ -382,7 +382,8 @@ Write `.claude/work/<TICKET>/06-review.md`. The `Cost:` line of `## Summary` is
|
|
|
382
382
|
**The retirement rule, written down before the data arrives** so it cannot be argued backwards later: a pass that contributes **no exclusive surviving finding across twenty reviews** is removed from this command. Zero is zero, and the decision is made against the number rather than against whoever is most attached to the pass.
|
|
383
383
|
- **Stage what the review taught** (`knowledge.stage` set; silence by default). Review is where a project teaches the most and, until now, the one phase that never staged — a work with three review rounds and seventeen blockers produced zero knowledge cards because nothing asked for them while they were in context. Candidates are findings about the **domain or the codebase's real behaviour**, not about this diff: a library that does other than its name says, a test disguise that kept the suite green over a live defect, a module rule the reviewers had to cite from its own prose, a measurement. A blocker fixed here is not knowledge; *why it was written wrong* may be. Same evidence rule as `/flow:feat:design` §8 — one line of evidence per finding or it is not staged. One call per finding, one line to the user («Staged N finding(s) for `ship`»). Never `knowledge.save` here.
|
|
384
384
|
- Overwrite `00-summary.md` whole (≤15 lines, flow-core §5).
|
|
385
|
-
- **
|
|
385
|
+
- **Record what the agents missed** (flow-core §6.7, `agents.learn` not `off`; asking nothing): for each finding that survived, the panel member or named `agents.<role>` whose category it falls in and who did not report it, and the delegated `build` agent whose code it sits in → one `meta.json.agent_lessons[]` row each, only when the lesson passes the §6.7 test. The origins §2.1 carried are what make this possible — a finding with no origin teaches nobody.
|
|
386
|
+
- **Configuration this phase earned the right to ask about** (flow-core §0, `manual` only, at most one key per work, as an extra option on this same stop — never a question of its own): a `Cost:` line that went over `agents.budget_max` → `quality.review_depth`. In `guided`/`auto` neither is asked: the default is taken and recorded in `meta.json.defaults_used[]`.
|
|
386
387
|
- Report findings and next step **following the stop header** (flow-core §3) **when this is a stop**; in `guided`/`auto` with a clean gate the next command runs in this same turn, so this goes to `06-review.md` and the turn opens with the call that chains — the `Cost:` line then travels to the stop the run does reach, added to that phase's own. Include it once. Body: the findings that **survived** verification and what you did with each — a blocker, an applied fix, a rejection with its reason. Corrections to the reviewers' own reports go to `06-review.md`, not here.
|
|
387
388
|
- **Autonomy handoff.** Only when there are **no blockers and no unresolved high-severity findings** — with any of those, stop in every mode (hard gate). Clean: in `manual`, propose `/flow:feat:validate` with a single `AskUserQuestion` and invoke it on confirmation; in `guided`/`auto`, **chain into `/flow:feat:validate` automatically** in this same turn. Never chain into `/flow:feat:ship` from here — ship is reached through `validate`.
|
|
388
389
|
"""
|