flow-api-translator 0.33.3 → 0.35.0

package/dist/TSDefToFlowDef.js

@@ -525,7 +525,7 @@ const getTransforms = (originalCode, opts) => {
         }),
         importKind: // `import type React from 'react'` in TS means `import typeof React from react` in Flow
         specifiers.some(s => s.type === 'ImportDefaultSpecifier') && node.importKind === 'type' ? 'typeof' : node.importKind,
-        assertions: [],
+        attributes: [],
         specifiers
       });
     }

package/dist/TSDefToFlowDef.js.flow

@@ -606,7 +606,7 @@ const getTransforms = (originalCode: string, opts: TranslationOptions) => {
           node.importKind === 'type'
             ? 'typeof'
             : node.importKind,
-        assertions: [],
+        attributes: [],
         specifiers,
       });
     }

package/dist/flowDefToTSDef.js

@@ -734,6 +734,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
     }
   };
 
+  const wellKnownSymbols = new Set(['iterator', 'asyncIterator', 'dispose', 'asyncDispose']);
   const transform = {
     AnyTypeAnnotation(_node) {
       return {
@@ -899,7 +900,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
                   if (_key.type === 'Identifier' && _key.name.startsWith('@@')) {
                     const name = _key.name.slice(2);
 
-                    if (['iterator', 'asyncIterator'].includes(name)) {
+                    if (wellKnownSymbols.has(name)) {
                       return [{
                         type: 'MemberExpression',
                         computed: false,
@@ -1267,7 +1268,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
             return {
               type: 'ExportNamedDeclaration',
               loc: DUMMY_LOC,
-              // flow does not currently support assertions
+              // flow does not currently support attributes
               assertions: [],
               declaration: null,
               // flow does not support declared type exports with specifiers
@@ -1350,7 +1351,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
                 return [{
                   type: 'ExportNamedDeclaration',
                   loc: DUMMY_LOC,
-                  // flow does not currently support assertions
+                  // flow does not currently support attributes
                   assertions: [],
                   declaration,
                   exportKind,
@@ -1385,7 +1386,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
                   loc: DUMMY_LOC,
                   specifiers: [],
                   exportKind: 'type',
-                  // flow does not currently support assertions
+                  // flow does not currently support attributes
                   assertions: []
                 }];
               }
@@ -1394,7 +1395,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
             const exportNamedDeclaration = {
               type: 'ExportNamedDeclaration',
               loc: DUMMY_LOC,
-              // flow does not currently support assertions
+              // flow does not currently support attributes
               assertions: [],
               declaration,
               exportKind,
@@ -1408,7 +1409,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
           return {
             type: 'ExportNamedDeclaration',
             loc: DUMMY_LOC,
-            // flow does not currently support assertions
+            // flow does not currently support attributes
             assertions: [],
             declaration: null,
             // flow does not support declared type exports with a source
@@ -1718,7 +1719,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
       return {
         type: 'ExportAllDeclaration',
         loc: DUMMY_LOC,
-        // flow does not currently support import/export assertions
+        // flow does not currently support import/export attributes
         assertions: [],
         exportKind: node.exportKind,
         source: transform.StringLiteral(node.source),
@@ -1732,7 +1733,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
         return {
           type: 'ExportNamedDeclaration',
           loc: DUMMY_LOC,
-          // flow does not currently support import/export assertions
+          // flow does not currently support import/export attributes
           assertions: [],
           declaration: null,
           exportKind: node.exportKind,
@@ -2981,7 +2982,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
       const out = specifiers.length ? [{
         type: 'ImportDeclaration',
         loc: DUMMY_LOC,
-        assertions: node.assertions.map(transform.ImportAttribute),
+        assertions: node.attributes.map(transform.ImportAttribute),
         importKind: importKind === 'typeof' ? 'type' : importKind != null ? importKind : 'value',
         source: transform.StringLiteral(node.source),
         specifiers
@@ -3119,7 +3120,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
 
     ObjectTypeAnnotation(node) {
       if (node.properties.length === 1 && node.properties[0].type === 'ObjectTypeMappedTypeProperty') {
-        var _prop$variance;
+        var _prop$variance, _prop$variance2;
 
         // Mapped Object Object types must not have other object properties.
         const prop = node.properties[0];
@@ -3144,7 +3145,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
             name: prop.keyTparam.name
           },
           constraint: transformTypeAnnotationType(prop.sourceType),
-          readonly: ((_prop$variance = prop.variance) == null ? void 0 : _prop$variance.kind) === 'plus',
+          readonly: ((_prop$variance = prop.variance) == null ? void 0 : _prop$variance.kind) === 'plus' || ((_prop$variance2 = prop.variance) == null ? void 0 : _prop$variance2.kind) === 'readonly',
           optional: prop.optional === 'Optional',
           typeAnnotation: transformTypeAnnotationType(prop.propType),
           nameType: null
@@ -3365,10 +3366,10 @@ const getTransforms = (originalCode, scopeManager, opts) => {
     },
 
     ObjectTypeIndexer(node) {
-      var _node$variance2;
+      var _node$variance3, _node$variance4;
 
       if (node.key.type === 'GenericTypeAnnotation') {
-        var _node$variance;
+        var _node$variance, _node$variance2;
 
         const ident = node.key.id.type === 'Identifier' ? node.key.id : node.key.id.id;
         return {
@@ -3390,7 +3391,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
               loc: DUMMY_LOC
             }
           },
-          readonly: ((_node$variance = node.variance) == null ? void 0 : _node$variance.kind) === 'plus',
+          readonly: ((_node$variance = node.variance) == null ? void 0 : _node$variance.kind) === 'plus' || ((_node$variance2 = node.variance) == null ? void 0 : _node$variance2.kind) === 'readonly',
           static: node.static,
           typeAnnotation: {
             type: 'TSTypeAnnotation',
@@ -3413,7 +3414,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
             typeAnnotation: transformTypeAnnotationType(node.key)
           }
         }],
-        readonly: ((_node$variance2 = node.variance) == null ? void 0 : _node$variance2.kind) === 'plus',
+        readonly: ((_node$variance3 = node.variance) == null ? void 0 : _node$variance3.kind) === 'plus' || ((_node$variance4 = node.variance) == null ? void 0 : _node$variance4.kind) === 'readonly',
         static: node.static,
         typeAnnotation: {
           type: 'TSTypeAnnotation',
@@ -3424,22 +3425,52 @@ const getTransforms = (originalCode, scopeManager, opts) => {
     },
 
     ObjectTypeProperty(node) {
-      var _node$variance3;
+      var _node$variance5, _node$variance6;
 
-      const key = node.key.type === 'Identifier' ? transform.Identifier(node.key) : node.key.literalType === 'string' ? transform.StringLiteral(node.key) : null;
+      const [key, computed] = (() => {
+        if (node.key.type === 'Identifier' && node.key.name.startsWith('@@')) {
+          const name = node.key.name.slice(2);
 
-      if (key == null) {
-        throw unexpectedTranslationError(node, 'Unsupported key type');
-      }
+          if (node.method === true && wellKnownSymbols.has(name)) {
+            return [{
+              type: 'MemberExpression',
+              computed: false,
+              object: {
+                type: 'Identifier',
+                name: 'Symbol',
+                optional: false,
+                loc: DUMMY_LOC
+              },
+              optional: false,
+              property: {
+                type: 'Identifier',
+                name,
+                optional: false,
+                loc: DUMMY_LOC
+              },
+              loc: DUMMY_LOC
+            }, true];
+          }
+        }
+
+        const key = node.key.type === 'Identifier' ? transform.Identifier(node.key) : node.key.literalType === 'string' ? transform.StringLiteral(node.key) : null;
+
+        if (key == null) {
+          throw unexpectedTranslationError(node, 'Unsupported key type');
+        }
+
+        return [key, false];
+      })();
 
       if (node.method === true) {
         // flow has just one node for all object properties and relies upon the method flag
         // TS has separate nodes for methods and properties
-        const func = transform.FunctionTypeAnnotation(node.value);
+        const func = transform.FunctionTypeAnnotation(node.value); // $FlowFixMe[incompatible-type] `computed` is set dynamically
+
         return {
           type: 'TSMethodSignature',
           loc: DUMMY_LOC,
-          computed: false,
+          computed,
           key,
           kind: node.kind === 'init' ? 'method' : node.kind,
           optional: node.optional,
@@ -3453,11 +3484,12 @@ const getTransforms = (originalCode, scopeManager, opts) => {
       if (node.kind === 'get' || node.kind === 'set') {
         // flow treats getters/setters as true property signatures (method === false)
         // TS treats them as method signatures
-        const func = transform.FunctionTypeAnnotation(node.value);
+        const func = transform.FunctionTypeAnnotation(node.value); // $FlowFixMe[incompatible-type] `computed` is set dynamically
+
         return {
           type: 'TSMethodSignature',
           loc: DUMMY_LOC,
-          computed: false,
+          computed,
           key,
           kind: node.kind,
           optional: false,
@@ -3468,15 +3500,16 @@ const getTransforms = (originalCode, scopeManager, opts) => {
           // TS accessors cannot have type parameters
           typeParameters: undefined
         };
-      }
+      } // $FlowFixMe[incompatible-type] `computed` is set dynamically
+
 
       return {
         type: 'TSPropertySignature',
         loc: DUMMY_LOC,
-        computed: false,
+        computed,
         key,
         optional: node.optional,
-        readonly: ((_node$variance3 = node.variance) == null ? void 0 : _node$variance3.kind) === 'plus',
+        readonly: ((_node$variance5 = node.variance) == null ? void 0 : _node$variance5.kind) === 'plus' || ((_node$variance6 = node.variance) == null ? void 0 : _node$variance6.kind) === 'readonly',
         static: node.static,
         typeAnnotation: {
           type: 'TSTypeAnnotation',
@@ -3598,7 +3631,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
     },
 
     TupleTypeAnnotation(node) {
-      const allReadOnly = node.elementTypes.length > 0 && node.elementTypes.every(element => element.type === 'TupleTypeLabeledElement' && element.variance != null && element.variance.kind === 'plus');
+      const allReadOnly = node.elementTypes.length > 0 && node.elementTypes.every(element => element.type === 'TupleTypeLabeledElement' && element.variance != null && (element.variance.kind === 'plus' || element.variance.kind === 'readonly'));
       const elems = node.elementTypes.map(element => {
         switch (element.type) {
           case 'TupleTypeLabeledElement':

package/dist/flowDefToTSDef.js.flow

@@ -766,6 +766,13 @@ const getTransforms = (
     }
   };
 
+  const wellKnownSymbols = new Set([
+    'iterator',
+    'asyncIterator',
+    'dispose',
+    'asyncDispose',
+  ]);
+
   const transform = {
     AnyTypeAnnotation(
       _node: FlowESTree.AnyTypeAnnotation,
@@ -944,7 +951,7 @@ const getTransforms = (
                 const _key = member.key;
                 if (_key.type === 'Identifier' && _key.name.startsWith('@@')) {
                   const name = _key.name.slice(2);
-                  if (['iterator', 'asyncIterator'].includes(name)) {
+                  if (wellKnownSymbols.has(name)) {
                     return [
                       {
                         type: 'MemberExpression',
@@ -1373,7 +1380,7 @@ const getTransforms = (
             return ({
               type: 'ExportNamedDeclaration',
               loc: DUMMY_LOC,
-              // flow does not currently support assertions
+              // flow does not currently support attributes
               assertions: [],
               declaration: null,
               // flow does not support declared type exports with specifiers
@@ -1470,7 +1477,7 @@ const getTransforms = (
                   {
                     type: 'ExportNamedDeclaration',
                     loc: DUMMY_LOC,
-                    // flow does not currently support assertions
+                    // flow does not currently support attributes
                     assertions: [],
                     declaration,
                     exportKind,
@@ -1506,7 +1513,7 @@ const getTransforms = (
                     loc: DUMMY_LOC,
                     specifiers: [],
                     exportKind: 'type',
-                    // flow does not currently support assertions
+                    // flow does not currently support attributes
                     assertions: [],
                   },
                 ];
@@ -1517,7 +1524,7 @@ const getTransforms = (
               {
                 type: 'ExportNamedDeclaration',
                 loc: DUMMY_LOC,
-                // flow does not currently support assertions
+                // flow does not currently support attributes
                 assertions: [],
                 declaration,
                 exportKind,
@@ -1532,7 +1539,7 @@ const getTransforms = (
           return ({
             type: 'ExportNamedDeclaration',
             loc: DUMMY_LOC,
-            // flow does not currently support assertions
+            // flow does not currently support attributes
             assertions: [],
             declaration: null,
             // flow does not support declared type exports with a source
@@ -1905,7 +1912,7 @@ const getTransforms = (
       return {
         type: 'ExportAllDeclaration',
         loc: DUMMY_LOC,
-        // flow does not currently support import/export assertions
+        // flow does not currently support import/export attributes
         assertions: [],
         exportKind: node.exportKind,
         source: transform.StringLiteral(node.source),
@@ -1923,7 +1930,7 @@ const getTransforms = (
         return {
           type: 'ExportNamedDeclaration',
           loc: DUMMY_LOC,
-          // flow does not currently support import/export assertions
+          // flow does not currently support import/export attributes
           assertions: [],
           declaration: null,
           exportKind: node.exportKind,
@@ -3227,7 +3234,7 @@ const getTransforms = (
             {
               type: 'ImportDeclaration',
               loc: DUMMY_LOC,
-              assertions: node.assertions.map(transform.ImportAttribute),
+              assertions: node.attributes.map(transform.ImportAttribute),
               importKind:
                 importKind === 'typeof' ? 'type' : (importKind ?? 'value'),
               source: transform.StringLiteral(node.source),
@@ -3415,7 +3422,9 @@ const getTransforms = (
             name: prop.keyTparam.name,
           },
           constraint: transformTypeAnnotationType(prop.sourceType),
-          readonly: prop.variance?.kind === 'plus',
+          readonly:
+            prop.variance?.kind === 'plus' ||
+            prop.variance?.kind === 'readonly',
           optional: prop.optional === 'Optional',
           typeAnnotation: transformTypeAnnotationType(prop.propType),
           nameType: null,
@@ -3692,7 +3701,9 @@ const getTransforms = (
               loc: DUMMY_LOC,
             },
           },
-          readonly: node.variance?.kind === 'plus',
+          readonly:
+            node.variance?.kind === 'plus' ||
+            node.variance?.kind === 'readonly',
           static: node.static,
           typeAnnotation: {
             type: 'TSTypeAnnotation',
@@ -3716,7 +3727,8 @@ const getTransforms = (
             },
           },
         ],
-        readonly: node.variance?.kind === 'plus',
+        readonly:
+          node.variance?.kind === 'plus' || node.variance?.kind === 'readonly',
         static: node.static,
         typeAnnotation: {
           type: 'TSTypeAnnotation',
@@ -3728,25 +3740,57 @@ const getTransforms = (
     ObjectTypeProperty(
       node: FlowESTree.ObjectTypeProperty,
     ): TSESTree.TSPropertySignature | TSESTree.TSMethodSignature {
-      const key =
-        node.key.type === 'Identifier'
-          ? transform.Identifier(node.key)
-          : node.key.literalType === 'string'
-            ? transform.StringLiteral(node.key)
-            : null;
-
-      if (key == null) {
-        throw unexpectedTranslationError(node, 'Unsupported key type');
-      }
+      const [key, computed] = ((): [TSESTree.PropertyName, boolean] => {
+        if (node.key.type === 'Identifier' && node.key.name.startsWith('@@')) {
+          const name = node.key.name.slice(2);
+          if (node.method === true && wellKnownSymbols.has(name)) {
+            return [
+              {
+                type: 'MemberExpression',
+                computed: false,
+                object: {
+                  type: 'Identifier',
+                  name: 'Symbol',
+                  optional: false,
+                  loc: DUMMY_LOC,
+                },
+                optional: false,
+                property: {
+                  type: 'Identifier',
+                  name,
+                  optional: false,
+                  loc: DUMMY_LOC,
+                },
+                loc: DUMMY_LOC,
+              },
+              true,
+            ];
+          }
+        }
+
+        const key =
+          node.key.type === 'Identifier'
+            ? transform.Identifier(node.key)
+            : node.key.literalType === 'string'
+              ? transform.StringLiteral(node.key)
+              : null;
+
+        if (key == null) {
+          throw unexpectedTranslationError(node, 'Unsupported key type');
+        }
+
+        return [key, false];
+      })();
 
       if (node.method === true) {
         // flow has just one node for all object properties and relies upon the method flag
         // TS has separate nodes for methods and properties
         const func = transform.FunctionTypeAnnotation(node.value);
+        // $FlowFixMe[incompatible-type] `computed` is set dynamically
         return {
           type: 'TSMethodSignature',
           loc: DUMMY_LOC,
-          computed: false,
+          computed,
           key,
           kind: node.kind === 'init' ? 'method' : node.kind,
           optional: node.optional,
@@ -3761,10 +3805,11 @@ const getTransforms = (
         // flow treats getters/setters as true property signatures (method === false)
         // TS treats them as method signatures
         const func = transform.FunctionTypeAnnotation(node.value);
+        // $FlowFixMe[incompatible-type] `computed` is set dynamically
         return {
           type: 'TSMethodSignature',
           loc: DUMMY_LOC,
-          computed: false,
+          computed,
           key,
           kind: node.kind,
           optional: false,
@@ -3777,13 +3822,15 @@ const getTransforms = (
         };
       }
 
+      // $FlowFixMe[incompatible-type] `computed` is set dynamically
       return {
         type: 'TSPropertySignature',
         loc: DUMMY_LOC,
-        computed: false,
+        computed,
         key,
         optional: node.optional,
-        readonly: node.variance?.kind === 'plus',
+        readonly:
+          node.variance?.kind === 'plus' || node.variance?.kind === 'readonly',
         static: node.static,
         typeAnnotation: {
           type: 'TSTypeAnnotation',
@@ -3924,7 +3971,8 @@ const getTransforms = (
           element =>
             element.type === 'TupleTypeLabeledElement' &&
             element.variance != null &&
-            element.variance.kind === 'plus',
+            (element.variance.kind === 'plus' ||
+              element.variance.kind === 'readonly'),
         );
       const elems = node.elementTypes.map((element): TSESTree.TypeNode => {
         switch (element.type) {

package/dist/flowToFlowDef.js

@@ -249,7 +249,7 @@ function stripUnusedDefs(detachedStmt, usedDeps, context) {
             specifiers: resultSpecfiers,
             importKind: stmt.importKind,
             source: stmt.source,
-            assertions: stmt.assertions
+            attributes: stmt.attributes
           });
         }
 
@@ -727,15 +727,15 @@ function convertVariableDeclaration(stmt, context) {
 }
 
 function convertImportDeclaration(stmt, context) {
-  if (stmt.assertions.length > 0) {
-    throw (0, _ErrorUtils.translationError)(stmt, 'ImportDeclaration: assertions not supported', context);
+  if (stmt.attributes.length > 0) {
+    throw (0, _ErrorUtils.translationError)(stmt, 'ImportDeclaration: attributes not supported', context);
   }
 
   return [_hermesTransform.t.ImportDeclaration({
     specifiers: stmt.specifiers,
     importKind: stmt.importKind,
     source: stmt.source,
-    assertions: []
+    attributes: []
   }), []];
 }
 
@@ -1147,12 +1147,12 @@ function convertFunctionParameters(params, context) {
 }
 
 function convertBindingNameToFunctionTypeParam(pat, context, index, isAssignment) {
-  const name = pat.type === 'Identifier' ? pat.name : `$$PARAM_${index}$$`;
+  const name = pat.type === 'Identifier' && pat.name != null ? pat.name : `$$PARAM_${index}$$`;
   const [resultParamTypeAnnotation, paramDeps] = convertTypeAnnotation(pat.typeAnnotation, pat, context);
   return [_hermesTransform.t.FunctionTypeParam({
-    name: name != null ? _hermesTransform.t.Identifier({
+    name: _hermesTransform.t.Identifier({
       name
-    }) : null,
+    }),
     typeAnnotation: resultParamTypeAnnotation,
     optional: isAssignment || (pat.type === 'Identifier' ? pat.optional : false)
   }), paramDeps];

package/dist/flowToFlowDef.js.flow

@@ -357,7 +357,7 @@ function stripUnusedDefs(
           specifiers: resultSpecfiers,
           importKind: stmt.importKind,
           source: stmt.source,
-          assertions: stmt.assertions,
+          attributes: stmt.attributes,
         });
       }
       return detachedStmt;
@@ -940,10 +940,10 @@ function convertImportDeclaration(
   stmt: ImportDeclaration,
   context: TranslationContext,
 ): TranslatedResult<ImportDeclaration> {
-  if (stmt.assertions.length > 0) {
+  if (stmt.attributes.length > 0) {
     throw translationError(
       stmt,
-      'ImportDeclaration: assertions not supported',
+      'ImportDeclaration: attributes not supported',
       context,
     );
   }
@@ -953,7 +953,7 @@ function convertImportDeclaration(
       specifiers: stmt.specifiers,
       importKind: stmt.importKind,
       source: stmt.source,
-      assertions: [],
+      attributes: [],
     }),
     [],
   ];
@@ -1623,7 +1623,10 @@ function convertBindingNameToFunctionTypeParam(
   index: number,
   isAssignment: boolean,
 ): TranslatedResult<FunctionTypeParam> {
-  const name = pat.type === 'Identifier' ? pat.name : `$$PARAM_${index}$$`;
+  const name =
+    pat.type === 'Identifier' && pat.name != null
+      ? pat.name
+      : `$$PARAM_${index}$$`;
   const [resultParamTypeAnnotation, paramDeps] = convertTypeAnnotation(
     pat.typeAnnotation,
     pat,
@@ -1631,7 +1634,7 @@ function convertBindingNameToFunctionTypeParam(
   );
   return [
     t.FunctionTypeParam({
-      name: name != null ? t.Identifier({name}) : null,
+      name: t.Identifier({name}),
       typeAnnotation: resultParamTypeAnnotation,
       optional:
         isAssignment || (pat.type === 'Identifier' ? pat.optional : false),

package/dist/src/TSDefToFlowDef.js

@@ -525,7 +525,7 @@ const getTransforms = (originalCode, opts) => {
         }),
         importKind: // `import type React from 'react'` in TS means `import typeof React from react` in Flow
         specifiers.some(s => s.type === 'ImportDefaultSpecifier') && node.importKind === 'type' ? 'typeof' : node.importKind,
-        assertions: [],
+        attributes: [],
         specifiers
       });
     }

package/dist/src/flowDefToTSDef.js

@@ -734,6 +734,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
     }
   };
 
+  const wellKnownSymbols = new Set(['iterator', 'asyncIterator', 'dispose', 'asyncDispose']);
   const transform = {
     AnyTypeAnnotation(_node) {
       return {
@@ -899,7 +900,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
                   if (_key.type === 'Identifier' && _key.name.startsWith('@@')) {
                     const name = _key.name.slice(2);
 
-                    if (['iterator', 'asyncIterator'].includes(name)) {
+                    if (wellKnownSymbols.has(name)) {
                       return [{
                         type: 'MemberExpression',
                         computed: false,
@@ -1267,7 +1268,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
             return {
               type: 'ExportNamedDeclaration',
               loc: DUMMY_LOC,
-              // flow does not currently support assertions
+              // flow does not currently support attributes
               assertions: [],
               declaration: null,
               // flow does not support declared type exports with specifiers
@@ -1350,7 +1351,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
                 return [{
                   type: 'ExportNamedDeclaration',
                   loc: DUMMY_LOC,
-                  // flow does not currently support assertions
+                  // flow does not currently support attributes
                   assertions: [],
                   declaration,
                   exportKind,
@@ -1385,7 +1386,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
                   loc: DUMMY_LOC,
                   specifiers: [],
                   exportKind: 'type',
-                  // flow does not currently support assertions
+                  // flow does not currently support attributes
                   assertions: []
                 }];
               }
@@ -1394,7 +1395,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
             const exportNamedDeclaration = {
               type: 'ExportNamedDeclaration',
               loc: DUMMY_LOC,
-              // flow does not currently support assertions
+              // flow does not currently support attributes
               assertions: [],
               declaration,
               exportKind,
@@ -1408,7 +1409,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
           return {
             type: 'ExportNamedDeclaration',
             loc: DUMMY_LOC,
-            // flow does not currently support assertions
+            // flow does not currently support attributes
             assertions: [],
             declaration: null,
             // flow does not support declared type exports with a source
@@ -1718,7 +1719,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
       return {
         type: 'ExportAllDeclaration',
         loc: DUMMY_LOC,
-        // flow does not currently support import/export assertions
+        // flow does not currently support import/export attributes
         assertions: [],
         exportKind: node.exportKind,
         source: transform.StringLiteral(node.source),
@@ -1732,7 +1733,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
         return {
           type: 'ExportNamedDeclaration',
           loc: DUMMY_LOC,
-          // flow does not currently support import/export assertions
+          // flow does not currently support import/export attributes
           assertions: [],
           declaration: null,
           exportKind: node.exportKind,
@@ -2981,7 +2982,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
       const out = specifiers.length ? [{
         type: 'ImportDeclaration',
         loc: DUMMY_LOC,
-        assertions: node.assertions.map(transform.ImportAttribute),
+        assertions: node.attributes.map(transform.ImportAttribute),
         importKind: importKind === 'typeof' ? 'type' : importKind != null ? importKind : 'value',
         source: transform.StringLiteral(node.source),
         specifiers
@@ -3119,7 +3120,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
 
     ObjectTypeAnnotation(node) {
       if (node.properties.length === 1 && node.properties[0].type === 'ObjectTypeMappedTypeProperty') {
-        var _prop$variance;
+        var _prop$variance, _prop$variance2;
 
         // Mapped Object Object types must not have other object properties.
         const prop = node.properties[0];
@@ -3144,7 +3145,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
             name: prop.keyTparam.name
           },
           constraint: transformTypeAnnotationType(prop.sourceType),
-          readonly: ((_prop$variance = prop.variance) == null ? void 0 : _prop$variance.kind) === 'plus',
+          readonly: ((_prop$variance = prop.variance) == null ? void 0 : _prop$variance.kind) === 'plus' || ((_prop$variance2 = prop.variance) == null ? void 0 : _prop$variance2.kind) === 'readonly',
           optional: prop.optional === 'Optional',
           typeAnnotation: transformTypeAnnotationType(prop.propType),
           nameType: null
@@ -3365,10 +3366,10 @@ const getTransforms = (originalCode, scopeManager, opts) => {
     },
 
     ObjectTypeIndexer(node) {
-      var _node$variance2;
+      var _node$variance3, _node$variance4;
 
       if (node.key.type === 'GenericTypeAnnotation') {
-        var _node$variance;
+        var _node$variance, _node$variance2;
 
         const ident = node.key.id.type === 'Identifier' ? node.key.id : node.key.id.id;
         return {
@@ -3390,7 +3391,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
               loc: DUMMY_LOC
             }
           },
-          readonly: ((_node$variance = node.variance) == null ? void 0 : _node$variance.kind) === 'plus',
+          readonly: ((_node$variance = node.variance) == null ? void 0 : _node$variance.kind) === 'plus' || ((_node$variance2 = node.variance) == null ? void 0 : _node$variance2.kind) === 'readonly',
           static: node.static,
           typeAnnotation: {
             type: 'TSTypeAnnotation',
@@ -3413,7 +3414,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
             typeAnnotation: transformTypeAnnotationType(node.key)
           }
         }],
-        readonly: ((_node$variance2 = node.variance) == null ? void 0 : _node$variance2.kind) === 'plus',
+        readonly: ((_node$variance3 = node.variance) == null ? void 0 : _node$variance3.kind) === 'plus' || ((_node$variance4 = node.variance) == null ? void 0 : _node$variance4.kind) === 'readonly',
         static: node.static,
         typeAnnotation: {
           type: 'TSTypeAnnotation',
@@ -3424,22 +3425,52 @@ const getTransforms = (originalCode, scopeManager, opts) => {
     },
 
     ObjectTypeProperty(node) {
-      var _node$variance3;
+      var _node$variance5, _node$variance6;
 
-      const key = node.key.type === 'Identifier' ? transform.Identifier(node.key) : node.key.literalType === 'string' ? transform.StringLiteral(node.key) : null;
+      const [key, computed] = (() => {
+        if (node.key.type === 'Identifier' && node.key.name.startsWith('@@')) {
+          const name = node.key.name.slice(2);
 
-      if (key == null) {
-        throw unexpectedTranslationError(node, 'Unsupported key type');
-      }
+          if (node.method === true && wellKnownSymbols.has(name)) {
+            return [{
+              type: 'MemberExpression',
+              computed: false,
+              object: {
+                type: 'Identifier',
+                name: 'Symbol',
+                optional: false,
+                loc: DUMMY_LOC
+              },
+              optional: false,
+              property: {
+                type: 'Identifier',
+                name,
+                optional: false,
+                loc: DUMMY_LOC
+              },
+              loc: DUMMY_LOC
+            }, true];
+          }
+        }
+
+        const key = node.key.type === 'Identifier' ? transform.Identifier(node.key) : node.key.literalType === 'string' ? transform.StringLiteral(node.key) : null;
+
+        if (key == null) {
+          throw unexpectedTranslationError(node, 'Unsupported key type');
+        }
+
+        return [key, false];
+      })();
 
       if (node.method === true) {
         // flow has just one node for all object properties and relies upon the method flag
         // TS has separate nodes for methods and properties
-        const func = transform.FunctionTypeAnnotation(node.value);
+        const func = transform.FunctionTypeAnnotation(node.value); // $FlowFixMe[incompatible-type] `computed` is set dynamically
+
         return {
           type: 'TSMethodSignature',
           loc: DUMMY_LOC,
-          computed: false,
+          computed,
           key,
           kind: node.kind === 'init' ? 'method' : node.kind,
           optional: node.optional,
@@ -3453,11 +3484,12 @@ const getTransforms = (originalCode, scopeManager, opts) => {
       if (node.kind === 'get' || node.kind === 'set') {
         // flow treats getters/setters as true property signatures (method === false)
         // TS treats them as method signatures
-        const func = transform.FunctionTypeAnnotation(node.value);
+        const func = transform.FunctionTypeAnnotation(node.value); // $FlowFixMe[incompatible-type] `computed` is set dynamically
+
         return {
           type: 'TSMethodSignature',
           loc: DUMMY_LOC,
-          computed: false,
+          computed,
           key,
           kind: node.kind,
           optional: false,
@@ -3468,15 +3500,16 @@ const getTransforms = (originalCode, scopeManager, opts) => {
           // TS accessors cannot have type parameters
           typeParameters: undefined
         };
-      }
+      } // $FlowFixMe[incompatible-type] `computed` is set dynamically
+
 
       return {
         type: 'TSPropertySignature',
         loc: DUMMY_LOC,
-        computed: false,
+        computed,
         key,
         optional: node.optional,
-        readonly: ((_node$variance3 = node.variance) == null ? void 0 : _node$variance3.kind) === 'plus',
+        readonly: ((_node$variance5 = node.variance) == null ? void 0 : _node$variance5.kind) === 'plus' || ((_node$variance6 = node.variance) == null ? void 0 : _node$variance6.kind) === 'readonly',
         static: node.static,
         typeAnnotation: {
           type: 'TSTypeAnnotation',
@@ -3598,7 +3631,7 @@ const getTransforms = (originalCode, scopeManager, opts) => {
     },
 
     TupleTypeAnnotation(node) {
-      const allReadOnly = node.elementTypes.length > 0 && node.elementTypes.every(element => element.type === 'TupleTypeLabeledElement' && element.variance != null && element.variance.kind === 'plus');
+      const allReadOnly = node.elementTypes.length > 0 && node.elementTypes.every(element => element.type === 'TupleTypeLabeledElement' && element.variance != null && (element.variance.kind === 'plus' || element.variance.kind === 'readonly'));
       const elems = node.elementTypes.map(element => {
         switch (element.type) {
           case 'TupleTypeLabeledElement':

package/dist/src/flowToFlowDef.js

@@ -249,7 +249,7 @@ function stripUnusedDefs(detachedStmt, usedDeps, context) {
             specifiers: resultSpecfiers,
             importKind: stmt.importKind,
             source: stmt.source,
-            assertions: stmt.assertions
+            attributes: stmt.attributes
           });
         }
 
@@ -727,15 +727,15 @@ function convertVariableDeclaration(stmt, context) {
 }
 
 function convertImportDeclaration(stmt, context) {
-  if (stmt.assertions.length > 0) {
-    throw (0, _ErrorUtils.translationError)(stmt, 'ImportDeclaration: assertions not supported', context);
+  if (stmt.attributes.length > 0) {
+    throw (0, _ErrorUtils.translationError)(stmt, 'ImportDeclaration: attributes not supported', context);
   }
 
   return [_hermesTransform.t.ImportDeclaration({
     specifiers: stmt.specifiers,
     importKind: stmt.importKind,
     source: stmt.source,
-    assertions: []
+    attributes: []
   }), []];
 }
 
@@ -1147,12 +1147,12 @@ function convertFunctionParameters(params, context) {
 }
 
 function convertBindingNameToFunctionTypeParam(pat, context, index, isAssignment) {
-  const name = pat.type === 'Identifier' ? pat.name : `$$PARAM_${index}$$`;
+  const name = pat.type === 'Identifier' && pat.name != null ? pat.name : `$$PARAM_${index}$$`;
   const [resultParamTypeAnnotation, paramDeps] = convertTypeAnnotation(pat.typeAnnotation, pat, context);
   return [_hermesTransform.t.FunctionTypeParam({
-    name: name != null ? _hermesTransform.t.Identifier({
+    name: _hermesTransform.t.Identifier({
       name
-    }) : null,
+    }),
     typeAnnotation: resultParamTypeAnnotation,
     optional: isAssignment || (pat.type === 'Identifier' ? pat.optional : false)
   }), paramDeps];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "flow-api-translator",
-  "version": "0.33.3",
+  "version": "0.35.0",
   "description": "Toolkit for creating Flow and TypeScript compatible libraries from Flow source code.",
   "main": "dist/index.js",
   "license": "MIT",
@@ -13,10 +13,10 @@
     "@typescript-eslint/parser": "8.38.0",
     "@typescript-eslint/visitor-keys": "8.38.0",
     "flow-enums-runtime": "^0.0.6",
-    "hermes-eslint": "0.33.3",
-    "hermes-estree": "0.33.3",
-    "hermes-parser": "0.33.3",
-    "hermes-transform": "0.33.3",
+    "hermes-eslint": "0.35.0",
+    "hermes-estree": "0.35.0",
+    "hermes-parser": "0.35.0",
+    "hermes-transform": "0.35.0",
     "typescript": "5.3.2"
   },
   "peerDependencies": {