flexdesk 0.4.7 → 0.6.0

package/src/flow/outline/strings.js

@@ -0,0 +1,135 @@
+/**
+ * EVERY WORD THE OUTLINE EDITOR DRAWS, over the kit's (36 §3.13, §6).
+ *
+ * English, and naming no domain. What a consumer calls a block's parts — what
+ * an error port means, what a loop's foot says, what the flow row is called —
+ * comes from the BLOCK MAPPING (`mapping.js`), and the consumer's `strings`
+ * are laid over these:
+ *
+ *     const S = createStrings(OUTLINE_STRINGS, options.strings);
+ *
+ * Names are quoted ‘like this’ in a sentence. A function string takes the
+ * names it quotes, already resolved to what the reader sees (a step's label,
+ * else its type's label, else its id).
+ */
+
+const plural = (n, one, many) => (n === 1 ? one : many.replace('{n}', String(n)));
+
+export const OUTLINE_STRINGS = Object.freeze({
+    // ── why a flow cannot be drawn as an outline (36 §6.3) ──────────────
+    outline_no_start: 'This flow has no Start step.',
+    outline_two_starts: 'This flow has two Start steps.',
+    outline_unknown_type: (type) => `‘${type}’ is a step type this editor does not know, so the flow cannot be `
+        + 'drawn as an outline.',
+    outline_unreachable: (x) => `Nothing leads to ‘${x}’ from Start.`,
+    outline_shared_step: (x) => `‘${x}’ is reached from two places that are not one block.`,
+    outline_jump_out: (x, y) => `A line from ‘${x}’ leaves its block for ‘${y}’.`,
+    outline_two_continuations: (x) => `‘${x}’ continues to two steps; a Parallel step runs branches side by side.`,
+    outline_parallel_unjoined: (p) => `The branches of ‘${p}’ do not meet at one Merge.`,
+    outline_merge_unpaired: (j) => `‘${j}’ closes no Parallel step.`,
+    outline_loop_shape: (l) => `The body of ‘${l}’ does not end at its Next.`,
+    loopNextOutside: (x, l) => `‘${x}’ is not inside the body of ‘${l}’, so it cannot go on to its next item.`,
+    loopLeaks: (l, y) => `The body of ‘${l}’ reaches ‘${y}’, which runs after the loop.`,
+    loopEnteredByNext: (l) => `‘${l}’ is entered by its Next from outside its body.`,
+    outline_cycle: (x, y) => `‘${x}’ leads back to ‘${y}’, and only a loop's Next may.`,
+    selfLine: (x) => `A line leaves ‘${x}’ and comes straight back into it; a step cannot connect to itself.`,
+    outline_unknown_port: (x, port) => `‘${x}’ has no port called ${port}.`,
+    outline_broken_line: (id) => `A line names ‘${id}’, which is not a step in this flow.`,
+    outline_after_end: (x, y) => `‘${x}’ ends the run, and a line leaves it for ‘${y}’.`,
+    readOnlyBecause: (reason) => `This flow is shown as a list in the order it runs, and cannot be edited here: ${reason}`,
+
+    // ── the list ───────────────────────────────────────────────────────
+    stepsHeading: 'Steps',
+    stepsCount: (n) => plural(n, '1 step', '{n} steps'),
+    findStep: 'Find a step',
+    findNothing: (q) => `No step matches “${q}”.`,
+    statusKeys: 'Alt+↑ ↓ moves a step · Ctrl+D duplicates · Del removes · Ctrl+Z undoes',
+    fold: (x) => `Fold ${x}`,
+    unfold: (x) => `Unfold ${x}`,
+    menuFor: (x) => `Menu for ${x}`,
+    dragToMove: 'Drag to move',
+    addStepHere: (where) => `Add a step here — ${where}`,
+    removeBranch: (arm) => `Remove ${arm}`,
+    armStops: 'Stops here',
+    flowStart: 'Start',
+    startType: 'Flow',
+
+    // ── where a step is, and where one would go ────────────────────────
+    topLevel: 'Top level',
+    topLevelFirst: 'Top level · the first step',
+    topLevelLast: 'Top level · the last step',
+    insidePath: (path) => `Inside ${path}`,
+    pathJoin: ' › ',
+    gapTop: 'at the top level',
+    gapInside: (path) => `inside ${path}`,
+    gapAfter: (where, x) => `${where}, after ${x}`,
+    gapBefore: (where, x) => `${where}, before ${x}`,
+    gapFirst: (where) => `${where}, as the first step`,
+    dropInto: (path) => `Into ${path}`,
+    dropTop: 'Top level',
+    dropBefore: (x) => `before ${x}`,
+    dropAfter: (x) => `after ${x}`,
+    dropFirst: 'as the first step',
+    dropLabel: (where, at) => `${where} · ${at}`,
+    dropNowhere: 'Drop it between two steps to move it there.',
+
+    // ── the step menu ──────────────────────────────────────────────────
+    moveUp: 'Move up',
+    moveDown: 'Move down',
+    moveOut: (x) => `Move out of ${x}`,
+    moveOutTop: 'Move out',
+    wrapIn: 'Wrap in',
+    copy: 'Copy',
+    cut: 'Cut',
+    pasteAfter: 'Paste after',
+    renameKey: 'F2',
+    keyMoveUp: 'Alt+↑',
+    keyMoveDown: 'Alt+↓',
+    keyMoveOut: 'Alt+←',
+    keyDuplicate: 'Ctrl+D',
+    keyCopy: 'Ctrl+C',
+    keyCut: 'Ctrl+X',
+    keyPaste: 'Ctrl+V',
+    keyRemove: 'Del',
+    refusedLine: (what, why) => `${what} — ${why}`,
+    alreadyFirst: (where) => `already first in ${where}`,
+    alreadyLast: (where) => `already last in ${where}`,
+    alreadyTop: 'already at the top level',
+    theTopLevel: 'the top level',
+    nothingCopied: 'nothing is copied',
+    readOnlyRefusal: 'the flow is read only',
+
+    // ── why an edit is refused ─────────────────────────────────────────
+    endNotLast: (end) => `‘${end}’ ends the run, so it can only be the last step here.`,
+    nothingAfterEnd: (end) => `Nothing runs after ‘${end}’.`,
+    endsNotLast: (x) => `Every way through ‘${x}’ ends, so it can only be the last step here.`,
+    endInLoop: (end, loop) => `‘${end}’ ends the run, and a loop's body cannot: the steps inside ‘${loop}’ end at its next item.`,
+    wrapLoopNeverReturns: (x) => `‘${x}’ never goes on, so a loop around it would never reach its next item.`,
+    wouldOrphan: (y) => `Nothing would lead to ‘${y}’ any more.`,
+    branchToJoinNeeded: (p, j) => `‘${p}’ needs a branch that goes on to ‘${j}’.`,
+    unreachableHere: (x) => `Every way through ‘${x}’ ends, so nothing would reach a step after it.`,
+    nextOutsideLoop: (x) => `‘${x}’ goes on with the next item of a loop, so it can only go inside one.`,
+    intoItself: (x) => `‘${x}’ cannot go inside itself.`,
+    lastBranch: (p) => `‘${p}’ needs at least one branch.`,
+    armNoContinuation: (x) => `Nothing comes after ‘${x}’ yet, so there is nowhere for those steps to carry on `
+        + 'to — add a step after it first.',
+    notBlockShaped: (why) => `That would leave a flow the outline cannot draw: ${why}`,
+    noJoinType: 'There is no step type that closes a Parallel step.',
+
+    // ── ports drawn as settings (36 §6.5) ──────────────────────────────
+    armExitLabel: 'After those steps',
+    armExitRejoin: (x) => `Carry on with “${x}”`,
+    armExitRejoinEnd: 'Carry on after this step',
+    joinSettingLabel: 'When the branches finish',
+    joinAll: 'Wait for every branch',
+    joinAny: 'Go on when the first one finishes',
+
+    // ── the run overlay (36 §6.7) ──────────────────────────────────────
+    runTaken: 'taken',
+    runNotTaken: 'not taken',
+    runCount: (n) => `×${n}`,
+    runState: (state) => ({
+        completed: 'completed', failed: 'failed', skipped: 'skipped', running: 'running',
+        cancelled: 'cancelled', 'not-reached': 'not reached',
+    }[state] ?? String(state ?? '')),
+});

package/src/tiling/landing_table.js

@@ -3,7 +3,10 @@
  * pattern used by SFC / Markets / Scenarios / KPIs landings (and the
  * market-archetype instances table). Three responsibilities:
  *
- *   1. Single-click row → open the entity (handled by callers).
+ *   1. Single-click row → open the entity (handled by callers). Since 0.5.0
+ *      the click is judged by the same rule as `DataTable`'s `onRowActivate`
+ *      (`ui/components/row_activation.js`); a table that owns its rows can
+ *      use that option directly instead of this helper.
  *   2. Right-click row → custom context menu with Open / Edit / Delete
  *      (replaces DataTable's default copy-as-TSV menu for these tables;
  *      the default still applies to data tables outside this helper).
@@ -16,6 +19,7 @@
  */
 
 import { showContextMenu } from '../ui/components/context_menu.js';
+import { isRowActivation } from '../ui/components/row_activation.js';
 import { registerPanelKeys } from './panel_keys.js';
 
 /** Attach the navigation-table interactions to a host element that
@@ -85,10 +89,14 @@ export function attachLandingTableBehavior(host, getRow, entityActions, options
             dispatch(actionBtn.dataset.twmAction, tr ? getRow(tr.__rowIndex) : null);
             return;
         }
-        // Plain row click → open. Ignore clicks on interactive controls
-        // (buttons, filter inputs, links) and anything outside a body row
-        // (pagination strip, header, empty space).
-        if (ev.target.closest('button, a, input, select, textarea')) return;
+        // Plain row click → open — by THE row-activation rule DataTable's own
+        // `onRowActivate` uses (0.5.0, `ui/components/row_activation.js`), so
+        // the two cannot drift: not on a control (a button, a field, a link),
+        // not on the click that ends a drag selecting a cell's text, and not on
+        // the second click of a double-click, which used to open the row twice.
+        // Anything outside a body row (pagination strip, header, empty space)
+        // is not a row either.
+        if (!isRowActivation(ev, 'click', { scope: host })) return;
         const tr = bodyRowFor(ev);
         if (tr) dispatch('open', getRow(tr.__rowIndex));
     };