flexdesk 0.17.16 → 0.17.18

package/src/ui/controllers/window_chrome_controller.js

@@ -404,10 +404,13 @@ export class WindowChromeController {
         // What never starts a drag: anything you can click or type into. An
         // embedder adds its own with `noDrag`. (`.window-controls` and
         // `.panel-toggles` are kept for embedders' own markup of that shape.)
+        // A menu bar in the top bar (a hamburger, STORY-0133) drops its menus
+        // inside the bar's DOM: a press on a menu's padding or separator is
+        // in the bar, not a drag.
         const NO_DRAG_SELECTOR = [
             '.no-drag', 'button', 'a', 'input', 'select', 'textarea', 'label',
             '[role="button"]', '[role="menuitem"]', '[role="tab"]', '[contenteditable="true"]',
-            '.twm-window-controls', '.window-controls', '.panel-toggles',
+            '.twm-window-controls', '.window-controls', '.panel-toggles', '.twm-menubar',
             this._noDrag,
         ].filter(Boolean).join(', ');
 

package/src/ui/notification_center.js

@@ -35,11 +35,20 @@
  * `log:entry`). A toast that leaves marks its own entry `dismissed` with a
  * `reason`; it adds none. `subscribe(fn)` calls `fn(entry, center)` for each
  * entry added, so a history view follows the centre rather than the bus.
+ *
+ * Copy message (STORY-0131)
+ * -------------------------
+ * A right-click on a toast, or on its entry in the history, opens the context
+ * menu with "Copy message": the title, the message and the description, one
+ * per line, go to the clipboard as plain text. The text is also selectable:
+ * a click on the title, message, description or status, or one that ends a
+ * selection, does not close the toast; only a click on its chrome does.
  */
 import { ComponentBase } from './base/component_base.js';
 import { getSetting } from '../core/settings.js';
 import { setToastBus, getToastBus } from './components/toast.js';
 import { ProgressBar } from './components/progress.js';
+import { showContextMenu } from './components/context_menu.js';
 
 const SEVERITIES = ['info', 'success', 'warn', 'error', 'fatal'];
 
@@ -60,6 +69,39 @@ const DEFAULT_LOG_LEVELS = new Set(['warn', 'error', 'fatal']);
 // Messages from these namespaces are self-descriptive and need no category header.
 const SUPPRESSED_NAMESPACE_TITLES = new Set(['bootstrap', 'app']);
 
+/** A notification as plain text: its title, message and description, one per line. */
+export function notificationText(notification) {
+    return [notification.title, notification.message, notification.description]
+        .filter((part) => part != null && String(part) !== '')
+        .join('\n');
+}
+
+/**
+ * The right-click menu of a toast or a history entry: "Copy message". It takes
+ * the right-click, so the browser's own menu does not open.
+ */
+export function showNotificationMenu(event, notification, logger) {
+    event.preventDefault();
+    event.stopPropagation();
+    showContextMenu(event.clientX, event.clientY,
+        [{ label: 'Copy message', icon: 'content_copy', action: 'copy' }],
+        () => {
+            Promise.resolve()
+                .then(() => navigator.clipboard.writeText(notificationText(notification)))
+                .catch((err) => logger?.warn?.('twm-notification-center', 'Copy message failed', { err }));
+        });
+}
+
+/** The toast's text: clicking it selects, it does not dismiss. */
+const TOAST_TEXT = '.twm-notification__title, .twm-notification__body, '
+    + '.twm-notification__description, .twm-notification__status';
+
+/** A non-empty text selection inside `el`: a click that ends one is not a click on it. */
+function selectsTextIn(el) {
+    const sel = el.ownerDocument.getSelection?.();
+    return Boolean(sel && !sel.isCollapsed && sel.rangeCount && el.contains(sel.getRangeAt(0).commonAncestorContainer));
+}
+
 export class NotificationCenter extends ComponentBase {
     #items;
     #summaryEl;
@@ -752,12 +794,16 @@ export class NotificationCenter extends ComponentBase {
             item.appendChild(actionsEl);
         }
 
+        // A click on the text is the start of selecting it (a double-click's
+        // first click leaves only a caret), so only the toast's chrome closes it.
         item.addEventListener('click', (event) => {
-            if (event.target.closest('button') || NotificationCenter.#isRunning(notification)) {
+            if (event.target.closest(`button, ${TOAST_TEXT}`) || NotificationCenter.#isRunning(notification)
+                || selectsTextIn(item)) {
                 return;
             }
             this.dismiss(notification.id, 'click');
         });
+        item.addEventListener('contextmenu', (event) => showNotificationMenu(event, notification, this.logger));
 
         this.#patchItem(entry, notification);
         return entry;