flet-box 1.0.3 → 1.0.4

package/src/widgets/Modal.js

@@ -312,6 +312,8 @@ export const Modal = (props = {}) => {
 
   let isOpen = false;
   let overlay = null;
+  // Pending "hide after the close animation" timer, so it can be cancelled.
+  let closeTimer = null;
   let modalBody = null;
 
   // Handlers
@@ -323,7 +325,11 @@ export const Modal = (props = {}) => {
       modalBody.style.opacity = "0";
     }
     if (overlay) overlay.style.opacity = "0";
-    setTimeout(() => {
+    // Keep the id: `handleOpen` clears it, otherwise a reopen within 300 ms gets
+    // a stale timer that hides an OPEN modal, leaving it invisible and unusable.
+    if (closeTimer) clearTimeout(closeTimer);
+    closeTimer = setTimeout(() => {
+      closeTimer = null;
       if (overlay) overlay.style.visibility = "hidden";
     }, 300);
     if (closeOnEsc) document.removeEventListener("keydown", handleKeyDown);
@@ -333,6 +339,11 @@ export const Modal = (props = {}) => {
   const handleOpen = () => {
     if (isOpen) return;
     isOpen = true;
+    // Cancel any pending hide from a close that is still animating out.
+    if (closeTimer) {
+      clearTimeout(closeTimer);
+      closeTimer = null;
+    }
     if (overlay) {
       overlay.style.visibility = "visible";
       overlay.style.opacity = "1";
@@ -405,6 +416,18 @@ export const Modal = (props = {}) => {
   overlay.appendChild(modalBody);
   document.body.appendChild(overlay);
 
+  // The overlay lives in `document.body` and can be removed without `close()`
+  // ever running (a state rebuild, a route change, a plain removeChild of the
+  // host). `_cleanup` is not called on that path, so release the document
+  // listener and any pending animation timer through the lifecycle hook too.
+  overlay.onUnmount(() => {
+    if (closeTimer) {
+      clearTimeout(closeTimer);
+      closeTimer = null;
+    }
+    if (closeOnEsc) document.removeEventListener("keydown", handleKeyDown);
+  });
+
   // Public API
   const instance = {
     open: handleOpen,

package/src/widgets/QRCode.js

@@ -116,7 +116,9 @@ function buildQRMatrix(text, ecLevel = "M") {
     for (let i = len - 1; i >= 0; i--) bits.push((val >> i) & 1);
   };
   pushBits(0b0100, 4);           // mode indicator: byte
-  pushBits(bytes.length, 8);    // character count
+  // Character count: 8 bits for versions 1-9, 16 bits for versions 10-40
+  // (ISO/IEC 18004). Emitting 8 bits at version 10 misaligns every later bit.
+  pushBits(bytes.length, version < 10 ? 8 : 16);
   for (const b of bytes) pushBits(b, 8);
   // Terminator
   for (let i = 0; i < 4 && bits.length < dataCodewords * 8; i++) bits.push(0);
@@ -161,7 +163,12 @@ function buildQRMatrix(text, ecLevel = "M") {
 
   // 7. Build final bit sequence
   const finalBits = [];
-  for (const cw of finalCW) pushBits(cw, 8);
+  // NOTE: `pushBits` writes into `bits` (the pre-interleave stream), so it must
+  // not be used here. Using it left `finalBits` empty, and the placement pass
+  // then wrote every data module as 0 — the symbol carried no payload at all.
+  for (const cw of finalCW) {
+    for (let i = 7; i >= 0; i--) finalBits.push((cw >> i) & 1);
+  }
   // Remainder bits (version-dependent, versions 2–6 need 7)
   const remainderBitsCount = version >= 2 && version <= 6 ? 7 : 0;
   for (let i = 0; i < remainderBitsCount; i++) finalBits.push(0);

package/src/widgets/Radio.js

@@ -67,7 +67,7 @@ export const Radio = (props) => {
 
   // Handle click
   if (!disabled) {
-    radio.onclick = (e) => {
+    const handleClick = (e) => {
       e.stopPropagation();
       if (internalSelected) return;
 
@@ -88,6 +88,10 @@ export const Radio = (props) => {
 
       if (onPress) onPress(true);
     };
+    // Routed through the factory props: `assignProps` clears `onclick` on every
+    // update and only re-applies handlers present in the merged props, so a
+    // direct assignment died on the first `update()` or reactive setter.
+    radio.update({ onPress: handleClick });
 
     // Hover effect
     radio.addEventListener("mouseenter", () => {

package/src/widgets/Slider.js

@@ -299,6 +299,9 @@ export const Slider = (props) => {
 
   function generateDefaultMarks() {
     const stepMark = (currentMax - currentMin) / 4;
+    // With `min === max` (or non-numeric bounds) stepMark is 0/NaN, so
+    // `i += stepMark` never advances and the loop hangs the tab forever.
+    if (!(stepMark > 0)) return [currentMin];
     const marksList = [];
     for (let i = currentMin; i <= currentMax + 0.1; i += stepMark) {
       marksList.push(Math.round(i));

package/src/widgets/SnackBar.js

@@ -124,9 +124,18 @@ export function SnackBar(options) {
   });
 
   let timeoutId = null;
+  let rafId = null;
+  // `close()` is final: it must fire `onClose` exactly once and must win any
+  // race against the pending `show()` frame, otherwise closing a toast right
+  // after creating it would flash it back to opacity 1 for a full animation.
+  let closed = false;
 
   const show = () => {
-    requestAnimationFrame(() => {
+    if (closed) return;
+    if (rafId !== null) cancelAnimationFrame(rafId);
+    rafId = requestAnimationFrame(() => {
+      rafId = null;
+      if (closed) return;
       snackbar.style.opacity = "1";
       snackbar.style.transform = "translateY(0)";
     });
@@ -134,7 +143,16 @@ export function SnackBar(options) {
   };
 
   const close = () => {
-    if (timeoutId) clearTimeout(timeoutId);
+    if (closed) return;
+    closed = true;
+    if (timeoutId) {
+      clearTimeout(timeoutId);
+      timeoutId = null;
+    }
+    if (rafId !== null) {
+      cancelAnimationFrame(rafId);
+      rafId = null;
+    }
     snackbar.style.opacity = "0";
     snackbar.style.transform =
       position === "bottom"

package/src/widgets/Switch.js

@@ -79,13 +79,17 @@ export const Switch = (props) => {
 
   // Handle click
   if (!disabled) {
-    switchContainer.onclick = (e) => {
+    const handleClick = (e) => {
       e.stopPropagation();
       const newValue = !internalValue;
       internalValue = newValue;
       updateUI(newValue);
       if (onPress) onPress(newValue);
     };
+    // Routed through the factory props: `assignProps` clears `onclick` on every
+    // update and only re-applies handlers present in the merged props, so a
+    // direct assignment died on the first `update()` or reactive setter.
+    switchContainer.update({ onPress: handleClick });
   }
 
   // Public methods

package/src/widgets/TreeView.js

@@ -280,7 +280,9 @@ export const TreeView = (props) => {
 
   // ========== PUBLIC METHODS ==========
 
-  container.updateNodes = (newNodes, selectedId = null) => {
+  // NOTE: no `selectedId = null` default. The guard below tests `!== undefined`,
+  // so a `null` default made it always true and every call wiped the selection.
+  container.updateNodes = (newNodes, selectedId) => {
     nodes.length = 0;
     nodes.push(...newNodes);
     if (selectedId !== undefined) currentSelectedId = selectedId;