fix-smart-quotes 1.0.0 → 1.0.2

package/README.md

@@ -4,26 +4,28 @@ Convert straight quotes to proper typographic ("smart") quotes in Markdown files
 
 | Language | Before | After |
 |----------|--------|-------|
-| German | `"text"` | `„text"` (U+201E / U+201C) |
-| English | `"text"` | `"text"` (U+201C / U+201D) |
+| German | `"text"` | `„text“` (U+201E / U+201C) |
+| English | `"text"` | `“text”` (U+201C / U+201D) |
 
 ## Why?
 
-When AI coding assistants edit Markdown files, they often replace typographic quotes with straight quotes. This is intentional—straight quotes are safer for code and avoid encoding issues.
+Claude (including Claude.ai, Claude Desktop, and Claude Code) consistently uses straight quotes (`"`) instead of typographic quotes. This applies to both generated text and edits to existing content. The reason: straight quotes are universally compatible. They work in code, terminals, and forms, avoiding encoding issues that can turn smart quotes into question marks.
 
-But for prose text, proper typography matters.
+Other AI assistants behave differently: ChatGPT and DeepSeek typically output smart quotes, while Claude and Gemini use straight quotes.
 
-**Example - before AI edit:**
+For prose and documentation, proper typography matters. German and English have distinct quote styles that convey professionalism and readability.
+
+**Example - text with proper German quotes:**
 ```
-Sie sagte: „Das ist wichtig."
+Sie sagte: „Das ist wichtig.“
 ```
 
-**After AI edit:**
+**After Claude edits or generates text:**
 ```
 Sie sagte: "Das ist wichtig."
 ```
 
-This tool restores the correct quotes—either manually via CLI, or automatically after each Claude Code edit via hook.
+This tool restores the correct quotes: either manually via CLI or automatically after each Claude edit via hook.
 
 ## Installation
 
@@ -49,26 +51,37 @@ fix-smart-quotes docs/*.md
 
 ## Claude Code Hook
 
-The primary use case: automatically fix quotes in files that Claude Code just edited. The hook runs **only** on files modified by Claude's Write or Edit tools—not on your entire project.
+Automatically fix quotes after Claude edits Markdown files.
+
+**1. Create wrapper script** at `~/.claude/hooks/fix-smart-quotes-wrapper.sh`:
+
+```bash
+#!/bin/bash
+INPUT=$(cat)
+FILE_PATH=$(echo "$INPUT" | jq -r '.tool_input.file_path // empty')
+[ -z "$FILE_PATH" ] && exit 0
+[[ ! "$FILE_PATH" =~ \.md$ ]] && exit 0
+[ ! -f "$FILE_PATH" ] && exit 0
+npx fix-smart-quotes "$FILE_PATH"
+exit 0
+```
+
+**2. Make executable:** `chmod +x ~/.claude/hooks/fix-smart-quotes-wrapper.sh`
 
-Add to `~/.claude/settings.json`:
+**3. Add to** `~/.claude/settings.json`:
 
 ```json
 {
   "hooks": {
     "PostToolUse": [{
       "matcher": "Write|Edit",
-      "hooks": [{
-        "type": "command",
-        "command": "npx fix-smart-quotes \"$FILE_PATH\"",
-        "timeout": 30
-      }]
+      "hooks": [{"type": "command", "command": "~/.claude/hooks/fix-smart-quotes-wrapper.sh", "timeout": 30}]
     }]
   }
 }
 ```
 
-This means: After Claude writes or edits a file, immediately run the quote fixer on that specific file.
+> **Note:** Claude Code passes file paths via stdin JSON, not environment variables. The wrapper script handles this.
 
 ## Features
 

package/docs/plans/2026-01-21-hook-wrapper-fix.md

@@ -0,0 +1,160 @@
+# Hook Wrapper Fix Implementation Plan
+
+> **For Claude:** REQUIRED SUB-SKILL: Use superpowers:executing-plans to implement this plan task-by-task.
+
+**Goal:** Fix the PostToolUse hook to correctly receive file paths via stdin JSON instead of environment variables.
+
+**Architecture:** Create a wrapper shell script that parses JSON from stdin, extracts the file path, filters for markdown files only, and calls fix-smart-quotes. Update settings.json to use the wrapper.
+
+**Tech Stack:** Bash, jq, Node.js (fix-smart-quotes)
+
+---
+
+## Task 1: Create Wrapper Script
+
+**Files:**
+- Create: `~/.claude/hooks/fix-smart-quotes-wrapper.sh`
+
+**Step 1: Create the wrapper script**
+
+```bash
+#!/bin/bash
+# fix-smart-quotes-wrapper.sh
+# Wrapper for fix-smart-quotes that parses Claude Code hook stdin JSON
+
+# Read JSON from stdin
+INPUT=$(cat)
+
+# Extract file_path from JSON using jq
+FILE_PATH=$(echo "$INPUT" | jq -r '.tool_input.file_path // .tool_input.filePath // empty')
+
+# Exit 0 if no file path found (non-blocking)
+if [ -z "$FILE_PATH" ]; then
+  exit 0
+fi
+
+# Only process markdown files
+if [[ ! "$FILE_PATH" =~ \.(md|markdown)$ ]]; then
+  exit 0
+fi
+
+# Check if file exists
+if [ ! -f "$FILE_PATH" ]; then
+  exit 0
+fi
+
+# Run fix-smart-quotes
+npx fix-smart-quotes "$FILE_PATH"
+
+# Always exit 0 to not block Claude Code
+exit 0
+```
+
+**Step 2: Make script executable**
+
+Run: `chmod +x ~/.claude/hooks/fix-smart-quotes-wrapper.sh`
+
+**Step 3: Verify script is executable**
+
+Run: `ls -la ~/.claude/hooks/fix-smart-quotes-wrapper.sh`
+Expected: `-rwxr-xr-x` permissions
+
+---
+
+## Task 2: Test Wrapper Script Manually
+
+**Step 1: Test with valid markdown file path**
+
+Run:
+```bash
+echo '{"tool_input": {"file_path": "/tmp/test.md"}}' > /tmp/test.md
+echo 'This is a "test" file.' >> /tmp/test.md
+echo '{"tool_input": {"file_path": "/tmp/test.md"}}' | ~/.claude/hooks/fix-smart-quotes-wrapper.sh
+echo "Exit code: $?"
+cat /tmp/test.md
+```
+
+Expected: Exit code 0, file contains smart quotes
+
+**Step 2: Test with non-markdown file**
+
+Run:
+```bash
+echo '{"tool_input": {"file_path": "/tmp/test.json"}}' | ~/.claude/hooks/fix-smart-quotes-wrapper.sh
+echo "Exit code: $?"
+```
+
+Expected: Exit code 0 (non-blocking)
+
+**Step 3: Test with missing file_path**
+
+Run:
+```bash
+echo '{"tool_input": {}}' | ~/.claude/hooks/fix-smart-quotes-wrapper.sh
+echo "Exit code: $?"
+```
+
+Expected: Exit code 0 (non-blocking)
+
+**Step 4: Cleanup test files**
+
+Run: `rm -f /tmp/test.md /tmp/test.json`
+
+---
+
+## Task 3: Update settings.json
+
+**Files:**
+- Modify: `~/.claude/settings.json`
+
+**Step 1: Update hook command**
+
+Change from:
+```json
+"command": "npx fix-smart-quotes \"$FILE_PATH\""
+```
+
+To:
+```json
+"command": "~/.claude/hooks/fix-smart-quotes-wrapper.sh"
+```
+
+**Step 2: Verify settings.json is valid JSON**
+
+Run: `jq . ~/.claude/settings.json > /dev/null && echo "Valid JSON"`
+Expected: "Valid JSON"
+
+---
+
+## Task 4: End-to-End Test
+
+**Step 1: Create a test markdown file**
+
+Run:
+```bash
+echo 'Test "quotes" here.' > /tmp/hook-test.md
+```
+
+**Step 2: Simulate hook invocation**
+
+Run:
+```bash
+echo '{"tool_input": {"file_path": "/tmp/hook-test.md"}}' | ~/.claude/hooks/fix-smart-quotes-wrapper.sh
+cat /tmp/hook-test.md
+```
+
+Expected: File contains smart quotes (German style since no lang specified)
+
+**Step 3: Cleanup**
+
+Run: `rm /tmp/hook-test.md`
+
+---
+
+## Summary
+
+After completing all tasks:
+- [x] Wrapper script created at `~/.claude/hooks/fix-smart-quotes-wrapper.sh`
+- [x] Wrapper parses stdin JSON, filters for .md files, exits 0 on non-matches
+- [x] settings.json updated to use wrapper
+- [x] Hook no longer causes errors on non-markdown files

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fix-smart-quotes",
-  "version": "1.0.0",
+  "version": "1.0.2",
   "description": "Fix straight quotes to smart quotes in Markdown (DE/EN)",
   "main": "index.js",
   "bin": {