firstly 0.9.1 → 0.9.3

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # firstly
 
+## 0.9.3
+
+### Patch Changes
+
+- [#349](https://github.com/jycouet/firstly/pull/349) [`b285731`](https://github.com/jycouet/firstly/commit/b285731fe8e6cd41e5a257a044524486319e5544) Thanks [@jycouet](https://github.com/jycouet)! - feedback: `getIssues` now returns `labels` (names), `createdAt` and `updatedAt` per issue; `createIssue` accepts an optional `labels: string[]` applied on top of `create_label`.
+
+- [#351](https://github.com/jycouet/firstly/pull/351) [`9701c40`](https://github.com/jycouet/firstly/commit/9701c404c7c2e6e2f94a7e3eab536b6a55d0c9c2) Thanks [@jycouet](https://github.com/jycouet)! - `withShortTermCache`: mutations (POST writes, PUT, PATCH, DELETE) now clear the cache once they settle, so a follow-up refresh no longer serves the pre-mutation read.
+
+## 0.9.2
+
+### Patch Changes
+
+- [#347](https://github.com/jycouet/firstly/pull/347) [`2a6576c`](https://github.com/jycouet/firstly/commit/2a6576ce7955ad73b38b3c07a3daf7c0fde78525) Thanks [@jycouet](https://github.com/jycouet)! - fix(sqlAdmin): read-only queries no longer fail with "nested transactions not allowed" on Postgres
+
 ## 0.9.1
 
 ### Patch Changes

package/esm/core/httpClientStack.d.ts

@@ -28,7 +28,8 @@ export type ShortTermCacheOptions = {
  * Middleware that dedupes identical read requests within a short TTL - a tiny
  * client-side cache. Two components mounting and issuing the same query result in
  * ONE network call; each caller gets its own `Response` clone. Failed requests are
- * evicted immediately so the next call retries.
+ * evicted immediately so the next call retries. Any mutation (non-GET that isn't a
+ * cached read) clears the cache once it settles, so a follow-up refresh sees fresh data.
  *
  * ```ts
  * remult.apiClient.httpClient = stackHttpClient(withShortTermCache({ ttlMs: 2000 }))

package/esm/core/httpClientStack.js

@@ -26,7 +26,8 @@ const defaultShouldCache = (_input, init, key) => {
  * Middleware that dedupes identical read requests within a short TTL - a tiny
  * client-side cache. Two components mounting and issuing the same query result in
  * ONE network call; each caller gets its own `Response` clone. Failed requests are
- * evicted immediately so the next call retries.
+ * evicted immediately so the next call retries. Any mutation (non-GET that isn't a
+ * cached read) clears the cache once it settles, so a follow-up refresh sees fresh data.
  *
  * ```ts
  * remult.apiClient.httpClient = stackHttpClient(withShortTermCache({ ttlMs: 2000 }))
@@ -48,7 +49,18 @@ export function withShortTermCache(opts = {}) {
             cacheKey = `${cacheKey}:${bodyStr}`;
         }
         if (!shouldCache(input, init, cacheKey)) {
-            return next(input, init);
+            const method = init?.method?.toUpperCase() ?? 'GET';
+            if (method === 'GET')
+                return next(input, init);
+            // Mutation: drop cached reads once it settles (not before, so a read racing the
+            // write can't re-cache pre-mutation data). Cleared on error too: the server may
+            // have partially mutated.
+            try {
+                return await next(input, init);
+            }
+            finally {
+                cache.clear();
+            }
         }
         const now = Date.now();
         const cached = cache.get(cacheKey);

package/esm/feedback/FeedbackController.d.ts

@@ -9,6 +9,10 @@ export declare class FeedbackController {
         number: number;
         titleHTML: string;
         state: string;
+        createdAt: string;
+        updatedAt: string;
+        /** GitHub label names. */
+        labels: string[];
         highlight: boolean;
     }[]>;
     static getIssue(issueNumber: number): Promise<{
@@ -27,7 +31,9 @@ export declare class FeedbackController {
     }>;
     static createIssue(milestoneId: string, title: string, body: string, metadata: {
         page: string;
-    }): Promise<{
+    }, 
+    /** Extra label names applied on top of `create_label` (unknown names are ignored). */
+    labels?: string[]): Promise<{
         id: string;
         number: number;
     }>;

package/esm/feedback/FeedbackController.js

@@ -121,6 +121,8 @@ export class FeedbackController {
                 number
                 titleHTML
                 state
+                createdAt
+                updatedAt
                 labels(first:10){
                   nodes {
                     name
@@ -142,14 +144,18 @@ export class FeedbackController {
             issueOrder,
         });
         return data.repository.milestone.issues.nodes.map((issue) => {
+            const labels = issue.labels.nodes.map((label) => label.name);
             const hasWaitingForAnswerLabel = remult.context.feedbackOptions.highlight_label
-                ? issue.labels.nodes.some((label) => label.name.includes(remult.context.feedbackOptions.highlight_label))
+                ? labels.some((name) => name.includes(remult.context.feedbackOptions.highlight_label))
                 : false;
             return {
                 id: issue.id,
                 number: issue.number,
                 titleHTML: issue.titleHTML,
                 state: issue.state,
+                createdAt: issue.createdAt,
+                updatedAt: issue.updatedAt,
+                labels,
                 highlight: hasWaitingForAnswerLabel,
             };
         });
@@ -231,7 +237,9 @@ repository(name: $repository, owner: $owner) {
         };
         return toRet;
     }
-    static async createIssue(milestoneId, title, body, metadata) {
+    static async createIssue(milestoneId, title, body, metadata, 
+    /** Extra label names applied on top of `create_label` (unknown names are ignored). */
+    labels = []) {
         const repoInfo = await getGitHub(`query RepoInfo(
         $repository: String!
         $owner: String!
@@ -250,7 +258,8 @@ repository(name: $repository, owner: $owner) {
             owner: remult.context.feedbackOptions.repo.owner,
         });
         const repoInfoData = repoInfo.repository;
-        const create_label = repoInfoData.labels.nodes.find((c) => c.name === remult.context.feedbackOptions.create_label);
+        const wanted = new Set([remult.context.feedbackOptions.create_label, ...labels]);
+        const labelIds = repoInfoData.labels.nodes.filter((c) => wanted.has(c.name)).map((c) => c.id);
         const newIssue = await getGitHub(`mutation CreateIssue($input: CreateIssueInput!) {
       createIssue(input: $input) {
         issue {
@@ -263,7 +272,7 @@ repository(name: $repository, owner: $owner) {
             input: {
                 repositoryId: repoInfoData.id,
                 milestoneId: milestoneId,
-                labelIds: [create_label?.id],
+                labelIds,
                 title: title ?? 'New Feedback (wo title...)',
                 body: body,
             },

package/esm/sqlAdmin/SqlAdminController.js

@@ -21,17 +21,14 @@ export class SqlAdminController {
         const db = SqlAdminController.dp ?? SqlDatabase.getDb();
         const start = performance.now();
         let rows = [];
-        if (notReadOnly) {
-            rows = (await db.execute(cmd)).rows;
-        }
-        else {
-            await db.transaction(async (tx) => {
-                const txDb = SqlDatabase.getDb(tx);
-                // Postgres: makes the whole transaction reject writes at the DB level.
+        // One transaction either way: a failing multi-statement script leaves nothing behind.
+        await db.transaction(async (tx) => {
+            const txDb = SqlDatabase.getDb(tx);
+            // Postgres: makes the whole transaction reject writes at the DB level.
+            if (!notReadOnly)
                 await txDb.execute('SET TRANSACTION READ ONLY');
-                rows = (await txDb.execute(cmd)).rows;
-            });
-        }
+            rows = (await txDb.execute(cmd)).rows;
+        });
         const took = performance.now() - start;
         return { rows, rowCount: rows.length, took };
     }
@@ -40,5 +37,8 @@ __decorate([
     BackendMethod({
         allowed: [Roles_SqlAdmin.SqlAdmin_Admin, FF_Role.FF_Role_Admin],
         apiPrefix: 'ff/sqlAdmin',
+        // Remult wraps BackendMethods in a transaction by default; ours would then be
+        // nested, which Postgres rejects. We open our own below instead.
+        transactional: false,
     })
 ], SqlAdminController, "exec", null);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "firstly",
-  "version": "0.9.1",
+  "version": "0.9.3",
   "type": "module",
   "description": "Firstly, an opinionated Remult setup!",
   "funding": "https://github.com/sponsors/jycouet",