firstly 0.9.1 → 0.9.2

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # firstly
 
+## 0.9.2
+
+### Patch Changes
+
+- [#347](https://github.com/jycouet/firstly/pull/347) [`2a6576c`](https://github.com/jycouet/firstly/commit/2a6576ce7955ad73b38b3c07a3daf7c0fde78525) Thanks [@jycouet](https://github.com/jycouet)! - fix(sqlAdmin): read-only queries no longer fail with "nested transactions not allowed" on Postgres
+
 ## 0.9.1
 
 ### Patch Changes

package/esm/sqlAdmin/SqlAdminController.js

@@ -21,17 +21,14 @@ export class SqlAdminController {
         const db = SqlAdminController.dp ?? SqlDatabase.getDb();
         const start = performance.now();
         let rows = [];
-        if (notReadOnly) {
-            rows = (await db.execute(cmd)).rows;
-        }
-        else {
-            await db.transaction(async (tx) => {
-                const txDb = SqlDatabase.getDb(tx);
-                // Postgres: makes the whole transaction reject writes at the DB level.
+        // One transaction either way: a failing multi-statement script leaves nothing behind.
+        await db.transaction(async (tx) => {
+            const txDb = SqlDatabase.getDb(tx);
+            // Postgres: makes the whole transaction reject writes at the DB level.
+            if (!notReadOnly)
                 await txDb.execute('SET TRANSACTION READ ONLY');
-                rows = (await txDb.execute(cmd)).rows;
-            });
-        }
+            rows = (await txDb.execute(cmd)).rows;
+        });
         const took = performance.now() - start;
         return { rows, rowCount: rows.length, took };
     }
@@ -40,5 +37,8 @@ __decorate([
     BackendMethod({
         allowed: [Roles_SqlAdmin.SqlAdmin_Admin, FF_Role.FF_Role_Admin],
         apiPrefix: 'ff/sqlAdmin',
+        // Remult wraps BackendMethods in a transaction by default; ours would then be
+        // nested, which Postgres rejects. We open our own below instead.
+        transactional: false,
     })
 ], SqlAdminController, "exec", null);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "firstly",
-  "version": "0.9.1",
+  "version": "0.9.2",
   "type": "module",
   "description": "Firstly, an opinionated Remult setup!",
   "funding": "https://github.com/sponsors/jycouet",