first-base 0.1.2 → 0.2.0

package/README.md

@@ -21,7 +21,7 @@ test("something", async () => {
 
 ### `spawn(command: string, args?: Array<string>, options?: Object) => RunContext`
 
-`args` and `options` are the same as [child_process.spawn](https://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options), except you can also put `pty: true` in `options` to launch the process using a psuedoterminal (useful for testing color output).
+`args` and `options` are the same as [child_process.spawn](https://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options).
 
 Returns a `RunContext` object; see below.
 

package/dist/index.d.ts

@@ -8,7 +8,6 @@ export type Options = {
   shell?: boolean | string;
   windowsVerbatimArguments?: boolean;
   windowsHide?: boolean;
-  pty?: boolean;
 };
 
 export type RunContext = {

package/dist/index.js

@@ -4,8 +4,6 @@ function _typeof(obj) { if (typeof Symbol === "function" && typeof Symbol.iterat
 
 var normalSpawn = require("child_process").spawn;
 
-var ptySpawn = require("node-pty").spawn;
-
 var stripAnsi = require("strip-ansi"); // Run a child process and return a "run context" object
 // to interact with it. Function signature is the same as
 // child_process spawn, except you can pass `pty: true` in
@@ -114,12 +112,7 @@ var spawn = function spawn(cmd, argsOrOptions, passedOptions) {
   };
 
   if (options.pty) {
-    child = ptySpawn(cmd, args, options);
-    stdin = child;
-    stdout = child;
-    stderr = null; // no way to tell between stdout and stderr with pty
-
-    unreffable = child.socket;
+    throw new Error("pty mode is no longer supported due to lack of support for new node.js versions in the node-pty module");
   } else {
     child = normalSpawn(cmd, args, options);
     stdin = child.stdin;
@@ -145,15 +138,26 @@ var spawn = function spawn(cmd, argsOrOptions, passedOptions) {
   };
 
   stdout.setEncoding("utf-8");
-  stdout.on("data", function (data) {
+
+  var handleStdoutData = function handleStdoutData(data) {
     runContext.result.stdout += data;
     outputContainsBuffer += data;
     debugLog("STDOUT: ".concat(data.toString()));
     checkForPendingOutputRequestsToResolve();
-  });
+  };
+
+  if (stdout.onData) {
+    // the pty instance returned by node-pty
+    // requires attaching handlers differently
+    stdout.onData(handleStdoutData);
+  } else {
+    stdout.on("data", handleStdoutData);
+  }
 
   if (stderr) {
-    stderr.setEncoding("utf-8");
+    stderr.setEncoding("utf-8"); // this is never a pty instance,
+    // so we don't need to deal with onData here:
+
     stderr.on("data", function (data) {
       runContext.result.stderr += data;
       outputContainsBuffer += data;

package/dist/index.js.flow

@@ -9,7 +9,6 @@ export type Options = {
   shell?: ?boolean | string,
   windowsVerbatimArguments?: ?boolean,
   windowsHide?: ?boolean,
-  pty?: ?boolean,
 };
 
 export type RunContext = {

package/package.json

@@ -1,13 +1,12 @@
 {
   "name": "first-base",
-  "version": "0.1.2",
+  "version": "0.2.0",
   "description": "Integration testing for CLI applications",
   "main": "dist/index.js",
   "repository": "https://github.com/suchipi/first-base",
   "author": "Lily Scott <me@suchipi.com>",
   "license": "MIT",
   "dependencies": {
-    "node-pty": "^0.8.0",
     "strip-ansi": "^5.0.0"
   },
   "devDependencies": {