firebase-tools 9.23.2 → 10.0.0

package/CHANGELOG.md

@@ -1,7 +1,5 @@
-- Fixes issue when installing a Firebase Extension where secrets would be created before validation.
-- Fixes issue with filtering on a specific storage bucket using functions in the emulator. (#3893)
-- Fixes check in Cloud Functions for Firebase initialization to check for API enablement before trying to enable them. (#2574)
-- No longer tries to clean up function build images from Artifact Registry when Artifact Registry is not enabled. (#3943)
-- Show error message when running `firebase init hosting:github` with no Hosting config in `firebase.json`. (#3113)
-- Fixes issue where `remoteconfig:get` was not fetching the latest version by default. (#3559)
-- Fixes issue where empty variables in .env files would instead read as multi-line values. (#3934)
+- **BREAKING** Drops support for running the CLI on Node 10.
+- **BREAKING** Replaces all usages of `-y`, `--yes`, or `--confirm` with `-f` and `--force`.
+- **BREAKING** Function deploys upload source to the deployed region instead of us-central1.
+- Requires firebase-functions >= 3.13.1 in Functions emulator to include bug fixes (#3851).
+- Updates default functions runtime to Node.js 16.

package/lib/api.js

@@ -93,7 +93,6 @@ var api = {
     functionsOrigin: utils.envOverride("FIREBASE_FUNCTIONS_URL", "https://cloudfunctions.googleapis.com"),
     functionsV2Origin: utils.envOverride("FIREBASE_FUNCTIONS_V2_URL", "https://cloudfunctions.googleapis.com"),
     runOrigin: utils.envOverride("CLOUD_RUN_URL", "https://run.googleapis.com"),
-    functionsUploadRegion: utils.envOverride("FIREBASE_FUNCTIONS_UPLOAD_REGION", "us-central1"),
     functionsDefaultRegion: utils.envOverride("FIREBASE_FUNCTIONS_DEFAULT_REGION", "us-central1"),
     cloudschedulerOrigin: utils.envOverride("FIREBASE_CLOUDSCHEDULER_URL", "https://cloudscheduler.googleapis.com"),
     cloudTasksOrigin: utils.envOverride("FIREBASE_CLOUD_TAKS_URL", "https://cloudtasks.googleapis.com"),

package/lib/commands/database-remove.js

@@ -14,7 +14,7 @@ const clc = require("cli-color");
 const _ = require("lodash");
 module.exports = new command_1.Command("database:remove <path>")
     .description("remove data from your Firebase at the specified path")
-    .option("-y, --confirm", "pass this option to bypass confirmation prompt")
+    .option("-f, --force", "pass this option to bypass confirmation prompt")
     .option("--instance <instance>", "use the database <instance>.firebaseio.com (if omitted, use default database instance)")
     .before(requirePermissions_1.requirePermissions, ["firebasedatabase.instances.update"])
     .before(requireDatabaseInstance_1.requireDatabaseInstance)
@@ -28,7 +28,7 @@ module.exports = new command_1.Command("database:remove <path>")
     const databaseUrl = utils.getDatabaseUrl(origin, options.instance, path);
     const confirm = await prompt_1.promptOnce({
         type: "confirm",
-        name: "confirm",
+        name: "force",
         default: false,
         message: "You are about to remove all data at " + clc.cyan(databaseUrl) + ". Are you sure?",
     }, options);

package/lib/commands/database-set.js

@@ -19,7 +19,7 @@ const utils = require("../utils");
 exports.default = new command_1.Command("database:set <path> [infile]")
     .description("store JSON data at the specified path via STDIN, arg, or file")
     .option("-d, --data <data>", "specify escaped JSON directly")
-    .option("-y, --confirm", "pass this option to bypass confirmation prompt")
+    .option("-f, --force", "pass this option to bypass confirmation prompt")
     .option("--instance <instance>", "use the database <instance>.firebaseio.com (if omitted, use default database instance)")
     .before(requirePermissions_1.requirePermissions, ["firebasedatabase.instances.update"])
     .before(requireDatabaseInstance_1.requireDatabaseInstance)
@@ -34,7 +34,7 @@ exports.default = new command_1.Command("database:set <path> [infile]")
     const dbJsonURL = new url_1.URL(utils.getDatabaseUrl(origin, options.instance, path + ".json"));
     const confirm = await prompt_1.promptOnce({
         type: "confirm",
-        name: "confirm",
+        name: "force",
         default: false,
         message: "You are about to overwrite all data at " + clc.cyan(dbPath) + ". Are you sure?",
     }, options);

package/lib/commands/database-update.js

@@ -18,7 +18,7 @@ const utils = require("../utils");
 exports.default = new command_1.Command("database:update <path> [infile]")
     .description("update some of the keys for the defined path in your Firebase")
     .option("-d, --data <data>", "specify escaped JSON directly")
-    .option("-y, --confirm", "pass this option to bypass confirmation prompt")
+    .option("-f, --force", "pass this option to bypass confirmation prompt")
     .option("--instance <instance>", "use the database <instance>.firebaseio.com (if omitted, use default database instance)")
     .before(requirePermissions_1.requirePermissions, ["firebasedatabase.instances.update"])
     .before(requireDatabaseInstance_1.requireDatabaseInstance)
@@ -32,7 +32,7 @@ exports.default = new command_1.Command("database:update <path> [infile]")
     const url = utils.getDatabaseUrl(origin, options.instance, path);
     const confirmed = await prompt_1.promptOnce({
         type: "confirm",
-        name: "confirm",
+        name: "force",
         default: false,
         message: `You are about to modify data at ${clc.cyan(url)}. Are you sure?`,
     }, options);

package/lib/commands/firestore-delete.js

@@ -54,7 +54,7 @@ module.exports = new command_1.Command("firestore:delete [path]")
     "subcollections. May not be passed along with -r.")
     .option("--all-collections", "Delete all. Deletes the entire Firestore database, " +
     "including all collections and documents. Any other flags or arguments will be ignored.")
-    .option("-y, --yes", "No confirmation. Otherwise, a confirmation prompt will appear.")
+    .option("-f, --force", "No confirmation. Otherwise, a confirmation prompt will appear.")
     .before(commandUtils_1.printNoticeIfEmulated, types_1.Emulators.FIRESTORE)
     .before(requirePermissions_1.requirePermissions, ["datastore.entities.list", "datastore.entities.delete"])
     .action(async (path, options) => {
@@ -68,7 +68,7 @@ module.exports = new command_1.Command("firestore:delete [path]")
     });
     const confirm = await prompt_1.promptOnce({
         type: "confirm",
-        name: "yes",
+        name: "force",
         default: false,
         message: getConfirmationMessage(deleteOp, options),
     }, options);

package/lib/commands/hosting-disable.js

@@ -10,7 +10,7 @@ const requirePermissions_1 = require("../requirePermissions");
 const utils = require("../utils");
 exports.default = new command_1.Command("hosting:disable")
     .description("stop serving web traffic to your Firebase Hosting site")
-    .option("-y, --confirm", "skip confirmation")
+    .option("-f, --force", "skip confirmation")
     .option("-s, --site <siteName>", "the site to disable")
     .before(requirePermissions_1.requirePermissions, ["firebasehosting.sites.update"])
     .before(requireHostingSite_1.requireHostingSite)
@@ -18,9 +18,9 @@ exports.default = new command_1.Command("hosting:disable")
     const siteToDisable = options.site;
     const confirm = await prompt_1.promptOnce({
         type: "confirm",
-        name: "confirm",
+        name: "force",
         message: `Are you sure you want to disable Firebase Hosting for the site ${clc.underline(siteToDisable)}\n${clc.underline("This will immediately make your site inaccessible!")}`,
-    });
+    }, options);
     if (!confirm) {
         return;
     }

package/lib/deploy/functions/deploy.js

@@ -5,18 +5,16 @@ const tmp_1 = require("tmp");
 const clc = require("cli-color");
 const fs = require("fs");
 const checkIam_1 = require("./checkIam");
-const api_1 = require("../../api");
 const utils_1 = require("../../utils");
 const gcs = require("../../gcp/storage");
 const gcf = require("../../gcp/cloudfunctions");
 const gcfv2 = require("../../gcp/cloudfunctionsv2");
 const utils = require("../../utils");
 const backend = require("./backend");
-const GCP_REGION = api_1.functionsUploadRegion;
 tmp_1.setGracefulCleanup();
-async function uploadSourceV1(context) {
-    const uploadUrl = await gcf.generateUploadUrl(context.projectId, GCP_REGION);
-    context.uploadUrl = uploadUrl;
+async function uploadSourceV1(context, region) {
+    const uploadUrl = await gcf.generateUploadUrl(context.projectId, region);
+    context.sourceUrl = uploadUrl;
     const uploadOpts = {
         file: context.functionsSourceV1,
         stream: fs.createReadStream(context.functionsSourceV1),
@@ -45,8 +43,9 @@ async function deploy(context, options, payload) {
     try {
         const want = payload.functions.backend;
         const uploads = [];
-        if (backend.allEndpoints(want).some((endpoint) => endpoint.platform === "gcfv1")) {
-            uploads.push(uploadSourceV1(context));
+        const v1Endpoints = backend.allEndpoints(want).filter((e) => e.platform === "gcfv1");
+        if (v1Endpoints.length > 0) {
+            uploads.push(uploadSourceV1(context, v1Endpoints[0].region));
         }
         for (const region of Object.keys(want.endpoints)) {
             if (backend.regionalEndpoints(want, region).some((e) => e.platform === "gcfv2")) {

package/lib/deploy/functions/release/index.js

@@ -37,7 +37,7 @@ async function release(context, options, payload) {
     const fab = new fabricator.Fabricator({
         functionExecutor,
         executor: new executor.QueueExecutor({}),
-        sourceUrl: context.uploadUrl,
+        sourceUrl: context.sourceUrl,
         storage: context.storage,
         appEngineLocation: functionsConfig_1.getAppEngineLocation(context.firebaseConfig),
     });

package/lib/deploy/functions/runtimes/node/parseRuntimeAndValidateSDK.js

@@ -18,7 +18,7 @@ const ENGINE_RUNTIMES = {
 const ENGINE_RUNTIMES_NAMES = Object.values(ENGINE_RUNTIMES);
 exports.RUNTIME_NOT_SET = "`runtime` field is required but was not found in firebase.json.\n" +
     "To fix this, add the following lines to the `functions` section of your firebase.json:\n" +
-    '"runtime": "nodejs14"\n';
+    '"runtime": "nodejs16"\n';
 exports.UNSUPPORTED_NODE_VERSION_FIREBASE_JSON_MSG = clc.bold(`functions.runtime value is unsupported. ` +
     `Valid choices are: ${clc.bold("nodejs{10|12|14|16}")}.`);
 exports.UNSUPPORTED_NODE_VERSION_PACKAGE_JSON_MSG = clc.bold(`package.json in functions directory has an engines field which is unsupported. ` +

package/lib/emulator/functionsEmulatorRuntime.js

@@ -135,7 +135,7 @@ async function assertResolveDeveloperNodeModule(frb, name) {
 async function verifyDeveloperNodeModules(frb) {
     const modBundles = [
         { name: "firebase-admin", isDev: false, minVersion: "8.9.0" },
-        { name: "firebase-functions", isDev: false, minVersion: "3.3.0" },
+        { name: "firebase-functions", isDev: false, minVersion: "3.13.1" },
     ];
     for (const modBundle of modBundles) {
         const resolution = await resolveDeveloperNodeModule(frb, modBundle.name);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "firebase-tools",
-  "version": "9.23.2",
+  "version": "10.0.0",
   "description": "Command-Line Interface for Firebase",
   "main": "./lib/index.js",
   "bin": {
@@ -55,7 +55,7 @@
   ],
   "preferGlobal": true,
   "engines": {
-    "node": ">= 10.13"
+    "node": ">= 12"
   },
   "author": "Firebase (https://firebase.google.com/)",
   "license": "MIT",

package/templates/init/functions/javascript/package.lint.json

@@ -10,7 +10,7 @@
     "logs": "firebase functions:log"
   },
   "engines": {
-    "node": "14"
+    "node": "16"
   },
   "main": "index.js",
   "dependencies": {

package/templates/init/functions/javascript/package.nolint.json

@@ -9,7 +9,7 @@
     "logs": "firebase functions:log"
   },
   "engines": {
-    "node": "14"
+    "node": "16"
   },
   "main": "index.js",
   "dependencies": {

package/templates/init/functions/typescript/package.lint.json

@@ -10,7 +10,7 @@
     "logs": "firebase functions:log"
   },
   "engines": {
-    "node": "14"
+    "node": "16"
   },
   "main": "lib/index.js",
   "dependencies": {

package/templates/init/functions/typescript/package.nolint.json

@@ -9,7 +9,7 @@
     "logs": "firebase functions:log"
   },
   "engines": {
-    "node": "14"
+    "node": "16"
   },
   "main": "lib/index.js",
   "dependencies": {