firebase-tools 9.19.0 → 9.23.0

package/CHANGELOG.md

@@ -1,3 +1 @@
-- `ext:dev:publish` and `ext:update` now support --force and --non-interactive flags.
-- Fixes issue where account specified by `login:use` was not being correctly loaded (#3759).
-- Fixes minor layout issues in Auth Emulator IDP sign-in page (#3774).
+- `firebase deploy --only extensions` now supports project specifc .env files. When deploying to multiple projects, param values that are different between projects can be put in `extensions/${extensionInstanceId}.env.${projectIdOrAlias}` and common param values can be put in `extensions/${extensionInstanceId}.env`.

package/lib/api.js

@@ -72,6 +72,7 @@ var api = {
     cloudbillingOrigin: utils.envOverride("FIREBASE_CLOUDBILLING_URL", "https://cloudbilling.googleapis.com"),
     cloudloggingOrigin: utils.envOverride("FIREBASE_CLOUDLOGGING_URL", "https://logging.googleapis.com"),
     containerRegistryDomain: utils.envOverride("CONTAINER_REGISTRY_DOMAIN", "gcr.io"),
+    artifactRegistryDomain: utils.envOverride("ARTIFACT_REGISTRY_DOMAIN", "https://artifactregistry.googleapis.com"),
     appDistributionOrigin: utils.envOverride("FIREBASE_APP_DISTRIBUTION_URL", "https://firebaseappdistribution.googleapis.com"),
     appengineOrigin: utils.envOverride("FIREBASE_APPENGINE_URL", "https://appengine.googleapis.com"),
     authOrigin: utils.envOverride("FIREBASE_AUTH_URL", "https://accounts.google.com"),
@@ -95,6 +96,7 @@ var api = {
     functionsUploadRegion: utils.envOverride("FIREBASE_FUNCTIONS_UPLOAD_REGION", "us-central1"),
     functionsDefaultRegion: utils.envOverride("FIREBASE_FUNCTIONS_DEFAULT_REGION", "us-central1"),
     cloudschedulerOrigin: utils.envOverride("FIREBASE_CLOUDSCHEDULER_URL", "https://cloudscheduler.googleapis.com"),
+    cloudTasksOrigin: utils.envOverride("FIREBASE_CLOUD_TAKS_URL", "https://cloudtasks.googleapis.com"),
     pubsubOrigin: utils.envOverride("FIREBASE_PUBSUB_URL", "https://pubsub.googleapis.com"),
     googleOrigin: utils.envOverride("FIREBASE_TOKEN_URL", utils.envOverride("FIREBASE_GOOGLE_URL", "https://www.googleapis.com")),
     hostingOrigin: utils.envOverride("FIREBASE_HOSTING_URL", "https://web.app"),
@@ -115,6 +117,7 @@ var api = {
     serviceUsageOrigin: utils.envOverride("FIREBASE_SERVICE_USAGE_URL", "https://serviceusage.googleapis.com"),
     githubOrigin: utils.envOverride("GITHUB_URL", "https://github.com"),
     githubApiOrigin: utils.envOverride("GITHUB_API_URL", "https://api.github.com"),
+    secretManagerOrigin: utils.envOverride("CLOUD_SECRET_MANAGER_URL", "https://secretmanager.googleapis.com"),
     githubClientId: utils.envOverride("GITHUB_CLIENT_ID", "89cf50f02ac6aaed3484"),
     githubClientSecret: utils.envOverride("GITHUB_CLIENT_SECRET", "3330d14abc895d9a74d5f17cd7a00711fa2c5bf0"),
     setRefreshToken: function (token) {

package/lib/apiv2.js

@@ -118,8 +118,10 @@ class Client {
             reqOptions.headers.set("User-Agent", `FirebaseCLI/${CLI_VERSION}`);
         }
         reqOptions.headers.set("X-Client-Version", `FirebaseCLI/${CLI_VERSION}`);
-        if (reqOptions.responseType === "json") {
-            reqOptions.headers.set("Content-Type", "application/json");
+        if (!reqOptions.headers.has("Content-Type")) {
+            if (reqOptions.responseType === "json") {
+                reqOptions.headers.set("Content-Type", "application/json");
+            }
         }
         return reqOptions;
     }
@@ -217,11 +219,12 @@ class Client {
         }
         let body;
         if (options.responseType === "json") {
-            if (res.status === 204) {
+            const text = await res.text();
+            if (!text.length) {
                 body = undefined;
             }
             else {
-                body = (await res.json());
+                body = JSON.parse(text);
             }
         }
         else if (options.responseType === "stream") {

package/lib/commands/crashlytics-symbols-upload.js

@@ -0,0 +1,146 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const fs = require("fs-extra");
+const os = require("os");
+const path = require("path");
+const spawn = require("cross-spawn");
+const uuid = require("uuid");
+const command_1 = require("../command");
+const downloadUtils = require("../downloadUtils");
+const error_1 = require("../error");
+const logger_1 = require("../logger");
+const rimraf = require("rimraf");
+const utils = require("../utils");
+var SymbolGenerator;
+(function (SymbolGenerator) {
+    SymbolGenerator["breakpad"] = "breakpad";
+    SymbolGenerator["csym"] = "csym";
+})(SymbolGenerator || (SymbolGenerator = {}));
+const SYMBOL_CACHE_ROOT_DIR = process.env.FIREBASE_CRASHLYTICS_CACHE_PATH || os.tmpdir();
+const JAR_CACHE_DIR = process.env.FIREBASE_CRASHLYTICS_BUILDTOOLS_PATH ||
+    path.join(os.homedir(), ".cache", "firebase", "crashlytics", "buildtools");
+const JAR_VERSION = "2.8.0";
+const JAR_URL = `https://dl.google.com/android/maven2/com/google/firebase/firebase-crashlytics-buildtools/${JAR_VERSION}/firebase-crashlytics-buildtools-${JAR_VERSION}.jar`;
+exports.default = new command_1.Command("crashlytics:symbols:upload <symbolFiles...>")
+    .description("Upload symbols for native code, to symbolicate stack traces.")
+    .option("--app <appID>", "the app id of your Firebase app")
+    .option("--generator [breakpad|csym]", "the symbol generator being used, defaults to breakpad.")
+    .option("--dry-run", "generate symbols without uploading them")
+    .option("--debug", "print debug output and logging from the underlying uploader tool")
+    .action(async (symbolFiles, options) => {
+    const app = getGoogleAppID(options) || "";
+    const generator = getSymbolGenerator(options);
+    const dryRun = !!options.dryRun;
+    const debug = !!options.debug;
+    let jarFile = await downloadBuiltoolsJar();
+    if (process.env.LOCAL_JAR) {
+        jarFile = process.env.LOCAL_JAR;
+    }
+    const jarOptions = {
+        jarFile,
+        app,
+        generator,
+        cachePath: path.join(SYMBOL_CACHE_ROOT_DIR, `crashlytics-${uuid.v4()}`, "nativeSymbols", app.replace(/:/g, "-"), generator),
+        symbolFile: "",
+        generate: true,
+    };
+    for (const symbolFile of symbolFiles) {
+        utils.logBullet(`Generating symbols for ${symbolFile}`);
+        const generateArgs = buildArgs(Object.assign(Object.assign({}, jarOptions), { symbolFile }));
+        const output = runJar(generateArgs, debug);
+        if (output.length > 0) {
+            utils.logBullet(output);
+        }
+        else {
+            utils.logBullet(`Generated symbols for ${symbolFile}`);
+            utils.logBullet(`Output Path: ${jarOptions.cachePath}`);
+        }
+    }
+    if (dryRun) {
+        utils.logBullet("Skipping upload because --dry-run was passed");
+        return;
+    }
+    utils.logBullet(`Uploading all generated symbols`);
+    const uploadArgs = buildArgs(Object.assign(Object.assign({}, jarOptions), { generate: false }));
+    const output = runJar(uploadArgs, debug);
+    if (output.length > 0) {
+        utils.logBullet(output);
+    }
+    else {
+        utils.logBullet("Successfully uploaded all symbols");
+    }
+});
+function getGoogleAppID(options) {
+    if (!options.app) {
+        throw new error_1.FirebaseError("set the --app option to a valid Firebase app id and try again");
+    }
+    return options.app;
+}
+function getSymbolGenerator(options) {
+    if (!options.generator) {
+        return SymbolGenerator.breakpad;
+    }
+    if (!Object.values(SymbolGenerator).includes(options.generator)) {
+        throw new error_1.FirebaseError('--symbol-generator should be set to either "breakpad" or "csym"');
+    }
+    return options.generator;
+}
+async function downloadBuiltoolsJar() {
+    const jarPath = path.join(JAR_CACHE_DIR, `crashlytics-buildtools-${JAR_VERSION}.jar`);
+    if (fs.existsSync(jarPath)) {
+        logger_1.logger.debug(`Buildtools Jar already downloaded at ${jarPath}`);
+        return jarPath;
+    }
+    if (fs.existsSync(JAR_CACHE_DIR)) {
+        logger_1.logger.debug(`Deleting Jar cache at ${JAR_CACHE_DIR} because the CLI was run with a newer Jar version`);
+        rimraf.sync(JAR_CACHE_DIR);
+    }
+    utils.logBullet("Downloading buildtools.jar to " + jarPath);
+    utils.logBullet("For open source licenses used by this command, look in the META-INF directory in the buildtools.jar file");
+    const tmpfile = await downloadUtils.downloadToTmp(JAR_URL);
+    fs.mkdirSync(JAR_CACHE_DIR, { recursive: true });
+    fs.copySync(tmpfile, jarPath);
+    return jarPath;
+}
+function buildArgs(options) {
+    const baseArgs = [
+        "-jar",
+        options.jarFile,
+        `-symbolGenerator=${options.generator}`,
+        `-symbolFileCacheDir=${options.cachePath}`,
+        "-verbose",
+    ];
+    if (options.generate) {
+        return baseArgs.concat(["-generateNativeSymbols", `-unstrippedLibrary=${options.symbolFile}`]);
+    }
+    return baseArgs.concat([
+        "-uploadNativeSymbols",
+        `-googleAppId=${options.app}`,
+    ]);
+}
+function runJar(args, debug) {
+    var _a, _b, _c;
+    const outputs = spawn.sync("java", args, {
+        stdio: debug ? "inherit" : "pipe",
+    });
+    if (outputs.status || 0 > 0) {
+        if (!debug) {
+            utils.logWarning(((_a = outputs.stdout) === null || _a === void 0 ? void 0 : _a.toString()) || "An unknown error occurred");
+        }
+        throw new error_1.FirebaseError("Failed to upload symbols");
+    }
+    if (!debug) {
+        let logRegex = /(Generated symbol file.*$)/m;
+        let matched = (((_b = outputs.stdout) === null || _b === void 0 ? void 0 : _b.toString()) || "").match(logRegex);
+        if (matched) {
+            return matched[1];
+        }
+        logRegex = /(Crashlytics symbol file uploaded successfully.*$)/m;
+        matched = (((_c = outputs.stdout) === null || _c === void 0 ? void 0 : _c.toString()) || "").match(logRegex);
+        if (matched) {
+            return matched[1];
+        }
+        return "";
+    }
+    return "";
+}

package/lib/commands/deploy.js

@@ -9,7 +9,15 @@ const deploy = require("../deploy");
 const requireConfig = require("../requireConfig");
 const { filterTargets } = require("../filterTargets");
 const { requireHostingSite } = require("../requireHostingSite");
-const VALID_TARGETS = ["database", "storage", "firestore", "functions", "hosting", "remoteconfig"];
+const VALID_TARGETS = [
+    "database",
+    "storage",
+    "firestore",
+    "functions",
+    "hosting",
+    "remoteconfig",
+    "extensions",
+];
 const TARGET_PERMISSIONS = {
     database: ["firebasedatabase.instances.update"],
     hosting: ["firebasehosting.sites.update"],

package/lib/commands/ext-configure.js

@@ -52,6 +52,8 @@ exports.default = new command_1.Command("ext:configure <extensionInstanceId>")
             paramSpecs: paramSpecWithNewDefaults,
             nonInteractive: options.nonInteractive,
             paramsEnvPath: options.params,
+            instanceId,
+            reconfiguring: true,
         });
         if (immutableParams.length) {
             const plural = immutableParams.length > 1;
@@ -67,7 +69,7 @@ exports.default = new command_1.Command("ext:configure <extensionInstanceId>")
                 ", uninstall the extension, then install a new instance of this extension.");
         }
         spinner.start();
-        const res = await extensionsApi.configureInstance(projectId, instanceId, params);
+        const res = await extensionsApi.configureInstance({ projectId, instanceId, params });
         spinner.stop();
         utils.logLabeledSuccess(extensionsHelper_1.logPrefix, `successfully configured ${clc.bold(instanceId)}.`);
         utils.logLabeledBullet(extensionsHelper_1.logPrefix, marked(`You can view your reconfigured instance in the Firebase console: ${utils.consoleUrl(projectId, `/extensions/instances/${instanceId}?tab=config`)}`));

package/lib/commands/ext-dev-deprecate.js

@@ -0,0 +1,63 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const clc = require("cli-color");
+const semver = require("semver");
+const refs = require("../extensions/refs");
+const utils = require("../utils");
+const command_1 = require("../command");
+const prompt_1 = require("../prompt");
+const extensionsHelper_1 = require("../extensions/extensionsHelper");
+const extensionsApi_1 = require("../extensions/extensionsApi");
+const versionHelper_1 = require("../extensions/versionHelper");
+const requireAuth_1 = require("../requireAuth");
+const error_1 = require("../error");
+exports.default = new command_1.Command("ext:dev:deprecate <extensionRef> <versionPredicate>")
+    .description("deprecate extension versions that match the version predicate")
+    .option("-m, --message <deprecationMessage>", "deprecation message")
+    .option("-f, --force", "override deprecation message for existing deprecated extension versions that match")
+    .before(requireAuth_1.requireAuth)
+    .before(extensionsHelper_1.ensureExtensionsApiEnabled)
+    .action(async (extensionRef, versionPredicate, options) => {
+    const { publisherId, extensionId, version } = refs.parse(extensionRef);
+    if (version) {
+        throw new error_1.FirebaseError(`The input extension reference must be of the format ${clc.bold("<publisherId>/<extensionId>")}. Version should be supplied in the version predicate argument.`);
+    }
+    if (!publisherId || !extensionId) {
+        throw new error_1.FirebaseError(`Error parsing publisher ID and extension ID from extension reference '${clc.bold(extensionRef)}'. Please use the format '${clc.bold("<publisherId>/<extensionId>")}'.`);
+    }
+    const { comparator, targetSemVer } = versionHelper_1.parseVersionPredicate(versionPredicate);
+    const filter = `id${comparator}"${targetSemVer}"`;
+    const extensionVersions = await extensionsApi_1.listExtensionVersions(extensionRef, filter);
+    const filteredExtensionVersions = extensionVersions
+        .sort((ev1, ev2) => {
+        return -semver.compare(ev1.spec.version, ev2.spec.version);
+    })
+        .filter((extensionVersion) => {
+        if (extensionVersion.state === "DEPRECATED" && !options.force) {
+            return false;
+        }
+        const message = extensionVersion.state === "DEPRECATED" ? ", will overwrite deprecation message" : "";
+        utils.logLabeledBullet(extensionVersion.ref, extensionVersion.state + message);
+        return true;
+    });
+    if (filteredExtensionVersions.length > 0) {
+        if (!options.force) {
+            const confirmMessage = "You are about to deprecate these extension version(s). Do you wish to continue?";
+            const consent = await prompt_1.promptOnce({
+                type: "confirm",
+                message: confirmMessage,
+                default: false,
+            });
+            if (!consent) {
+                throw new error_1.FirebaseError("Deprecation canceled.");
+            }
+        }
+    }
+    else {
+        throw new error_1.FirebaseError("No extension versions matched the version predicate.");
+    }
+    await utils.allSettled(filteredExtensionVersions.map(async (extensionVersion) => {
+        await extensionsApi_1.deprecateExtensionVersion(extensionVersion.ref, options.deprecationMessage);
+    }));
+    utils.logLabeledSuccess(extensionsHelper_1.logPrefix, "successfully deprecated extension version(s).");
+});

package/lib/commands/ext-dev-undeprecate.js

@@ -0,0 +1,56 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const clc = require("cli-color");
+const semver = require("semver");
+const refs = require("../extensions/refs");
+const utils = require("../utils");
+const command_1 = require("../command");
+const prompt_1 = require("../prompt");
+const extensionsHelper_1 = require("../extensions/extensionsHelper");
+const extensionsApi_1 = require("../extensions/extensionsApi");
+const versionHelper_1 = require("../extensions/versionHelper");
+const requireAuth_1 = require("../requireAuth");
+const error_1 = require("../error");
+exports.default = new command_1.Command("ext:dev:undeprecate <extensionRef> <versionPredicate>")
+    .description("undeprecate extension versions that match the version predicate")
+    .before(requireAuth_1.requireAuth)
+    .before(extensionsHelper_1.ensureExtensionsApiEnabled)
+    .action(async (extensionRef, versionPredicate, options) => {
+    const { publisherId, extensionId, version } = refs.parse(extensionRef);
+    if (version) {
+        throw new error_1.FirebaseError(`The input extension reference must be of the format ${clc.bold("<publisherId>/<extensionId>")}. Version should be supplied in the version predicate argument.`);
+    }
+    if (!publisherId || !extensionId) {
+        throw new error_1.FirebaseError(`Error parsing publisher ID and extension ID from extension reference '${clc.bold(extensionRef)}'. Please use the format '${clc.bold("<publisherId>/<extensionId>")}'.`);
+    }
+    const { comparator, targetSemVer } = versionHelper_1.parseVersionPredicate(versionPredicate);
+    const filter = `id${comparator}"${targetSemVer}"`;
+    const extensionVersions = await extensionsApi_1.listExtensionVersions(extensionRef, filter);
+    extensionVersions
+        .sort((ev1, ev2) => {
+        return -semver.compare(ev1.spec.version, ev2.spec.version);
+    })
+        .forEach((extensionVersion) => {
+        utils.logLabeledBullet(extensionVersion.ref, extensionVersion.state);
+    });
+    if (extensionVersions.length > 0) {
+        if (!options.force) {
+            const confirmMessage = "You are about to undeprecate these extension version(s). Do you wish to continue?";
+            const consent = await prompt_1.promptOnce({
+                type: "confirm",
+                message: confirmMessage,
+                default: false,
+            });
+            if (!consent) {
+                throw new error_1.FirebaseError("Undeprecation canceled.");
+            }
+        }
+    }
+    else {
+        throw new error_1.FirebaseError("No extension versions matched the version predicate.");
+    }
+    await utils.allSettled(extensionVersions.map(async (extensionVersion) => {
+        await extensionsApi_1.undeprecateExtensionVersion(extensionVersion.ref);
+    }));
+    utils.logLabeledSuccess(extensionsHelper_1.logPrefix, "successfully undeprecated extension version(s).");
+});

package/lib/commands/ext-dev-unpublish.js

@@ -12,11 +12,12 @@ const error_1 = require("../error");
 const checkMinRequiredVersion_1 = require("../checkMinRequiredVersion");
 module.exports = new command_1.Command("ext:dev:unpublish <extensionRef>")
     .description("unpublish an extension")
+    .withForce()
     .help("use this command to unpublish an extension, and make it unavailable for developers to install or reconfigure. " +
     "Specify the extension you want to unpublish using the format '<publisherId>/<extensionId>.")
     .before(requireAuth_1.requireAuth)
     .before(checkMinRequiredVersion_1.checkMinRequiredVersion, "extDevMinVersion")
-    .action(async (extensionRef) => {
+    .action(async (extensionRef, options) => {
     const { publisherId, extensionId, version } = refs.parse(extensionRef);
     utils.logLabeledWarning(extensionsHelper_1.logPrefix, "If you unpublish this extension, developers won't be able to install it. For developers who currently have this extension installed, it will continue to run and will appear as unpublished when listed in the Firebase console or Firebase CLI.");
     utils.logLabeledWarning("This is a permanent action", `Once unpublished, you may never use the extension name '${clc.bold(extensionId)}' again.`);
@@ -24,14 +25,20 @@ module.exports = new command_1.Command("ext:dev:unpublish <extensionRef>")
         throw new error_1.FirebaseError(`Unpublishing a single version is not currently supported. You can only unpublish ${clc.bold("ALL versions")} of an extension. To unpublish all versions, please remove the version from the reference.`);
     }
     await extensionsApi_1.getExtension(extensionRef);
-    const consent = await comfirmUnpublish(publisherId, extensionId);
+    const consent = await comfirmUnpublish(publisherId, extensionId, options);
     if (!consent) {
         throw new error_1.FirebaseError("unpublishing cancelled.");
     }
     await extensionsApi_1.unpublishExtension(extensionRef);
     utils.logLabeledSuccess(extensionsHelper_1.logPrefix, "successfully unpublished all versions of this extension.");
 });
-async function comfirmUnpublish(publisherId, extensionId) {
+async function comfirmUnpublish(publisherId, extensionId, options) {
+    if (options.nonInteractive && !options.force) {
+        throw new error_1.FirebaseError("Pass the --force flag to use this command in non-interactive mode");
+    }
+    if (options.nonInteractive && options.force) {
+        return true;
+    }
     const message = `You are about to unpublish ALL versions of ${clc.green(`${publisherId}/${extensionId}`)}.\nDo you wish to continue? `;
     return prompt_1.promptOnce({
         type: "confirm",

package/lib/commands/ext-export.js

@@ -0,0 +1,44 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const checkMinRequiredVersion_1 = require("../checkMinRequiredVersion");
+const command_1 = require("../command");
+const planner = require("../deploy/extensions/planner");
+const export_1 = require("../extensions/export");
+const extensionsHelper_1 = require("../extensions/extensionsHelper");
+const functional_1 = require("../functional");
+const getProjectNumber_1 = require("../getProjectNumber");
+const logger_1 = require("../logger");
+const projectUtils_1 = require("../projectUtils");
+const prompt_1 = require("../prompt");
+const requirePermissions_1 = require("../requirePermissions");
+module.exports = new command_1.Command("ext:export")
+    .description("export all Extension instances installed on a project to a local Firebase directory")
+    .before(requirePermissions_1.requirePermissions, ["firebaseextensions.instances.list"])
+    .before(extensionsHelper_1.ensureExtensionsApiEnabled)
+    .before(checkMinRequiredVersion_1.checkMinRequiredVersion, "extMinVersion")
+    .withForce()
+    .action(async (options) => {
+    const projectId = projectUtils_1.needProjectId(options);
+    const projectNumber = await getProjectNumber_1.getProjectNumber(options);
+    const have = await Promise.all((await planner.have(projectId)).map(async (i) => {
+        const subbed = await export_1.setSecretParamsToLatest(i);
+        return export_1.parameterizeProject(projectId, projectNumber, subbed);
+    }));
+    if (have.length == 0) {
+        logger_1.logger.info(`No extension instances installed on ${projectId}, so there is nothing to export.`);
+        return;
+    }
+    const [withRef, withoutRef] = functional_1.partition(have, (s) => !!s.ref);
+    export_1.displayExportInfo(withRef, withoutRef);
+    if (!options.nonInteractive &&
+        !options.force &&
+        !(await prompt_1.promptOnce({
+            message: "Do you wish to add these Extension instances to firebase.json?",
+            type: "confirm",
+            default: true,
+        }))) {
+        logger_1.logger.info("Exiting. No changes made.");
+        return;
+    }
+    await export_1.writeFiles(withRef, options);
+});

package/lib/commands/ext-install.js

@@ -14,6 +14,7 @@ const command_1 = require("../command");
 const error_1 = require("../error");
 const projectUtils_1 = require("../projectUtils");
 const extensionsApi = require("../extensions/extensionsApi");
+const secretsUtils = require("../extensions/secretsUtils");
 const provisioningHelper = require("../extensions/provisioningHelper");
 const refs = require("../extensions/refs");
 const warnings_1 = require("../extensions/warnings");
@@ -37,7 +38,8 @@ async function installExtension(options) {
     const spinner = ora.default();
     try {
         await provisioningHelper.checkProductsProvisioned(projectId, spec);
-        if (spec.billingRequired) {
+        const usesSecrets = secretsUtils.usesSecrets(spec);
+        if (spec.billingRequired || usesSecrets) {
             const enabled = await cloudbilling_1.checkBillingEnabled(projectId);
             if (!enabled && nonInteractive) {
                 throw new error_1.FirebaseError(`This extension requires the Blaze plan, but project ${projectId} is not on the Blaze plan. ` +
@@ -45,12 +47,29 @@ async function installExtension(options) {
             }
             else if (!enabled) {
                 await billingMigrationHelper_1.displayNode10CreateBillingNotice(spec, false);
-                await checkProjectBilling_1.enableBilling(projectId, spec.displayName || spec.name);
+                await checkProjectBilling_1.enableBilling(projectId);
             }
             else {
                 await billingMigrationHelper_1.displayNode10CreateBillingNotice(spec, !nonInteractive);
             }
         }
+        const apis = spec.apis || [];
+        if (usesSecrets) {
+            apis.push({
+                apiName: "secretmanager.googleapis.com",
+                reason: `To access and manage secrets which are used by this extension. By using this product you agree to the terms and conditions of the following license: https://console.cloud.google.com/tos?id=cloud&project=${projectId}`,
+            });
+        }
+        if (apis.length) {
+            askUserForConsent.displayApis(spec.displayName || spec.name, projectId, apis);
+            const consented = await extensionsHelper_1.confirm({ nonInteractive, force, default: true });
+            if (!consented) {
+                throw new error_1.FirebaseError("Without explicit consent for the APIs listed, we cannot deploy this extension.");
+            }
+        }
+        if (usesSecrets) {
+            await secretsUtils.ensureSecretManagerApiEnabled(options);
+        }
         const roles = spec.roles ? spec.roles.map((role) => role.role) : [];
         if (roles.length) {
             await askUserForConsent.displayRoles(spec.displayName || spec.name, projectId, roles);
@@ -86,6 +105,7 @@ async function installExtension(options) {
                     paramSpecs: spec.params,
                     nonInteractive,
                     paramsEnvPath,
+                    instanceId,
                 });
                 spinner.text = "Installing your extension instance. This usually takes 3 to 5 minutes...";
                 spinner.start();
@@ -106,6 +126,7 @@ async function installExtension(options) {
                     paramSpecs: spec.params,
                     nonInteractive,
                     paramsEnvPath,
+                    instanceId,
                 });
                 spinner.text = "Updating your extension instance. This usually takes 3 to 5 minutes...";
                 spinner.start();
@@ -164,7 +185,7 @@ async function infoInstallByReference(extensionName) {
     }
     const extVersion = await extensionsApi.getExtensionVersion(extensionName);
     displayExtensionInfo_1.displayExtInfo(extensionName, ref.publisherId, extVersion.spec, true);
-    warnings_1.displayWarningPrompts(ref.publisherId, extension.registryLaunchStage, extVersion);
+    await warnings_1.displayWarningPrompts(ref.publisherId, extension.registryLaunchStage, extVersion);
     return extVersion;
 }
 exports.default = new command_1.Command("ext:install [extensionName]")

package/lib/commands/ext-uninstall.js

@@ -10,6 +10,7 @@ const command_1 = require("../command");
 const error_1 = require("../error");
 const projectUtils_1 = require("../projectUtils");
 const extensionsApi = require("../extensions/extensionsApi");
+const secretsUtils = require("../extensions/secretsUtils");
 const extensionsHelper_1 = require("../extensions/extensionsHelper");
 const prompt_1 = require("../prompt");
 const requirePermissions_1 = require("../requirePermissions");
@@ -51,11 +52,16 @@ exports.default = new command_1.Command("ext:uninstall <extensionInstanceId>")
     }
     if (!options.force) {
         const serviceAccountMessage = `Uninstalling deletes the service account used by this extension instance:\n${clc.bold(instance.serviceAccountEmail)}\n\n`;
+        const managedSecrets = await secretsUtils.getManagedSecrets(instance);
         const resourcesMessage = _.get(instance, "config.source.spec.resources", []).length
             ? "Uninstalling deletes all extension resources created for this extension instance:\n" +
                 instance.config.source.spec.resources
                     .map((resource) => clc.bold(`- ${extensionsHelper_1.resourceTypeToNiceName[resource.type] || resource.type}: ${resource.name} \n`))
                     .join("") +
+                managedSecrets
+                    .map(secretsUtils.prettySecretName)
+                    .map((s) => clc.bold(`- Secret: ${s}\n`))
+                    .join("") +
                 "\n"
             : "";
         const artifactsMessage = `The following ${clc.bold("will not")} be deleted:\n` +

package/lib/commands/ext-update.js

@@ -12,6 +12,7 @@ const billingMigrationHelper_1 = require("../extensions/billingMigrationHelper")
 const checkProjectBilling_1 = require("../extensions/checkProjectBilling");
 const cloudbilling_1 = require("../gcp/cloudbilling");
 const extensionsApi = require("../extensions/extensionsApi");
+const secretsUtils = require("../extensions/secretsUtils");
 const provisioningHelper = require("../extensions/provisioningHelper");
 const extensionsHelper_1 = require("../extensions/extensionsHelper");
 const paramHelper = require("../extensions/paramHelper");
@@ -124,7 +125,8 @@ exports.default = new command_1.Command("ext:update <extensionInstanceId> [updat
             force: options.force,
         });
         await provisioningHelper.checkProductsProvisioned(projectId, newSpec);
-        if (newSpec.billingRequired) {
+        const usesSecrets = secretsUtils.usesSecrets(newSpec);
+        if (newSpec.billingRequired || usesSecrets) {
             const enabled = await cloudbilling_1.checkBillingEnabled(projectId);
             billingMigrationHelper_1.displayNode10UpdateBillingNotice(existingSpec, newSpec);
             if (!(await extensionsHelper_1.confirm({
@@ -136,7 +138,7 @@ exports.default = new command_1.Command("ext:update <extensionInstanceId> [updat
             }
             if (!enabled) {
                 if (!options.nonInteractive) {
-                    await checkProjectBilling_1.enableBilling(projectId, instanceId);
+                    await checkProjectBilling_1.enableBilling(projectId);
                 }
                 else {
                     throw new error_1.FirebaseError("The extension requires your project to be upgraded to the Blaze plan. " +
@@ -144,7 +146,11 @@ exports.default = new command_1.Command("ext:update <extensionInstanceId> [updat
                         marked(`https://console.cloud.google.com/billing/linkedaccount?project=${projectId}`));
                 }
             }
+            if (usesSecrets) {
+                await secretsUtils.ensureSecretManagerApiEnabled(options);
+            }
         }
+        const oldParamValues = Object.assign({}, existingParams);
         const newParams = await paramHelper.getParamsForUpdate({
             spec: existingSpec,
             newSpec,
@@ -152,6 +158,7 @@ exports.default = new command_1.Command("ext:update <extensionInstanceId> [updat
             projectId,
             paramsEnvPath: options.params,
             nonInteractive: options.nonInteractive,
+            instanceId,
         });
         spinner.start();
         const updateOptions = {
@@ -164,7 +171,7 @@ exports.default = new command_1.Command("ext:update <extensionInstanceId> [updat
         else {
             updateOptions.source = newSource;
         }
-        if (!_.isEqual(newParams, existingParams)) {
+        if (!_.isEqual(newParams, oldParamValues)) {
             updateOptions.params = newParams;
         }
         await updateHelper_1.update(updateOptions);