firebase-tools 9.19.0 → 9.20.0

package/CHANGELOG.md

@@ -1,3 +1 @@
-- `ext:dev:publish` and `ext:update` now support --force and --non-interactive flags.
-- Fixes issue where account specified by `login:use` was not being correctly loaded (#3759).
-- Fixes minor layout issues in Auth Emulator IDP sign-in page (#3774).
+- `ext:install`, `ext:update` and `ext:configure` now support param type `secret`.

package/lib/api.js

@@ -115,6 +115,7 @@ var api = {
     serviceUsageOrigin: utils.envOverride("FIREBASE_SERVICE_USAGE_URL", "https://serviceusage.googleapis.com"),
     githubOrigin: utils.envOverride("GITHUB_URL", "https://github.com"),
     githubApiOrigin: utils.envOverride("GITHUB_API_URL", "https://api.github.com"),
+    secretManagerOrigin: utils.envOverride("CLOUD_SECRET_MANAGER_URL", "https://secretmanager.googleapis.com"),
     githubClientId: utils.envOverride("GITHUB_CLIENT_ID", "89cf50f02ac6aaed3484"),
     githubClientSecret: utils.envOverride("GITHUB_CLIENT_SECRET", "3330d14abc895d9a74d5f17cd7a00711fa2c5bf0"),
     setRefreshToken: function (token) {

package/lib/commands/crashlytics-symbols-upload.js

@@ -0,0 +1,146 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const fs = require("fs-extra");
+const os = require("os");
+const path = require("path");
+const spawn = require("cross-spawn");
+const uuid = require("uuid");
+const command_1 = require("../command");
+const downloadUtils = require("../downloadUtils");
+const error_1 = require("../error");
+const logger_1 = require("../logger");
+const rimraf = require("rimraf");
+const utils = require("../utils");
+var SymbolGenerator;
+(function (SymbolGenerator) {
+    SymbolGenerator["breakpad"] = "breakpad";
+    SymbolGenerator["csym"] = "csym";
+})(SymbolGenerator || (SymbolGenerator = {}));
+const SYMBOL_CACHE_ROOT_DIR = process.env.FIREBASE_CRASHLYTICS_CACHE_PATH || os.tmpdir();
+const JAR_CACHE_DIR = process.env.FIREBASE_CRASHLYTICS_BUILDTOOLS_PATH ||
+    path.join(os.homedir(), ".cache", "firebase", "crashlytics", "buildtools");
+const JAR_VERSION = "2.8.0";
+const JAR_URL = `https://storage.googleapis.com/firebase-preview-drop/android/crashlytics-eap/crashlytics-buildtools/firebase-crashlytics-buildtools-${JAR_VERSION}-alpha-all.jar`;
+exports.default = new command_1.Command("crashlytics:symbols:upload <symbolFiles...>")
+    .description("Upload symbols for native code, to symbolicate stack traces.")
+    .option("--app <appID>", "the app id of your Firebase app")
+    .option("--generator [breakpad|csym]", "the symbol generator being used, defaults to breakpad.")
+    .option("--dry-run", "generate symbols without uploading them")
+    .option("--debug", "print debug output and logging from the underlying uploader tool")
+    .action(async (symbolFiles, options) => {
+    const app = getGoogleAppID(options) || "";
+    const generator = getSymbolGenerator(options);
+    const dryRun = !!options.dryRun;
+    const debug = !!options.debug;
+    let jarFile = await downloadBuiltoolsJar();
+    if (process.env.LOCAL_JAR) {
+        jarFile = process.env.LOCAL_JAR;
+    }
+    const jarOptions = {
+        jarFile,
+        app,
+        generator,
+        cachePath: path.join(SYMBOL_CACHE_ROOT_DIR, `crashlytics-${uuid.v4()}`, "nativeSymbols", app, generator),
+        symbolFile: "",
+        generate: true,
+    };
+    for (const symbolFile of symbolFiles) {
+        utils.logBullet(`Generating symbols for ${symbolFile}`);
+        const generateArgs = buildArgs(Object.assign(Object.assign({}, jarOptions), { symbolFile }));
+        const output = runJar(generateArgs, debug);
+        if (output.length > 0) {
+            utils.logBullet(output);
+        }
+        else {
+            utils.logBullet(`Generated symbols for ${symbolFile}`);
+            utils.logBullet(`Output Path: ${jarOptions.cachePath}`);
+        }
+    }
+    if (dryRun) {
+        utils.logBullet("Skipping upload because --dry-run was passed");
+        return;
+    }
+    utils.logBullet(`Uploading all generated symbols`);
+    const uploadArgs = buildArgs(Object.assign(Object.assign({}, jarOptions), { generate: false }));
+    const output = runJar(uploadArgs, debug);
+    if (output.length > 0) {
+        utils.logBullet(output);
+    }
+    else {
+        utils.logBullet("Successfully uploaded all symbols");
+    }
+});
+function getGoogleAppID(options) {
+    if (!options.app) {
+        throw new error_1.FirebaseError("set the --app option to a valid Firebase app id and try again");
+    }
+    return options.app;
+}
+function getSymbolGenerator(options) {
+    if (!options.generator) {
+        return SymbolGenerator.breakpad;
+    }
+    if (!Object.values(SymbolGenerator).includes(options.generator)) {
+        throw new error_1.FirebaseError('--symbol-generator should be set to either "breakpad" or "csym"');
+    }
+    return options.generator;
+}
+async function downloadBuiltoolsJar() {
+    const jarPath = path.join(JAR_CACHE_DIR, `crashlytics-buildtools-${JAR_VERSION}.jar`);
+    if (fs.existsSync(jarPath)) {
+        logger_1.logger.debug(`Buildtools Jar already downloaded at ${jarPath}`);
+        return jarPath;
+    }
+    if (fs.existsSync(JAR_CACHE_DIR)) {
+        logger_1.logger.debug(`Deleting Jar cache at ${JAR_CACHE_DIR} because the CLI was run with a newer Jar version`);
+        rimraf.sync(JAR_CACHE_DIR);
+    }
+    utils.logBullet("Downloading buildtools.jar to " + jarPath);
+    utils.logBullet("For open source licenses used by this command, look in the META-INF directory in the buildtools.jar file");
+    const tmpfile = await downloadUtils.downloadToTmp(JAR_URL);
+    fs.mkdirSync(JAR_CACHE_DIR, { recursive: true });
+    fs.copySync(tmpfile, jarPath);
+    return jarPath;
+}
+function buildArgs(options) {
+    const baseArgs = [
+        "-jar",
+        options.jarFile,
+        `-symbolGenerator=${options.generator}`,
+        `-symbolFileCacheDir=${options.cachePath}`,
+        "-verbose",
+    ];
+    if (options.generate) {
+        return baseArgs.concat(["-generateNativeSymbols", `-unstrippedLibrary=${options.symbolFile}`]);
+    }
+    return baseArgs.concat([
+        "-uploadNativeSymbols",
+        `-googleAppId=${options.app}`,
+    ]);
+}
+function runJar(args, debug) {
+    var _a, _b, _c;
+    const outputs = spawn.sync("java", args, {
+        stdio: debug ? "inherit" : "pipe",
+    });
+    if (outputs.status || 0 > 0) {
+        if (!debug) {
+            utils.logWarning(((_a = outputs.stdout) === null || _a === void 0 ? void 0 : _a.toString()) || "An unknown error occurred");
+        }
+        throw new error_1.FirebaseError("Failed to upload symbols");
+    }
+    if (!debug) {
+        let logRegex = /(Generated symbol file.*$)/m;
+        let matched = (((_b = outputs.stdout) === null || _b === void 0 ? void 0 : _b.toString()) || "").match(logRegex);
+        if (matched) {
+            return matched[1];
+        }
+        logRegex = /(Crashlytics symbol file uploaded successfully.*$)/m;
+        matched = (((_c = outputs.stdout) === null || _c === void 0 ? void 0 : _c.toString()) || "").match(logRegex);
+        if (matched) {
+            return matched[1];
+        }
+        return "";
+    }
+    return "";
+}

package/lib/commands/ext-configure.js

@@ -52,6 +52,8 @@ exports.default = new command_1.Command("ext:configure <extensionInstanceId>")
             paramSpecs: paramSpecWithNewDefaults,
             nonInteractive: options.nonInteractive,
             paramsEnvPath: options.params,
+            instanceId,
+            reconfiguring: true,
         });
         if (immutableParams.length) {
             const plural = immutableParams.length > 1;

package/lib/commands/ext-install.js

@@ -14,6 +14,7 @@ const command_1 = require("../command");
 const error_1 = require("../error");
 const projectUtils_1 = require("../projectUtils");
 const extensionsApi = require("../extensions/extensionsApi");
+const secretsUtils = require("../extensions/secretsUtils");
 const provisioningHelper = require("../extensions/provisioningHelper");
 const refs = require("../extensions/refs");
 const warnings_1 = require("../extensions/warnings");
@@ -37,7 +38,8 @@ async function installExtension(options) {
     const spinner = ora.default();
     try {
         await provisioningHelper.checkProductsProvisioned(projectId, spec);
-        if (spec.billingRequired) {
+        const usesSecrets = secretsUtils.usesSecrets(spec);
+        if (spec.billingRequired || usesSecrets) {
             const enabled = await cloudbilling_1.checkBillingEnabled(projectId);
             if (!enabled && nonInteractive) {
                 throw new error_1.FirebaseError(`This extension requires the Blaze plan, but project ${projectId} is not on the Blaze plan. ` +
@@ -51,6 +53,23 @@ async function installExtension(options) {
                 await billingMigrationHelper_1.displayNode10CreateBillingNotice(spec, !nonInteractive);
             }
         }
+        const apis = spec.apis || [];
+        if (usesSecrets) {
+            apis.push({
+                apiName: "secretmanager.googleapis.com",
+                reason: `To access and manage secrets which are used by this extension. By using this product you agree to the terms and conditions of the following license: https://console.cloud.google.com/tos?id=cloud&project=${projectId}`,
+            });
+        }
+        if (apis.length) {
+            askUserForConsent.displayApis(spec.displayName || spec.name, projectId, apis);
+            const consented = await extensionsHelper_1.confirm({ nonInteractive, force, default: true });
+            if (!consented) {
+                throw new error_1.FirebaseError("Without explicit consent for the APIs listed, we cannot deploy this extension.");
+            }
+        }
+        if (usesSecrets) {
+            await secretsUtils.ensureSecretManagerApiEnabled(options);
+        }
         const roles = spec.roles ? spec.roles.map((role) => role.role) : [];
         if (roles.length) {
             await askUserForConsent.displayRoles(spec.displayName || spec.name, projectId, roles);
@@ -86,6 +105,7 @@ async function installExtension(options) {
                     paramSpecs: spec.params,
                     nonInteractive,
                     paramsEnvPath,
+                    instanceId,
                 });
                 spinner.text = "Installing your extension instance. This usually takes 3 to 5 minutes...";
                 spinner.start();
@@ -106,6 +126,7 @@ async function installExtension(options) {
                     paramSpecs: spec.params,
                     nonInteractive,
                     paramsEnvPath,
+                    instanceId,
                 });
                 spinner.text = "Updating your extension instance. This usually takes 3 to 5 minutes...";
                 spinner.start();
@@ -164,7 +185,7 @@ async function infoInstallByReference(extensionName) {
     }
     const extVersion = await extensionsApi.getExtensionVersion(extensionName);
     displayExtensionInfo_1.displayExtInfo(extensionName, ref.publisherId, extVersion.spec, true);
-    warnings_1.displayWarningPrompts(ref.publisherId, extension.registryLaunchStage, extVersion);
+    await warnings_1.displayWarningPrompts(ref.publisherId, extension.registryLaunchStage, extVersion);
     return extVersion;
 }
 exports.default = new command_1.Command("ext:install [extensionName]")

package/lib/commands/ext-uninstall.js

@@ -10,6 +10,7 @@ const command_1 = require("../command");
 const error_1 = require("../error");
 const projectUtils_1 = require("../projectUtils");
 const extensionsApi = require("../extensions/extensionsApi");
+const secretsUtils = require("../extensions/secretsUtils");
 const extensionsHelper_1 = require("../extensions/extensionsHelper");
 const prompt_1 = require("../prompt");
 const requirePermissions_1 = require("../requirePermissions");
@@ -51,11 +52,16 @@ exports.default = new command_1.Command("ext:uninstall <extensionInstanceId>")
     }
     if (!options.force) {
         const serviceAccountMessage = `Uninstalling deletes the service account used by this extension instance:\n${clc.bold(instance.serviceAccountEmail)}\n\n`;
+        const managedSecrets = await secretsUtils.getManagedSecrets(instance);
         const resourcesMessage = _.get(instance, "config.source.spec.resources", []).length
             ? "Uninstalling deletes all extension resources created for this extension instance:\n" +
                 instance.config.source.spec.resources
                     .map((resource) => clc.bold(`- ${extensionsHelper_1.resourceTypeToNiceName[resource.type] || resource.type}: ${resource.name} \n`))
                     .join("") +
+                managedSecrets
+                    .map(secretsUtils.prettySecretName)
+                    .map((s) => clc.bold(`- Secret: ${s}\n`))
+                    .join("") +
                 "\n"
             : "";
         const artifactsMessage = `The following ${clc.bold("will not")} be deleted:\n` +

package/lib/commands/ext-update.js

@@ -12,6 +12,7 @@ const billingMigrationHelper_1 = require("../extensions/billingMigrationHelper")
 const checkProjectBilling_1 = require("../extensions/checkProjectBilling");
 const cloudbilling_1 = require("../gcp/cloudbilling");
 const extensionsApi = require("../extensions/extensionsApi");
+const secretsUtils = require("../extensions/secretsUtils");
 const provisioningHelper = require("../extensions/provisioningHelper");
 const extensionsHelper_1 = require("../extensions/extensionsHelper");
 const paramHelper = require("../extensions/paramHelper");
@@ -124,7 +125,8 @@ exports.default = new command_1.Command("ext:update <extensionInstanceId> [updat
             force: options.force,
         });
         await provisioningHelper.checkProductsProvisioned(projectId, newSpec);
-        if (newSpec.billingRequired) {
+        const usesSecrets = secretsUtils.usesSecrets(newSpec);
+        if (newSpec.billingRequired || usesSecrets) {
             const enabled = await cloudbilling_1.checkBillingEnabled(projectId);
             billingMigrationHelper_1.displayNode10UpdateBillingNotice(existingSpec, newSpec);
             if (!(await extensionsHelper_1.confirm({
@@ -144,7 +146,11 @@ exports.default = new command_1.Command("ext:update <extensionInstanceId> [updat
                         marked(`https://console.cloud.google.com/billing/linkedaccount?project=${projectId}`));
                 }
             }
+            if (usesSecrets) {
+                await secretsUtils.ensureSecretManagerApiEnabled(options);
+            }
         }
+        const oldParamValues = Object.assign({}, existingParams);
         const newParams = await paramHelper.getParamsForUpdate({
             spec: existingSpec,
             newSpec,
@@ -152,6 +158,7 @@ exports.default = new command_1.Command("ext:update <extensionInstanceId> [updat
             projectId,
             paramsEnvPath: options.params,
             nonInteractive: options.nonInteractive,
+            instanceId,
         });
         spinner.start();
         const updateOptions = {
@@ -164,7 +171,7 @@ exports.default = new command_1.Command("ext:update <extensionInstanceId> [updat
         else {
             updateOptions.source = newSource;
         }
-        if (!_.isEqual(newParams, existingParams)) {
+        if (!_.isEqual(newParams, oldParamValues)) {
             updateOptions.params = newParams;
         }
         await updateHelper_1.update(updateOptions);

package/lib/commands/functions-config-export.js

@@ -0,0 +1,115 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const path = require("path");
+const clc = require("cli-color");
+const requireInteractive_1 = require("../requireInteractive");
+const command_1 = require("../command");
+const error_1 = require("../error");
+const iam_1 = require("../gcp/iam");
+const logger_1 = require("../logger");
+const prompt_1 = require("../prompt");
+const requirePermissions_1 = require("../requirePermissions");
+const utils_1 = require("../utils");
+const functional_1 = require("../functional");
+const configExport = require("../functions/runtimeConfigExport");
+const requireConfig = require("../requireConfig");
+const REQUIRED_PERMISSIONS = [
+    "runtimeconfig.configs.list",
+    "runtimeconfig.configs.get",
+    "runtimeconfig.variables.list",
+    "runtimeconfig.variables.get",
+];
+const RESERVED_PROJECT_ALIAS = ["local"];
+const MAX_ATTEMPTS = 3;
+function checkReservedAliases(pInfos) {
+    for (const pInfo of pInfos) {
+        if (pInfo.alias && RESERVED_PROJECT_ALIAS.includes(pInfo.alias)) {
+            utils_1.logWarning(`Project alias (${clc.bold(pInfo.alias)}) is reserved for internal use. ` +
+                `Saving exported config in .env.${pInfo.projectId} instead.`);
+            delete pInfo.alias;
+        }
+    }
+}
+async function checkRequiredPermission(pInfos) {
+    pInfos = pInfos.filter((pInfo) => !pInfo.config);
+    const testPermissions = pInfos.map((pInfo) => iam_1.testIamPermissions(pInfo.projectId, REQUIRED_PERMISSIONS));
+    const results = await Promise.all(testPermissions);
+    for (const [pInfo, result] of functional_1.zip(pInfos, results)) {
+        if (result.passed) {
+            throw new error_1.FirebaseError(`Unexpectedly failed to fetch runtime config for project ${pInfo.projectId}`);
+        }
+        utils_1.logWarning("You are missing the following permissions to read functions config on project " +
+            `${clc.bold(pInfo.projectId)}:\n\t${result.missing.join("\n\t")}`);
+        const confirm = await prompt_1.promptOnce({
+            type: "confirm",
+            name: "skip",
+            default: true,
+            message: `Continue without importing configs from project ${pInfo.projectId}?`,
+        });
+        if (!confirm) {
+            throw new error_1.FirebaseError("Command aborted!");
+        }
+    }
+}
+async function promptForPrefix(errMsg) {
+    utils_1.logWarning("The following configs keys could not be exported as environment variables:\n");
+    utils_1.logWarning(errMsg);
+    return await prompt_1.promptOnce({
+        type: "input",
+        name: "prefix",
+        default: "CONFIG_",
+        message: "Enter a PREFIX to rename invalid environment variable keys:",
+    }, {});
+}
+function fromEntries(itr) {
+    const obj = {};
+    for (const [k, v] of itr) {
+        obj[k] = v;
+    }
+    return obj;
+}
+exports.default = new command_1.Command("functions:config:export")
+    .description("Export environment config as environment variables in dotenv format")
+    .before(requirePermissions_1.requirePermissions, [
+    "runtimeconfig.configs.list",
+    "runtimeconfig.configs.get",
+    "runtimeconfig.variables.list",
+    "runtimeconfig.variables.get",
+])
+    .before(requireConfig)
+    .before(requireInteractive_1.default)
+    .action(async (options) => {
+    let pInfos = configExport.getProjectInfos(options);
+    checkReservedAliases(pInfos);
+    utils_1.logBullet("Importing functions configs from projects [" +
+        pInfos.map(({ projectId }) => `${clc.bold(projectId)}`).join(", ") +
+        "]");
+    await configExport.hydrateConfigs(pInfos);
+    await checkRequiredPermission(pInfos);
+    pInfos = pInfos.filter((pInfo) => pInfo.config);
+    logger_1.logger.debug(`Loaded function configs: ${JSON.stringify(pInfos)}`);
+    utils_1.logBullet(`Importing configs from projects: [${pInfos.map((p) => p.projectId).join(", ")}]`);
+    let attempts = 0;
+    let prefix = "";
+    while (true) {
+        if (attempts >= MAX_ATTEMPTS) {
+            throw new error_1.FirebaseError("Exceeded max attempts to fix invalid config keys.");
+        }
+        const errMsg = configExport.hydrateEnvs(pInfos, prefix);
+        if (errMsg.length == 0) {
+            break;
+        }
+        prefix = await promptForPrefix(errMsg);
+        attempts += 1;
+    }
+    const header = `# Exported firebase functions:config:export command on ${new Date().toLocaleDateString()}`;
+    const dotEnvs = pInfos.map((pInfo) => configExport.toDotenvFormat(pInfo.envs, header));
+    const filenames = pInfos.map(configExport.generateDotenvFilename);
+    const filesToWrite = fromEntries(functional_1.zip(filenames, dotEnvs));
+    filesToWrite[".env.local"] = `${header}\n# .env.local file contains environment variables for the Functions Emulator.\n`;
+    filesToWrite[".env"] = `${header}# .env file contains environment variables that applies to all projects.\n`;
+    const functionsDir = options.config.get("functions.source", ".");
+    for (const [filename, content] of Object.entries(filesToWrite)) {
+        await options.config.askWriteProjectFile(path.join(functionsDir, filename), content);
+    }
+});

package/lib/commands/functions-delete.js

@@ -10,6 +10,7 @@ const helper = require("../deploy/functions/functionsDeployHelper");
 const requirePermissions_1 = require("../requirePermissions");
 const utils = require("../utils");
 const backend = require("../deploy/functions/backend");
+const error_1 = require("../error");
 exports.default = new command_1.Command("functions:delete [filters...]")
     .description("delete one or more Cloud Functions by name or group name.")
     .option("--region <region>", "Specify region of the function to be deleted. " +
@@ -26,41 +27,49 @@ exports.default = new command_1.Command("functions:delete [filters...]")
     const filterChunks = filters.map((filter) => {
         return filter.split(".");
     });
-    const [config, existingBackend] = await Promise.all([
-        functionsConfig.getFirebaseConfig(options),
-        backend.existingBackend(context),
-    ]);
-    await backend.checkAvailability(context, backend.empty());
-    const appEngineLocation = functionsConfig.getAppEngineLocation(config);
-    const functionsToDelete = existingBackend.cloudFunctions.filter((fn) => {
-        const regionMatches = options.region ? fn.region === options.region : true;
-        const nameMatches = helper.functionMatchesAnyGroup(fn, filterChunks);
-        return regionMatches && nameMatches;
-    });
-    if (functionsToDelete.length === 0) {
-        return utils.reject(`The specified filters do not match any existing functions in project ${clc.bold(context.projectId)}.`, { exit: 1 });
+    try {
+        const [config, existingBackend] = await Promise.all([
+            functionsConfig.getFirebaseConfig(options),
+            backend.existingBackend(context),
+        ]);
+        await backend.checkAvailability(context, backend.empty());
+        const appEngineLocation = functionsConfig.getAppEngineLocation(config);
+        const functionsToDelete = existingBackend.cloudFunctions.filter((fn) => {
+            const regionMatches = options.region ? fn.region === options.region : true;
+            const nameMatches = helper.functionMatchesAnyGroup(fn, filterChunks);
+            return regionMatches && nameMatches;
+        });
+        if (functionsToDelete.length === 0) {
+            throw new Error(`The specified filters do not match any existing functions in project ${clc.bold(context.projectId)}.`);
+        }
+        const schedulesToDelete = existingBackend.schedules.filter((schedule) => {
+            functionsToDelete.some(backend.sameFunctionName(schedule.targetService));
+        });
+        const topicsToDelete = existingBackend.topics.filter((topic) => {
+            functionsToDelete.some(backend.sameFunctionName(topic.targetService));
+        });
+        const deleteList = functionsToDelete
+            .map((func) => {
+            return "\t" + helper.getFunctionLabel(func);
+        })
+            .join("\n");
+        const confirmDeletion = await prompt_1.promptOnce({
+            type: "confirm",
+            name: "force",
+            default: false,
+            message: "You are about to delete the following Cloud Functions:\n" +
+                deleteList +
+                "\n  Are you sure?",
+        }, options);
+        if (!confirmDeletion) {
+            throw new Error("Command aborted.");
+        }
+        return await functionsDelete_1.deleteFunctions(functionsToDelete, schedulesToDelete, topicsToDelete, appEngineLocation);
     }
-    const schedulesToDelete = existingBackend.schedules.filter((schedule) => {
-        functionsToDelete.some(backend.sameFunctionName(schedule.targetService));
-    });
-    const topicsToDelete = existingBackend.topics.filter((topic) => {
-        functionsToDelete.some(backend.sameFunctionName(topic.targetService));
-    });
-    const deleteList = functionsToDelete
-        .map((func) => {
-        return "\t" + helper.getFunctionLabel(func);
-    })
-        .join("\n");
-    const confirmDeletion = await prompt_1.promptOnce({
-        type: "confirm",
-        name: "force",
-        default: false,
-        message: "You are about to delete the following Cloud Functions:\n" +
-            deleteList +
-            "\n  Are you sure?",
-    }, options);
-    if (!confirmDeletion) {
-        return utils.reject("Command aborted.", { exit: 1 });
+    catch (err) {
+        throw new error_1.FirebaseError("Failed to delete functions", {
+            original: err,
+            exit: 1,
+        });
     }
-    return await functionsDelete_1.deleteFunctions(functionsToDelete, schedulesToDelete, topicsToDelete, appEngineLocation);
 });

package/lib/commands/functions-list.js

@@ -46,7 +46,7 @@ exports.default = new command_1.Command("functions:list")
         return functionList;
     }
     catch (err) {
-        throw new error_1.FirebaseError(`Failed to list functions ${err.message}`, {
+        throw new error_1.FirebaseError("Failed to list functions", {
             exit: 1,
             original: err,
         });

package/lib/commands/index.js

@@ -26,6 +26,11 @@ module.exports = function (client) {
     client.auth = {};
     client.auth.export = loadCommand("auth-export");
     client.auth.upload = loadCommand("auth-import");
+    if (previews.crashlyticsSymbolsUpload) {
+        client.crashlytics = {};
+        client.crashlytics.symbols = {};
+        client.crashlytics.symbols.upload = loadCommand("crashlytics-symbols-upload");
+    }
     client.database = {};
     client.database.get = loadCommand("database-get");
     client.database.instances = {};
@@ -84,6 +89,9 @@ module.exports = function (client) {
     client.functions = {};
     client.functions.config = {};
     client.functions.config.clone = loadCommand("functions-config-clone");
+    if (previews.dotenv) {
+        client.functions.config.export = loadCommand("functions-config-export");
+    }
     client.functions.config.get = loadCommand("functions-config-get");
     client.functions.config.set = loadCommand("functions-config-set");
     client.functions.config.unset = loadCommand("functions-config-unset");

package/lib/deploy/functions/backend.js

@@ -104,7 +104,7 @@ async function existingBackend(context, forceRefresh) {
 }
 exports.existingBackend = existingBackend;
 async function loadExistingBackend(ctx) {
-    var _a, _b, _c;
+    var _a, _b, _c, _d;
     ctx.loadedExistingBackend = true;
     ctx.existingBackend = Object.assign({}, empty());
     ctx.unreachableRegions = {
@@ -144,12 +144,21 @@ async function loadExistingBackend(ctx) {
     if (!previews_1.previews.functionsv2) {
         return;
     }
-    const gcfV2Results = await gcfV2.listAllFunctions(ctx.projectId);
+    let gcfV2Results;
+    try {
+        gcfV2Results = await gcfV2.listAllFunctions(ctx.projectId);
+    }
+    catch (err) {
+        if (err.status === 404 && ((_b = err.message) === null || _b === void 0 ? void 0 : _b.toLowerCase().includes("method not found"))) {
+            return;
+        }
+        throw err;
+    }
     for (const apiFunction of gcfV2Results.functions) {
         const specFunction = gcfV2.specFromFunction(apiFunction);
         ctx.existingBackend.cloudFunctions.push(specFunction);
-        const pubsubScheduled = ((_b = apiFunction.labels) === null || _b === void 0 ? void 0 : _b["deployment-scheduled"]) === "true";
-        const httpsScheduled = ((_c = apiFunction.labels) === null || _c === void 0 ? void 0 : _c["deployment-scheduled"]) === "https";
+        const pubsubScheduled = ((_c = apiFunction.labels) === null || _c === void 0 ? void 0 : _c["deployment-scheduled"]) === "true";
+        const httpsScheduled = ((_d = apiFunction.labels) === null || _d === void 0 ? void 0 : _d["deployment-scheduled"]) === "https";
         if (pubsubScheduled) {
             const id = scheduleIdForFunction(specFunction);
             ctx.existingBackend.schedules.push({

package/lib/deploy/functions/prepare.js

@@ -18,6 +18,7 @@ const runtimes = require("./runtimes");
 const validate = require("./validate");
 const utils = require("../../utils");
 const logger_1 = require("../../logger");
+const triggerRegionHelper_1 = require("./triggerRegionHelper");
 function hasUserConfig(config) {
     return Object.keys(config).length > 1;
 }
@@ -70,6 +71,7 @@ async function prepare(context, options, payload) {
             cloudrun: "run.googleapis.com",
             eventarc: "eventarc.googleapis.com",
             pubsub: "pubsub.googleapis.com",
+            storage: "storage.googleapis.com",
         };
         const enablements = Object.entries(V2_APIS).map(([tag, api]) => {
             return ensureApiEnabled.ensure(context.projectId, api, tag);
@@ -100,6 +102,7 @@ async function prepare(context, options, payload) {
         return functionsDeployHelper_1.functionMatchesAnyGroup(fn, context.filters);
     });
     const haveFunctions = (await backend.existingBackend(context)).cloudFunctions;
+    await triggerRegionHelper_1.setTriggerRegion(wantFunctions, haveFunctions);
     await prompts_1.promptForFailurePolicies(options, wantFunctions, haveFunctions);
     await prompts_1.promptForMinInstances(options, wantFunctions, haveFunctions);
     await backend.checkAvailability(context, wantBackend);

package/lib/deploy/functions/runtimes/node/parseTriggers.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.addResourcesToBackend = exports.discoverBackend = exports.useStrategy = void 0;
+exports.addResourcesToBackend = exports.discoverBackend = exports.useStrategy = exports.GCS_EVENTS = void 0;
 const path = require("path");
 const _ = require("lodash");
 const child_process_1 = require("child_process");
@@ -10,6 +10,12 @@ const backend = require("../../backend");
 const api = require("../../../../api");
 const proto = require("../../../../gcp/proto");
 const TRIGGER_PARSER = path.resolve(__dirname, "./triggerParser.js");
+exports.GCS_EVENTS = new Set([
+    "google.cloud.storage.object.v1.finalized",
+    "google.cloud.storage.object.v1.archived",
+    "google.cloud.storage.object.v1.deleted",
+    "google.cloud.storage.object.v1.metadataUpdated",
+]);
 function removeInspectOptions(options) {
     return options.filter((opt) => !opt.startsWith("--inspect"));
 }
@@ -58,6 +64,7 @@ async function discoverBackend(projectId, sourceDir, runtime, configValues, envs
 }
 exports.discoverBackend = discoverBackend;
 function addResourcesToBackend(projectId, runtime, annotation, want) {
+    var _a;
     Object.freeze(annotation);
     for (const region of annotation.regions || [api.functionsDefaultRegion]) {
         let trigger;
@@ -79,6 +86,11 @@ function addResourcesToBackend(projectId, runtime, annotation, want) {
                 },
                 retry: !!annotation.failurePolicy,
             };
+            if (exports.GCS_EVENTS.has(((_a = annotation.eventTrigger) === null || _a === void 0 ? void 0 : _a.eventType) || "")) {
+                trigger.eventFilters = {
+                    bucket: annotation.eventTrigger.resource,
+                };
+            }
         }
         const cloudFunctionName = {
             id: annotation.name,