firebase-tools 9.17.0 → 9.21.0

package/lib/deploy/functions/runtimes/node/parseTriggers.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.addResourcesToBackend = exports.discoverBackend = exports.useStrategy = void 0;
+exports.addResourcesToBackend = exports.discoverBackend = exports.useStrategy = exports.GCS_EVENTS = void 0;
 const path = require("path");
 const _ = require("lodash");
 const child_process_1 = require("child_process");
@@ -10,6 +10,12 @@ const backend = require("../../backend");
 const api = require("../../../../api");
 const proto = require("../../../../gcp/proto");
 const TRIGGER_PARSER = path.resolve(__dirname, "./triggerParser.js");
+exports.GCS_EVENTS = new Set([
+    "google.cloud.storage.object.v1.finalized",
+    "google.cloud.storage.object.v1.archived",
+    "google.cloud.storage.object.v1.deleted",
+    "google.cloud.storage.object.v1.metadataUpdated",
+]);
 function removeInspectOptions(options) {
     return options.filter((opt) => !opt.startsWith("--inspect"));
 }
@@ -58,75 +64,53 @@ async function discoverBackend(projectId, sourceDir, runtime, configValues, envs
 }
 exports.discoverBackend = discoverBackend;
 function addResourcesToBackend(projectId, runtime, annotation, want) {
+    var _a;
     Object.freeze(annotation);
     for (const region of annotation.regions || [api.functionsDefaultRegion]) {
-        let trigger;
+        let triggered;
         if (!!annotation.httpsTrigger == !!annotation.eventTrigger) {
             throw new error_1.FirebaseError("Unexpected annotation generated by the Firebase Functions SDK. This should never happen.");
         }
         if (annotation.httpsTrigger) {
-            let allowInsecure;
-            if ("allowInsecure" in annotation.httpsTrigger) {
-                allowInsecure = !!annotation.httpsTrigger.allowInsecure;
-            }
-            else {
-                allowInsecure = !annotation.platform || annotation.platform === "gcfv1";
-            }
-            trigger = { allowInsecure };
+            const trigger = {};
             if (annotation.failurePolicy) {
                 logger_1.logger.warn(`Ignoring retry policy for HTTPS function ${annotation.name}`);
             }
-            proto.copyIfPresent(trigger, annotation.httpsTrigger, "invoker", "invoker");
+            proto.copyIfPresent(trigger, annotation.httpsTrigger, "invoker");
+            triggered = { httpsTrigger: trigger };
+        }
+        else if (annotation.schedule) {
+            want.requiredAPIs["pubsub"] = "pubsub.googleapis.com";
+            want.requiredAPIs["scheduler"] = "cloudscheduler.googleapis.com";
+            triggered = { scheduleTrigger: annotation.schedule };
         }
         else {
-            trigger = {
-                eventType: annotation.eventTrigger.eventType,
-                eventFilters: {
-                    resource: annotation.eventTrigger.resource,
+            triggered = {
+                eventTrigger: {
+                    eventType: annotation.eventTrigger.eventType,
+                    eventFilters: {
+                        resource: annotation.eventTrigger.resource,
+                    },
+                    retry: !!annotation.failurePolicy,
                 },
-                retry: !!annotation.failurePolicy,
             };
+            if (exports.GCS_EVENTS.has(((_a = annotation.eventTrigger) === null || _a === void 0 ? void 0 : _a.eventType) || "")) {
+                triggered.eventTrigger.eventFilters = {
+                    bucket: annotation.eventTrigger.resource,
+                };
+            }
         }
-        const cloudFunctionName = {
-            id: annotation.name,
-            region: region,
-            project: projectId,
-        };
-        const cloudFunction = Object.assign(Object.assign({ platform: annotation.platform || "gcfv1" }, cloudFunctionName), { entryPoint: annotation.entryPoint, runtime: runtime, trigger: trigger });
+        const endpoint = Object.assign({ platform: annotation.platform || "gcfv1", id: annotation.name, region: region, project: projectId, entryPoint: annotation.entryPoint, runtime: runtime }, triggered);
         if (annotation.vpcConnector) {
             let maybeId = annotation.vpcConnector;
             if (!maybeId.includes("/")) {
                 maybeId = `projects/${projectId}/locations/${region}/connectors/${maybeId}`;
             }
-            cloudFunction.vpcConnector = maybeId;
-        }
-        proto.copyIfPresent(cloudFunction, annotation, "concurrency", "serviceAccountEmail", "labels", "vpcConnectorEgressSettings", "ingressSettings", "timeout", "maxInstances", "minInstances", "availableMemoryMb");
-        if (annotation.schedule) {
-            want.requiredAPIs["pubsub"] = "pubsub.googleapis.com";
-            want.requiredAPIs["scheduler"] = "cloudscheduler.googleapis.com";
-            const id = backend.scheduleIdForFunction(cloudFunctionName);
-            const schedule = {
-                id,
-                project: projectId,
-                schedule: annotation.schedule.schedule,
-                transport: "pubsub",
-                targetService: cloudFunctionName,
-            };
-            proto.copyIfPresent(schedule, annotation.schedule, "timeZone", "retryConfig");
-            want.schedules.push(schedule);
-            const topic = {
-                id,
-                project: projectId,
-                labels: backend.SCHEDULED_FUNCTION_LABEL,
-                targetService: cloudFunctionName,
-            };
-            want.topics.push(topic);
-            if (backend.isEventTrigger(cloudFunction.trigger)) {
-                cloudFunction.trigger.eventFilters.resource = `${cloudFunction.trigger.eventFilters.resource}/${id}`;
-            }
-            cloudFunction.labels = Object.assign(Object.assign({}, cloudFunction.labels), { "deployment-scheduled": "true" });
+            endpoint.vpcConnector = maybeId;
         }
-        want.cloudFunctions.push(cloudFunction);
+        proto.copyIfPresent(endpoint, annotation, "concurrency", "serviceAccountEmail", "labels", "vpcConnectorEgressSettings", "ingressSettings", "timeout", "maxInstances", "minInstances", "availableMemoryMb");
+        want.endpoints[region] = want.endpoints[region] || {};
+        want.endpoints[region][endpoint.id] = endpoint;
     }
 }
 exports.addResourcesToBackend = addResourcesToBackend;

package/lib/deploy/functions/triggerRegionHelper.js

@@ -0,0 +1,40 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.lookupMissingTriggerRegions = void 0;
+const backend = require("./backend");
+const storage = require("../../gcp/storage");
+const error_1 = require("../../error");
+const logger_1 = require("../../logger");
+const noop = () => Promise.resolve();
+const LOOKUP_BY_EVENT_TYPE = {
+    "google.cloud.pubsub.topic.v1.messagePublished": noop,
+    "google.cloud.storage.object.v1.finalized": lookupBucketRegion,
+    "google.cloud.storage.object.v1.archived": lookupBucketRegion,
+    "google.cloud.storage.object.v1.deleted": lookupBucketRegion,
+    "google.cloud.storage.object.v1.metadataUpdated": lookupBucketRegion,
+};
+async function lookupMissingTriggerRegions(want) {
+    const regionLookups = [];
+    for (const ep of backend.allEndpoints(want)) {
+        if (ep.platform === "gcfv1" || !backend.isEventTriggered(ep) || ep.eventTrigger.region) {
+            continue;
+        }
+        const lookup = LOOKUP_BY_EVENT_TYPE[ep.eventTrigger.eventType];
+        if (!lookup) {
+            logger_1.logger.debug("Don't know how to look up trigger region for event type", ep.eventTrigger.eventType, ". Deploy will fail unless this event type is global");
+            continue;
+        }
+        regionLookups.push(lookup(ep));
+    }
+    await Promise.all(regionLookups);
+}
+exports.lookupMissingTriggerRegions = lookupMissingTriggerRegions;
+async function lookupBucketRegion(endpoint) {
+    try {
+        const bucket = await storage.getBucket(endpoint.eventTrigger.eventFilters.bucket);
+        endpoint.eventTrigger.region = bucket.location.toLowerCase();
+    }
+    catch (err) {
+        throw new error_1.FirebaseError("Can't find the storage bucket region", { original: err });
+    }
+}

package/lib/deploy/functions/validate.js

@@ -1,10 +1,8 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.checkForInvalidChangeOfTrigger = exports.functionIdsAreValid = exports.functionsDirectoryExists = void 0;
+exports.functionIdsAreValid = exports.functionsDirectoryExists = void 0;
 const clc = require("cli-color");
 const error_1 = require("../../error");
-const functionsDeployHelper_1 = require("./functionsDeployHelper");
-const backend = require("./backend");
 const fsutils = require("../../fsutils");
 const projectPath = require("../../projectPath");
 function functionsDirectoryExists(options, sourceDirName) {
@@ -36,24 +34,3 @@ function functionIdsAreValid(functions) {
     }
 }
 exports.functionIdsAreValid = functionIdsAreValid;
-function checkForInvalidChangeOfTrigger(fn, exFn) {
-    var _a, _b;
-    const wantEventTrigger = backend.isEventTrigger(fn.trigger);
-    const haveEventTrigger = backend.isEventTrigger(exFn.trigger);
-    if (!wantEventTrigger && haveEventTrigger) {
-        throw new error_1.FirebaseError(`[${functionsDeployHelper_1.getFunctionLabel(fn)}] Changing from a background triggered function to an HTTPS function is not allowed. Please delete your function and create a new one instead.`);
-    }
-    if (wantEventTrigger && !haveEventTrigger) {
-        throw new error_1.FirebaseError(`[${functionsDeployHelper_1.getFunctionLabel(fn)}] Changing from an HTTPS function to an background triggered function is not allowed. Please delete your function and create a new one instead.`);
-    }
-    if (fn.platform == "gcfv2" && exFn.platform == "gcfv1") {
-        throw new error_1.FirebaseError(`[${functionsDeployHelper_1.getFunctionLabel(fn)}] Upgrading from GCFv1 to GCFv2 is not yet supported. Please delete your old function or wait for this feature to be ready.`);
-    }
-    if (fn.platform == "gcfv1" && exFn.platform == "gcfv2") {
-        throw new error_1.FirebaseError(`[${functionsDeployHelper_1.getFunctionLabel(fn)}] Functions cannot be downgraded from GCFv2 to GCFv1`);
-    }
-    if (((_a = exFn.labels) === null || _a === void 0 ? void 0 : _a["deployment-scheduled"]) && !((_b = fn.labels) === null || _b === void 0 ? void 0 : _b["deployment-scheduled"])) {
-        throw new error_1.FirebaseError(`[${functionsDeployHelper_1.getFunctionLabel(fn)}] Scheduled functions cannot be changed to event handler or HTTP functions`);
-    }
-}
-exports.checkForInvalidChangeOfTrigger = checkForInvalidChangeOfTrigger;

package/lib/downloadUtils.js

@@ -0,0 +1,37 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.downloadToTmp = void 0;
+const url_1 = require("url");
+const fs = require("fs-extra");
+const ProgressBar = require("progress");
+const tmp = require("tmp");
+const apiv2_1 = require("./apiv2");
+const error_1 = require("./error");
+async function downloadToTmp(remoteUrl) {
+    const u = new url_1.URL(remoteUrl);
+    const c = new apiv2_1.Client({ urlPrefix: u.origin, auth: false });
+    const tmpfile = tmp.fileSync();
+    const writeStream = fs.createWriteStream(tmpfile.name);
+    const res = await c.request({
+        method: "GET",
+        path: u.pathname,
+        queryParams: u.searchParams,
+        responseType: "stream",
+        resolveOnHTTPError: true,
+    });
+    if (res.status !== 200) {
+        throw new error_1.FirebaseError(`download failed, status ${res.status}`, { exit: 1 });
+    }
+    const total = parseInt(res.response.headers.get("content-length") || "0", 10);
+    const totalMb = Math.ceil(total / 1000000);
+    const bar = new ProgressBar(`Progress: :bar (:percent of ${totalMb}MB)`, { total, head: ">" });
+    res.body.on("data", (chunk) => {
+        bar.tick(chunk.length);
+    });
+    await new Promise((resolve) => {
+        writeStream.on("finish", resolve);
+        res.body.pipe(writeStream);
+    });
+    return tmpfile.name;
+}
+exports.downloadToTmp = downloadToTmp;