firebase-tools 15.10.0 → 15.11.0

package/lib/emulator/apphosting/serve.js

@@ -20,9 +20,10 @@ const utils_1 = require("../../utils");
 const apphosting = require("../../gcp/apphosting");
 const constants_2 = require("../constants");
 const fetchWebSetup_1 = require("../../fetchWebSetup");
-const apps_1 = require("../../management/apps");
 const child_process_1 = require("child_process");
 const semver_1 = require("semver");
+const utils_2 = require("../../apphosting/utils");
+const apps_1 = require("../../management/apps");
 const secretResourceRegex = /^projects\/([^/]+)\/secrets\/([^/]+)(?:\/versions\/((?:latest)|\d+))?$/;
 const secretShorthandRegex = /^([^/@]+)(?:@((?:latest)|\d+))?$/;
 async function loadSecret(project, name) {
@@ -81,6 +82,15 @@ async function start(options) {
         startCommand = await (0, developmentServer_1.detectPackageManagerStartCommand)(backendRoot);
         developmentServer_2.logger.logLabeled("BULLET", types_1.Emulators.APPHOSTING, `starting app with: '${startCommand}'`);
     }
+    const packageManager = await (0, developmentServer_1.detectPackageManager)(backendRoot).catch(() => undefined);
+    let autoinitEnvVars = {};
+    if (packageManager === "pnpm") {
+        (0, utils_1.logLabeledWarning)("apphosting", "Firebase JS SDK autoinit does not currently support PNPM.");
+    }
+    else {
+        const webappConfig = await getBackendAppConfig(options?.projectId, options?.backendId);
+        autoinitEnvVars = (0, utils_2.getAutoinitEnvVars)(webappConfig);
+    }
     const apphostingLocalConfig = await (0, config_1.getLocalAppHostingConfiguration)(backendRoot);
     const resolveEnv = Object.entries(apphostingLocalConfig.env).map(async ([key, value]) => [
         key,
@@ -88,6 +98,7 @@ async function start(options) {
     ]);
     const environmentVariablesToInject = {
         NODE_ENV: process.env.NODE_ENV,
+        ...autoinitEnvVars,
         ...getEmulatorEnvs(),
         ...Object.fromEntries(await Promise.all(resolveEnv)),
         FIREBASE_APP_HOSTING: "1",
@@ -96,20 +107,7 @@ async function start(options) {
         PROJECT_ID: options?.projectId,
         PORT: port.toString(),
     };
-    const packageManager = await (0, developmentServer_1.detectPackageManager)(backendRoot).catch(() => undefined);
-    if (packageManager === "pnpm") {
-        (0, utils_1.logLabeledWarning)("apphosting", `Firebase JS SDK autoinit does not currently support PNPM.`);
-    }
-    else {
-        const webappConfig = await getBackendAppConfig(options?.projectId, options?.backendId);
-        if (webappConfig) {
-            environmentVariablesToInject["FIREBASE_WEBAPP_CONFIG"] || (environmentVariablesToInject["FIREBASE_WEBAPP_CONFIG"] = JSON.stringify(webappConfig));
-            environmentVariablesToInject["FIREBASE_CONFIG"] || (environmentVariablesToInject["FIREBASE_CONFIG"] = JSON.stringify({
-                databaseURL: webappConfig.databaseURL,
-                storageBucket: webappConfig.storageBucket,
-                projectId: webappConfig.projectId,
-            }));
-        }
+    if (packageManager !== "pnpm") {
         await tripFirebasePostinstall(backendRoot, environmentVariablesToInject);
     }
     (0, spawn_1.spawnWithCommandString)(startCommand, backendRoot, environmentVariablesToInject)

package/lib/emulator/downloadableEmulatorInfo.json

@@ -8,12 +8,12 @@
         "downloadPathRelativeToCacheDir": "firebase-database-emulator-v4.11.2.jar"
     },
     "firestore": {
-        "version": "1.20.2",
-        "expectedSize": 123046947,
-        "expectedChecksum": "3b04168138ff8ab17025fe7756e05dc9",
-        "expectedChecksumSHA256": "4a117fc297b1441eac1b7756e80442e86ef88865b9e3caf6f59eabf83da574f8",
-        "remoteUrl": "https://storage.googleapis.com/firebase-preview-drop/emulator/cloud-firestore-emulator-v1.20.2.jar",
-        "downloadPathRelativeToCacheDir": "cloud-firestore-emulator-v1.20.2.jar"
+        "version": "1.20.4",
+        "expectedSize": 136551710,
+        "expectedChecksum": "8397dac992e02454914dec28d23b6ed8",
+        "expectedChecksumSHA256": "49ee7814741b481ae5becfdaa7b55693bdf7a03363cd184e35c36c1595a9643",
+        "remoteUrl": "https://storage.googleapis.com/firebase-preview-drop/emulator/cloud-firestore-emulator-v1.20.4.jar",
+        "downloadPathRelativeToCacheDir": "cloud-firestore-emulator-v1.20.4.jar"
     },
     "storage": {
         "version": "1.1.3",
@@ -44,46 +44,46 @@
         }
     },
     "pubsub": {
-        "version": "0.8.27",
-        "expectedSize": 52924291,
-        "expectedChecksum": "cb0d35db6aa1bb5e3f7e2a5a690c631d",
-        "expectedChecksumSHA256": "0b793b420b608b68c200a0d15123c63967ac2863bbd9545ecb087d5b28871339",
-        "remoteUrl": "https://storage.googleapis.com/firebase-preview-drop/emulator/pubsub-emulator-0.8.27.zip",
-        "downloadPathRelativeToCacheDir": "pubsub-emulator-0.8.27.zip",
-        "binaryPathRelativeToCacheDir": "pubsub-emulator-0.8.27/pubsub-emulator/bin/cloud-pubsub-emulator"
+        "version": "0.8.29",
+        "expectedSize": 52906482,
+        "expectedChecksum": "8345b0a923dda5634dd56a25f913cf37",
+        "expectedChecksumSHA256": "31228112fb95a6818d13a88e801f4be6fb5ea5b601175b74528cc61823ea5507",
+        "remoteUrl": "https://storage.googleapis.com/firebase-preview-drop/emulator/pubsub-emulator-0.8.29.zip",
+        "downloadPathRelativeToCacheDir": "pubsub-emulator-0.8.29.zip",
+        "binaryPathRelativeToCacheDir": "pubsub-emulator-0.8.29/pubsub-emulator/bin/cloud-pubsub-emulator"
     },
     "dataconnect": {
         "darwin": {
-            "version": "3.2.1",
-            "expectedSize": 30880608,
-            "expectedChecksum": "ef63443e5132e4ade7b89506fea60e29",
-            "expectedChecksumSHA256": "0a9c05413cb3048a4bef1968e55109ca67eb607e6d77355741cb9a7dcae51607",
-            "remoteUrl": "https://storage.googleapis.com/firemat-preview-drop/emulator/dataconnect-emulator-macos-amd64-v3.2.1",
-            "downloadPathRelativeToCacheDir": "dataconnect-emulator-3.2.1"
+            "version": "3.3.0",
+            "expectedSize": 32051312,
+            "expectedChecksum": "9c9d9fb375826d90f9a57ce7a1770afc",
+            "expectedChecksumSHA256": "ae2fe4f4b9a79b6bfd52ef227dcdb5e58c5b0e3a662a3874abc07c73d2e8f8e4",
+            "remoteUrl": "https://storage.googleapis.com/firemat-preview-drop/emulator/dataconnect-emulator-macos-amd64-v3.3.0",
+            "downloadPathRelativeToCacheDir": "dataconnect-emulator-3.3.0"
         },
         "darwin_arm64": {
-            "version": "3.2.1",
-            "expectedSize": 30339010,
-            "expectedChecksum": "866989b28ae5cad1084403bd4404dcee",
-            "expectedChecksumSHA256": "558e334c456c646b1ddf4b32ab43d976c5b03c191a4c92855e8c93cd32e1215a",
-            "remoteUrl": "https://storage.googleapis.com/firemat-preview-drop/emulator/dataconnect-emulator-macos-arm64-v3.2.1",
-            "downloadPathRelativeToCacheDir": "dataconnect-emulator-3.2.1"
+            "version": "3.3.0",
+            "expectedSize": 30237490,
+            "expectedChecksum": "cd6e0b50e7614edd420a44cde1a6de54",
+            "expectedChecksumSHA256": "1524161c428f6c97ae1e4eb6371028bace2280f1090ebe89e73313afb30b7bdc",
+            "remoteUrl": "https://storage.googleapis.com/firemat-preview-drop/emulator/dataconnect-emulator-macos-arm64-v3.3.0",
+            "downloadPathRelativeToCacheDir": "dataconnect-emulator-3.3.0"
         },
         "win32": {
-            "version": "3.2.1",
-            "expectedSize": 31385088,
-            "expectedChecksum": "cb46949156c889d5724f7fa80e8a613b",
-            "expectedChecksumSHA256": "1dd1f9ef7910d8295baac61741fde29fac536d82ff841a2d5cefe25e98f7cd98",
-            "remoteUrl": "https://storage.googleapis.com/firemat-preview-drop/emulator/dataconnect-emulator-windows-amd64-v3.2.1",
-            "downloadPathRelativeToCacheDir": "dataconnect-emulator-3.2.1.exe"
+            "version": "3.3.0",
+            "expectedSize": 32093696,
+            "expectedChecksum": "e2b6a90994609e613aae189fb6bb732b",
+            "expectedChecksumSHA256": "ddf44b362658a43ffb97c23e605e26d257e786adb9a71466ebd756b36c4dd212",
+            "remoteUrl": "https://storage.googleapis.com/firemat-preview-drop/emulator/dataconnect-emulator-windows-amd64-v3.3.0",
+            "downloadPathRelativeToCacheDir": "dataconnect-emulator-3.3.0.exe"
         },
         "linux": {
-            "version": "3.2.1",
-            "expectedSize": 30798008,
-            "expectedChecksum": "8c29b6b526efcbf13de278bd3b5b598a",
-            "expectedChecksumSHA256": "d7eb7f7afd98dd9018039c83782312f975b160c3708eb49f8fecdf7d27508d82",
-            "remoteUrl": "https://storage.googleapis.com/firemat-preview-drop/emulator/dataconnect-emulator-linux-amd64-v3.2.1",
-            "downloadPathRelativeToCacheDir": "dataconnect-emulator-3.2.1"
+            "version": "3.3.0",
+            "expectedSize": 31211704,
+            "expectedChecksum": "48b40f31c1897afd39e3b256c356730a",
+            "expectedChecksumSHA256": "e6774287f3a3ea7ee240f524644e0b0441720dd5d55d6a970a6c4db9923b517f",
+            "remoteUrl": "https://storage.googleapis.com/firemat-preview-drop/emulator/dataconnect-emulator-linux-amd64-v3.3.0",
+            "downloadPathRelativeToCacheDir": "dataconnect-emulator-3.3.0"
         }
     }
 }

package/lib/emulator/functionsEmulator.js

@@ -35,6 +35,8 @@ const v1_1 = require("../functions/events/v1");
 const build_1 = require("../deploy/functions/build");
 const env_1 = require("./env");
 const python_1 = require("../functions/python");
+const supported_1 = require("../deploy/functions/runtimes/supported");
+const dart_1 = require("../deploy/functions/runtimes/dart");
 const EVENT_INVOKE_GA4 = "functions_invoke";
 const DATABASE_PATH_PATTERN = new RegExp("^projects/[^/]+/instances/([^/]+)/refs(/.*)$");
 class IPCConn {
@@ -83,6 +85,7 @@ class FunctionsEmulator {
         this.staticBackends = [];
         this.dynamicBackends = [];
         this.watchers = [];
+        this.watchCleanups = [];
         this.debugMode = false;
         this.staticBackends = args.emulatableBackends;
         emulatorLogger_1.EmulatorLogger.setVerbosity(this.args.verbosity ? emulatorLogger_1.Verbosity[this.args.verbosity] : emulatorLogger_1.Verbosity["DEBUG"]);
@@ -208,7 +211,7 @@ class FunctionsEmulator {
     async sendRequest(trigger, body) {
         const record = this.getTriggerRecordByKey(this.getTriggerKey(trigger));
         const pool = this.workerPools[record.backend.codebase];
-        if (!pool.readyForWork(trigger.id)) {
+        if (!pool.readyForWork(trigger.id, record.backend.runtime)) {
             try {
                 await this.startRuntime(record.backend, trigger);
             }
@@ -217,7 +220,7 @@ class FunctionsEmulator {
                 return;
             }
         }
-        const worker = pool.getIdleWorker(trigger.id);
+        const worker = pool.getIdleWorker(trigger.id, record.backend.runtime);
         if (this.debugMode) {
             await worker.sendDebugMsg({
                 functionTarget: trigger.entryPoint,
@@ -229,10 +232,13 @@ class FunctionsEmulator {
             "Content-Type": "application/json",
             "Content-Length": `${reqBody.length}`,
         };
+        const isDart = (0, supported_1.isLanguageRuntime)(record.backend.runtime, "dart");
+        const path = isDart ? `/${trigger.entryPoint}` : `/`;
         return new Promise((resolve, reject) => {
             const req = http.request({
                 ...worker.runtime.conn.httpReqOpts(),
-                path: `/`,
+                method: "POST",
+                path: path,
                 headers: headers,
             }, resolve);
             req.on("error", reject);
@@ -264,23 +270,43 @@ class FunctionsEmulator {
     async connect() {
         for (const backend of this.staticBackends) {
             this.logger.logLabeled("BULLET", "functions", `Watching "${backend.functionsDir}" for Cloud Functions...`);
-            const watcher = chokidar.watch(backend.functionsDir, {
-                ignored: [
-                    /.+?[\\\/]node_modules[\\\/].+?/,
-                    /(^|[\/\\])\../,
-                    /.+\.log/,
-                    /.+?[\\\/]venv[\\\/].+?/,
-                    ...(backend.ignore?.map((i) => `**/${i}`) ?? []),
-                ],
-                persistent: true,
-            });
-            this.watchers.push(watcher);
-            const debouncedLoadTriggers = (0, utils_1.debounce)(() => this.loadTriggers(backend), 1000);
-            watcher.on("change", (filePath) => {
-                this.logger.log("DEBUG", `File ${filePath} changed, reloading triggers`);
-                return debouncedLoadTriggers();
-            });
             await this.loadTriggers(backend, true);
+            const isDart = (0, supported_1.isLanguageRuntime)(backend.runtime, "dart");
+            if (isDart) {
+                const runtimeDelegateContext = {
+                    projectId: this.args.projectId,
+                    projectDir: this.args.projectDir,
+                    sourceDir: backend.functionsDir,
+                    runtime: backend.runtime,
+                };
+                const delegate = await runtimes.getRuntimeDelegate(runtimeDelegateContext);
+                this.logger.logLabeled("BULLET", "functions", `Starting build_runner watch for Dart functions...`);
+                const debouncedLoadTriggers = (0, utils_1.debounce)(() => this.loadTriggers(backend), 1000);
+                const cleanup = await delegate.watch(() => {
+                    this.logger.log("DEBUG", "build_runner rebuilt, reloading triggers");
+                    debouncedLoadTriggers();
+                });
+                this.watchCleanups.push(cleanup);
+                this.logger.logLabeled("SUCCESS", "functions", `build_runner initial build completed`);
+            }
+            else {
+                const watcher = chokidar.watch(backend.functionsDir, {
+                    ignored: [
+                        /(^|[\/\\])\../,
+                        /.+\.log/,
+                        /.+?[\\\/]node_modules[\\\/].+?/,
+                        /.+?[\\\/]venv[\\\/].+?/,
+                        ...(backend.ignore?.map((i) => `**/${i}`) ?? []),
+                    ],
+                    persistent: true,
+                });
+                this.watchers.push(watcher);
+                const debouncedLoadTriggers = (0, utils_1.debounce)(() => this.loadTriggers(backend), 1000);
+                watcher.on("change", (filePath) => {
+                    this.logger.log("DEBUG", `File ${filePath} changed, reloading triggers`);
+                    return debouncedLoadTriggers();
+                });
+            }
         }
         await this.performPostLoadOperations();
         return;
@@ -300,6 +326,10 @@ class FunctionsEmulator {
             await watcher.close();
         }
         this.watchers = [];
+        for (const cleanup of this.watchCleanups) {
+            await cleanup();
+        }
+        this.watchCleanups = [];
         if (this.destroyServer) {
             await this.destroyServer();
         }
@@ -1098,13 +1128,52 @@ class FunctionsEmulator {
             conn: new TCPConn("127.0.0.1", port),
         };
     }
+    async startDart(backend, envs) {
+        if (this.debugMode) {
+            this.logger.log("WARN", "--inspect-functions not supported for Dart functions. Ignored.");
+        }
+        const port = await portfinder.getPortPromise({
+            port: 8081 + (0, utils_1.randomInt)(0, 1000),
+        });
+        const args = ["run", "--no-serve-devtools", dart_1.DART_ENTRY_POINT];
+        const dartEnvs = { ...envs };
+        delete dartEnvs.FUNCTION_TARGET;
+        delete dartEnvs.FUNCTION_SIGNATURE_TYPE;
+        const bin = backend.bin || "dart";
+        logger_1.logger.debug(`Starting Dart runtime with args: ${args.join(" ")} on port ${port}`);
+        const childProcess = spawn(bin, args, {
+            cwd: backend.functionsDir,
+            env: {
+                ...process.env,
+                ...dartEnvs,
+                HOST: "127.0.0.1",
+                PORT: port.toString(),
+            },
+            stdio: ["pipe", "pipe", "pipe"],
+        });
+        childProcess.stdout?.on("data", (chunk) => {
+            this.logger.log("DEBUG", `[dart] ${chunk.toString("utf8")}`);
+        });
+        childProcess.stderr?.on("data", (chunk) => {
+            this.logger.log("DEBUG", `[dart] ${chunk.toString("utf8")}`);
+        });
+        return {
+            process: childProcess,
+            events: new events_1.EventEmitter(),
+            cwd: backend.functionsDir,
+            conn: new TCPConn("127.0.0.1", port),
+        };
+    }
     async startRuntime(backend, trigger) {
         const runtimeEnv = this.getRuntimeEnvs(backend, trigger);
         const secretEnvs = await this.resolveSecretEnvs(backend, trigger);
         let runtime;
-        if (backend.runtime.startsWith("python")) {
+        if ((0, supported_1.isLanguageRuntime)(backend.runtime, "python")) {
             runtime = await this.startPython(backend, { ...runtimeEnv, ...secretEnvs });
         }
+        else if ((0, supported_1.isLanguageRuntime)(backend.runtime, "dart")) {
+            runtime = await this.startDart(backend, { ...runtimeEnv, ...secretEnvs });
+        }
         else {
             runtime = await this.startNode(backend, { ...runtimeEnv, ...secretEnvs });
         }
@@ -1113,7 +1182,7 @@ class FunctionsEmulator {
             ref: backend.extensionVersion?.ref,
         };
         const pool = this.workerPools[backend.codebase];
-        const worker = pool.addWorker(trigger, runtime, extensionLogInfo);
+        const worker = pool.addWorker(trigger, runtime, extensionLogInfo, backend.runtime);
         await worker.waitForSocketReady();
         return worker;
     }
@@ -1172,10 +1241,20 @@ class FunctionsEmulator {
         });
         this.logger.log("DEBUG", `[functions] Runtime ready! Sending request!`);
         const url = new url_1.URL(`${req.protocol}://${req.hostname}${req.url}`);
-        const path = `${url.pathname}${url.search}`.replace(new RegExp(`\/${this.args.projectId}\/[^\/]*\/${req.params.trigger_name}\/?`), "/");
+        let path = `${url.pathname}${url.search}`.replace(new RegExp(`\/${this.args.projectId}\/[^\/]*\/${req.params.trigger_name}\/?`), "/");
+        const isDart = (0, supported_1.isLanguageRuntime)(record.backend.runtime, "dart");
+        if (isDart) {
+            const isBackgroundRoute = req.url.startsWith("/functions/projects/");
+            if (isBackgroundRoute || path === "/") {
+                path = `/${trigger.entryPoint}`;
+            }
+            else {
+                path = `/${trigger.entryPoint}${path}`;
+            }
+        }
         this.logger.log("DEBUG", `[functions] Got req.url=${req.url}, mapping to path=${path}`);
         const pool = this.workerPools[record.backend.codebase];
-        if (!pool.readyForWork(trigger.id)) {
+        if (!pool.readyForWork(trigger.id, record.backend.runtime)) {
             try {
                 await this.startRuntime(record.backend, trigger);
             }
@@ -1196,7 +1275,7 @@ class FunctionsEmulator {
             method,
             path,
             headers: req.headers,
-        }, res, reqBody, debugBundle);
+        }, res, reqBody, debugBundle, record.backend.runtime);
     }
 }
 exports.FunctionsEmulator = FunctionsEmulator;

package/lib/emulator/functionsRuntimeWorker.js

@@ -8,6 +8,7 @@ const events_1 = require("events");
 const emulatorLogger_1 = require("./emulatorLogger");
 const error_1 = require("../error");
 const discovery_1 = require("../deploy/functions/runtimes/discovery");
+const supported_1 = require("../deploy/functions/runtimes/supported");
 var RuntimeWorkerState;
 (function (RuntimeWorkerState) {
     RuntimeWorkerState["CREATED"] = "CREATED";
@@ -226,13 +227,14 @@ class RuntimeWorkerPool {
         this.mode = mode;
         this.workers = new Map();
     }
-    getKey(triggerId) {
+    getKey(triggerId, runtime) {
         if (this.mode === types_1.FunctionsExecutionMode.SEQUENTIAL) {
             return "~shared~";
         }
-        else {
-            return triggerId || "~diagnostic~";
+        if ((0, supported_1.isLanguageRuntime)(runtime, "dart")) {
+            return "~dart-shared~";
         }
+        return triggerId || "~diagnostic~";
     }
     refresh() {
         for (const arr of this.workers.values()) {
@@ -261,13 +263,13 @@ class RuntimeWorkerPool {
             });
         }
     }
-    readyForWork(triggerId) {
-        const idleWorker = this.getIdleWorker(triggerId);
+    readyForWork(triggerId, runtime) {
+        const idleWorker = this.getIdleWorker(triggerId, runtime);
         return !!idleWorker;
     }
-    async submitRequest(triggerId, req, resp, body, debug) {
+    async submitRequest(triggerId, req, resp, body, debug, runtime) {
         this.log(`submitRequest(triggerId=${triggerId})`);
-        const worker = this.getIdleWorker(triggerId);
+        const worker = this.getIdleWorker(triggerId, runtime);
         if (!worker) {
             throw new error_1.FirebaseError("Internal Error: can't call submitRequest without checking for idle workers");
         }
@@ -276,11 +278,11 @@ class RuntimeWorkerPool {
         }
         return worker.request(req, resp, body, !!debug);
     }
-    getIdleWorker(triggerId) {
+    getIdleWorker(triggerId, runtime) {
         this.cleanUpWorkers();
-        const triggerWorkers = this.getTriggerWorkers(triggerId);
+        const triggerWorkers = this.getTriggerWorkers(triggerId, runtime);
         if (!triggerWorkers.length) {
-            this.setTriggerWorkers(triggerId, []);
+            this.setTriggerWorkers(triggerId, [], runtime);
             return;
         }
         for (const worker of triggerWorkers) {
@@ -290,21 +292,22 @@ class RuntimeWorkerPool {
         }
         return;
     }
-    addWorker(trigger, runtime, extensionLogInfo) {
-        this.log(`addWorker(${this.getKey(trigger?.id)})`);
+    addWorker(trigger, runtime, extensionLogInfo, runtimeType) {
+        const key = this.getKey(trigger?.id, runtimeType);
+        this.log(`addWorker(${key})`);
         const disableTimeout = !trigger?.id || this.mode === types_1.FunctionsExecutionMode.SEQUENTIAL;
         const worker = new RuntimeWorker(trigger?.id, runtime, extensionLogInfo, disableTimeout ? undefined : trigger?.timeoutSeconds);
-        const keyWorkers = this.getTriggerWorkers(trigger?.id);
+        const keyWorkers = this.getTriggerWorkers(trigger?.id, runtimeType);
         keyWorkers.push(worker);
-        this.setTriggerWorkers(trigger?.id, keyWorkers);
+        this.setTriggerWorkers(trigger?.id, keyWorkers, runtimeType);
         this.log(`Adding worker with key ${worker.triggerKey}, total=${keyWorkers.length}`);
         return worker;
     }
-    getTriggerWorkers(triggerId) {
-        return this.workers.get(this.getKey(triggerId)) || [];
+    getTriggerWorkers(triggerId, runtime) {
+        return this.workers.get(this.getKey(triggerId, runtime)) || [];
     }
-    setTriggerWorkers(triggerId, workers) {
-        this.workers.set(this.getKey(triggerId), workers);
+    setTriggerWorkers(triggerId, workers, runtime) {
+        this.workers.set(this.getKey(triggerId, runtime), workers);
     }
     cleanUpWorkers() {
         for (const [key, keyWorkers] of this.workers.entries()) {