firebase-tools 14.9.0 → 14.10.1

package/lib/apphosting/backend.js

@@ -152,7 +152,7 @@ async function createGitRepoLink(projectId, location, connectionId) {
     await githubConnections.linkGitHubRepository(projectId, location, connectionId);
 }
 exports.createGitRepoLink = createGitRepoLink;
-async function ensureAppHostingComputeServiceAccount(projectId, serviceAccount, deployFromSource = false) {
+async function ensureAppHostingComputeServiceAccount(projectId, serviceAccount) {
     const sa = serviceAccount || defaultComputeServiceAccountEmail(projectId);
     const name = `projects/${projectId}/serviceAccounts/${sa}`;
     try {
@@ -162,21 +162,14 @@ async function ensureAppHostingComputeServiceAccount(projectId, serviceAccount,
         if (!(err instanceof error_1.FirebaseError)) {
             throw err;
         }
-        if (err.status === 404) {
-            await provisionDefaultComputeServiceAccount(projectId);
-        }
-        else if (err.status === 403) {
+        if (err.status === 403) {
             throw new error_1.FirebaseError(`Failed to create backend due to missing delegation permissions for ${sa}. Make sure you have the iam.serviceAccounts.actAs permission.`, { original: err });
         }
-    }
-    if (deployFromSource) {
-        const policy = await (0, resourceManager_1.getIamPolicy)(projectId);
-        const objectViewerBinding = policy.bindings.find((binding) => binding.role === "roles/storage.objectViewer");
-        if (!objectViewerBinding ||
-            !objectViewerBinding.members.includes(`serviceAccount:${defaultComputeServiceAccountEmail(projectId)}`)) {
-            await (0, resourceManager_1.addServiceAccountToRoles)(projectId, defaultComputeServiceAccountEmail(projectId), ["roles/storage.objectViewer"], true);
+        else if (err.status !== 404) {
+            throw new error_1.FirebaseError("Unexpected error occurred while testing for IAM service account permissions", { original: err });
         }
     }
+    await provisionDefaultComputeServiceAccount(projectId);
 }
 exports.ensureAppHostingComputeServiceAccount = ensureAppHostingComputeServiceAccount;
 async function promptNewBackendId(projectId, location) {
@@ -232,12 +225,22 @@ async function provisionDefaultComputeServiceAccount(projectId) {
             throw err;
         }
     }
-    await (0, resourceManager_1.addServiceAccountToRoles)(projectId, defaultComputeServiceAccountEmail(projectId), [
-        "roles/firebaseapphosting.computeRunner",
-        "roles/firebase.sdkAdminServiceAgent",
-        "roles/developerconnect.readTokenAccessor",
-        "roles/storage.objectViewer",
-    ], true);
+    try {
+        await (0, resourceManager_1.addServiceAccountToRoles)(projectId, defaultComputeServiceAccountEmail(projectId), [
+            "roles/firebaseapphosting.computeRunner",
+            "roles/firebase.sdkAdminServiceAgent",
+            "roles/developerconnect.readTokenAccessor",
+            "roles/storage.objectViewer",
+        ], true);
+    }
+    catch (err) {
+        if ((0, error_1.getErrStatus)(err) === 400) {
+            (0, utils_1.logWarning)("Your App Hosting compute service account is still being provisioned in the background. If you encounter an error, please try again after a few moments.");
+        }
+        else {
+            throw err;
+        }
+    }
 }
 async function setDefaultTrafficPolicy(projectId, location, backendId, codebaseBranch) {
     const traffic = {

package/lib/deploy/apphosting/prepare.js

@@ -13,15 +13,7 @@ async function default_1(context, options) {
     const projectId = (0, projectUtils_1.needProjectId)(options);
     await (0, apphosting_1.ensureApiEnabled)(options);
     await (0, backend_1.ensureRequiredApisEnabled)(projectId);
-    try {
-        await (0, backend_1.ensureAppHostingComputeServiceAccount)(projectId, "", true);
-    }
-    catch (err) {
-        if (err.status === 400) {
-            (0, utils_1.logLabeledWarning)("apphosting", "Your App Hosting compute service account is still being provisioned. Please try again in a few moments.");
-        }
-        throw err;
-    }
+    await (0, backend_1.ensureAppHostingComputeServiceAccount)(projectId, "");
     context.backendConfigs = new Map();
     context.backendLocations = new Map();
     context.backendStorageUris = new Map();

package/lib/emulator/controller.js

@@ -358,6 +358,7 @@ async function startAll(options, showUI = true, runningTestScript = false) {
     if (extensionEmulator) {
         await startEmulator(extensionEmulator);
     }
+    const account = (0, auth_1.getProjectDefaultAccount)(options.projectRoot);
     if (emulatableBackends.length) {
         if (!listenForEmulator.functions || !listenForEmulator.eventarc || !listenForEmulator.tasks) {
             listenForEmulator = await (0, portUtils_1.resolveHostAndAssignPorts)(Object.assign(Object.assign({}, listenForEmulator), { functions: (_h = listenForEmulator.functions) !== null && _h !== void 0 ? _h : getListenConfig(options, types_1.Emulators.FUNCTIONS), eventarc: (_j = listenForEmulator.eventarc) !== null && _j !== void 0 ? _j : getListenConfig(options, types_1.Emulators.EVENTARC), tasks: (_k = listenForEmulator.eventarc) !== null && _k !== void 0 ? _k : getListenConfig(options, types_1.Emulators.TASKS) }));
@@ -378,7 +379,6 @@ async function startAll(options, showUI = true, runningTestScript = false) {
         if (emulatorsNotRunning.length > 0 && !constants_1.Constants.isDemoProject(projectId)) {
             functionsLogger.logLabeled("WARN", "functions", `The following emulators are not running, calls to these services from the Functions emulator will affect production: ${clc.bold(emulatorsNotRunning.join(", "))}`);
         }
-        const account = (0, auth_1.getProjectDefaultAccount)(options.projectRoot);
         const functionsEmulator = new functionsEmulator_1.FunctionsEmulator({
             projectId,
             projectDir,
@@ -574,6 +574,7 @@ async function startAll(options, showUI = true, runningTestScript = false) {
             enable_output_generated_sdk: true,
             enable_output_schema_extensions: true,
             debug: options.debug,
+            account,
         };
         if (exportMetadata.dataconnect) {
             utils.assertIsString(options.import);

package/lib/emulator/dataconnect/pgliteServer.js

@@ -44,7 +44,6 @@ BEGIN
 END
 $do$;`;
 const decoder = new node_string_decoder_1.StringDecoder();
-const pgliteDebugLog = fs.createWriteStream("pglite-debug.log");
 class PostgresServer {
     async createPGServer(host = "127.0.0.1", port) {
         const getDb = this.getDb.bind(this);
@@ -244,6 +243,7 @@ class PGliteExtendedQueryPatch {
         this.connection = connection;
         this.isExtendedQuery = false;
         this.eqpErrored = false;
+        this.pgliteDebugLog = fs.createWriteStream("pglite-debug.log");
     }
     filterResponse(message, response) {
         return __asyncGenerator(this, arguments, function* filterResponse_1() {
@@ -254,7 +254,7 @@ class PGliteExtendedQueryPatch {
                 pg_gateway_1.FrontendMessageCode.Close,
             ];
             const decoded = decoder.write(message);
-            pgliteDebugLog.write("Front: " + decoded);
+            this.pgliteDebugLog.write("Front: " + decoded);
             if (pipelineStartMessages.includes(message[0])) {
                 this.isExtendedQuery = true;
             }
@@ -275,10 +275,10 @@ class PGliteExtendedQueryPatch {
                             this.eqpErrored = true;
                         }
                         if (this.isExtendedQuery && bm[0] === pg_gateway_1.BackendMessageCode.ReadyForQuery) {
-                            pgliteDebugLog.write("Filtered: " + decoder.write(bm));
+                            this.pgliteDebugLog.write("Filtered: " + decoder.write(bm));
                             continue;
                         }
-                        pgliteDebugLog.write("Sent: " + decoder.write(bm));
+                        this.pgliteDebugLog.write("Sent: " + decoder.write(bm));
                         yield yield __await(bm);
                     }
                     finally {

package/lib/emulator/dataconnectEmulator.js

@@ -250,7 +250,6 @@ class DataConnectEmulator {
         if (account) {
             const defaultCredPath = await (0, defaultCredentials_1.getCredentialPathAsync)(account);
             if (defaultCredPath) {
-                logger_1.logger.log("DEBUG", `Setting GAC to ${defaultCredPath}`);
                 credsEnv.GOOGLE_APPLICATION_CREDENTIALS = defaultCredPath;
             }
         }

package/lib/emulator/downloadableEmulatorInfo.json

@@ -54,28 +54,28 @@
     },
     "dataconnect": {
         "darwin": {
-            "version": "2.8.0",
-            "expectedSize": 29279072,
-            "expectedChecksum": "0381ba8dd2eb67629cbbf4a88b276850",
-            "expectedChecksumSHA256": "bc88bca96c83df21f7ed4b66c2a518ca48a21ba259fe481c0911fb5010d2fa0f",
-            "remoteUrl": "https://storage.googleapis.com/firemat-preview-drop/emulator/dataconnect-emulator-macos-v2.8.0",
-            "downloadPathRelativeToCacheDir": "dataconnect-emulator-2.8.0"
+            "version": "2.9.1",
+            "expectedSize": 29307744,
+            "expectedChecksum": "b6c7485c7a25b703610172a5718e372c",
+            "expectedChecksumSHA256": "2442af6068478fad6e202412ed41a9bb4ca663c27286e654042a346e8c7f1557",
+            "remoteUrl": "https://storage.googleapis.com/firemat-preview-drop/emulator/dataconnect-emulator-macos-v2.9.1",
+            "downloadPathRelativeToCacheDir": "dataconnect-emulator-2.9.1"
         },
         "win32": {
-            "version": "2.8.0",
-            "expectedSize": 29769216,
-            "expectedChecksum": "622e7c7e23b0bd7592ad5a0ca0934987",
-            "expectedChecksumSHA256": "c23484eaf8f1ac68653bb29bb307de9d1c47a1fc4005610b094772e7ac368512",
-            "remoteUrl": "https://storage.googleapis.com/firemat-preview-drop/emulator/dataconnect-emulator-windows-v2.8.0",
-            "downloadPathRelativeToCacheDir": "dataconnect-emulator-2.8.0.exe"
+            "version": "2.9.1",
+            "expectedSize": 29797888,
+            "expectedChecksum": "643ed6d0ef81488dc23f2ef5247d3f6f",
+            "expectedChecksumSHA256": "ffc2723ce25ffedb958b848c71fcda5bf488208e9d2ef4310ac4f41d6533934d",
+            "remoteUrl": "https://storage.googleapis.com/firemat-preview-drop/emulator/dataconnect-emulator-windows-v2.9.1",
+            "downloadPathRelativeToCacheDir": "dataconnect-emulator-2.9.1.exe"
         },
         "linux": {
-            "version": "2.8.0",
-            "expectedSize": 29208760,
-            "expectedChecksum": "dd9b1b9a55761f4d763a11bb7b84cbff",
-            "expectedChecksumSHA256": "7ffe98a28e9c185ddb07cdbf1610dc86747083afca9ac8cb850214ca8f1147c4",
-            "remoteUrl": "https://storage.googleapis.com/firemat-preview-drop/emulator/dataconnect-emulator-linux-v2.8.0",
-            "downloadPathRelativeToCacheDir": "dataconnect-emulator-2.8.0"
+            "version": "2.9.1",
+            "expectedSize": 29233336,
+            "expectedChecksum": "4ae414db7c87ebe8da9fe12139203d67",
+            "expectedChecksumSHA256": "777e5ee6661cce1874f8c363d06ca446838b0e98840ec51b9aa8a79af6565db7",
+            "remoteUrl": "https://storage.googleapis.com/firemat-preview-drop/emulator/dataconnect-emulator-linux-v2.9.1",
+            "downloadPathRelativeToCacheDir": "dataconnect-emulator-2.9.1"
         }
     }
 }

package/lib/extensions/paramHelper.js

@@ -33,7 +33,8 @@ function setNewDefaults(params, newDefaults) {
         if (newDefaults[param.param]) {
             param.default = newDefaults[param.param];
         }
-        else if ((param.param = `firebaseextensions.v1beta.function/location` && newDefaults["LOCATION"])) {
+        else if (param.param === `firebaseextensions.v1beta.function/location` &&
+            newDefaults["LOCATION"]) {
             param.default = newDefaults["LOCATION"];
         }
     }

package/lib/init/features/apphosting.js

@@ -22,17 +22,7 @@ async function doSetup(setup, config) {
     }
     await (0, apphosting_1.ensureApiEnabled)({ projectId });
     await (0, backend_1.ensureRequiredApisEnabled)(projectId);
-    const spinner = ora("Checking your App Hosting compute service account...").start();
-    try {
-        await (0, backend_1.ensureAppHostingComputeServiceAccount)(projectId, "", true);
-        spinner.succeed("App Hosting compute Service account is ready");
-    }
-    catch (err) {
-        if (err.status === 400) {
-            spinner.warn("Your App Hosting compute service account is still being provisioned. Please try again in a few moments.");
-        }
-        throw err;
-    }
+    await (0, backend_1.ensureAppHostingComputeServiceAccount)(projectId, "");
     utils.logBullet("This command links your local project to Firebase App Hosting. You will be able to deploy your web app with `firebase deploy` after setup.");
     const backendConfig = {
         backendId: "",

package/lib/mcp/tools/crashlytics/list_top_issues.js

@@ -12,7 +12,7 @@ exports.list_top_issues = (0, tool_js_1.tool)({
         app_id: zod_1.z
             .string()
             .optional()
-            .describe("AppId for which the issues list is fetched. Defaults to the first appId provided by firebase_list_apps."),
+            .describe("AppId for which the issues list should be fetched. For an Android application, read the mobilesdk_app_id value specified in the google-services.json file for the current package name. For an iOS Application, read the GOOGLE_APP_ID from GoogleService-Info.plist. If neither is available, use the `firebase_list_apps` tool to find an app_id to pass to this tool."),
         issue_count: zod_1.z
             .number()
             .optional()

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "firebase-tools",
-  "version": "14.9.0",
+  "version": "14.10.1",
   "description": "Command-Line Interface for Firebase",
   "main": "./lib/index.js",
   "bin": {