firebase-tools 13.34.0 → 13.35.1

package/lib/emulator/apphosting/serve.js

@@ -2,6 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.getEmulatorEnvs = exports.start = void 0;
 const net_1 = require("net");
+const clc = require("colorette");
 const portUtils_1 = require("../portUtils");
 const developmentServer_1 = require("./developmentServer");
 const constants_1 = require("../constants");
@@ -12,6 +13,9 @@ const config_1 = require("./config");
 const projectPath_1 = require("../../projectPath");
 const registry_1 = require("../registry");
 const env_1 = require("../env");
+const error_1 = require("../../error");
+const secrets = require("../../gcp/secretManager");
+const utils_1 = require("../../utils");
 async function start(options) {
     var _a;
     const hostname = constants_1.DEFAULT_HOST;
@@ -19,19 +23,56 @@ async function start(options) {
     while (!(await availablePort(hostname, port))) {
         port += 1;
     }
-    serve(port, options === null || options === void 0 ? void 0 : options.startCommand, options === null || options === void 0 ? void 0 : options.rootDirectory);
+    await serve(options === null || options === void 0 ? void 0 : options.projectId, port, options === null || options === void 0 ? void 0 : options.startCommand, options === null || options === void 0 ? void 0 : options.rootDirectory);
     return { hostname, port };
 }
 exports.start = start;
-async function serve(port, startCommand, backendRelativeDir) {
+const secretResourceRegex = /^projects\/([^/]+)\/secrets\/([^/]+)(?:\/versions\/((?:latest)|\d+))?$/;
+const secretShorthandRegex = /^([^/@]+)(?:@((?:latest)|\d+))?$/;
+async function loadSecret(project, name) {
+    var _a, _b, _c, _d;
+    let projectId;
+    let secretId;
+    let version;
+    const match = secretResourceRegex.exec(name);
+    if (match) {
+        projectId = match[1];
+        secretId = match[2];
+        version = match[3] || "latest";
+    }
+    else {
+        const match = secretShorthandRegex.exec(name);
+        if (!match) {
+            throw new error_1.FirebaseError(`Invalid secret name: ${name}`);
+        }
+        if (!project) {
+            throw new error_1.FirebaseError(`Cannot load secret ${match[1]} without a project. ` +
+                `Please use ${clc.bold("firebase use")} or pass the --project flag.`);
+        }
+        projectId = project;
+        secretId = match[1];
+        version = match[2] || "latest";
+    }
+    try {
+        return await secrets.accessSecretVersion(projectId, secretId, version);
+    }
+    catch (err) {
+        if (((_a = err === null || err === void 0 ? void 0 : err.original) === null || _a === void 0 ? void 0 : _a.code) === 403 || ((_d = (_c = (_b = err === null || err === void 0 ? void 0 : err.original) === null || _b === void 0 ? void 0 : _b.context) === null || _c === void 0 ? void 0 : _c.response) === null || _d === void 0 ? void 0 : _d.statusCode) === 403) {
+            (0, utils_1.logLabeledError)(types_1.Emulators.APPHOSTING, `Permission denied to access secret ${secretId}. Use ` +
+                `${clc.bold("firebase apphosting:secrets:grantaccess")} to get permissions.`);
+        }
+        throw err;
+    }
+}
+async function serve(projectId, port, startCommand, backendRelativeDir) {
     backendRelativeDir = backendRelativeDir !== null && backendRelativeDir !== void 0 ? backendRelativeDir : "./";
     const backendRoot = (0, projectPath_1.resolveProjectPath)({}, backendRelativeDir);
     const apphostingLocalConfig = await (0, config_1.getLocalAppHostingConfiguration)(backendRoot);
-    const environmentVariablesAsRecord = {};
-    for (const env of apphostingLocalConfig.environmentVariables) {
-        environmentVariablesAsRecord[env.variable] = env.value;
-    }
-    const environmentVariablesToInject = Object.assign(Object.assign(Object.assign({}, getEmulatorEnvs()), environmentVariablesAsRecord), { PORT: port.toString() });
+    const resolveEnv = Object.entries(apphostingLocalConfig.env).map(async ([key, value]) => [
+        key,
+        value.value ? value.value : await loadSecret(projectId, value.secret),
+    ]);
+    const environmentVariablesToInject = Object.assign(Object.assign(Object.assign({}, getEmulatorEnvs()), Object.fromEntries(await Promise.all(resolveEnv))), { PORT: port.toString() });
     if (startCommand) {
         developmentServer_2.logger.logLabeled("BULLET", types_1.Emulators.APPHOSTING, `running custom start command: '${startCommand}'`);
         await (0, spawn_1.spawnWithCommandString)(startCommand, backendRoot, environmentVariablesToInject);

package/lib/emulator/controller.js

@@ -635,6 +635,7 @@ async function startAll(options, showUI = true, runningTestScript = false) {
             apphostingLogger.logLabeled("WARN", types_1.Emulators.APPHOSTING, "The `firebase.json#emulators.apphosting.startCommandOverride` config is deprecated, please use `firebase.json#emulators.apphosting.startCommand` to set a custom start command instead");
         }
         const apphostingEmulator = new apphosting_1.AppHostingEmulator({
+            projectId: options.project,
             host: apphostingAddr.host,
             port: apphostingAddr.port,
             startCommand: (apphostingConfig === null || apphostingConfig === void 0 ? void 0 : apphostingConfig.startCommand) || (apphostingConfig === null || apphostingConfig === void 0 ? void 0 : apphostingConfig.startCommandOverride),

package/lib/emulator/dataconnect/pgliteServer.js

@@ -149,6 +149,7 @@ class PGliteExtendedQueryPatch {
     constructor(connection) {
         this.connection = connection;
         this.isExtendedQuery = false;
+        this.eqpErrored = false;
     }
     filterResponse(message, response) {
         return __asyncGenerator(this, arguments, function* filterResponse_1() {
@@ -166,6 +167,7 @@ class PGliteExtendedQueryPatch {
             }
             if (message[0] === index_1.FrontendMessageCode.Sync) {
                 this.isExtendedQuery = false;
+                this.eqpErrored = false;
                 return yield __await(this.connection.createReadyForQuery());
             }
             try {
@@ -174,8 +176,11 @@ class PGliteExtendedQueryPatch {
                     _d = false;
                     try {
                         const message = _c;
-                        if (message[0] === index_1.BackendMessageCode.ErrorMessage) {
-                            this.isExtendedQuery = false;
+                        if (this.eqpErrored) {
+                            continue;
+                        }
+                        if (this.isExtendedQuery && message[0] === index_1.BackendMessageCode.ErrorMessage) {
+                            this.eqpErrored = true;
                         }
                         if (this.isExtendedQuery && message[0] === index_1.BackendMessageCode.ReadyForQuery) {
                             logger_1.logger.debug("Filtered out a ReadyForQuery.");

package/lib/emulator/dataconnectEmulator.js

@@ -20,6 +20,7 @@ const load_1 = require("../dataconnect/load");
 const pgliteServer_1 = require("./dataconnect/pgliteServer");
 const controller_1 = require("./controller");
 const utils_1 = require("../utils");
+const env_1 = require("./env");
 exports.dataConnectEmulatorEvents = new events_1.EventEmitter();
 class DataConnectEmulator {
     constructor(args) {
@@ -33,7 +34,10 @@ class DataConnectEmulator {
         let resolvedConfigDir;
         try {
             resolvedConfigDir = this.args.config.path(this.args.configDir);
-            const info = await DataConnectEmulator.build({ configDir: resolvedConfigDir });
+            const info = await DataConnectEmulator.build({
+                configDir: resolvedConfigDir,
+                account: this.args.account,
+            });
             if ((0, types_2.requiresVector)(info.metadata)) {
                 if (constants_1.Constants.isDemoProject(this.args.projectId)) {
                     this.logger.logLabeled("WARN", "dataconnect", "Detected a 'demo-' project, but vector embeddings require a real project. Operations that use vector_embed will fail.");
@@ -46,13 +50,14 @@ class DataConnectEmulator {
         catch (err) {
             this.logger.log("DEBUG", `'fdc build' failed with error: ${err.message}`);
         }
+        const env = await DataConnectEmulator.getEnv(this.args.account, this.args.extraEnv);
         await (0, downloadableEmulators_1.start)(types_1.Emulators.DATACONNECT, {
             auto_download: this.args.auto_download,
             listen: (0, portUtils_1.listenSpecsToString)(this.args.listen),
             config_dir: resolvedConfigDir,
             enable_output_schema_extensions: this.args.enable_output_schema_extensions,
             enable_output_generated_sdk: this.args.enable_output_generated_sdk,
-        }, this.args.extraEnv);
+        }, env);
         this.usingExistingEmulator = false;
         if (this.args.autoconnectToPostgres) {
             const info = await (0, load_1.load)(this.args.projectId, this.args.config, this.args.configDir);
@@ -159,7 +164,8 @@ class DataConnectEmulator {
         if (args.watch) {
             cmd.push("--watch");
         }
-        const res = childProcess.spawnSync(commandInfo.binary, cmd, { encoding: "utf-8" });
+        const env = await DataConnectEmulator.getEnv(args.account);
+        const res = childProcess.spawnSync(commandInfo.binary, cmd, { encoding: "utf-8", env });
         if ((0, downloadableEmulators_1.isIncomaptibleArchError)(res.error)) {
             throw new error_1.FirebaseError(`Unknown system error when running the Data Connect toolkit. ` +
                 `You may be able to fix this by installing Rosetta: ` +
@@ -183,7 +189,8 @@ class DataConnectEmulator {
         if (args.projectId) {
             cmd.push(`--project_id=${args.projectId}`);
         }
-        const res = childProcess.spawnSync(commandInfo.binary, cmd, { encoding: "utf-8" });
+        const env = await DataConnectEmulator.getEnv(args.account);
+        const res = childProcess.spawnSync(commandInfo.binary, cmd, { encoding: "utf-8", env });
         if ((0, downloadableEmulators_1.isIncomaptibleArchError)(res.error)) {
             throw new error_1.FirebaseError(`Unkown system error when running the Data Connect toolkit. ` +
                 `You may be able to fix this by installing Rosetta: ` +
@@ -236,6 +243,10 @@ class DataConnectEmulator {
         }
         return false;
     }
+    static async getEnv(account, extraEnv = {}) {
+        const credsEnv = await (0, env_1.getCredentialsEnvironment)(account, emulatorLogger_1.EmulatorLogger.forEmulator(types_1.Emulators.DATACONNECT), "dataconnect");
+        return Object.assign(Object.assign(Object.assign({}, process.env), extraEnv), credsEnv);
+    }
 }
 exports.DataConnectEmulator = DataConnectEmulator;
 class DataConnectEmulatorClient {

package/lib/emulator/downloadableEmulators.js

@@ -48,20 +48,20 @@ const EMULATOR_UPDATE_DETAILS = {
     },
     dataconnect: process.platform === "darwin"
         ? {
-            version: "1.8.5",
-            expectedSize: 25600768,
-            expectedChecksum: "7e2a935f972ce30e075cca1f36e24663",
+            version: "1.9.2",
+            expectedSize: 26403584,
+            expectedChecksum: "a0a957bb5d564059ed883fee9e9fd67a",
         }
         : process.platform === "win32"
             ? {
-                version: "1.8.5",
-                expectedSize: 26031616,
-                expectedChecksum: "da063f9893b0ff4c99f280653c717977",
+                version: "1.9.2",
+                expectedSize: 26846208,
+                expectedChecksum: "80f49b574aa69ef76fb49e2e96c8a699",
             }
             : {
-                version: "1.8.5",
-                expectedSize: 25514136,
-                expectedChecksum: "6564f779f7f5a467e587d7093ed7c3e3",
+                version: "1.9.2",
+                expectedSize: 26316952,
+                expectedChecksum: "cc3c0318e453d9ddf098b582ee0f2b77",
             },
 };
 exports.DownloadDetails = {

package/lib/emulator/env.js

@@ -1,9 +1,10 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.setEnvVarsForEmulators = void 0;
+exports.getCredentialsEnvironment = exports.setEnvVarsForEmulators = void 0;
 const constants_1 = require("./constants");
 const types_1 = require("./types");
 const functionsEmulatorShared_1 = require("./functionsEmulatorShared");
+const defaultCredentials_1 = require("../defaultCredentials");
 function setEnvVarsForEmulators(env, emulators) {
     for (const emu of emulators) {
         const host = (0, functionsEmulatorShared_1.formatHost)(emu);
@@ -40,3 +41,18 @@ function setEnvVarsForEmulators(env, emulators) {
     }
 }
 exports.setEnvVarsForEmulators = setEnvVarsForEmulators;
+async function getCredentialsEnvironment(account, logger, logLabel) {
+    const credentialEnv = {};
+    if (await (0, defaultCredentials_1.hasDefaultCredentials)()) {
+        logger.logLabeled("WARN", logLabel, `Application Default Credentials detected. Non-emulated services will access production using these credentials. Be careful!`);
+    }
+    else if (account) {
+        const defaultCredPath = await (0, defaultCredentials_1.getCredentialPathAsync)(account);
+        if (defaultCredPath) {
+            logger.log("DEBUG", `Setting GAC to ${defaultCredPath}`);
+            credentialEnv.GOOGLE_APPLICATION_CREDENTIALS = defaultCredPath;
+        }
+    }
+    return credentialEnv;
+}
+exports.getCredentialsEnvironment = getCredentialsEnvironment;

package/lib/emulator/functionsEmulator.js

@@ -25,7 +25,6 @@ const functionsRuntimeWorker_1 = require("./functionsRuntimeWorker");
 const error_1 = require("../error");
 const workQueue_1 = require("./workQueue");
 const utils_1 = require("../utils");
-const defaultCredentials_1 = require("../defaultCredentials");
 const adminSdkConfig_1 = require("./adminSdkConfig");
 const validate_1 = require("../deploy/functions/validate");
 const secretManager_1 = require("../gcp/secretManager");
@@ -111,7 +110,7 @@ class FunctionsEmulator {
             this.dynamicBackends =
                 this.args.extensionsEmulator.filterUnemulatedTriggers(unfilteredBackends);
             const mode = this.debugMode ? types_1.FunctionsExecutionMode.SEQUENTIAL : types_1.FunctionsExecutionMode.AUTO;
-            const credentialEnv = await this.getCredentialsEnvironment();
+            const credentialEnv = await (0, env_1.getCredentialsEnvironment)(this.args.account, this.logger, "functions");
             for (const backend of this.dynamicBackends) {
                 backend.env = Object.assign(Object.assign({}, credentialEnv), backend.env);
                 if (this.workerPools[backend.codebase]) {
@@ -130,23 +129,6 @@ class FunctionsEmulator {
             }
         }
     }
-    async getCredentialsEnvironment() {
-        const credentialEnv = {};
-        if (process.env.GOOGLE_APPLICATION_CREDENTIALS) {
-            this.logger.logLabeled("WARN", "functions", `Your GOOGLE_APPLICATION_CREDENTIALS environment variable points to ${process.env.GOOGLE_APPLICATION_CREDENTIALS}. Non-emulated services will access production using these credentials. Be careful!`);
-        }
-        else if (this.args.account) {
-            const defaultCredPath = await (0, defaultCredentials_1.getCredentialPathAsync)(this.args.account);
-            if (defaultCredPath) {
-                this.logger.log("DEBUG", `Setting GAC to ${defaultCredPath}`);
-                credentialEnv.GOOGLE_APPLICATION_CREDENTIALS = defaultCredPath;
-            }
-        }
-        else {
-            this.logger.logLabeled("WARN", "functions", "You are not signed in to the Firebase CLI. If you have authorized this machine using gcloud application-default credentials those may be discovered and used to access production services.");
-        }
-        return credentialEnv;
-    }
     createHubServer() {
         this.workQueue.start();
         const hub = express();
@@ -255,7 +237,7 @@ class FunctionsEmulator {
         });
     }
     async start() {
-        const credentialEnv = await this.getCredentialsEnvironment();
+        const credentialEnv = await (0, env_1.getCredentialsEnvironment)(this.args.account, this.logger, "functions");
         for (const e of this.staticBackends) {
             e.env = Object.assign(Object.assign({}, credentialEnv), e.env);
         }

package/lib/extensions/extensionsHelper.js

@@ -868,10 +868,14 @@ function isUrlPath(extInstallPath) {
 exports.isUrlPath = isUrlPath;
 function isLocalPath(extInstallPath) {
     const trimmedPath = extInstallPath.trim();
-    return (trimmedPath.startsWith("~/") ||
-        trimmedPath.startsWith("./") ||
-        trimmedPath.startsWith("../") ||
-        trimmedPath.startsWith("/") ||
+    return (trimmedPath.startsWith(`~${path.sep}`) ||
+        trimmedPath.startsWith(`.${path.sep}`) ||
+        trimmedPath.startsWith(`..${path.sep}`) ||
+        trimmedPath.startsWith(`${path.sep}`) ||
+        trimmedPath.startsWith(`~/`) ||
+        trimmedPath.startsWith(`./`) ||
+        trimmedPath.startsWith(`../`) ||
+        trimmedPath.startsWith(`/`) ||
         [".", ".."].includes(trimmedPath));
 }
 exports.isLocalPath = isLocalPath;

package/lib/frameworks/angular/utils.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.tryToGetOptionsForTarget = exports.getAngularVersion = exports.getBuildConfig = exports.getServerConfig = exports.getBrowserConfig = exports.getContext = exports.getAllTargets = void 0;
+exports.getBuilderType = exports.tryToGetOptionsForTarget = exports.getAngularVersion = exports.getBuildConfig = exports.getServerConfig = exports.getBrowserConfig = exports.getContext = exports.getAllTargets = exports.BuilderType = void 0;
 const utils_1 = require("../utils");
 const error_1 = require("../../error");
 const path_1 = require("path");
@@ -54,24 +54,30 @@ async function localesForTarget(dir, architectHost, target, workspaceProject) {
     (0, utils_1.validateLocales)(locales);
     return { locales, defaultLocale };
 }
-const DEV_SERVER_TARGETS = [
-    "@angular-devkit/build-angular:dev-server",
-    "@nguniversal/builders:ssr-dev-server",
-    "@angular-devkit/build-angular:ssr-dev-server",
-];
-function getValidBuilders(purpose) {
+var BuilderType;
+(function (BuilderType) {
+    BuilderType["DEPLOY"] = "deploy";
+    BuilderType["DEV_SERVER"] = "dev-server";
+    BuilderType["SSR_DEV_SERVER"] = "ssr-dev-server";
+    BuilderType["SERVER"] = "server";
+    BuilderType["BROWSER"] = "browser";
+    BuilderType["BROWSER_ESBUILD"] = "browser-esbuild";
+    BuilderType["APPLICATION"] = "application";
+    BuilderType["PRERENDER"] = "prerender";
+})(BuilderType = exports.BuilderType || (exports.BuilderType = {}));
+const DEV_SERVER_TARGETS = [BuilderType.DEV_SERVER, BuilderType.SSR_DEV_SERVER];
+function getValidBuilderTypes(purpose) {
     return [
-        "@angular-devkit/build-angular:application",
-        "@angular-devkit/build-angular:browser-esbuild",
-        "@angular/fire:deploy",
-        "@angular-devkit/build-angular:browser",
-        "@angular-devkit/build-angular:prerender",
-        "@nguniversal/builders:prerender",
+        BuilderType.APPLICATION,
+        BuilderType.BROWSER_ESBUILD,
+        BuilderType.DEPLOY,
+        BuilderType.BROWSER,
+        BuilderType.PRERENDER,
         ...(purpose === "deploy" ? [] : DEV_SERVER_TARGETS),
     ];
 }
 async function getAllTargets(purpose, dir) {
-    const validBuilders = getValidBuilders(purpose);
+    const validBuilderTypes = getValidBuilderTypes(purpose);
     const [{ NodeJsAsyncHost }, { workspaces }, { targetStringFromTarget }] = await Promise.all([
         (0, utils_1.relativeRequire)(dir, "@angular-devkit/core/node"),
         (0, utils_1.relativeRequire)(dir, "@angular-devkit/core"),
@@ -84,8 +90,10 @@ async function getAllTargets(purpose, dir) {
         if (projectDefinition.extensions.projectType !== "application")
             return;
         projectDefinition.targets.forEach((targetDefinition, target) => {
-            if (!validBuilders.includes(targetDefinition.builder))
+            const builderType = getBuilderType(targetDefinition.builder);
+            if (builderType && !validBuilderTypes.includes(builderType)) {
                 return;
+            }
             const configurations = Object.keys(targetDefinition.configurations || {});
             if (!configurations.includes("production"))
                 configurations.push("production");
@@ -152,34 +160,32 @@ async function getContext(dir, targetOrConfiguration) {
         throw new error_1.FirebaseError(`No project ${project} found.`);
     if (overrideTarget) {
         const target = workspaceProject.targets.get(overrideTarget.target);
-        const builder = target.builder;
-        switch (builder) {
-            case "@angular/fire:deploy":
+        const builderType = getBuilderType(target.builder);
+        switch (builderType) {
+            case BuilderType.DEPLOY:
                 deployTarget = overrideTarget;
                 break;
-            case "@angular-devkit/build-angular:application":
+            case BuilderType.APPLICATION:
                 buildTarget = overrideTarget;
                 break;
-            case "@angular-devkit/build-angular:browser-esbuild":
-            case "@angular-devkit/build-angular:browser":
+            case BuilderType.BROWSER:
+            case BuilderType.BROWSER_ESBUILD:
                 browserTarget = overrideTarget;
                 break;
-            case "@angular-devkit/build-angular:prerender":
-            case "@nguniversal/builders:prerender":
+            case BuilderType.PRERENDER:
                 prerenderTarget = overrideTarget;
                 break;
-            case "@angular-devkit/build-angular:dev-server":
-            case "@nguniversal/builders:ssr-dev-server":
-            case "@angular-devkit/build-angular:ssr-dev-server":
+            case BuilderType.DEV_SERVER:
+            case BuilderType.SSR_DEV_SERVER:
                 serveTarget = overrideTarget;
                 break;
             default:
-                throw new error_1.FirebaseError(`builder ${builder} not known.`);
+                throw new error_1.FirebaseError(`builder type ${builderType} not known.`);
         }
     }
     else if (workspaceProject.targets.has("deploy")) {
         const { builder, defaultConfiguration = "production" } = workspaceProject.targets.get("deploy");
-        if (builder === "@angular/fire:deploy") {
+        if (getBuilderType(builder) === BuilderType.DEPLOY) {
             deployTarget = {
                 project,
                 target: "deploy",
@@ -251,13 +257,13 @@ async function getContext(dir, targetOrConfiguration) {
         }
         if (!buildTarget && !browserTarget && workspaceProject.targets.has("build")) {
             const { builder, defaultConfiguration = "production" } = workspaceProject.targets.get("build");
+            const builderType = getBuilderType(builder);
             const target = {
                 project,
                 target: "build",
                 configuration: configuration || defaultConfiguration,
             };
-            if (builder === "@angular-devkit/build-angular:browser" ||
-                builder === "@angular-devkit/build-angular:browser-esbuild") {
+            if (builderType === BuilderType.BROWSER || builderType === BuilderType.BROWSER_ESBUILD) {
                 browserTarget = target;
             }
             else {
@@ -307,27 +313,30 @@ async function getContext(dir, targetOrConfiguration) {
             if (!definition)
                 throw new error_1.FirebaseError(`${target} could not be found in your angular.json`);
             const { builder } = definition;
-            if (target === deployTarget && builder === "@angular/fire:deploy")
+            const builderType = getBuilderType(builder);
+            if (target === deployTarget && builderType === BuilderType.DEPLOY)
+                continue;
+            if (target === buildTarget && builderType === BuilderType.APPLICATION)
                 continue;
-            if (target === buildTarget && builder === "@angular-devkit/build-angular:application")
+            if (target === buildTarget && builderType === BuilderType.BROWSER)
                 continue;
-            if (target === buildTarget && builder === "@angular-devkit/build-angular:browser")
+            if (target === browserTarget && builderType === BuilderType.BROWSER_ESBUILD)
                 continue;
-            if (target === browserTarget && builder === "@angular-devkit/build-angular:browser-esbuild")
+            if (target === browserTarget && builderType === BuilderType.BROWSER)
                 continue;
-            if (target === browserTarget && builder === "@angular-devkit/build-angular:browser")
+            if (target === browserTarget && builderType === BuilderType.APPLICATION)
                 continue;
-            if (target === prerenderTarget && builder === "@angular-devkit/build-angular:prerender")
+            if (target === prerenderTarget && builderType === BuilderType.PRERENDER)
                 continue;
-            if (target === prerenderTarget && builder === "@nguniversal/builders:prerender")
+            if (target === prerenderTarget && builderType === BuilderType.PRERENDER)
                 continue;
-            if (target === serverTarget && builder === "@angular-devkit/build-angular:server")
+            if (target === serverTarget && builderType === BuilderType.SERVER)
                 continue;
-            if (target === serveTarget && builder === "@nguniversal/builders:ssr-dev-server")
+            if (target === serveTarget && builderType === BuilderType.SSR_DEV_SERVER)
                 continue;
-            if (target === serveTarget && builder === "@angular-devkit/build-angular:ssr-dev-server")
+            if (target === serveTarget && builderType === BuilderType.DEV_SERVER)
                 continue;
-            if (target === serveTarget && builder === "@angular-devkit/build-angular:dev-server")
+            if (target === serveTarget && builderType === BuilderType.SERVER)
                 continue;
             throw new error_1.FirebaseError(`${definition.builder} (${targetString}) is not a recognized builder. Please check your angular.json`);
         }
@@ -373,7 +382,7 @@ async function getBrowserConfig(sourceDir, configuration) {
         architectHost.getBuilderNameForTarget(buildOrBrowserTarget),
     ]);
     (0, utils_2.assertIsString)(targetOptions === null || targetOptions === void 0 ? void 0 : targetOptions.outputPath);
-    const outputPath = (0, path_1.join)(targetOptions.outputPath, buildTarget && builderName === "@angular-devkit/build-angular:application" ? "browser" : "");
+    const outputPath = (0, path_1.join)(targetOptions.outputPath, buildTarget && getBuilderType(builderName) === BuilderType.APPLICATION ? "browser" : "");
     return { locales, baseHref, outputPath, defaultLocale };
 }
 exports.getBrowserConfig = getBrowserConfig;
@@ -475,3 +484,12 @@ exports.tryToGetOptionsForTarget = tryToGetOptionsForTarget;
 function throwCannotDetermineTarget(error) {
     throw new error_1.FirebaseError(`Unable to determine the application to deploy, specify a target via the FIREBASE_FRAMEWORKS_BUILD_TARGET environment variable.`, { original: error });
 }
+function getBuilderType(builder) {
+    const colonIndex = builder.lastIndexOf(":");
+    const builderType = colonIndex >= 0 ? builder.slice(colonIndex + 1) : undefined;
+    if (!builderType || !Object.values(BuilderType).includes(builderType)) {
+        return null;
+    }
+    return builderType;
+}
+exports.getBuilderType = getBuilderType;

package/lib/functions/artifacts.js

@@ -0,0 +1,105 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.hasCleanupOptOut = exports.hasSameCleanupPolicy = exports.setCleanupPolicy = exports.optOutRepository = exports.updateRepository = exports.generateCleanupPolicy = exports.parseDaysFromPolicy = exports.daysToSeconds = exports.findExistingPolicy = exports.makeRepoPath = exports.DEFAULT_CLEANUP_DAYS = exports.OPT_OUT_LABEL_KEY = exports.CLEANUP_POLICY_ID = exports.GCF_REPO_ID = void 0;
+const artifactregistry = require("../gcp/artifactregistry");
+const error_1 = require("../error");
+exports.GCF_REPO_ID = "gcf-artifacts";
+exports.CLEANUP_POLICY_ID = "firebase-functions-cleanup";
+exports.OPT_OUT_LABEL_KEY = "firebase-functions-cleanup-opted-out";
+exports.DEFAULT_CLEANUP_DAYS = 1;
+const SECONDS_IN_DAY = 24 * 60 * 60;
+function makeRepoPath(projectId, location, repoName = exports.GCF_REPO_ID) {
+    return `projects/${projectId}/locations/${location}/repositories/${repoName}`;
+}
+exports.makeRepoPath = makeRepoPath;
+function findExistingPolicy(repository) {
+    var _a;
+    return (_a = repository === null || repository === void 0 ? void 0 : repository.cleanupPolicies) === null || _a === void 0 ? void 0 : _a[exports.CLEANUP_POLICY_ID];
+}
+exports.findExistingPolicy = findExistingPolicy;
+function daysToSeconds(days) {
+    const seconds = days * SECONDS_IN_DAY;
+    return `${seconds}s`;
+}
+exports.daysToSeconds = daysToSeconds;
+function parseDaysFromPolicy(olderThan) {
+    const match = olderThan.match(/^(\d+)s$/);
+    if (match && match[1]) {
+        const seconds = parseInt(match[1], 10);
+        return Math.floor(seconds / SECONDS_IN_DAY);
+    }
+    return;
+}
+exports.parseDaysFromPolicy = parseDaysFromPolicy;
+function generateCleanupPolicy(daysToKeep) {
+    return {
+        [exports.CLEANUP_POLICY_ID]: {
+            id: exports.CLEANUP_POLICY_ID,
+            condition: {
+                tagState: "ANY",
+                olderThan: daysToSeconds(daysToKeep),
+            },
+            action: "DELETE",
+        },
+    };
+}
+exports.generateCleanupPolicy = generateCleanupPolicy;
+async function updateRepository(repo) {
+    try {
+        await artifactregistry.updateRepository(repo);
+    }
+    catch (err) {
+        if (err.status === 403) {
+            throw new error_1.FirebaseError(`You don't have permission to update this repository.\n` +
+                `To update repository settings, ask your administrator to grant you the ` +
+                `Artifact Registry Administrator (roles/artifactregistry.admin) IAM role on the repository project.`, { original: err, exit: 1 });
+        }
+        else {
+            throw new error_1.FirebaseError("Failed to update artifact registry repository", {
+                original: err,
+            });
+        }
+    }
+}
+exports.updateRepository = updateRepository;
+async function optOutRepository(repository) {
+    const policies = Object.assign({}, repository.cleanupPolicies);
+    if (exports.CLEANUP_POLICY_ID in policies) {
+        delete policies[exports.CLEANUP_POLICY_ID];
+    }
+    const update = {
+        name: repository.name,
+        labels: Object.assign(Object.assign({}, repository.labels), { [exports.OPT_OUT_LABEL_KEY]: "true" }),
+        cleanupPolicies: policies,
+    };
+    await exports.updateRepository(update);
+}
+exports.optOutRepository = optOutRepository;
+async function setCleanupPolicy(repository, daysToKeep) {
+    const labels = Object.assign({}, repository.labels);
+    delete labels[exports.OPT_OUT_LABEL_KEY];
+    const update = {
+        name: repository.name,
+        cleanupPolicies: Object.assign(Object.assign({}, repository.cleanupPolicies), generateCleanupPolicy(daysToKeep)),
+        labels,
+    };
+    await exports.updateRepository(update);
+}
+exports.setCleanupPolicy = setCleanupPolicy;
+function hasSameCleanupPolicy(repository, daysToKeep) {
+    var _a, _b;
+    const existingPolicy = findExistingPolicy(repository);
+    if (!existingPolicy) {
+        return false;
+    }
+    if (((_a = existingPolicy.condition) === null || _a === void 0 ? void 0 : _a.tagState) !== "ANY" || !((_b = existingPolicy.condition) === null || _b === void 0 ? void 0 : _b.olderThan)) {
+        return false;
+    }
+    const existingSeconds = parseDaysFromPolicy(existingPolicy.condition.olderThan);
+    return existingSeconds === daysToKeep;
+}
+exports.hasSameCleanupPolicy = hasSameCleanupPolicy;
+function hasCleanupOptOut(repo) {
+    return !!(repo.labels && repo.labels[exports.OPT_OUT_LABEL_KEY] === "true");
+}
+exports.hasCleanupOptOut = hasCleanupOptOut;