firebase-tools 13.17.0 → 13.19.0

package/lib/deploy/extensions/prepare.js

@@ -17,20 +17,19 @@ const etags_1 = require("../../extensions/etags");
 const v2FunctionHelper_1 = require("./v2FunctionHelper");
 const tos_1 = require("../../extensions/tos");
 const common_1 = require("../../extensions/runtimes/common");
-const projectConfig_1 = require("../../functions/projectConfig");
 const functionsDeployHelper_1 = require("../functions/functionsDeployHelper");
-async function prepareHelper(context, options, payload, wantExtensions, noDeleteExtensions, isPrimaryCall) {
+async function prepareHelper(context, options, payload, wantExtensions, haveExtensions, isDynamic) {
     var _a, _b;
     const projectId = (0, projectUtils_1.needProjectId)(options);
-    context.have = await planner.have(projectId);
     context.want = wantExtensions;
+    context.have = haveExtensions;
     const etagsChanged = (0, etags_1.detectEtagChanges)(options.rc, projectId, context.have);
     if (etagsChanged.length) {
         const wantChangedIds = wantExtensions
             .map((e) => e.instanceId)
             .filter((id) => etagsChanged.includes(id));
         if (wantChangedIds.length) {
-            (0, warnings_1.outOfBandChangesWarning)(wantChangedIds);
+            (0, warnings_1.outOfBandChangesWarning)(wantChangedIds, isDynamic);
             if (!(await prompt.confirm({
                 message: `Do you wish to continue deploying these extension instances?`,
                 default: false,
@@ -52,7 +51,7 @@ async function prepareHelper(context, options, payload, wantExtensions, noDelete
     payload.instancesToCreate = context.want.filter((i) => { var _a; return !((_a = context.have) === null || _a === void 0 ? void 0 : _a.some(matchesInstanceId(i))); });
     payload.instancesToConfigure = context.want.filter((i) => { var _a; return (_a = context.have) === null || _a === void 0 ? void 0 : _a.some(isConfigure(i)); });
     payload.instancesToUpdate = context.want.filter((i) => { var _a; return (_a = context.have) === null || _a === void 0 ? void 0 : _a.some(isUpdate(i)); });
-    payload.instancesToDelete = context.have.filter((i) => { var _a; return !((_a = context.want) === null || _a === void 0 ? void 0 : _a.some(matchesInstanceId(i))) && !(noDeleteExtensions === null || noDeleteExtensions === void 0 ? void 0 : noDeleteExtensions.some(matchesInstanceId(i))); });
+    payload.instancesToDelete = context.have.filter((i) => { var _a; return !((_a = context.want) === null || _a === void 0 ? void 0 : _a.some(matchesInstanceId(i))); });
     if (await (0, warnings_1.displayWarningsForDeploy)(payload.instancesToCreate)) {
         if (!(await prompt.confirm({
             message: `Do you wish to continue deploying these extension instances?`,
@@ -64,9 +63,6 @@ async function prepareHelper(context, options, payload, wantExtensions, noDelete
         }
     }
     const permissionsNeeded = [];
-    if (!isPrimaryCall) {
-        payload.instancesToDelete = [];
-    }
     if (payload.instancesToCreate.length) {
         permissionsNeeded.push("firebaseextensions.instances.create");
         logger_1.logger.info(deploymentSummary.createsSummary(payload.instancesToCreate));
@@ -80,15 +76,20 @@ async function prepareHelper(context, options, payload, wantExtensions, noDelete
         logger_1.logger.info(deploymentSummary.configuresSummary(payload.instancesToConfigure));
     }
     if (payload.instancesToDelete.length) {
-        logger_1.logger.info(deploymentSummary.deletesSummary(payload.instancesToDelete));
-        if (!(await prompt.confirm({
-            message: `Would you like to delete ${payload.instancesToDelete
-                .map((i) => i.instanceId)
-                .join(", ")}?`,
-            default: false,
-            nonInteractive: options.nonInteractive,
-            force: options.force,
-        }))) {
+        logger_1.logger.info(deploymentSummary.deletesSummary(payload.instancesToDelete, isDynamic));
+        if (options.dryRun) {
+            logger_1.logger.info("On your next deploy, you will be asked if you want to delete these instances.");
+            logger_1.logger.info("If you deploy --force, they will be deleted.");
+        }
+        if (!options.dryRun &&
+            !(await prompt.confirm({
+                message: `Would you like to delete ${payload.instancesToDelete
+                    .map((i) => i.instanceId)
+                    .join(", ")}?`,
+                default: false,
+                nonInteractive: options.nonInteractive,
+                force: options.force,
+            }))) {
             payload.instancesToDelete = [];
         }
         else {
@@ -96,61 +97,36 @@ async function prepareHelper(context, options, payload, wantExtensions, noDelete
         }
     }
     await (0, requirePermissions_1.requirePermissions)(options, permissionsNeeded);
-    await (0, tos_1.acceptLatestAppDeveloperTOS)(options, projectId, context.want.map((i) => i.instanceId));
+    if (options.dryRun) {
+        const appDevTos = await (0, tos_1.getAppDeveloperTOSStatus)(projectId);
+        if (!appDevTos.lastAcceptedVersion) {
+            logger_1.logger.info("On your next deploy, you will be asked to accept the Firebase Extensions App Developer Terms of Service");
+        }
+    }
+    else {
+        await (0, tos_1.acceptLatestAppDeveloperTOS)(options, projectId, context.want.map((i) => i.instanceId));
+    }
 }
 async function prepareDynamicExtensions(context, options, payload, builds) {
     const filters = (0, functionsDeployHelper_1.getEndpointFilters)(options);
     const extensions = (0, common_1.extractExtensionsFromBuilds)(builds, filters);
-    const isApiEnabled = await (0, extensionsHelper_1.checkExtensionsApiEnabled)(options);
-    if (Object.keys(extensions).length === 0 && !isApiEnabled) {
-        return;
-    }
     const projectId = (0, projectUtils_1.needProjectId)(options);
     const projectNumber = await (0, projectUtils_1.needProjectNumber)(options);
-    const aliases = (0, projectUtils_1.getAliases)(options, projectId);
-    const projectDir = options.config.projectDir;
-    const isPrimaryCall = !!options.only && !options.only.split(",").includes("extensions");
     await (0, extensionsHelper_1.ensureExtensionsApiEnabled)(options);
     await (0, requirePermissions_1.requirePermissions)(options, ["firebaseextensions.instances.list"]);
+    let haveExtensions = await planner.haveDynamic(projectId);
+    haveExtensions = haveExtensions.filter((e) => { var _a; return (0, common_1.extensionMatchesAnyFilter)((_a = e.labels) === null || _a === void 0 ? void 0 : _a.codebase, e.instanceId, filters); });
+    if (Object.keys(extensions).length === 0 && haveExtensions.length === 0) {
+        return;
+    }
     const dynamicWant = await planner.wantDynamic({
         projectId,
         projectNumber,
         extensions,
     });
-    let noDeleteExtensions = [];
-    if (isPrimaryCall) {
-        const firebaseJsonWant = await planner.want({
-            projectId,
-            projectNumber,
-            aliases,
-            projectDir,
-            extensions: options.config.get("extensions", {}),
-        });
-        noDeleteExtensions = noDeleteExtensions.concat(firebaseJsonWant);
-        if (hasNonDeployingCodebases(options)) {
-            const dynamicAll = await planner.wantDynamic({
-                projectId,
-                projectNumber,
-                extensions: await (0, common_1.extractAllDynamicExtensions)(options),
-            });
-            noDeleteExtensions = noDeleteExtensions.concat(dynamicAll);
-        }
-    }
-    return prepareHelper(context, options, payload, dynamicWant, noDeleteExtensions, isPrimaryCall);
+    return prepareHelper(context, options, payload, dynamicWant, haveExtensions, true);
 }
 exports.prepareDynamicExtensions = prepareDynamicExtensions;
-function hasNonDeployingCodebases(options) {
-    const functionFilters = (0, functionsDeployHelper_1.getEndpointFilters)(options);
-    if (functionFilters === null || functionFilters === void 0 ? void 0 : functionFilters.length) {
-        return true;
-    }
-    const functionsConfig = (0, projectConfig_1.normalizeAndValidate)(options.config.src.functions);
-    const allCodebases = (0, functionsDeployHelper_1.targetCodebases)(functionsConfig);
-    const deployingCodebases = (0, functionsDeployHelper_1.targetCodebases)(functionsConfig, functionFilters);
-    if (allCodebases.length > deployingCodebases.length) {
-        return true;
-    }
-}
 async function prepare(context, options, payload) {
     context.extensionsStartTime = Date.now();
     const projectId = (0, projectUtils_1.needProjectId)(options);
@@ -159,19 +135,15 @@ async function prepare(context, options, payload) {
     const projectDir = options.config.projectDir;
     await (0, extensionsHelper_1.ensureExtensionsApiEnabled)(options);
     await (0, requirePermissions_1.requirePermissions)(options, ["firebaseextensions.instances.list"]);
-    const firebaseJsonWant = await planner.want({
+    const wantExtensions = await planner.want({
         projectId,
         projectNumber,
         aliases,
         projectDir,
         extensions: options.config.get("extensions", {}),
     });
-    const dynamicWant = await planner.wantDynamic({
-        projectId,
-        projectNumber,
-        extensions: await (0, common_1.extractAllDynamicExtensions)(options),
-    });
-    return prepareHelper(context, options, payload, firebaseJsonWant, dynamicWant, true);
+    const haveExtensions = await planner.have(projectId);
+    return prepareHelper(context, options, payload, wantExtensions, haveExtensions, false);
 }
 exports.prepare = prepare;
 const matchesInstanceId = (dep) => (test) => {

package/lib/deploy/extensions/release.js

@@ -24,20 +24,20 @@ async function release(context, options, payload) {
         concurrency: 5,
         handler: tasks.extensionsDeploymentHandler(errorHandler),
     });
-    for (const creation of (_a = payload.instancesToCreate) !== null && _a !== void 0 ? _a : []) {
-        const task = tasks.createExtensionInstanceTask(projectId, creation);
+    for (const inst of (_a = payload.instancesToConfigure) !== null && _a !== void 0 ? _a : []) {
+        const task = tasks.configureExtensionInstanceTask(projectId, inst);
         void deploymentQueue.run(task);
     }
-    for (const update of (_b = payload.instancesToUpdate) !== null && _b !== void 0 ? _b : []) {
-        const task = tasks.updateExtensionInstanceTask(projectId, update);
+    for (const inst of (_b = payload.instancesToDelete) !== null && _b !== void 0 ? _b : []) {
+        const task = tasks.deleteExtensionInstanceTask(projectId, inst);
         void deploymentQueue.run(task);
     }
-    for (const update of (_c = payload.instancesToConfigure) !== null && _c !== void 0 ? _c : []) {
-        const task = tasks.configureExtensionInstanceTask(projectId, update);
+    for (const inst of (_c = payload.instancesToCreate) !== null && _c !== void 0 ? _c : []) {
+        const task = tasks.createExtensionInstanceTask(projectId, inst);
         void deploymentQueue.run(task);
     }
-    for (const deletion of (_d = payload.instancesToDelete) !== null && _d !== void 0 ? _d : []) {
-        const task = tasks.deleteExtensionInstanceTask(projectId, deletion);
+    for (const inst of (_d = payload.instancesToUpdate) !== null && _d !== void 0 ? _d : []) {
+        const task = tasks.updateExtensionInstanceTask(projectId, inst);
         void deploymentQueue.run(task);
     }
     const deploymentPromise = deploymentQueue.wait();
@@ -53,8 +53,9 @@ async function release(context, options, payload) {
         errors: (_o = errorHandler.errors.length) !== null && _o !== void 0 ? _o : 0,
         interactive: options.nonInteractive ? "false" : "true",
     }, duration);
-    const newHave = await planner.have(projectId);
-    (0, etags_1.saveEtags)(options.rc, projectId, newHave);
+    const have = await planner.have(projectId);
+    const dynamicHave = await planner.haveDynamic(projectId);
+    (0, etags_1.saveEtags)(options.rc, projectId, have.concat(dynamicHave));
     if (errorHandler.hasErrors()) {
         errorHandler.print();
         throw new error_1.FirebaseError(`Extensions deployment failed.`);

package/lib/deploy/extensions/tasks.js

@@ -7,6 +7,7 @@ const extensionsApi = require("../../extensions/extensionsApi");
 const extensionsHelper_1 = require("../../extensions/extensionsHelper");
 const refs = require("../../extensions/refs");
 const utils = require("../../utils");
+const types_1 = require("../../extensions/types");
 const isRetryable = (err) => err.status === 429 || err.status === 409;
 function extensionsDeploymentHandler(errorHandler) {
     return async (task) => {
@@ -27,34 +28,37 @@ function extensionsDeploymentHandler(errorHandler) {
 exports.extensionsDeploymentHandler = extensionsDeploymentHandler;
 function createExtensionInstanceTask(projectId, instanceSpec, validateOnly = false) {
     const run = async () => {
+        if (!validateOnly) {
+            utils.logLabeledBullet("extensions", `Creating ${clc.bold(instanceSpec.instanceId)} extension instance`);
+        }
+        const createArgs = {
+            projectId,
+            instanceId: instanceSpec.instanceId,
+            params: instanceSpec.params,
+            systemParams: instanceSpec.systemParams,
+            allowedEventTypes: instanceSpec.allowedEventTypes,
+            eventarcChannel: instanceSpec.eventarcChannel,
+            validateOnly,
+            labels: instanceSpec.labels,
+        };
         if (instanceSpec.ref) {
-            await extensionsApi.createInstance({
-                projectId,
-                instanceId: instanceSpec.instanceId,
-                params: instanceSpec.params,
-                systemParams: instanceSpec.systemParams,
-                extensionVersionRef: refs.toExtensionVersionRef(instanceSpec.ref),
-                allowedEventTypes: instanceSpec.allowedEventTypes,
-                eventarcChannel: instanceSpec.eventarcChannel,
-                validateOnly,
-            });
+            createArgs.extensionVersionRef = refs.toExtensionVersionRef(instanceSpec.ref);
         }
         else if (instanceSpec.localPath) {
-            const extensionSource = await (0, extensionsHelper_1.createSourceFromLocation)(projectId, instanceSpec.localPath);
-            await extensionsApi.createInstance({
-                projectId,
-                instanceId: instanceSpec.instanceId,
-                params: instanceSpec.params,
-                systemParams: instanceSpec.systemParams,
-                extensionSource,
-                allowedEventTypes: instanceSpec.allowedEventTypes,
-                eventarcChannel: instanceSpec.eventarcChannel,
-                validateOnly,
-            });
+            createArgs.extensionSource = await (0, extensionsHelper_1.createSourceFromLocation)(projectId, instanceSpec.localPath);
         }
         else {
             throw new error_1.FirebaseError(`Tried to create extension instance ${instanceSpec.instanceId} without a ref or a local path. This should never happen.`);
         }
+        try {
+            await extensionsApi.createInstance(createArgs);
+        }
+        catch (err) {
+            if ((0, types_1.isObject)(err) && err.status === 409) {
+                throw new error_1.FirebaseError(`Failed to create extension instance. Extension instance ${clc.bold(instanceSpec.instanceId)} already exists.`);
+            }
+            throw err;
+        }
         printSuccess(instanceSpec.instanceId, "create", validateOnly);
         return;
     };
@@ -67,6 +71,9 @@ function createExtensionInstanceTask(projectId, instanceSpec, validateOnly = fal
 exports.createExtensionInstanceTask = createExtensionInstanceTask;
 function updateExtensionInstanceTask(projectId, instanceSpec, validateOnly = false) {
     const run = async () => {
+        if (!validateOnly) {
+            utils.logLabeledBullet("extensions", `Updating ${clc.bold(instanceSpec.instanceId)} extension instance`);
+        }
         if (instanceSpec.ref) {
             await extensionsApi.updateInstanceFromRegistry({
                 projectId,
@@ -109,6 +116,9 @@ function updateExtensionInstanceTask(projectId, instanceSpec, validateOnly = fal
 exports.updateExtensionInstanceTask = updateExtensionInstanceTask;
 function configureExtensionInstanceTask(projectId, instanceSpec, validateOnly = false) {
     const run = async () => {
+        if (!validateOnly) {
+            utils.logLabeledBullet("extensions", `Configuring ${clc.bold(instanceSpec.instanceId)} extension instance`);
+        }
         if (instanceSpec.ref) {
             await extensionsApi.configureInstance({
                 projectId,
@@ -139,6 +149,7 @@ function configureExtensionInstanceTask(projectId, instanceSpec, validateOnly =
 exports.configureExtensionInstanceTask = configureExtensionInstanceTask;
 function deleteExtensionInstanceTask(projectId, instanceSpec) {
     const run = async () => {
+        utils.logLabeledBullet("extensions", `Deleting ${clc.bold(instanceSpec.instanceId)} extension instance`);
         await extensionsApi.deleteInstance(projectId, instanceSpec.instanceId);
         printSuccess(instanceSpec.instanceId, "delete", false);
         return;

package/lib/deploy/firestore/prepare.js

@@ -5,6 +5,7 @@ const loadCJSON_1 = require("../../loadCJSON");
 const rulesDeploy_1 = require("../../rulesDeploy");
 const utils = require("../../utils");
 const fsConfig = require("../../firestore/fsConfig");
+const logger_1 = require("../../logger");
 function prepareRules(context, rulesDeploy, databaseId, rulesFile) {
     rulesDeploy.addFile(rulesFile);
     context.firestore.rules.push({
@@ -23,6 +24,7 @@ function prepareIndexes(context, options, databaseId, indexesFileName) {
     });
 }
 async function default_1(context, options) {
+    var _a;
     if (options.only) {
         const targets = options.only.split(",");
         const excludeRules = targets.indexOf("firestore:indexes") >= 0;
@@ -57,5 +59,13 @@ async function default_1(context, options) {
     if (context.firestore.rules.length > 0) {
         await rulesDeploy.compile();
     }
+    const rulesContext = (_a = context === null || context === void 0 ? void 0 : context.firestore) === null || _a === void 0 ? void 0 : _a.rules;
+    for (const ruleContext of rulesContext) {
+        const databaseId = ruleContext.databaseId;
+        const rulesFile = ruleContext.rulesFile;
+        if (!rulesFile) {
+            logger_1.logger.error(`Invalid firestore config for ${databaseId} database: ${JSON.stringify(options.config.src.firestore)}`);
+        }
+    }
 }
 exports.default = default_1;

package/lib/deploy/firestore/release.js

@@ -1,8 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 const rulesDeploy_1 = require("../../rulesDeploy");
-const logger_1 = require("../../logger");
-async function default_1(context, options) {
+async function default_1(context) {
     var _a, _b;
     const rulesDeploy = (_a = context === null || context === void 0 ? void 0 : context.firestore) === null || _a === void 0 ? void 0 : _a.rulesDeploy;
     if (!context.firestoreRules || !rulesDeploy) {
@@ -12,11 +11,9 @@ async function default_1(context, options) {
     await Promise.all(rulesContext.map(async (ruleContext) => {
         const databaseId = ruleContext.databaseId;
         const rulesFile = ruleContext.rulesFile;
-        if (!rulesFile) {
-            logger_1.logger.error(`Invalid firestore config for ${databaseId} database: ${JSON.stringify(options.config.src.firestore)}`);
-            return;
+        if (rulesFile) {
+            return rulesDeploy.release(rulesFile, rulesDeploy_1.RulesetServiceType.CLOUD_FIRESTORE, databaseId);
         }
-        return rulesDeploy.release(rulesFile, rulesDeploy_1.RulesetServiceType.CLOUD_FIRESTORE, databaseId);
     }));
 }
 exports.default = default_1;

package/lib/deploy/functions/checkIam.js

@@ -102,7 +102,7 @@ function obtainDefaultComputeServiceAgentBindings(projectNumber) {
     return [runInvokerBinding, eventarcEventReceiverBinding];
 }
 exports.obtainDefaultComputeServiceAgentBindings = obtainDefaultComputeServiceAgentBindings;
-async function ensureServiceAgentRoles(projectId, projectNumber, want, have) {
+async function ensureServiceAgentRoles(projectId, projectNumber, want, have, dryRun) {
     const wantServices = backend.allEndpoints(want).reduce(reduceEventsToServices, []);
     const haveServices = backend.allEndpoints(have).reduce(reduceEventsToServices, []);
     const newServices = wantServices.filter((wantS) => !haveServices.find((haveS) => wantS.name === haveS.name));
@@ -138,7 +138,12 @@ async function ensureServiceAgentRoles(projectId, projectNumber, want, have) {
         return;
     }
     try {
-        await (0, resourceManager_1.setIamPolicy)(projectNumber, policy, "bindings");
+        if (dryRun) {
+            logger_1.logger.info(`On your next deploy, the following required roles will be granted: ${requiredBindings.map((b) => `${b.members.join(", ")}: ${(0, colorette_1.bold)(b.role)}`)}`);
+        }
+        else {
+            await (0, resourceManager_1.setIamPolicy)(projectNumber, policy, "bindings");
+        }
     }
     catch (err) {
         iam.printManualIamConfig(requiredBindings, projectId, "functions");

package/lib/deploy/functions/ensure.js

@@ -79,11 +79,19 @@ async function secretsToServiceAccounts(b) {
     }
     return secretsToSa;
 }
-async function secretAccess(projectId, wantBackend, haveBackend) {
+async function secretAccess(projectId, wantBackend, haveBackend, dryRun) {
     var _a, _b;
     const ensureAccess = async (secret, serviceAccounts) => {
         (0, utils_1.logLabeledBullet)("functions", `ensuring ${clc.bold(serviceAccounts.join(", "))} access to secret ${clc.bold(secret)}.`);
-        await (0, secretManager_1.ensureServiceAgentRole)({ name: secret, projectId }, serviceAccounts, "roles/secretmanager.secretAccessor");
+        if (dryRun) {
+            const check = await (0, secretManager_1.checkServiceAgentRole)({ name: secret, projectId }, serviceAccounts, "roles/secretmanager.secretAccessor");
+            if (check.length) {
+                (0, utils_1.logLabeledBullet)("functions", `On your next deploy, ${clc.bold(serviceAccounts.join(", "))} will be granted access to secret ${clc.bold(secret)}.`);
+            }
+        }
+        else {
+            await (0, secretManager_1.ensureServiceAgentRole)({ name: secret, projectId }, serviceAccounts, "roles/secretmanager.secretAccessor");
+        }
         (0, utils_1.logLabeledSuccess)("functions", `ensured ${clc.bold(serviceAccounts.join(", "))} access to ${clc.bold(secret)}.`);
     };
     const wantSecrets = await secretsToServiceAccounts(wantBackend);

package/lib/deploy/functions/prepare.js

@@ -27,6 +27,7 @@ const serviceusage_1 = require("../../gcp/serviceusage");
 const applyHash_1 = require("./cache/applyHash");
 const backend_1 = require("./backend");
 const functional_1 = require("../../functional");
+const prepare_1 = require("../extensions/prepare");
 exports.EVENTARC_SOURCE_ENV = "EVENTARC_CLOUD_EVENT_SOURCE";
 async function prepare(context, options, payload) {
     var _a, _b;
@@ -55,6 +56,13 @@ async function prepare(context, options, payload) {
     }
     context.codebaseDeployEvents = {};
     const wantBuilds = await loadCodebases(context.config, options, firebaseConfig, runtimeConfig, context.filters);
+    if (Object.values(wantBuilds).some((b) => b.extensions)) {
+        const extContext = {};
+        const extPayload = {};
+        await (0, prepare_1.prepareDynamicExtensions)(extContext, options, extPayload, wantBuilds);
+        context.extensions = extContext;
+        payload.extensions = extPayload;
+    }
     const codebaseUsesEnvs = [];
     const wantBackends = {};
     for (const [codebase, wantBuild] of Object.entries(wantBuilds)) {
@@ -183,9 +191,9 @@ async function prepare(context, options, payload) {
     await (0, prompts_1.promptForFailurePolicies)(options, matchingBackend, haveBackend);
     await (0, prompts_1.promptForMinInstances)(options, matchingBackend, haveBackend);
     await backend.checkAvailability(context, matchingBackend);
-    await (0, checkIam_1.ensureServiceAgentRoles)(projectId, projectNumber, matchingBackend, haveBackend);
     await validate.secretsAreValid(projectId, matchingBackend);
-    await ensure.secretAccess(projectId, matchingBackend, haveBackend);
+    await (0, checkIam_1.ensureServiceAgentRoles)(projectId, projectNumber, matchingBackend, haveBackend, options.dryRun);
+    await ensure.secretAccess(projectId, matchingBackend, haveBackend, options.dryRun);
     updateEndpointTargetedStatus(wantBackends, context.filters || []);
     (0, applyHash_1.applyBackendHashToBackends)(wantBackends, context);
 }

package/lib/deploy/functions/runtimes/node/index.js

@@ -18,7 +18,7 @@ const validate = require("./validate");
 const versioning = require("./versioning");
 const parseTriggers = require("./parseTriggers");
 const fsutils_1 = require("../../../../fsutils");
-const MIN_FUNCTIONS_SDK_VERSION = "3.20.0";
+const MIN_FUNCTIONS_SDK_VERSION = "5.1.0";
 async function tryCreateDelegate(context) {
     const packageJsonPath = path.join(context.sourceDir, "package.json");
     if (!(await (0, util_1.promisify)(fs.exists)(packageJsonPath))) {

package/lib/deploy/index.js

@@ -41,6 +41,7 @@ const chain = async function (fns, context, options, payload) {
     }
 };
 const deploy = async function (targetNames, options, customContext = {}) {
+    var _a;
     const projectId = (0, projectUtils_1.needProjectId)(options);
     const payload = {};
     const context = Object.assign({ projectId }, customContext);
@@ -85,9 +86,11 @@ const deploy = async function (targetNames, options, customContext = {}) {
         }
         predeploys.push((0, lifecycleHooks_1.lifecycleHooks)(targetName, "predeploy"));
         prepares.push(target.prepare);
-        deploys.push(target.deploy);
-        releases.push(target.release);
-        postdeploys.push((0, lifecycleHooks_1.lifecycleHooks)(targetName, "postdeploy"));
+        if (!options.dryRun) {
+            deploys.push(target.deploy);
+            releases.push(target.release);
+            postdeploys.push((0, lifecycleHooks_1.lifecycleHooks)(targetName, "postdeploy"));
+        }
     }
     logger_1.logger.info();
     logger_1.logger.info((0, colorette_1.bold)((0, colorette_1.white)("===") + " Deploying to '" + projectId + "'..."));
@@ -110,11 +113,12 @@ const deploy = async function (targetNames, options, customContext = {}) {
         analyticsParams[t] = "true";
     }
     await (0, track_1.trackGA4)("product_deploy", analyticsParams, duration);
+    const successMessage = options.dryRun ? "Dry run complete!" : "Deploy complete!";
     logger_1.logger.info();
-    (0, utils_1.logSuccess)((0, colorette_1.bold)((0, colorette_1.underline)("Deploy complete!")));
+    (0, utils_1.logSuccess)((0, colorette_1.bold)((0, colorette_1.underline)(successMessage)));
     logger_1.logger.info();
     const deployedHosting = (0, lodash_1.includes)(targetNames, "hosting");
-    logger_1.logger.info((0, colorette_1.bold)("Project Console:"), (0, utils_1.consoleUrl)(options.project, "/overview"));
+    logger_1.logger.info((0, colorette_1.bold)("Project Console:"), (0, utils_1.consoleUrl)((_a = options.project) !== null && _a !== void 0 ? _a : "_", "/overview"));
     if (deployedHosting) {
         (0, lodash_1.each)(context.hosting.deploys, (deploy) => {
             logger_1.logger.info((0, colorette_1.bold)("Hosting URL:"), (0, utils_1.addSubdomain)((0, api_1.hostingOrigin)(), deploy.config.site));

package/lib/emulator/downloadableEmulators.js

@@ -46,20 +46,20 @@ const EMULATOR_UPDATE_DETAILS = {
     },
     dataconnect: process.platform === "darwin"
         ? {
-            version: "1.3.6",
-            expectedSize: 24867584,
-            expectedChecksum: "b924d31e3620d7ed4486a95e22629fc8",
+            version: "1.3.8",
+            expectedSize: 25027328,
+            expectedChecksum: "903f0e8dd8212fec575dc2eba34be6e7",
         }
         : process.platform === "win32"
             ? {
-                version: "1.3.6",
-                expectedSize: 25292288,
-                expectedChecksum: "45025491b43b55a94f4e4db8df903250",
+                version: "1.3.8",
+                expectedSize: 25450496,
+                expectedChecksum: "e09999deda7301eba06f88face5e1744",
             }
             : {
-                version: "1.3.6",
-                expectedSize: 24785048,
-                expectedChecksum: "6ae5820c0470c5a954540ad97838ec01",
+                version: "1.3.8",
+                expectedSize: 24940696,
+                expectedChecksum: "69aeb9755d4ec2e77bdadbc40236b306",
             },
 };
 exports.DownloadDetails = {

package/lib/extensions/extensionsApi.js

@@ -15,10 +15,11 @@ const extensionsApiClient = new apiv2_1.Client({
     urlPrefix: (0, api_1.extensionsOrigin)(),
     apiVersion: EXTENSIONS_API_VERSION,
 });
-async function createInstanceHelper(projectId, instanceId, config, validateOnly = false) {
+async function createInstanceHelper(projectId, instanceId, config, labels, validateOnly = false) {
     const createRes = await extensionsApiClient.post(`/projects/${projectId}/instances/`, {
         name: `projects/${projectId}/instances/${instanceId}`,
         config,
+        labels,
     }, {
         queryParams: {
             validateOnly: validateOnly ? "true" : "false",
@@ -63,7 +64,7 @@ async function createInstance(args) {
     if (args.eventarcChannel) {
         config.eventarcChannel = args.eventarcChannel;
     }
-    return createInstanceHelper(args.projectId, args.instanceId, config, args.validateOnly);
+    return await createInstanceHelper(args.projectId, args.instanceId, config, args.labels, args.validateOnly);
 }
 exports.createInstance = createInstance;
 async function deleteInstance(projectId, instanceId) {

package/lib/extensions/extensionsHelper.js

@@ -7,7 +7,7 @@ var __asyncValues = (this && this.__asyncValues) || function (o) {
     function settle(resolve, reject, d, v) { Promise.resolve(v).then(function(v) { resolve({ value: v, done: d }); }, reject); }
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.diagnoseAndFixProject = exports.getSourceOrigin = exports.isLocalOrURLPath = exports.isLocalPath = exports.isUrlPath = exports.instanceIdExists = exports.promptForRepeatInstance = exports.promptForOfficialExtension = exports.displayReleaseNotes = exports.getPublisherProjectFromName = exports.createSourceFromLocation = exports.getMissingPublisherError = exports.uploadExtensionVersionFromLocalSource = exports.uploadExtensionVersionFromGitHubSource = exports.unpackExtensionState = exports.getNextVersionByStage = exports.ensureExtensionsPublisherApiEnabled = exports.ensureExtensionsApiEnabled = exports.checkExtensionsApiEnabled = exports.promptForExtensionRoot = exports.promptForValidRepoURI = exports.promptForValidInstanceId = exports.validateSpec = exports.validateCommandLineParams = exports.populateDefaultParams = exports.substituteSecretParams = exports.substituteParams = exports.getFirebaseProjectParams = exports.getDBInstanceFromURL = exports.resourceTypeToNiceName = exports.AUTOPOULATED_PARAM_PLACEHOLDERS = exports.EXTENSIONS_BUCKET_NAME = exports.URL_REGEX = exports.logPrefix = exports.SourceOrigin = exports.SpecParamType = void 0;
+exports.diagnoseAndFixProject = exports.getSourceOrigin = exports.isLocalOrURLPath = exports.isLocalPath = exports.isUrlPath = exports.instanceIdExists = exports.promptForRepeatInstance = exports.promptForOfficialExtension = exports.displayReleaseNotes = exports.getPublisherProjectFromName = exports.createSourceFromLocation = exports.getMissingPublisherError = exports.uploadExtensionVersionFromLocalSource = exports.uploadExtensionVersionFromGitHubSource = exports.unpackExtensionState = exports.getNextVersionByStage = exports.ensureExtensionsPublisherApiEnabled = exports.ensureExtensionsApiEnabled = exports.checkExtensionsApiEnabled = exports.promptForExtensionRoot = exports.promptForValidRepoURI = exports.promptForValidInstanceId = exports.validateSpec = exports.validateCommandLineParams = exports.populateDefaultParams = exports.substituteSecretParams = exports.substituteParams = exports.getFirebaseProjectParams = exports.getDBInstanceFromURL = exports.resourceTypeToNiceName = exports.AUTOPOPULATED_PARAM_PLACEHOLDERS = exports.EXTENSIONS_BUCKET_NAME = exports.URL_REGEX = exports.logPrefix = exports.SourceOrigin = exports.SpecParamType = void 0;
 const clc = require("colorette");
 const ora = require("ora");
 const semver = require("semver");
@@ -69,7 +69,7 @@ const AUTOPOPULATED_PARAM_NAMES = [
     "DATABASE_INSTANCE",
     "DATABASE_URL",
 ];
-exports.AUTOPOULATED_PARAM_PLACEHOLDERS = {
+exports.AUTOPOPULATED_PARAM_PLACEHOLDERS = {
     PROJECT_ID: "project-id",
     STORAGE_BUCKET: "project-id.appspot.com",
     EXT_INSTANCE_ID: "extension-id",
@@ -449,7 +449,7 @@ async function validateExtensionSpec(rootDirectory, extensionId) {
         throw new error_1.FirebaseError(`Extension ID '${clc.bold(extensionId)}' does not match the name in extension.yaml '${clc.bold(extensionSpec.name)}'.`);
     }
     const subbedSpec = JSON.parse(JSON.stringify(extensionSpec));
-    subbedSpec.params = substituteParams(extensionSpec.params || [], exports.AUTOPOULATED_PARAM_PLACEHOLDERS);
+    subbedSpec.params = substituteParams(extensionSpec.params || [], exports.AUTOPOPULATED_PARAM_PLACEHOLDERS);
     validateSpec(subbedSpec);
     return extensionSpec;
 }

package/lib/extensions/localHelper.js

@@ -6,11 +6,20 @@ const path = require("path");
 const yaml = require("yaml");
 const fsutils_1 = require("../fsutils");
 const error_1 = require("../error");
+const types_1 = require("./types");
 const logger_1 = require("../logger");
+const extensionsHelper_1 = require("./extensionsHelper");
 exports.EXTENSIONS_SPEC_FILE = "extension.yaml";
 const EXTENSIONS_PREINSTALL_FILE = "PREINSTALL.md";
 async function getLocalExtensionSpec(directory) {
     const spec = await parseYAML(readFile(path.resolve(directory, exports.EXTENSIONS_SPEC_FILE)));
+    if (spec.lifecycleEvents) {
+        spec.lifecycleEvents = fixLifecycleEvents(spec.lifecycleEvents);
+    }
+    if (!(0, types_1.isExtensionSpec)(spec)) {
+        (0, extensionsHelper_1.validateSpec)(spec);
+        throw new error_1.FirebaseError("Error: extension.yaml does not contain a valid extension specification.");
+    }
     try {
         const preinstall = readFile(path.resolve(directory, EXTENSIONS_PREINSTALL_FILE));
         spec.preinstallContent = preinstall;
@@ -21,6 +30,28 @@ async function getLocalExtensionSpec(directory) {
     return spec;
 }
 exports.getLocalExtensionSpec = getLocalExtensionSpec;
+function fixLifecycleEvents(lifecycleEvents) {
+    const stages = {
+        onInstall: "ON_INSTALL",
+        onUpdate: "ON_UPDATE",
+        onConfigure: "ON_CONFIGURE",
+        stageUnspecified: "STAGE_UNSPECIFIED",
+    };
+    const arrayLifecycle = [];
+    if ((0, types_1.isObject)(lifecycleEvents)) {
+        for (const [key, val] of Object.entries(lifecycleEvents)) {
+            if ((0, types_1.isObject)(val) &&
+                typeof val.function === "string" &&
+                typeof val.processingMessage === "string") {
+                arrayLifecycle.push({
+                    stage: stages[key] || stages["stageUnspecified"],
+                    taskQueueTriggerFunction: val.function,
+                });
+            }
+        }
+    }
+    return arrayLifecycle;
+}
 function findExtensionYaml(directory) {
     while (!(0, fsutils_1.fileExistsSync)(path.resolve(directory, exports.EXTENSIONS_SPEC_FILE))) {
         const parentDir = path.dirname(directory);