firebase-tools 12.3.1 → 12.4.1

package/lib/api/frameworks.js

@@ -0,0 +1,21 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.createBuild = exports.createStack = exports.API_VERSION = void 0;
+const apiv2_1 = require("../apiv2");
+const api_1 = require("../api");
+exports.API_VERSION = "v1";
+const client = new apiv2_1.Client({
+    urlPrefix: api_1.frameworksOrigin,
+    auth: true,
+    apiVersion: exports.API_VERSION,
+});
+async function createStack(projectId, location, stackId, stack) {
+    const res = await client.post(`projects/${projectId}/locations/${location}/stacks`, stack, { queryParams: { stackId } });
+    return res.body;
+}
+exports.createStack = createStack;
+async function createBuild(projectId, location, stackId, buildId, build) {
+    const res = await client.post(`projects/${projectId}/locations/${location}/stacks/${stackId}/builds`, build, { queryParams: { buildId } });
+    return res.body;
+}
+exports.createBuild = createBuild;

package/lib/api.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.secretManagerOrigin = exports.githubApiOrigin = exports.githubOrigin = exports.serviceUsageOrigin = exports.cloudRunApiOrigin = exports.hostingApiOrigin = exports.firebaseStorageOrigin = exports.storageOrigin = exports.runtimeconfigOrigin = exports.rulesOrigin = exports.resourceManagerOrigin = exports.remoteConfigApiOrigin = exports.rtdbMetadataOrigin = exports.rtdbManagementOrigin = exports.realtimeOrigin = exports.extensionsTOSOrigin = exports.extensionsPublisherOrigin = exports.extensionsOrigin = exports.iamOrigin = exports.identityOrigin = exports.hostingOrigin = exports.googleOrigin = exports.pubsubOrigin = exports.cloudTasksOrigin = exports.cloudschedulerOrigin = exports.functionsDefaultRegion = exports.runOrigin = exports.functionsV2Origin = exports.functionsOrigin = exports.firestoreOrigin = exports.firestoreOriginOrEmulator = exports.firedataOrigin = exports.firebaseExtensionsRegistryOrigin = exports.firebaseApiOrigin = exports.eventarcOrigin = exports.dynamicLinksKey = exports.dynamicLinksOrigin = exports.deployOrigin = exports.consoleOrigin = exports.authOrigin = exports.appengineOrigin = exports.appDistributionOrigin = exports.artifactRegistryDomain = exports.containerRegistryDomain = exports.cloudMonitoringOrigin = exports.cloudloggingOrigin = exports.cloudbillingOrigin = exports.clientSecret = exports.clientId = exports.authProxyOrigin = void 0;
-exports.setScopes = exports.getScopes = exports.githubClientSecret = exports.githubClientId = void 0;
+exports.githubApiOrigin = exports.githubOrigin = exports.frameworksOrigin = exports.serviceUsageOrigin = exports.cloudRunApiOrigin = exports.hostingApiOrigin = exports.firebaseStorageOrigin = exports.storageOrigin = exports.runtimeconfigOrigin = exports.rulesOrigin = exports.resourceManagerOrigin = exports.remoteConfigApiOrigin = exports.rtdbMetadataOrigin = exports.rtdbManagementOrigin = exports.realtimeOrigin = exports.extensionsTOSOrigin = exports.extensionsPublisherOrigin = exports.extensionsOrigin = exports.iamOrigin = exports.identityOrigin = exports.hostingOrigin = exports.googleOrigin = exports.pubsubOrigin = exports.cloudTasksOrigin = exports.cloudschedulerOrigin = exports.cloudbuildOrigin = exports.functionsDefaultRegion = exports.runOrigin = exports.functionsV2Origin = exports.functionsOrigin = exports.firestoreOrigin = exports.firestoreOriginOrEmulator = exports.firedataOrigin = exports.firebaseExtensionsRegistryOrigin = exports.firebaseApiOrigin = exports.eventarcOrigin = exports.dynamicLinksKey = exports.dynamicLinksOrigin = exports.deployOrigin = exports.consoleOrigin = exports.authOrigin = exports.appDistributionOrigin = exports.artifactRegistryDomain = exports.containerRegistryDomain = exports.cloudMonitoringOrigin = exports.cloudloggingOrigin = exports.cloudbillingOrigin = exports.clientSecret = exports.clientId = exports.authProxyOrigin = void 0;
+exports.setScopes = exports.getScopes = exports.githubClientSecret = exports.githubClientId = exports.secretManagerOrigin = void 0;
 const constants_1 = require("./emulator/constants");
 const logger_1 = require("./logger");
 const scopes = require("./scopes");
@@ -16,7 +16,6 @@ exports.cloudMonitoringOrigin = utils.envOverride("CLOUD_MONITORING_URL", "https
 exports.containerRegistryDomain = utils.envOverride("CONTAINER_REGISTRY_DOMAIN", "gcr.io");
 exports.artifactRegistryDomain = utils.envOverride("ARTIFACT_REGISTRY_DOMAIN", "https://artifactregistry.googleapis.com");
 exports.appDistributionOrigin = utils.envOverride("FIREBASE_APP_DISTRIBUTION_URL", "https://firebaseappdistribution.googleapis.com");
-exports.appengineOrigin = utils.envOverride("FIREBASE_APPENGINE_URL", "https://appengine.googleapis.com");
 exports.authOrigin = utils.envOverride("FIREBASE_AUTH_URL", "https://accounts.google.com");
 exports.consoleOrigin = utils.envOverride("FIREBASE_CONSOLE_URL", "https://console.firebase.google.com");
 exports.deployOrigin = utils.envOverride("FIREBASE_DEPLOY_URL", utils.envOverride("FIREBASE_UPLOAD_URL", "https://deploy.firebase.com"));
@@ -37,6 +36,7 @@ exports.functionsOrigin = utils.envOverride("FIREBASE_FUNCTIONS_URL", "https://c
 exports.functionsV2Origin = utils.envOverride("FIREBASE_FUNCTIONS_V2_URL", "https://cloudfunctions.googleapis.com");
 exports.runOrigin = utils.envOverride("CLOUD_RUN_URL", "https://run.googleapis.com");
 exports.functionsDefaultRegion = utils.envOverride("FIREBASE_FUNCTIONS_DEFAULT_REGION", "us-central1");
+exports.cloudbuildOrigin = utils.envOverride("FIREBASE_CLOUDBUILD_URL", "https://cloudbuild.googleapis.com");
 exports.cloudschedulerOrigin = utils.envOverride("FIREBASE_CLOUDSCHEDULER_URL", "https://cloudscheduler.googleapis.com");
 exports.cloudTasksOrigin = utils.envOverride("FIREBASE_CLOUD_TAKS_URL", "https://cloudtasks.googleapis.com");
 exports.pubsubOrigin = utils.envOverride("FIREBASE_PUBSUB_URL", "https://pubsub.googleapis.com");
@@ -59,6 +59,7 @@ exports.firebaseStorageOrigin = utils.envOverride("FIREBASE_FIREBASESTORAGE_URL"
 exports.hostingApiOrigin = utils.envOverride("FIREBASE_HOSTING_API_URL", "https://firebasehosting.googleapis.com");
 exports.cloudRunApiOrigin = utils.envOverride("CLOUD_RUN_API_URL", "https://run.googleapis.com");
 exports.serviceUsageOrigin = utils.envOverride("FIREBASE_SERVICE_USAGE_URL", "https://serviceusage.googleapis.com");
+exports.frameworksOrigin = utils.envOverride("FRAMEWORKS_URL", "https://placeholder.googleapis.com");
 exports.githubOrigin = utils.envOverride("GITHUB_URL", "https://github.com");
 exports.githubApiOrigin = utils.envOverride("GITHUB_API_URL", "https://api.github.com");
 exports.secretManagerOrigin = utils.envOverride("CLOUD_SECRET_MANAGER_URL", "https://secretmanager.googleapis.com");

package/lib/appdistribution/client.js

@@ -137,5 +137,57 @@ class AppDistributionClient {
         }
         return apiResponse.body;
     }
+    async createGroup(projectName, displayName, alias) {
+        let apiResponse;
+        try {
+            apiResponse = await this.appDistroV2Client.request({
+                method: "POST",
+                path: alias === undefined ? `${projectName}/groups` : `${projectName}/groups?groupId=${alias}`,
+                body: { displayName: displayName },
+            });
+        }
+        catch (err) {
+            throw new error_1.FirebaseError(`Failed to create group ${err}`);
+        }
+        return apiResponse.body;
+    }
+    async deleteGroup(groupName) {
+        try {
+            await this.appDistroV2Client.request({
+                method: "DELETE",
+                path: groupName,
+            });
+        }
+        catch (err) {
+            throw new error_1.FirebaseError(`Failed to delete group ${err}`);
+        }
+        utils.logSuccess(`Group deleted successfully`);
+    }
+    async addTestersToGroup(groupName, emails) {
+        try {
+            await this.appDistroV2Client.request({
+                method: "POST",
+                path: `${groupName}:batchJoin`,
+                body: { emails: emails },
+            });
+        }
+        catch (err) {
+            throw new error_1.FirebaseError(`Failed to add testers to group ${err}`);
+        }
+        utils.logSuccess(`Testers added to group successfully`);
+    }
+    async removeTestersFromGroup(groupName, emails) {
+        try {
+            await this.appDistroV2Client.request({
+                method: "POST",
+                path: `${groupName}:batchLeave`,
+                body: { emails: emails },
+            });
+        }
+        catch (err) {
+            throw new error_1.FirebaseError(`Failed to remove testers from group ${err}`);
+        }
+        utils.logSuccess(`Testers removed from group successfully`);
+    }
 }
 exports.AppDistributionClient = AppDistributionClient;

package/lib/auth.js

@@ -307,7 +307,7 @@ async function loginRemotely() {
     });
     try {
         const tokens = await getTokensFromAuthorizationCode(code, `${api_1.authProxyOrigin}/complete`, codeVerifier);
-        void (0, track_1.track)("login", "google_remote");
+        void (0, track_1.trackGA4)("login", { method: "google_remote" });
         return {
             user: jwt.decode(tokens.id_token),
             tokens: tokens,
@@ -323,7 +323,7 @@ async function loginWithLocalhostGoogle(port, userHint) {
     const authUrl = getLoginUrl(callbackUrl, userHint);
     const successTemplate = "../templates/loginSuccess.html";
     const tokens = await loginWithLocalhost(port, callbackUrl, authUrl, successTemplate, getTokensFromAuthorizationCode);
-    void (0, track_1.track)("login", "google_localhost");
+    void (0, track_1.trackGA4)("login", { method: "google_localhost" });
     return {
         user: jwt.decode(tokens.id_token),
         tokens: tokens,
@@ -335,7 +335,7 @@ async function loginWithLocalhostGitHub(port) {
     const authUrl = getGithubLoginUrl(callbackUrl);
     const successTemplate = "../templates/loginSuccessGithub.html";
     const tokens = await loginWithLocalhost(port, callbackUrl, authUrl, successTemplate, getGithubTokensFromAuthorizationCode);
-    void (0, track_1.track)("login", "google_localhost");
+    void (0, track_1.trackGA4)("login", { method: "github_localhost" });
     return tokens;
 }
 async function loginWithLocalhost(port, callbackUrl, authUrl, successTemplate, getTokens) {

package/lib/command.js

@@ -89,7 +89,12 @@ class Command {
                     }, null, 2));
                 }
                 const duration = Math.floor((process.uptime() - start) * 1000);
-                const trackSuccess = (0, track_1.track)(this.name, "success", duration);
+                const trackSuccess = (0, track_1.trackGA4)("command_execution", {
+                    command_name: this.name,
+                    result: "success",
+                    duration,
+                    interactive: (0, utils_1.getInheritedOption)(options, "nonInteractive") ? "false" : "true",
+                });
                 if (!isEmulator) {
                     await (0, utils_1.withTimeout)(5000, trackSuccess);
                 }
@@ -113,8 +118,11 @@ class Command {
                 }
                 const duration = Math.floor((process.uptime() - start) * 1000);
                 await (0, utils_1.withTimeout)(5000, Promise.all([
-                    (0, track_1.track)(this.name, "error", duration),
-                    (0, track_1.track)(err.exit === 1 ? "Error (User)" : "Error (Unexpected)", "", duration),
+                    (0, track_1.trackGA4)("command_execution", {
+                        command_name: this.name,
+                        result: "error",
+                        interactive: (0, utils_1.getInheritedOption)(options, "nonInteractive") ? "false" : "true",
+                    }, duration),
                     isEmulator
                         ? (0, track_1.trackEmulator)("command_error", {
                             command_name: this.name,
@@ -223,7 +231,10 @@ function validateProjectId(project) {
     if (PROJECT_ID_REGEX.test(project)) {
         return;
     }
-    (0, track_1.track)("Project ID Check", "invalid");
+    (0, track_1.trackGA4)("error", {
+        error_type: "Error (User)",
+        details: "Invalid project ID",
+    });
     const invalidMessage = "Invalid project id: " + clc.bold(project) + ".";
     if (project.toLowerCase() !== project) {
         throw new error_1.FirebaseError(invalidMessage + "\nNote: Project id must be all lowercase.");

package/lib/commands/appdistribution-group-create.js

@@ -0,0 +1,19 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.command = void 0;
+const command_1 = require("../command");
+const utils = require("../utils");
+const requireAuth_1 = require("../requireAuth");
+const client_1 = require("../appdistribution/client");
+const options_parser_util_1 = require("../appdistribution/options-parser-util");
+exports.command = new command_1.Command("appdistribution:group:create <displayName> [alias]")
+    .description("create group in project")
+    .before(requireAuth_1.requireAuth)
+    .action(async (displayName, alias, options) => {
+    const projectName = await (0, options_parser_util_1.getProjectName)(options);
+    const appDistroClient = new client_1.AppDistributionClient();
+    utils.logBullet(`Creating group in project`);
+    const group = await appDistroClient.createGroup(projectName, displayName, alias);
+    alias = group.name.split("/").pop();
+    utils.logSuccess(`Group '${group.displayName}' (alias: ${alias}) created successfully`);
+});

package/lib/commands/appdistribution-group-delete.js

@@ -0,0 +1,24 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.command = void 0;
+const command_1 = require("../command");
+const utils = require("../utils");
+const requireAuth_1 = require("../requireAuth");
+const error_1 = require("../error");
+const client_1 = require("../appdistribution/client");
+const options_parser_util_1 = require("../appdistribution/options-parser-util");
+exports.command = new command_1.Command("appdistribution:group:delete <alias>")
+    .description("delete group from a project")
+    .before(requireAuth_1.requireAuth)
+    .action(async (alias, options) => {
+    const projectName = await (0, options_parser_util_1.getProjectName)(options);
+    const appDistroClient = new client_1.AppDistributionClient();
+    try {
+        utils.logBullet(`Deleting group from project`);
+        await appDistroClient.deleteGroup(`${projectName}/groups/${alias}`);
+    }
+    catch (err) {
+        throw new error_1.FirebaseError(`Failed to delete group ${err}`);
+    }
+    utils.logSuccess(`Group ${alias} has successfully been deleted`);
+});

package/lib/commands/appdistribution-testers-add.js

@@ -7,8 +7,9 @@ const requireAuth_1 = require("../requireAuth");
 const client_1 = require("../appdistribution/client");
 const options_parser_util_1 = require("../appdistribution/options-parser-util");
 exports.command = new command_1.Command("appdistribution:testers:add [emails...]")
-    .description("add testers to project")
+    .description("add testers to project (and possibly group)")
     .option("--file <file>", "a path to a file containing a list of tester emails to be added")
+    .option("--group-alias <group-alias>", "if specified, the testers are also added to the group identified by this alias")
     .before(requireAuth_1.requireAuth)
     .action(async (emails, options) => {
     const projectName = await (0, options_parser_util_1.getProjectName)(options);
@@ -16,4 +17,8 @@ exports.command = new command_1.Command("appdistribution:testers:add [emails...]
     const emailsToAdd = (0, options_parser_util_1.getEmails)(emails, options.file);
     utils.logBullet(`Adding ${emailsToAdd.length} testers to project`);
     await appDistroClient.addTesters(projectName, emailsToAdd);
+    if (options.groupAlias) {
+        utils.logBullet(`Adding ${emailsToAdd.length} testers to group`);
+        await appDistroClient.addTestersToGroup(`${projectName}/groups/${options.groupAlias}`, emailsToAdd);
+    }
 });

package/lib/commands/appdistribution-testers-remove.js

@@ -9,25 +9,32 @@ const client_1 = require("../appdistribution/client");
 const options_parser_util_1 = require("../appdistribution/options-parser-util");
 const logger_1 = require("../logger");
 exports.command = new command_1.Command("appdistribution:testers:remove [emails...]")
-    .description("remove testers from a project")
+    .description("remove testers from a project (or group)")
     .option("--file <file>", "a path to a file containing a list of tester emails to be removed")
+    .option("--group-alias <group-alias>", "if specified, the testers are only removed from the group identified by this alias, but not the project")
     .before(requireAuth_1.requireAuth)
     .action(async (emails, options) => {
     const projectName = await (0, options_parser_util_1.getProjectName)(options);
     const appDistroClient = new client_1.AppDistributionClient();
     const emailsArr = (0, options_parser_util_1.getEmails)(emails, options.file);
-    let deleteResponse;
-    try {
-        utils.logBullet(`Deleting ${emailsArr.length} testers from project`);
-        deleteResponse = await appDistroClient.removeTesters(projectName, emailsArr);
+    if (options.groupAlias) {
+        utils.logBullet(`Removing ${emailsArr.length} testers from group`);
+        await appDistroClient.removeTestersFromGroup(`${projectName}/groups/${options.groupAlias}`, emailsArr);
     }
-    catch (err) {
-        throw new error_1.FirebaseError(`Failed to remove testers ${err}`);
+    else {
+        let deleteResponse;
+        try {
+            utils.logBullet(`Deleting ${emailsArr.length} testers from project`);
+            deleteResponse = await appDistroClient.removeTesters(projectName, emailsArr);
+        }
+        catch (err) {
+            throw new error_1.FirebaseError(`Failed to remove testers ${err}`);
+        }
+        if (!deleteResponse.emails) {
+            utils.logSuccess(`Testers did not exist`);
+            return;
+        }
+        logger_1.logger.debug(`Testers: ${deleteResponse.emails}, have been successfully deleted`);
+        utils.logSuccess(`${deleteResponse.emails.length} testers have successfully been deleted`);
     }
-    if (!deleteResponse.emails) {
-        utils.logSuccess(`Testers did not exist`);
-        return;
-    }
-    logger_1.logger.debug(`Testers: ${deleteResponse.emails}, have been successfully deleted`);
-    utils.logSuccess(`${deleteResponse.emails.length} testers have successfully been deleted`);
 });

package/lib/commands/experiments-describe.js

@@ -8,7 +8,7 @@ const experiments = require("../experiments");
 const logger_1 = require("../logger");
 const utils_1 = require("../utils");
 exports.command = new command_1.Command("experiments:describe <experiment>")
-    .description("enable an experiment on this machine")
+    .description("describe what an experiment does when enabled")
     .action((experiment) => {
     if (!experiments.isValidExperiment(experiment)) {
         let message = `Cannot find experiment ${(0, colorette_1.bold)(experiment)}`;

package/lib/commands/ext-install.js

@@ -35,7 +35,7 @@ exports.command = new command_1.Command("ext:install [extensionName]")
     .before(checkMinRequiredVersion_1.checkMinRequiredVersion, "extMinVersion")
     .before(extensionsHelper_1.diagnoseAndFixProject)
     .action(async (extensionName, options) => {
-    var _a;
+    var _a, _b;
     const projectId = (0, projectUtils_1.getProjectId)(options);
     const paramsEnvPath = "";
     let learnMore = false;
@@ -61,12 +61,18 @@ exports.command = new command_1.Command("ext:install [extensionName]")
     if ((0, extensionsHelper_1.isLocalPath)(extensionName)) {
         source = await (0, extensionsHelper_1.createSourceFromLocation)((0, projectUtils_1.needProjectId)({ projectId }), extensionName);
         await (0, displayExtensionInfo_1.displayExtInfo)(extensionName, "", source.spec);
-        void (0, track_1.track)("Extension Install", "Install by Source", options.interactive ? 1 : 0);
+        void (0, track_1.trackGA4)("extension_added_to_manifest", {
+            published: "local",
+            interactive: options.nonInteractive ? "false" : "true",
+        });
     }
     else {
-        void (0, track_1.track)("Extension Install", "Install by Extension Ref", options.interactive ? 1 : 0);
         extensionName = await (0, extensionsHelper_1.canonicalizeRefInput)(extensionName);
         extensionVersion = await extensionsApi.getExtensionVersion(extensionName);
+        void (0, track_1.trackGA4)("extension_added_to_manifest", {
+            published: ((_a = extensionVersion.listing) === null || _a === void 0 ? void 0 : _a.state) === "APPROVED" ? "published" : "uploaded",
+            interactive: options.nonInteractive ? "false" : "true",
+        });
         await infoExtensionVersion({
             extensionName,
             extensionVersion,
@@ -82,7 +88,7 @@ exports.command = new command_1.Command("ext:install [extensionName]")
     if (!source && !extensionVersion) {
         throw new error_1.FirebaseError("Could not find a source. Please specify a valid source to continue.");
     }
-    const spec = (_a = source === null || source === void 0 ? void 0 : source.spec) !== null && _a !== void 0 ? _a : extensionVersion === null || extensionVersion === void 0 ? void 0 : extensionVersion.spec;
+    const spec = (_b = source === null || source === void 0 ? void 0 : source.spec) !== null && _b !== void 0 ? _b : extensionVersion === null || extensionVersion === void 0 ? void 0 : extensionVersion.spec;
     if (!spec) {
         throw new error_1.FirebaseError(`Could not find the extension.yaml for extension '${clc.bold(extensionName)}'. Please make sure this is a valid extension and try again.`);
     }

package/lib/commands/index.js

@@ -19,6 +19,9 @@ function load(client) {
     client.appdistribution.testers = {};
     client.appdistribution.testers.add = loadCommand("appdistribution-testers-add");
     client.appdistribution.testers.delete = loadCommand("appdistribution-testers-remove");
+    client.appdistribution.group = {};
+    client.appdistribution.group.create = loadCommand("appdistribution-group-create");
+    client.appdistribution.group.delete = loadCommand("appdistribution-group-delete");
     client.apps = {};
     client.apps.create = loadCommand("apps-create");
     client.apps.list = loadCommand("apps-list");
@@ -141,6 +144,8 @@ function load(client) {
         client.internaltesting.frameworks.compose = loadCommand("internaltesting-frameworks-compose");
         client.internaltesting.functions = {};
         client.internaltesting.functions.discover = loadCommand("internaltesting-functions-discover");
+        client.internaltesting.frameworks = {};
+        client.internaltesting.frameworks.init = loadCommand("internaltesting-frameworks-init");
     }
     client.login = loadCommand("login");
     client.login.add = loadCommand("login-add");

package/lib/commands/init.js

@@ -14,6 +14,7 @@ const prompt_1 = require("../prompt");
 const requireAuth_1 = require("../requireAuth");
 const fsutils = require("../fsutils");
 const utils = require("../utils");
+const experiments_1 = require("../experiments");
 const homeDir = os.homedir();
 const TEMPLATE_ROOT = path.resolve(__dirname, "../../templates/");
 const BANNER_TEXT = fs.readFileSync(path.join(TEMPLATE_ROOT, "banner.txt"), "utf8");
@@ -68,6 +69,13 @@ const choices = [
         checked: false,
     },
 ];
+if ((0, experiments_1.isEnabled)("frameworks")) {
+    choices.push({
+        value: "frameworks",
+        name: "Frameworks: Get started with Frameworks projects.",
+        checked: false,
+    });
+}
 const featureNames = choices.map((choice) => choice.value);
 const DESCRIPTION = `Interactively configure the current directory as a Firebase project or initialize new features in an already configured Firebase project directory.
 

package/lib/commands/internaltesting-frameworks-init.js

@@ -0,0 +1,14 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.command = void 0;
+const command_1 = require("../command");
+const repo_1 = require("../init/features/composer/repo");
+const projectUtils_1 = require("../projectUtils");
+const requireInteractive_1 = require("../requireInteractive");
+exports.command = new command_1.Command("internaltesting:frameworks:init")
+    .description("connect github repo to cloud build")
+    .before(requireInteractive_1.default)
+    .action(async (options) => {
+    const projectId = (0, projectUtils_1.needProjectId)(options);
+    await (0, repo_1.linkGitHubRepository)(projectId, "us-central2", "stack0");
+});

package/lib/config.js

@@ -208,6 +208,7 @@ class Config {
         }
         throw new error_1.FirebaseError("Not in a Firebase app directory (could not locate firebase.json)", {
             exit: 1,
+            status: 404,
         });
     }
 }

package/lib/deploy/extensions/prepare.js

@@ -18,6 +18,7 @@ const v2FunctionHelper_1 = require("./v2FunctionHelper");
 const tos_1 = require("../../extensions/tos");
 async function prepare(context, options, payload) {
     var _a, _b;
+    context.extensionsStartTime = Date.now();
     const projectId = (0, projectUtils_1.needProjectId)(options);
     const projectNumber = await (0, projectUtils_1.needProjectNumber)(options);
     const aliases = (0, projectUtils_1.getAliases)(options, projectId);

package/lib/deploy/extensions/release.js

@@ -8,8 +8,9 @@ const error_1 = require("../../error");
 const errors_1 = require("./errors");
 const projectUtils_1 = require("../../projectUtils");
 const etags_1 = require("../../extensions/etags");
+const track_1 = require("../../track");
 async function release(context, options, payload) {
-    var _a, _b, _c, _d;
+    var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o;
     const projectId = (0, projectUtils_1.needProjectId)(options);
     const errorHandler = new errors_1.ErrorHandler();
     const deploymentQueue = new queue_1.default({
@@ -37,6 +38,15 @@ async function release(context, options, payload) {
     deploymentQueue.process();
     deploymentQueue.close();
     await deploymentPromise;
+    const duration = context.extensionsStartTime ? Date.now() - context.extensionsStartTime : 1;
+    await (0, track_1.trackGA4)("extensions_deploy", {
+        extension_instance_created: (_f = (_e = payload.instancesToCreate) === null || _e === void 0 ? void 0 : _e.length) !== null && _f !== void 0 ? _f : 0,
+        extension_instance_updated: (_h = (_g = payload.instancesToUpdate) === null || _g === void 0 ? void 0 : _g.length) !== null && _h !== void 0 ? _h : 0,
+        extension_instance_configured: (_k = (_j = payload.instancesToConfigure) === null || _j === void 0 ? void 0 : _j.length) !== null && _k !== void 0 ? _k : 0,
+        extension_instance_deleted: (_m = (_l = payload.instancesToDelete) === null || _l === void 0 ? void 0 : _l.length) !== null && _m !== void 0 ? _m : 0,
+        errors: (_o = errorHandler.errors.length) !== null && _o !== void 0 ? _o : 0,
+        interactive: options.nonInteractive ? "false" : "true",
+    }, duration);
     const newHave = await planner.have(projectId);
     (0, etags_1.saveEtags)(options.rc, projectId, newHave);
     if (errorHandler.hasErrors()) {

package/lib/deploy/functions/checkIam.js

@@ -59,7 +59,10 @@ async function checkHttpIam(context, options, payload) {
         return;
     }
     if (!passed) {
-        void (0, track_1.track)("Error (User)", "deploy:functions:http_create_missing_iam");
+        void (0, track_1.trackGA4)("error", {
+            error_type: "Error (User)",
+            details: "deploy:functions:http_create_missing_iam",
+        });
         throw new error_1.FirebaseError(`Missing required permission on project ${(0, colorette_1.bold)(context.projectId)} to deploy new HTTPS functions. The permission ${(0, colorette_1.bold)(PERMISSION)} is required to deploy the following functions:\n\n- ` +
             newHttpsEndpoints.map((func) => func.id).join("\n- ") +
             `\n\nTo address this error, please ask a project Owner to assign your account the "Cloud Functions Admin" role at the following URL:\n\nhttps://console.cloud.google.com/iam-admin/iam?project=${context.projectId}`);

package/lib/deploy/functions/prepare.js

@@ -301,7 +301,8 @@ async function loadCodebases(config, options, firebaseConfig, runtimeConfig, fil
         logger_1.logger.debug(`Building ${runtimeDelegate.name} source`);
         await runtimeDelegate.build();
         const firebaseEnvs = functionsEnv.loadFirebaseEnvs(firebaseConfig, projectId);
-        wantBuilds[codebase] = await runtimeDelegate.discoverBuild(runtimeConfig, firebaseEnvs);
+        (0, utils_1.logLabeledBullet)("functions", `Loading and anaylzing source code for codebase ${codebase} to determine what to deploy`);
+        wantBuilds[codebase] = await runtimeDelegate.discoverBuild(runtimeConfig, Object.assign(Object.assign({}, firebaseEnvs), { GOOGLE_CLOUD_QUOTA_PROJECT: projectId }));
     }
     return wantBuilds;
 }

package/lib/deploy/functions/runtimes/discovery/index.js

@@ -64,6 +64,12 @@ async function detectFromPort(port, project, runtime, timeout = 10000) {
             throw err;
         }
     }
+    if (res.status !== 200) {
+        const text = await res.text();
+        logger_1.logger.debug(`Got response code ${res.status}; body ${text}`);
+        throw new error_1.FirebaseError("Functions codebase could not be analyzed successfully. " +
+            "It may have a syntax or runtime error");
+    }
     const text = await res.text();
     logger_1.logger.debug("Got response from /__/functions.yaml", text);
     let parsed;

package/lib/deploy/functions/runtimes/node/index.js

@@ -92,7 +92,7 @@ class Delegate {
         return Promise.resolve(() => Promise.resolve());
     }
     serveAdmin(port, config, envs) {
-        var _a;
+        var _a, _b;
         const env = Object.assign(Object.assign({}, envs), { PORT: port, FUNCTIONS_CONTROL_API: "true", HOME: process.env.HOME, PATH: process.env.PATH, NODE_ENV: process.env.NODE_ENV, __FIREBASE_FRAMEWORKS_ENTRY__: process.env.__FIREBASE_FRAMEWORKS_ENTRY__ });
         if (Object.keys(config || {}).length) {
             env.CLOUD_RUNTIME_CONFIG = JSON.stringify(config);
@@ -114,17 +114,25 @@ class Delegate {
                 const childProcess = spawn(binPath, [this.sourceDir], {
                     env,
                     cwd: this.sourceDir,
-                    stdio: ["ignore", "pipe", "inherit"],
+                    stdio: ["ignore", "pipe", "pipe"],
                 });
                 (_a = childProcess.stdout) === null || _a === void 0 ? void 0 : _a.on("data", (chunk) => {
-                    logger_1.logger.debug(chunk.toString());
+                    logger_1.logger.info(chunk.toString("utf8"));
+                });
+                (_b = childProcess.stderr) === null || _b === void 0 ? void 0 : _b.on("data", (chunk) => {
+                    logger_1.logger.error(chunk.toString("utf8"));
                 });
                 return Promise.resolve(async () => {
                     const p = new Promise((resolve, reject) => {
                         childProcess.once("exit", resolve);
                         childProcess.once("error", reject);
                     });
-                    await (0, node_fetch_1.default)(`http://localhost:${port}/__/quitquitquit`);
+                    try {
+                        await (0, node_fetch_1.default)(`http://localhost:${port}/__/quitquitquit`);
+                    }
+                    catch (e) {
+                        logger_1.logger.debug("Failed to call quitquitquit. This often means the server failed to start", e);
+                    }
                     setTimeout(() => {
                         if (!childProcess.killed) {
                             childProcess.kill("SIGKILL");

package/lib/deploy/functions/runtimes/python/index.js

@@ -11,7 +11,6 @@ const discovery = require("../discovery");
 const logger_1 = require("../../../../logger");
 const python_1 = require("../../../../functions/python");
 const error_1 = require("../../../../error");
-const utils_1 = require("../../../../utils");
 exports.LATEST_VERSION = "python311";
 async function tryCreateDelegate(context) {
     const requirementsTextPath = path.join(context.sourceDir, "requirements.txt");
@@ -108,32 +107,31 @@ class Delegate {
         const modulesDir = await this.modulesDir();
         const envWithAdminPort = Object.assign(Object.assign({}, envs), { ADMIN_PORT: port.toString() });
         const args = [this.bin, `"${path.join(modulesDir, "private", "serving.py")}"`];
-        const stdout = [];
-        const stderr = [];
         logger_1.logger.debug(`Running admin server with args: ${JSON.stringify(args)} and env: ${JSON.stringify(envWithAdminPort)} in ${this.sourceDir}`);
         const childProcess = (0, python_1.runWithVirtualEnv)(args, this.sourceDir, envWithAdminPort);
         (_a = childProcess.stdout) === null || _a === void 0 ? void 0 : _a.on("data", (chunk) => {
-            const chunkString = chunk.toString();
-            stdout.push(chunkString);
-            logger_1.logger.debug(`stdout: ${chunkString}`);
+            logger_1.logger.info(chunk.toString("utf8"));
         });
         (_b = childProcess.stderr) === null || _b === void 0 ? void 0 : _b.on("data", (chunk) => {
-            const chunkString = chunk.toString();
-            stderr.push(chunkString);
-            logger_1.logger.debug(`stderr: ${chunkString}`);
+            logger_1.logger.error(chunk.toString("utf8"));
         });
-        return Promise.resolve({
-            stderr,
-            stdout,
-            killProcess: async () => {
+        return Promise.resolve(async () => {
+            try {
                 await (0, node_fetch_1.default)(`http://127.0.0.1:${port}/__/quitquitquit`);
-                const quitTimeout = setTimeout(() => {
-                    if (!childProcess.killed) {
-                        childProcess.kill("SIGKILL");
-                    }
-                }, 10000);
-                clearTimeout(quitTimeout);
-            },
+            }
+            catch (e) {
+                logger_1.logger.debug("Failed to call quitquitquit. This often means the server failed to start", e);
+            }
+            const quitTimeout = setTimeout(() => {
+                if (!childProcess.killed) {
+                    childProcess.kill("SIGKILL");
+                }
+            }, 10000);
+            clearTimeout(quitTimeout);
+            return new Promise((resolve, reject) => {
+                childProcess.once("exit", resolve);
+                childProcess.once("error", reject);
+            });
         });
     }
     async discoverBuild(_configValues, envs) {
@@ -142,14 +140,10 @@ class Delegate {
             const adminPort = await portfinder.getPortPromise({
                 port: 8081,
             });
-            const { killProcess, stderr } = await this.serveAdmin(adminPort, envs);
+            const killProcess = await this.serveAdmin(adminPort, envs);
             try {
                 discovered = await discovery.detectFromPort(adminPort, this.projectId, this.runtime);
             }
-            catch (e) {
-                (0, utils_1.logLabeledWarning)("functions", `Failed to detect functions from source ${e}.\nstderr:${stderr.join("\n")}`);
-                throw e;
-            }
             finally {
                 await killProcess();
             }

package/lib/deploy/hosting/deploy.js

@@ -5,7 +5,6 @@ const uploader_1 = require("./uploader");
 const detectProjectRoot_1 = require("../../detectProjectRoot");
 const listFiles_1 = require("../../listFiles");
 const logger_1 = require("../../logger");
-const track_1 = require("../../track");
 const utils_1 = require("../../utils");
 const colorette_1 = require("colorette");
 const ora = require("ora");
@@ -67,10 +66,6 @@ async function deploy(context, options) {
         try {
             await uploader.start();
         }
-        catch (err) {
-            void (0, track_1.track)("Hosting Deploy", "failure");
-            throw err;
-        }
         finally {
             clearInterval(progressInterval);
             updateSpinner(uploader.statusMessage(), debugging);
@@ -81,7 +76,6 @@ async function deploy(context, options) {
         (0, utils_1.logLabeledSuccess)(`hosting[${deploy.config.site}]`, "file upload complete");
         const dt = Date.now() - t0;
         logger_1.logger.debug(`[hosting] deploy completed after ${dt}ms`);
-        void (0, track_1.track)("Hosting Deploy", "success", dt);
         return runDeploys(deploys, debugging);
     }
     const debugging = !!(options.debug || options.nonInteractive);