firebase-tools 12.2.1 → 12.3.1

package/lib/commands/functions-secrets-access.js

@@ -5,8 +5,10 @@ const command_1 = require("../command");
 const logger_1 = require("../logger");
 const projectUtils_1 = require("../projectUtils");
 const secretManager_1 = require("../gcp/secretManager");
+const secrets = require("../functions/secrets");
 exports.command = new command_1.Command("functions:secrets:access <KEY>[@version]")
     .description("Access secret value given secret and its version. Defaults to accessing the latest version.")
+    .before(secrets.ensureApi)
     .action(async (key, options) => {
     const projectId = (0, projectUtils_1.needProjectId)(options);
     let [name, version] = key.split("@");

package/lib/commands/functions-secrets-destroy.js

@@ -11,6 +11,7 @@ const backend = require("../deploy/functions/backend");
 exports.command = new command_1.Command("functions:secrets:destroy <KEY>[@version]")
     .description("Destroy a secret. Defaults to destroying the latest version.")
     .withForce("Destroys a secret without confirmation.")
+    .before(secrets.ensureApi)
     .action(async (key, options) => {
     const projectId = (0, projectUtils_1.needProjectId)(options);
     const projectNumber = await (0, projectUtils_1.needProjectNumber)(options);

package/lib/commands/functions-secrets-get.js

@@ -7,8 +7,10 @@ const logger_1 = require("../logger");
 const projectUtils_1 = require("../projectUtils");
 const secretManager_1 = require("../gcp/secretManager");
 const requirePermissions_1 = require("../requirePermissions");
+const secrets = require("../functions/secrets");
 exports.command = new command_1.Command("functions:secrets:get <KEY>")
     .description("Get metadata for secret and its versions")
+    .before(secrets.ensureApi)
     .before(requirePermissions_1.requirePermissions, ["secretmanager.secrets.get"])
     .action(async (key, options) => {
     const projectId = (0, projectUtils_1.needProjectId)(options);

package/lib/commands/functions-secrets-prune.js

@@ -4,7 +4,7 @@ exports.command = void 0;
 const backend = require("../deploy/functions/backend");
 const command_1 = require("../command");
 const projectUtils_1 = require("../projectUtils");
-const secrets_1 = require("../functions/secrets");
+const secrets = require("../functions/secrets");
 const requirePermissions_1 = require("../requirePermissions");
 const deploymentTool_1 = require("../deploymentTool");
 const utils_1 = require("../utils");
@@ -13,6 +13,7 @@ const secretManager_1 = require("../gcp/secretManager");
 exports.command = new command_1.Command("functions:secrets:prune")
     .withForce("Destroys unused secrets without prompt")
     .description("Destroys unused secrets")
+    .before(secrets.ensureApi)
     .before(requirePermissions_1.requirePermissions, [
     "cloudfunctions.functions.list",
     "secretmanager.secrets.list",
@@ -27,7 +28,7 @@ exports.command = new command_1.Command("functions:secrets:prune")
     const haveEndpoints = backend
         .allEndpoints(haveBackend)
         .filter((e) => (0, deploymentTool_1.isFirebaseManaged)(e.labels || []));
-    const pruned = await (0, secrets_1.pruneSecrets)({ projectNumber, projectId }, haveEndpoints);
+    const pruned = await secrets.pruneSecrets({ projectNumber, projectId }, haveEndpoints);
     if (pruned.length === 0) {
         (0, utils_1.logBullet)("All secrets are in use. Nothing to prune today.");
         return;

package/lib/commands/functions-secrets-set.js

@@ -4,6 +4,7 @@ exports.command = void 0;
 const tty = require("tty");
 const fs = require("fs");
 const clc = require("colorette");
+const logger_1 = require("../logger");
 const secrets_1 = require("../functions/secrets");
 const command_1 = require("../command");
 const requirePermissions_1 = require("../requirePermissions");
@@ -13,9 +14,11 @@ const projectUtils_1 = require("../projectUtils");
 const secretManager_1 = require("../gcp/secretManager");
 const secrets = require("../functions/secrets");
 const backend = require("../deploy/functions/backend");
+const ensureApiEnabled_1 = require("../ensureApiEnabled");
 exports.command = new command_1.Command("functions:secrets:set <KEY>")
     .description("Create or update a secret for use in Cloud Functions for Firebase.")
     .withForce("Automatically updates functions to use the new secret.")
+    .before(secrets.ensureApi)
     .before(requirePermissions_1.requirePermissions, [
     "secretmanager.secrets.create",
     "secretmanager.secrets.get",
@@ -50,6 +53,11 @@ exports.command = new command_1.Command("functions:secrets:set <KEY>")
             clc.bold("firebase deploy --only functions"));
         return;
     }
+    const functionsEnabled = await (0, ensureApiEnabled_1.check)(projectId, "cloudfunctions.googleapis.com", "functions", true);
+    if (!functionsEnabled) {
+        logger_1.logger.debug("Customer set secrets before enabling functions. Exiting");
+        return;
+    }
     const haveBackend = await backend.existingBackend({ projectId });
     const endpointsToUpdate = backend
         .allEndpoints(haveBackend)

package/lib/commands/hosting-channel-deploy.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.command = void 0;
+exports.hostingChannelDeployAction = exports.command = void 0;
 const colorette_1 = require("colorette");
 const command_1 = require("../command");
 const error_1 = require("../error");
@@ -25,7 +25,8 @@ exports.command = new command_1.Command("hosting:channel:deploy [channelId]")
     .before(requireConfig_1.requireConfig)
     .before(requirePermissions_1.requirePermissions, ["firebasehosting.sites.update"])
     .before(requireHostingSite_1.requireHostingSite)
-    .action(async (channelId, options) => {
+    .action(hostingChannelDeployAction);
+async function hostingChannelDeployAction(channelId, options) {
     const projectId = (0, projectUtils_1.needProjectId)(options);
     if (options.open) {
         throw new error_1.FirebaseError("open is not yet implemented");
@@ -122,7 +123,8 @@ exports.command = new command_1.Command("hosting:channel:deploy [channelId]")
         (0, utils_1.logLabeledSuccess)(LOG_TAG, `Channel URL (${(0, colorette_1.bold)(d.site || d.target || "")}): ${d.url} ${expires}${version}`);
     });
     return deploys;
-});
+}
+exports.hostingChannelDeployAction = hostingChannelDeployAction;
 async function syncAuthState(projectId, sites) {
     const siteNames = sites.map((d) => d.site);
     const urlNames = sites.map((d) => d.url);

package/lib/commands/index.js

@@ -137,6 +137,8 @@ function load(client) {
     client.init = loadCommand("init");
     if (experiments.isEnabled("internaltesting")) {
         client.internaltesting = {};
+        client.internaltesting.frameworks = {};
+        client.internaltesting.frameworks.compose = loadCommand("internaltesting-frameworks-compose");
         client.internaltesting.functions = {};
         client.internaltesting.functions.discover = loadCommand("internaltesting-functions-discover");
     }

package/lib/commands/internaltesting-frameworks-compose.js

@@ -0,0 +1,20 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.command = void 0;
+const command_1 = require("../command");
+const logger_1 = require("../logger");
+const driver_1 = require("../frameworks/compose/driver");
+const compose_1 = require("../frameworks/compose");
+const error_1 = require("../error");
+exports.command = new command_1.Command("internaltesting:frameworks:compose")
+    .option("-m, --mode <mode>", "Composer mode (local or docker)", "local")
+    .description("compose framework in current directory")
+    .action((options) => {
+    const mode = options.mode;
+    if (!driver_1.SUPPORTED_MODES.includes(mode)) {
+        throw new error_1.FirebaseError(`Unsupported mode ${mode}. Supported modes are [${driver_1.SUPPORTED_MODES.join(", ")}]`);
+    }
+    const bundle = (0, compose_1.compose)(mode);
+    logger_1.logger.info(JSON.stringify(bundle, null, 2));
+    return {};
+});

package/lib/deploy/functions/release/executor.js

@@ -1,21 +1,26 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.InlineExecutor = exports.QueueExecutor = void 0;
+exports.InlineExecutor = exports.QueueExecutor = exports.DEFAULT_RETRY_CODES = void 0;
 const queue_1 = require("../../../throttler/queue");
-async function handler(op) {
+exports.DEFAULT_RETRY_CODES = [429, 409, 503];
+function parseErrorCode(err) {
     var _a, _b, _c, _d, _e, _f;
+    return (err.status ||
+        err.code ||
+        ((_b = (_a = err.context) === null || _a === void 0 ? void 0 : _a.response) === null || _b === void 0 ? void 0 : _b.statusCode) ||
+        ((_c = err.original) === null || _c === void 0 ? void 0 : _c.code) ||
+        ((_f = (_e = (_d = err.original) === null || _d === void 0 ? void 0 : _d.context) === null || _e === void 0 ? void 0 : _e.response) === null || _f === void 0 ? void 0 : _f.statusCode));
+}
+async function handler(op) {
     try {
         op.result = await op.func();
     }
     catch (err) {
-        const code = err.status ||
-            err.code ||
-            ((_b = (_a = err.context) === null || _a === void 0 ? void 0 : _a.response) === null || _b === void 0 ? void 0 : _b.statusCode) ||
-            ((_c = err.original) === null || _c === void 0 ? void 0 : _c.code) ||
-            ((_f = (_e = (_d = err.original) === null || _d === void 0 ? void 0 : _d.context) === null || _e === void 0 ? void 0 : _e.response) === null || _f === void 0 ? void 0 : _f.statusCode);
-        if (code === 429 || code === 409 || code === 503) {
+        const code = parseErrorCode(err);
+        if (op.retryCodes.includes(code)) {
             throw err;
         }
+        err.code = code;
         op.error = err;
     }
     return;
@@ -24,8 +29,12 @@ class QueueExecutor {
     constructor(options) {
         this.queue = new queue_1.Queue(Object.assign(Object.assign({}, options), { handler }));
     }
-    async run(func) {
-        const op = { func };
+    async run(func, opts) {
+        const retryCodes = (opts === null || opts === void 0 ? void 0 : opts.retryCodes) || exports.DEFAULT_RETRY_CODES;
+        const op = {
+            func,
+            retryCodes,
+        };
         await this.queue.run(op);
         if (op.error) {
             throw op.error;

package/lib/deploy/functions/release/fabricator.js

@@ -2,6 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.Fabricator = void 0;
 const clc = require("colorette");
+const executor_1 = require("./executor");
 const error_1 = require("../../../error");
 const sourceTokenScraper_1 = require("./sourceTokenScraper");
 const timer_1 = require("./timer");
@@ -44,6 +45,7 @@ const eventarcPollerOptions = {
     masterTimeout: 25 * 60 * 1000,
     maxBackoff: 10000,
 };
+const CLOUD_RUN_RESOURCE_EXHAUSTED_CODE = 8;
 const rethrowAs = (endpoint, op) => (err) => {
     logger_1.logger.error(err.message);
     throw new reporter.DeploymentError(endpoint, op, err);
@@ -269,12 +271,24 @@ class Fabricator {
             })
                 .catch(rethrowAs(endpoint, "upsert eventarc channel"));
         }
-        const resultFunction = await this.functionExecutor
-            .run(async () => {
-            const op = await gcfV2.createFunction(apiFunction);
-            return await poller.pollOperation(Object.assign(Object.assign({}, gcfV2PollerOptions), { pollerName: `create-${endpoint.codebase}-${endpoint.region}-${endpoint.id}`, operationResourceName: op.name }));
-        })
-            .catch(rethrowAs(endpoint, "create"));
+        let resultFunction = null;
+        while (!resultFunction) {
+            resultFunction = await this.functionExecutor
+                .run(async () => {
+                const op = await gcfV2.createFunction(apiFunction);
+                return await poller.pollOperation(Object.assign(Object.assign({}, gcfV2PollerOptions), { pollerName: `create-${endpoint.codebase}-${endpoint.region}-${endpoint.id}`, operationResourceName: op.name }));
+            })
+                .catch(async (err) => {
+                if (err.code === CLOUD_RUN_RESOURCE_EXHAUSTED_CODE) {
+                    await this.deleteV2Function(endpoint);
+                    return null;
+                }
+                else {
+                    logger_1.logger.error(err.message);
+                    throw new reporter.DeploymentError(endpoint, "create", err);
+                }
+            });
+        }
         endpoint.uri = (_d = resultFunction.serviceConfig) === null || _d === void 0 ? void 0 : _d.uri;
         const serviceName = (_e = resultFunction.serviceConfig) === null || _e === void 0 ? void 0 : _e.service;
         endpoint.runServiceId = utils.last(serviceName === null || serviceName === void 0 ? void 0 : serviceName.split("/"));
@@ -367,7 +381,7 @@ class Fabricator {
             .run(async () => {
             const op = await gcfV2.updateFunction(apiFunction);
             return await poller.pollOperation(Object.assign(Object.assign({}, gcfV2PollerOptions), { pollerName: `update-${endpoint.codebase}-${endpoint.region}-${endpoint.id}`, operationResourceName: op.name }));
-        })
+        }, { retryCodes: [...executor_1.DEFAULT_RETRY_CODES, CLOUD_RUN_RESOURCE_EXHAUSTED_CODE] })
             .catch(rethrowAs(endpoint, "update"));
         endpoint.uri = (_c = resultFunction.serviceConfig) === null || _c === void 0 ? void 0 : _c.uri;
         const serviceName = (_d = resultFunction.serviceConfig) === null || _d === void 0 ? void 0 : _d.service;
@@ -414,7 +428,7 @@ class Fabricator {
             const op = await gcfV2.deleteFunction(fnName);
             const pollerOptions = Object.assign(Object.assign({}, gcfV2PollerOptions), { pollerName: `delete-${endpoint.codebase}-${endpoint.region}-${endpoint.id}`, operationResourceName: op.name });
             await poller.pollOperation(pollerOptions);
-        })
+        }, { retryCodes: [...executor_1.DEFAULT_RETRY_CODES, CLOUD_RUN_RESOURCE_EXHAUSTED_CODE] })
             .catch(rethrowAs(endpoint, "delete"));
     }
     async setRunTraits(serviceName, endpoint) {

package/lib/deploy/index.js

@@ -52,7 +52,7 @@ const deploy = async function (targetNames, options, customContext = {}) {
         const config = options.config.get("hosting");
         if (Array.isArray(config) ? config.some((it) => it.source) : config.source) {
             experiments.assertEnabled("webframeworks", "deploy a web framework from source");
-            await (0, frameworks_1.prepareFrameworks)(targetNames, context, options);
+            await (0, frameworks_1.prepareFrameworks)("deploy", targetNames, context, options);
         }
     }
     if (targetNames.includes("hosting") && (0, prepare_1.hasPinnedFunctions)(options)) {

package/lib/emulator/auth/operations.js

@@ -146,13 +146,13 @@ async function signUp(state, reqBody, ctx) {
             (0, errors_1.assert)(state.enableAnonymousUser, "ADMIN_ONLY_OPERATION");
         }
     }
-    if (reqBody.email) {
+    if (typeof reqBody.email === "string") {
         (0, errors_1.assert)((0, utils_1.isValidEmailAddress)(reqBody.email), "INVALID_EMAIL");
         const email = (0, utils_1.canonicalizeEmailAddress)(reqBody.email);
         (0, errors_1.assert)(!state.getUserByEmail(email), "EMAIL_EXISTS");
         updates.email = email;
     }
-    if (reqBody.password) {
+    if (typeof reqBody.password === "string") {
         (0, errors_1.assert)(reqBody.password.length >= PASSWORD_MIN_LENGTH, `WEAK_PASSWORD : Password should be at least ${PASSWORD_MIN_LENGTH} characters`);
         updates.salt = "fakeSalt" + (0, utils_1.randomId)(20);
         updates.passwordHash = hashPassword(reqBody.password, updates.salt);

package/lib/emulator/commandUtils.js

@@ -288,7 +288,7 @@ async function emulatorExec(script, options) {
     let deprecationNotices;
     try {
         const showUI = !!options.ui;
-        ({ deprecationNotices } = await controller.startAll(options, showUI));
+        ({ deprecationNotices } = await controller.startAll(options, showUI, true));
         exitCode = await runScript(script, extraEnv);
         await controller.onExit(options);
     }

package/lib/emulator/controller.js

@@ -116,6 +116,10 @@ function shouldStart(options, name) {
 }
 exports.shouldStart = shouldStart;
 function findExportMetadata(importPath) {
+    const pathExists = fs.existsSync(importPath);
+    if (!pathExists) {
+        throw new error_1.FirebaseError(`Directory "${importPath}" does not exist.`);
+    }
     const pathIsDirectory = fs.lstatSync(importPath).isDirectory();
     if (!pathIsDirectory) {
         return;
@@ -151,7 +155,7 @@ function findExportMetadata(importPath) {
         return metadata;
     }
 }
-async function startAll(options, showUI = true) {
+async function startAll(options, showUI = true, runningTestScript = false) {
     var _a, _b, _c, _d, _e, _f, _g;
     const targets = filterEmulatorTargets(options);
     options.targets = targets;
@@ -291,7 +295,7 @@ async function startAll(options, showUI = true) {
                 });
             }
         }
-        await (0, frameworks_1.prepareFrameworks)(targets, options, options, emulators);
+        await (0, frameworks_1.prepareFrameworks)(runningTestScript ? "test" : "emulate", targets, undefined, options, emulators);
     }
     const projectDir = (options.extDevDir || options.config.projectDir);
     if (shouldStart(options, types_1.Emulators.FUNCTIONS)) {

package/lib/emulator/functionsEmulatorShared.js

@@ -272,6 +272,9 @@ function getSignatureType(def) {
     if (def.httpsTrigger || def.blockingTrigger) {
         return "http";
     }
+    if (def.platform === "gcfv2" && def.schedule) {
+        return "http";
+    }
     return def.platform === "gcfv2" ? "cloudevent" : "event";
 }
 exports.getSignatureType = getSignatureType;

package/lib/frameworks/angular/index.js

@@ -44,7 +44,7 @@ async function init(setup, config) {
 }
 exports.init = init;
 async function build(dir, configuration) {
-    const { targets, serverTarget, serveOptimizedImages, locales, baseHref } = await (0, utils_2.getBuildConfig)(dir, configuration);
+    const { targets, serverTarget, serveOptimizedImages, locales, baseHref: baseUrl, } = await (0, utils_2.getBuildConfig)(dir, configuration);
     await (0, utils_1.warnIfCustomBuildScript)(dir, exports.name, DEFAULT_BUILD_SCRIPT);
     for (const target of targets) {
         const cli = (0, utils_1.getNodeModuleBin)("ng", dir);
@@ -60,12 +60,12 @@ async function build(dir, configuration) {
         ? []
         : [
             {
-                source: path_1.posix.join(baseHref, "**"),
-                destination: path_1.posix.join(baseHref, "index.html"),
+                source: path_1.posix.join(baseUrl, "**"),
+                destination: path_1.posix.join(baseUrl, "index.html"),
             },
         ];
     const i18n = !!locales;
-    return { wantsBackend, i18n, rewrites };
+    return { wantsBackend, i18n, rewrites, baseUrl };
 }
 exports.build = build;
 async function getDevModeHandle(dir, configuration) {
@@ -73,7 +73,7 @@ async function getDevModeHandle(dir, configuration) {
     const { serveTarget } = await (0, utils_2.getContext)(dir, configuration);
     if (!serveTarget)
         throw new Error("Could not find the serveTarget");
-    const host = new Promise((resolve) => {
+    const host = new Promise((resolve, reject) => {
         const cli = (0, utils_1.getNodeModuleBin)("ng", dir);
         const serve = (0, cross_spawn_1.spawn)(cli, ["run", targetStringFromTarget(serveTarget), "--host", "localhost"], {
             cwd: dir,
@@ -87,6 +87,7 @@ async function getDevModeHandle(dir, configuration) {
         serve.stderr.on("data", (data) => {
             process.stderr.write(data);
         });
+        serve.on("exit", reject);
     });
     return (0, utils_1.simpleProxy)(await host);
 }
@@ -114,7 +115,7 @@ async function getValidBuildTargets(purpose, dir) {
     const validTargetNames = new Set(["development", "production"]);
     try {
         const { workspaceProject, browserTarget, serverTarget, serveTarget } = await (0, utils_2.getContext)(dir);
-        const { target } = ((purpose === "serve" && serveTarget) || serverTarget || browserTarget);
+        const { target } = ((purpose === "emulate" && serveTarget) || serverTarget || browserTarget);
         const workspaceTarget = workspaceProject.targets.get(target);
         Object.keys(workspaceTarget.configurations || {}).forEach((it) => validTargetNames.add(it));
     }
@@ -134,7 +135,7 @@ exports.shouldUseDevModeHandle = shouldUseDevModeHandle;
 async function ɵcodegenFunctionsDirectory(sourceDir, destDir, configuration) {
     var _a;
     var _b;
-    const { packageJson, serverOutputPath, browserOutputPath, defaultLocale, serverLocales, browserLocales, bundleDependencies, externalDependencies, baseHref: baseUrl, serveOptimizedImages, } = await (0, utils_2.getServerConfig)(sourceDir, configuration);
+    const { packageJson, serverOutputPath, browserOutputPath, defaultLocale, serverLocales, browserLocales, bundleDependencies, externalDependencies, baseHref, serveOptimizedImages, } = await (0, utils_2.getServerConfig)(sourceDir, configuration);
     const dotEnv = { __NG_BROWSER_OUTPUT_PATH__: browserOutputPath };
     let rewriteSource = undefined;
     await Promise.all([
@@ -187,8 +188,8 @@ exports.handle = function(req,res) {
     }
     else {
         bootstrapScript = `exports.handle = (res, req) => req.sendStatus(404);\n`;
-        rewriteSource = path_1.posix.join(baseUrl, "__image__");
+        rewriteSource = path_1.posix.join(baseHref, "__image__");
     }
-    return { bootstrapScript, packageJson, baseUrl, dotEnv, rewriteSource };
+    return { bootstrapScript, packageJson, dotEnv, rewriteSource };
 }
 exports.ɵcodegenFunctionsDirectory = ɵcodegenFunctionsDirectory;

package/lib/frameworks/astro/index.js

@@ -21,7 +21,7 @@ async function discover(dir) {
         return;
     const { output, publicDir: publicDirectory } = await (0, utils_2.getConfig)(dir);
     return {
-        mayWantBackend: output === "server",
+        mayWantBackend: output !== "static",
         publicDirectory,
     };
 }
@@ -31,18 +31,19 @@ async function build(cwd) {
     const cli = (0, utils_1.getNodeModuleBin)("astro", cwd);
     await (0, utils_1.warnIfCustomBuildScript)(cwd, exports.name, DEFAULT_BUILD_SCRIPT);
     const { output, adapter } = await (0, utils_2.getConfig)(cwd);
-    if (output === "server" && (adapter === null || adapter === void 0 ? void 0 : adapter.name) !== "@astrojs/node") {
-        throw new error_1.FirebaseError("Deploying an Astro application with SSR on Firebase Hosting requires the @astrojs/node adapter.");
+    const wantsBackend = output !== "static";
+    if (wantsBackend && (adapter === null || adapter === void 0 ? void 0 : adapter.name) !== "@astrojs/node") {
+        throw new error_1.FirebaseError("Deploying an Astro application with SSR on Firebase Hosting requires the @astrojs/node adapter in middleware mode. https://docs.astro.build/en/guides/integrations-guide/node/");
     }
     const build = (0, cross_spawn_1.sync)(cli, ["build"], { cwd, stdio: "inherit" });
     if (build.status !== 0)
         throw new error_1.FirebaseError("Unable to build your Astro app");
-    return { wantsBackend: output === "server" };
+    return { wantsBackend };
 }
 exports.build = build;
 async function ɵcodegenPublicDirectory(root, dest) {
     const { outDir, output } = await (0, utils_2.getConfig)(root);
-    const assetPath = (0, path_1.join)(root, outDir, output === "server" ? "client" : "");
+    const assetPath = (0, path_1.join)(root, outDir, output !== "static" ? "client" : "");
     await (0, fs_extra_1.copy)(assetPath, dest);
 }
 exports.ɵcodegenPublicDirectory = ɵcodegenPublicDirectory;
@@ -57,7 +58,7 @@ async function ɵcodegenFunctionsDirectory(sourceDir, destDir) {
 }
 exports.ɵcodegenFunctionsDirectory = ɵcodegenFunctionsDirectory;
 async function getDevModeHandle(cwd) {
-    const host = new Promise((resolve) => {
+    const host = new Promise((resolve, reject) => {
         const cli = (0, utils_1.getNodeModuleBin)("astro", cwd);
         const serve = (0, cross_spawn_1.spawn)(cli, ["dev"], { cwd });
         serve.stdout.on("data", (data) => {
@@ -69,6 +70,7 @@ async function getDevModeHandle(cwd) {
         serve.stderr.on("data", (data) => {
             process.stderr.write(data);
         });
+        serve.on("exit", reject);
     });
     return (0, utils_1.simpleProxy)(await host);
 }

package/lib/frameworks/compose/discover/index.js

@@ -0,0 +1,23 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.discover = void 0;
+function discover() {
+    return {
+        baseImage: "us-docker.pkg.dev/firestack-build/test/run:latest",
+        environmentVariables: {
+            NODE_ENV: "PRODUCTION",
+        },
+        installCommand: "npm install",
+        buildCommand: "npm run build",
+        startCommand: "npm run start",
+        afterInstall: (b) => {
+            console.log("HOOK: AFTER INSTALL");
+            return Object.assign(Object.assign({}, b), { version: "v1alpha", notes: "afterInstall" });
+        },
+        afterBuild(b) {
+            console.log("HOOK: AFTER BUILD");
+            return Object.assign(Object.assign({}, b), { version: "v1alpha", notes: "afterBuild" });
+        },
+    };
+}
+exports.discover = discover;