firebase-tools 12.2.1 → 12.3.0

package/lib/commands/hosting-channel-deploy.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.command = void 0;
+exports.hostingChannelDeployAction = exports.command = void 0;
 const colorette_1 = require("colorette");
 const command_1 = require("../command");
 const error_1 = require("../error");
@@ -25,7 +25,8 @@ exports.command = new command_1.Command("hosting:channel:deploy [channelId]")
     .before(requireConfig_1.requireConfig)
     .before(requirePermissions_1.requirePermissions, ["firebasehosting.sites.update"])
     .before(requireHostingSite_1.requireHostingSite)
-    .action(async (channelId, options) => {
+    .action(hostingChannelDeployAction);
+async function hostingChannelDeployAction(channelId, options) {
     const projectId = (0, projectUtils_1.needProjectId)(options);
     if (options.open) {
         throw new error_1.FirebaseError("open is not yet implemented");
@@ -122,7 +123,8 @@ exports.command = new command_1.Command("hosting:channel:deploy [channelId]")
         (0, utils_1.logLabeledSuccess)(LOG_TAG, `Channel URL (${(0, colorette_1.bold)(d.site || d.target || "")}): ${d.url} ${expires}${version}`);
     });
     return deploys;
-});
+}
+exports.hostingChannelDeployAction = hostingChannelDeployAction;
 async function syncAuthState(projectId, sites) {
     const siteNames = sites.map((d) => d.site);
     const urlNames = sites.map((d) => d.url);

package/lib/deploy/index.js

@@ -52,7 +52,7 @@ const deploy = async function (targetNames, options, customContext = {}) {
         const config = options.config.get("hosting");
         if (Array.isArray(config) ? config.some((it) => it.source) : config.source) {
             experiments.assertEnabled("webframeworks", "deploy a web framework from source");
-            await (0, frameworks_1.prepareFrameworks)(targetNames, context, options);
+            await (0, frameworks_1.prepareFrameworks)("deploy", targetNames, context, options);
         }
     }
     if (targetNames.includes("hosting") && (0, prepare_1.hasPinnedFunctions)(options)) {

package/lib/emulator/auth/operations.js

@@ -146,13 +146,13 @@ async function signUp(state, reqBody, ctx) {
             (0, errors_1.assert)(state.enableAnonymousUser, "ADMIN_ONLY_OPERATION");
         }
     }
-    if (reqBody.email) {
+    if (typeof reqBody.email === "string") {
         (0, errors_1.assert)((0, utils_1.isValidEmailAddress)(reqBody.email), "INVALID_EMAIL");
         const email = (0, utils_1.canonicalizeEmailAddress)(reqBody.email);
         (0, errors_1.assert)(!state.getUserByEmail(email), "EMAIL_EXISTS");
         updates.email = email;
     }
-    if (reqBody.password) {
+    if (typeof reqBody.password === "string") {
         (0, errors_1.assert)(reqBody.password.length >= PASSWORD_MIN_LENGTH, `WEAK_PASSWORD : Password should be at least ${PASSWORD_MIN_LENGTH} characters`);
         updates.salt = "fakeSalt" + (0, utils_1.randomId)(20);
         updates.passwordHash = hashPassword(reqBody.password, updates.salt);

package/lib/emulator/commandUtils.js

@@ -288,7 +288,7 @@ async function emulatorExec(script, options) {
     let deprecationNotices;
     try {
         const showUI = !!options.ui;
-        ({ deprecationNotices } = await controller.startAll(options, showUI));
+        ({ deprecationNotices } = await controller.startAll(options, showUI, true));
         exitCode = await runScript(script, extraEnv);
         await controller.onExit(options);
     }

package/lib/emulator/controller.js

@@ -116,6 +116,10 @@ function shouldStart(options, name) {
 }
 exports.shouldStart = shouldStart;
 function findExportMetadata(importPath) {
+    const pathExists = fs.existsSync(importPath);
+    if (!pathExists) {
+        throw new error_1.FirebaseError(`Directory "${importPath}" does not exist.`);
+    }
     const pathIsDirectory = fs.lstatSync(importPath).isDirectory();
     if (!pathIsDirectory) {
         return;
@@ -151,7 +155,7 @@ function findExportMetadata(importPath) {
         return metadata;
     }
 }
-async function startAll(options, showUI = true) {
+async function startAll(options, showUI = true, runningTestScript = false) {
     var _a, _b, _c, _d, _e, _f, _g;
     const targets = filterEmulatorTargets(options);
     options.targets = targets;
@@ -291,7 +295,7 @@ async function startAll(options, showUI = true) {
                 });
             }
         }
-        await (0, frameworks_1.prepareFrameworks)(targets, options, options, emulators);
+        await (0, frameworks_1.prepareFrameworks)(runningTestScript ? "test" : "emulate", targets, undefined, options, emulators);
     }
     const projectDir = (options.extDevDir || options.config.projectDir);
     if (shouldStart(options, types_1.Emulators.FUNCTIONS)) {

package/lib/emulator/functionsEmulatorShared.js

@@ -272,6 +272,9 @@ function getSignatureType(def) {
     if (def.httpsTrigger || def.blockingTrigger) {
         return "http";
     }
+    if (def.platform === "gcfv2" && def.schedule) {
+        return "http";
+    }
     return def.platform === "gcfv2" ? "cloudevent" : "event";
 }
 exports.getSignatureType = getSignatureType;

package/lib/frameworks/angular/index.js

@@ -44,7 +44,7 @@ async function init(setup, config) {
 }
 exports.init = init;
 async function build(dir, configuration) {
-    const { targets, serverTarget, serveOptimizedImages, locales, baseHref } = await (0, utils_2.getBuildConfig)(dir, configuration);
+    const { targets, serverTarget, serveOptimizedImages, locales, baseHref: baseUrl, } = await (0, utils_2.getBuildConfig)(dir, configuration);
     await (0, utils_1.warnIfCustomBuildScript)(dir, exports.name, DEFAULT_BUILD_SCRIPT);
     for (const target of targets) {
         const cli = (0, utils_1.getNodeModuleBin)("ng", dir);
@@ -60,12 +60,12 @@ async function build(dir, configuration) {
         ? []
         : [
             {
-                source: path_1.posix.join(baseHref, "**"),
-                destination: path_1.posix.join(baseHref, "index.html"),
+                source: path_1.posix.join(baseUrl, "**"),
+                destination: path_1.posix.join(baseUrl, "index.html"),
             },
         ];
     const i18n = !!locales;
-    return { wantsBackend, i18n, rewrites };
+    return { wantsBackend, i18n, rewrites, baseUrl };
 }
 exports.build = build;
 async function getDevModeHandle(dir, configuration) {
@@ -73,7 +73,7 @@ async function getDevModeHandle(dir, configuration) {
     const { serveTarget } = await (0, utils_2.getContext)(dir, configuration);
     if (!serveTarget)
         throw new Error("Could not find the serveTarget");
-    const host = new Promise((resolve) => {
+    const host = new Promise((resolve, reject) => {
         const cli = (0, utils_1.getNodeModuleBin)("ng", dir);
         const serve = (0, cross_spawn_1.spawn)(cli, ["run", targetStringFromTarget(serveTarget), "--host", "localhost"], {
             cwd: dir,
@@ -87,6 +87,7 @@ async function getDevModeHandle(dir, configuration) {
         serve.stderr.on("data", (data) => {
             process.stderr.write(data);
         });
+        serve.on("exit", reject);
     });
     return (0, utils_1.simpleProxy)(await host);
 }
@@ -114,7 +115,7 @@ async function getValidBuildTargets(purpose, dir) {
     const validTargetNames = new Set(["development", "production"]);
     try {
         const { workspaceProject, browserTarget, serverTarget, serveTarget } = await (0, utils_2.getContext)(dir);
-        const { target } = ((purpose === "serve" && serveTarget) || serverTarget || browserTarget);
+        const { target } = ((purpose === "emulate" && serveTarget) || serverTarget || browserTarget);
         const workspaceTarget = workspaceProject.targets.get(target);
         Object.keys(workspaceTarget.configurations || {}).forEach((it) => validTargetNames.add(it));
     }
@@ -134,7 +135,7 @@ exports.shouldUseDevModeHandle = shouldUseDevModeHandle;
 async function ɵcodegenFunctionsDirectory(sourceDir, destDir, configuration) {
     var _a;
     var _b;
-    const { packageJson, serverOutputPath, browserOutputPath, defaultLocale, serverLocales, browserLocales, bundleDependencies, externalDependencies, baseHref: baseUrl, serveOptimizedImages, } = await (0, utils_2.getServerConfig)(sourceDir, configuration);
+    const { packageJson, serverOutputPath, browserOutputPath, defaultLocale, serverLocales, browserLocales, bundleDependencies, externalDependencies, baseHref, serveOptimizedImages, } = await (0, utils_2.getServerConfig)(sourceDir, configuration);
     const dotEnv = { __NG_BROWSER_OUTPUT_PATH__: browserOutputPath };
     let rewriteSource = undefined;
     await Promise.all([
@@ -187,8 +188,8 @@ exports.handle = function(req,res) {
     }
     else {
         bootstrapScript = `exports.handle = (res, req) => req.sendStatus(404);\n`;
-        rewriteSource = path_1.posix.join(baseUrl, "__image__");
+        rewriteSource = path_1.posix.join(baseHref, "__image__");
     }
-    return { bootstrapScript, packageJson, baseUrl, dotEnv, rewriteSource };
+    return { bootstrapScript, packageJson, dotEnv, rewriteSource };
 }
 exports.ɵcodegenFunctionsDirectory = ɵcodegenFunctionsDirectory;

package/lib/frameworks/astro/index.js

@@ -21,7 +21,7 @@ async function discover(dir) {
         return;
     const { output, publicDir: publicDirectory } = await (0, utils_2.getConfig)(dir);
     return {
-        mayWantBackend: output === "server",
+        mayWantBackend: output !== "static",
         publicDirectory,
     };
 }
@@ -31,18 +31,19 @@ async function build(cwd) {
     const cli = (0, utils_1.getNodeModuleBin)("astro", cwd);
     await (0, utils_1.warnIfCustomBuildScript)(cwd, exports.name, DEFAULT_BUILD_SCRIPT);
     const { output, adapter } = await (0, utils_2.getConfig)(cwd);
-    if (output === "server" && (adapter === null || adapter === void 0 ? void 0 : adapter.name) !== "@astrojs/node") {
-        throw new error_1.FirebaseError("Deploying an Astro application with SSR on Firebase Hosting requires the @astrojs/node adapter.");
+    const wantsBackend = output !== "static";
+    if (wantsBackend && (adapter === null || adapter === void 0 ? void 0 : adapter.name) !== "@astrojs/node") {
+        throw new error_1.FirebaseError("Deploying an Astro application with SSR on Firebase Hosting requires the @astrojs/node adapter in middleware mode. https://docs.astro.build/en/guides/integrations-guide/node/");
     }
     const build = (0, cross_spawn_1.sync)(cli, ["build"], { cwd, stdio: "inherit" });
     if (build.status !== 0)
         throw new error_1.FirebaseError("Unable to build your Astro app");
-    return { wantsBackend: output === "server" };
+    return { wantsBackend };
 }
 exports.build = build;
 async function ɵcodegenPublicDirectory(root, dest) {
     const { outDir, output } = await (0, utils_2.getConfig)(root);
-    const assetPath = (0, path_1.join)(root, outDir, output === "server" ? "client" : "");
+    const assetPath = (0, path_1.join)(root, outDir, output !== "static" ? "client" : "");
     await (0, fs_extra_1.copy)(assetPath, dest);
 }
 exports.ɵcodegenPublicDirectory = ɵcodegenPublicDirectory;
@@ -57,7 +58,7 @@ async function ɵcodegenFunctionsDirectory(sourceDir, destDir) {
 }
 exports.ɵcodegenFunctionsDirectory = ɵcodegenFunctionsDirectory;
 async function getDevModeHandle(cwd) {
-    const host = new Promise((resolve) => {
+    const host = new Promise((resolve, reject) => {
         const cli = (0, utils_1.getNodeModuleBin)("astro", cwd);
         const serve = (0, cross_spawn_1.spawn)(cli, ["dev"], { cwd });
         serve.stdout.on("data", (data) => {
@@ -69,6 +70,7 @@ async function getDevModeHandle(cwd) {
         serve.stderr.on("data", (data) => {
             process.stderr.write(data);
         });
+        serve.on("exit", reject);
     });
     return (0, utils_1.simpleProxy)(await host);
 }

package/lib/frameworks/index.js

@@ -8,7 +8,6 @@ const cross_spawn_1 = require("cross-spawn");
 const promises_1 = require("fs/promises");
 const fs_extra_1 = require("fs-extra");
 const process = require("node:process");
-const semver = require("semver");
 const glob = require("glob");
 const projectUtils_1 = require("../projectUtils");
 const config_1 = require("../hosting/config");
@@ -30,6 +29,8 @@ Object.defineProperty(exports, "WebFrameworks", { enumerable: true, get: functio
 const utils_2 = require("../utils");
 const ensureTargeted_1 = require("../functions/ensureTargeted");
 const util_1 = require("util");
+const projectPath_1 = require("../projectPath");
+const logger_1 = require("../logger");
 async function discover(dir, warn = true) {
     const allFrameworkTypes = [
         ...new Set(Object.values(constants_2.WebFrameworks).map(({ type }) => type)),
@@ -71,21 +72,17 @@ function memoizeBuild(dir, build, deps, target) {
     BUILD_MEMO.set(key, value);
     return value;
 }
-async function prepareFrameworks(targetNames, context, options, emulators = []) {
-    var _a, _b, _c, _d, _e;
-    var _f, _g, _h, _j, _k;
-    const nodeVersion = process.version;
-    if (!semver.satisfies(nodeVersion, ">=16.0.0")) {
-        throw new error_1.FirebaseError(`The frameworks awareness feature requires Node.JS >= 16 and npm >= 8 in order to work correctly, due to some of the downstream dependencies. Please upgrade your version of Node.JS, reinstall firebase-tools, and give it another go.`);
-    }
-    const project = (0, projectUtils_1.needProjectId)(context);
-    const { projectRoot } = options;
+async function prepareFrameworks(purpose, targetNames, context, options, emulators = []) {
+    var _a, _b, _c, _d, _e, _f;
+    var _g, _h, _j, _k, _l;
+    const project = (0, projectUtils_1.needProjectId)(context || options);
+    const projectRoot = (0, projectPath_1.resolveProjectPath)(options, ".");
     const account = (0, auth_1.getProjectDefaultAccount)(projectRoot);
     if (!options.site) {
         try {
             await (0, requireHostingSite_1.requireHostingSite)(options);
         }
-        catch (_l) {
+        catch (_m) {
             options.site = project;
         }
     }
@@ -189,13 +186,17 @@ async function prepareFrameworks(targetNames, context, options, emulators = [])
         }
         const { framework, mayWantBackend, publicDirectory } = results;
         const { build, ɵcodegenPublicDirectory, ɵcodegenFunctionsDirectory: codegenProdModeFunctionsDirectory, getDevModeHandle, name, support, docsUrl, getValidBuildTargets = constants_2.GET_DEFAULT_BUILD_TARGETS, shouldUseDevModeHandle = constants_2.DEFAULT_SHOULD_USE_DEV_MODE_HANDLE, } = constants_2.WebFrameworks[framework];
-        console.log(`\n${(0, utils_1.frameworksCallToAction)(constants_2.SupportLevelWarnings[support](name), docsUrl, "   ")}\n`);
+        logger_1.logger.info(`\n${(0, utils_1.frameworksCallToAction)(constants_2.SupportLevelWarnings[support](name), docsUrl, "   ")}\n`);
         const hostingEmulatorInfo = emulators.find((e) => e.name === types_1.Emulators.HOSTING);
-        const buildTargetPurpose = context._name === "deploy" ? "deploy" : context._name === "emulators:exec" ? "test" : "serve";
-        const validBuildTargets = await getValidBuildTargets(buildTargetPurpose, getProjectPath());
-        const frameworksBuildTarget = (0, utils_1.getFrameworksBuildTarget)(buildTargetPurpose, validBuildTargets);
-        const useDevModeHandle = await shouldUseDevModeHandle(frameworksBuildTarget, getProjectPath());
+        const validBuildTargets = await getValidBuildTargets(purpose, getProjectPath());
+        const frameworksBuildTarget = (0, utils_1.getFrameworksBuildTarget)(purpose, validBuildTargets);
+        const useDevModeHandle = purpose !== "deploy" &&
+            (await shouldUseDevModeHandle(frameworksBuildTarget, getProjectPath()));
         let codegenFunctionsDirectory;
+        let baseUrl = "";
+        const rewrites = [];
+        const redirects = [];
+        const headers = [];
         const devModeHandle = useDevModeHandle &&
             getDevModeHandle &&
             (await getDevModeHandle(getProjectPath(), frameworksBuildTarget, hostingEmulatorInfo));
@@ -208,13 +209,19 @@ async function prepareFrameworks(targetNames, context, options, emulators = [])
         }
         else {
             const buildResult = await memoizeBuild(getProjectPath(), build, [firebaseDefaults, frameworksBuildTarget], frameworksBuildTarget);
-            const { wantsBackend = false, rewrites = [], redirects = [], headers = [], trailingSlash, i18n = false, } = buildResult || {};
-            config.rewrites.push(...rewrites);
-            config.redirects.push(...redirects);
-            config.headers.push(...headers);
-            (_d = config.trailingSlash) !== null && _d !== void 0 ? _d : (config.trailingSlash = trailingSlash);
+            const { wantsBackend = false, trailingSlash, i18n = false } = buildResult || {};
+            if (buildResult) {
+                baseUrl = (_d = buildResult.baseUrl) !== null && _d !== void 0 ? _d : baseUrl;
+                if (buildResult.headers)
+                    headers.push(...buildResult.headers);
+                if (buildResult.rewrites)
+                    rewrites.push(...buildResult.rewrites);
+                if (buildResult.redirects)
+                    redirects.push(...buildResult.redirects);
+            }
+            (_e = config.trailingSlash) !== null && _e !== void 0 ? _e : (config.trailingSlash = trailingSlash);
             if (i18n)
-                (_e = config.i18n) !== null && _e !== void 0 ? _e : (config.i18n = { root: constants_2.I18N_ROOT });
+                (_f = config.i18n) !== null && _f !== void 0 ? _f : (config.i18n = { root: constants_2.I18N_ROOT });
             if (await (0, fs_extra_1.pathExists)(hostingDist))
                 await (0, promises_1.rm)(hostingDist, { recursive: true });
             await (0, fs_extra_1.mkdirp)(hostingDist);
@@ -232,7 +239,7 @@ async function prepareFrameworks(targetNames, context, options, emulators = [])
                 firebaseDefaults._authTokenSyncURL = "/__session";
                 process.env.__FIREBASE_DEFAULTS__ = JSON.stringify(firebaseDefaults);
             }
-            if (context.hostingChannel) {
+            if (context === null || context === void 0 ? void 0 : context.hostingChannel) {
                 experiments.assertEnabled("pintags", "deploy an app that requires a backend to a preview channel");
             }
             const codebase = `firebase-frameworks-${site}`;
@@ -246,10 +253,7 @@ async function prepareFrameworks(targetNames, context, options, emulators = [])
                     codebase,
                 },
             ]);
-            if (!experiments.isEnabled("pintags") ||
-                context._name === "serve" ||
-                context._name === "emulators:start" ||
-                context._name === "emulators:exec") {
+            if (!experiments.isEnabled("pintags") || purpose !== "deploy") {
                 if (!targetNames.includes("functions")) {
                     targetNames.unshift("functions");
                 }
@@ -273,38 +277,41 @@ async function prepareFrameworks(targetNames, context, options, emulators = [])
             else {
                 await (0, fs_extra_1.mkdirp)(functionsDist);
             }
-            const { packageJson, bootstrapScript, frameworksEntry = framework, baseUrl = "", dotEnv = {}, rewriteSource = path_1.posix.join(baseUrl, "**"), } = await codegenFunctionsDirectory(getProjectPath(), functionsDist, frameworksBuildTarget);
-            config.rewrites = [
-                {
-                    source: rewriteSource,
-                    function: {
-                        functionId,
-                        region: ssrRegion,
-                        pinTag: experiments.isEnabled("pintags"),
-                    },
+            const { packageJson, bootstrapScript, frameworksEntry = framework, dotEnv = {}, rewriteSource, } = await codegenFunctionsDirectory(getProjectPath(), functionsDist, frameworksBuildTarget);
+            const rewrite = {
+                source: rewriteSource || path_1.posix.join(baseUrl, "**"),
+                function: {
+                    functionId,
+                    region: ssrRegion,
+                    pinTag: experiments.isEnabled("pintags"),
                 },
-                ...config.rewrites,
-            ];
+            };
+            if (rewriteSource) {
+                config.rewrites.unshift(rewrite);
+            }
+            else {
+                rewrites.push(rewrite);
+            }
             process.env.__FIREBASE_FRAMEWORKS_ENTRY__ = frameworksEntry;
             packageJson.main = "server.js";
             packageJson.dependencies || (packageJson.dependencies = {});
-            (_f = packageJson.dependencies)["firebase-frameworks"] || (_f["firebase-frameworks"] = constants_2.FIREBASE_FRAMEWORKS_VERSION);
-            (_g = packageJson.dependencies)["firebase-functions"] || (_g["firebase-functions"] = constants_2.FIREBASE_FUNCTIONS_VERSION);
-            (_h = packageJson.dependencies)["firebase-admin"] || (_h["firebase-admin"] = constants_2.FIREBASE_ADMIN_VERSION);
+            (_g = packageJson.dependencies)["firebase-frameworks"] || (_g["firebase-frameworks"] = constants_2.FIREBASE_FRAMEWORKS_VERSION);
+            (_h = packageJson.dependencies)["firebase-functions"] || (_h["firebase-functions"] = constants_2.FIREBASE_FUNCTIONS_VERSION);
+            (_j = packageJson.dependencies)["firebase-admin"] || (_j["firebase-admin"] = constants_2.FIREBASE_ADMIN_VERSION);
             packageJson.engines || (packageJson.engines = {});
             const validEngines = constants_2.VALID_ENGINES.node.filter((it) => it <= constants_2.NODE_VERSION);
             const engine = validEngines[validEngines.length - 1] || constants_2.VALID_ENGINES.node[0];
             if (engine !== constants_2.NODE_VERSION) {
                 (0, utils_2.logWarning)(`This integration expects Node version ${(0, utils_1.conjoinOptions)(constants_2.VALID_ENGINES.node, "or")}. You're running version ${constants_2.NODE_VERSION}, problems may be encountered.`);
             }
-            (_j = packageJson.engines).node || (_j.node = engine.toString());
+            (_k = packageJson.engines).node || (_k.node = engine.toString());
             delete packageJson.scripts;
             delete packageJson.devDependencies;
             const bundledDependencies = packageJson.bundledDependencies || {};
             if (Object.keys(bundledDependencies).length) {
                 (0, utils_2.logWarning)("Bundled dependencies aren't supported in Cloud Functions, converting to dependencies.");
                 for (const [dep, version] of Object.entries(bundledDependencies)) {
-                    (_k = packageJson.dependencies)[dep] || (_k[dep] = version);
+                    (_l = packageJson.dependencies)[dep] || (_l[dep] = version);
                 }
                 delete packageJson.bundledDependencies;
             }
@@ -376,13 +383,18 @@ ${firebaseDefaults ? `__FIREBASE_DEFAULTS__=${JSON.stringify(firebaseDefaults)}\
                 await (0, promises_1.rm)(functionsDist, { recursive: true });
             }
         }
+        const ourConfigShouldComeFirst = !["", "/"].includes(baseUrl);
+        const operation = ourConfigShouldComeFirst ? "unshift" : "push";
+        config.rewrites[operation](...rewrites);
+        config.redirects[operation](...redirects);
+        config.headers[operation](...headers);
         if (firebaseDefaults) {
             const encodedDefaults = Buffer.from(JSON.stringify(firebaseDefaults)).toString("base64url");
             const expires = new Date(new Date().getTime() + 60000000000);
             const sameSite = "Strict";
             const path = `/`;
             config.headers.push({
-                source: "**/*.[jt]s",
+                source: path_1.posix.join(baseUrl, "**", "*.[jt]s"),
                 headers: [
                     {
                         key: "Set-Cookie",
@@ -392,10 +404,7 @@ ${firebaseDefaults ? `__FIREBASE_DEFAULTS__=${JSON.stringify(firebaseDefaults)}\
             });
         }
     }
-    if (process.env.DEBUG) {
-        console.log("Effective firebase.json:");
-        console.log(JSON.stringify(configs, undefined, 2));
-    }
+    logger_1.logger.debug("[web frameworks] effective firebase.json: ", JSON.stringify({ hosting: configs, functions: options.config.get("functions") }, undefined, 2));
     BUILD_MEMO.clear();
     delete process.env.__FIREBASE_DEFAULTS__;
     delete process.env.__FIREBASE_FRAMEWORKS_ENTRY__;

package/lib/frameworks/next/index.js

@@ -22,6 +22,7 @@ const utils_2 = require("./utils");
 const constants_1 = require("../constants");
 const constants_2 = require("./constants");
 const api_1 = require("../../hosting/api");
+const logger_1 = require("../../logger");
 const DEFAULT_BUILD_SCRIPT = ["next build"];
 const PUBLIC_DIR = "public";
 exports.name = "Next.js";
@@ -58,7 +59,7 @@ async function build(dir) {
         throw e;
     });
     const reasonsForBackend = new Set();
-    const { distDir, trailingSlash, basePath } = await getConfig(dir);
+    const { distDir, trailingSlash, basePath: baseUrl } = await getConfig(dir);
     if (await (0, utils_2.isUsingMiddleware)((0, path_1.join)(dir, distDir), false)) {
         reasonsForBackend.add("middleware");
     }
@@ -103,7 +104,7 @@ async function build(dir) {
         (0, utils_1.readJSON)((0, path_1.join)(dir, distDir, constants_2.APP_PATH_ROUTES_MANIFEST)).catch(() => undefined),
     ]);
     if (appPathRoutesManifest) {
-        const headersFromMetaFiles = await (0, utils_2.getHeadersFromMetaFiles)(dir, distDir, basePath, appPathRoutesManifest);
+        const headersFromMetaFiles = await (0, utils_2.getHeadersFromMetaFiles)(dir, distDir, baseUrl, appPathRoutesManifest);
         headers.push(...headersFromMetaFiles);
         if (appPathsManifest) {
             const unrenderedServerComponents = (0, utils_2.getNonStaticServerComponents)(appPathsManifest, appPathRoutesManifest, prerenderedRoutes, dynamicRoutes);
@@ -144,15 +145,17 @@ async function build(dir) {
     }));
     const wantsBackend = reasonsForBackend.size > 0;
     if (wantsBackend) {
-        const numberOfReasonsToList = process.env.DEBUG ? Infinity : DEFAULT_NUMBER_OF_REASONS_TO_LIST;
-        console.log("Building a Cloud Function to run this application. This is needed due to:");
-        for (const reason of Array.from(reasonsForBackend).slice(0, numberOfReasonsToList)) {
-            console.log(` • ${reason}`);
+        logger_1.logger.info("Building a Cloud Function to run this application. This is needed due to:");
+        for (const reason of Array.from(reasonsForBackend).slice(0, DEFAULT_NUMBER_OF_REASONS_TO_LIST)) {
+            logger_1.logger.info(` • ${reason}`);
         }
-        if (reasonsForBackend.size > numberOfReasonsToList) {
-            console.log(` • and ${reasonsForBackend.size - numberOfReasonsToList} other reasons, use --debug to see more`);
+        for (const reason of Array.from(reasonsForBackend).slice(DEFAULT_NUMBER_OF_REASONS_TO_LIST)) {
+            logger_1.logger.debug(` • ${reason}`);
         }
-        console.log("");
+        if (reasonsForBackend.size > DEFAULT_NUMBER_OF_REASONS_TO_LIST && !process.env.DEBUG) {
+            logger_1.logger.info(` • and ${reasonsForBackend.size - DEFAULT_NUMBER_OF_REASONS_TO_LIST} other reasons, use --debug to see more`);
+        }
+        logger_1.logger.info("");
     }
     const i18n = !!nextjsI18n;
     return {
@@ -162,6 +165,7 @@ async function build(dir) {
         rewrites,
         trailingSlash,
         i18n,
+        baseUrl,
     };
 }
 exports.build = build;
@@ -226,13 +230,11 @@ async function ɵcodegenPublicDirectory(sourceDir, destDir, _, context) {
     await Promise.all(Object.entries(routesToCopy).map(async ([path, route]) => {
         var _a, _b;
         if (route.initialRevalidateSeconds) {
-            if (process.env.DEBUG)
-                console.log(`skipping ${path} due to revalidate`);
+            logger_1.logger.debug(`skipping ${path} due to revalidate`);
             return;
         }
         if (pathsUsingsFeaturesNotSupportedByHosting.some((it) => path.match(it))) {
-            if (process.env.DEBUG)
-                console.log(`skipping ${path} due to it matching an unsupported rewrite/redirect/header or middlware`);
+            logger_1.logger.debug(`skipping ${path} due to it matching an unsupported rewrite/redirect/header or middlware`);
             return;
         }
         const appPathRoute = route.srcRoute && ((_a = appPathRoutesEntries.find(([, it]) => it === route.srcRoute)) === null || _a === void 0 ? void 0 : _a[0]);
@@ -245,8 +247,7 @@ async function ɵcodegenPublicDirectory(sourceDir, destDir, _, context) {
             !matchingI18nDomain.locales ||
             matchingI18nDomain.locales.includes(locale);
         if (!includeOnThisDomain) {
-            if (process.env.DEBUG)
-                console.log(`skipping ${path} since it is for a locale not deployed on this domain`);
+            logger_1.logger.debug(`skipping ${path} since it is for a locale not deployed on this domain`);
             return;
         }
         const sourcePartsOrIndex = sourceParts.length > 0 ? sourceParts : ["index"];
@@ -293,7 +294,7 @@ async function ɵcodegenPublicDirectory(sourceDir, destDir, _, context) {
 exports.ɵcodegenPublicDirectory = ɵcodegenPublicDirectory;
 const BUNDLE_NEXT_CONFIG_TIMEOUT = 10000;
 async function ɵcodegenFunctionsDirectory(sourceDir, destDir) {
-    const { distDir, basePath } = await getConfig(sourceDir);
+    const { distDir } = await getConfig(sourceDir);
     const packageJson = await (0, utils_1.readJSON)((0, path_1.join)(sourceDir, "package.json"));
     if ((0, fs_1.existsSync)((0, path_1.join)(sourceDir, "next.config.js"))) {
         try {
@@ -345,7 +346,7 @@ async function ɵcodegenFunctionsDirectory(sourceDir, destDir) {
     }
     await (0, fs_extra_1.mkdirp)((0, path_1.join)(destDir, distDir));
     await (0, fs_extra_1.copy)((0, path_1.join)(sourceDir, distDir), (0, path_1.join)(destDir, distDir));
-    return { packageJson, frameworksEntry: "next.js", basePath };
+    return { packageJson, frameworksEntry: "next.js" };
 }
 exports.ɵcodegenFunctionsDirectory = ɵcodegenFunctionsDirectory;
 async function getDevModeHandle(dir, _, hostingEmulatorInfo) {

package/lib/frameworks/nuxt/index.js

@@ -30,7 +30,7 @@ exports.discover = discover;
 async function build(cwd) {
     await (0, utils_1.warnIfCustomBuildScript)(cwd, exports.name, DEFAULT_BUILD_SCRIPT);
     const cli = (0, utils_1.getNodeModuleBin)("nuxt", cwd);
-    const { ssr: wantsBackend, app: { baseURL }, } = await getConfig(cwd);
+    const { ssr: wantsBackend, app: { baseURL: baseUrl }, } = await getConfig(cwd);
     const command = wantsBackend ? ["build"] : ["generate"];
     const build = (0, cross_spawn_1.sync)(cli, command, {
         cwd,
@@ -43,11 +43,11 @@ async function build(cwd) {
         ? []
         : [
             {
-                source: path_1.posix.join(baseURL, "**"),
-                destination: path_1.posix.join(baseURL, "200.html"),
+                source: path_1.posix.join(baseUrl, "**"),
+                destination: path_1.posix.join(baseUrl, "200.html"),
             },
         ];
-    return { wantsBackend, rewrites };
+    return { wantsBackend, rewrites, baseUrl };
 }
 exports.build = build;
 async function ɵcodegenPublicDirectory(root, dest) {
@@ -64,12 +64,11 @@ async function ɵcodegenFunctionsDirectory(sourceDir) {
     const packageJson = JSON.parse(packageJsonBuffer.toString());
     packageJson.dependencies || (packageJson.dependencies = {});
     packageJson.dependencies["nitro-output"] = `file:${serverDir}`;
-    const { app: { baseURL: baseUrl }, } = await getConfig(sourceDir);
-    return { packageJson, frameworksEntry: "nitro", baseUrl };
+    return { packageJson, frameworksEntry: "nitro" };
 }
 exports.ɵcodegenFunctionsDirectory = ɵcodegenFunctionsDirectory;
 async function getDevModeHandle(cwd) {
-    const host = new Promise((resolve) => {
+    const host = new Promise((resolve, reject) => {
         const cli = (0, utils_1.getNodeModuleBin)("nuxt", cwd);
         const serve = (0, cross_spawn_1.spawn)(cli, ["dev"], { cwd: cwd });
         serve.stdout.on("data", (data) => {
@@ -81,6 +80,7 @@ async function getDevModeHandle(cwd) {
         serve.stderr.on("data", (data) => {
             process.stderr.write(data);
         });
+        serve.on("exit", reject);
     });
     return (0, utils_1.simpleProxy)(await host);
 }

package/lib/frameworks/nuxt2/index.js

@@ -60,7 +60,7 @@ async function ɵcodegenFunctionsDirectory(rootDir, destDir) {
 }
 exports.ɵcodegenFunctionsDirectory = ɵcodegenFunctionsDirectory;
 async function getDevModeHandle(cwd) {
-    const host = new Promise((resolve) => {
+    const host = new Promise((resolve, reject) => {
         const cli = (0, utils_1.getNodeModuleBin)("nuxt", cwd);
         const serve = (0, cross_spawn_1.spawn)(cli, ["dev"], { cwd });
         serve.stdout.on("data", (data) => {
@@ -72,6 +72,7 @@ async function getDevModeHandle(cwd) {
         serve.stderr.on("data", (data) => {
             process.stderr.write(data);
         });
+        serve.on("exit", reject);
     });
     return (0, utils_3.simpleProxy)(await host);
 }

package/lib/frameworks/utils.js

@@ -32,16 +32,31 @@ async function warnIfCustomBuildScript(dir, framework, defaultBuildScripts) {
     }
 }
 exports.warnIfCustomBuildScript = warnIfCustomBuildScript;
+function proxyResponse(original, next) {
+    return (response) => {
+        const { statusCode, statusMessage } = response;
+        if (!statusCode) {
+            original.end();
+            return;
+        }
+        if (statusCode === 404) {
+            return next();
+        }
+        const headers = "getHeaders" in response ? response.getHeaders() : response.headers;
+        original.writeHead(statusCode, statusMessage, headers);
+        response.pipe(original);
+    };
+}
 function simpleProxy(hostOrRequestHandler) {
     const agent = new http_1.Agent({ keepAlive: true });
+    const firebaseDefaultsJSON = process.env.__FIREBASE_DEFAULTS__;
+    const authTokenSyncURL = firebaseDefaultsJSON && JSON.parse(firebaseDefaultsJSON)._authTokenSyncURL;
     return async (originalReq, originalRes, next) => {
         const { method, headers, url: path } = originalReq;
         if (!method || !path) {
             originalRes.end();
             return;
         }
-        const firebaseDefaultsJSON = process.env.__FIREBASE_DEFAULTS__;
-        const authTokenSyncURL = firebaseDefaultsJSON && JSON.parse(firebaseDefaultsJSON)._authTokenSyncURL;
         if (path === authTokenSyncURL) {
             return next();
         }
@@ -61,8 +76,13 @@ function simpleProxy(hostOrRequestHandler) {
             };
             const req = (0, http_1.request)(opts, (response) => {
                 const { statusCode, statusMessage, headers } = response;
-                originalRes.writeHead(statusCode, statusMessage, headers);
-                response.pipe(originalRes);
+                if (statusCode === 404) {
+                    next();
+                }
+                else {
+                    originalRes.writeHead(statusCode, statusMessage, headers);
+                    response.pipe(originalRes);
+                }
             });
             originalReq.pipe(req);
             req.on("error", (err) => {
@@ -71,7 +91,9 @@ function simpleProxy(hostOrRequestHandler) {
             });
         }
         else {
-            await hostOrRequestHandler(originalReq, originalRes);
+            await Promise.resolve(hostOrRequestHandler(originalReq, originalRes, next));
+            const proxiedRes = new http_1.ServerResponse(originalReq);
+            proxyResponse(originalRes, next)(proxiedRes);
         }
     };
 }
@@ -183,25 +205,18 @@ function getFrameworksBuildTarget(purpose, validOptions) {
         }
         return frameworksBuild;
     }
-    else if (purpose === "deploy") {
-        return "production";
-    }
-    else if (process.env.NODE_ENV) {
-        switch (process.env.NODE_ENV) {
-            case "development":
-                return "development";
-            case "production":
-            case "test":
-                return "production";
-            default:
-                throw new error_1.FirebaseError(`We cannot infer your build target from a non-standard NODE_ENV. Please set the FIREBASE_FRAMEWORKS_BUILD_TARGET environment variable. Valid values are: ${validOptions.join(", ")}`);
-        }
-    }
-    else if (purpose === "test") {
+    else if (["test", "deploy"].includes(purpose)) {
         return "production";
     }
-    else {
-        return "development";
+    switch (process.env.NODE_ENV) {
+        case undefined:
+        case "development":
+            return "development";
+        case "production":
+        case "test":
+            return "production";
+        default:
+            throw new error_1.FirebaseError(`We cannot infer your build target from a non-standard NODE_ENV. Please set the FIREBASE_FRAMEWORKS_BUILD_TARGET environment variable. Valid values are: ${validOptions.join(", ")}`);
     }
 }
 exports.getFrameworksBuildTarget = getFrameworksBuildTarget;

package/lib/frameworks/vite/index.js

@@ -72,7 +72,7 @@ async function ɵcodegenPublicDirectory(root, dest) {
 }
 exports.ɵcodegenPublicDirectory = ɵcodegenPublicDirectory;
 async function getDevModeHandle(dir) {
-    const host = new Promise((resolve) => {
+    const host = new Promise((resolve, reject) => {
         const cli = (0, utils_1.getNodeModuleBin)("vite", dir);
         const serve = (0, cross_spawn_1.spawn)(cli, [], { cwd: dir });
         serve.stdout.on("data", (data) => {
@@ -84,6 +84,7 @@ async function getDevModeHandle(dir) {
         serve.stderr.on("data", (data) => {
             process.stderr.write(data);
         });
+        serve.on("exit", reject);
     });
     return (0, utils_1.simpleProxy)(await host);
 }

package/lib/serve/index.js

@@ -19,7 +19,7 @@ async function serve(options) {
     options.port = parseInt(options.port, 10);
     if (targetNames.includes("hosting") && config.extract(options).some((it) => it.source)) {
         experiments.assertEnabled("webframeworks", "emulate a web framework");
-        await (0, frameworks_1.prepareFrameworks)(targetNames, options, options);
+        await (0, frameworks_1.prepareFrameworks)("emulate", targetNames, undefined, options);
     }
     const isDemoProject = constants_1.Constants.isDemoProject((0, projectUtils_1.getProjectId)(options) || "");
     targetNames.forEach((targetName) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "firebase-tools",
-  "version": "12.2.1",
+  "version": "12.3.0",
   "description": "Command-Line Interface for Firebase",
   "main": "./lib/index.js",
   "bin": {

package/templates/extensions/extension.yaml

@@ -1,7 +1,9 @@
 # Learn detailed information about the fields of an extension.yaml file in the docs:
 # https://firebase.google.com/docs/extensions/reference/extension-yaml
 
-name: greet-the-world  # Identifier for your extension
+# Identifier for your extension
+# TODO: Replace this with an descriptive name for your extension.
+name: greet-the-world  
 version: 0.0.1  # Follow semver versioning
 specVersion: v1beta  # Version of the Firebase Extensions specification
 
@@ -14,12 +16,13 @@ description: >-
 
 license: Apache-2.0  # https://spdx.org/licenses/
 
-# Public URL for the source code of your extension
-sourceUrl: https://github.com/firebase/firebase-tools/tree/master/templates/extensions
+# Public URL for the source code of your extension.
+# TODO:  Replace this with your GitHub repo.
+sourceUrl: https://github.com/ORG_OR_USER/REPO_NAME
 
 # Specify whether a paid-tier billing plan is required to use your extension.
 # Learn more in the docs: https://firebase.google.com/docs/extensions/reference/extension-yaml#billing-required-field
-billingRequired: false
+billingRequired: true
 
 # In an `apis` field, list any Google APIs (like Cloud Translation, BigQuery, etc.)
 # required for your extension to operate.
@@ -39,8 +42,6 @@ resources:
     description: >-
       HTTP request-triggered function that responds with a specified greeting message
     properties:
-      # LOCATION is a user-configured parameter value specified by the user during installation.
-      location: ${LOCATION}
       # httpsTrigger is used for an HTTP triggered function.
       httpsTrigger: {}
       runtime: "nodejs16"
@@ -58,54 +59,3 @@ params:
     default: Hello
     required: true
     immutable: false
-
-  - param: LOCATION
-    label: Cloud Functions location
-    description: >-
-      Where do you want to deploy the functions created for this extension?
-      For help selecting a location, refer to the [location selection
-      guide](https://firebase.google.com/docs/functions/locations).
-    type: select
-    options:
-      - label: Iowa (us-central1)
-        value: us-central1
-      - label: South Carolina (us-east1)
-        value: us-east1
-      - label: Northern Virginia (us-east4)
-        value: us-east4
-      - label: Los Angeles (us-west2)
-        value: us-west2
-      - label: Salt Lake City (us-west3)
-        value: us-west3
-      - label: Las Vegas (us-west4)
-        value: us-west4
-      - label: Warsaw (europe-central2)
-        value: europe-central2
-      - label: Belgium (europe-west1)
-        value: europe-west1
-      - label: London (europe-west2)
-        value: europe-west2
-      - label: Frankfurt (europe-west3)
-        value: europe-west3
-      - label: Zurich (europe-west6)
-        value: europe-west6
-      - label: Hong Kong (asia-east2)
-        value: asia-east2
-      - label: Tokyo (asia-northeast1)
-        value: asia-northeast1
-      - label: Osaka (asia-northeast2)
-        value: asia-northeast2
-      - label: Seoul (asia-northeast3)
-        value: asia-northeast3
-      - label: Mumbai (asia-south1)
-        value: asia-south1
-      - label: Jakarta (asia-southeast2)
-        value: asia-southeast2
-      - label: Montreal (northamerica-northeast1)
-        value: northamerica-northeast1
-      - label: Sao Paulo (southamerica-east1)
-        value: southamerica-east1
-      - label: Sydney (australia-southeast1)
-        value: australia-southeast1
-    required: true
-    immutable: true

package/templates/extensions/javascript/index.js

@@ -5,7 +5,7 @@
  * Reference PARAMETERS in your functions code with:
  * `process.env.<parameter-name>`
  * Learn more about building extensions in the docs:
- * https://firebase.google.com/docs/extensions/alpha/overview
+ * https://firebase.google.com/docs/extensions/publishers
  */
 
 const functions = require("firebase-functions");