firebase-tools 12.0.1 → 12.2.0

package/lib/deploy/functions/functionsDeployHelper.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.isEndpointFiltered = exports.isCodebaseFiltered = exports.groupEndpointsByCodebase = exports.targetCodebases = exports.getFunctionLabel = exports.getEndpointFilters = exports.parseFunctionSelector = exports.endpointMatchesFilter = exports.endpointMatchesAnyFilter = void 0;
+exports.isEndpointFiltered = exports.isCodebaseFiltered = exports.groupEndpointsByCodebase = exports.targetCodebases = exports.getFunctionLabel = exports.getHumanFriendlyPlatformName = exports.getEndpointFilters = exports.parseFunctionSelector = exports.endpointMatchesFilter = exports.endpointMatchesAnyFilter = void 0;
 const backend = require("./backend");
 const projectConfig_1 = require("../../functions/projectConfig");
 function endpointMatchesAnyFilter(endpoint, filters) {
@@ -67,6 +67,13 @@ function getEndpointFilters(options) {
     return filters;
 }
 exports.getEndpointFilters = getEndpointFilters;
+function getHumanFriendlyPlatformName(platform) {
+    if (platform === "gcfv1") {
+        return "1st Gen";
+    }
+    return "2nd Gen";
+}
+exports.getHumanFriendlyPlatformName = getHumanFriendlyPlatformName;
 function getFunctionLabel(fn) {
     let id = `${fn.id}(${fn.region})`;
     if (fn.codebase && fn.codebase !== projectConfig_1.DEFAULT_CODEBASE) {

package/lib/deploy/functions/release/fabricator.js

@@ -25,6 +25,7 @@ const utils = require("../../../utils");
 const services = require("../services");
 const v1_1 = require("../../../functions/events/v1");
 const checkIam_1 = require("../checkIam");
+const functionsDeployHelper_1 = require("../functionsDeployHelper");
 const gcfV1PollerOptions = {
     apiOrigin: api_1.functionsOrigin,
     apiVersion: gcf.API_VERSION,
@@ -536,8 +537,9 @@ class Fabricator {
     }
     logOpStart(op, endpoint) {
         const runtime = (0, runtimes_1.getHumanFriendlyRuntimeName)(endpoint.runtime);
+        const platform = (0, functionsDeployHelper_1.getHumanFriendlyPlatformName)(endpoint.platform);
         const label = helper.getFunctionLabel(endpoint);
-        utils.logLabeledBullet("functions", `${op} ${runtime} function ${clc.bold(label)}...`);
+        utils.logLabeledBullet("functions", `${op} ${runtime} (${platform}) function ${clc.bold(label)}...`);
     }
     logOpSuccess(op, endpoint) {
         utils.logSuccess(this.getLogSuccessMessage(op, endpoint));

package/lib/deploy/functions/runtimes/index.js

@@ -11,6 +11,7 @@ const RUNTIMES = [
     "nodejs14",
     "nodejs16",
     "nodejs18",
+    "nodejs20",
     "python310",
     "python311",
 ];
@@ -32,6 +33,7 @@ const MESSAGE_FRIENDLY_RUNTIMES = {
     nodejs14: "Node.js 14",
     nodejs16: "Node.js 16",
     nodejs18: "Node.js 18",
+    nodejs20: "Node.js 20",
     python310: "Python 3.10",
     python311: "Python 3.11",
 };

package/lib/deploy/functions/runtimes/node/parseRuntimeAndValidateSDK.js

@@ -15,6 +15,7 @@ const ENGINE_RUNTIMES = {
     14: "nodejs14",
     16: "nodejs16",
     18: "nodejs18",
+    20: "nodejs20",
 };
 const ENGINE_RUNTIMES_NAMES = Object.values(ENGINE_RUNTIMES);
 exports.RUNTIME_NOT_SET = "`runtime` field is required but was not found in firebase.json.\n" +

package/lib/deploy/functions/runtimes/python/index.js

@@ -107,7 +107,7 @@ class Delegate {
         var _a, _b;
         const modulesDir = await this.modulesDir();
         const envWithAdminPort = Object.assign(Object.assign({}, envs), { ADMIN_PORT: port.toString() });
-        const args = [this.bin, path.join(modulesDir, "private", "serving.py")];
+        const args = [this.bin, `"${path.join(modulesDir, "private", "serving.py")}"`];
         const stdout = [];
         const stderr = [];
         logger_1.logger.debug(`Running admin server with args: ${JSON.stringify(args)} and env: ${JSON.stringify(envWithAdminPort)} in ${this.sourceDir}`);

package/lib/emulator/downloadableEmulators.js

@@ -18,9 +18,9 @@ const EMULATOR_INSTANCE_KILL_TIMEOUT = 4000;
 const CACHE_DIR = process.env.FIREBASE_EMULATORS_PATH || path.join(os.homedir(), ".cache", "firebase", "emulators");
 const EMULATOR_UPDATE_DETAILS = {
     database: {
-        version: "4.11.0",
-        expectedSize: 34318940,
-        expectedChecksum: "311609538bd65666eb724ef47c2e6466",
+        version: "4.11.2",
+        expectedSize: 34495935,
+        expectedChecksum: "2fd771101c0e1f7898c04c9204f2ce63",
     },
     firestore: {
         version: "1.17.4",

package/lib/emulator/functionsEmulator.js

@@ -332,7 +332,12 @@ class FunctionsEmulator {
             this.logger.logLabeled("ERROR", "functions", `Failed to load function definition from source: ${e}`);
             return;
         }
-        this.workerPools[emulatableBackend.codebase].refresh();
+        if (this.debugMode) {
+            this.workerPools[emulatableBackend.codebase].exit();
+        }
+        else {
+            this.workerPools[emulatableBackend.codebase].refresh();
+        }
         this.blockingFunctionsConfig = {};
         const toSetup = triggerDefinitions.filter((definition) => {
             if (force) {

package/lib/frameworks/angular/index.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.ɵcodegenFunctionsDirectory = exports.ɵcodegenPublicDirectory = exports.getDevModeHandle = exports.build = exports.init = exports.discover = exports.docsUrl = exports.type = exports.support = exports.name = void 0;
+exports.ɵcodegenFunctionsDirectory = exports.shouldUseDevModeHandle = exports.getValidBuildTargets = exports.ɵcodegenPublicDirectory = exports.getDevModeHandle = exports.build = exports.init = exports.discover = exports.docsUrl = exports.type = exports.support = exports.name = void 0;
 const path_1 = require("path");
 const child_process_1 = require("child_process");
 const cross_spawn_1 = require("cross-spawn");
@@ -10,6 +10,7 @@ const prompt_1 = require("../../prompt");
 const utils_1 = require("../utils");
 const utils_2 = require("./utils");
 const constants_1 = require("../constants");
+const error_1 = require("../../error");
 exports.name = "Angular";
 exports.support = "preview";
 exports.type = 3;
@@ -42,26 +43,36 @@ async function init(setup, config) {
     }
 }
 exports.init = init;
-async function build(dir) {
-    const { targets, serverTarget, serveOptimizedImages, locales } = await (0, utils_2.getBuildConfig)(dir);
+async function build(dir, configuration) {
+    const { targets, serverTarget, serveOptimizedImages, locales, baseHref } = await (0, utils_2.getBuildConfig)(dir, configuration);
     await (0, utils_1.warnIfCustomBuildScript)(dir, exports.name, DEFAULT_BUILD_SCRIPT);
     for (const target of targets) {
         const cli = (0, utils_1.getNodeModuleBin)("ng", dir);
-        (0, cross_spawn_1.sync)(cli, ["run", target], {
+        const result = (0, cross_spawn_1.sync)(cli, ["run", target], {
             cwd: dir,
             stdio: "inherit",
         });
+        if (result.status !== 0)
+            throw new error_1.FirebaseError(`Unable to build ${target}`);
     }
     const wantsBackend = !!serverTarget || serveOptimizedImages;
+    const rewrites = serverTarget
+        ? []
+        : [
+            {
+                source: path_1.posix.join(baseHref, "**"),
+                destination: path_1.posix.join(baseHref, "index.html"),
+            },
+        ];
     const i18n = !!locales;
-    return { wantsBackend, i18n };
+    return { wantsBackend, i18n, rewrites };
 }
 exports.build = build;
-async function getDevModeHandle(dir) {
+async function getDevModeHandle(dir, configuration) {
     const { targetStringFromTarget } = (0, utils_1.relativeRequire)(dir, "@angular-devkit/architect");
-    const { serveTarget } = await (0, utils_2.getContext)(dir);
+    const { serveTarget } = await (0, utils_2.getContext)(dir, configuration);
     if (!serveTarget)
-        return;
+        throw new Error("Could not find the serveTarget");
     const host = new Promise((resolve) => {
         const cli = (0, utils_1.getNodeModuleBin)("ng", dir);
         const serve = (0, cross_spawn_1.spawn)(cli, ["run", targetStringFromTarget(serveTarget), "--host", "localhost"], {
@@ -80,8 +91,8 @@ async function getDevModeHandle(dir) {
     return (0, utils_1.simpleProxy)(await host);
 }
 exports.getDevModeHandle = getDevModeHandle;
-async function ɵcodegenPublicDirectory(sourceDir, destDir) {
-    const { outputPath, baseHref, defaultLocale, locales } = await (0, utils_2.getBrowserConfig)(sourceDir);
+async function ɵcodegenPublicDirectory(sourceDir, destDir, configuration) {
+    const { outputPath, baseHref, defaultLocale, locales } = await (0, utils_2.getBrowserConfig)(sourceDir, configuration);
     await (0, promises_1.mkdir)((0, path_1.join)(destDir, baseHref), { recursive: true });
     if (locales) {
         await Promise.all([
@@ -99,11 +110,33 @@ async function ɵcodegenPublicDirectory(sourceDir, destDir) {
     }
 }
 exports.ɵcodegenPublicDirectory = ɵcodegenPublicDirectory;
-async function ɵcodegenFunctionsDirectory(sourceDir, destDir) {
+async function getValidBuildTargets(purpose, dir) {
+    const validTargetNames = new Set(["development", "production"]);
+    try {
+        const { workspaceProject, browserTarget, serverTarget, serveTarget } = await (0, utils_2.getContext)(dir);
+        const { target } = ((purpose === "serve" && serveTarget) || serverTarget || browserTarget);
+        const workspaceTarget = workspaceProject.targets.get(target);
+        Object.keys(workspaceTarget.configurations || {}).forEach((it) => validTargetNames.add(it));
+    }
+    catch (e) {
+    }
+    const allTargets = await (0, utils_2.getAllTargets)(purpose, dir);
+    return [...validTargetNames, ...allTargets];
+}
+exports.getValidBuildTargets = getValidBuildTargets;
+async function shouldUseDevModeHandle(targetOrConfiguration, dir) {
+    const { serveTarget } = await (0, utils_2.getContext)(dir, targetOrConfiguration);
+    if (!serveTarget)
+        return false;
+    return serveTarget.configuration !== "production";
+}
+exports.shouldUseDevModeHandle = shouldUseDevModeHandle;
+async function ɵcodegenFunctionsDirectory(sourceDir, destDir, configuration) {
     var _a;
     var _b;
-    const { packageJson, serverOutputPath, browserOutputPath, defaultLocale, serverLocales, browserLocales, bundleDependencies, externalDependencies, baseHref: baseUrl, serveOptimizedImages, } = await (0, utils_2.getServerConfig)(sourceDir);
+    const { packageJson, serverOutputPath, browserOutputPath, defaultLocale, serverLocales, browserLocales, bundleDependencies, externalDependencies, baseHref: baseUrl, serveOptimizedImages, } = await (0, utils_2.getServerConfig)(sourceDir, configuration);
     const dotEnv = { __NG_BROWSER_OUTPUT_PATH__: browserOutputPath };
+    let rewriteSource = undefined;
     await Promise.all([
         serverOutputPath
             ? (0, promises_1.mkdir)((0, path_1.join)(destDir, serverOutputPath), { recursive: true }).then(() => (0, fs_extra_1.copy)((0, path_1.join)(sourceDir, serverOutputPath), (0, path_1.join)(destDir, serverOutputPath)))
@@ -154,7 +187,8 @@ exports.handle = function(req,res) {
     }
     else {
         bootstrapScript = `exports.handle = (res, req) => req.sendStatus(404);\n`;
+        rewriteSource = path_1.posix.join(baseUrl, "__image__");
     }
-    return { bootstrapScript, packageJson, baseUrl, dotEnv };
+    return { bootstrapScript, packageJson, baseUrl, dotEnv, rewriteSource };
 }
 exports.ɵcodegenFunctionsDirectory = ɵcodegenFunctionsDirectory;

package/lib/frameworks/angular/utils.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getBuildConfig = exports.getServerConfig = exports.getBrowserConfig = exports.getContext = void 0;
+exports.getBuildConfig = exports.getServerConfig = exports.getBrowserConfig = exports.getContext = exports.getAllTargets = void 0;
 const utils_1 = require("../utils");
 const error_1 = require("../../error");
 const path_1 = require("path");
@@ -49,7 +49,46 @@ async function localesForTarget(dir, architectHost, target, workspaceProject) {
     (0, utils_1.validateLocales)(locales);
     return { locales, defaultLocale };
 }
-async function getContext(dir) {
+const DEV_SERVER_TARGETS = [
+    "@angular-devkit/build-angular:dev-server",
+    "@nguniversal/builders:ssr-dev-server",
+];
+function getValidBuilders(purpose) {
+    return [
+        "@angular/fire:deploy",
+        "@angular-devkit/build-angular:browser",
+        "@nguniversal/builders:prerender",
+        ...(purpose === "deploy" ? [] : DEV_SERVER_TARGETS),
+    ];
+}
+async function getAllTargets(purpose, dir) {
+    const validBuilders = getValidBuilders(purpose);
+    const { NodeJsAsyncHost } = (0, utils_1.relativeRequire)(dir, "@angular-devkit/core/node");
+    const { workspaces } = (0, utils_1.relativeRequire)(dir, "@angular-devkit/core");
+    const { targetStringFromTarget } = (0, utils_1.relativeRequire)(dir, "@angular-devkit/architect");
+    const host = workspaces.createWorkspaceHost(new NodeJsAsyncHost());
+    const { workspace } = await workspaces.readWorkspace(dir, host);
+    const targets = [];
+    workspace.projects.forEach((projectDefinition, project) => {
+        if (projectDefinition.extensions.projectType !== "application")
+            return;
+        projectDefinition.targets.forEach((targetDefinition, target) => {
+            if (!validBuilders.includes(targetDefinition.builder))
+                return;
+            const configurations = Object.keys(targetDefinition.configurations || {});
+            if (!configurations.includes("production"))
+                configurations.push("production");
+            if (!configurations.includes("development"))
+                configurations.push("development");
+            configurations.forEach((configuration) => {
+                targets.push(targetStringFromTarget({ project, target, configuration }));
+            });
+        });
+    });
+    return targets;
+}
+exports.getAllTargets = getAllTargets;
+async function getContext(dir, targetOrConfiguration) {
     const { NodeJsAsyncHost } = (0, utils_1.relativeRequire)(dir, "@angular-devkit/core/node");
     const { workspaces } = (0, utils_1.relativeRequire)(dir, "@angular-devkit/core");
     const { WorkspaceNodeModulesArchitectHost } = (0, utils_1.relativeRequire)(dir, "@angular-devkit/architect/node");
@@ -59,12 +98,26 @@ async function getContext(dir) {
     const { workspace } = await workspaces.readWorkspace(dir, host);
     const architectHost = new WorkspaceNodeModulesArchitectHost(workspace, dir);
     const architect = new Architect(architectHost);
-    let project = globalThis.NG_DEPLOY_PROJECT;
+    let overrideTarget;
+    let project;
     let browserTarget;
     let serverTarget;
     let prerenderTarget;
     let serveTarget;
     let serveOptimizedImages = false;
+    let deployTargetName;
+    let configuration = undefined;
+    if (targetOrConfiguration) {
+        try {
+            overrideTarget = targetFromTargetString(targetOrConfiguration);
+            configuration = overrideTarget.configuration;
+            project = overrideTarget.project;
+        }
+        catch (e) {
+            deployTargetName = "deploy";
+            configuration = targetOrConfiguration;
+        }
+    }
     if (!project) {
         const angularJson = parse(await host.readFile((0, path_1.join)(dir, "angular.json")));
         project = angularJson.defaultProject;
@@ -79,11 +132,25 @@ async function getContext(dir) {
             project = apps[0];
     }
     if (!project)
-        throw new error_1.FirebaseError("Unable to determine the application to deploy, you should use `ng deploy` via @angular/fire.");
+        throw new error_1.FirebaseError("Unable to determine the application to deploy, specify a target via the FIREBASE_FRAMEWORKS_BUILD_TARGET environment variable");
     const workspaceProject = workspace.projects.get(project);
     if (!workspaceProject)
         throw new error_1.FirebaseError(`No project ${project} found.`);
-    const deployTargetDefinition = workspaceProject.targets.get("deploy");
+    if (overrideTarget) {
+        const target = workspaceProject.targets.get(overrideTarget.target);
+        const builder = target.builder;
+        if (builder === "@angular/fire:deploy")
+            deployTargetName = overrideTarget.target;
+        if (builder === "@angular-devkit/build-angular:browser")
+            browserTarget = overrideTarget;
+        if (builder === "@nguniversal/builders:prerender")
+            prerenderTarget = overrideTarget;
+        if (typeof builder === "string" && DEV_SERVER_TARGETS.includes(builder))
+            serveTarget = overrideTarget;
+    }
+    const deployTargetDefinition = deployTargetName
+        ? workspaceProject.targets.get(deployTargetName)
+        : undefined;
     if ((deployTargetDefinition === null || deployTargetDefinition === void 0 ? void 0 : deployTargetDefinition.builder) === "@angular/fire:deploy") {
         const options = deployTargetDefinition.options;
         if (typeof (options === null || options === void 0 ? void 0 : options.prerenderTarget) === "string")
@@ -107,76 +174,57 @@ async function getContext(dir) {
                 console.warn("Treating the application as fully rendered. Add a serverTarget to your deploy target in angular.json to utilize server-side rendering.");
         }
     }
-    else if (workspaceProject.targets.has("prerender")) {
-        const target = workspaceProject.targets.get("prerender");
-        const configurations = Object.keys(target.configurations);
-        const configuration = configurations.includes("production")
-            ? "production"
-            : target.defaultConfiguration;
-        if (!configuration)
-            throw new Error("No production or default configutation found for prerender.");
-        if (configuration !== "production")
-            console.warn(`Using ${configuration} configuration for the prerender, we suggest adding a production target.`);
-        prerenderTarget = { project, target: "prerender", configuration };
-        const production = await architectHost.getOptionsForTarget(prerenderTarget);
-        if (typeof (production === null || production === void 0 ? void 0 : production.browserTarget) !== "string")
+    if (!overrideTarget && !prerenderTarget && workspaceProject.targets.has("prerender")) {
+        const { defaultConfiguration = "production" } = workspaceProject.targets.get("prerender");
+        prerenderTarget = { project, target: "prerender", configuration: defaultConfiguration };
+    }
+    if (serveTarget) {
+        const options = await architectHost.getOptionsForTarget(serveTarget);
+        if (typeof (options === null || options === void 0 ? void 0 : options.browserTarget) !== "string")
+            throw new Error(`${serveTarget.target} browserTarget expected to be string, check your angular.json.`);
+        browserTarget = targetFromTargetString(options.browserTarget);
+        if (options === null || options === void 0 ? void 0 : options.serverTarget) {
+            if (typeof options.serverTarget !== "string")
+                throw new Error(`${serveTarget.target} serverTarget expected to be string, check your angular.json.`);
+            serverTarget = targetFromTargetString(options.serverTarget);
+        }
+    }
+    else if (prerenderTarget) {
+        const options = await architectHost.getOptionsForTarget(prerenderTarget);
+        if (typeof (options === null || options === void 0 ? void 0 : options.browserTarget) !== "string")
             throw new Error("Prerender browserTarget expected to be string, check your angular.json.");
-        browserTarget = targetFromTargetString(production.browserTarget);
-        if (typeof (production === null || production === void 0 ? void 0 : production.serverTarget) !== "string")
+        browserTarget = targetFromTargetString(options.browserTarget);
+        if (typeof (options === null || options === void 0 ? void 0 : options.serverTarget) !== "string")
             throw new Error("Prerender serverTarget expected to be string, check your angular.json.");
-        serverTarget = targetFromTargetString(production.serverTarget);
+        serverTarget = targetFromTargetString(options.serverTarget);
+    }
+    if (!browserTarget && workspaceProject.targets.has("build")) {
+        const { defaultConfiguration = "production" } = workspaceProject.targets.get("build");
+        browserTarget = { project, target: "build", configuration: defaultConfiguration };
+    }
+    if (!serverTarget && workspaceProject.targets.has("server")) {
+        const { defaultConfiguration = "production" } = workspaceProject.targets.get("server");
+        serverTarget = { project, target: "server", configuration: defaultConfiguration };
     }
-    else {
-        if (workspaceProject.targets.has("build")) {
-            const target = workspaceProject.targets.get("build");
-            const configurations = Object.keys(target.configurations);
-            const configuration = configurations.includes("production")
-                ? "production"
-                : target.defaultConfiguration;
-            if (!configuration)
-                throw new Error("No production or default configutation found for build.");
-            if (configuration !== "production")
-                console.warn(`Using ${configuration} configuration for the browser deploy, we suggest adding a production target.`);
-            browserTarget = { project, target: "build", configuration };
+    if (!serveTarget) {
+        if (serverTarget && workspaceProject.targets.has("serve-ssr")) {
+            const { defaultConfiguration = "development" } = workspaceProject.targets.get("serve-ssr");
+            serveTarget = { project, target: "serve-ssr", configuration: defaultConfiguration };
         }
-        if (workspaceProject.targets.has("server")) {
-            const target = workspaceProject.targets.get("server");
-            const configurations = Object.keys(target.configurations);
-            const configuration = configurations.includes("production")
-                ? "production"
-                : target.defaultConfiguration;
-            if (!configuration)
-                throw new Error("No production or default configutation found for server.");
-            if (configuration !== "production")
-                console.warn(`Using ${configuration} configuration for the server deploy, we suggest adding a production target.`);
-            serverTarget = { project, target: "server", configuration };
+        else if (workspaceProject.targets.has("serve")) {
+            const { defaultConfiguration = "development" } = workspaceProject.targets.get("serve");
+            serveTarget = { project, target: "serve", configuration: defaultConfiguration };
         }
     }
-    if (serverTarget && workspaceProject.targets.has("serve-ssr")) {
-        const target = workspaceProject.targets.get("serve-ssr");
-        const configurations = Object.keys(target.configurations);
-        const configuration = configurations.includes("development")
-            ? "development"
-            : target.defaultConfiguration;
-        if (!configuration)
-            throw new Error("No development or default configutation found for serve-ssr.");
-        if (configuration !== "development")
-            console.warn(`Using ${configuration} configuration for the local server, we suggest adding a development target.`);
-        serveTarget = { project, target: "serve-ssr", configuration };
-    }
-    else if (workspaceProject.targets.has("serve")) {
+    if (configuration) {
+        if (prerenderTarget)
+            prerenderTarget.configuration = configuration;
         if (serverTarget)
-            console.warn(`No server-ssr target found.`);
-        const target = workspaceProject.targets.get("serve");
-        const configurations = Object.keys(target.configurations);
-        const configuration = configurations.includes("development")
-            ? "development"
-            : target.defaultConfiguration;
-        if (!configuration)
-            throw new Error("No development or default configutation found for serve.");
-        if (configuration !== "development")
-            console.warn(`Using ${configuration} configuration for the local server, we suggest adding a development target.`);
-        serveTarget = { project, target: "serve", configuration };
+            serverTarget.configuration = configuration;
+        if (browserTarget)
+            browserTarget.configuration = configuration;
+        if (serveTarget)
+            serveTarget.configuration = configuration;
     }
     if (!browserTarget)
         throw new error_1.FirebaseError(`No browser target on ${project}`);
@@ -184,7 +232,7 @@ async function getContext(dir) {
     if (!browserTargetOptions) {
         throw new error_1.FirebaseError(`Couldn't find options for ${targetStringFromTarget(browserTarget)}.`);
     }
-    const baseHref = browserTargetOptions.baseHref || "";
+    const baseHref = browserTargetOptions.baseHref || "/";
     if (typeof baseHref !== "string") {
         throw new error_1.FirebaseError(`baseHref on ${targetStringFromTarget(browserTarget)} was not a string`);
     }
@@ -202,8 +250,8 @@ async function getContext(dir) {
     };
 }
 exports.getContext = getContext;
-async function getBrowserConfig(sourceDir) {
-    const { architectHost, browserTarget, baseHref, workspaceProject } = await getContext(sourceDir);
+async function getBrowserConfig(sourceDir, configuration) {
+    const { architectHost, browserTarget, baseHref, workspaceProject } = await getContext(sourceDir, configuration);
     const { locales, defaultLocale } = await localesForTarget(sourceDir, architectHost, browserTarget, workspaceProject);
     const browserTargetOptions = await architectHost.getOptionsForTarget(browserTarget);
     if (typeof (browserTargetOptions === null || browserTargetOptions === void 0 ? void 0 : browserTargetOptions.outputPath) !== "string")
@@ -212,9 +260,9 @@ async function getBrowserConfig(sourceDir) {
     return { locales, baseHref, outputPath, defaultLocale };
 }
 exports.getBrowserConfig = getBrowserConfig;
-async function getServerConfig(sourceDir) {
+async function getServerConfig(sourceDir, configuration) {
     var _a;
-    const { architectHost, host, serverTarget, browserTarget, baseHref, workspaceProject, serveOptimizedImages, } = await getContext(sourceDir);
+    const { architectHost, host, serverTarget, browserTarget, baseHref, workspaceProject, serveOptimizedImages, } = await getContext(sourceDir, configuration);
     const browserTargetOptions = await architectHost.getOptionsForTarget(browserTarget);
     if (typeof (browserTargetOptions === null || browserTargetOptions === void 0 ? void 0 : browserTargetOptions.outputPath) !== "string")
         throw new Error("browserTarget output path is not a string");
@@ -259,13 +307,14 @@ async function getServerConfig(sourceDir) {
     };
 }
 exports.getServerConfig = getServerConfig;
-async function getBuildConfig(sourceDir) {
+async function getBuildConfig(sourceDir, configuration) {
     const { targetStringFromTarget } = (0, utils_1.relativeRequire)(sourceDir, "@angular-devkit/architect");
-    const { browserTarget, prerenderTarget, serverTarget, architectHost, workspaceProject, serveOptimizedImages, } = await getContext(sourceDir);
+    const { browserTarget, baseHref, prerenderTarget, serverTarget, architectHost, workspaceProject, serveOptimizedImages, } = await getContext(sourceDir, configuration);
     const targets = (prerenderTarget ? [prerenderTarget] : [browserTarget, serverTarget].filter((it) => !!it)).map((it) => targetStringFromTarget(it));
     const locales = await localesForTarget(sourceDir, architectHost, browserTarget, workspaceProject);
     return {
         targets,
+        baseHref,
         serverTarget,
         locales,
         serveOptimizedImages,

package/lib/frameworks/astro/index.js

@@ -35,7 +35,7 @@ async function build(cwd) {
         throw new error_1.FirebaseError("Deploying an Astro application with SSR on Firebase Hosting requires the @astrojs/node adapter.");
     }
     const build = (0, cross_spawn_1.sync)(cli, ["build"], { cwd, stdio: "inherit" });
-    if (build.status)
+    if (build.status !== 0)
         throw new error_1.FirebaseError("Unable to build your Astro app");
     return { wantsBackend: output === "server" };
 }

package/lib/frameworks/constants.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.WebFrameworks = exports.I18N_ROOT = exports.ALLOWED_SSR_REGIONS = exports.DEFAULT_REGION = exports.VALID_LOCALE_FORMATS = exports.VALID_ENGINES = exports.NODE_VERSION = exports.SHARP_VERSION = exports.FIREBASE_ADMIN_VERSION = exports.FIREBASE_FUNCTIONS_VERSION = exports.FIREBASE_FRAMEWORKS_VERSION = exports.MAILING_LIST_URL = exports.FEATURE_REQUEST_URL = exports.FILE_BUG_URL = exports.DEFAULT_DOCS_URL = exports.SupportLevelWarnings = exports.NPM_COMMAND_TIMEOUT_MILLIES = void 0;
+exports.DEFAULT_SHOULD_USE_DEV_MODE_HANDLE = exports.GET_DEFAULT_BUILD_TARGETS = exports.WebFrameworks = exports.I18N_ROOT = exports.ALLOWED_SSR_REGIONS = exports.DEFAULT_REGION = exports.VALID_LOCALE_FORMATS = exports.VALID_ENGINES = exports.NODE_VERSION = exports.SHARP_VERSION = exports.FIREBASE_ADMIN_VERSION = exports.FIREBASE_FUNCTIONS_VERSION = exports.FIREBASE_FRAMEWORKS_VERSION = exports.MAILING_LIST_URL = exports.FEATURE_REQUEST_URL = exports.FILE_BUG_URL = exports.DEFAULT_DOCS_URL = exports.SupportLevelWarnings = exports.NPM_COMMAND_TIMEOUT_MILLIES = void 0;
 const fs_1 = require("fs");
 const path_1 = require("path");
 const clc = require("colorette");
@@ -21,7 +21,7 @@ exports.FIREBASE_FUNCTIONS_VERSION = "^4.3.0";
 exports.FIREBASE_ADMIN_VERSION = "^11.0.1";
 exports.SHARP_VERSION = "^0.32.1";
 exports.NODE_VERSION = parseInt(process.versions.node, 10);
-exports.VALID_ENGINES = { node: [16, 18] };
+exports.VALID_ENGINES = { node: [16, 18, 20] };
 exports.VALID_LOCALE_FORMATS = [/^ALL_[a-z]+$/, /^[a-z]+_ALL$/, /^[a-z]+(_[a-z]+)?$/];
 exports.DEFAULT_REGION = "us-central1";
 exports.ALLOWED_SSR_REGIONS = [
@@ -43,3 +43,11 @@ exports.WebFrameworks = Object.fromEntries((0, fs_1.readdirSync)(__dirname)
     }
 })
     .filter(([, obj]) => obj && obj.name && obj.discover && obj.build && obj.type !== undefined && obj.support));
+function GET_DEFAULT_BUILD_TARGETS() {
+    return Promise.resolve(["production", "development"]);
+}
+exports.GET_DEFAULT_BUILD_TARGETS = GET_DEFAULT_BUILD_TARGETS;
+function DEFAULT_SHOULD_USE_DEV_MODE_HANDLE(target) {
+    return Promise.resolve(target === "development");
+}
+exports.DEFAULT_SHOULD_USE_DEV_MODE_HANDLE = DEFAULT_SHOULD_USE_DEV_MODE_HANDLE;

package/lib/frameworks/express/index.js

@@ -21,10 +21,10 @@ async function getConfig(root) {
 async function discover(dir) {
     if (!(await (0, fs_extra_1.pathExists)((0, path_1.join)(dir, "package.json"))))
         return;
-    const { serveDir } = await getConfig(dir);
-    if (!serveDir)
+    const { serveDir: publicDirectory } = await getConfig(dir);
+    if (!publicDirectory)
         return;
-    return { mayWantBackend: true };
+    return { mayWantBackend: true, publicDirectory };
 }
 exports.discover = discover;
 async function build(cwd) {
@@ -88,7 +88,7 @@ async function getBootstrapScript(root, _bootstrapScript = "", _entry) {
 async function ɵcodegenFunctionsDirectory(root, dest) {
     const bootstrapScript = await getBootstrapScript(root);
     if (!bootstrapScript)
-        return;
+        throw new Error("Cloud not find bootstrapScript");
     await (0, promises_1.mkdir)(dest, { recursive: true });
     const { packageJson } = await getConfig(root);
     const packResults = (0, child_process_1.execSync)(`npm pack ${root} --json`, { cwd: dest });

package/lib/frameworks/flutter/constants.js

@@ -0,0 +1,72 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.FALLBACK_PROJECT_NAME = exports.DART_RESERVED_WORDS = void 0;
+exports.DART_RESERVED_WORDS = [
+    "abstract",
+    "else",
+    "import",
+    "show",
+    "as",
+    "enum",
+    "in",
+    "static",
+    "assert",
+    "export",
+    "interface",
+    "super",
+    "async",
+    "extends",
+    "is",
+    "switch",
+    "await",
+    "extension",
+    "late",
+    "sync",
+    "base",
+    "external",
+    "library",
+    "this",
+    "break",
+    "factory",
+    "mixin",
+    "throw",
+    "case",
+    "false",
+    "new",
+    "true",
+    "catch",
+    "final",
+    "null",
+    "try",
+    "class",
+    "on",
+    "typedef",
+    "const",
+    "finally",
+    "operator",
+    "var",
+    "continue",
+    "for",
+    "part",
+    "void",
+    "covariant",
+    "function",
+    "required",
+    "when",
+    "default",
+    "get",
+    "rethrow",
+    "while",
+    "deferred",
+    "hide",
+    "return",
+    "with",
+    "do",
+    "if",
+    "sealed",
+    "yield",
+    "dynamic",
+    "implements",
+    "set",
+];
+exports.FALLBACK_PROJECT_NAME = "hello_firebase";