firebase-tools 12.0.0 → 12.1.0

package/lib/deploy/functions/runtimes/index.js

@@ -11,6 +11,7 @@ const RUNTIMES = [
     "nodejs14",
     "nodejs16",
     "nodejs18",
+    "nodejs20",
     "python310",
     "python311",
 ];
@@ -32,6 +33,7 @@ const MESSAGE_FRIENDLY_RUNTIMES = {
     nodejs14: "Node.js 14",
     nodejs16: "Node.js 16",
     nodejs18: "Node.js 18",
+    nodejs20: "Node.js 20",
     python310: "Python 3.10",
     python311: "Python 3.11",
 };

package/lib/deploy/functions/runtimes/node/parseRuntimeAndValidateSDK.js

@@ -15,6 +15,7 @@ const ENGINE_RUNTIMES = {
     14: "nodejs14",
     16: "nodejs16",
     18: "nodejs18",
+    20: "nodejs20",
 };
 const ENGINE_RUNTIMES_NAMES = Object.values(ENGINE_RUNTIMES);
 exports.RUNTIME_NOT_SET = "`runtime` field is required but was not found in firebase.json.\n" +

package/lib/deploy/functions/runtimes/python/index.js

@@ -107,7 +107,7 @@ class Delegate {
         var _a, _b;
         const modulesDir = await this.modulesDir();
         const envWithAdminPort = Object.assign(Object.assign({}, envs), { ADMIN_PORT: port.toString() });
-        const args = [this.bin, path.join(modulesDir, "private", "serving.py")];
+        const args = [this.bin, `"${path.join(modulesDir, "private", "serving.py")}"`];
         const stdout = [];
         const stderr = [];
         logger_1.logger.debug(`Running admin server with args: ${JSON.stringify(args)} and env: ${JSON.stringify(envWithAdminPort)} in ${this.sourceDir}`);

package/lib/emulator/eventarcEmulatorUtils.js

@@ -36,10 +36,12 @@ function cloudEventFromProtoToJson(ce) {
 }
 exports.cloudEventFromProtoToJson = cloudEventFromProtoToJson;
 function getOptionalAttribute(ce, attr, type) {
-    return ce["attributes"][attr][type];
+    var _a, _b;
+    return (_b = (_a = ce === null || ce === void 0 ? void 0 : ce["attributes"]) === null || _a === void 0 ? void 0 : _a[attr]) === null || _b === void 0 ? void 0 : _b[type];
 }
 function getRequiredAttribute(ce, attr, type) {
-    const val = ce["attributes"][attr][type];
+    var _a, _b;
+    const val = (_b = (_a = ce === null || ce === void 0 ? void 0 : ce["attributes"]) === null || _a === void 0 ? void 0 : _a[attr]) === null || _b === void 0 ? void 0 : _b[type];
     if (val === undefined) {
         throw new error_1.FirebaseError("CloudEvent must contain " + attr + " attribute");
     }

package/lib/frameworks/angular/index.js

@@ -10,6 +10,7 @@ const prompt_1 = require("../../prompt");
 const utils_1 = require("../utils");
 const utils_2 = require("./utils");
 const constants_1 = require("../constants");
+const error_1 = require("../../error");
 exports.name = "Angular";
 exports.support = "preview";
 exports.type = 3;
@@ -47,10 +48,12 @@ async function build(dir) {
     await (0, utils_1.warnIfCustomBuildScript)(dir, exports.name, DEFAULT_BUILD_SCRIPT);
     for (const target of targets) {
         const cli = (0, utils_1.getNodeModuleBin)("ng", dir);
-        (0, cross_spawn_1.sync)(cli, ["run", target], {
+        const result = (0, cross_spawn_1.sync)(cli, ["run", target], {
             cwd: dir,
             stdio: "inherit",
         });
+        if (result.status !== 0)
+            throw new error_1.FirebaseError(`Unable to build ${target}`);
     }
     const wantsBackend = !!serverTarget || serveOptimizedImages;
     const i18n = !!locales;

package/lib/frameworks/angular/utils.js

@@ -114,7 +114,7 @@ async function getContext(dir) {
             ? "production"
             : target.defaultConfiguration;
         if (!configuration)
-            throw new Error("No production or default configutation found for prerender.");
+            throw new Error("No production or default configuration found for prerender.");
         if (configuration !== "production")
             console.warn(`Using ${configuration} configuration for the prerender, we suggest adding a production target.`);
         prerenderTarget = { project, target: "prerender", configuration };
@@ -134,7 +134,7 @@ async function getContext(dir) {
                 ? "production"
                 : target.defaultConfiguration;
             if (!configuration)
-                throw new Error("No production or default configutation found for build.");
+                throw new Error("No production or default configuration found for build.");
             if (configuration !== "production")
                 console.warn(`Using ${configuration} configuration for the browser deploy, we suggest adding a production target.`);
             browserTarget = { project, target: "build", configuration };

package/lib/frameworks/astro/index.js

@@ -35,7 +35,7 @@ async function build(cwd) {
         throw new error_1.FirebaseError("Deploying an Astro application with SSR on Firebase Hosting requires the @astrojs/node adapter.");
     }
     const build = (0, cross_spawn_1.sync)(cli, ["build"], { cwd, stdio: "inherit" });
-    if (build.status)
+    if (build.status !== 0)
         throw new error_1.FirebaseError("Unable to build your Astro app");
     return { wantsBackend: output === "server" };
 }

package/lib/frameworks/flutter/constants.js

@@ -0,0 +1,72 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.FALLBACK_PROJECT_NAME = exports.DART_RESERVED_WORDS = void 0;
+exports.DART_RESERVED_WORDS = [
+    "abstract",
+    "else",
+    "import",
+    "show",
+    "as",
+    "enum",
+    "in",
+    "static",
+    "assert",
+    "export",
+    "interface",
+    "super",
+    "async",
+    "extends",
+    "is",
+    "switch",
+    "await",
+    "extension",
+    "late",
+    "sync",
+    "base",
+    "external",
+    "library",
+    "this",
+    "break",
+    "factory",
+    "mixin",
+    "throw",
+    "case",
+    "false",
+    "new",
+    "true",
+    "catch",
+    "final",
+    "null",
+    "try",
+    "class",
+    "on",
+    "typedef",
+    "const",
+    "finally",
+    "operator",
+    "var",
+    "continue",
+    "for",
+    "part",
+    "void",
+    "covariant",
+    "function",
+    "required",
+    "when",
+    "default",
+    "get",
+    "rethrow",
+    "while",
+    "deferred",
+    "hide",
+    "return",
+    "with",
+    "do",
+    "if",
+    "sealed",
+    "yield",
+    "dynamic",
+    "implements",
+    "set",
+];
+exports.FALLBACK_PROJECT_NAME = "hello_firebase";

package/lib/frameworks/flutter/index.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.ɵcodegenPublicDirectory = exports.build = exports.discover = exports.support = exports.type = exports.name = void 0;
+exports.ɵcodegenPublicDirectory = exports.build = exports.init = exports.discover = exports.support = exports.type = exports.name = void 0;
 const cross_spawn_1 = require("cross-spawn");
 const fs_extra_1 = require("fs-extra");
 const path_1 = require("path");
@@ -8,7 +8,8 @@ const js_yaml_1 = require("js-yaml");
 const promises_1 = require("fs/promises");
 const error_1 = require("../../error");
 const utils_1 = require("./utils");
-exports.name = "Flutter";
+const constants_1 = require("./constants");
+exports.name = "Flutter Web";
 exports.type = 3;
 exports.support = "experimental";
 async function discover(dir) {
@@ -25,10 +26,28 @@ async function discover(dir) {
     return { mayWantBackend: false, publicDirectory: (0, path_1.join)(dir, "web") };
 }
 exports.discover = discover;
+function init(setup, config) {
+    (0, utils_1.assertFlutterCliExists)();
+    const projectName = constants_1.DART_RESERVED_WORDS.includes(setup.projectId)
+        ? constants_1.FALLBACK_PROJECT_NAME
+        : setup.projectId.replaceAll("-", "_");
+    const result = (0, cross_spawn_1.sync)("flutter", [
+        "create",
+        "--template=app",
+        `--project-name=${projectName}`,
+        "--overwrite",
+        "--platforms=web",
+        setup.hosting.source,
+    ], { stdio: "inherit", cwd: config.projectDir });
+    if (result.status !== 0)
+        throw new error_1.FirebaseError("We were not able to create your flutter app, create the application yourself https://docs.flutter.dev/get-started/test-drive?tab=terminal before trying again.");
+    return Promise.resolve();
+}
+exports.init = init;
 function build(cwd) {
     (0, utils_1.assertFlutterCliExists)();
     const build = (0, cross_spawn_1.sync)("flutter", ["build", "web"], { cwd, stdio: "inherit" });
-    if (build.status)
+    if (build.status !== 0)
         throw new error_1.FirebaseError("Unable to build your Flutter app");
     return Promise.resolve({ wantsBackend: false });
 }

package/lib/frameworks/flutter/utils.js

@@ -5,7 +5,7 @@ const cross_spawn_1 = require("cross-spawn");
 const error_1 = require("../../error");
 function assertFlutterCliExists() {
     const process = (0, cross_spawn_1.sync)("flutter", ["--version"], { stdio: "ignore" });
-    if (process.status)
-        throw new error_1.FirebaseError("Flutter CLI not found.");
+    if (process.status !== 0)
+        throw new error_1.FirebaseError("Flutter CLI not found, follow the instructions here https://docs.flutter.dev/get-started/install before trying again.");
 }
 exports.assertFlutterCliExists = assertFlutterCliExists;

package/lib/frameworks/index.js

@@ -311,7 +311,7 @@ async function prepareFrameworks(targetNames, context, options, emulators = [])
                         const result = (0, cross_spawn_1.sync)("npm", ["pack", (0, path_1.relative)(functionsDist, path), "--json=true"], {
                             cwd: functionsDist,
                         });
-                        if (result.status)
+                        if (result.status !== 0)
                             throw new Error(`Error running \`npm pack\` at ${path}`);
                         const { filename } = JSON.parse(result.stdout.toString())[0];
                         packageJson.dependencies[name] = `file:${filename}`;

package/lib/frameworks/next/index.js

@@ -325,7 +325,7 @@ async function ɵcodegenFunctionsDirectory(sourceDir, destDir) {
                 cwd: sourceDir,
                 timeout: BUNDLE_NEXT_CONFIG_TIMEOUT,
             });
-            if (bundle.status) {
+            if (bundle.status !== 0) {
                 throw new error_1.FirebaseError(bundle.stderr.toString());
             }
         }

package/lib/functions/python.js

@@ -7,7 +7,7 @@ const logger_1 = require("../logger");
 exports.DEFAULT_VENV_DIR = "venv";
 function virtualEnvCmd(cwd, venvDir) {
     const activateScriptPath = process.platform === "win32" ? ["Scripts", "activate.bat"] : ["bin", "activate"];
-    const venvActivate = path.join(cwd, venvDir, ...activateScriptPath);
+    const venvActivate = `"${path.join(cwd, venvDir, ...activateScriptPath)}"`;
     return {
         command: process.platform === "win32" ? venvActivate : ".",
         args: [process.platform === "win32" ? "" : venvActivate],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "firebase-tools",
-  "version": "12.0.0",
+  "version": "12.1.0",
   "description": "Command-Line Interface for Firebase",
   "main": "./lib/index.js",
   "bin": {

package/schema/firebase-config.json

@@ -617,7 +617,8 @@
                                 "nodejs12",
                                 "nodejs14",
                                 "nodejs16",
-                                "nodejs18"
+                                "nodejs18",
+                                "nodejs20"
                             ],
                             "type": "string"
                         },
@@ -672,7 +673,8 @@
                                     "nodejs12",
                                     "nodejs14",
                                     "nodejs16",
-                                    "nodejs18"
+                                    "nodejs18",
+                                    "nodejs20"
                                 ],
                                 "type": "string"
                             },