firebase-tools 11.30.0 → 12.0.1

package/lib/frameworks/index.js

@@ -29,6 +29,7 @@ const constants_2 = require("./constants");
 Object.defineProperty(exports, "WebFrameworks", { enumerable: true, get: function () { return constants_2.WebFrameworks; } });
 const utils_2 = require("../utils");
 const ensureTargeted_1 = require("../functions/ensureTargeted");
+const util_1 = require("util");
 async function discover(dir, warn = true) {
     const allFrameworkTypes = [
         ...new Set(Object.values(constants_2.WebFrameworks).map(({ type }) => type)),
@@ -58,9 +59,21 @@ async function discover(dir, warn = true) {
     return;
 }
 exports.discover = discover;
+const BUILD_MEMO = new Map();
+function memoizeBuild(dir, build, deps) {
+    const key = [dir, ...deps];
+    for (const existingKey of BUILD_MEMO.keys()) {
+        if ((0, util_1.isDeepStrictEqual)(existingKey, key)) {
+            return BUILD_MEMO.get(existingKey);
+        }
+    }
+    const value = build(dir);
+    BUILD_MEMO.set(key, value);
+    return value;
+}
 async function prepareFrameworks(targetNames, context, options, emulators = []) {
-    var _a, _b, _c;
-    var _d, _e, _f, _g, _h;
+    var _a, _b, _c, _d, _e;
+    var _f, _g, _h, _j, _k;
     const nodeVersion = process.version;
     if (!semver.satisfies(nodeVersion, ">=16.0.0")) {
         throw new error_1.FirebaseError(`The frameworks awareness feature requires Node.JS >= 16 and npm >= 8 in order to work correctly, due to some of the downstream dependencies. Please upgrade your version of Node.JS, reinstall firebase-tools, and give it another go.`);
@@ -72,7 +85,7 @@ async function prepareFrameworks(targetNames, context, options, emulators = [])
         try {
             await (0, requireHostingSite_1.requireHostingSite)(options);
         }
-        catch (_j) {
+        catch (_l) {
             options.site = project;
         }
     }
@@ -98,6 +111,7 @@ async function prepareFrameworks(targetNames, context, options, emulators = [])
             throw new Error(`hosting.public and hosting.source cannot both be set in firebase.json`);
         }
         const ssrRegion = (_b = frameworksBackend === null || frameworksBackend === void 0 ? void 0 : frameworksBackend.region) !== null && _b !== void 0 ? _b : constants_2.DEFAULT_REGION;
+        const omitCloudFunction = (_c = frameworksBackend === null || frameworksBackend === void 0 ? void 0 : frameworksBackend.omit) !== null && _c !== void 0 ? _c : false;
         if (!allowedRegionsValues.includes(ssrRegion)) {
             const validRegions = (0, utils_1.conjoinOptions)(allowedRegionsValues);
             throw new error_1.FirebaseError(`Hosting config for site ${site} places server-side content in region ${ssrRegion} which is not known. Valid regions are ${validRegions}`);
@@ -190,17 +204,22 @@ async function prepareFrameworks(targetNames, context, options, emulators = [])
             }
         }
         else {
-            const { wantsBackend = false, rewrites = [], redirects = [], headers = [], trailingSlash, } = (await build(getProjectPath())) || {};
+            const { wantsBackend = false, rewrites = [], redirects = [], headers = [], trailingSlash, i18n = false, } = (await memoizeBuild(getProjectPath(), build, [firebaseDefaults])) || {};
             config.rewrites.push(...rewrites);
             config.redirects.push(...redirects);
             config.headers.push(...headers);
-            (_c = config.trailingSlash) !== null && _c !== void 0 ? _c : (config.trailingSlash = trailingSlash);
+            (_d = config.trailingSlash) !== null && _d !== void 0 ? _d : (config.trailingSlash = trailingSlash);
+            if (i18n)
+                (_e = config.i18n) !== null && _e !== void 0 ? _e : (config.i18n = { root: constants_2.I18N_ROOT });
             if (await (0, fs_extra_1.pathExists)(hostingDist))
                 await (0, promises_1.rm)(hostingDist, { recursive: true });
             await (0, fs_extra_1.mkdirp)(hostingDist);
-            await ɵcodegenPublicDirectory(getProjectPath(), hostingDist);
+            await ɵcodegenPublicDirectory(getProjectPath(), hostingDist, {
+                project,
+                site,
+            });
             config.public = (0, path_1.relative)(projectRoot, hostingDist);
-            if (wantsBackend)
+            if (wantsBackend && !omitCloudFunction)
                 codegenFunctionsDirectory = codegenProdModeFunctionsDirectory;
         }
         config.webFramework = `${framework}${codegenFunctionsDirectory ? "_ssr" : ""}`;
@@ -212,14 +231,6 @@ async function prepareFrameworks(targetNames, context, options, emulators = [])
             if (context.hostingChannel) {
                 experiments.assertEnabled("pintags", "deploy an app that requires a backend to a preview channel");
             }
-            config.rewrites.push({
-                source: "**",
-                function: {
-                    functionId,
-                    region: ssrRegion,
-                    pinTag: experiments.isEnabled("pintags"),
-                },
-            });
             const codebase = `firebase-frameworks-${site}`;
             const existingFunctionsConfig = options.config.get("functions")
                 ? [].concat(options.config.get("functions"))
@@ -258,27 +269,35 @@ async function prepareFrameworks(targetNames, context, options, emulators = [])
             else {
                 await (0, fs_extra_1.mkdirp)(functionsDist);
             }
-            const { packageJson, bootstrapScript, frameworksEntry = framework, } = await codegenFunctionsDirectory(getProjectPath(), functionsDist);
+            const { packageJson, bootstrapScript, frameworksEntry = framework, baseUrl = "", dotEnv = {}, } = await codegenFunctionsDirectory(getProjectPath(), functionsDist);
+            config.rewrites.push({
+                source: path_1.posix.normalize(path_1.posix.join(baseUrl, "**")),
+                function: {
+                    functionId,
+                    region: ssrRegion,
+                    pinTag: experiments.isEnabled("pintags"),
+                },
+            });
             process.env.__FIREBASE_FRAMEWORKS_ENTRY__ = frameworksEntry;
             packageJson.main = "server.js";
             packageJson.dependencies || (packageJson.dependencies = {});
-            (_d = packageJson.dependencies)["firebase-frameworks"] || (_d["firebase-frameworks"] = constants_2.FIREBASE_FRAMEWORKS_VERSION);
-            (_e = packageJson.dependencies)["firebase-functions"] || (_e["firebase-functions"] = constants_2.FIREBASE_FUNCTIONS_VERSION);
-            (_f = packageJson.dependencies)["firebase-admin"] || (_f["firebase-admin"] = constants_2.FIREBASE_ADMIN_VERSION);
+            (_f = packageJson.dependencies)["firebase-frameworks"] || (_f["firebase-frameworks"] = constants_2.FIREBASE_FRAMEWORKS_VERSION);
+            (_g = packageJson.dependencies)["firebase-functions"] || (_g["firebase-functions"] = constants_2.FIREBASE_FUNCTIONS_VERSION);
+            (_h = packageJson.dependencies)["firebase-admin"] || (_h["firebase-admin"] = constants_2.FIREBASE_ADMIN_VERSION);
             packageJson.engines || (packageJson.engines = {});
             const validEngines = constants_2.VALID_ENGINES.node.filter((it) => it <= constants_2.NODE_VERSION);
             const engine = validEngines[validEngines.length - 1] || constants_2.VALID_ENGINES.node[0];
             if (engine !== constants_2.NODE_VERSION) {
                 (0, utils_2.logWarning)(`This integration expects Node version ${(0, utils_1.conjoinOptions)(constants_2.VALID_ENGINES.node, "or")}. You're running version ${constants_2.NODE_VERSION}, problems may be encountered.`);
             }
-            (_g = packageJson.engines).node || (_g.node = engine.toString());
+            (_j = packageJson.engines).node || (_j.node = engine.toString());
             delete packageJson.scripts;
             delete packageJson.devDependencies;
             const bundledDependencies = packageJson.bundledDependencies || {};
             if (Object.keys(bundledDependencies).length) {
                 (0, utils_2.logWarning)("Bundled dependencies aren't supported in Cloud Functions, converting to dependencies.");
                 for (const [dep, version] of Object.entries(bundledDependencies)) {
-                    (_h = packageJson.dependencies)[dep] || (_h[dep] = version);
+                    (_k = packageJson.dependencies)[dep] || (_k[dep] = version);
                 }
                 delete packageJson.bundledDependencies;
             }
@@ -289,12 +308,12 @@ async function prepareFrameworks(targetNames, context, options, emulators = [])
                         continue;
                     const stats = await (0, fs_extra_1.stat)(path);
                     if (stats.isDirectory()) {
-                        const result = (0, cross_spawn_1.sync)("npm", ["pack", (0, path_1.relative)(functionsDist, path)], {
+                        const result = (0, cross_spawn_1.sync)("npm", ["pack", (0, path_1.relative)(functionsDist, path), "--json=true"], {
                             cwd: functionsDist,
                         });
-                        if (!result.stdout)
+                        if (result.status)
                             throw new Error(`Error running \`npm pack\` at ${path}`);
-                        const filename = result.stdout.toString().trim();
+                        const { filename } = JSON.parse(result.stdout.toString())[0];
                         packageJson.dependencies[name] = `file:${filename}`;
                     }
                     else {
@@ -310,13 +329,16 @@ async function prepareFrameworks(targetNames, context, options, emulators = [])
             if (await (0, fs_extra_1.pathExists)(getProjectPath(".npmrc"))) {
                 await (0, promises_1.copyFile)(getProjectPath(".npmrc"), (0, path_1.join)(functionsDist, ".npmrc"));
             }
-            let existingDotEnvContents = "";
+            let dotEnvContents = "";
             if (await (0, fs_extra_1.pathExists)(getProjectPath(".env"))) {
-                existingDotEnvContents = (await (0, promises_1.readFile)(getProjectPath(".env"))).toString();
+                dotEnvContents = (await (0, promises_1.readFile)(getProjectPath(".env"))).toString();
+            }
+            for (const [key, value] of Object.entries(dotEnv)) {
+                dotEnvContents += `\n${key}=${value}`;
             }
-            await (0, promises_1.writeFile)((0, path_1.join)(functionsDist, ".env"), `${existingDotEnvContents}
+            await (0, promises_1.writeFile)((0, path_1.join)(functionsDist, ".env"), `${dotEnvContents}
 __FIREBASE_FRAMEWORKS_ENTRY__=${frameworksEntry}
-${firebaseDefaults ? `__FIREBASE_DEFAULTS__=${JSON.stringify(firebaseDefaults)}\n` : ""}`);
+${firebaseDefaults ? `__FIREBASE_DEFAULTS__=${JSON.stringify(firebaseDefaults)}\n` : ""}`.trimStart());
             const envs = await new Promise((resolve, reject) => glob(getProjectPath(".env.*"), (err, matches) => {
                 if (err)
                     reject(err);
@@ -343,6 +365,9 @@ ${firebaseDefaults ? `__FIREBASE_DEFAULTS__=${JSON.stringify(firebaseDefaults)}\
             }
         }
         else {
+            if (await (0, fs_extra_1.pathExists)(functionsDist)) {
+                await (0, promises_1.rm)(functionsDist, { recursive: true });
+            }
             config.rewrites.push({
                 source: "**",
                 destination: "/index.html",
@@ -364,6 +389,13 @@ ${firebaseDefaults ? `__FIREBASE_DEFAULTS__=${JSON.stringify(firebaseDefaults)}\
             });
         }
     }
+    if (process.env.DEBUG) {
+        console.log("Effective firebase.json:");
+        console.log(JSON.stringify(configs, undefined, 2));
+    }
+    BUILD_MEMO.clear();
+    delete process.env.__FIREBASE_DEFAULTS__;
+    delete process.env.__FIREBASE_FRAMEWORKS_ENTRY__;
 }
 exports.prepareFrameworks = prepareFrameworks;
 function codegenDevModeFunctionsDirectory() {

package/lib/frameworks/next/index.js

@@ -17,10 +17,11 @@ const StreamObject_1 = require("stream-json/streamers/StreamObject");
 const fsutils_1 = require("../../fsutils");
 const prompt_1 = require("../../prompt");
 const error_1 = require("../../error");
-const constants_1 = require("../constants");
 const utils_1 = require("../utils");
 const utils_2 = require("./utils");
+const constants_1 = require("../constants");
 const constants_2 = require("./constants");
+const api_1 = require("../../hosting/api");
 const DEFAULT_BUILD_SCRIPT = ["next build"];
 const PUBLIC_DIR = "public";
 exports.name = "Next.js";
@@ -57,7 +58,7 @@ async function build(dir) {
         throw e;
     });
     const reasonsForBackend = new Set();
-    const { distDir, trailingSlash } = await getConfig(dir);
+    const { distDir, trailingSlash, basePath } = await getConfig(dir);
     if (await (0, utils_2.isUsingMiddleware)((0, path_1.join)(dir, distDir), false)) {
         reasonsForBackend.add("middleware");
     }
@@ -85,12 +86,13 @@ async function build(dir) {
         reasonsForBackend.add(`non-static route ${key}`);
     }
     const manifest = await (0, utils_1.readJSON)((0, path_1.join)(dir, distDir, constants_2.ROUTES_MANIFEST));
-    const { headers: nextJsHeaders = [], redirects: nextJsRedirects = [], rewrites: nextJsRewrites = [], } = manifest;
-    const isEveryHeaderSupported = nextJsHeaders.every(utils_2.isHeaderSupportedByHosting);
+    const { headers: nextJsHeaders = [], redirects: nextJsRedirects = [], rewrites: nextJsRewrites = [], i18n: nextjsI18n, } = manifest;
+    const isEveryHeaderSupported = nextJsHeaders.map(utils_2.cleanI18n).every(utils_2.isHeaderSupportedByHosting);
     if (!isEveryHeaderSupported) {
         reasonsForBackend.add("advanced headers");
     }
     const headers = nextJsHeaders
+        .map(utils_2.cleanI18n)
         .filter(utils_2.isHeaderSupportedByHosting)
         .map(({ source, headers }) => ({
         source: (0, utils_2.cleanEscapedChars)(source),
@@ -101,7 +103,7 @@ async function build(dir) {
         (0, utils_1.readJSON)((0, path_1.join)(dir, distDir, constants_2.APP_PATH_ROUTES_MANIFEST)).catch(() => undefined),
     ]);
     if (appPathRoutesManifest) {
-        const headersFromMetaFiles = await (0, utils_2.getHeadersFromMetaFiles)(dir, distDir, appPathRoutesManifest);
+        const headersFromMetaFiles = await (0, utils_2.getHeadersFromMetaFiles)(dir, distDir, basePath, appPathRoutesManifest);
         headers.push(...headersFromMetaFiles);
         if (appPathsManifest) {
             const unrenderedServerComponents = (0, utils_2.getNonStaticServerComponents)(appPathsManifest, appPathRoutesManifest, prerenderedRoutes, dynamicRoutes);
@@ -117,6 +119,7 @@ async function build(dir) {
         reasonsForBackend.add("advanced redirects");
     }
     const redirects = nextJsRedirects
+        .map(utils_2.cleanI18n)
         .filter(utils_2.isRedirectSupportedByHosting)
         .map(({ source, destination, statusCode: type }) => ({
         source: (0, utils_2.cleanEscapedChars)(source),
@@ -134,6 +137,7 @@ async function build(dir) {
     }
     const rewrites = nextJsRewritesToUse
         .filter(utils_2.isRewriteSupportedByHosting)
+        .map(utils_2.cleanI18n)
         .map(({ source, destination }) => ({
         source: (0, utils_2.cleanEscapedChars)(source),
         destination,
@@ -150,7 +154,15 @@ async function build(dir) {
         }
         console.log("");
     }
-    return { wantsBackend, headers, redirects, rewrites, trailingSlash };
+    const i18n = !!nextjsI18n;
+    return {
+        wantsBackend,
+        headers,
+        redirects,
+        rewrites,
+        trailingSlash,
+        i18n,
+    };
 }
 exports.build = build;
 async function init(setup, config) {
@@ -163,25 +175,20 @@ async function init(setup, config) {
     (0, child_process_1.execSync)(`npx --yes create-next-app@latest -e hello-world ${setup.hosting.source} --use-npm ${language === "TypeScript" ? "--ts" : "--js"}`, { stdio: "inherit", cwd: config.projectDir });
 }
 exports.init = init;
-async function ɵcodegenPublicDirectory(sourceDir, destDir) {
-    const { distDir } = await getConfig(sourceDir);
+async function ɵcodegenPublicDirectory(sourceDir, destDir, context) {
+    const { distDir, i18n, basePath } = await getConfig(sourceDir);
+    let matchingI18nDomain = undefined;
+    if (i18n === null || i18n === void 0 ? void 0 : i18n.domains) {
+        const siteDomains = await (0, api_1.getAllSiteDomains)(context.project, context.site);
+        matchingI18nDomain = i18n.domains.find(({ domain }) => siteDomains.includes(domain));
+    }
+    const singleLocaleDomain = !i18n || ((matchingI18nDomain || i18n).locales || []).length <= 1;
     const publicPath = (0, path_1.join)(sourceDir, "public");
-    await (0, promises_1.mkdir)((0, path_1.join)(destDir, "_next", "static"), { recursive: true });
+    await (0, promises_1.mkdir)((0, path_1.join)(destDir, basePath, "_next", "static"), { recursive: true });
     if (await (0, fs_extra_1.pathExists)(publicPath)) {
-        await (0, fs_extra_1.copy)(publicPath, destDir);
-    }
-    await (0, fs_extra_1.copy)((0, path_1.join)(sourceDir, distDir, "static"), (0, path_1.join)(destDir, "_next", "static"));
-    for (const file of ["index.html", "404.html", "500.html"]) {
-        const pagesPath = (0, path_1.join)(sourceDir, distDir, "server", "pages", file);
-        if (await (0, fs_extra_1.pathExists)(pagesPath)) {
-            await (0, promises_1.copyFile)(pagesPath, (0, path_1.join)(destDir, file));
-            continue;
-        }
-        const appPath = (0, path_1.join)(sourceDir, distDir, "server", "app", file);
-        if (await (0, fs_extra_1.pathExists)(appPath)) {
-            await (0, promises_1.copyFile)(appPath, (0, path_1.join)(destDir, file));
-        }
+        await (0, fs_extra_1.copy)(publicPath, (0, path_1.join)(destDir, basePath));
     }
+    await (0, fs_extra_1.copy)((0, path_1.join)(sourceDir, distDir, "static"), (0, path_1.join)(destDir, basePath, "_next", "static"));
     const [middlewareManifest, prerenderManifest, routesManifest, pagesManifest, appPathRoutesManifest,] = await Promise.all([
         (0, utils_1.readJSON)((0, path_1.join)(sourceDir, distDir, "server", constants_2.MIDDLEWARE_MANIFEST)),
         (0, utils_1.readJSON)((0, path_1.join)(sourceDir, distDir, constants_2.PRERENDER_MANIFEST)),
@@ -194,9 +201,12 @@ async function ɵcodegenPublicDirectory(sourceDir, destDir) {
     const { redirects = [], rewrites = [], headers = [] } = routesManifest;
     const rewritesRegexesNotSupportedByHosting = (0, utils_2.getNextjsRewritesToUse)(rewrites)
         .filter((rewrite) => !(0, utils_2.isRewriteSupportedByHosting)(rewrite))
+        .map(utils_2.cleanI18n)
         .map((rewrite) => new RegExp(rewrite.regex));
     const redirectsRegexesNotSupportedByHosting = redirects
+        .filter((it) => !it.internal)
         .filter((redirect) => !(0, utils_2.isRedirectSupportedByHosting)(redirect))
+        .map(utils_2.cleanI18n)
         .map((redirect) => new RegExp(redirect.regex));
     const headersRegexesNotSupportedByHosting = headers
         .filter((header) => !(0, utils_2.isHeaderSupportedByHosting)(header))
@@ -214,33 +224,67 @@ async function ɵcodegenPublicDirectory(sourceDir, destDir) {
     }));
     const routesToCopy = Object.assign(Object.assign({}, prerenderManifest.routes), pagesManifestLikePrerender);
     await Promise.all(Object.entries(routesToCopy).map(async ([path, route]) => {
-        var _a;
-        if (route.initialRevalidateSeconds ||
-            pathsUsingsFeaturesNotSupportedByHosting.some((it) => path.match(it))) {
+        var _a, _b;
+        if (route.initialRevalidateSeconds) {
+            if (process.env.DEBUG)
+                console.log(`skipping ${path} due to revalidate`);
+            return;
+        }
+        if (pathsUsingsFeaturesNotSupportedByHosting.some((it) => path.match(it))) {
+            if (process.env.DEBUG)
+                console.log(`skipping ${path} due to it matching an unsupported rewrite/redirect/header or middlware`);
             return;
         }
         const appPathRoute = route.srcRoute && ((_a = appPathRoutesEntries.find(([, it]) => it === route.srcRoute)) === null || _a === void 0 ? void 0 : _a[0]);
         const contentDist = (0, path_1.join)(sourceDir, distDir, "server", appPathRoute ? "app" : "pages");
-        const parts = path.split("/").filter((it) => !!it);
-        const partsOrIndex = parts.length > 0 ? parts : ["index"];
-        let sourcePath = (0, path_1.join)(contentDist, ...partsOrIndex);
-        let destPath = (0, path_1.join)(destDir, ...partsOrIndex);
+        const sourceParts = path.split("/").filter((it) => !!it);
+        const locale = (i18n === null || i18n === void 0 ? void 0 : i18n.locales.includes(sourceParts[0])) ? sourceParts[0] : undefined;
+        const includeOnThisDomain = !locale ||
+            !matchingI18nDomain ||
+            matchingI18nDomain.defaultLocale === locale ||
+            !matchingI18nDomain.locales ||
+            matchingI18nDomain.locales.includes(locale);
+        if (!includeOnThisDomain) {
+            if (process.env.DEBUG)
+                console.log(`skipping ${path} since it is for a locale not deployed on this domain`);
+            return;
+        }
+        const sourcePartsOrIndex = sourceParts.length > 0 ? sourceParts : ["index"];
+        const destParts = sourceParts.slice(locale ? 1 : 0);
+        const destPartsOrIndex = destParts.length > 0 ? destParts : ["index"];
+        const isDefaultLocale = !locale || ((_b = (matchingI18nDomain || i18n)) === null || _b === void 0 ? void 0 : _b.defaultLocale) === locale;
+        let sourcePath = (0, path_1.join)(contentDist, ...sourcePartsOrIndex);
+        let localizedDestPath = !singleLocaleDomain &&
+            locale &&
+            (0, path_1.join)(destDir, constants_1.I18N_ROOT, locale, basePath, ...destPartsOrIndex);
+        let defaultDestPath = isDefaultLocale && (0, path_1.join)(destDir, basePath, ...destPartsOrIndex);
         if (!(0, fsutils_1.fileExistsSync)(sourcePath) && (0, fsutils_1.fileExistsSync)(`${sourcePath}.html`)) {
             sourcePath += ".html";
-            destPath += ".html";
+            if (localizedDestPath)
+                localizedDestPath += ".html";
+            if (defaultDestPath)
+                defaultDestPath += ".html";
         }
-        else if (appPathRoute && (0, path_1.basename)(appPathRoute) === "route" && (0, fsutils_1.dirExistsSync)(sourcePath)) {
+        else if (appPathRoute &&
+            (0, path_1.basename)(appPathRoute) === "route" &&
+            (0, fsutils_1.fileExistsSync)(`${sourcePath}.body`)) {
             sourcePath += ".body";
         }
-        if (!(0, fs_extra_1.pathExistsSync)(sourcePath)) {
+        else if (!(0, fs_extra_1.pathExistsSync)(sourcePath)) {
             console.error(`Cannot find ${path} in your compiled Next.js application.`);
             return;
         }
-        await (0, promises_1.mkdir)((0, path_1.dirname)(destPath), { recursive: true });
-        await (0, promises_1.copyFile)(sourcePath, destPath);
+        if (localizedDestPath) {
+            await (0, promises_1.mkdir)((0, path_1.dirname)(localizedDestPath), { recursive: true });
+            await (0, promises_1.copyFile)(sourcePath, localizedDestPath);
+        }
+        if (defaultDestPath) {
+            await (0, promises_1.mkdir)((0, path_1.dirname)(defaultDestPath), { recursive: true });
+            await (0, promises_1.copyFile)(sourcePath, defaultDestPath);
+        }
         if (route.dataRoute && !appPathRoute) {
-            const dataSourcePath = `${(0, path_1.join)(...partsOrIndex)}.json`;
-            const dataDestPath = (0, path_1.join)(destDir, route.dataRoute);
+            const dataSourcePath = `${(0, path_1.join)(...sourcePartsOrIndex)}.json`;
+            const dataDestPath = (0, path_1.join)(destDir, basePath, route.dataRoute);
             await (0, promises_1.mkdir)((0, path_1.dirname)(dataDestPath), { recursive: true });
             await (0, promises_1.copyFile)((0, path_1.join)(contentDist, dataSourcePath), dataDestPath);
         }
@@ -249,7 +293,7 @@ async function ɵcodegenPublicDirectory(sourceDir, destDir) {
 exports.ɵcodegenPublicDirectory = ɵcodegenPublicDirectory;
 const BUNDLE_NEXT_CONFIG_TIMEOUT = 10000;
 async function ɵcodegenFunctionsDirectory(sourceDir, destDir) {
-    const { distDir } = await getConfig(sourceDir);
+    const { distDir, basePath } = await getConfig(sourceDir);
     const packageJson = await (0, utils_1.readJSON)((0, path_1.join)(sourceDir, "package.json"));
     if ((0, fs_1.existsSync)((0, path_1.join)(sourceDir, "next.config.js"))) {
         try {
@@ -297,11 +341,11 @@ async function ɵcodegenFunctionsDirectory(sourceDir, destDir) {
     }
     if (!(await (0, utils_2.hasUnoptimizedImage)(sourceDir, distDir)) &&
         ((0, utils_2.usesAppDirRouter)(sourceDir) || (await (0, utils_2.usesNextImage)(sourceDir, distDir)))) {
-        packageJson.dependencies["sharp"] = "latest";
+        packageJson.dependencies["sharp"] = constants_1.SHARP_VERSION;
     }
     await (0, fs_extra_1.mkdirp)((0, path_1.join)(destDir, distDir));
     await (0, fs_extra_1.copy)((0, path_1.join)(sourceDir, distDir), (0, path_1.join)(destDir, distDir));
-    return { packageJson, frameworksEntry: "next.js" };
+    return { packageJson, frameworksEntry: "next.js", basePath };
 }
 exports.ɵcodegenFunctionsDirectory = ɵcodegenFunctionsDirectory;
 async function getDevModeHandle(dir, hostingEmulatorInfo) {
@@ -329,6 +373,7 @@ async function getDevModeHandle(dir, hostingEmulatorInfo) {
 exports.getDevModeHandle = getDevModeHandle;
 async function getConfig(dir) {
     var _a;
+    var _b;
     let config = {};
     if ((0, fs_1.existsSync)((0, path_1.join)(dir, "next.config.js"))) {
         const version = getNextVersion(dir);
@@ -348,5 +393,6 @@ async function getConfig(dir) {
             }
         }
     }
-    return Object.assign({ distDir: ".next", trailingSlash: false }, config);
+    (0, utils_1.validateLocales)((_b = config.i18n) === null || _b === void 0 ? void 0 : _b.locales);
+    return Object.assign({ distDir: ".next", trailingSlash: false, basePath: "/" }, config);
 }

package/lib/frameworks/next/utils.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getBuildId = exports.getHeadersFromMetaFiles = exports.getNonStaticServerComponents = exports.getNonStaticRoutes = exports.getMiddlewareMatcherRegexes = exports.allDependencyNames = exports.isUsingAppDirectory = exports.isUsingImageOptimization = exports.isUsingMiddleware = exports.hasUnoptimizedImage = exports.usesNextImage = exports.usesAppDirRouter = exports.getNextjsRewritesToUse = exports.isHeaderSupportedByHosting = exports.isRedirectSupportedByHosting = exports.isRewriteSupportedByHosting = exports.cleanEscapedChars = exports.pathHasRegex = void 0;
+exports.getBuildId = exports.getHeadersFromMetaFiles = exports.getNonStaticServerComponents = exports.getNonStaticRoutes = exports.getMiddlewareMatcherRegexes = exports.allDependencyNames = exports.isUsingAppDirectory = exports.isUsingImageOptimization = exports.isUsingMiddleware = exports.hasUnoptimizedImage = exports.usesNextImage = exports.usesAppDirRouter = exports.getNextjsRewritesToUse = exports.isHeaderSupportedByHosting = exports.isRedirectSupportedByHosting = exports.isRewriteSupportedByHosting = exports.cleanI18n = exports.cleanCustomRouteI18n = exports.cleanEscapedChars = exports.I18N_SOURCE = void 0;
 const fs_1 = require("fs");
 const fs_extra_1 = require("fs-extra");
 const path_1 = require("path");
@@ -8,32 +8,49 @@ const utils_1 = require("../utils");
 const constants_1 = require("./constants");
 const fsutils_1 = require("../../fsutils");
 const promises_1 = require("fs/promises");
-function pathHasRegex(path) {
-    return /(?<!\\)\(/.test(path);
-}
-exports.pathHasRegex = pathHasRegex;
+exports.I18N_SOURCE = /\/:nextInternalLocale(\([^\)]+\))?/;
 function cleanEscapedChars(path) {
     return path.replace(/\\([(){}:+?*])/g, (a, b) => b);
 }
 exports.cleanEscapedChars = cleanEscapedChars;
+function cleanCustomRouteI18n(path) {
+    return path.replace(exports.I18N_SOURCE, "");
+}
+exports.cleanCustomRouteI18n = cleanCustomRouteI18n;
+function cleanI18n(it) {
+    const [, localesRegex] = it.source.match(exports.I18N_SOURCE) || [undefined, undefined];
+    const source = localesRegex ? cleanCustomRouteI18n(it.source) : it.source;
+    const destination = "destination" in it && localesRegex ? cleanCustomRouteI18n(it.destination) : it.destination;
+    const regex = "regex" in it && localesRegex ? it.regex.replace(`(?:/${localesRegex})`, "") : it.regex;
+    return Object.assign(Object.assign({}, it), { source,
+        destination,
+        regex });
+}
+exports.cleanI18n = cleanI18n;
 function isRewriteSupportedByHosting(rewrite) {
-    return !("has" in rewrite || pathHasRegex(rewrite.source) || (0, utils_1.isUrl)(rewrite.destination));
+    return !("has" in rewrite ||
+        "missing" in rewrite ||
+        (0, utils_1.isUrl)(rewrite.destination) ||
+        rewrite.destination.includes("?"));
 }
 exports.isRewriteSupportedByHosting = isRewriteSupportedByHosting;
 function isRedirectSupportedByHosting(redirect) {
-    return !("has" in redirect || pathHasRegex(redirect.source) || "internal" in redirect);
+    return !("has" in redirect ||
+        "missing" in redirect ||
+        "internal" in redirect ||
+        redirect.destination.includes("?"));
 }
 exports.isRedirectSupportedByHosting = isRedirectSupportedByHosting;
 function isHeaderSupportedByHosting(header) {
-    return !("has" in header || pathHasRegex(header.source));
+    return !("has" in header || "missing" in header);
 }
 exports.isHeaderSupportedByHosting = isHeaderSupportedByHosting;
 function getNextjsRewritesToUse(nextJsRewrites) {
     if (Array.isArray(nextJsRewrites)) {
-        return nextJsRewrites;
+        return nextJsRewrites.map(cleanI18n);
     }
     if (nextJsRewrites === null || nextJsRewrites === void 0 ? void 0 : nextJsRewrites.beforeFiles) {
-        return nextJsRewrites.beforeFiles;
+        return nextJsRewrites.beforeFiles.map(cleanI18n);
     }
     return [];
 }
@@ -129,7 +146,7 @@ function getNonStaticServerComponents(appPathsManifest, appPathRoutesManifest, p
     return nonStaticServerComponents;
 }
 exports.getNonStaticServerComponents = getNonStaticServerComponents;
-async function getHeadersFromMetaFiles(sourceDir, distDir, appPathRoutesManifest) {
+async function getHeadersFromMetaFiles(sourceDir, distDir, basePath, appPathRoutesManifest) {
     const headers = [];
     await Promise.all(Object.entries(appPathRoutesManifest).map(async ([key, source]) => {
         if ((0, path_1.basename)(key) !== "route")
@@ -142,7 +159,7 @@ async function getHeadersFromMetaFiles(sourceDir, distDir, appPathRoutesManifest
             const meta = await (0, utils_1.readJSON)(metadataPath);
             if (meta.headers)
                 headers.push({
-                    source,
+                    source: path_1.posix.join(basePath, source),
                     headers: Object.entries(meta.headers).map(([key, value]) => ({ key, value })),
                 });
         }

package/lib/frameworks/utils.js

@@ -1,11 +1,11 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.frameworksCallToAction = exports.conjoinOptions = exports.relativeRequire = exports.findDependency = exports.getNodeModuleBin = exports.getNpmRoot = exports.simpleProxy = exports.warnIfCustomBuildScript = exports.readJSON = exports.isUrl = void 0;
+exports.validateLocales = exports.frameworksCallToAction = exports.conjoinOptions = exports.relativeRequire = exports.findDependency = exports.getNodeModuleBin = exports.getNpmRoot = exports.simpleProxy = exports.warnIfCustomBuildScript = exports.readJSON = exports.isUrl = void 0;
 const fs_extra_1 = require("fs-extra");
 const path_1 = require("path");
 const promises_1 = require("fs/promises");
 const http_1 = require("http");
-const child_process_1 = require("child_process");
+const cross_spawn_1 = require("cross-spawn");
 const clc = require("colorette");
 const logger_1 = require("../logger");
 const error_1 = require("../error");
@@ -87,7 +87,7 @@ function scanDependencyTree(searchingFor, dependencies = {}) {
 }
 function getNpmRoot(cwd) {
     var _a;
-    return (_a = (0, child_process_1.spawnSync)("npm", ["root"], { cwd, timeout: NPM_ROOT_TIMEOUT_MILLIES })
+    return (_a = (0, cross_spawn_1.sync)("npm", ["root"], { cwd, timeout: NPM_ROOT_TIMEOUT_MILLIES })
         .stdout) === null || _a === void 0 ? void 0 : _a.toString().trim();
 }
 exports.getNpmRoot = getNpmRoot;
@@ -115,7 +115,7 @@ function findDependency(name, options = {}) {
         return;
     const env = Object.assign({}, process.env);
     delete env.NODE_ENV;
-    const result = (0, child_process_1.spawnSync)("npm", [
+    const result = (0, cross_spawn_1.sync)("npm", [
         "list",
         name,
         "--json=true",
@@ -167,3 +167,10 @@ ${prefix}${clc.bold("Submit a feature request:")} ${constants_1.FEATURE_REQUEST_
 ${prefix}We'd love to learn from you. Express your interest in helping us shape the future of Firebase Hosting: ${constants_1.MAILING_LIST_URL}`;
 }
 exports.frameworksCallToAction = frameworksCallToAction;
+function validateLocales(locales = []) {
+    const invalidLocales = locales.filter((locale) => !constants_1.VALID_LOCALE_FORMATS.some((format) => locale.match(format)));
+    if (invalidLocales.length) {
+        throw new error_1.FirebaseError(`Invalid i18n locales (${invalidLocales.join(", ")}) for Firebase. See our docs for more information https://firebase.google.com/docs/hosting/i18n-rewrites#country-and-language-codes`);
+    }
+}
+exports.validateLocales = validateLocales;

package/lib/functions/python.js

@@ -7,9 +7,9 @@ const logger_1 = require("../logger");
 exports.DEFAULT_VENV_DIR = "venv";
 function virtualEnvCmd(cwd, venvDir) {
     const activateScriptPath = process.platform === "win32" ? ["Scripts", "activate.bat"] : ["bin", "activate"];
-    const venvActivate = path.join(cwd, venvDir, ...activateScriptPath);
+    const venvActivate = `"${path.join(cwd, venvDir, ...activateScriptPath)}"`;
     return {
-        command: process.platform === "win32" ? venvActivate : "source",
+        command: process.platform === "win32" ? venvActivate : ".",
         args: [process.platform === "win32" ? "" : venvActivate],
     };
 }

package/lib/hosting/api.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.cleanAuthState = exports.getCleanDomains = exports.removeAuthDomain = exports.addAuthDomains = exports.deleteSite = exports.updateSite = exports.createSite = exports.getSite = exports.listSites = exports.createRelease = exports.cloneVersion = exports.listVersions = exports.updateVersion = exports.createVersion = exports.deleteChannel = exports.updateChannelTtl = exports.createChannel = exports.listChannels = exports.getChannel = exports.normalizeName = void 0;
+exports.getAllSiteDomains = exports.getSiteDomains = exports.cleanAuthState = exports.getCleanDomains = exports.removeAuthDomain = exports.addAuthDomains = exports.deleteSite = exports.updateSite = exports.createSite = exports.getSite = exports.listSites = exports.createRelease = exports.cloneVersion = exports.listVersions = exports.updateVersion = exports.createVersion = exports.deleteChannel = exports.updateChannelTtl = exports.createChannel = exports.listChannels = exports.getChannel = exports.normalizeName = void 0;
 const error_1 = require("../error");
 const api_1 = require("../api");
 const apiv2_1 = require("../apiv2");
@@ -246,3 +246,34 @@ async function cleanAuthState(project, sites) {
     return siteDomainMap;
 }
 exports.cleanAuthState = cleanAuthState;
+async function getSiteDomains(project, site) {
+    var _a;
+    try {
+        const res = await apiClient.get(`/projects/${project}/sites/${site}/domains`);
+        return (_a = res.body.domains) !== null && _a !== void 0 ? _a : [];
+    }
+    catch (e) {
+        if (e instanceof error_1.FirebaseError && e.status === 404) {
+            throw new error_1.FirebaseError(`could not find site "${site}" for project "${project}"`, {
+                original: e,
+            });
+        }
+        throw e;
+    }
+}
+exports.getSiteDomains = getSiteDomains;
+async function getAllSiteDomains(projectId, siteId) {
+    const [hostingDomains, defaultDomain] = await Promise.all([
+        getSiteDomains(projectId, siteId),
+        getSite(projectId, siteId),
+    ]);
+    const defaultDomainWithoutHttp = defaultDomain.defaultUrl.replace(/^https?:\/\//, "");
+    const allSiteDomains = new Set([
+        ...hostingDomains.map(({ domainName }) => domainName),
+        defaultDomainWithoutHttp,
+        `${siteId}.web.app`,
+        `${siteId}.firebaseapp.com`,
+    ]);
+    return Array.from(allSiteDomains);
+}
+exports.getAllSiteDomains = getAllSiteDomains;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "firebase-tools",
-  "version": "11.30.0",
+  "version": "12.0.1",
   "description": "Command-Line Interface for Firebase",
   "main": "./lib/index.js",
   "bin": {
@@ -29,7 +29,7 @@
   ],
   "preferGlobal": true,
   "engines": {
-    "node": "^14.18.0 || >=16.4.0"
+    "node": ">=16.13.0 || >=18.0.0"
   },
   "author": "Firebase (https://firebase.google.com/)",
   "license": "MIT",