firebase-tools 11.29.1 → 12.0.0

package/lib/extensions/extensionsHelper.js

@@ -1,15 +1,15 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.canonicalizeRefInput = exports.diagnoseAndFixProject = exports.getSourceOrigin = exports.isLocalOrURLPath = exports.isLocalPath = exports.isUrlPath = exports.instanceIdExists = exports.promptForRepeatInstance = exports.promptForOfficialExtension = exports.displayReleaseNotes = exports.getPublisherProjectFromName = exports.createSourceFromLocation = exports.publishExtensionVersionFromLocalSource = exports.publishExtensionVersionFromRemoteRepo = exports.incrementPrereleaseVersion = exports.ensureExtensionsApiEnabled = exports.promptForValidRepoURI = exports.promptForValidInstanceId = exports.validateSpec = exports.validateCommandLineParams = exports.populateDefaultParams = exports.substituteParams = exports.getFirebaseProjectParams = exports.getDBInstanceFromURL = exports.resourceTypeToNiceName = exports.AUTOPOULATED_PARAM_PLACEHOLDERS = exports.EXTENSIONS_BUCKET_NAME = exports.URL_REGEX = exports.logPrefix = exports.SourceOrigin = exports.SpecParamType = void 0;
+exports.canonicalizeRefInput = exports.diagnoseAndFixProject = exports.getSourceOrigin = exports.isLocalOrURLPath = exports.isLocalPath = exports.isUrlPath = exports.instanceIdExists = exports.promptForRepeatInstance = exports.promptForOfficialExtension = exports.displayReleaseNotes = exports.getPublisherProjectFromName = exports.createSourceFromLocation = exports.getMissingPublisherError = exports.uploadExtensionVersionFromLocalSource = exports.uploadExtensionVersionFromGitHubSource = exports.unpackExtensionState = exports.getNextVersionByStage = exports.ensureExtensionsPublisherApiEnabled = exports.ensureExtensionsApiEnabled = exports.promptForValidExtensionRoot = exports.promptForValidRepoURI = exports.promptForValidInstanceId = exports.validateSpec = exports.validateCommandLineParams = exports.populateDefaultParams = exports.substituteParams = exports.getFirebaseProjectParams = exports.getDBInstanceFromURL = exports.resourceTypeToNiceName = exports.AUTOPOULATED_PARAM_PLACEHOLDERS = exports.EXTENSIONS_BUCKET_NAME = exports.URL_REGEX = exports.logPrefix = exports.SourceOrigin = exports.SpecParamType = void 0;
 const clc = require("colorette");
 const ora = require("ora");
 const semver = require("semver");
 const tmp = require("tmp");
 const fs = require("fs-extra");
-const unzipper = require("unzipper");
 const node_fetch_1 = require("node-fetch");
 const path = require("path");
 const marked_1 = require("marked");
+const unzip_1 = require("./../unzip");
 const TerminalRenderer = require("marked-terminal");
 marked_1.marked.setOptions({
     renderer: new TerminalRenderer(),
@@ -27,6 +27,7 @@ const ensureApiEnabled_1 = require("../ensureApiEnabled");
 const storage_1 = require("../gcp/storage");
 const projectUtils_1 = require("../projectUtils");
 const extensionsApi_1 = require("./extensionsApi");
+const publisherApi_1 = require("./publisherApi");
 const refs = require("./refs");
 const localHelper_1 = require("./localHelper");
 const prompt_1 = require("../prompt");
@@ -75,7 +76,7 @@ exports.resourceTypeToNiceName = {
     "firebaseextensions.v1beta.function": "Cloud Function",
 };
 const repoRegex = new RegExp(`^https:\/\/github\.com\/[^\/]+\/[^\/]+$`);
-const stageOptions = ["alpha", "beta", "rc", "stable"];
+const stageOptions = ["rc", "alpha", "beta", "stable"];
 function getDBInstanceFromURL(databaseUrl = "") {
     const instanceRegex = new RegExp("(?:https://)(.*)(?:.firebaseio.com)");
     const matches = instanceRegex.exec(databaseUrl);
@@ -175,6 +176,15 @@ function validateSpec(spec) {
     if (!spec.version) {
         errors.push("extension.yaml is missing required field: version");
     }
+    else if (!semver.valid(spec.version)) {
+        errors.push(`version ${spec.version} in extension.yaml is not a valid semver`);
+    }
+    else {
+        const version = semver.parse(spec.version);
+        if (version.prerelease.length > 0 || version.build.length > 0) {
+            errors.push("version field in extension.yaml does not support pre-release annotations; instead, set a pre-release stage using the --stage flag");
+        }
+    }
     if (!spec.license) {
         errors.push("extension.yaml is missing required field: license");
     }
@@ -279,7 +289,7 @@ async function promptForValidRepoURI() {
     while (!repoIsValid) {
         extensionRoot = await (0, prompt_1.promptOnce)({
             type: "input",
-            message: "Enter the GitHub repo URI where this Extension's source code is located:",
+            message: "Enter the GitHub repo URI where this extension's source code is located:",
         });
         if (!repoRegex.test(extensionRoot)) {
             logger_1.logger.info("Repo URI must follow this format: https://github.com/<user>/<repo>");
@@ -291,6 +301,60 @@ async function promptForValidRepoURI() {
     return extensionRoot;
 }
 exports.promptForValidRepoURI = promptForValidRepoURI;
+async function promptForValidExtensionRoot(defaultRoot) {
+    let rootIsValid = false;
+    let extensionRoot = "";
+    while (!rootIsValid) {
+        extensionRoot = await (0, prompt_1.promptOnce)({
+            type: "input",
+            message: "Enter this extension's root directory in the repo (defaults to previous root if set):",
+            default: defaultRoot,
+        });
+        rootIsValid = true;
+    }
+    return extensionRoot;
+}
+exports.promptForValidExtensionRoot = promptForValidExtensionRoot;
+async function promptForReleaseStage(args) {
+    let stage = "rc";
+    if (!args.nonInteractive) {
+        const choices = [
+            { name: `Release candidate (${args.versionByStage.get("rc")})`, value: "rc" },
+            { name: `Alpha (${args.versionByStage.get("alpha")})`, value: "alpha" },
+            { name: `Beta (${args.versionByStage.get("beta")})`, value: "beta" },
+        ];
+        if (args.allowStable) {
+            const stableChoice = {
+                name: `Stable (${args.versionByStage.get("stable")}${args.autoReview ? ", automatically sent for review" : ""})`,
+                value: "stable",
+            };
+            choices.push(stableChoice);
+        }
+        stage = await (0, prompt_1.promptOnce)({
+            type: "list",
+            message: "Choose the release stage:",
+            choices: choices,
+            default: stage,
+        });
+        if (stage === "stable" && !args.hasVersions) {
+            logger_1.logger.info(`${clc.bold(clc.yellow("Warning:"))} It's highly recommended to first upload a pre-release version before choosing stable.`);
+            const confirmed = await (0, prompt_1.confirm)({
+                nonInteractive: args.nonInteractive,
+                force: args.force,
+                default: false,
+            });
+            if (!confirmed) {
+                stage = await (0, prompt_1.promptOnce)({
+                    type: "list",
+                    message: "Choose the release stage:",
+                    choices: choices,
+                    default: stage,
+                });
+            }
+        }
+    }
+    return stage;
+}
 async function ensureExtensionsApiEnabled(options) {
     const projectId = (0, projectUtils_1.getProjectId)(options);
     if (!projectId) {
@@ -299,6 +363,14 @@ async function ensureExtensionsApiEnabled(options) {
     return await (0, ensureApiEnabled_1.ensure)(projectId, "firebaseextensions.googleapis.com", "extensions", options.markdown);
 }
 exports.ensureExtensionsApiEnabled = ensureExtensionsApiEnabled;
+async function ensureExtensionsPublisherApiEnabled(options) {
+    const projectId = (0, projectUtils_1.getProjectId)(options);
+    if (!projectId) {
+        return;
+    }
+    return await (0, ensureApiEnabled_1.ensure)(projectId, "firebaseextensionspublisher.googleapis.com", "extensions", options.markdown);
+}
+exports.ensureExtensionsPublisherApiEnabled = ensureExtensionsPublisherApiEnabled;
 async function archiveAndUploadSource(extPath, bucketName) {
     const zippedSource = await (0, archiveDirectory_1.archiveDirectory)(extPath, {
         type: "zip",
@@ -307,75 +379,150 @@ async function archiveAndUploadSource(extPath, bucketName) {
     const res = await (0, storage_1.uploadObject)(zippedSource, bucketName);
     return `/${res.bucket}/${res.object}`;
 }
-async function incrementPrereleaseVersion(ref, extensionVersion, stage) {
-    var _a;
-    if (!stageOptions.includes(stage)) {
-        throw new error_1.FirebaseError(`--stage flag only supports the following values: ${stageOptions}`);
+async function getNextVersionByStage(extensionRef, newVersion) {
+    let extensionVersions = [];
+    try {
+        extensionVersions = await (0, publisherApi_1.listExtensionVersions)(extensionRef, `id="${newVersion}"`, true);
     }
-    if (stage !== "stable") {
-        const version = semver.parse(extensionVersion);
-        if (version.prerelease.length > 0 || version.build.length > 0) {
-            throw new error_1.FirebaseError(`Cannot combine the --stage flag with a version with a prerelease annotation in extension.yaml.`);
-        }
-        let extensionVersions = [];
-        try {
-            extensionVersions = await (0, extensionsApi_1.listExtensionVersions)(ref, `id="${version.version}"`, true);
+    catch (err) {
+    }
+    const versionByStage = new Map(["rc", "alpha", "beta"].map((stage) => [
+        stage,
+        semver.inc(`${newVersion}-${stage}`, "prerelease", undefined, stage),
+    ]));
+    for (const extensionVersion of extensionVersions) {
+        const version = semver.parse(extensionVersion.spec.version);
+        if (!version.prerelease.length) {
+            continue;
         }
-        catch (e) {
+        const prerelease = semver.prerelease(version)[0];
+        const stage = prerelease.split(".")[0];
+        if (versionByStage.has(stage) && semver.gte(version, versionByStage.get(stage))) {
+            versionByStage.set(stage, semver.inc(version, "prerelease", undefined, stage));
         }
-        const latestVersion = (_a = extensionVersions
-            .map((version) => semver.parse(version.spec.version))
-            .filter((version) => version.prerelease.length > 0 && version.prerelease[0] === stage)
-            .sort((v1, v2) => semver.compare(v1, v2))
-            .pop()) !== null && _a !== void 0 ? _a : `${version}-${stage}`;
-        return semver.inc(latestVersion, "prerelease", undefined, stage);
     }
-    return extensionVersion;
+    versionByStage.set("stable", newVersion);
+    return { versionByStage, hasVersions: extensionVersions.length > 0 };
 }
-exports.incrementPrereleaseVersion = incrementPrereleaseVersion;
-async function validateExtensionSpec(args) {
-    const extensionRef = `${args.publisherId}/${args.extensionId}`;
-    const extensionSpec = await (0, localHelper_1.getLocalExtensionSpec)(args.rootDirectory);
-    if (extensionSpec.name !== args.extensionId) {
-        throw new error_1.FirebaseError(`Extension ID '${clc.bold(args.extensionId)}' does not match the name in extension.yaml '${clc.bold(extensionSpec.name)}'.`);
+exports.getNextVersionByStage = getNextVersionByStage;
+async function validateExtensionSpec(rootDirectory, extensionId) {
+    const extensionSpec = await (0, localHelper_1.getLocalExtensionSpec)(rootDirectory);
+    if (extensionSpec.name !== extensionId) {
+        throw new error_1.FirebaseError(`Extension ID '${clc.bold(extensionId)}' does not match the name in extension.yaml '${clc.bold(extensionSpec.name)}'.`);
     }
     const subbedSpec = JSON.parse(JSON.stringify(extensionSpec));
     subbedSpec.params = substituteParams(extensionSpec.params || [], exports.AUTOPOULATED_PARAM_PLACEHOLDERS);
     validateSpec(subbedSpec);
-    extensionSpec.version = await incrementPrereleaseVersion(extensionRef, extensionSpec.version, args.stage);
+    return extensionSpec;
+}
+function validateReleaseNotes(rootDirectory, newVersion, extension) {
     let notes;
     try {
-        const changes = (0, change_log_1.getLocalChangelog)(args.rootDirectory);
-        notes = changes[extensionSpec.version];
+        const changes = (0, change_log_1.getLocalChangelog)(rootDirectory);
+        notes = changes[newVersion];
     }
     catch (err) {
         throw new error_1.FirebaseError("No CHANGELOG.md file found. " +
             "Please create one and add an entry for this version. " +
-            (0, marked_1.marked)("See https://firebase.google.com/docs/extensions/alpha/create-user-docs#writing-changelog for more details."));
+            (0, marked_1.marked)("See https://firebase.google.com/docs/extensions/publishers/user-documentation#writing-changelog for more details."));
     }
-    if (!notes && !semver.prerelease(extensionSpec.version) && args.latestVersion) {
-        throw new error_1.FirebaseError(`No entry for version ${extensionSpec.version} found in CHANGELOG.md. ` +
+    if (!notes && !semver.prerelease(newVersion) && extension) {
+        throw new error_1.FirebaseError(`No entry for version ${newVersion} found in CHANGELOG.md. ` +
             "Please add one so users know what has changed in this version. " +
-            (0, marked_1.marked)("See https://firebase.google.com/docs/extensions/alpha/create-user-docs#writing-changelog for more details."));
+            (0, marked_1.marked)("See https://firebase.google.com/docs/extensions/publishers/user-documentation#writing-changelog for more details."));
     }
-    if (args.latestVersion) {
-        if (semver.lt(extensionSpec.version, args.latestVersion)) {
-            throw new error_1.FirebaseError(`The version you are trying to publish (${clc.bold(extensionSpec.version)}) is lower than the current version (${clc.bold(args.latestVersion)}) for the extension '${clc.bold(extensionRef)}'. Please make sure this version is greater than the current version (${clc.bold(args.latestVersion)}) inside of extension.yaml.\n`, { exit: 104 });
+    return notes;
+}
+function validateVersion(extensionRef, newVersion, latestVersion) {
+    if (latestVersion) {
+        if (semver.lt(newVersion, latestVersion)) {
+            throw new error_1.FirebaseError(`The version you are trying to publish (${clc.bold(newVersion)}) is lower than the current version (${clc.bold(latestVersion)}) for the extension '${clc.bold(extensionRef)}'. Make sure this version is greater than the current version (${clc.bold(latestVersion)}) inside of extension.yaml and try again.\n`, { exit: 104 });
         }
-        else if (semver.eq(extensionSpec.version, args.latestVersion)) {
-            throw new error_1.FirebaseError(`The version you are trying to publish (${clc.bold(extensionSpec.version)}) already exists for Extension '${clc.bold(extensionRef)}'. Please increment the version inside of extension.yaml.\n`, { exit: 103 });
+        else if (semver.eq(newVersion, latestVersion)) {
+            throw new error_1.FirebaseError(`The version you are trying to upload (${clc.bold(newVersion)}) already exists for extension '${clc.bold(extensionRef)}'. Increment the version inside of extension.yaml and try again.\n`, { exit: 103 });
         }
     }
-    return { extensionSpec, notes };
 }
-async function publishExtensionVersionFromRemoteRepo(args) {
+function unpackExtensionState(extension) {
+    switch (extension.state) {
+        case "PUBLISHED":
+            if (extension.latestApprovedVersion) {
+                return clc.bold(clc.green("Published"));
+            }
+            else if (extension.latestVersion) {
+                return clc.green("Uploaded");
+            }
+            else {
+                return "Prerelease";
+            }
+        case "DEPRECATED":
+            return clc.red("Deprecated");
+        case "SUSPENDED":
+            return clc.bold(clc.red("Suspended"));
+        default:
+            return "-";
+    }
+}
+exports.unpackExtensionState = unpackExtensionState;
+function displayExtensionHeader(extensionRef, extension, extensionRoot) {
+    var _a, _b;
+    if (extension) {
+        let source = "Local source";
+        if (extension.repoUri) {
+            const uri = new URL(extension.repoUri);
+            uri.pathname = path.join(uri.pathname, extensionRoot !== null && extensionRoot !== void 0 ? extensionRoot : "");
+            source = `${uri.toString()} (use --repo and --root to modify)`;
+        }
+        logger_1.logger.info(`\n${clc.bold("Extension:")} ${extension.ref}\n` +
+            `${clc.bold("State:")} ${unpackExtensionState(extension)}\n` +
+            `${clc.bold("Latest Version:")} ${(_a = extension.latestVersion) !== null && _a !== void 0 ? _a : "-"}\n` +
+            `${clc.bold("Version in Extensions Hub:")} ${(_b = extension.latestApprovedVersion) !== null && _b !== void 0 ? _b : "-"}\n` +
+            `${clc.bold("Source in GitHub:")} ${source}\n`);
+    }
+    else {
+        logger_1.logger.info(`\n${clc.bold("Extension:")} ${extensionRef}\n` +
+            `${clc.bold("State:")} ${clc.bold(clc.blue("New"))}\n`);
+    }
+}
+async function fetchExtensionSource(repoUri, sourceRef, extensionRoot) {
+    const sourceUri = repoUri + path.join("/tree", sourceRef, extensionRoot);
+    logger_1.logger.info(`Validating source code at ${clc.bold(sourceUri)}...`);
+    const archiveUri = `${repoUri}/archive/${sourceRef}.zip`;
+    const tempDirectory = tmp.dirSync({ unsafeCleanup: true });
+    try {
+        const response = await (0, node_fetch_1.default)(archiveUri);
+        if (response.ok) {
+            await response.body.pipe((0, unzip_1.createUnzipTransform)(tempDirectory.name)).promise();
+        }
+    }
+    catch (err) {
+        throw new error_1.FirebaseError(`Failed to fetch extension archive from ${archiveUri}. Please check the repo URI and source ref. ${err}`);
+    }
+    const archiveName = fs.readdirSync(tempDirectory.name)[0];
+    const rootDirectory = path.join(tempDirectory.name, archiveName, extensionRoot);
+    try {
+        (0, localHelper_1.readFile)(path.resolve(rootDirectory, localHelper_1.EXTENSIONS_SPEC_FILE));
+    }
+    catch (err) {
+        throw new error_1.FirebaseError(`Failed to find ${clc.bold(localHelper_1.EXTENSIONS_SPEC_FILE)} in directory ${clc.bold(extensionRoot)}. Please verify the root and try again.`);
+    }
+    return rootDirectory;
+}
+async function uploadExtensionVersionFromGitHubSource(args) {
+    var _a, _b, _c;
     const extensionRef = `${args.publisherId}/${args.extensionId}`;
     let extension;
+    let latestVersion;
     try {
-        extension = await (0, extensionsApi_1.getExtension)(extensionRef);
+        extension = await (0, publisherApi_1.getExtension)(extensionRef);
+        latestVersion = await (0, publisherApi_1.getExtensionVersion)(`${extensionRef}@latest`);
     }
     catch (err) {
     }
+    displayExtensionHeader(extensionRef, extension, latestVersion === null || latestVersion === void 0 ? void 0 : latestVersion.extensionRoot);
+    if (args.stage && !stageOptions.includes(args.stage)) {
+        throw new error_1.FirebaseError(`--stage only supports the following values: ${stageOptions.join(", ")}`);
+    }
     if (args.repoUri && !repoRegex.test(args.repoUri)) {
         throw new error_1.FirebaseError("Repo URI must follow this format: https://github.com/<user>/<repo>");
     }
@@ -388,30 +535,14 @@ async function publishExtensionVersionFromRemoteRepo(args) {
             throw new error_1.FirebaseError("Repo URI is required but not currently set.");
         }
     }
-    if (extension === null || extension === void 0 ? void 0 : extension.repoUri) {
-        logger_1.logger.info(`Extension ${clc.bold(extensionRef)} is published from ${clc.bold(extension === null || extension === void 0 ? void 0 : extension.repoUri)}. Use --repo to change this repo.`);
-    }
-    let extensionRoot = args.extensionRoot;
-    let defaultRoot = "/";
+    let extensionRoot = args.extensionRoot || (latestVersion === null || latestVersion === void 0 ? void 0 : latestVersion.extensionRoot);
     if (!extensionRoot) {
-        if (extension) {
-            try {
-                const extensionVersionRef = `${extensionRef}@${extension.latestVersion}`;
-                const extensionVersion = await (0, extensionsApi_1.getExtensionVersion)(extensionVersionRef);
-                if (extensionVersion.extensionRoot) {
-                    defaultRoot = extensionVersion.extensionRoot;
-                }
-            }
-            catch (err) {
-            }
-        }
-        extensionRoot = defaultRoot;
+        const defaultRoot = "/";
         if (!args.nonInteractive) {
-            extensionRoot = await (0, prompt_1.promptOnce)({
-                type: "input",
-                message: "Enter this Extension's root directory in the repo (defaults to previous root if set):",
-                default: defaultRoot,
-            });
+            extensionRoot = await promptForValidExtensionRoot(defaultRoot);
+        }
+        else {
+            extensionRoot = defaultRoot;
         }
     }
     let sourceRef = args.sourceRef;
@@ -428,50 +559,35 @@ async function publishExtensionVersionFromRemoteRepo(args) {
             sourceRef = defaultSourceRef;
         }
     }
+    const rootDirectory = await fetchExtensionSource(repoUri, sourceRef, extensionRoot);
+    const extensionSpec = await validateExtensionSpec(rootDirectory, args.extensionId);
+    validateVersion(extensionRef, extensionSpec.version, extension === null || extension === void 0 ? void 0 : extension.latestVersion);
+    const { versionByStage, hasVersions } = await getNextVersionByStage(extensionRef, extensionSpec.version);
+    const autoReview = !!(extension === null || extension === void 0 ? void 0 : extension.latestApprovedVersion) ||
+        ((_a = latestVersion === null || latestVersion === void 0 ? void 0 : latestVersion.listing) === null || _a === void 0 ? void 0 : _a.state) === "PENDING" ||
+        ((_b = latestVersion === null || latestVersion === void 0 ? void 0 : latestVersion.listing) === null || _b === void 0 ? void 0 : _b.state) === "APPROVED" ||
+        ((_c = latestVersion === null || latestVersion === void 0 ? void 0 : latestVersion.listing) === null || _c === void 0 ? void 0 : _c.state) === "REJECTED";
     let stage = args.stage;
-    const defaultStage = "rc";
     if (!stage) {
-        if (!args.nonInteractive) {
-            stage = await (0, prompt_1.promptOnce)({
-                type: "list",
-                message: "Choose the release stage (pre-release annotations will be auto-incremented):",
-                choices: stageOptions,
-                default: defaultStage,
-            });
-        }
-        else {
-            stage = defaultStage;
-        }
-    }
-    logger_1.logger.info("Downloading and validating source code...");
-    const archiveUri = `${repoUri}/archive/${sourceRef}.zip`;
-    const tempDirectory = tmp.dirSync({ unsafeCleanup: true });
-    try {
-        const response = await (0, node_fetch_1.default)(archiveUri);
-        if (response.ok) {
-            await response.body.pipe(unzipper.Extract({ path: tempDirectory.name })).promise();
-        }
-    }
-    catch (err) {
-        throw new error_1.FirebaseError(`Failed to fetch Extension archive ${archiveUri}. Please check the repo URI and source ref. ${err}`);
-    }
-    const archiveName = fs.readdirSync(tempDirectory.name)[0];
-    const rootDirectory = path.join(tempDirectory.name, archiveName, extensionRoot);
-    try {
-        (0, localHelper_1.readFile)(path.resolve(rootDirectory, localHelper_1.EXTENSIONS_SPEC_FILE));
-    }
-    catch (err) {
-        throw new error_1.FirebaseError(`Failed to find ${clc.bold(localHelper_1.EXTENSIONS_SPEC_FILE)} in directory ${clc.bold(extensionRoot)}. Please verify the root and try again.`);
+        stage = await promptForReleaseStage({
+            versionByStage,
+            autoReview,
+            allowStable: true,
+            hasVersions,
+            nonInteractive: args.nonInteractive,
+            force: args.force,
+        });
     }
-    const { extensionSpec, notes } = await validateExtensionSpec({
-        publisherId: args.publisherId,
-        extensionId: args.extensionId,
-        rootDirectory: rootDirectory,
-        latestVersion: extension === null || extension === void 0 ? void 0 : extension.latestVersion,
-        stage: stage,
+    const newVersion = versionByStage.get(stage);
+    const releaseNotes = validateReleaseNotes(rootDirectory, extensionSpec.version, extension);
+    const sourceUri = repoUri + path.join("/tree", sourceRef, extensionRoot);
+    displayReleaseNotes({
+        extensionRef,
+        newVersion,
+        releaseNotes,
+        sourceUri,
+        autoReview: stage === "stable" && autoReview,
     });
-    const sourceUri = path.join(repoUri, "tree", sourceRef, extensionRoot);
-    displayReleaseNotes(extensionRef, extensionSpec.version, notes, sourceUri);
     const confirmed = await (0, prompt_1.confirm)({
         nonInteractive: args.nonInteractive,
         force: args.force,
@@ -480,22 +596,21 @@ async function publishExtensionVersionFromRemoteRepo(args) {
     if (!confirmed) {
         return;
     }
-    const extensionVersionRef = `${extensionRef}@${extensionSpec.version}`;
-    const publishSpinner = ora(`Publishing ${clc.bold(extensionVersionRef)}`);
+    const extensionVersionRef = `${extensionRef}@${newVersion}`;
+    const uploadSpinner = ora(`Uploading ${clc.bold(extensionVersionRef)}...`);
     let res;
     try {
-        publishSpinner.start();
-        res = await (0, extensionsApi_1.publishExtensionVersion)({
+        uploadSpinner.start();
+        res = await (0, publisherApi_1.createExtensionVersionFromGitHubSource)({
             extensionVersionRef,
-            packageUri: "",
             extensionRoot,
             repoUri,
-            sourceRef: args.sourceRef,
+            sourceRef: sourceRef,
         });
-        publishSpinner.succeed(` Successfully published ${clc.bold(extensionRef)}`);
+        uploadSpinner.succeed(`Successfully uploaded ${clc.bold(extensionRef)}`);
     }
     catch (err) {
-        publishSpinner.fail();
+        uploadSpinner.fail();
         if (err.status === 404) {
             throw getMissingPublisherError(args.publisherId);
         }
@@ -503,23 +618,44 @@ async function publishExtensionVersionFromRemoteRepo(args) {
     }
     return res;
 }
-exports.publishExtensionVersionFromRemoteRepo = publishExtensionVersionFromRemoteRepo;
-async function publishExtensionVersionFromLocalSource(args) {
+exports.uploadExtensionVersionFromGitHubSource = uploadExtensionVersionFromGitHubSource;
+async function uploadExtensionVersionFromLocalSource(args) {
+    const extensionRef = `${args.publisherId}/${args.extensionId}`;
     let extension;
+    let latestVersion;
     try {
-        extension = await (0, extensionsApi_1.getExtension)(`${args.publisherId}/${args.extensionId}`);
+        extension = await (0, publisherApi_1.getExtension)(extensionRef);
+        latestVersion = await (0, publisherApi_1.getExtensionVersion)(`${extensionRef}@latest`);
     }
     catch (err) {
     }
-    const { extensionSpec, notes } = await validateExtensionSpec({
-        publisherId: args.publisherId,
-        extensionId: args.extensionId,
-        rootDirectory: args.rootDirectory,
-        latestVersion: extension === null || extension === void 0 ? void 0 : extension.latestVersion,
-        stage: args.stage,
-    });
-    const extensionRef = `${args.publisherId}/${args.extensionId}`;
-    displayReleaseNotes(extensionRef, extensionSpec.version, notes);
+    displayExtensionHeader(extensionRef, extension, latestVersion === null || latestVersion === void 0 ? void 0 : latestVersion.extensionRoot);
+    const localStageOptions = ["rc", "alpha", "beta"];
+    if (args.stage && !localStageOptions.includes(args.stage)) {
+        throw new error_1.FirebaseError(`--stage only supports the following values when used with --local: ${localStageOptions.join(", ")}`);
+    }
+    const extensionSpec = await validateExtensionSpec(args.rootDirectory, args.extensionId);
+    validateVersion(extensionRef, extensionSpec.version, extension === null || extension === void 0 ? void 0 : extension.latestVersion);
+    const { versionByStage } = await getNextVersionByStage(extensionRef, extensionSpec.version);
+    let stage = args.stage;
+    if (!stage) {
+        if (!args.nonInteractive) {
+            stage = await promptForReleaseStage({
+                versionByStage,
+                autoReview: false,
+                allowStable: false,
+                hasVersions: false,
+                nonInteractive: args.nonInteractive,
+                force: args.force,
+            });
+        }
+        else {
+            stage = "rc";
+        }
+    }
+    const newVersion = versionByStage.get(stage);
+    const releaseNotes = validateReleaseNotes(args.rootDirectory, extensionSpec.version, extension);
+    displayReleaseNotes({ extensionRef, newVersion, releaseNotes, autoReview: false });
     const confirmed = await (0, prompt_1.confirm)({
         nonInteractive: args.nonInteractive,
         force: args.force,
@@ -528,28 +664,28 @@ async function publishExtensionVersionFromLocalSource(args) {
     if (!confirmed) {
         return;
     }
-    const extensionVersionRef = `${extensionRef}@${extensionSpec.version}`;
+    const extensionVersionRef = `${extensionRef}@${newVersion}`;
     let packageUri;
     let objectPath = "";
-    const uploadSpinner = ora(" Archiving and uploading extension source code");
+    const uploadSpinner = ora("Archiving and uploading extension source code...");
     try {
         uploadSpinner.start();
         objectPath = await archiveAndUploadSource(args.rootDirectory, exports.EXTENSIONS_BUCKET_NAME);
-        uploadSpinner.succeed(" Uploaded extension source code");
+        uploadSpinner.succeed("Uploaded extension source code");
         packageUri = api_1.storageOrigin + objectPath + "?alt=media";
     }
     catch (err) {
         uploadSpinner.fail();
-        throw new error_1.FirebaseError(`Failed to archive and upload extension source, ${err}`, {
+        throw new error_1.FirebaseError(`Failed to archive and upload extension source code, ${err}`, {
             original: err,
         });
     }
-    const publishSpinner = ora(`Publishing ${clc.bold(extensionVersionRef)}`);
+    const publishSpinner = ora(`Uploading ${clc.bold(extensionVersionRef)}...`);
     let res;
     try {
         publishSpinner.start();
-        res = await (0, extensionsApi_1.publishExtensionVersion)({ extensionVersionRef, packageUri });
-        publishSpinner.succeed(` Successfully published ${clc.bold(extensionVersionRef)}`);
+        res = await (0, publisherApi_1.createExtensionVersionFromLocalSource)({ extensionVersionRef, packageUri });
+        publishSpinner.succeed(`Successfully uploaded ${clc.bold(extensionVersionRef)}`);
     }
     catch (err) {
         publishSpinner.fail();
@@ -561,10 +697,11 @@ async function publishExtensionVersionFromLocalSource(args) {
     await deleteUploadedSource(objectPath);
     return res;
 }
-exports.publishExtensionVersionFromLocalSource = publishExtensionVersionFromLocalSource;
+exports.uploadExtensionVersionFromLocalSource = uploadExtensionVersionFromLocalSource;
 function getMissingPublisherError(publisherId) {
-    return new error_1.FirebaseError((0, marked_1.marked)(`Couldn't find publisher ID '${clc.bold(publisherId)}'. Please ensure that you have registered this ID. To register as a publisher, you can check out the [Firebase documentation](https://firebase.google.com/docs/extensions/alpha/share#register_as_an_extensions_publisher) for step-by-step instructions.`));
+    return new error_1.FirebaseError((0, marked_1.marked)(`Couldn't find publisher ID '${clc.bold(publisherId)}'. Please ensure that you have registered this ID. For step-by-step instructions on getting started as a publisher, see https://firebase.google.com/docs/extensions/publishers/get-started.`));
 }
+exports.getMissingPublisherError = getMissingPublisherError;
 async function createSourceFromLocation(projectId, sourceUri) {
     const extensionRoot = "/";
     let packageUri;
@@ -608,18 +745,18 @@ function getPublisherProjectFromName(publisherName) {
     throw new error_1.FirebaseError(`Could not find publisher with name '${publisherName}'.`);
 }
 exports.getPublisherProjectFromName = getPublisherProjectFromName;
-function displayReleaseNotes(extensionRef, versionId, releaseNotes, sourceUri) {
-    const source = sourceUri || "local source";
-    const releaseNotesMessage = releaseNotes
-        ? `${clc.bold("Release notes:")}\n${(0, marked_1.marked)(releaseNotes)}`
-        : "";
-    const metadataMessage = `${clc.bold("Extension:")} ${extensionRef}\n` +
-        `${clc.bold("Version:")} ${clc.bold(clc.green(versionId))}\n` +
+function displayReleaseNotes(args) {
+    const source = args.sourceUri || "Local source";
+    const releaseNotesMessage = args.releaseNotes
+        ? `${clc.bold("Release notes:")}\n${(0, marked_1.marked)(args.releaseNotes)}`
+        : "\n";
+    const metadataMessage = `${clc.bold("Extension:")} ${args.extensionRef}\n` +
+        `${clc.bold("Version:")} ${clc.bold(clc.green(args.newVersion))} ${args.autoReview ? "(automatically sent for review)" : ""}\n` +
         `${clc.bold("Source:")} ${source}\n`;
-    const message = `\nYou are about to publish a new version to Firebase's registry of Extensions.\n\n` +
+    const message = `\nYou are about to upload a new version to Firebase's registry of extensions.\n\n` +
         metadataMessage +
         releaseNotesMessage +
-        `\nOnce an Extension version is published, it cannot be changed. If you wish to make changes after publishing, you will need to publish a new version.\n`;
+        `Once an extension version is uploaded, it becomes installable by other users and cannot be changed. If you wish to make changes after uploading, you will need to upload a new version.\n`;
     logger_1.logger.info(message);
 }
 exports.displayReleaseNotes = displayReleaseNotes;
@@ -727,7 +864,7 @@ async function canonicalizeRefInput(refInput) {
         inferredRef = `firebase/${inferredRef}`;
     }
     if (refInput.split("@").length < 2) {
-        inferredRef = `${inferredRef}@latest`;
+        inferredRef = `${inferredRef}@latest-approved`;
     }
     const ref = refs.parse(inferredRef);
     ref.version = await (0, planner_1.resolveVersion)(ref);

package/lib/extensions/manifest.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.showPostDeprecationNotice = exports.readInstanceParam = exports.writeExtensionsToFirebaseJson = exports.getInstanceRef = exports.getInstanceTarget = exports.instanceExists = exports.loadConfig = exports.removeFromManifest = exports.writeLocalSecrets = exports.writeEmptyManifest = exports.writeToManifest = exports.ENV_DIRECTORY = void 0;
+exports.readInstanceParam = exports.writeExtensionsToFirebaseJson = exports.getInstanceRef = exports.getInstanceTarget = exports.instanceExists = exports.loadConfig = exports.removeFromManifest = exports.writeLocalSecrets = exports.writeEmptyManifest = exports.writeToManifest = exports.ENV_DIRECTORY = void 0;
 const clc = require("colorette");
 const path = require("path");
 const fs = require("fs-extra");
@@ -203,10 +203,3 @@ function readParamsFile(projectDir, fileName) {
     const params = (0, paramHelper_1.readEnvFile)(paramPath);
     return params;
 }
-function showPostDeprecationNotice() {
-    utils.logLabeledBullet(extensionsHelper_1.logPrefix, "The behavior of ext:install, ext:update, ext:configure, and ext:uninstall has changed in firebase-tools@11.0.0. " +
-        "Instead of deploying extensions directly, " +
-        "changes to extension instances will be written to firebase.json and ./extensions/*.env. " +
-        `Then ${clc.bold("firebase deploy (--only extensions)")} will deploy the changes to your Firebase project. See https://firebase.google.com/docs/extensions/manifest for more details.`);
-}
-exports.showPostDeprecationNotice = showPostDeprecationNotice;