firebase-tools 11.29.0 → 11.29.1

package/lib/deploy/extensions/secrets.js

@@ -37,8 +37,8 @@ const secretsInSpec = (spec) => {
     return spec.params.filter((p) => p.type === types_1.ParamType.SECRET);
 };
 async function handleSecretsCreateInstance(i, nonInteractive) {
-    const extensionVersion = await (0, planner_1.getExtensionVersion)(i);
-    const secretParams = secretsInSpec(extensionVersion.spec);
+    const spec = await (0, planner_1.getExtensionSpec)(i);
+    const secretParams = secretsInSpec(spec);
     for (const s of secretParams) {
         await handleSecretParamForCreate(s, i, nonInteractive);
     }

package/lib/deploy/hosting/prepare.js

@@ -1,12 +1,14 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.prepare = void 0;
+exports.unsafePins = exports.prepare = void 0;
 const error_1 = require("../../error");
 const api = require("../../hosting/api");
 const config = require("../../hosting/config");
 const deploymentTool = require("../../deploymentTool");
 const functional_1 = require("../../functional");
 const track_1 = require("../../track");
+const utils = require("../../utils");
+const backend = require("../functions/backend");
 async function prepare(context, options) {
     if (options.public) {
         if (Array.isArray(options.config.get("hosting"))) {
@@ -23,6 +25,12 @@ async function prepare(context, options) {
         if (config.webFramework) {
             labels["firebase-web-framework"] = config.webFramework;
         }
+        const unsafe = await unsafePins(context, config);
+        if (unsafe.length) {
+            const msg = `Cannot deploy site ${config.site} to channel ${context.hostingChannel} because it would modify one or more rewrites in "live" that are not pinned, breaking production. Please pin "live" before pinning other channels.`;
+            utils.logLabeledError("Hosting", msg);
+            throw new Error(msg);
+        }
         const version = {
             status: "CREATED",
             labels,
@@ -41,3 +49,50 @@ async function prepare(context, options) {
     }
 }
 exports.prepare = prepare;
+function rewriteTarget(source) {
+    if ("glob" in source) {
+        return source.glob;
+    }
+    else if ("source" in source) {
+        return source.source;
+    }
+    else if ("regex" in source) {
+        return source.regex;
+    }
+    else {
+        (0, functional_1.assertExhaustive)(source);
+    }
+}
+async function unsafePins(context, config) {
+    var _a, _b, _c;
+    if ((context.hostingChannel || "live") === "live") {
+        return [];
+    }
+    const targetTaggedRewrites = {};
+    for (const rewrite of config.rewrites || []) {
+        const target = rewriteTarget(rewrite);
+        if ("run" in rewrite && rewrite.run.pinTag) {
+            targetTaggedRewrites[target] = `${rewrite.run.region || "us-central1"}/${rewrite.run.serviceId}`;
+        }
+        if ("function" in rewrite && typeof rewrite.function === "object" && rewrite.function.pinTag) {
+            const region = rewrite.function.region || "us-central1";
+            const endpoint = (await backend.existingBackend(context)).endpoints[region][rewrite.function.functionId];
+            if (!endpoint) {
+                continue;
+            }
+            targetTaggedRewrites[target] = `${region}/${endpoint.runServiceId || endpoint.id}`;
+        }
+    }
+    if (!Object.keys(targetTaggedRewrites).length) {
+        return [];
+    }
+    const channelConfig = await api.getChannel(context.projectId, config.site, "live");
+    const existingUntaggedRewrites = {};
+    for (const rewrite of ((_c = (_b = (_a = channelConfig === null || channelConfig === void 0 ? void 0 : channelConfig.release) === null || _a === void 0 ? void 0 : _a.version) === null || _b === void 0 ? void 0 : _b.config) === null || _c === void 0 ? void 0 : _c.rewrites) || []) {
+        if ("run" in rewrite && !rewrite.run.tag) {
+            existingUntaggedRewrites[rewriteTarget(rewrite)] = `${rewrite.run.region}/${rewrite.run.serviceId}`;
+        }
+    }
+    return Object.keys(targetTaggedRewrites).filter((target) => targetTaggedRewrites[target] === existingUntaggedRewrites[target]);
+}
+exports.unsafePins = unsafePins;

package/lib/emulator/downloadableEmulators.js

@@ -23,9 +23,9 @@ const EMULATOR_UPDATE_DETAILS = {
         expectedChecksum: "311609538bd65666eb724ef47c2e6466",
     },
     firestore: {
-        version: "1.17.2",
-        expectedSize: 64907894,
-        expectedChecksum: "bc56ccf2419be3242e7b53def0a51566",
+        version: "1.17.3",
+        expectedSize: 64970588,
+        expectedChecksum: "75beb285dc404176b974fec9e3032712",
     },
     storage: {
         version: "1.1.3",

package/npm-shrinkwrap.json

@@ -1,12 +1,12 @@
 {
   "name": "firebase-tools",
-  "version": "11.29.0",
+  "version": "11.29.1",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "firebase-tools",
-      "version": "11.29.0",
+      "version": "11.29.1",
       "license": "MIT",
       "dependencies": {
         "@google-cloud/pubsub": "^3.0.1",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "firebase-tools",
-  "version": "11.29.0",
+  "version": "11.29.1",
   "description": "Command-Line Interface for Firebase",
   "main": "./lib/index.js",
   "bin": {