firebase-tools 11.14.3-canary.0 → 11.14.4

package/lib/deploy/functions/params.js

@@ -352,7 +352,7 @@ async function promptText(prompt, input, resolvedDefault, converter) {
             return promptText(prompt, input, resolvedDefault, converter);
         }
     }
-    const converted = converter(res);
+    const converted = converter(res.toString());
     if (typeof converted === "object") {
         logger_1.logger.error(converted.message);
         return promptText(prompt, input, resolvedDefault, converter);

package/lib/emulator/auth/operations.js

@@ -619,7 +619,7 @@ function sendOobCode(state, reqBody, ctx) {
         (0, errors_1.assert)((_a = ctx.security) === null || _a === void 0 ? void 0 : _a.Oauth2, "INSUFFICIENT_PERMISSION");
     }
     if (reqBody.continueUrl) {
-        (0, errors_1.assert)((0, utils_1.parseAbsoluteUri)(reqBody.continueUrl), "INVALID_CONTINUE_URI: ((expected an absolute URI with valid scheme and host))");
+        (0, errors_1.assert)((0, utils_1.parseAbsoluteUri)(reqBody.continueUrl), "INVALID_CONTINUE_URI : ((expected an absolute URI with valid scheme and host))");
     }
     let email;
     let mode;
@@ -1462,8 +1462,8 @@ function updateConfig(state, reqBody, ctx) {
     (0, errors_1.assert)(state instanceof state_1.AgentProjectState, "((Can only update top-level configurations on agent projects.))");
     for (const event in (_a = reqBody.blockingFunctions) === null || _a === void 0 ? void 0 : _a.triggers) {
         if (Object.prototype.hasOwnProperty.call(reqBody.blockingFunctions.triggers, event)) {
-            (0, errors_1.assert)(Object.values(state_1.BlockingFunctionEvents).includes(event), "INVALID_BLOCKING_FUNCTION: ((Event type is invalid.))");
-            (0, errors_1.assert)((0, utils_1.parseAbsoluteUri)(reqBody.blockingFunctions.triggers[event].functionUri), "INVALID_BLOCKING_FUNCTION: ((Expected an absolute URI with valid scheme and host.))");
+            (0, errors_1.assert)(Object.values(state_1.BlockingFunctionEvents).includes(event), "INVALID_BLOCKING_FUNCTION : ((Event type is invalid.))");
+            (0, errors_1.assert)((0, utils_1.parseAbsoluteUri)(reqBody.blockingFunctions.triggers[event].functionUri), "INVALID_BLOCKING_FUNCTION : ((Expected an absolute URI with valid scheme and host.))");
         }
     }
     return state.updateConfig(reqBody, ctx.params.query.updateMask);
@@ -1900,7 +1900,7 @@ function parsePendingCredential(state, pendingCredential) {
 function createTenant(state, reqBody) {
     var _a, _b, _c, _d, _e;
     if (!(state instanceof state_1.AgentProjectState)) {
-        throw new errors_1.InternalError("INTERNAL_ERROR: Can only create tenant in agent project", "INTERNAL");
+        throw new errors_1.InternalError("INTERNAL_ERROR : Can only create tenant in agent project", "INTERNAL");
     }
     const mfaConfig = (_a = reqBody.mfaConfig) !== null && _a !== void 0 ? _a : {};
     if (!("state" in mfaConfig)) {
@@ -1968,6 +1968,9 @@ async function fetchBlockingFunction(state, event, user, options = {}, oauthToke
         controller.abort();
     }, timeoutMs);
     let response;
+    let ok;
+    let status;
+    let text;
     try {
         const res = await (0, node_fetch_1.default)(url, {
             method: "POST",
@@ -1975,21 +1978,29 @@ async function fetchBlockingFunction(state, event, user, options = {}, oauthToke
             body: JSON.stringify(reqBody),
             signal: controller.signal,
         });
-        const text = await res.text();
-        (0, errors_1.assert)(res.ok, `BLOCKING_FUNCTION_ERROR_RESPONSE: ((HTTP request to ${url} returned HTTP error${res.status}: ${text}))`);
-        response = JSON.parse(text);
+        ok = res.ok;
+        status = res.status;
+        text = await res.text();
     }
     catch (thrown) {
         const err = thrown instanceof Error ? thrown : new Error(thrown);
         const isAbortError = err.name.includes("AbortError");
         if (isAbortError) {
-            throw new errors_1.InternalError(`BLOCKING_FUNCTION_ERROR_RESPONSE: ((Deadline exceeded making request to ${url}.))`, err.message);
+            throw new errors_1.InternalError(`BLOCKING_FUNCTION_ERROR_RESPONSE : ((Deadline exceeded making request to ${url}.))`, err.message);
         }
-        throw new errors_1.InternalError(`BLOCKING_FUNCTION_ERROR_RESPONSE: ((Failed to make request to ${url}.))`, err.message);
+        throw new errors_1.InternalError(`BLOCKING_FUNCTION_ERROR_RESPONSE : ((Failed to make request to ${url}.))`, err.message);
     }
     finally {
         clearTimeout(timeout);
     }
+    (0, errors_1.assert)(ok, `BLOCKING_FUNCTION_ERROR_RESPONSE : ((HTTP request to ${url} returned HTTP error ${status}: ${text}))`);
+    try {
+        response = JSON.parse(text);
+    }
+    catch (thrown) {
+        const err = thrown instanceof Error ? thrown : new Error(thrown);
+        throw new errors_1.InternalError(`BLOCKING_FUNCTION_ERROR_RESPONSE : ((Response body is not valid JSON.))`, err.message);
+    }
     return processBlockingFunctionResponse(event, response);
 }
 function processBlockingFunctionResponse(event, response) {
@@ -1997,7 +2008,7 @@ function processBlockingFunctionResponse(event, response) {
     const updates = {};
     if (response.userRecord) {
         const userRecord = response.userRecord;
-        (0, errors_1.assert)(userRecord.updateMask, "BLOCKING_FUNCTION_ERROR_RESPONSE: ((Response UserRecord is missing updateMask.))");
+        (0, errors_1.assert)(userRecord.updateMask, "BLOCKING_FUNCTION_ERROR_RESPONSE : ((Response UserRecord is missing updateMask.))");
         const mask = userRecord.updateMask;
         const fields = mask.split(",");
         for (const field of fields) {
@@ -2023,7 +2034,7 @@ function processBlockingFunctionResponse(event, response) {
                         extraClaims = userRecord.sessionClaims;
                     }
                     catch (_a) {
-                        throw new errors_1.BadRequestError("BLOCKING_FUNCTION_ERROR_RESPONSE: ((Response has malformed session claims.))");
+                        throw new errors_1.BadRequestError("BLOCKING_FUNCTION_ERROR_RESPONSE : ((Response has malformed session claims.))");
                     }
                     break;
                 default:

package/lib/emulator/storage/rules/runtime.js

@@ -190,7 +190,7 @@ class StorageRulesRuntime {
             },
         };
         const response = (await this._sendRequest(runtimeActionRequest));
-        if (response.errors.length || response.warnings.length) {
+        if (response.errors.length) {
             return {
                 issues: StorageRulesIssues.fromResponse(response),
             };

package/lib/frameworks/index.js

@@ -104,13 +104,15 @@ function scanDependencyTree(searchingFor, dependencies = {}) {
 }
 function findDependency(name, options = {}) {
     const { cwd, depth, omitDev } = Object.assign(Object.assign({}, DEFAULT_FIND_DEP_OPTIONS), options);
+    const env = Object.assign({}, process.env);
+    delete env.NODE_ENV;
     const result = (0, child_process_1.spawnSync)(NPM_COMMAND, [
         "list",
         name,
         "--json",
         ...(omitDev ? ["--omit", "dev"] : []),
         ...(depth === undefined ? [] : ["--depth", depth.toString(10)]),
-    ], { cwd });
+    ], { cwd, env });
     if (!result.stdout)
         return;
     const json = JSON.parse(result.stdout.toString());

package/npm-shrinkwrap.json

@@ -1,12 +1,12 @@
 {
   "name": "firebase-tools",
-  "version": "11.14.3-canary.0",
+  "version": "11.14.4",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "firebase-tools",
-      "version": "11.14.3-canary.0",
+      "version": "11.14.4",
       "license": "MIT",
       "dependencies": {
         "@google-cloud/pubsub": "^3.0.1",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "firebase-tools",
-  "version": "11.14.3-canary.0",
+  "version": "11.14.4",
   "description": "Command-Line Interface for Firebase",
   "main": "./lib/index.js",
   "bin": {