firebase-tools 10.2.1 → 10.3.1

package/lib/emulator/storage/server.js

@@ -58,7 +58,7 @@ function createApp(defaultProjectId, emulator) {
         }
         const name = file.name;
         const content = file.content;
-        const issues = await emulator.loadRuleset({ files: [{ name, content }] });
+        const issues = await emulator.setRules({ name, content });
         if (issues.errors.length > 0) {
             res.status(400).json({
                 message: "There was an error updating rules, see logs for more details",
@@ -70,7 +70,7 @@ function createApp(defaultProjectId, emulator) {
         });
     });
     app.post("/internal/reset", (req, res) => {
-        storageLayer.reset();
+        emulator.reset();
         res.sendStatus(200);
     });
     app.use("/v0", (0, firebase_1.createFirebaseEndpoints)(emulator));

package/lib/emulator/storage/upload.js

@@ -0,0 +1,106 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.UploadService = exports.NotCancellableError = exports.UploadNotActiveError = exports.UploadStatus = exports.UploadType = void 0;
+const uuid_1 = require("uuid");
+const errors_1 = require("./errors");
+var UploadType;
+(function (UploadType) {
+    UploadType[UploadType["MULTIPART"] = 0] = "MULTIPART";
+    UploadType[UploadType["RESUMABLE"] = 1] = "RESUMABLE";
+})(UploadType = exports.UploadType || (exports.UploadType = {}));
+var UploadStatus;
+(function (UploadStatus) {
+    UploadStatus[UploadStatus["ACTIVE"] = 0] = "ACTIVE";
+    UploadStatus[UploadStatus["CANCELLED"] = 1] = "CANCELLED";
+    UploadStatus[UploadStatus["FINISHED"] = 2] = "FINISHED";
+})(UploadStatus = exports.UploadStatus || (exports.UploadStatus = {}));
+class UploadNotActiveError extends Error {
+}
+exports.UploadNotActiveError = UploadNotActiveError;
+class NotCancellableError extends Error {
+}
+exports.NotCancellableError = NotCancellableError;
+class UploadService {
+    constructor(_persistence) {
+        this._persistence = _persistence;
+        this.reset();
+    }
+    reset() {
+        this._uploads = new Map();
+    }
+    multipartUpload(request) {
+        const upload = this.startMultipartUpload(request, request.dataRaw.byteLength);
+        this._persistence.deleteFile(upload.path, true);
+        this._persistence.appendBytes(upload.path, request.dataRaw);
+        return upload;
+    }
+    startMultipartUpload(request, sizeInBytes) {
+        const id = (0, uuid_1.v4)();
+        const upload = {
+            id: (0, uuid_1.v4)(),
+            bucketId: request.bucketId,
+            objectId: request.objectId,
+            type: UploadType.MULTIPART,
+            path: this.getStagingFileName(id, request.bucketId, request.objectId),
+            status: UploadStatus.FINISHED,
+            metadata: JSON.parse(request.metadataRaw),
+            size: sizeInBytes,
+            authorization: request.authorization,
+        };
+        this._uploads.set(upload.id, upload);
+        return upload;
+    }
+    startResumableUpload(request) {
+        const id = (0, uuid_1.v4)();
+        const upload = {
+            id: id,
+            bucketId: request.bucketId,
+            objectId: request.objectId,
+            type: UploadType.RESUMABLE,
+            path: this.getStagingFileName(id, request.bucketId, request.objectId),
+            status: UploadStatus.ACTIVE,
+            metadata: JSON.parse(request.metadataRaw),
+            size: 0,
+            authorization: request.authorization,
+        };
+        this._uploads.set(upload.id, upload);
+        this._persistence.deleteFile(upload.path, true);
+        return upload;
+    }
+    continueResumableUpload(uploadId, dataRaw) {
+        const upload = this.getResumableUpload(uploadId);
+        if (upload.status !== UploadStatus.ACTIVE) {
+            throw new UploadNotActiveError();
+        }
+        this._persistence.appendBytes(upload.path, dataRaw);
+        upload.size += dataRaw.byteLength;
+        return upload;
+    }
+    getResumableUpload(uploadId) {
+        const upload = this._uploads.get(uploadId);
+        if (!upload || upload.type !== UploadType.RESUMABLE) {
+            throw new errors_1.NotFoundError();
+        }
+        return upload;
+    }
+    cancelResumableUpload(uploadId) {
+        const upload = this.getResumableUpload(uploadId);
+        if (upload.status === UploadStatus.FINISHED) {
+            throw new NotCancellableError();
+        }
+        upload.status = UploadStatus.CANCELLED;
+        return upload;
+    }
+    finalizeResumableUpload(uploadId) {
+        const upload = this.getResumableUpload(uploadId);
+        if (upload.status === UploadStatus.CANCELLED) {
+            throw new UploadNotActiveError();
+        }
+        upload.status = UploadStatus.FINISHED;
+        return upload;
+    }
+    getStagingFileName(uploadId, bucketId, objectId) {
+        return encodeURIComponent(`${uploadId}_b_${bucketId}_o_${objectId}`);
+    }
+}
+exports.UploadService = UploadService;

package/lib/emulator/types.js

@@ -13,6 +13,7 @@ var Emulators;
     Emulators["UI"] = "ui";
     Emulators["LOGGING"] = "logging";
     Emulators["STORAGE"] = "storage";
+    Emulators["EXTENSIONS"] = "extensions";
 })(Emulators = exports.Emulators || (exports.Emulators = {}));
 exports.DOWNLOADABLE_EMULATORS = [
     Emulators.FIRESTORE,
@@ -48,6 +49,7 @@ exports.EMULATORS_SUPPORTED_BY_UI = [
     Emulators.FIRESTORE,
     Emulators.FUNCTIONS,
     Emulators.STORAGE,
+    Emulators.EXTENSIONS,
 ];
 exports.EMULATORS_SUPPORTED_BY_USE_EMULATOR = [
     Emulators.AUTH,
@@ -59,6 +61,7 @@ exports.ALL_EMULATORS = [
     Emulators.HUB,
     Emulators.UI,
     Emulators.LOGGING,
+    Emulators.EXTENSIONS,
     ...exports.ALL_SERVICE_EMULATORS,
 ];
 function isDownloadableEmulator(value) {

package/lib/ensureApiEnabled.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.ensure = exports.check = exports.POLL_SETTINGS = void 0;
+exports.enableApiURI = exports.ensure = exports.check = exports.POLL_SETTINGS = void 0;
 const cli_color_1 = require("cli-color");
 const track = require("./track");
 const api_1 = require("./api");
@@ -75,3 +75,7 @@ async function ensure(projectId, apiName, prefix, silent = false) {
     return enableApiWithRetries(projectId, apiName, prefix, silent);
 }
 exports.ensure = ensure;
+function enableApiURI(projectId, apiName) {
+    return `https://console.cloud.google.com/apis/library/${apiName}?project=${projectId}`;
+}
+exports.enableApiURI = enableApiURI;

package/lib/error.js

@@ -23,7 +23,7 @@ function isBillingError(e) {
     return !!((_d = (_c = (_b = (_a = e.context) === null || _a === void 0 ? void 0 : _a.body) === null || _b === void 0 ? void 0 : _b.error) === null || _c === void 0 ? void 0 : _c.details) === null || _d === void 0 ? void 0 : _d.find((d) => {
         var _a;
         return (((_a = d.violations) === null || _a === void 0 ? void 0 : _a.find((v) => v.type === "serviceusage/billing-enabled")) ||
-            d.reason == "UREQ_PROJECT_BILLING_NOT_FOUND");
+            d.reason === "UREQ_PROJECT_BILLING_NOT_FOUND");
     }));
 }
 exports.isBillingError = isBillingError;

package/lib/extensions/askUserForParam.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.ask = exports.getInquirerDefault = exports.promptCreateSecret = exports.askForParam = exports.checkResponse = void 0;
+exports.getInquirerDefault = exports.promptCreateSecret = exports.askForParam = exports.ask = exports.checkResponse = void 0;
 const _ = require("lodash");
 const clc = require("cli-color");
 const { marked } = require("marked");
@@ -20,7 +20,7 @@ var SecretUpdateAction;
 function checkResponse(response, spec) {
     let valid = true;
     let responses;
-    if (spec.required && (response == "" || response == undefined)) {
+    if (spec.required && (response === "" || response === undefined)) {
         utils.logWarning(`Param ${spec.param} is required, but no value was provided.`);
         return false;
     }
@@ -55,7 +55,31 @@ function checkResponse(response, spec) {
     return valid;
 }
 exports.checkResponse = checkResponse;
-async function askForParam(projectId, instanceId, paramSpec, reconfiguring) {
+async function ask(projectId, instanceId, paramSpecs, firebaseProjectParams, reconfiguring) {
+    if (_.isEmpty(paramSpecs)) {
+        logger_1.logger.debug("No params were specified for this extension.");
+        return {};
+    }
+    utils.logLabeledBullet(extensionsHelper_1.logPrefix, "answer the questions below to configure your extension:");
+    const substituted = (0, extensionsHelper_1.substituteParams)(paramSpecs, firebaseProjectParams);
+    const result = {};
+    const promises = _.map(substituted, (paramSpec) => {
+        return async () => {
+            result[paramSpec.param] = await askForParam({
+                projectId,
+                instanceId,
+                paramSpec,
+                reconfiguring,
+            });
+        };
+    });
+    await promises.reduce((prev, cur) => prev.then(cur), Promise.resolve());
+    logger_1.logger.info();
+    return result;
+}
+exports.ask = ask;
+async function askForParam(args) {
+    const paramSpec = args.paramSpec;
     let valid = false;
     let response = "";
     const description = paramSpec.description || "";
@@ -99,9 +123,9 @@ async function askForParam(projectId, instanceId, paramSpec, reconfiguring) {
                 valid = checkResponse(response, paramSpec);
                 break;
             case extensionsApi_1.ParamType.SECRET:
-                response = reconfiguring
-                    ? await promptReconfigureSecret(projectId, instanceId, paramSpec)
-                    : await promptCreateSecret(projectId, instanceId, paramSpec);
+                response = args.reconfiguring
+                    ? await promptReconfigureSecret(args.projectId, args.instanceId, paramSpec)
+                    : await promptCreateSecret(args.projectId, args.instanceId, paramSpec);
                 valid = true;
                 break;
             default:
@@ -114,7 +138,7 @@ async function askForParam(projectId, instanceId, paramSpec, reconfiguring) {
                 valid = checkResponse(response, paramSpec);
         }
     }
-    return response;
+    return { baseValue: response };
 }
 exports.askForParam = askForParam;
 async function promptReconfigureSecret(projectId, instanceId, paramSpec) {
@@ -210,21 +234,3 @@ function getInquirerDefault(options, def) {
     return defaultOption ? defaultOption.label || defaultOption.value : "";
 }
 exports.getInquirerDefault = getInquirerDefault;
-async function ask(projectId, instanceId, paramSpecs, firebaseProjectParams, reconfiguring) {
-    if (_.isEmpty(paramSpecs)) {
-        logger_1.logger.debug("No params were specified for this extension.");
-        return {};
-    }
-    utils.logLabeledBullet(extensionsHelper_1.logPrefix, "answer the questions below to configure your extension:");
-    const substituted = (0, extensionsHelper_1.substituteParams)(paramSpecs, firebaseProjectParams);
-    const result = {};
-    const promises = _.map(substituted, (paramSpec) => {
-        return async () => {
-            result[paramSpec.param] = await askForParam(projectId, instanceId, paramSpec, reconfiguring);
-        };
-    });
-    await promises.reduce((prev, cur) => prev.then(cur), Promise.resolve());
-    logger_1.logger.info();
-    return result;
-}
-exports.ask = ask;

package/lib/extensions/changelog.js

@@ -58,7 +58,9 @@ function breakingChangesInUpdate(versionsInUpdate) {
     const semvers = versionsInUpdate.map((v) => semver.parse(v)).sort(semver.compare);
     for (let i = 1; i < semvers.length; i++) {
         const hasMajorBump = semvers[i - 1].major < semvers[i].major;
-        const hasMinorBumpInPreview = semvers[i - 1].major == 0 && semvers[i].major == 0 && semvers[i - 1].minor < semvers[i].minor;
+        const hasMinorBumpInPreview = semvers[i - 1].major === 0 &&
+            semvers[i].major === 0 &&
+            semvers[i - 1].minor < semvers[i].minor;
         if (hasMajorBump || hasMinorBumpInPreview) {
             breakingVersions.push(semvers[i].raw);
         }

package/lib/extensions/checkProjectBilling.js

@@ -49,7 +49,7 @@ Please select the one that you would like to associate with this project:`,
         billingEnabled = await openBillingAccount(projectId, billingURL, true);
     }
     else {
-        const billingAccount = accounts.find((a) => a.displayName == answer);
+        const billingAccount = accounts.find((a) => a.displayName === answer);
         billingEnabled = await cloudbilling.setBillingAccount(projectId, billingAccount.name);
     }
     return logBillingStatus(billingEnabled, projectId);

package/lib/extensions/displayExtensionInfo.js

@@ -136,7 +136,7 @@ async function displayUpdateChangesRequiringConfirmation(args) {
 }
 exports.displayUpdateChangesRequiringConfirmation = displayUpdateChangesRequiringConfirmation;
 function compareResources(resource1, resource2) {
-    return resource1.name == resource2.name && resource1.type == resource2.type;
+    return resource1.name === resource2.name && resource1.type === resource2.type;
 }
 function getResourceReadableName(resource) {
     return resource.type === "firebaseextensions.v1beta.function"

package/lib/extensions/emulator/optionsHelper.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getParams = exports.buildOptions = void 0;
+exports.getParams = exports.getSecretEnvVars = exports.getNonSecretEnv = exports.getExtensionFunctionInfo = exports.buildOptions = void 0;
 const fs = require("fs-extra");
 const _ = require("lodash");
 const path = require("path");
@@ -8,6 +8,7 @@ const paramHelper = require("../paramHelper");
 const specHelper = require("./specHelper");
 const localHelper = require("../localHelper");
 const triggerHelper = require("./triggerHelper");
+const extensionsApi_1 = require("../extensionsApi");
 const extensionsHelper = require("../extensionsHelper");
 const config_1 = require("../../config");
 const error_1 = require("../../error");
@@ -15,9 +16,9 @@ const emulatorLogger_1 = require("../../emulator/emulatorLogger");
 const projectUtils_1 = require("../../projectUtils");
 const types_1 = require("../../emulator/types");
 async function buildOptions(options) {
-    const extensionDir = localHelper.findExtensionYaml(process.cwd());
-    options.extensionDir = extensionDir;
-    const spec = await specHelper.readExtensionYaml(extensionDir);
+    const extDevDir = localHelper.findExtensionYaml(process.cwd());
+    options.extDevDir = extDevDir;
+    const spec = await specHelper.readExtensionYaml(extDevDir);
     extensionsHelper.validateSpec(spec);
     const params = getParams(options, spec);
     extensionsHelper.validateCommandLineParams(params, spec.params);
@@ -28,13 +29,60 @@ async function buildOptions(options) {
         checkTestConfig(testConfig, functionResources);
     }
     options.config = buildConfig(functionResources, testConfig);
-    options.extensionEnv = params;
+    options.extDevEnv = params;
     const functionEmuTriggerDefs = functionResources.map((r) => triggerHelper.functionResourceToEmulatedTriggerDefintion(r));
-    options.extensionTriggers = functionEmuTriggerDefs;
-    options.extensionNodeVersion = specHelper.getNodeVersion(functionResources);
+    options.extDevTriggers = functionEmuTriggerDefs;
+    options.extDevNodeVersion = specHelper.getNodeVersion(functionResources);
     return options;
 }
 exports.buildOptions = buildOptions;
+async function getExtensionFunctionInfo(extensionDir, instanceId, paramValues) {
+    const spec = await specHelper.readExtensionYaml(extensionDir);
+    const functionResources = specHelper.getFunctionResourcesWithParamSubstitution(spec, paramValues);
+    const extensionTriggers = functionResources
+        .map((r) => triggerHelper.functionResourceToEmulatedTriggerDefintion(r))
+        .map((trigger) => {
+        trigger.name = `ext-${instanceId}-${trigger.name}`;
+        return trigger;
+    });
+    const nodeMajorVersion = specHelper.getNodeVersion(functionResources);
+    const nonSecretEnv = getNonSecretEnv(spec.params, paramValues);
+    const secretEnvVariables = getSecretEnvVars(spec.params, paramValues);
+    return {
+        extensionTriggers,
+        nodeMajorVersion,
+        nonSecretEnv,
+        secretEnvVariables,
+    };
+}
+exports.getExtensionFunctionInfo = getExtensionFunctionInfo;
+const isSecretParam = (p) => p.type === extensionsHelper.SpecParamType.SECRET || p.type === extensionsApi_1.ParamType.SECRET;
+function getNonSecretEnv(params, paramValues) {
+    const getNonSecretEnv = Object.assign({}, paramValues);
+    const secretParams = params.filter(isSecretParam);
+    for (const p of secretParams) {
+        delete getNonSecretEnv[p.param];
+    }
+    return getNonSecretEnv;
+}
+exports.getNonSecretEnv = getNonSecretEnv;
+function getSecretEnvVars(params, paramValues) {
+    const secretEnvVar = [];
+    const secretParams = params.filter(isSecretParam);
+    for (const s of secretParams) {
+        if (paramValues[s.param]) {
+            const [, projectId, , secret, , version] = paramValues[s.param].split("/");
+            secretEnvVar.push({
+                key: s.param,
+                secret,
+                projectId,
+                version,
+            });
+        }
+    }
+    return secretEnvVar;
+}
+exports.getSecretEnvVars = getSecretEnvVars;
 function getParams(options, extensionSpec) {
     const projectId = (0, projectUtils_1.needProjectId)(options);
     const userParams = paramHelper.readEnvFile(options.testParams);
@@ -120,7 +168,7 @@ function getFunctionSourceDirectory(functionResources) {
         if (!sourceDirectory) {
             sourceDirectory = dir;
         }
-        else if (sourceDirectory != dir) {
+        else if (sourceDirectory !== dir) {
             throw new error_1.FirebaseError(`Found function resources with different sourceDirectories: '${sourceDirectory}' and '${dir}'. The extensions emulator only supports a single sourceDirectory.`);
         }
     }

package/lib/extensions/emulator/specHelper.js

@@ -2,13 +2,11 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.getNodeVersion = exports.getFunctionProperties = exports.getFunctionResourcesWithParamSubstitution = exports.readFileFromDirectory = exports.readExtensionYaml = void 0;
 const yaml = require("js-yaml");
-const _ = require("lodash");
 const path = require("path");
 const fs = require("fs-extra");
 const error_1 = require("../../error");
 const extensionsHelper_1 = require("../extensionsHelper");
-const emulatorLogger_1 = require("../../emulator/emulatorLogger");
-const types_1 = require("../../emulator/types");
+const functionsEmulatorUtils_1 = require("../../emulator/functionsEmulatorUtils");
 const SPEC_FILE = "extension.yaml";
 const validFunctionTypes = [
     "firebaseextensions.v1beta.function",
@@ -62,35 +60,24 @@ function getFunctionProperties(resources) {
 }
 exports.getFunctionProperties = getFunctionProperties;
 function getNodeVersion(resources) {
-    const functionNamesWithoutRuntime = [];
+    const invalidRuntimes = [];
     const versions = resources.map((r) => {
         var _a, _b;
-        if (_.includes(r.type, "function")) {
-            if ((_a = r.properties) === null || _a === void 0 ? void 0 : _a.runtime) {
-                return (_b = r.properties) === null || _b === void 0 ? void 0 : _b.runtime;
+        if ((_a = r.properties) === null || _a === void 0 ? void 0 : _a.runtime) {
+            const runtimeName = (_b = r.properties) === null || _b === void 0 ? void 0 : _b.runtime;
+            const runtime = (0, functionsEmulatorUtils_1.parseRuntimeVersion)(runtimeName);
+            if (!runtime) {
+                invalidRuntimes.push(runtimeName);
             }
             else {
-                functionNamesWithoutRuntime.push(r.name);
+                return runtime;
             }
         }
-        return "nodejs8";
-    });
-    if (functionNamesWithoutRuntime.length) {
-        emulatorLogger_1.EmulatorLogger.forEmulator(types_1.Emulators.FUNCTIONS).logLabeled("WARN", "extensions", `No 'runtime' property found for the following functions, defaulting to nodejs8: ${functionNamesWithoutRuntime.join(", ")}`);
-    }
-    const invalidRuntimes = _.filter(versions, (v) => {
-        return !_.includes(v, "nodejs");
+        return 14;
     });
     if (invalidRuntimes.length) {
         throw new error_1.FirebaseError(`The following runtimes are not supported by the Emulator Suite: ${invalidRuntimes.join(", ")}. \n Only Node runtimes are supported.`);
     }
-    if (_.includes(versions, "nodejs10")) {
-        return "10";
-    }
-    if (_.includes(versions, "nodejs6")) {
-        emulatorLogger_1.EmulatorLogger.forEmulator(types_1.Emulators.FUNCTIONS).logLabeled("WARN", "extensions", "Node 6 is deprecated. We recommend upgrading to a newer version.");
-        return "6";
-    }
-    return "8";
+    return Math.max(...versions);
 }
 exports.getNodeVersion = getNodeVersion;

package/lib/extensions/export.js

@@ -1,14 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.writeFiles = exports.displayExportInfo = exports.setSecretParamsToLatest = exports.parameterizeProject = void 0;
-const clc = require("cli-color");
-const refs = require("./refs");
-const config_1 = require("../config");
+exports.displayExportInfo = exports.setSecretParamsToLatest = exports.parameterizeProject = void 0;
 const planner_1 = require("../deploy/extensions/planner");
 const deploymentSummary_1 = require("../deploy/extensions/deploymentSummary");
 const logger_1 = require("../logger");
-const error_1 = require("../error");
-const prompt_1 = require("../prompt");
 const secretManager_1 = require("../gcp/secretManager");
 const secretsUtils_1 = require("./secretsUtils");
 function parameterizeProject(projectId, projectNumber, spec) {
@@ -60,48 +55,3 @@ function displaySpecs(specs) {
         logger_1.logger.info("");
     }
 }
-function writeExtensionsToFirebaseJson(have, existingConfig) {
-    const extensions = existingConfig.get("extensions", {});
-    for (const s of have) {
-        extensions[s.instanceId] = refs.toExtensionVersionRef(s.ref);
-    }
-    existingConfig.set("extensions", extensions);
-    logger_1.logger.info("Adding Extensions to " + clc.bold("firebase.json") + "...");
-    existingConfig.writeProjectFile("firebase.json", existingConfig.src);
-}
-async function writeEnvFile(spec, existingConfig, force) {
-    const content = Object.entries(spec.params)
-        .map((r) => `${r[0]}=${r[1]}`)
-        .join("\n");
-    await existingConfig.askWriteProjectFile(`extensions/${spec.instanceId}.env`, content, force);
-}
-async function writeFiles(have, options) {
-    const existingConfig = config_1.Config.load(options, true);
-    if (!existingConfig) {
-        throw new error_1.FirebaseError("Not currently in a Firebase directory. Please run `firebase init` to create a Firebase directory.");
-    }
-    if (existingConfig.has("extensions") &&
-        Object.keys(existingConfig.get("extensions")).length &&
-        !options.nonInteractive &&
-        !options.force) {
-        const currentExtensions = Object.entries(existingConfig.get("extensions"))
-            .map((i) => `${i[0]}: ${i[1]}`)
-            .join("\n\t");
-        const overwrite = await (0, prompt_1.promptOnce)({
-            type: "list",
-            message: `firebase.json already contains extensions:\n${currentExtensions}\nWould you like to overwrite or merge?`,
-            choices: [
-                { name: "Overwrite", value: true },
-                { name: "Merge", value: false },
-            ],
-        });
-        if (overwrite) {
-            existingConfig.set("extensions", {});
-        }
-    }
-    writeExtensionsToFirebaseJson(have, existingConfig);
-    for (const spec of have) {
-        await writeEnvFile(spec, existingConfig, options.force);
-    }
-}
-exports.writeFiles = writeFiles;

package/lib/extensions/extensionsApi.js

@@ -295,7 +295,7 @@ async function listExtensionVersions(ref, filter = "") {
 exports.listExtensionVersions = listExtensionVersions;
 async function getPublisherProfile(projectId, publisherId) {
     const res = await apiClient.get(`/projects/${projectId}/publisherProfile`, {
-        queryParams: publisherId == undefined
+        queryParams: publisherId === undefined
             ? undefined
             : {
                 publisherId,