firebase-tools 10.1.5 → 10.2.2

package/lib/emulator/storage/apis/firebase.js

@@ -114,10 +114,10 @@ function createFirebaseEndpoints(emulator) {
             return;
         }
         let isGZipped = false;
-        if (md.contentEncoding == "gzip") {
+        if (md.contentEncoding === "gzip") {
             isGZipped = true;
         }
-        if (req.query.alt == "media") {
+        if (req.query.alt === "media") {
             let data = storageLayer.getBytes(req.params.bucketId, req.params.objectId);
             if (!data) {
                 res.sendStatus(404);
@@ -206,7 +206,6 @@ function createFirebaseEndpoints(emulator) {
         res.json(storageLayer.listItemsAndPrefixes(req.params.bucketId, prefix, delimiter, pageToken, maxRes));
     });
     const handleUpload = async (req, res) => {
-        var _a;
         if (req.query.create_token || req.query.delete_token) {
             const decodedObjectId = decodeURIComponent(req.params.objectId);
             const operationPath = ["b", req.params.bucketId, "o", decodedObjectId].join("/");
@@ -239,7 +238,7 @@ function createFirebaseEndpoints(emulator) {
             const deleteTokenParam = req.query["delete_token"];
             let md;
             if (createTokenParam) {
-                if (createTokenParam != "true") {
+                if (createTokenParam !== "true") {
                     res.sendStatus(400);
                     return;
                 }
@@ -261,7 +260,7 @@ function createFirebaseEndpoints(emulator) {
         }
         const name = req.query.name.toString();
         const uploadType = req.header("x-goog-upload-protocol");
-        if (uploadType == "multipart") {
+        if (uploadType === "multipart") {
             const contentType = req.header("content-type");
             if (!contentType || !contentType.startsWith("multipart/related")) {
                 res.sendStatus(400);
@@ -311,7 +310,7 @@ function createFirebaseEndpoints(emulator) {
                     },
                 });
             }
-            if (md.downloadTokens.length == 0) {
+            if (md.downloadTokens.length === 0) {
                 md.addDownloadToken();
             }
             res.json(new metadata_1.OutgoingFirebaseMetadata(md));
@@ -324,7 +323,7 @@ function createFirebaseEndpoints(emulator) {
                 res.sendStatus(400);
                 return;
             }
-            if (uploadCommand == "start") {
+            if (uploadCommand === "start") {
                 let objectContentType = req.header("x-goog-upload-header-content-type") ||
                     req.header("x-goog-upload-content-type");
                 if (!objectContentType) {
@@ -336,7 +335,7 @@ function createFirebaseEndpoints(emulator) {
                         objectContentType = mimeTypeFromName;
                     }
                 }
-                const upload = storageLayer.startUpload(req.params.bucketId, name, objectContentType, req.body);
+                const upload = storageLayer.startUpload(req.params.bucketId, name, objectContentType, req.body, req.header("authorization"));
                 storageLayer.uploadBytes(upload.uploadId, Buffer.alloc(0));
                 const emulatorInfo = registry_1.EmulatorRegistry.getInfo(types_1.Emulators.STORAGE);
                 res.header("x-goog-upload-chunk-granularity", "10000");
@@ -352,7 +351,7 @@ function createFirebaseEndpoints(emulator) {
                 return;
             }
             const uploadId = req.query.upload_id.toString();
-            if (uploadCommand == "query") {
+            if (uploadCommand === "query") {
                 const upload = storageLayer.queryUpload(uploadId);
                 if (!upload) {
                     res.sendStatus(400);
@@ -362,13 +361,15 @@ function createFirebaseEndpoints(emulator) {
                 res.sendStatus(200);
                 return;
             }
-            if (uploadCommand == "cancel") {
-                const upload = storageLayer.cancelUpload(uploadId);
-                if (!upload) {
-                    res.sendStatus(400);
-                    return;
+            if (uploadCommand === "cancel") {
+                const upload = storageLayer.queryUpload(uploadId);
+                if (upload) {
+                    const cancelled = storageLayer.cancelUpload(upload);
+                    res.sendStatus(cancelled ? 200 : 400);
+                }
+                else {
+                    res.sendStatus(404);
                 }
-                res.sendStatus(200);
                 return;
             }
             let upload;
@@ -394,20 +395,18 @@ function createFirebaseEndpoints(emulator) {
                 res.header("x-gupload-uploadid", upload.uploadId);
             }
             if (uploadCommand.includes("finalize")) {
-                const finalizedUpload = storageLayer.finalizeUpload(uploadId);
-                if (!finalizedUpload) {
+                upload = storageLayer.queryUpload(uploadId);
+                if (!upload) {
                     res.sendStatus(400);
                     return;
                 }
-                upload = finalizedUpload.upload;
-                res.header("x-goog-upload-status", "final");
                 if (!(await isPermitted({
                     ruleset: emulator.rules,
                     method: types_2.RulesetOperationMethod.CREATE,
                     path: operationPath,
-                    authorization: req.header("authorization"),
+                    authorization: upload.authorization,
                     file: {
-                        after: (_a = storageLayer.getMetadata(req.params.bucketId, name)) === null || _a === void 0 ? void 0 : _a.asRulesResource(),
+                        after: storageLayer.createMetadata(upload).asRulesResource(),
                     },
                 }))) {
                     storageLayer.deleteFile(upload.bucketId, name);
@@ -418,11 +417,13 @@ function createFirebaseEndpoints(emulator) {
                         },
                     });
                 }
-                const md = finalizedUpload.file.metadata;
-                if (md.downloadTokens.length == 0) {
+                res.header("x-goog-upload-status", "final");
+                const uploadedFile = storageLayer.finalizeUpload(upload);
+                const md = uploadedFile.metadata;
+                if (md.downloadTokens.length === 0) {
                     md.addDownloadToken();
                 }
-                res.json(new metadata_1.OutgoingFirebaseMetadata(finalizedUpload.file.metadata));
+                res.json(new metadata_1.OutgoingFirebaseMetadata(uploadedFile.metadata));
             }
             else if (!upload) {
                 res.sendStatus(400);
@@ -447,12 +448,17 @@ function createFirebaseEndpoints(emulator) {
     firebaseStorageAPI.delete("/b/:bucketId/o/:objectId", async (req, res) => {
         const decodedObjectId = decodeURIComponent(req.params.objectId);
         const operationPath = ["b", req.params.bucketId, "o", decodedObjectId].join("/");
+        const md = storageLayer.getMetadata(req.params.bucketId, decodedObjectId);
+        const rulesFiles = {};
+        if (md) {
+            rulesFiles.before = md.asRulesResource();
+        }
         if (!(await isPermitted({
             ruleset: emulator.rules,
             method: types_2.RulesetOperationMethod.DELETE,
             path: operationPath,
             authorization: req.header("authorization"),
-            file: {},
+            file: rulesFiles,
         }))) {
             return res.status(403).json({
                 error: {
@@ -461,7 +467,6 @@ function createFirebaseEndpoints(emulator) {
                 },
             });
         }
-        const md = storageLayer.getMetadata(req.params.bucketId, decodedObjectId);
         if (!md) {
             res.sendStatus(404);
             return;

package/lib/emulator/storage/apis/gcloud.js

@@ -26,7 +26,7 @@ function createCloudEndpoints(emulator) {
             res.sendStatus(404);
             return;
         }
-        if (req.query.alt == "media") {
+        if (req.query.alt === "media") {
             return sendFileBytes(md, storageLayer, req, res);
         }
         const outgoingMd = new metadata_1.CloudStorageObjectMetadata(md);
@@ -80,18 +80,13 @@ function createCloudEndpoints(emulator) {
                 resolve();
             });
         });
-        let upload = storageLayer.uploadBytes(uploadId, req.body);
+        const upload = storageLayer.uploadBytes(uploadId, req.body);
         if (!upload) {
             res.sendStatus(400);
             return;
         }
-        const finalizedUpload = storageLayer.finalizeUpload(uploadId);
-        if (!finalizedUpload) {
-            res.sendStatus(400);
-            return;
-        }
-        upload = finalizedUpload.upload;
-        res.status(200).json(new metadata_1.CloudStorageObjectMetadata(finalizedUpload.file.metadata)).send();
+        const uploadedFile = storageLayer.finalizeUpload(upload);
+        res.status(200).json(new metadata_1.CloudStorageObjectMetadata(uploadedFile.metadata)).send();
     });
     gcloudStorageAPI.post("/b/:bucketId/o/:objectId/acl", (req, res) => {
         var _a, _b;
@@ -130,10 +125,10 @@ function createCloudEndpoints(emulator) {
             res.sendStatus(400);
             return;
         }
-        if (req.query.uploadType == "resumable") {
+        if (req.query.uploadType === "resumable") {
             const upload = storageLayer.startUpload(req.params.bucketId, name, contentType, req.body);
             const emulatorInfo = registry_1.EmulatorRegistry.getInfo(types_1.Emulators.STORAGE);
-            if (emulatorInfo == undefined) {
+            if (emulatorInfo === undefined) {
                 res.sendStatus(500);
                 return;
             }
@@ -202,7 +197,7 @@ function sendFileBytes(md, storageLayer, req, res) {
         res.sendStatus(404);
         return;
     }
-    const isGZipped = md.contentEncoding == "gzip";
+    const isGZipped = md.contentEncoding === "gzip";
     if (isGZipped) {
         data = (0, zlib_1.gunzipSync)(data);
     }

package/lib/emulator/storage/files.js

@@ -40,7 +40,7 @@ class StoredFile {
 }
 exports.StoredFile = StoredFile;
 class ResumableUpload {
-    constructor(bucketId, objectId, uploadId, contentType, metadata) {
+    constructor(bucketId, objectId, uploadId, contentType, metadata, authorization) {
         this._currentBytesUploaded = 0;
         this._status = UploadStatus.ACTIVE;
         this._bucketId = bucketId;
@@ -48,6 +48,7 @@ class ResumableUpload {
         this._uploadId = uploadId;
         this._contentType = contentType;
         this._metadata = metadata;
+        this._authorization = authorization;
         this._fileLocation = encodeURIComponent(`${uploadId}_b_${bucketId}_o_${objectId}`);
         this._currentBytesUploaded = 0;
     }
@@ -69,6 +70,9 @@ class ResumableUpload {
     set contentType(contentType) {
         this._contentType = contentType;
     }
+    get authorization() {
+        return this._authorization;
+    }
     get currentBytesUploaded() {
         return this._currentBytesUploaded;
     }
@@ -110,7 +114,7 @@ class StorageLayer {
         }
     }
     async listBuckets() {
-        if (this._buckets.size == 0) {
+        if (this._buckets.size === 0) {
             let adminSdkConfig = await (0, adminSdkConfig_1.getProjectAdminSdkConfigOrCached)(this._projectId);
             if (!adminSdkConfig) {
                 adminSdkConfig = (0, adminSdkConfig_1.constructDefaultAdminSdkConfig)(this._projectId);
@@ -127,6 +131,16 @@ class StorageLayer {
         }
         return;
     }
+    createMetadata(upload) {
+        const bytes = this._persistence.readBytes(upload.fileLocation, upload.currentBytesUploaded);
+        return new metadata_1.StoredFileMetadata({
+            name: upload.objectId,
+            bucket: upload.bucketId,
+            contentType: "",
+            contentEncoding: upload.metadata.contentEncoding,
+            customMetadata: upload.metadata.metadata,
+        }, this._cloudFunctions, bytes);
+    }
     getBytes(bucket, object, size, offset) {
         const key = this.path(bucket, object);
         const val = this._files.get(key);
@@ -139,22 +153,21 @@ class StorageLayer {
     public(value) {
         this._files = value;
     }
-    startUpload(bucket, object, contentType, metadata) {
+    startUpload(bucket, object, contentType, metadata, authorization) {
         const uploadId = (0, uuid_1.v4)();
-        const upload = new ResumableUpload(bucket, object, uploadId, contentType, metadata);
+        const upload = new ResumableUpload(bucket, object, uploadId, contentType, metadata, authorization);
         this._uploads.set(uploadId, upload);
         return upload;
     }
     queryUpload(uploadId) {
         return this._uploads.get(uploadId);
     }
-    cancelUpload(uploadId) {
-        const upload = this._uploads.get(uploadId);
-        if (!upload) {
-            return undefined;
+    cancelUpload(upload) {
+        if (upload.status === UploadStatus.ACTIVE) {
+            this._persistence.deleteFile(upload.fileLocation);
+            upload.status = UploadStatus.CANCELLED;
         }
-        upload.status = UploadStatus.CANCELLED;
-        this._persistence.deleteFile(upload.fileLocation);
+        return upload.status === UploadStatus.CANCELLED;
     }
     uploadBytes(uploadId, bytes) {
         const upload = this._uploads.get(uploadId);
@@ -175,7 +188,7 @@ class StorageLayer {
             filePath += "%2F";
         }
         const file = this._files.get(filePath);
-        if (file == undefined) {
+        if (file === undefined) {
             return false;
         }
         else {
@@ -188,27 +201,16 @@ class StorageLayer {
     async deleteAll() {
         return this._persistence.deleteAll();
     }
-    finalizeUpload(uploadId) {
-        const upload = this._uploads.get(uploadId);
-        if (!upload) {
-            return undefined;
-        }
+    finalizeUpload(upload) {
         upload.status = UploadStatus.FINISHED;
+        const metadata = this.createMetadata(upload);
         const filePath = this.path(upload.bucketId, upload.objectId);
-        const bytes = this._persistence.readBytes(upload.fileLocation, upload.currentBytesUploaded);
-        const finalMetadata = new metadata_1.StoredFileMetadata({
-            name: upload.objectId,
-            bucket: upload.bucketId,
-            contentType: "",
-            contentEncoding: upload.metadata.contentEncoding,
-            customMetadata: upload.metadata.metadata,
-        }, this._cloudFunctions, bytes, upload.metadata);
-        const file = new StoredFile(finalMetadata, filePath);
+        const file = new StoredFile(metadata, filePath);
         this._files.set(filePath, file);
         this._persistence.deleteFile(filePath, true);
         this._persistence.renameFile(upload.fileLocation, filePath);
         this._cloudFunctions.dispatch("finalize", new metadata_1.CloudStorageObjectMetadata(file.metadata));
-        return { upload: upload, file: file };
+        return file;
     }
     oneShotUpload(bucket, object, contentType, incomingMetadata, bytes) {
         const filePath = this.path(bucket, object);
@@ -220,7 +222,7 @@ class StorageLayer {
             contentType: incomingMetadata.contentType || "application/octet-stream",
             contentEncoding: incomingMetadata.contentEncoding,
             customMetadata: incomingMetadata.metadata,
-        }, this._cloudFunctions, bytes, incomingMetadata);
+        }, this._cloudFunctions, bytes);
         const file = new StoredFile(md, this._persistence.getDiskPath(filePath));
         this._files.set(filePath, file);
         this._cloudFunctions.dispatch("finalize", new metadata_1.CloudStorageObjectMetadata(file.metadata));
@@ -242,7 +244,7 @@ class StorageLayer {
         let items = [];
         const prefixes = new Set();
         for (const [, file] of this._files) {
-            if (file.metadata.bucket != bucket) {
+            if (file.metadata.bucket !== bucket) {
                 continue;
             }
             let name = `${delimiter}${file.metadata.name}`;
@@ -254,7 +256,7 @@ class StorageLayer {
                 name = name.substring(prefix.length);
             }
             const startAtIndex = name.indexOf(delimiter);
-            if (startAtIndex == -1) {
+            if (startAtIndex === -1) {
                 if (!file.metadata.name.endsWith("/")) {
                     items.push(file.metadata.name);
                 }
@@ -266,8 +268,8 @@ class StorageLayer {
         }
         items.sort();
         if (pageToken) {
-            const idx = items.findIndex((v) => v == pageToken);
-            if (idx != -1) {
+            const idx = items.findIndex((v) => v === pageToken);
+            if (idx !== -1) {
                 items = items.slice(idx);
             }
         }
@@ -293,7 +295,7 @@ class StorageLayer {
         }
         let items = [];
         for (const [, file] of this._files) {
-            if (file.metadata.bucket != bucket) {
+            if (file.metadata.bucket !== bucket) {
                 continue;
             }
             let name = file.metadata.name;
@@ -308,8 +310,8 @@ class StorageLayer {
         }
         items.sort();
         if (pageToken) {
-            const idx = items.findIndex((v) => v == pageToken);
-            if (idx != -1) {
+            const idx = items.findIndex((v) => v === pageToken);
+            if (idx !== -1) {
                 items = items.slice(idx);
             }
         }

package/lib/emulator/storage/index.js

@@ -33,14 +33,14 @@ class StorageEmulator {
         const { host, port } = this.getInfo();
         await this._rulesRuntime.start(this.args.auto_download);
         this._app = await (0, server_1.createApp)(this.args.projectId, this);
-        if (typeof this.args.rules == "string") {
+        if (typeof this.args.rules === "string") {
             const rulesFile = this.args.rules;
             this.updateRulesSource(rulesFile);
         }
         else {
             this._rulesetSource = this.args.rules;
         }
-        if (!this._rulesetSource || this._rulesetSource.files.length == 0) {
+        if (!this._rulesetSource || this._rulesetSource.files.length === 0) {
             throw new error_1.FirebaseError("Can not initialize Storage emulator without a rules source / file.");
         }
         else if (this._rulesetSource.files.length > 1) {

package/lib/emulator/storage/metadata.js

@@ -149,9 +149,9 @@ class StoredFileMetadata {
         if (!this.downloadTokens.length) {
             return;
         }
-        const remainingTokens = this.downloadTokens.filter((t) => t != token);
+        const remainingTokens = this.downloadTokens.filter((t) => t !== token);
         this.downloadTokens = remainingTokens;
-        if (remainingTokens.length == 0) {
+        if (remainingTokens.length === 0) {
             this.addDownloadToken();
         }
         this.update({});

package/lib/emulator/storage/rules/runtime.js

@@ -20,7 +20,7 @@ class StorageRulesetInstance {
         this.rulesetName = rulesetName;
     }
     async verify(opts, runtimeVariableOverrides = {}) {
-        if (opts.method == types_1.RulesetOperationMethod.LIST && this.rulesVersion < 2) {
+        if (opts.method === types_1.RulesetOperationMethod.LIST && this.rulesVersion < 2) {
             const issues = new StorageRulesIssues();
             issues.warnings.push("Permission denied. List operations are only allowed for rules_version='2'.");
             return {
@@ -103,6 +103,7 @@ class StorageRulesRuntime {
         (_a = this._childprocess.stderr) === null || _a === void 0 ? void 0 : _a.on("data", (buf) => {
             const error = buf.toString();
             if (error.includes("jarfile")) {
+                emulatorLogger_1.EmulatorLogger.forEmulator(types_2.Emulators.STORAGE).log("ERROR", error);
                 throw new error_1.FirebaseError("There was an issue starting the rules emulator, please run 'firebase setup:emulators:storage` again");
             }
             else {
@@ -111,7 +112,7 @@ class StorageRulesRuntime {
         });
         (_b = this._childprocess.stdout) === null || _b === void 0 ? void 0 : _b.on("data", (buf) => {
             const serializedRuntimeActionResponse = buf.toString("UTF8").trim();
-            if (serializedRuntimeActionResponse != "") {
+            if (serializedRuntimeActionResponse !== "") {
                 let rap;
                 try {
                     rap = JSON.parse(serializedRuntimeActionResponse);
@@ -217,14 +218,14 @@ class StorageRulesRuntime {
 }
 exports.StorageRulesRuntime = StorageRulesRuntime;
 function toExpressionValue(obj) {
-    if (typeof obj == "string") {
+    if (typeof obj === "string") {
         return { string_value: obj };
     }
-    if (typeof obj == "boolean") {
+    if (typeof obj === "boolean") {
         return { bool_value: obj };
     }
-    if (typeof obj == "number") {
-        if (Math.floor(obj) == obj) {
+    if (typeof obj === "number") {
+        if (Math.floor(obj) === obj) {
             return { int_value: obj };
         }
         else {
@@ -255,7 +256,7 @@ function toExpressionValue(obj) {
             null_value: 0,
         };
     }
-    if (typeof obj == "object") {
+    if (typeof obj === "object") {
         const fields = {};
         Object.keys(obj).forEach((key) => {
             fields[key] = toExpressionValue(obj[key]);

package/lib/emulator/types.js

@@ -13,6 +13,7 @@ var Emulators;
     Emulators["UI"] = "ui";
     Emulators["LOGGING"] = "logging";
     Emulators["STORAGE"] = "storage";
+    Emulators["EXTENSIONS"] = "extensions";
 })(Emulators = exports.Emulators || (exports.Emulators = {}));
 exports.DOWNLOADABLE_EMULATORS = [
     Emulators.FIRESTORE,
@@ -48,6 +49,7 @@ exports.EMULATORS_SUPPORTED_BY_UI = [
     Emulators.FIRESTORE,
     Emulators.FUNCTIONS,
     Emulators.STORAGE,
+    Emulators.EXTENSIONS,
 ];
 exports.EMULATORS_SUPPORTED_BY_USE_EMULATOR = [
     Emulators.AUTH,
@@ -59,6 +61,7 @@ exports.ALL_EMULATORS = [
     Emulators.HUB,
     Emulators.UI,
     Emulators.LOGGING,
+    Emulators.EXTENSIONS,
     ...exports.ALL_SERVICE_EMULATORS,
 ];
 function isDownloadableEmulator(value) {

package/lib/ensureApiEnabled.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.ensure = exports.check = exports.POLL_SETTINGS = void 0;
+exports.enableApiURI = exports.ensure = exports.check = exports.POLL_SETTINGS = void 0;
 const cli_color_1 = require("cli-color");
 const track = require("./track");
 const api_1 = require("./api");
@@ -75,3 +75,7 @@ async function ensure(projectId, apiName, prefix, silent = false) {
     return enableApiWithRetries(projectId, apiName, prefix, silent);
 }
 exports.ensure = ensure;
+function enableApiURI(projectId, apiName) {
+    return `https://console.cloud.google.com/apis/library/${apiName}?project=${projectId}`;
+}
+exports.enableApiURI = enableApiURI;

package/lib/error.js

@@ -23,7 +23,7 @@ function isBillingError(e) {
     return !!((_d = (_c = (_b = (_a = e.context) === null || _a === void 0 ? void 0 : _a.body) === null || _b === void 0 ? void 0 : _b.error) === null || _c === void 0 ? void 0 : _c.details) === null || _d === void 0 ? void 0 : _d.find((d) => {
         var _a;
         return (((_a = d.violations) === null || _a === void 0 ? void 0 : _a.find((v) => v.type === "serviceusage/billing-enabled")) ||
-            d.reason == "UREQ_PROJECT_BILLING_NOT_FOUND");
+            d.reason === "UREQ_PROJECT_BILLING_NOT_FOUND");
     }));
 }
 exports.isBillingError = isBillingError;

package/lib/extensions/askUserForParam.js

@@ -20,7 +20,7 @@ var SecretUpdateAction;
 function checkResponse(response, spec) {
     let valid = true;
     let responses;
-    if (spec.required && (response == "" || response == undefined)) {
+    if (spec.required && (response === "" || response === undefined)) {
         utils.logWarning(`Param ${spec.param} is required, but no value was provided.`);
         return false;
     }
@@ -199,7 +199,7 @@ async function generateSecretName(projectId, instanceId, paramName) {
     return secretName;
 }
 async function addNewSecretVersion(projectId, instanceId, secret, paramSpec, secretValue) {
-    const version = await secretManagerApi.addVersion(secret, secretValue);
+    const version = await secretManagerApi.addVersion(projectId, secret.name, secretValue);
     await secretsUtils.grantFirexServiceAgentSecretAdminRole(secret);
     return `projects/${version.secret.projectId}/secrets/${version.secret.name}/versions/${version.versionId}`;
 }

package/lib/extensions/changelog.js

@@ -58,7 +58,9 @@ function breakingChangesInUpdate(versionsInUpdate) {
     const semvers = versionsInUpdate.map((v) => semver.parse(v)).sort(semver.compare);
     for (let i = 1; i < semvers.length; i++) {
         const hasMajorBump = semvers[i - 1].major < semvers[i].major;
-        const hasMinorBumpInPreview = semvers[i - 1].major == 0 && semvers[i].major == 0 && semvers[i - 1].minor < semvers[i].minor;
+        const hasMinorBumpInPreview = semvers[i - 1].major === 0 &&
+            semvers[i].major === 0 &&
+            semvers[i - 1].minor < semvers[i].minor;
         if (hasMajorBump || hasMinorBumpInPreview) {
             breakingVersions.push(semvers[i].raw);
         }

package/lib/extensions/checkProjectBilling.js

@@ -49,7 +49,7 @@ Please select the one that you would like to associate with this project:`,
         billingEnabled = await openBillingAccount(projectId, billingURL, true);
     }
     else {
-        const billingAccount = accounts.find((a) => a.displayName == answer);
+        const billingAccount = accounts.find((a) => a.displayName === answer);
         billingEnabled = await cloudbilling.setBillingAccount(projectId, billingAccount.name);
     }
     return logBillingStatus(billingEnabled, projectId);

package/lib/extensions/diagnose.js

@@ -0,0 +1,56 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.diagnose = void 0;
+const extensionsHelper_1 = require("./extensionsHelper");
+const getProjectNumber_1 = require("../getProjectNumber");
+const utils = require("../utils");
+const resourceManager = require("../gcp/resourceManager");
+const extensionsApi_1 = require("./extensionsApi");
+const prompt_1 = require("../prompt");
+const logger_1 = require("../logger");
+const error_1 = require("../error");
+const SERVICE_AGENT_ROLE = "roles/firebasemods.serviceAgent";
+async function diagnose(projectId) {
+    const projectNumber = await (0, getProjectNumber_1.getProjectNumber)({ projectId });
+    const firexSaProjectId = utils.envOverride("FIREBASE_EXTENSIONS_SA_PROJECT_ID", "gcp-sa-firebasemods");
+    const saEmail = `service-${projectNumber}@${firexSaProjectId}.iam.gserviceaccount.com`;
+    utils.logLabeledBullet(extensionsHelper_1.logPrefix, "Checking project IAM policy...");
+    await (0, extensionsApi_1.listInstances)(projectId);
+    let policy;
+    try {
+        policy = await resourceManager.getIamPolicy(projectId);
+        logger_1.logger.debug(policy);
+    }
+    catch (e) {
+        if (e instanceof error_1.FirebaseError && e.status === 403) {
+            throw new error_1.FirebaseError("Unable to get project IAM policy, permission denied (403). Please " +
+                "make sure you have sufficient project privileges or if this is a brand new project " +
+                "try again in a few minutes.");
+        }
+        throw e;
+    }
+    if (policy.bindings.find((b) => b.role === SERVICE_AGENT_ROLE && b.members.includes("serviceAccount:" + saEmail))) {
+        utils.logLabeledSuccess(extensionsHelper_1.logPrefix, "Project IAM policy OK");
+        return true;
+    }
+    else {
+        utils.logWarning("Firebase Extensions Service Agent is missing a required IAM role " +
+            "`Firebase Extensions API Service Agent`.");
+        const fix = await (0, prompt_1.promptOnce)({
+            type: "confirm",
+            message: "Would you like to fix the issue by updating IAM policy to include Firebase " +
+                "Extensions Service Agent with role `Firebase Extensions API Service Agent`",
+        });
+        if (fix) {
+            policy.bindings.push({
+                role: SERVICE_AGENT_ROLE,
+                members: ["serviceAccount:" + saEmail],
+            });
+            await resourceManager.setIamPolicy(projectId, policy, "bindings");
+            utils.logSuccess("Project IAM policy updated successfully");
+            return true;
+        }
+        return false;
+    }
+}
+exports.diagnose = diagnose;

package/lib/extensions/displayExtensionInfo.js

@@ -136,7 +136,7 @@ async function displayUpdateChangesRequiringConfirmation(args) {
 }
 exports.displayUpdateChangesRequiringConfirmation = displayUpdateChangesRequiringConfirmation;
 function compareResources(resource1, resource2) {
-    return resource1.name == resource2.name && resource1.type == resource2.type;
+    return resource1.name === resource2.name && resource1.type === resource2.type;
 }
 function getResourceReadableName(resource) {
     return resource.type === "firebaseextensions.v1beta.function"