firebase-functions 4.2.0 → 4.2.1

package/lib/common/providers/database.js

@@ -31,14 +31,9 @@ const path_1 = require("../../common/utilities/path");
 class DataSnapshot {
     constructor(data, path, // path is undefined for the database root
     app, instance) {
-        var _a, _b;
         this.app = app;
         const config = (0, config_1.firebaseConfig)();
-        if ((_b = (_a = app === null || app === void 0 ? void 0 : app.options) === null || _a === void 0 ? void 0 : _a.databaseURL) === null || _b === void 0 ? void 0 : _b.startsWith("http:")) {
-            // In this case we're dealing with an emulator
-            this.instance = app.options.databaseURL;
-        }
-        else if (instance) {
+        if (instance) {
             // SDK always supplies instance, but user's unit tests may not
             this.instance = instance;
         }

package/lib/common/providers/https.js

@@ -21,7 +21,7 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.onCallHandler = exports.checkAuthToken = exports.unsafeDecodeAppCheckToken = exports.unsafeDecodeIdToken = exports.unsafeDecodeToken = exports.decode = exports.encode = exports.isValidRequest = exports.HttpsError = void 0;
+exports.onCallHandler = exports.checkAuthToken = exports.unsafeDecodeAppCheckToken = exports.unsafeDecodeIdToken = exports.unsafeDecodeToken = exports.decode = exports.encode = exports.isValidRequest = exports.HttpsError = exports.ORIGINAL_AUTH_HEADER = exports.CALLABLE_AUTH_HEADER = void 0;
 const cors = require("cors");
 const logger = require("../../logger");
 // TODO(inlined): Decide whether we want to un-version apps or whether we want a
@@ -31,6 +31,10 @@ const auth_1 = require("firebase-admin/auth");
 const app_1 = require("../app");
 const debug_1 = require("../debug");
 const JWT_REGEX = /^[a-zA-Z0-9\-_=]+?\.[a-zA-Z0-9\-_=]+?\.([a-zA-Z0-9\-_=]+)?$/;
+/** @internal */
+exports.CALLABLE_AUTH_HEADER = "x-callable-context-auth";
+/** @internal */
+exports.ORIGINAL_AUTH_HEADER = "x-original-auth";
 /**
  * Standard error codes and HTTP statuses for different ways a request can fail,
  * as defined by:
@@ -382,6 +386,29 @@ function wrapOnCallHandler(options, handler) {
                 throw new HttpsError("invalid-argument", "Bad Request");
             }
             const context = { rawRequest: req };
+            // TODO(colerogers): yank this when we release a breaking change of the CLI that removes
+            // our monkey-patching code referenced below and increases the minimum supported SDK version.
+            //
+            // Note: This code is needed to fix v1 callable functions in the emulator with a monorepo setup.
+            // The original monkey-patched code lived in the functionsEmulatorRuntime
+            // (link: https://github.com/firebase/firebase-tools/blob/accea7abda3cc9fa6bb91368e4895faf95281c60/src/emulator/functionsEmulatorRuntime.ts#L480)
+            // and was not compatible with how monorepos separate out packages (see https://github.com/firebase/firebase-tools/issues/5210).
+            if ((0, debug_1.isDebugFeatureEnabled)("skipTokenVerification") && handler.length === 2) {
+                const authContext = context.rawRequest.header(exports.CALLABLE_AUTH_HEADER);
+                if (authContext) {
+                    logger.debug("Callable functions auth override", {
+                        key: exports.CALLABLE_AUTH_HEADER,
+                        value: authContext,
+                    });
+                    context.auth = JSON.parse(decodeURIComponent(authContext));
+                    delete context.rawRequest.headers[exports.CALLABLE_AUTH_HEADER];
+                }
+                const originalAuth = context.rawRequest.header(exports.ORIGINAL_AUTH_HEADER);
+                if (originalAuth) {
+                    context.rawRequest.headers["authorization"] = originalAuth;
+                    delete context.rawRequest.headers[exports.ORIGINAL_AUTH_HEADER];
+                }
+            }
             const tokenStatus = await checkTokens(req, context);
             if (tokenStatus.auth === "INVALID") {
                 throw new HttpsError("unauthenticated", "Unauthenticated");

package/lib/v1/providers/testLab.d.ts

@@ -121,7 +121,7 @@ export declare class ResultStorage {
  * - `USE_DESTINATION_ARTIFACTS`: One or more of the test targets defined in the
  *   .xctestrun file specifies "UseDestinationArtifacts", which is disallowed.
  *
- * - `TEST_NON_APP_HOSTED`: XC tests which run on physical devices must have
+ * - `TEST_NOT_APP_HOSTED`: XC tests which run on physical devices must have
  *   "IsAppHostedTestBundle" == "true" in the xctestrun file.
  *
  * - `PLIST_CANNOT_BE_PARSED`: An Info.plist file in the XCTest zip could not be

package/lib/v2/providers/database.js

@@ -178,7 +178,7 @@ function onChangedOperation(eventType, referenceOrOpts, handler) {
     // wrap the handler
     const func = (raw) => {
         const event = raw;
-        const instanceUrl = `https://${event.instance}.${event.firebasedatabasehost}`;
+        const instanceUrl = getInstance(event);
         const params = makeParams(event, pathPattern, instancePattern);
         const databaseEvent = makeChangedDatabaseEvent(event, instanceUrl, params);
         return (0, trace_1.wrapTraceContext)(handler)(databaseEvent);
@@ -196,7 +196,7 @@ function onOperation(eventType, referenceOrOpts, handler) {
     // wrap the handler
     const func = (raw) => {
         const event = raw;
-        const instanceUrl = `https://${event.instance}.${event.firebasedatabasehost}`;
+        const instanceUrl = getInstance(event);
         const params = makeParams(event, pathPattern, instancePattern);
         const data = eventType === exports.deletedEventType ? event.data.data : event.data.delta;
         const databaseEvent = makeDatabaseEvent(event, data, instanceUrl, params);
@@ -207,3 +207,9 @@ function onOperation(eventType, referenceOrOpts, handler) {
     return func;
 }
 exports.onOperation = onOperation;
+function getInstance(event) {
+    const emuHost = process.env.FIREBASE_DATABASE_EMULATOR_HOST;
+    return emuHost
+        ? `http://${emuHost}/?ns=${event.instance}`
+        : `https://${event.instance}.${event.firebasedatabasehost}`;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "firebase-functions",
-  "version": "4.2.0",
+  "version": "4.2.1",
   "description": "Firebase SDK for Cloud Functions",
   "keywords": [
     "firebase",