firebase-functions 4.1.1 → 4.2.1

package/lib/common/providers/database.js

@@ -31,14 +31,9 @@ const path_1 = require("../../common/utilities/path");
 class DataSnapshot {
     constructor(data, path, // path is undefined for the database root
     app, instance) {
-        var _a, _b;
         this.app = app;
         const config = (0, config_1.firebaseConfig)();
-        if ((_b = (_a = app === null || app === void 0 ? void 0 : app.options) === null || _a === void 0 ? void 0 : _a.databaseURL) === null || _b === void 0 ? void 0 : _b.startsWith("http:")) {
-            // In this case we're dealing with an emulator
-            this.instance = app.options.databaseURL;
-        }
-        else if (instance) {
+        if (instance) {
             // SDK always supplies instance, but user's unit tests may not
             this.instance = instance;
         }

package/lib/common/providers/https.js

@@ -21,7 +21,7 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.onCallHandler = exports.checkAuthToken = exports.unsafeDecodeAppCheckToken = exports.unsafeDecodeIdToken = exports.unsafeDecodeToken = exports.decode = exports.encode = exports.isValidRequest = exports.HttpsError = void 0;
+exports.onCallHandler = exports.checkAuthToken = exports.unsafeDecodeAppCheckToken = exports.unsafeDecodeIdToken = exports.unsafeDecodeToken = exports.decode = exports.encode = exports.isValidRequest = exports.HttpsError = exports.ORIGINAL_AUTH_HEADER = exports.CALLABLE_AUTH_HEADER = void 0;
 const cors = require("cors");
 const logger = require("../../logger");
 // TODO(inlined): Decide whether we want to un-version apps or whether we want a
@@ -31,6 +31,10 @@ const auth_1 = require("firebase-admin/auth");
 const app_1 = require("../app");
 const debug_1 = require("../debug");
 const JWT_REGEX = /^[a-zA-Z0-9\-_=]+?\.[a-zA-Z0-9\-_=]+?\.([a-zA-Z0-9\-_=]+)?$/;
+/** @internal */
+exports.CALLABLE_AUTH_HEADER = "x-callable-context-auth";
+/** @internal */
+exports.ORIGINAL_AUTH_HEADER = "x-original-auth";
 /**
  * Standard error codes and HTTP statuses for different ways a request can fail,
  * as defined by:
@@ -382,6 +386,29 @@ function wrapOnCallHandler(options, handler) {
                 throw new HttpsError("invalid-argument", "Bad Request");
             }
             const context = { rawRequest: req };
+            // TODO(colerogers): yank this when we release a breaking change of the CLI that removes
+            // our monkey-patching code referenced below and increases the minimum supported SDK version.
+            //
+            // Note: This code is needed to fix v1 callable functions in the emulator with a monorepo setup.
+            // The original monkey-patched code lived in the functionsEmulatorRuntime
+            // (link: https://github.com/firebase/firebase-tools/blob/accea7abda3cc9fa6bb91368e4895faf95281c60/src/emulator/functionsEmulatorRuntime.ts#L480)
+            // and was not compatible with how monorepos separate out packages (see https://github.com/firebase/firebase-tools/issues/5210).
+            if ((0, debug_1.isDebugFeatureEnabled)("skipTokenVerification") && handler.length === 2) {
+                const authContext = context.rawRequest.header(exports.CALLABLE_AUTH_HEADER);
+                if (authContext) {
+                    logger.debug("Callable functions auth override", {
+                        key: exports.CALLABLE_AUTH_HEADER,
+                        value: authContext,
+                    });
+                    context.auth = JSON.parse(decodeURIComponent(authContext));
+                    delete context.rawRequest.headers[exports.CALLABLE_AUTH_HEADER];
+                }
+                const originalAuth = context.rawRequest.header(exports.ORIGINAL_AUTH_HEADER);
+                if (originalAuth) {
+                    context.rawRequest.headers["authorization"] = originalAuth;
+                    delete context.rawRequest.headers[exports.ORIGINAL_AUTH_HEADER];
+                }
+            }
             const tokenStatus = await checkTokens(req, context);
             if (tokenStatus.auth === "INVALID") {
                 throw new HttpsError("unauthenticated", "Unauthenticated");

package/lib/params/index.d.ts

@@ -2,7 +2,7 @@
  * @hidden
  * @alpha
  */
-import { BooleanParam, Expression, FloatParam, IntParam, Param, ParamOptions, SecretParam, StringParam } from "./types";
+import { BooleanParam, Expression, IntParam, Param, ParamOptions, SecretParam, StringParam, ListParam } from "./types";
 export { ParamOptions, Expression };
 declare type SecretOrExpr = Param<any> | SecretParam;
 export declare const declaredParams: SecretOrExpr[];
@@ -62,10 +62,10 @@ export declare function defineBoolean(name: string, options?: ParamOptions<boole
  */
 export declare function defineInt(name: string, options?: ParamOptions<number>): IntParam;
 /**
- * Declare a float param.
+ * Declare a list param.
  *
  * @param name The name of the environment variable to use to load the param.
  * @param options Configuration options for the param.
- * @returns A Param with a `number` return type for `.value`.
+ * @returns A Param with a `string[]` return type for `.value`.
  */
-export declare function defineFloat(name: string, options?: ParamOptions<number>): FloatParam;
+export declare function defineList(name: string, options?: ParamOptions<string[]>): ListParam;

package/lib/params/index.js

@@ -21,7 +21,7 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.defineFloat = exports.defineInt = exports.defineBoolean = exports.defineString = exports.defineSecret = exports.storageBucket = exports.gcloudProject = exports.projectID = exports.databaseURL = exports.clearParams = exports.declaredParams = exports.Expression = void 0;
+exports.defineList = exports.defineFloat = exports.defineInt = exports.defineBoolean = exports.defineString = exports.defineSecret = exports.storageBucket = exports.gcloudProject = exports.projectID = exports.databaseURL = exports.clearParams = exports.declaredParams = exports.Expression = void 0;
 /**
  * @hidden
  * @alpha
@@ -131,6 +131,8 @@ exports.defineInt = defineInt;
  * @param name The name of the environment variable to use to load the param.
  * @param options Configuration options for the param.
  * @returns A Param with a `number` return type for `.value`.
+ *
+ * @internal
  */
 function defineFloat(name, options = {}) {
     const param = new types_1.FloatParam(name, options);
@@ -138,3 +140,16 @@ function defineFloat(name, options = {}) {
     return param;
 }
 exports.defineFloat = defineFloat;
+/**
+ * Declare a list param.
+ *
+ * @param name The name of the environment variable to use to load the param.
+ * @param options Configuration options for the param.
+ * @returns A Param with a `string[]` return type for `.value`.
+ */
+function defineList(name, options = {}) {
+    const param = new types_1.ListParam(name, options);
+    registerParam(param);
+    return param;
+}
+exports.defineList = defineList;

package/lib/params/types.d.ts

@@ -34,6 +34,8 @@ declare type ParamInput<T> = {
     text: TextInput<T>;
 } | {
     select: SelectInput<T>;
+} | {
+    multiSelect: MultiSelectInput;
 } | {
     resource: ResourceInput;
 };
@@ -73,6 +75,14 @@ export interface ResourceInput {
 export interface SelectInput<T = unknown> {
     options: Array<SelectOptions<T>>;
 }
+/**
+ * Specifies that a Param's value should be determined by having the user select
+ * a subset from a list of pre-canned options interactively at deploy-time.
+ * Will result in errors if used on Params of type other than string[].
+ */
+export interface MultiSelectInput {
+    options: Array<SelectOptions<string>>;
+}
 /**
  * One of the options provided to a SelectInput, containing a value and
  * optionally a human-readable label to display in the selection interface.
@@ -186,4 +196,19 @@ export declare class BooleanParam extends Param<boolean> {
     then<T extends string | number | boolean>(ifTrue: T | Expression<T>, ifFalse: T | Expression<T>): TernaryExpression<T>;
     thenElse<T extends string | number | boolean>(ifTrue: T | Expression<T>, ifFalse: T | Expression<T>): TernaryExpression<T>;
 }
+/**
+ *  A parametrized value of String[] type that will be read from .env files
+ *  if present, or prompted for by the CLI if missing.
+ */
+export declare class ListParam extends Param<string[]> {
+    static type: ParamValueType;
+    /** @hidden */
+    greaterThan(rhs: string[] | Expression<string[]>): CompareExpression<string[]>;
+    /** @hidden */
+    greaterThanOrEqualTo(rhs: string[] | Expression<string[]>): CompareExpression<string[]>;
+    /** @hidden */
+    lessThan(rhs: string[] | Expression<string[]>): CompareExpression<string[]>;
+    /** @hidden */
+    lessThanorEqualTo(rhs: string[] | Expression<string[]>): CompareExpression<string[]>;
+}
 export {};

package/lib/params/types.js

@@ -21,7 +21,7 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.BooleanParam = exports.FloatParam = exports.IntParam = exports.InternalExpression = exports.StringParam = exports.SecretParam = exports.Param = exports.CompareExpression = exports.TernaryExpression = exports.Expression = void 0;
+exports.ListParam = exports.BooleanParam = exports.FloatParam = exports.IntParam = exports.InternalExpression = exports.StringParam = exports.SecretParam = exports.Param = exports.CompareExpression = exports.TernaryExpression = exports.Expression = void 0;
 const logger = require("../logger");
 /*
  * A CEL expression which can be evaluated during function deployment, and
@@ -51,15 +51,29 @@ class Expression {
     }
 }
 exports.Expression = Expression;
-function quoteIfString(literal) {
-    // TODO(vsfan@): CEL's string escape semantics are slightly different than Javascript's, what do we do here?
-    return typeof literal === "string" ? `"${literal}"` : literal;
-}
 function valueOf(arg) {
     return arg instanceof Expression ? arg.runtimeValue() : arg;
 }
+/**
+ * Returns how an entity (either an Expression or a literal value) should be represented in CEL.
+ * - Expressions delegate to the .toString() method, which is used by the WireManifest
+ * - Strings have to be quoted explicitly
+ * - Arrays are represented as []-delimited, parsable JSON
+ * - Numbers and booleans are not quoted explicitly
+ */
 function refOf(arg) {
-    return arg instanceof Expression ? arg.toString() : quoteIfString(arg).toString();
+    if (arg instanceof Expression) {
+        return arg.toString();
+    }
+    else if (typeof arg === "string") {
+        return `"${arg}"`;
+    }
+    else if (Array.isArray(arg)) {
+        return JSON.stringify(arg);
+    }
+    else {
+        return arg.toString();
+    }
 }
 /**
  * A CEL expression corresponding to a ternary operator, e.g {{ cond ? ifTrue : ifFalse }}
@@ -99,9 +113,9 @@ class CompareExpression extends Expression {
         const right = valueOf(this.rhs);
         switch (this.cmp) {
             case "==":
-                return left === right;
+                return Array.isArray(left) ? this.arrayEquals(left, right) : left === right;
             case "!=":
-                return left !== right;
+                return Array.isArray(left) ? !this.arrayEquals(left, right) : left !== right;
             case ">":
                 return left > right;
             case ">=":
@@ -114,6 +128,10 @@ class CompareExpression extends Expression {
                 throw new Error(`Unknown comparator ${this.cmp}`);
         }
     }
+    /** @internal */
+    arrayEquals(a, b) {
+        return a.every((item) => b.includes(item)) && b.every((item) => a.includes(item));
+    }
     toString() {
         const rhsStr = refOf(this.rhs);
         return `${this.lhs} ${this.cmp} ${rhsStr}`;
@@ -309,3 +327,39 @@ class BooleanParam extends Param {
 }
 exports.BooleanParam = BooleanParam;
 BooleanParam.type = "boolean";
+/**
+ *  A parametrized value of String[] type that will be read from .env files
+ *  if present, or prompted for by the CLI if missing.
+ */
+class ListParam extends Param {
+    /** @internal */
+    runtimeValue() {
+        const val = JSON.parse(process.env[this.name]);
+        if (!Array.isArray(val) || !val.every((v) => typeof v === "string")) {
+            return [];
+        }
+        return val;
+    }
+    /** @hidden */
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    greaterThan(rhs) {
+        throw new Error(">/< comparison operators not supported on params of type List");
+    }
+    /** @hidden */
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    greaterThanOrEqualTo(rhs) {
+        throw new Error(">/< comparison operators not supported on params of type List");
+    }
+    /** @hidden */
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    lessThan(rhs) {
+        throw new Error(">/< comparison operators not supported on params of type List");
+    }
+    /** @hidden */
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    lessThanorEqualTo(rhs) {
+        throw new Error(">/< comparison operators not supported on params of type List");
+    }
+}
+exports.ListParam = ListParam;
+ListParam.type = "list";

package/lib/v1/function-configuration.d.ts

@@ -141,7 +141,7 @@ export interface RuntimeOptions {
     /**
      * Connect cloud function to specified VPC connector.
      */
-    vpcConnector?: string | ResetValue;
+    vpcConnector?: string | Expression<string> | ResetValue;
     /**
      * Egress settings for VPC connector.
      */

package/lib/v1/providers/testLab.d.ts

@@ -121,7 +121,7 @@ export declare class ResultStorage {
  * - `USE_DESTINATION_ARTIFACTS`: One or more of the test targets defined in the
  *   .xctestrun file specifies "UseDestinationArtifacts", which is disallowed.
  *
- * - `TEST_NON_APP_HOSTED`: XC tests which run on physical devices must have
+ * - `TEST_NOT_APP_HOSTED`: XC tests which run on physical devices must have
  *   "IsAppHostedTestBundle" == "true" in the xctestrun file.
  *
  * - `PLIST_CANNOT_BE_PARSED`: An Info.plist file in the XCTest zip could not be

package/lib/v2/options.d.ts

@@ -83,7 +83,7 @@ export interface GlobalOptions {
     /**
      * Connect cloud function to specified VPC connector.
      */
-    vpcConnector?: string | ResetValue;
+    vpcConnector?: string | Expression<string> | ResetValue;
     /**
      * Egress settings for VPC connector.
      */

package/lib/v2/providers/alerts/alerts.d.ts

@@ -97,7 +97,7 @@ export interface FirebaseAlertOptions extends options.EventHandlerOptions {
      * Connect cloud function to specified VPC connector.
      * A value of null removes the VPC connector
      */
-    vpcConnector?: string | ResetValue;
+    vpcConnector?: string | Expression<string> | ResetValue;
     /**
      * Egress settings for VPC connector.
      * A value of null turns off VPC connector egress settings

package/lib/v2/providers/alerts/appDistribution.d.ts

@@ -123,7 +123,7 @@ export interface AppDistributionOptions extends options.EventHandlerOptions {
     /**
      * Connect cloud function to specified VPC connector.
      */
-    vpcConnector?: string | ResetValue;
+    vpcConnector?: string | Expression<string> | ResetValue;
     /**
      * Egress settings for VPC connector.
      */

package/lib/v2/providers/alerts/crashlytics.d.ts

@@ -189,7 +189,7 @@ export interface CrashlyticsOptions extends options.EventHandlerOptions {
     /**
      * Connect cloud function to specified VPC connector.
      */
-    vpcConnector?: string | ResetValue;
+    vpcConnector?: string | Expression<string> | ResetValue;
     /**
      * Egress settings for VPC connector.
      */

package/lib/v2/providers/database.d.ts

@@ -111,7 +111,7 @@ export interface ReferenceOptions<Ref extends string = string> extends options.E
     /**
      * Connect cloud function to specified VPC connector.
      */
-    vpcConnector?: string | ResetValue;
+    vpcConnector?: string | Expression<string> | ResetValue;
     /**
      * Egress settings for VPC connector.
      */

package/lib/v2/providers/database.js

@@ -178,7 +178,7 @@ function onChangedOperation(eventType, referenceOrOpts, handler) {
     // wrap the handler
     const func = (raw) => {
         const event = raw;
-        const instanceUrl = `https://${event.instance}.${event.firebasedatabasehost}`;
+        const instanceUrl = getInstance(event);
         const params = makeParams(event, pathPattern, instancePattern);
         const databaseEvent = makeChangedDatabaseEvent(event, instanceUrl, params);
         return (0, trace_1.wrapTraceContext)(handler)(databaseEvent);
@@ -196,7 +196,7 @@ function onOperation(eventType, referenceOrOpts, handler) {
     // wrap the handler
     const func = (raw) => {
         const event = raw;
-        const instanceUrl = `https://${event.instance}.${event.firebasedatabasehost}`;
+        const instanceUrl = getInstance(event);
         const params = makeParams(event, pathPattern, instancePattern);
         const data = eventType === exports.deletedEventType ? event.data.data : event.data.delta;
         const databaseEvent = makeDatabaseEvent(event, data, instanceUrl, params);
@@ -207,3 +207,9 @@ function onOperation(eventType, referenceOrOpts, handler) {
     return func;
 }
 exports.onOperation = onOperation;
+function getInstance(event) {
+    const emuHost = process.env.FIREBASE_DATABASE_EMULATOR_HOST;
+    return emuHost
+        ? `http://${emuHost}/?ns=${event.instance}`
+        : `https://${event.instance}.${event.firebasedatabasehost}`;
+}

package/lib/v2/providers/eventarc.d.ts

@@ -88,7 +88,7 @@ export interface EventarcTriggerOptions extends options.EventHandlerOptions {
     /**
      * Connect cloud function to specified VPC connector.
      */
-    vpcConnector?: string | ResetValue;
+    vpcConnector?: string | Expression<string> | ResetValue;
     /**
      * Egress settings for VPC connector.
      */

package/lib/v2/providers/eventarc.js

@@ -67,6 +67,12 @@ function onCustomEventPublished(eventTypeOrOpts, handler) {
     (0, encoding_1.convertIfPresent)(endpoint.eventTrigger, opts, "eventFilters", "filters");
     (0, encoding_1.copyIfPresent)(endpoint.eventTrigger, opts, "retry");
     func.__endpoint = endpoint;
+    func.__requiredAPIs = [
+        {
+            api: "eventarcpublishing.googleapis.com",
+            reason: "Needed for custom event functions",
+        },
+    ];
     return func;
 }
 exports.onCustomEventPublished = onCustomEventPublished;

package/lib/v2/providers/https.d.ts

@@ -75,7 +75,7 @@ export interface HttpsOptions extends Omit<GlobalOptions, "region"> {
     /**
      * Connect cloud function to specified VPC connector.
      */
-    vpcConnector?: string | ResetValue;
+    vpcConnector?: string | Expression<string> | ResetValue;
     /**
      * Egress settings for VPC connector.
      */

package/lib/v2/providers/https.js

@@ -44,7 +44,11 @@ function onRequest(optsOrHandler, handler) {
         opts = optsOrHandler;
     }
     if ((0, debug_1.isDebugFeatureEnabled)("enableCors") || "cors" in opts) {
-        const origin = (0, debug_1.isDebugFeatureEnabled)("enableCors") ? true : opts.cors;
+        let origin = opts.cors;
+        if ((0, debug_1.isDebugFeatureEnabled)("enableCors")) {
+            // Respect `cors: false` to turn off cors even if debug feature is enabled.
+            origin = opts.cors === false ? false : true;
+        }
         const userProvidedHandler = handler;
         handler = (req, res) => {
             return new Promise((resolve) => {

package/lib/v2/providers/identity.d.ts

@@ -86,7 +86,7 @@ export interface BlockingOptions {
     /**
      * Connect cloud function to specified VPC connector.
      */
-    vpcConnector?: string | ResetValue;
+    vpcConnector?: string | Expression<string> | ResetValue;
     /**
      * Egress settings for VPC connector.
      */

package/lib/v2/providers/pubsub.d.ts

@@ -144,7 +144,7 @@ export interface PubSubOptions extends options.EventHandlerOptions {
     /**
      * Connect cloud function to specified VPC connector.
      */
-    vpcConnector?: string | ResetValue;
+    vpcConnector?: string | Expression<string> | ResetValue;
     /**
      * Egress settings for VPC connector.
      */

package/lib/v2/providers/storage.d.ts

@@ -220,7 +220,7 @@ export interface StorageOptions extends options.EventHandlerOptions {
     /**
      * Connect cloud function to specified VPC connector.
      */
-    vpcConnector?: string | ResetValue;
+    vpcConnector?: string | Expression<string> | ResetValue;
     /**
      * Egress settings for VPC connector.
      */

package/lib/v2/providers/tasks.d.ts

@@ -79,7 +79,7 @@ export interface TaskQueueOptions extends options.EventHandlerOptions {
     /**
      * Connect cloud function to specified VPC connector.
      */
-    vpcConnector?: string | ResetValue;
+    vpcConnector?: string | Expression<string> | ResetValue;
     /**
      * Egress settings for VPC connector.
      */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "firebase-functions",
-  "version": "4.1.1",
+  "version": "4.2.1",
   "description": "Firebase SDK for Cloud Functions",
   "keywords": [
     "firebase",
@@ -201,7 +201,7 @@
     "@microsoft/api-extractor": "^7.18.7",
     "@types/chai": "^4.1.7",
     "@types/chai-as-promised": "^7.1.0",
-    "@types/jsonwebtoken": "^8.3.2",
+    "@types/jsonwebtoken": "^9.0.0",
     "@types/mocha": "^5.2.7",
     "@types/mock-require": "^2.0.0",
     "@types/nock": "^10.0.3",
@@ -222,7 +222,7 @@
     "firebase-admin": "^10.3.0",
     "js-yaml": "^3.13.1",
     "jsdom": "^16.2.1",
-    "jsonwebtoken": "^8.5.1",
+    "jsonwebtoken": "^9.0.0",
     "jwk-to-pem": "^2.0.5",
     "mocha": "^6.1.4",
     "mock-require": "^3.0.3",