filegrc 0.13.0 → 0.13.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "filegrc",
-  "version": "0.13.0",
+  "version": "0.13.2",
   "description": "Zero-dependency Git-native GRC engine",
   "license": "MIT",
   "repository": {
@@ -22,7 +22,9 @@
   ],
   "scripts": {
     "test": "node ../../scripts/run-filegrc-tests.mjs",
-    "test:fast": "node ../../scripts/run-filegrc-tests.mjs --fast",
+    "test:unit": "node ../../scripts/run-filegrc-tests.mjs --tier unit",
+    "test:integration": "node ../../scripts/run-filegrc-tests.mjs --tier integration",
+    "test:fast": "npm run test:unit",
     "test:full": "npm test"
   },
   "engines": {

package/src/collection-review.js

@@ -102,17 +102,37 @@ export async function scaffoldCollectionReview(input = process.cwd(), options =
   const resourceType = requiredType(loaded, options.resourceType);
   const assessment = assessCollectionReview(loaded, resourceType, { programId: program.id });
   const allowedDecisions = assessment.configuration.decisions || ["complete"];
+  const now = options.now ? new Date(options.now) : new Date();
+  if (Number.isNaN(now.getTime())) throw new Error("A valid Collection Review time is required.");
+  const priorReview = assessment.review;
+  const v4 = modelSupports(loaded.model, "program-scope");
+  const priorAuthoritativeSourceId = priorReview?.authoritativeComponentId || priorReview?.authoritativeSystemId || null;
+  const priorAuthoritativeSourceActive = priorReview?.decision !== "externally-managed" || loaded.resources.some((record) => (
+    record.type === (v4 ? "component" : "system")
+    && record.id === priorAuthoritativeSourceId
+    && record.status === "active"
+  ));
+  const priorDecisionStillValid = allowedDecisions.includes(priorReview?.decision)
+    && priorAuthoritativeSourceActive
+    && (assessment.records.length
+      ? priorReview.decision !== "zero-population"
+      : priorReview.decision !== "complete");
+  const preservedAuthoritativeSourceId = priorDecisionStillValid && priorReview.decision === "externally-managed"
+    ? priorAuthoritativeSourceId
+    : null;
   return {
     resourceType,
-    decision: assessment.records.length
+    decision: priorDecisionStillValid ? priorReview.decision : (assessment.records.length
       ? "complete"
-      : allowedDecisions.includes("zero-population") ? "zero-population" : null,
-    rationale: null,
-    reviewedByIds: [],
-    reviewedOn: null,
-    ...(modelSupports(loaded.model, "program-scope")
-      ? { authoritativeComponentId: null }
-      : { authoritativeSystemId: null })
+      : allowedDecisions.includes("zero-population") ? "zero-population" : null),
+    rationale: priorReview?.rationale || null,
+    reviewedByIds: [...(priorReview?.reviewedByIds || [])],
+    reviewedOn: priorReview?.reviewedOn
+      ? currentCalendarDate(loaded.workspace.timezone, now)
+      : null,
+    ...(v4
+      ? { authoritativeComponentId: preservedAuthoritativeSourceId }
+      : { authoritativeSystemId: preservedAuthoritativeSourceId })
   };
 }
 

package/src/files.js

@@ -965,14 +965,22 @@ async function updateContentUnlocked(input, dataRelativePath, source, options) {
   const path = resolveDataPath(loaded.root, dataRelativePath);
   const previous = await readFile(path, "utf8");
   assertRevision(previous, options.expectedRevision, "The Markdown file");
-  const before = await validateWorkspace(loaded);
+  const deferValidation = workspaceValidationDeferred();
+  const before = deferValidation ? null : await validateWorkspace(loaded);
   const nextSource = source.endsWith("\n") ? source : `${source}\n`;
   await writeTextAtomic(path, nextSource);
   try {
-    const result = await validateWorkspace(loaded.root);
-    const introduced = newErrors(result, before);
-    if (introduced.length) throw new Error(formatWriteFailure(introduced, dataRelativePath));
-    return { path, dataRelativePath };
+    if (!deferValidation) {
+      const result = await validateWorkspace(loaded.root);
+      const introduced = newErrors(result, before);
+      if (introduced.length) throw new Error(formatWriteFailure(introduced, dataRelativePath));
+    }
+    return {
+      path,
+      dataRelativePath,
+      source: nextSource,
+      revision: contentRevision(nextSource)
+    };
   } catch (error) {
     await writeTextAtomic(path, previous);
     throw error;