fiftyone.pipeline.cloudrequestengine 4.4.92 → 4.4.94

package/cloudRequestEngine.js

@@ -52,7 +52,7 @@ class CloudRequestEngine extends Engine {
    * made from a origin matching those allowed by the resource key.
    * For more detail, see the 'Request Headers' section in the
    * <a href="https://cloud.51degrees.com/api-docs/index.html">cloud documentation</a>.
-   * @param options.requestClient
+   * @param {RequestClient} options.requestClient Set predefined RequestClient.
    */
   constructor (
     {
@@ -176,8 +176,7 @@ class CloudRequestEngine extends Engine {
    * However, transport level errors or other failures can result in
    * responses that are plain text. This function handles these cases.
    *
-   * @param {string} response the response data to process
-   * @param responseBody
+   * @param {string} responseBody the response data to process
    * @returns {Array} The error messages
    */
   getErrorMessages (responseBody) {
@@ -196,7 +195,8 @@ class CloudRequestEngine extends Engine {
   /**
    * Used to handle errors from http requests
    *
-   * @param response
+   * @param {http.ServerResponse} response Responce to get errors from
+   * @returns {Array<CloudRequestError>} Array of CloudRequestError from response
    */
   getErrorsFromResponse (response) {
     let content = response;
@@ -370,7 +370,7 @@ class CloudRequestEngine extends Engine {
    * If there are evidence keys other than 'query.' that conflict then
    * this is unexpected so a warning will be logged.
    *
-   * @param {FlowData} flowData
+   * @param {FlowData} flowData FlowData to get evidence from
    * @returns {Evidence} Evidence Dictionary
    */
   getContent (flowData) {
@@ -393,7 +393,7 @@ class CloudRequestEngine extends Engine {
   /**
    * Add query data to the evidence.
    *
-   * @param flowData
+   * @param {FlowData} flowData FlowData for logging
    * @param {object} queryData The destination dictionary to add query data to.
    * @param {Evidence} allEvidence All evidence in the flow data. This is used to
    * report which evidence keys are conflicting.
@@ -449,6 +449,7 @@ class CloudRequestEngine extends Engine {
    *
    * @param {Evidence} evidence All evidence in the flow data.
    * @param {stirng} type Required evidence key prefix
+   * @returns {Evidence} Selected evidence
    */
   getSelectedEvidence (evidence, type) {
     let selectedEvidence = {};
@@ -483,7 +484,7 @@ class CloudRequestEngine extends Engine {
    *
    * @param {string} itemKey Key to check
    * @param {string} prefix The prefix to check for.
-   * @returns True if the key has the prefix.
+   * @returns {boolean} True if the key has the prefix.
    */
   hasKeyPrefix (itemKey, prefix) {
     return itemKey.startsWith(prefix + '.');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fiftyone.pipeline.cloudrequestengine",
-  "version": "4.4.92",
+  "version": "4.4.94",
   "description": "Cloud request engine for the 51Degrees Pipeline API",
   "keywords": [
     "51degrees",

package/requestClient.js

@@ -28,7 +28,7 @@ class RequestClient {
    * @param {*} data The data to send in the body of the request
    * @param {*} origin The value to use for the Origin header when
    * making the request
-   * @returns a Promise. The resolve function will be passed the content
+   * @returns {Promise} The resolve function will be passed the content
    * from the response and the reject function will be passed
    * an object with 3 properties:
    * headers = HTTP headers in the response
@@ -43,9 +43,8 @@ class RequestClient {
     } else {
       httpModule = require('http');
     }
-
+    let requestData = '';
     if (data) {
-      var requestData = '';
       const keys = Object.keys(data);
       for (let i = 0; i < keys.length; i++) {
         requestData += encodeURIComponent(keys[i]) + '=' + encodeURIComponent(data[keys[i]]);
@@ -104,7 +103,7 @@ class RequestClient {
    * @param {*} url The url to send a request to
    * @param {*} origin The value to use for the Origin header when
    * making the request
-   * @returns a Promise. The resolve function will be passed the content
+   * @returns {Promise} The resolve function will be passed the content
    * from the response and the reject function will be passed
    * an object with 3 properties:
    * headers = HTTP headers in the response

package/tests/cloudResponse.test.js

@@ -215,9 +215,10 @@ test('validate case when cloud unavailable', (done) => {
 });
 
 /**
+ *  Check if Properties contains name
  *
- * @param properties
- * @param name
+ * @param {object} properties Object of properties
+ * @param {string} name Name of the property
  */
 function propertiesContainName (properties, name) {
   expect(properties[name.toLowerCase()]).not.toBeUndefined();