fhir-persistence 0.7.0 → 0.9.0

package/CHANGELOG.md

@@ -5,6 +5,52 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.9.0] - 2025-03-20
+
+### Fixed
+
+#### Bug-3: Token WHERE clause code-only / empty-system matching failure (P0)
+
+- **`buildTokenColumnFragmentV2()`** (v2, SQLite) and **`buildTokenColumnFragment()`** (v1, PostgreSQL) — corrected token value resolution logic per FHIR spec:
+  - `system|code` → exact match against stored `"system|code"` ✅
+  - `|code` → exact match against stored `"|code"` (empty system, keep pipe) ✅
+  - `system|` → `LIKE "system|%"` (any code within system) ✅
+  - `code` (bare, no pipe) → `LIKE "%|code"` (any system, match code) ✅
+- **Root cause**: Previous logic stripped leading `|` from `|code` values and used exact match for bare codes, causing zero results for `gender=male` (stored as `"|male"`) and `gender=|male`
+- **Impact**: All token searches using bare code or `|code` format now correctly match stored values
+- New helper: `arrayContainsLikeV2()` generates dialect-aware `LIKE` subqueries (SQLite `json_each` / PostgreSQL `unnest`)
+
+### Test Coverage
+
+- **1065 total tests** (1057 passing, 8 skipped) across 63 test files — no regressions
+- **5 new Bug-3 regression tests** in v2 and v1 test suites verifying all four token formats
+
+## [0.8.0] - 2025-03-20
+
+### Fixed
+
+#### Bug-1 + Bug-2: Token-column WHERE clause column name mismatch (P0)
+
+- **`buildTokenColumnFragment()`** (v1, PostgreSQL `$N` placeholders) — changed `__${columnName}Text` → `__${columnName}` to match DDL column name
+- **`buildTokenColumnFragmentV2()`** (v2, SQLite `?` placeholders) — same fix, aligning with DDL `__<name>` column
+- **Root cause**: WHERE clause referenced a non-existent `__genderText` column while DDL only creates `__gender` (TEXT, JSON array of `system|code` strings) and `__genderSort` (TEXT, display)
+- **Impact**: All token search queries (`GET /Patient?gender=male`) previously failed with `no such column: __genderText`
+- DDL / INSERT / WHERE column names now fully aligned: `__<name>` for token array, `__<name>Sort` for display text
+
+### Changed
+
+- **`search-parameter-registry.ts`** — Corrected `SearchStrategy` documentation: token-column uses 2 columns (not 3)
+
+### Confirmed
+
+- **Enh-1**: R4 standard SP loading (`name`, `identifier`, etc.) depends on external `DefinitionProvider` — not a persistence-layer issue
+- **Enh-2**: `ifMatch` optimistic locking is fully implemented in both `FhirStore` and `FhirPersistence` with test coverage
+
+### Test Coverage
+
+- **1062 total tests** (1054 passing, 8 skipped) across 63 test files — no regressions
+- **1 new regression test** for Bug-1: verifies token column references `__<name>` not `__<name>Text`
+
 ## [0.7.0] - 2025-03-18
 
 ### Added

package/README.md

@@ -5,7 +5,7 @@ Embedded FHIR R4 persistence layer — CRUD, search, indexing, and schema migrat
 [![npm version](https://img.shields.io/npm/v/fhir-persistence)](https://www.npmjs.com/package/fhir-persistence)
 [![License: MIT](https://img.shields.io/badge/License-MIT-blue.svg)](./LICENSE)
 
-> **v0.7.0** — Conformance storage module for IG Explorer: 6 repos + import orchestrator
+> **v0.9.0** — Token search fix: FHIR-correct code-only / empty-system matching (`|code`, `code`)
 
 ## Features
 

package/dist/cjs/index.cjs

@@ -5339,36 +5339,43 @@ function buildUriFragmentV2(impl, param, dialect) {
   return buildOrFragmentV2(col, "=", param.values);
 }
 function buildTokenColumnFragmentV2(impl, param, dialect) {
-  const textCol = quoteColumn(`__${impl.columnName}Text`);
+  const textCol = quoteColumn(`__${impl.columnName}`);
   const sortCol = quoteColumn(`__${impl.columnName}Sort`);
   if (param.modifier === "text") {
     return buildLikeFragmentV2(sortCol, param.values, "", "%");
   }
-  const needsLike = param.values.some((v) => v.endsWith("|"));
-  if (needsLike) {
-    const conds = [];
-    const vals = [];
-    for (const value of param.values) {
+  const exactValues = [];
+  const likePatterns = [];
+  for (const value of param.values) {
+    if (value.includes("|")) {
       if (value.endsWith("|")) {
-        const frag = arrayContainsLikeV2(textCol, value + "%", dialect);
-        conds.push(frag.sql);
-        vals.push(...frag.values);
+        likePatterns.push(value + "%");
       } else {
-        const resolved = value.startsWith("|") ? value.slice(1) : value;
-        const frag = arrayContainsV2(textCol, [resolved], dialect);
-        conds.push(frag.sql);
-        vals.push(...frag.values);
+        exactValues.push(value);
       }
+    } else {
+      likePatterns.push(`%|${value}`);
     }
-    const inner = conds.length === 1 ? conds[0] : `(${conds.join(" OR ")})`;
-    const sql = param.modifier === "not" ? `NOT (${inner})` : inner;
-    return { sql, values: vals };
   }
-  const resolvedValues = param.values.map((v) => v.startsWith("|") ? v.slice(1) : v);
-  if (param.modifier === "not") {
-    return arrayNotContainsV2(textCol, resolvedValues, dialect);
-  }
-  return arrayContainsV2(textCol, resolvedValues, dialect);
+  const conds = [];
+  const vals = [];
+  if (exactValues.length > 0) {
+    const frag = param.modifier === "not" ? arrayNotContainsV2(textCol, exactValues, dialect) : arrayContainsV2(textCol, exactValues, dialect);
+    conds.push(frag.sql);
+    vals.push(...frag.values);
+  }
+  for (const pattern of likePatterns) {
+    const frag = arrayContainsLikeV2(textCol, pattern, dialect);
+    const sql = param.modifier === "not" ? `NOT (${frag.sql})` : frag.sql;
+    conds.push(sql);
+    vals.push(...frag.values);
+  }
+  if (conds.length === 0) {
+    return { sql: "1=1", values: [] };
+  }
+  const joiner = param.modifier === "not" ? " AND " : " OR ";
+  const inner = conds.length === 1 ? conds[0] : `(${conds.join(joiner)})`;
+  return { sql: inner, values: vals };
 }
 function buildDefaultFragmentV2(impl, param) {
   const col = quoteColumn(impl.columnName);