fg-devkit 1.14.3 → 1.14.5

package/.cursor/rules/core-coding-standards.mdc

@@ -11,6 +11,13 @@ alwaysApply: true
 - Avoid unrelated refactors in the same task.
 - Preserve existing behavior unless a behavior change is requested.
 
+## Code comments
+
+- Do not add comments in code unless the user explicitly asks for them.
+- Prefer self-explanatory naming and structure over inline comments.
+- When updating existing code, do not add new comments or expand existing ones unless requested.
+- Exception: update comments only when they are required to keep an existing comment accurate after a behavior change in the same task.
+
 ## Communication efficiency
 
 - Do not waste tokens: keep responses concise, high-signal, and scoped to the request.
@@ -33,7 +40,7 @@ alwaysApply: true
 - Keep TypeScript and Vue template typing strict (`strict: true`, `strictTemplates: true`).
 - Do not introduce `any`; use `unknown` for unsafe input and narrow before use.
 - Type API boundaries explicitly (request payloads, response DTOs, mutation variables, callback contracts).
-- Prefer named reusable types (for example under `src/types`) for shared domain shapes.
+- Prefer named reusable types under `src/types/<domain>/` for shared domain shapes; re-export from `src/types/index.ts`. Do not keep shared interfaces in views, stores, or query files.
 - Avoid non-null assertions unless guarded by `enabled` checks or equivalent runtime guarantees.
 
 ## API boundaries
@@ -44,9 +51,10 @@ alwaysApply: true
 
 ## State-management boundaries
 
-- Use TanStack Query (or the project’s chosen data library) for server state and caching.
-- Use Pinia/Vuex only for client/app state that is not owned by the server.
-- Do not duplicate the same state across the query cache and global stores unless the project explicitly documents that pattern.
+- Use TanStack Query for server state and caching. Do not add Vuex for new work.
+- Use Pinia only for client/app state that is not owned by the server (for example `src/pinia/*`).
+- Do not duplicate the same state across the query cache and Pinia unless the project explicitly documents that pattern.
+- When a project is migrating Vuex → Query/Pinia, follow that repo’s local migration rules (if present) instead of expanding Vuex.
 
 ## TanStack Query server-state conventions
 
@@ -85,6 +93,7 @@ alwaysApply: true
 ## FDS-first component usage
 
 - Use `fds-vue-core` components as the default choice for UI building blocks.
+- Multi-step wizards use `FdsWizard` from `fds-vue-core`. Follow the project’s wizard rule file when one exists (for example `.cursor/rules/fds-wizard.md`).
 - Before adding custom UI, check whether an FDS component already solves the use case.
 - Prefer extending composition around FDS components over re-implementing design-system behavior.
 - Keep visual consistency by matching FDS variants, spacing patterns, and interaction styles.
@@ -113,6 +122,7 @@ alwaysApply: true
 - Keep spacing and typography explicit in class names; avoid hidden styling in deep selectors.
 - Use `!` utility overrides sparingly and only when a component default cannot be changed safely.
 - For Tailwind v4 important modifiers, use postfix-important utility syntax (for example `grid-cols-1!`) instead of prefix syntax (for example `!grid-cols-1`).
+- Stack repeated items with parent `flex flex-col gap-*` (or `space-y-*`). Do not use `mb-* last:mb-0` or `last-of-type:mb-*` — those variants often miss the last `v-for` item (extra Vue/FDS nodes) and trip Tailwind conflict lint.
 
 ## Figma MCP implementation workflow
 
@@ -166,9 +176,11 @@ alwaysApply: true
 
 ## Testing expectations
 
-- For non-trivial logic changes, add or update automated tests close to the affected feature.
-- Validate critical flows for changed views: loading, empty, error, and success states.
+- Do not add new automated tests unless the user explicitly asks for them.
+- Update existing tests when your change requires it (for example broken assertions, renamed APIs, or changed behavior covered by current tests).
+- When new tests are requested, add them close to the affected feature.
 - Keep tests behavior-focused and avoid brittle implementation-detail assertions.
+- When no new tests are requested, rely on lint, typecheck, and manual verification of critical flows where practical.
 
 ## CI/CD
 
@@ -178,7 +190,8 @@ alwaysApply: true
 
 ## Quality checks before finishing
 
-- Run relevant checks for touched code (lint, typecheck, or tests when practical).
+- Run relevant checks for touched code (lint and typecheck when practical).
+- Run and update existing tests when your change affects them; add new tests only when the user explicitly requests them.
 - Fix issues introduced by your change before handing off.
 - Call out anything you could not verify.
 

package/README.md

@@ -63,13 +63,6 @@ pnpm exec fgd fallow dead-code --json
 
 When you run `fgd sync-tooling-configs` (or `fgd sync-project-configs`), fg-devkit also writes a shared `.fallowrc.json` to the consuming repo.
 
-To remove redundant tooling dependencies from a consuming repo:
-
-```bash
-pnpm exec fgd prune-consumer-deps
-pnpm install
-```
-
 To sync standard consumer scripts to `fgd` commands:
 
 ```bash

package/configs/dependency-policy.vue-workspace.json

@@ -1,6 +1,6 @@
 {
   "toolchain": {
-    "packageManager": "pnpm@11.21.0",
+    "packageManager": "pnpm@11.22.0",
     "node": {
       "nvmrc": "22",
       "engines": ">=22.13.0",
@@ -33,7 +33,7 @@
       "content-disposition-header": "0.6.0",
       "date-fns": "4.4.0",
       "element-plus": "2.14.4",
-      "fds-vue-core": "8.4.3",
+      "fds-vue-core": "8.5.1",
       "imask": "7.6.1",
       "leaflet": "1.9.4",
       "lexical": "0.49.0",
@@ -59,15 +59,15 @@
     "devDependencies": {
       "@chromatic-com/storybook": "5.3.0",
       "@eslint/js": "9.39.1",
-      "@intlify/unplugin-vue-i18n": "11.2.4",
+      "@intlify/unplugin-vue-i18n": "11.2.5",
       "@playwright/test": "1.62.1",
-      "@storybook/addon-a11y": "10.5.7",
-      "@storybook/addon-docs": "10.5.7",
-      "@storybook/addon-vitest": "10.5.7",
-      "@storybook/vue3": "10.5.7",
-      "@storybook/vue3-vite": "10.5.7",
+      "@storybook/addon-a11y": "10.5.8",
+      "@storybook/addon-docs": "10.5.8",
+      "@storybook/addon-vitest": "10.5.8",
+      "@storybook/vue3": "10.5.8",
+      "@storybook/vue3-vite": "10.5.8",
       "@tanstack/vue-query-devtools": "6.1.38",
-      "@tsconfig/node22": "22.0.5",
+      "@tsconfig/node22": "22.0.6",
       "@types/lodash-es": "4.17.12",
       "@types/node": "22.16.5",
       "@vitest/browser": "4.1.10",
@@ -77,13 +77,13 @@
       "@vue/test-utils": "2.4.11",
       "arg": "5.0.2",
       "babel-eslint": "10.1.0",
-      "eslint-plugin-storybook": "10.5.7",
+      "eslint-plugin-storybook": "10.5.8",
       "globals": "15.11.0",
       "jsdom": "26.1.0",
       "sass": "1.102.0",
-      "storybook": "10.5.7",
+      "storybook": "10.5.8",
       "tsx": "4.23.12",
-      "vega": "6.3.1",
+      "vega": "6.4.0",
       "vite-plugin-dts": "4.5.4",
       "vite-plugin-vue-devtools": "8.2.1",
       "vitest": "4.1.10",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "fg-devkit",
-  "version": "1.14.3",
+  "version": "1.14.5",
   "description": "Shared configs, scripts, and DX tooling for Vue / TypeScript frontend repos",
   "type": "module",
   "license": "UNLICENSED",
@@ -27,7 +27,6 @@
     "./scripts/sync-project-configs.mjs": "./scripts/sync-project-configs.mjs",
     "./scripts/sync-consumer-scripts.mjs": "./scripts/sync-consumer-scripts.mjs",
     "./scripts/sync-consumer-lefthook.mjs": "./scripts/sync-consumer-lefthook.mjs",
-    "./scripts/prune-consumer-deps.mjs": "./scripts/prune-consumer-deps.mjs",
     "./scripts/policy-outdated.mjs": "./scripts/policy-outdated.mjs",
     "./scripts/policy-vulns.mjs": "./scripts/policy-vulns.mjs",
     "./scripts/repo-vulns.mjs": "./scripts/repo-vulns.mjs",
@@ -124,7 +123,7 @@
     "tsx": "4.23.12",
     "typescript": "5.9.3",
     "vue-eslint-parser": "10.4.1",
-    "vue-tsc": "3.3.9"
+    "vue-tsc": "3.3.10"
   },
   "devDependencies": {
     "cz-git": "1.13.2",

package/scaffold/vue/package.json

@@ -21,7 +21,7 @@
     "content-disposition-header": "0.6.0",
     "date-fns": "4.4.0",
     "dotenv": "16.4.5",
-    "fds-vue-core": "8.4.3",
+    "fds-vue-core": "8.5.1",
     "pinia": "3.0.4",
     "qrcode.vue": "3.10.0",
     "vue": "3.5.41",
@@ -29,16 +29,16 @@
     "vue-router": "4.6.3"
   },
   "devDependencies": {
-    "@intlify/unplugin-vue-i18n": "11.2.4",
+    "@intlify/unplugin-vue-i18n": "11.2.5",
     "@tanstack/vue-query-devtools": "6.1.38",
     "@types/node": "22.16.5",
     "@vitejs/plugin-vue": "6.0.8",
-    "fg-devkit": "1.14.3",
+    "fg-devkit": "1.14.5",
     "tailwindcss": "4.3.3",
     "tsx": "4.23.12",
     "vite": "7.3.5"
   },
-  "packageManager": "pnpm@11.21.0",
+  "packageManager": "pnpm@11.22.0",
   "engines": {
     "node": ">=22.13.0"
   }

package/scripts/fg-devkit.mjs

@@ -23,7 +23,6 @@
  *   pnpm exec fg-devkit sync-core-coding-standards
  *   pnpm exec fg-devkit sync-consumer-scripts
  *   pnpm exec fg-devkit setup-lefthook
- *   pnpm exec fg-devkit prune-consumer-deps [--dry-run]
  *   pnpm exec fg-devkit full-consumer-setup
  *   pnpm exec fg-devkit create-release [release|candidate] [patch|minor|major] [--skip-release-notes]
  *   pnpm exec fg-devkit generate-release-notes [--tag=vX.Y.Z]
@@ -145,7 +144,6 @@ function runSetupLefthook() {
 
 /**
  * Full consumer setup flow:
- * - Step 7: remove unnecessary deps
  * - Sync required consumer scripts for fgd commands
  * - Setup lefthook and migrate from husky/lint-staged
  * - Step 3: sync project configs
@@ -155,9 +153,6 @@ function runSetupLefthook() {
 function runFullConsumerSetup() {
   console.log('[fg-devkit] Running full consumer sync and setup')
 
-  const step7 = runNode('prune-consumer-deps.mjs')
-  if (step7 !== 0) return step7
-
   const scriptsStep = runNode('sync-consumer-scripts.mjs')
   if (scriptsStep !== 0) return scriptsStep
 
@@ -487,7 +482,6 @@ const DIRECT_COMMANDS = {
   'generate-release-notes': 'generate-release-notes.mjs',
   'verify-release-notes': 'verify-release-notes.mjs',
   'setup-lefthook': 'setup-lefthook',
-  'prune-consumer-deps': 'prune-consumer-deps.mjs',
   'sync-scaffold-vue-deps': 'sync-scaffold-vue-deps.mjs',
   'poeditor-download': 'poeditor-download.mjs',
   'poeditor-upload': 'poeditor-upload.mjs',
@@ -546,8 +540,7 @@ Commands:
   sync-core-coding-standards      Copy .cursor core coding standards with consumer package name
   sync-consumer-scripts           Enforce standard fgd scripts in consumer package.json
   setup-lefthook                  Setup lefthook and migrate from husky/lint-staged
-  prune-consumer-deps [--dry-run] Remove consumer tooling deps bundled by fg-devkit
-  full-consumer-setup             Run: step 7 -> scripts -> lefthook -> step 3 -> step 2 -> pnpm install
+  full-consumer-setup             Run: scripts -> lefthook -> step 3 -> step 2 -> pnpm install
   create-release [release|candidate] [patch|minor|major] [--skip-release-notes]
                                  Stable release or candidate (X.Y.Z-rc.N); omit = interactive menu
                                  (alias: createRelease)

package/scripts/prune-consumer-deps.mjs

@@ -1,101 +0,0 @@
-#!/usr/bin/env node
-/**
- * Removes tooling dependencies from a consuming repo that are now bundled by fg-devkit.
- *
- * By default this script edits package.json in the current working directory and removes
- * known ESLint/Prettier/TypeScript/cz-git tooling packages from dependencies/devDependencies.
- *
- * Usage:
- *   node node_modules/fg-devkit/scripts/prune-consumer-deps.mjs
- *   pnpm exec fg-devkit prune-consumer-deps
- *   pnpm exec fg-devkit prune-consumer-deps --dry-run
- */
-
-import fs from 'node:fs'
-import path from 'node:path'
-
-const BUNDLED_TOOLING_PACKAGES = new Set([
-  '@intlify/eslint-plugin-vue-i18n',
-  '@typescript-eslint/eslint-plugin',
-  '@typescript-eslint/parser',
-  '@vitest/eslint-plugin',
-  '@vue/eslint-config-prettier',
-  '@vue/eslint-config-typescript',
-  '@vue/tsconfig',
-  '@rushstack/eslint-patch',
-  'commitizen',
-  'cz-git',
-  'czg',
-  'eslint',
-  'eslint-plugin-prettier',
-  'eslint-plugin-vue',
-  'husky',
-  'jsonc-eslint-parser',
-  'lint-staged',
-  'lefthook',
-  'prettier',
-  'typescript',
-  'yaml-eslint-parser',
-  'vue-eslint-parser',
-  'vue-tsc',
-])
-
-function readPackageJson(packageJsonPath) {
-  if (!fs.existsSync(packageJsonPath)) {
-    console.error(`[prune-consumer-deps] No package.json found at ${packageJsonPath}`)
-    process.exit(1)
-  }
-  try {
-    return JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'))
-  } catch (err) {
-    console.error(`[prune-consumer-deps] Failed to parse package.json: ${err.message}`)
-    process.exit(1)
-  }
-}
-
-function removeFromSection(pkg, sectionName, removed) {
-  const section = pkg[sectionName]
-  if (!section || typeof section !== 'object') {
-    return
-  }
-  for (const name of Object.keys(section)) {
-    if (BUNDLED_TOOLING_PACKAGES.has(name)) {
-      removed.push(`${sectionName}.${name}@${section[name]}`)
-      delete section[name]
-    }
-  }
-  if (Object.keys(section).length === 0) {
-    delete pkg[sectionName]
-  }
-}
-
-function main() {
-  const dryRun = process.argv.includes('--dry-run')
-  const projectRoot = process.cwd()
-  const packageJsonPath = path.join(projectRoot, 'package.json')
-  const pkg = readPackageJson(packageJsonPath)
-
-  const removed = []
-  removeFromSection(pkg, 'dependencies', removed)
-  removeFromSection(pkg, 'devDependencies', removed)
-
-  if (removed.length === 0) {
-    console.log('[prune-consumer-deps] No bundled tooling dependencies found to remove.')
-    return
-  }
-
-  console.log('[prune-consumer-deps] Removed entries:')
-  for (const line of removed) {
-    console.log(`  - ${line}`)
-  }
-
-  if (dryRun) {
-    console.log('\n[prune-consumer-deps] Dry run only; package.json was not modified.')
-    return
-  }
-
-  fs.writeFileSync(packageJsonPath, `${JSON.stringify(pkg, null, 2)}\n`, 'utf8')
-  console.log('\n[prune-consumer-deps] Updated package.json. Run pnpm install to refresh lockfile.')
-}
-
-main()