ffc-pay-schemes 1.1.2 → 1.1.3

package/app/scheme-properties/get-siti-agri-schemes.js

@@ -2,14 +2,28 @@ const pillars = require('../constants/pillars')
 const sitiAgriSchemeIds = require('../constants/siti-agri-schemes')
 const schemeNames = require('../constants/scheme-names')
 const sourceSystems = require('../constants/source-systems')
+const schemeIds = require('../constants/scheme-ids')
+
+const schemeKeyById = Object.entries(schemeIds).reduce((acc, [key, value]) => {
+  acc[value] = key
+  return acc
+}, {})
 
 const getSitiAgriSchemes = () =>
-  Object.keys(sitiAgriSchemeIds).map((schemeKey) => ({
-    schemeId: sitiAgriSchemeIds[schemeKey],
-    schemeName: schemeNames[schemeKey],
-    sourceSystem: sourceSystems[schemeKey],
-    pillar: pillars[schemeKey]
-  }))
+  sitiAgriSchemeIds.map((schemeId) => {
+    const schemeKey = schemeKeyById[schemeId]
+
+    if (!schemeKey) {
+      throw new Error(`No scheme metadata found for schemeId: ${schemeId}`)
+    }
+
+    return {
+      schemeId,
+      schemeName: schemeNames[schemeKey],
+      sourceSystem: sourceSystems[schemeKey],
+      pillar: pillars[schemeKey]
+    }
+  })
 
 module.exports = {
   getSitiAgriSchemes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ffc-pay-schemes",
-  "version": "1.1.2",
+  "version": "1.1.3",
   "description": "Module for defining and providing details for the payment schemes supported by the Payment Hub.",
   "main": "index.js",
   "scripts": {

package/test/unit/scheme-properties/get-siti-agri-schemes.test.js

@@ -1,18 +1,42 @@
 const sitiAgriSchemeIds = require('../../../app/constants/siti-agri-schemes')
+const schemeIds = require('../../../app/constants/scheme-ids')
 const schemeNames = require('../../../app/constants/scheme-names')
 const sourceSystems = require('../../../app/constants/source-systems')
 const pillars = require('../../../app/constants/pillars')
 const { getSitiAgriSchemes } = require('../../../app/scheme-properties/get-siti-agri-schemes')
 
+const schemeKeyById = Object.entries(schemeIds).reduce((acc, [key, value]) => {
+  acc[value] = key
+  return acc
+}, {})
+
 describe('getSitiAgriSchemes', () => {
   test('returns one scheme object for each SITI Agri scheme id', () => {
-    const expected = Object.keys(sitiAgriSchemeIds).map((schemeKey) => ({
-      schemeId: sitiAgriSchemeIds[schemeKey],
-      schemeName: schemeNames[schemeKey],
-      sourceSystem: sourceSystems[schemeKey],
-      pillar: pillars[schemeKey]
-    }))
+    const expected = sitiAgriSchemeIds.map((schemeId) => {
+      const schemeKey = schemeKeyById[schemeId]
+
+      expect(schemeKey).toBeDefined()
+
+      return {
+        schemeId,
+        schemeName: schemeNames[schemeKey],
+        sourceSystem: sourceSystems[schemeKey],
+        pillar: pillars[schemeKey]
+      }
+    })
 
     expect(getSitiAgriSchemes()).toEqual(expected)
   })
+
+  test('returns the correct metadata for specific scheme (SFI23)', () => {
+    const schemes = getSitiAgriSchemes()
+    const sfi23 = schemes.find((scheme) => scheme.schemeId === schemeIds.SFI23)
+
+    expect(sfi23).toEqual({
+      schemeId: schemeIds.SFI23,
+      schemeName: schemeNames.SFI23,
+      sourceSystem: sourceSystems.SFI23,
+      pillar: pillars.SFI23
+    })
+  })
 })

package/test-output/cobertura-coverage.xml

@@ -1,20 +1,12 @@
 <?xml version="1.0" ?>
 <!DOCTYPE coverage SYSTEM "http://cobertura.sourceforge.net/xml/coverage-04.dtd">
-<coverage lines-valid="314" lines-covered="312" line-rate="0.9936" branches-valid="67" branches-covered="67" branch-rate="1" timestamp="1791818472377" complexity="0" version="0.1">
+<coverage lines-valid="312" lines-covered="312" line-rate="1" branches-valid="67" branches-covered="67" branch-rate="1" timestamp="1791821370454" complexity="0" version="0.1">
   <sources>
     <source>/home/samplackett/ffc-pay-schemes</source>
   </sources>
   <packages>
-    <package name="constants" line-rate="0.9354" branch-rate="1">
+    <package name="constants" line-rate="1" branch-rate="1">
       <classes>
-        <class name="batch-schemes.js" filename="app/constants/batch-schemes.js" line-rate="0" branch-rate="1">
-          <methods>
-          </methods>
-          <lines>
-            <line number="1" hits="0" branch="false"/>
-            <line number="3" hits="0" branch="false"/>
-          </lines>
-        </class>
         <class name="delivery-bodies.js" filename="app/constants/delivery-bodies.js" line-rate="1" branch-rate="1">
           <methods>
           </methods>