ffc-pay-schemes 1.0.5 → 1.0.6

package/app/constants/unknown.js

@@ -0,0 +1,3 @@
+module.exports = {
+  UNKNOWN: 'Unknown'
+}

package/app/get-scheme-name-from-scheme-id.js

@@ -1,8 +1,9 @@
+const { UNKNOWN } = require('./constants/unknown')
 const { getSchemes } = require('./get-schemes')
 
 const getSchemeNameFromSchemeId = (schemeId) => {
   const matchingScheme = getSchemes().find((scheme) => scheme.schemeId === schemeId)
-  return matchingScheme?.schemeName
+  return matchingScheme?.schemeName ?? UNKNOWN
 }
 
 module.exports = {

package/app/get-source-system-from-scheme-id.js

@@ -1,8 +1,9 @@
+const { UNKNOWN } = require('./constants/unknown')
 const { getSchemes } = require('./get-schemes')
 
 const getSourceSystemFromSchemeId = (schemeId) => {
   const matchingScheme = getSchemes().find((scheme) => scheme.schemeId === schemeId)
-  return matchingScheme?.sourceSystem
+  return matchingScheme?.sourceSystem ?? UNKNOWN
 }
 
 module.exports = {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ffc-pay-schemes",
-  "version": "1.0.5",
+  "version": "1.0.6",
   "description": "Module for defining and providing details for the payment schemes supported by the Payment Hub.",
   "main": "index.js",
   "scripts": {

package/test/unit/get-scheme-name-from-scheme-id.test.js

@@ -4,6 +4,7 @@ jest.mock('../../app/get-schemes', () => ({
 
 const { getSchemes } = require('../../app/get-schemes')
 const { getSchemeNameFromSchemeId } = require('../../app/get-scheme-name-from-scheme-id')
+const { UNKNOWN } = require('../../app/constants/unknown')
 
 describe('getSchemeNameFromSchemeId', () => {
   beforeEach(() => {
@@ -22,7 +23,7 @@ describe('getSchemeNameFromSchemeId', () => {
     expect(getSchemeNameFromSchemeId(1)).toBe('Example Scheme')
   })
 
-  test('returns undefined when the scheme ID is not found', () => {
+  test('returns unknown when the scheme ID is not found', () => {
     getSchemes.mockReturnValue([
       {
         schemeId: 1,
@@ -31,13 +32,13 @@ describe('getSchemeNameFromSchemeId', () => {
       }
     ])
 
-    expect(getSchemeNameFromSchemeId(2)).toBeUndefined()
+    expect(getSchemeNameFromSchemeId(2)).toBe(UNKNOWN)
   })
 
-  test('returns undefined when no schemes are available', () => {
+  test('returns unknown when no schemes are available', () => {
     getSchemes.mockReturnValue([])
 
-    expect(getSchemeNameFromSchemeId(2)).toBeUndefined()
+    expect(getSchemeNameFromSchemeId(2)).toBe(UNKNOWN)
   })
 
   test('gets schemes before searching for the source system', () => {

package/test/unit/get-source-system-from-scheme-id.test.js

@@ -2,6 +2,7 @@ jest.mock('../../app/get-schemes', () => ({
   getSchemes: jest.fn()
 }))
 
+const { UNKNOWN } = require('../../app/constants/unknown')
 const { getSchemes } = require('../../app/get-schemes')
 const { getSourceSystemFromSchemeId } = require('../../app/get-source-system-from-scheme-id')
 
@@ -22,7 +23,7 @@ describe('getSourceSystemFromSchemeId', () => {
     expect(getSourceSystemFromSchemeId(1)).toBe('Example Source')
   })
 
-  test('returns undefined when the scheme ID is not found', () => {
+  test('returns unknown when the scheme ID is not found', () => {
     getSchemes.mockReturnValue([
       {
         schemeId: 1,
@@ -31,13 +32,13 @@ describe('getSourceSystemFromSchemeId', () => {
       }
     ])
 
-    expect(getSourceSystemFromSchemeId(2)).toBeUndefined()
+    expect(getSourceSystemFromSchemeId(2)).toBe(UNKNOWN)
   })
 
-  test('returns undefined when no schemes are available', () => {
+  test('returns unknown when no schemes are available', () => {
     getSchemes.mockReturnValue([])
 
-    expect(getSourceSystemFromSchemeId(2)).toBeUndefined()
+    expect(getSourceSystemFromSchemeId(2)).toBe(UNKNOWN)
   })
 
   test('gets schemes before searching for the source system', () => {

package/test-output/cobertura-coverage.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" ?>
 <!DOCTYPE coverage SYSTEM "http://cobertura.sourceforge.net/xml/coverage-04.dtd">
-<coverage lines-valid="234" lines-covered="219" line-rate="0.9358" branches-valid="50" branches-covered="50" branch-rate="1" timestamp="1787827130090" complexity="0" version="0.1">
+<coverage lines-valid="236" lines-covered="221" line-rate="0.9364" branches-valid="52" branches-covered="52" branch-rate="1" timestamp="1787846748080" complexity="0" version="0.1">
   <sources>
     <source>/home/samplackett/ffc-pay-schemes</source>
   </sources>
@@ -92,21 +92,22 @@
           <methods>
             <method name="(anonymous_0)" hits="4" signature="()V">
               <lines>
-                <line number="3" hits="4"/>
+                <line number="4" hits="4"/>
               </lines>
             </method>
             <method name="(anonymous_1)" hits="2" signature="()V">
               <lines>
-                <line number="4" hits="2"/>
+                <line number="5" hits="2"/>
               </lines>
             </method>
           </methods>
           <lines>
             <line number="1" hits="1" branch="false"/>
-            <line number="3" hits="1" branch="false"/>
-            <line number="4" hits="4" branch="false"/>
+            <line number="2" hits="1" branch="false"/>
+            <line number="4" hits="1" branch="false"/>
             <line number="5" hits="4" branch="false"/>
-            <line number="8" hits="1" branch="false"/>
+            <line number="6" hits="4" branch="true" condition-coverage="100% (2/2)"/>
+            <line number="9" hits="1" branch="false"/>
           </lines>
         </class>
         <class name="get-scheme-names.js" filename="app/get-scheme-names.js" line-rate="1" branch-rate="1">
@@ -341,6 +342,13 @@
             <line number="1" hits="4" branch="false"/>
           </lines>
         </class>
+        <class name="unknown.js" filename="app/constants/unknown.js" line-rate="1" branch-rate="1">
+          <methods>
+          </methods>
+          <lines>
+            <line number="1" hits="1" branch="false"/>
+          </lines>
+        </class>
       </classes>
     </package>
     <package name="ffc-pay-schemes.app.constants.account-codes" line-rate="1" branch-rate="1">