ffc-pay-etl-framework 1.4.5 → 1.4.7

package/app/transformers/faker-transformer.js

@@ -1,44 +1,88 @@
 const { Transform } = require('node:stream')
 
 /**
+ * Creates a Node.js Transform stream that replaces placeholder data with fake data.
  *
  * @param {Object} options
- * @param {Array} options.columns {
- *           columns: [
- *               {
- *                   name: "column-name",
- *                   faker: "company.name"
- *               }
- *           ]
- *       }
- * @param {String} options.locale
- * @returns StreamReader
+ * @param {Array} options.columns List of column names and their mapped Faker methods.
+ * @param {String} options.locale Optional locale string identifier (e.g., 'en', 'de', 'en_IN').
+ * @returns {Transform}
  */
 function fakerTransformer (options) {
   const columns = options.columns
   let faker
-  if (options.locale) {
-    faker = require(`@faker-js/faker/locale/${options.locale}`).faker
-  } else {
-    faker = require('@faker-js/faker').faker
-  }
+  let getFaker
+  let fakerLoadError
+  let fakerLoaded = false
+
+  async function loadFaker () {
+    const { Faker, allLocales, faker: defaultFaker } = await import('@faker-js/faker')
+
+    // Resolve the locale instance safely using the Faker v10 allLocales registry
+    if (options.locale) {
+      const localeKey = options.locale === 'en_IND' ? 'en_IN' : options.locale
+      const selectedLocale = allLocales[localeKey]
 
-  function getFaker (fakerType) {
-    return fakerType.split('.').reduce((a, b) => {
-      return Object.keys(a).length === 0 ? faker[b] : a[b]
-    }, {})
+      if (!selectedLocale) {
+        throw new Error(`Locale "${options.locale}" is not supported by Faker v10.`)
+      }
+
+      faker = new Faker({ locale: selectedLocale })
+    } else {
+      faker = defaultFaker
+    }
+
+    // Modern path resolver using optional chaining to dig down into Faker's Proxy structure
+    getFaker = function (fakerType) {
+      return fakerType.split('.').reduce((current, key) => current?.[key], faker)
+    }
+
+    fakerLoaded = true
   }
 
   return new Transform({
     readableObjectMode: true,
     writableObjectMode: true,
     transform (chunk, _, callback) {
-      const { _columns } = chunk
-      columns.forEach(column => {
-        const colIndex = _columns.indexOf(column.name)
-        chunk[colIndex] = getFaker(column.faker)()
-      })
-      callback(null, chunk)
+      if (fakerLoadError) {
+        callback(fakerLoadError)
+        return
+      }
+
+      const runTransform = async () => {
+        if (!fakerLoaded) {
+          await loadFaker()
+        }
+
+        const { _columns } = chunk
+
+        for (const column of columns) {
+          const colIndex = _columns.indexOf(column.name)
+
+          // Guard: Skip processing if the configured column name doesn't exist in the chunk headers
+          if (colIndex === -1) {
+            continue
+          }
+
+          const fakerMethod = getFaker(column.faker)
+
+          // Guard: Verify that the method exists and can be executed safely
+          if (typeof fakerMethod !== 'function') {
+            throw new TypeError(`Faker method "${column.faker}" is invalid or does not exist.`)
+          }
+
+          chunk[colIndex] = fakerMethod()
+        }
+
+        return chunk
+      }
+
+      runTransform()
+        .then((transformed) => callback(null, transformed))
+        .catch((err) => {
+          fakerLoadError = err
+          callback(err)
+        })
     }
   })
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ffc-pay-etl-framework",
-  "version": "1.4.5",
+  "version": "1.4.7",
   "description": "A framework for creating ETL pipelines in node",
   "main": "index.js",
   "repository": "https://github.com/DEFRA/ffc-pay-etl-framework",
@@ -12,8 +12,8 @@
   ],
   "license": "OGL-UK-3.0",
   "dependencies": {
-    "@faker-js/faker": "8.4.1",
-    "csv-parse": "6.1.0",
+    "@faker-js/faker": "10.5.0",
+    "csv-parse": "7.0.2",
     "sequelize": "6.37.8",
     "validator": "13.15.23"
   },
@@ -28,11 +28,12 @@
   },
   "overrides": {
     "sequelize": {
-      "uuid": "11.1.1"
+      "uuid": "11.1.1",
+      "moment": "2.31.0"
     }
   },
   "scripts": {
-    "test": "jest",
+    "test": "PORT=0 node --experimental-vm-modules node_modules/jest/bin/jest.js --testPathPatterns=test/unit",
     "test:unit": "PORT=0 node --experimental-vm-modules node_modules/jest/bin/jest.js --testPathPatterns=test/unit",
     "test:watch": "jest --watchAll",
     "test:lint": "eslint",